[00:05:54] hmm, is it really Access-Control-Expose-Headers ? [00:06:38] yeah, Access-Control-Allow-Headers is for *request* headers, not *response* headers [00:06:50] er, right [00:06:55] I was looking at allow-headers, ok [00:07:11] was just double-checking https://developer.mozilla.org/en-US/docs/Web/HTTP/Access_control_CORS [00:23:05] gwicke, okay, that works [00:23:37] literally just rh['access-control-expose-headers'] = 'ETag' below the other access-control entries in lib/server.js in restbase [00:44:13] 10VisualEditor, 10Parsoid, 10RESTBase, 6Services: Provide a mechanism in VRS/RESTbase for switching between WT and DOM - https://phabricator.wikimedia.org/T104663#1716955 (10Krenair) I'm wondering about the scope of this ticket now... We seem to have most of the RESTBase parts in place (except {T115165}) a... [07:02:12] 10Citoid: http://dx.doi.org/10.1016/S1360-8592(98)80044-2 produces we couldn't make a citation for you - https://phabricator.wikimedia.org/T115108#1717179 (10Mvolz) @mobrovac, error is "too many redirects" - do we want to increase the number of redirects? Interestingly, this works if you just use the doi instea... [07:03:47] 10Citoid: http://dx.doi.org/10.1016/S1360-8592(98)80044-2 causes a "too many redirects" error - https://phabricator.wikimedia.org/T115108#1717181 (10Mvolz) [07:12:28] 10Citoid: http://dx.doi.org/10.1016/S1360-8592(98)80044-2 causes a "too many redirects" error - https://phabricator.wikimedia.org/T115108#1717185 (10Mvolz) Hmm, weird, I tried this again and this time I got stuck in a redirect loop afterall. Will investigate more later. [07:17:33] 10Citoid: http://dx.doi.org/10.1016/S1360-8592(98)80044-2 causes a "too many redirects" error - https://phabricator.wikimedia.org/T115108#1717186 (10Mvolz) Scratch that, yeah we just need to increase max redirects to get it. [07:23:55] (03CR) 10D3r1ck01: "The patch is ok now. It can be tested and then merged if it has to be." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/244439 (https://phabricator.wikimedia.org/T114857) (owner: 10D3r1ck01) [08:03:08] (03CR) 10Schnark: Blank Edit summary prompt Fix (031 comment) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/244439 (https://phabricator.wikimedia.org/T114857) (owner: 10D3r1ck01) [08:27:22] 10WikiEditor: Wikieditor's search and replace window is unnecessarily large, covers parts of the textarea - https://phabricator.wikimedia.org/T114597#1717206 (10V111P) Here is how I did it (removing the unnecessary vertical padding). It looks really nice that way. (I also added a border because I thought it was... [08:35:46] 10WikiEditor: WikiEditor should remember previous Search & Relace strings - https://phabricator.wikimedia.org/T114598#1717207 (10V111P) Browsers automatically remember text entered into input boxes, so the question is how to make that work with WikiEditor's search and replace input boxes. They need to have name... [10:01:43] 10Citoid: http://dx.doi.org/10.1016/S1360-8592(98)80044-2 causes a "too many redirects" error - https://phabricator.wikimedia.org/T115108#1717256 (10mobrovac) Currently `maxRedirects` is [set to 5](https://github.com/wikimedia/operations-puppet/blob/a7e3fde9b763b0468249dc9faca6ce5d4afc1c4b/modules/citoid/templat... [10:02:09] 10Citoid: Increase maxRedirects to 10 - https://phabricator.wikimedia.org/T115108#1717257 (10mobrovac) p:5Triage>3Normal a:3mobrovac [10:03:03] 10Citoid: Increase maxRedirects to 10 - https://phabricator.wikimedia.org/T115108#1715050 (10mobrovac) 5Open>3stalled Setting as stalled since we need an `ops/puppet` change for that and Opsens are away on an offsite this week. Will tackle that after that. [12:47:57] 10Citoid: Increase maxRedirects to 10 - https://phabricator.wikimedia.org/T115108#1717293 (10Mvolz) Sounds good; the reason the plain doi works and the link one doesn't is because we resolve the former in requestFromDOI; it's a freebie that doesn't count against the limit :). [12:55:09] (03PS1) 10Tchanders: Add documentation for Event mixin to ve.dm.Node [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/244882 [12:56:54] (03CR) 10Jforrester: [C: 032] Add documentation for Event mixin to ve.dm.Node [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/244882 (owner: 10Tchanders) [13:00:34] (03Merged) 10jenkins-bot: Add documentation for Event mixin to ve.dm.Node [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/244882 (owner: 10Tchanders) [13:04:37] 10VisualEditor, 6Editing-Department, 10MediaWiki-extensions-ContentTranslation, 7Design, 7Epic: [Epic] replace plain contenteditable with VisualEditor in ContentTranslation - https://phabricator.wikimedia.org/T105447#1717304 (10Esanders) We have very simple APIs for getting the DM HTML from a surface, an... [13:06:17] edsanders: hi [13:06:30] hey [13:06:35] is https://phabricator.wikimedia.org/T105447#1717304 posted in the right place? [13:07:19] it's in response to "Saving and retrieving. CX does it with DOM. With VE it will have to be something like saving the DM and applying transactions to restore that state of the annotations" [13:07:24] which is in the description of that bug [13:08:45] Do you have a bugs about link editing in CX? I noticed that if you select a whole word and type you lose the link. You also can't copy and paste links so you can't re-order linked words. [13:09:22] David has don't a lot of work with link continuation with VE recently so again this is something you could benefit from [13:16:38] edsanders: yes, a bunch [13:17:12] There's a big question mark on how much effort will the migration to VE require from us. [13:17:18] 10VisualEditor, 6Editing-Department, 10MediaWiki-extensions-ContentTranslation, 7Design, 7Epic: [Epic] replace plain contenteditable with VisualEditor in ContentTranslation - https://phabricator.wikimedia.org/T105447#1717322 (10Esanders) [13:17:35] It's something that I want to do very much, but I don't know how much time will it take. [13:17:37] 10VisualEditor, 6Editing-Department, 10MediaWiki-extensions-ContentTranslation, 7Design, 7Epic: [Epic] replace plain contenteditable with VisualEditor in ContentTranslation - https://phabricator.wikimedia.org/T105447#1444044 (10Esanders) [13:18:05] ok - I added a issues VE would fix, apologies if they're duplicates [13:19:24] yeah, clearly it's not the simplest of tasks, but you have about 10 bugs listed there that it would resolve [13:19:55] and many many more you haven't come across yet [13:21:08] It's probably the equivalent of fixing about 3-5 of the bugs you have listed there in terms of work [13:44:20] 10VisualEditor, 6Editing-Department, 10MediaWiki-extensions-ContentTranslation, 7Design, 7Epic: [Epic] replace plain contenteditable with VisualEditor in ContentTranslation - https://phabricator.wikimedia.org/T105447#1717341 (10Amire80) [13:44:45] 10VisualEditor, 6Editing-Department, 10MediaWiki-extensions-ContentTranslation, 7Design, 7Epic: [Epic] replace plain contenteditable with VisualEditor in ContentTranslation - https://phabricator.wikimedia.org/T105447#1444044 (10Amire80) [13:45:41] 10VisualEditor, 6Editing-Department, 10MediaWiki-extensions-ContentTranslation, 7Design, 7Epic: [Epic] replace plain contenteditable with VisualEditor in ContentTranslation - https://phabricator.wikimedia.org/T105447#1717347 (10Esanders) Also you'll be able to load your current HTML via this same API, so... [14:00:41] 10VisualEditor, 6Editing-Department, 10MediaWiki-extensions-ContentTranslation, 7Design, 7Epic: [Epic] replace plain contenteditable with VisualEditor in ContentTranslation - https://phabricator.wikimedia.org/T105447#1717379 (10Amire80) [14:00:52] 10VisualEditor, 6Editing-Department, 10MediaWiki-extensions-ContentTranslation, 7Design, 7Epic: [Epic] replace plain contenteditable with VisualEditor in ContentTranslation - https://phabricator.wikimedia.org/T105447#1444044 (10Amire80) [14:08:32] 10VisualEditor, 6Editing-Department, 10MediaWiki-extensions-ContentTranslation, 7Design, 7Epic: [Epic] replace plain contenteditable with VisualEditor in ContentTranslation - https://phabricator.wikimedia.org/T105447#1717391 (10Amire80) [14:32:31] 10VisualEditor: On Firefox, insert wikitext on a citation template to create a link generates an incorrect link as long as you didn't save the page - https://phabricator.wikimedia.org/T115089#1717411 (10Pols12) Same issue with Internet Explorer 11 on Windows7. [14:40:57] 10VisualEditor, 10VisualEditor-MediaWiki-Media, 6Multimedia: Media upload dialog reports that file page exists, but not the file, even if the file does exist - https://phabricator.wikimedia.org/T115056#1717412 (10Jdforrester-WMF) [14:42:43] 10VisualEditor: Carriage return marks ↵ shows up among text after a copy/paste - https://phabricator.wikimedia.org/T115007#1717415 (10Jdforrester-WMF) [14:42:45] 10VisualEditor, 10VisualEditor-CopyPaste, 7Browser-Support-Firefox: Pasting into a VE surface in Firefox adds spurious line breaks and nowikis - https://phabricator.wikimedia.org/T104790#1717416 (10Jdforrester-WMF) [14:43:54] 10VisualEditor, 10VisualEditor-EditingTools: VisualEditor: Link inspector does not function correctly after closing it using "Done"/"Remove" button in Firefox while the cursor is never active on CE - https://phabricator.wikimedia.org/T75423#1717418 (10Jdforrester-WMF) 5Open>3Resolved a:3Jdforrester-WMF T... [14:44:04] 10VisualEditor, 10VisualEditor-EditingTools: VisualEditor: Link inspector does not function correctly after closing it using "Done"/"Remove" button in Firefox while the cursor is never active on CE - https://phabricator.wikimedia.org/T75423#1717421 (10Jdforrester-WMF) [14:51:32] (03PS1) 10Esanders: MWLinkAnnotationInspector: Use IndexLayout for internal/external [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/244885 [14:51:34] (03PS1) 10Esanders: MWLinkAnnotationInspector: Close inspector when a search result is clicked [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/244886 [14:58:59] 10VisualEditor, 6Multimedia, 5Patch-For-Review: The drop down for categories in Upload image dialog opens too slowly, even sometimes after moving to the next field - https://phabricator.wikimedia.org/T114945#1717426 (10Jdforrester-WMF) [15:00:19] 10VisualEditor, 10VisualEditor-MediaWiki-Media, 6Multimedia, 5Patch-For-Review: Trying to upload image under blacklisted title in the upload image dialog throws error "" - https://phabricator.wikimedia.org/T114940#1717429 (10Jdforrester-WMF) [15:02:34] 10VisualEditor, 10VisualEditor-MediaWiki-Media, 6Multimedia, 7Design: Provide a way during the upload stage for the user to change their mind about what file to upload once they've started it uploading - https://phabricator.wikimedia.org/T114938#1717432 (10Jdforrester-WMF) p:5Normal>3Low [15:05:17] (03CR) 10Jforrester: [C: 031] "Minor reduction in test coverage (:-() but feels like a good move." [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/241144 (https://phabricator.wikimedia.org/T113797) (owner: 10Divec) [20:35:38] (03PS4) 10D3r1ck01: Blank Edit summary prompt Fix [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/244439 (https://phabricator.wikimedia.org/T114857) [20:56:22] it's "oojs/ui" [20:57:06] legoktm: link me to the repo in gerrit. [20:57:20] um [20:57:28] can you not find it yourself? [20:58:02] legoktm: i can :) [20:59:03] but linking me would have been faster. [20:59:03] okay [21:00:56] legoktm: for the list of authors, should i include the minor/patch contributors? [21:11:57] (03PS1) 10Esanders: MediaDialog: Rename bookletLayout to mediaSettingsBooklet [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/244931 [21:11:58] (03PS1) 10Esanders: Media upload: Only reset upload booklet on dialog setup [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/244932 (https://phabricator.wikimedia.org/T115059) [21:12:00] (03PS1) 10Esanders: Media upload: Hide tabs after first stage of upload booklet [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/244933