[02:30:56] <krrrit-wm>	 (03CR) 10Jforrester: [C: 032] Stop using raw HTML for 'visualeditor-dialog-transclusion-no-template-description' [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/243952 (https://phabricator.wikimedia.org/T87131) (owner: 10Bartosz Dziewoński)
[02:31:15] <wikibugs>	 10VisualEditor, 10VisualEditor-MediaWiki, 7I18n: Message 'visualeditor-dialog-transclusion-no-template-description' uses raw HTML - https://phabricator.wikimedia.org/T87131#1724182 (10Jdforrester-WMF) 5Open>3Resolved
[02:39:52] <krrrit-wm>	 (03Merged) 10jenkins-bot: Stop using raw HTML for 'visualeditor-dialog-transclusion-no-template-description' [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/243952 (https://phabricator.wikimedia.org/T87131) (owner: 10Bartosz Dziewoński)
[08:58:57] <wikibugs>	 10VisualEditor, 6Editing-Department, 10MediaWiki-extensions-ContentTranslation, 7Design, 7Epic: [Epic] replace plain contenteditable with VisualEditor in ContentTranslation - https://phabricator.wikimedia.org/T105447#1724510 (10Amire80)
[09:06:09] <wikibugs>	 10VisualEditor, 10BetaFeatures, 10MediaWiki-extensions-ContentTranslation, 7WorkType-Maintenance: ContentTranslation beta features auto-enrollment doesn't seem to work - https://phabricator.wikimedia.org/T87541#1724543 (10Amire80)
[09:10:39] <wikibugs>	 10VisualEditor, 10BetaFeatures, 10MediaWiki-extensions-ContentTranslation, 7WorkType-Maintenance: ContentTranslation beta features auto-enrollment doesn't seem to work - https://phabricator.wikimedia.org/T87541#1724557 (10Amire80) p:5Normal>3Low
[09:30:16] <aharoni>	 edsanders: hi
[09:30:28] <aharoni>	 the link tool doesn't work on mediawiki.org, in production
[09:30:31] <aharoni>	 known bug?
[09:30:36] <aharoni>	 sounds like an Unbreak Now to me.
[09:32:10] <wikibugs>	 10VisualEditor: link tool doesn't work in VisualEditor in mediawiki.org - https://phabricator.wikimedia.org/T115448#1724593 (10Amire80) 3NEW
[09:47:05] <krrrit-wm>	 (03PS1) 10Prtksxna: Media upload: Initialize booklet before setting file on drag drop [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/246185 (https://phabricator.wikimedia.org/T40031) 
[09:49:49] <krrrit-wm>	 (03PS2) 10Prtksxna: Media upload: Initialize booklet before setting file on drag drop [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/246185 (https://phabricator.wikimedia.org/T40031) 
[09:58:43] <edsanders>	 aharoni, looking
[09:59:14] <edsanders>	 thanks
[10:04:44] <krrrit-wm>	 (03PS1) 10Esanders: Follow-up Id473b45: Call getResults on input widget [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/246188 
[10:05:44] <edsanders>	 Krenair, needs backport ^
[11:01:20] <krrrit-wm>	 (03PS2) 10Esanders: Media upload: Get allowed file extensions and mime types from MW core [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/245961 
[11:01:22] <krrrit-wm>	 (03PS1) 10Esanders: MediaDialog: Reset upload form *before* populating [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/246199 
[11:01:24] <krrrit-wm>	 (03PS1) 10Esanders: Rename ImageTransferHandler to MediaTransferHandler [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/246200 
[11:34:37] <krrrit-wm>	 (03PS2) 10Alex Monk: Follow-up Id473b45: Call getResults on input widget [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/246188 (https://phabricator.wikimedia.org/T115448) (owner: 10Esanders)
[11:37:15] <krrrit-wm>	 (03CR) 10Alex Monk: [C: 032] Follow-up Id473b45: Call getResults on input widget [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/246188 (https://phabricator.wikimedia.org/T115448) (owner: 10Esanders)
[11:37:36] <krrrit-wm>	 (03PS1) 10Alex Monk: Follow-up Id473b45: Call getResults on input widget [extensions/VisualEditor] (wmf/1.27.0-wmf.3) - 10https://gerrit.wikimedia.org/r/246203 (https://phabricator.wikimedia.org/T115448) 
[11:38:16] <krrrit-wm>	 (03CR) 10Esanders: [C: 032] Follow-up Id473b45: Call getResults on input widget [extensions/VisualEditor] (wmf/1.27.0-wmf.3) - 10https://gerrit.wikimedia.org/r/246203 (https://phabricator.wikimedia.org/T115448) (owner: 10Alex Monk)
[11:39:08] <krrrit-wm>	 (03CR) 10Alex Monk: [C: 032] Follow-up Id473b45: Call getResults on input widget [extensions/VisualEditor] (wmf/1.27.0-wmf.3) - 10https://gerrit.wikimedia.org/r/246203 (https://phabricator.wikimedia.org/T115448) (owner: 10Alex Monk)
[11:41:00] <krrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Follow-up Id473b45: Call getResults on input widget [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/246188 (https://phabricator.wikimedia.org/T115448) (owner: 10Esanders)
[11:43:40] <krrrit-wm>	 (03Merged) 10jenkins-bot: Follow-up Id473b45: Call getResults on input widget [extensions/VisualEditor] (wmf/1.27.0-wmf.3) - 10https://gerrit.wikimedia.org/r/246203 (https://phabricator.wikimedia.org/T115448) (owner: 10Alex Monk)
[11:45:47] <krrrit-wm>	 (03CR) 10Alex Monk: [V: 032] Follow-up Id473b45: Call getResults on input widget [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/246188 (https://phabricator.wikimedia.org/T115448) (owner: 10Esanders)
[12:29:29] <krrrit-wm>	 (03CR) 10Alex Monk: [C: 032] MediaDialog: Reset upload form *before* populating [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/246199 (owner: 10Esanders)
[12:30:37] <krrrit-wm>	 (03CR) 10Alex Monk: [C: 032] Rename ImageTransferHandler to MediaTransferHandler [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/246200 (owner: 10Esanders)
[12:32:50] <wikibugs>	 10VisualEditor, 5Patch-For-Review, 5WMF-deploy-2015-10-13_(1.27.0-wmf.3), 5WMF-deploy-2015-10-20_(1.27.0-wmf.4): link tool doesn't work in VisualEditor in mediawiki.org - https://phabricator.wikimedia.org/T115448#1724880 (10Krenair) 5Open>3Resolved a:3Krenair
[12:32:55] <krrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] MediaDialog: Reset upload form *before* populating [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/246199 (owner: 10Esanders)
[12:32:57] <krrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Rename ImageTransferHandler to MediaTransferHandler [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/246200 (owner: 10Esanders)
[12:33:01] <wikibugs>	 10VisualEditor, 5Patch-For-Review, 5WMF-deploy-2015-10-13_(1.27.0-wmf.3), 5WMF-deploy-2015-10-20_(1.27.0-wmf.4): link tool doesn't work in VisualEditor in mediawiki.org - https://phabricator.wikimedia.org/T115448#1724593 (10Krenair) a:5Krenair>3Esanders
[12:37:09] <krrrit-wm>	 (03CR) 10Bartosz Dziewoński: [C: 04-1] "Duplicate of https://gerrit.wikimedia.org/r/#/c/246185/" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/246199 (owner: 10Esanders)
[12:37:18] <krrrit-wm>	 (03CR) 10Bartosz Dziewoński: MediaDialog: Reset upload form *before* populating [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/246199 (owner: 10Esanders)
[12:37:58] <krrrit-wm>	 (03CR) 10Bartosz Dziewoński: [C: 032] Media upload: Initialize booklet before setting file on drag drop [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/246185 (https://phabricator.wikimedia.org/T40031) (owner: 10Prtksxna)
[12:38:00] <MatmaRex>	 :P
[12:41:26] <krrrit-wm>	 (03PS2) 10Bartosz Dziewoński: Rename ImageTransferHandler to MediaTransferHandler [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/246200 (owner: 10Esanders)
[12:41:31] <krrrit-wm>	 (03CR) 10Bartosz Dziewoński: [C: 032] Rename ImageTransferHandler to MediaTransferHandler [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/246200 (owner: 10Esanders)
[12:43:21] <krrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Media upload: Initialize booklet before setting file on drag drop [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/246185 (https://phabricator.wikimedia.org/T40031) (owner: 10Prtksxna)
[12:46:51] <krrrit-wm>	 (03Merged) 10jenkins-bot: Rename ImageTransferHandler to MediaTransferHandler [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/246200 (owner: 10Esanders)
[12:49:33] <krrrit-wm>	 (03PS3) 10Bartosz Dziewoński: Media upload: Initialize booklet before setting file on drag drop [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/246185 (https://phabricator.wikimedia.org/T40031) (owner: 10Prtksxna)
[12:49:44] <krrrit-wm>	 (03CR) 10Bartosz Dziewoński: [C: 032] Media upload: Initialize booklet before setting file on drag drop [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/246185 (https://phabricator.wikimedia.org/T40031) (owner: 10Prtksxna)
[12:52:42] <krrrit-wm>	 (03Merged) 10jenkins-bot: Media upload: Initialize booklet before setting file on drag drop [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/246185 (https://phabricator.wikimedia.org/T40031) (owner: 10Prtksxna)
[12:56:57] <krrrit-wm>	 (03PS2) 10Bartosz Dziewoński: MediaDialog: Reset upload form *before* populating [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/246199 (owner: 10Esanders)
[12:57:14] <krrrit-wm>	 (03Abandoned) 10Bartosz Dziewoński: MediaDialog: Reset upload form *before* populating [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/246199 (owner: 10Esanders)
[12:58:14] <krrrit-wm>	 (03PS3) 10Bartosz Dziewoński: Media upload: Get allowed file extensions and mime types from MW core [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/245961 (owner: 10Esanders)
[15:20:56] <krrrit-wm>	 (03PS1) 10Esanders: Browser tests: Wait for save button to be enabled [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/246247 
[15:27:25] <krrrit-wm>	 (03CR) 10Jforrester: [C: 031] Media upload: Get allowed file extensions and mime types from MW core [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/245961 (owner: 10Esanders)
[15:28:15] <krrrit-wm>	 (03PS2) 10Jforrester: [Browser tests] Wait for save button to be enabled [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/246247 (owner: 10Esanders)
[15:30:40] <wikibugs>	 10VisualEditor, 5WMF-deploy-2015-10-13_(1.27.0-wmf.3), 5WMF-deploy-2015-10-20_(1.27.0-wmf.4): link tool doesn't work in VisualEditor in mediawiki.org - https://phabricator.wikimedia.org/T115448#1725372 (10Jdforrester-WMF)
[15:31:54] <krrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] [Browser tests] Wait for save button to be enabled [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/246247 (owner: 10Esanders)
[15:32:25] <krrrit-wm>	 (03PS1) 10Esanders: DM Surface: Cleanup emission of 'history' event [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/246250 
[15:35:26] <wikibugs>	 10VisualEditor, 10VisualEditor-MediaWiki: 'Save page' is not enabled for a short time (<1s) after the first transaction - https://phabricator.wikimedia.org/T115483#1725390 (10Esanders) 3NEW a:3Esanders
[15:35:36] <krrrit-wm>	 (03PS2) 10Esanders: DM Surface: Cleanup emission of 'history' event [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/246250 (https://phabricator.wikimedia.org/T115483) 
[15:36:37] <krrrit-wm>	 (03CR) 10Esanders: "Hopefully this would be made redundant by Ie36d4b06174f" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/246247 (owner: 10Esanders)
[16:13:41] <Krenair>	 James_F, any thoughts on my comment in https://gerrit.wikimedia.org/r/#/c/245593/ ?
[16:13:47] <Krenair>	 I kind of want it to look like the dialog we give in reverse
[16:14:00] <Krenair>	 But I don't think we can reuse the code at the stage this runs at
[16:14:12] <James_F>	 Krenair: Oh, sorry, yes, I agreed with you but only in my head when reading that. :-)
[16:15:40] <James_F>	 Krenair: On no-change we'd just switch instantly without a prompt, right?
[16:16:06] <Krenair>	 I don't think we can determine whether a change has been made or not
[16:16:59] <James_F>	 Eh.
[16:17:07] <James_F>	 Hash the text box on load?
[16:17:22] <Krenair>	 would have to be kept across previews
[16:18:06] <Krenair>	 I guess we could do that though
[16:18:11] <James_F>	 Eh.
[16:18:22] <James_F>	 Once you've previewed we can assume it's unchanged.
[16:18:31] <James_F>	 Though there are complications like preload.
[16:18:32] <Krenair>	 Can we really?
[16:19:24] <James_F>	 People that preview before they've edited didn't pay enough attention to deserve saving the 3 seconds on switching. :-)
[16:19:39] <Krenair>	 but people that preview after editing
[16:19:58] <James_F>	 If you've edited at all, we have to do the WT' -> VE route.
[16:20:20] <James_F>	 It's only if you've made no changes that we can do the faster thing of just launching VE from scratch.
[16:20:51] <Krenair>	 Once you've previewed we can assume that it's changed.
[16:21:21] <Krenair>	 I think that'll work
[16:22:31] * James_F nods.
[16:22:37] <James_F>	 Oh.
[16:22:41] <James_F>	 I typoed above.
[16:22:45] <James_F>	 Hence the confusion.
[16:22:47] <James_F>	 Sorry. :-)
[16:23:32] <Krenair>	 So anyway, actually displaying the prompt
[16:24:01] <Krenair>	 I don't know if we'll be able to do one exactly like the VE->WE prompt, but we'll see
[16:25:20] <krrrit-wm>	 (03PS1) 10Esanders: Link inspector: Show redlink in suggestions [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/246257 
[16:26:08] <krrrit-wm>	 (03CR) 10Esanders: "Spotted with a browser test!" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/246257 (owner: 10Esanders)
[16:36:05] <krrrit-wm>	 (03CR) 10Alex Monk: [C: 032] Link inspector: Show redlink in suggestions [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/246257 (owner: 10Esanders)
[16:38:02] <wikibugs>	 10VisualEditor, 10VisualEditor-EditingTools: Inspector crashes while trying to open it in a position where another inspector was opened previously - https://phabricator.wikimedia.org/T110378#1725658 (10DLynch) I went off looking, on the assumption that it might be something to do with the link annotations leav...
[16:39:32] <krrrit-wm>	 (03Merged) 10jenkins-bot: Link inspector: Show redlink in suggestions [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/246257 (owner: 10Esanders)
[16:42:44] <James_F>	 edsanders: Gosh, actually using?
[16:43:10] <krrrit-wm>	 (03PS1) 10Esanders: Browser tests: Add API URLs to environments.yml [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/246267 
[16:43:20] <James_F>	 Krenair: You mean because we'll be adding OOUI to use a MessageDialog? The icon for the toolbar button when we build it is an OOUI one.
[16:46:54] <krrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Browser tests: Add API URLs to environments.yml [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/246267 (owner: 10Esanders)
[16:51:36] <edsanders>	 James_F, trying
[16:52:11] <edsanders>	 the lengths they go to make it so that the test definitions are in "plain English" are ridiculous, and totally defeats the purpose
[16:53:34] <edsanders>	 you can write "When I click on the Link Inspector", but then they have a regex somewhere that maps "/When I click on the Link Inspector/" to {link_inspector}.click
[16:54:20] <James_F>	 edsanders: Fun.
[16:54:31] <edsanders>	 And the regexes are in a separate file
[16:54:35] <James_F>	 Of course.
[16:54:40] <edsanders>	 because god forbid someone sees the real code
[16:54:49] <James_F>	 Do any of the tests usefully pass at this point?
[16:55:01] <James_F>	 If so, we could add them to the V+2 pipeline.
[16:55:01] <edsanders>	 mostly
[16:55:06] <edsanders>	 hmm
[16:55:11] <James_F>	 Not all of them, for time/sanity reasons.
[16:55:11] <edsanders>	 they're super slow
[16:55:16] <James_F>	 Yeah.
[16:55:25] <edsanders>	 not least because they teardown and setup between each one
[16:55:31] <edsanders>	 instead of reusing an instance
[16:55:31] <James_F>	 But maybe one or two link ones, and one or two citoid ones?
[16:55:34] * James_F nods.
[16:55:41] <edsanders>	 and the cite ones assume Citoid isn't installed
[16:55:47] <James_F>	 Helpful. :-)
[16:56:21] <edsanders>	 I think the whole suite is 15 minutes+
[16:56:38] <edsanders>	 and it's not that many tests
[16:58:02] <James_F>	 I imagine there's no coverage of e.g. tables.
[16:58:11] <edsanders>	 there's a insert table test
[16:58:35] <James_F>	 OK, it's not that bad, then.
[16:58:42] <edsanders>	     When I click the insert table toolbar element
[16:58:42] <edsanders>	     Then the table should appear
[16:59:01] <edsanders>	 it's just SO STUPID
[16:59:08] <edsanders>	 the code powering that is longer than the definition file
[16:59:16] <edsanders>	 just add comments if it's not clear
[16:59:42] <wikibugs>	 10TemplateData, 6Community-Liaison, 7Documentation: Update Help:TemplateData at mediawiki.org - https://phabricator.wikimedia.org/T94937#1725721 (10Whatamidoing-WMF) 5Open>3Resolved a:3Whatamidoing-WMF Thanks for doing this.  I think that we can declare this done for now.
[17:24:23] <James_F>	 Thalia: Ready when you are.
[17:24:43] <krrrit-wm>	 (03CR) 10Jforrester: [C: 032] Browser tests: Add API URLs to environments.yml [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/246267 (owner: 10Esanders)
[17:28:19] <krrrit-wm>	 (03Merged) 10jenkins-bot: Browser tests: Add API URLs to environments.yml [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/246267 (owner: 10Esanders)
[18:18:18] <wikibugs>	 10Cite, 10Parsoid, 5WMF-deploy-2015-10-06_(1.27.0-wmf.2), 7user-notice: Show an error if a named <ref> is defined multiple times with different content - https://phabricator.wikimedia.org/T85386#1725968 (10Ashot1997) >>! In T85386#1717976, @IKhitron wrote: > Indeed. I solved it a lot of time ago. You shoul...
[18:41:30] <wikibugs>	 10Cite, 10Parsoid, 5WMF-deploy-2015-10-06_(1.27.0-wmf.2), 7user-notice: Show an error if a named <ref> is defined multiple times with different content - https://phabricator.wikimedia.org/T85386#1726038 (10IKhitron) OK. 1. (I already did this for you [[ https://hy.wikipedia.org/wiki/%D5%84%D5%B8%D5%A4%D5%B...
[19:05:20] <krrrit-wm>	 (03CR) 10Jforrester: [C: 032] [Browser tests] Wait for save button to be enabled [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/246247 (owner: 10Esanders)
[19:08:25] <krrrit-wm>	 (03Merged) 10jenkins-bot: [Browser tests] Wait for save button to be enabled [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/246247 (owner: 10Esanders)
[19:22:51] <wikibugs>	 10Citoid: Improve language code validation - https://phabricator.wikimedia.org/T93561#1726078 (10Mvolz)
[19:22:53] <wikibugs>	 10Citoid: "Unknown language" error on it.wp for sources in Italian - https://phabricator.wikimedia.org/T115326#1726077 (10Mvolz)
[19:55:40] <Krenair>	 James_F, so... yeah OO isn't available at this stage
[19:57:18] <James_F>	 Krenair: Add it to the dependency? EditPage load time is already in the multiple seconds, a single cached addition won't hurt much.
[19:58:06] <Krenair>	 James_F, this is the same code that's run on view pages
[19:58:19] <James_F>	 Krenair: Oh, you mean ve init init?
[19:58:23] <Krenair>	 yes
[19:58:32] <James_F>	 Krenair: Rather than the code in WikiEditor?
[19:58:58] <Krenair>	 I wasn't intending to change other extensions
[19:59:01] <Krenair>	 just VE
[20:00:30] <James_F>	 Hmm.
[20:15:08] <krrrit-wm>	 (03PS1) 10Esanders: Revert "[Browser tests] Wait for save button to be enabled" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/246397 
[20:20:43] <krrrit-wm>	 (03CR) 10Esanders: [C: 04-1] Revert "[Browser tests] Wait for save button to be enabled" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/246397 (owner: 10Esanders)
[20:24:59] <James_F>	 edsanders: So… https://integration.wikimedia.org/ci/view/BrowserTests/view/VisualEditor/
[20:26:33] <krrrit-wm>	 (03PS2) 10Esanders: Revert "[Browser tests] Wait for save button to be enabled" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/246397 
[20:27:34] <krrrit-wm>	 (03PS3) 10Esanders: Revert "[Browser tests] Wait for save button to be enabled" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/246397 
[20:29:42] <krrrit-wm>	 (03PS1) 10Esanders: Browser tests: Update link inspector tests [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/246403 
[20:29:44] <krrrit-wm>	 (03PS1) 10Esanders: Browser tests: Fix media insert test [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/246404 
[20:29:46] <krrrit-wm>	 (03PS1) 10Esanders: Browser tests: Fix table test [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/246405 
[20:29:47] <edsanders>	 interesting
[20:29:56] <James_F>	 ?
[20:35:37] <edsanders>	 is that claiming most of our tests are passing?
[20:37:14] <krrrit-wm>	 (03CR) 10Alex Monk: "I'm not sure how we're going to do that without OOjs UI being loaded on page views though." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/245593 (https://phabricator.wikimedia.org/T49779) (owner: 10Alex Monk)
[20:37:28] <edsanders>	 I don't understand those tables
[20:41:31] <James_F>	 edsanders: It says that the jobs are almost entirely failing.
[20:41:47] <edsanders>	 yeah - that sounds about right
[20:42:07] <James_F>	 How many pass locally?
[20:44:10] <edsanders>	 well with the save button bug not many
[20:44:14] <edsanders>	 I didn't run the full suite
[20:45:53] <wikibugs>	 10VisualEditor, 10VisualEditor-MediaWiki, 10GlobalUserPage, 10MediaWiki-extensions-EducationProgram: VisualEditor redlink detection should obey TitleIsAlwaysKnown hook (so that EducationProgram pages and GlobalUserPage links render correctly) - https://phabricator.wikimedia.org/T72123#1726336 (10Jdforrester...
[20:46:14] * James_F nods.
[20:46:26] <James_F>	 As I can't run them I can't really review. :-(
[20:50:08] <James_F>	 RoanKattouw: http://commons.wikimedia.beta.wmflabs.org/wiki/File:Add-constructive.svg
[20:51:26] <RoanKattouw>	 lol, that appears to be because the green color comes from a <style> tag
[20:55:07] * James_F blames MatmaRex. :-)
[20:56:25] <MatmaRex>	 what.
[20:56:28] <MatmaRex>	 oh, yeah, rsvg sucks.
[20:56:42] <James_F>	 MatmaRex: More like our intentional security steps.
[20:57:04] <MatmaRex>	 we do it with a <g style> tag in the PHP RLImageModule
[20:57:25] * James_F nods.
[20:57:28] <James_F>	 Not worth spending time on.
[20:58:12] <MatmaRex>	 although, hmm. it might require <style type="text/css">? or something.
[20:58:14] <MatmaRex>	 whatever
[21:02:50] <krrrit-wm>	 (03CR) 10Jforrester: [C: 032] Educational popups and highlights for links+citations [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/238380 (https://phabricator.wikimedia.org/T108620) (owner: 10Alex Monk)
[21:05:46] <krrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Educational popups and highlights for links+citations [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/238380 (https://phabricator.wikimedia.org/T108620) (owner: 10Alex Monk)
[21:09:39] <wikibugs>	 10VisualEditor, 10VisualEditor-EditingTools: Inspector crashes while trying to open it in a position where another inspector was opened previously - https://phabricator.wikimedia.org/T110378#1726443 (10dchan) We should probably fix this at both ends:  1. Refactor getNodeAndOffset so it doesn't crash in slugles...
[21:14:15] <James_F>	 edsanders: So I 'fixed' "No such file or directory - ../../i18n/.json (Errno::ENOENT)" by changing it to en.json, but…
[21:14:38] <edsanders>	 oh yeah - I made a symlink
[21:14:56] <James_F>	 From what? '.json' -> 'en.json'?
[21:15:28] <James_F>	 edsanders: And now I get "No such file or directory - environments.yml (Errno::ENOENT)"
[21:15:55] <edsanders>	 are you inside the browser folder?
[21:16:04] <James_F>	 Ah, should I be?
[21:16:19] <James_F>	 Aha.
[21:28:05] <krrrit-wm>	 (03PS2) 10Esanders: Browser tests: Fix media insert test [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/246404 
[21:28:07] <krrrit-wm>	 (03PS2) 10Esanders: Browser tests: Fix table test [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/246405 
[21:39:31] <James_F>	 edsanders: I seem to be able to get all the tests to fail on step one, which seems unlikely.
[21:41:12] <edsanders>	 James_F, which test, which step?
[21:41:17] <krrrit-wm>	 (03CR) 10Jforrester: "recheck" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/238380 (https://phabricator.wikimedia.org/T108620) (owner: 10Alex Monk)
[21:41:28] <James_F>	 edsanders: E.g. anon.feature
[21:41:37] <James_F>	   Scenario: Basic edit                                                              # features/anon.feature:4
[21:41:37] <James_F>	     Given I go to the "Anonymous Edit Test" page with content "Anonymous Edit Test" # features/step_definitions/shared_steps.rb:18
[21:41:37] <James_F>	       missing configuration for `mediawiki_password` (MediawikiSelenium::ConfigurationError)
[21:41:38] <edsanders>	 most of the tests are still broken
[21:41:39] <James_F>	       ./features/step_definitions/shared_steps.rb:20:in `/^I go to the "(.+)" page with content "(.+)"$/'
[21:41:41] <James_F>	       features/anon.feature:5:in `Given I go to the "Anonymous Edit Test" page with content "Anonymous Edit Test"'
[21:41:50] <James_F>	 Do you have a sample one that passes?
[21:41:59] <edsanders>	  missing configuration for `mediawiki_password`
[21:42:26] <edsanders>	 I edited environments.yml
[21:42:39] <edsanders>	 made vagrant-host the default
[21:42:54] <edsanders>	 the default is 'beta' but has not password set
[21:43:26] <edsanders>	 you could do export MEDIAWIKI_PASSWORD if you know the password for Selenium_user
[21:43:59] * James_F sighs.
[21:45:47] <Krenair>	 Can't that be found somewhere in jenkins?
[21:46:12] <James_F>	 How do you set the default?
[21:47:00] * James_F just sets the POSIX variable instead.
[21:47:15] <James_F>	 And now it just does nothing, instead.
[21:47:52] <Krenair>	 https://integration.wikimedia.org/ci/credential-store/domain/browsertests/credential/Selenium_user-at-beta.wmflabs.org/update
[21:48:04] <Krenair>	 should give you the password
[21:48:20] <James_F>	 It does, but I don't want to run them on Beta Cluster, I want to run them locally.
[21:48:32] <James_F>	 I did export MEDIAWIKI_ENVIRONMENT=mw-vagrant-host for now.
[21:50:23] <krrrit-wm>	 (03CR) 10Jforrester: [C: 032] Educational popups and highlights for links+citations [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/238380 (https://phabricator.wikimedia.org/T108620) (owner: 10Alex Monk)
[21:52:53] <krrrit-wm>	 (03Merged) 10jenkins-bot: Educational popups and highlights for links+citations [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/238380 (https://phabricator.wikimedia.org/T108620) (owner: 10Alex Monk)
[21:59:34] <krrrit-wm>	 (03CR) 10Jforrester: [C: 032] Revert "[Browser tests] Wait for save button to be enabled" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/246397 (owner: 10Esanders)
[22:04:04] <krrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Revert "[Browser tests] Wait for save button to be enabled" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/246397 (owner: 10Esanders)
[22:15:46] <krrrit-wm>	 (03CR) 10Alex Monk: Educational popups and highlights for links+citations (031 comment) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/238380 (https://phabricator.wikimedia.org/T108620) (owner: 10Alex Monk)
[22:16:34] <krrrit-wm>	 (03PS1) 10Alex Monk: User education popup for citations [extensions/Citoid] - 10https://gerrit.wikimedia.org/r/246428 (https://phabricator.wikimedia.org/T108620) 
[22:16:36] <krrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] User education popup for citations [extensions/Citoid] - 10https://gerrit.wikimedia.org/r/246428 (https://phabricator.wikimedia.org/T108620) (owner: 10Alex Monk)
[22:16:53] <wikibugs>	 10VisualEditor, 10VisualEditor-EditingTools: VisualEditor: When using citation templates, the page title and access date fields should be filled automatically - https://phabricator.wikimedia.org/T58772#1726674 (10Pols12) Is it Citoid ?
[22:24:06] <krrrit-wm>	 (03PS2) 10Alex Monk: User education popup for citations [extensions/Citoid] - 10https://gerrit.wikimedia.org/r/246428 (https://phabricator.wikimedia.org/T108620) 
[22:24:48] <RoanKattouw>	 Krenair: Hmm, I wonder why that happens
[22:25:04] <Krenair>	 why what happens?
[22:25:05] <RoanKattouw>	 Since other popups do still work
[22:25:11] <Krenair>	 the jenkins -1?
[22:25:20] <RoanKattouw>	 No the height:0 problem with the education popup
[22:25:22] <Krenair>	 oh, the oojs ui thing?
[22:25:24] <Krenair>	 ah
[22:25:26] <RoanKattouw>	 (sorry)
[22:25:30] <RoanKattouw>	 (should have given more context)
[22:30:39] <RoanKattouw>	 Krenair: Without that Citoid patch of yours (or without Citoid at all), how can I make an education popup apear in VE?
[22:30:55] <Krenair>	 link inspector
[22:35:10] <RoanKattouw>	 Hmm
[22:35:12] <RoanKattouw>	 Do 
[22:35:22] <RoanKattouw>	 Do I need config to enable it? Or do I need to do special things to trigger it?
[22:35:37] <RoanKattouw>	 (I tried editing in incognito mode and that did get me the welcome dialog, but I didn't notice anything different about the link inspector)
[22:37:37] <Krenair>	 make sure you have no visualeditor-hideusered pref
[22:38:04] <Krenair>	 and no ve-hideusered entry in localstorage
[22:38:13] <Krenair>	 and no ve-hideusered cookie
[23:05:40] <RoanKattouw>	 Oooh I see it
[23:05:50] <RoanKattouw>	 It's on the link inspector *tool*, not the inspector itself
[23:05:58] <RoanKattouw>	 I opened it with Ctrl+K which bypases it
[23:18:26] <RoanKattouw>	 Ahm I think I found a JS error in EducationPopupTool
[23:18:31] <RoanKattouw>	 Is this in production yet?
[23:18:51] <Krenair>	 no
[23:19:01] <RoanKattouw>	 If the hide cookie is set, this.$pulsatingDot is never set, but onSelect accesses it unconditionally
[23:19:03] <Krenair>	 it just got merged within the last few hours
[23:19:17] <RoanKattouw>	 Oh OK
[23:20:22] <RoanKattouw>	 OK so the education popup in the link inspector tool works fine for me if I comment out the setClippableContainer(null) line
[23:20:35] <RoanKattouw>	 Were you having issues with that one, or the Citoid one?
[23:20:48] <RoanKattouw>	 (I'm trying to reproduce the height: 0 issue so I can try to understand why it happens)
[23:20:55] <RoanKattouw>	 Also lemme whip up a patch for that JS error
[23:22:18] <Krenair>	 can you get rid of the extra line in https://gerrit.wikimedia.org/r/#/c/238380/13/modules/ve-mw/ui/tools/ve.ui.MWLinkInspectorTool.js as well please?
[23:22:20] <Krenair>	 I think that height issue pre-dates the Citoid popup
[23:22:52] <RoanKattouw>	 Oh OK
[23:25:44] <RoanKattouw>	 Also I'm guessing the setTimeout() in the constructor is there so we wait for the tool to be appended to the DOM?
[23:27:04] <Krenair>	 before positioning it? yeah
[23:27:52] <RoanKattouw>	 Right :S
[23:28:05] <RoanKattouw>	 I guess there probably isn't proper infrastructure for that right now?
[23:28:19] <RoanKattouw>	 There's Toolbar.initialize but I don't think there's anything that propagates down to the individual tools
[23:28:34] <krrrit-wm>	 (03PS1) 10Catrope: Followup 9d6fbc894e: fix JS error in education popup [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/246441 
[23:29:50] <Krenair>	 did you test that RoanKattouw?
[23:30:21] <Krenair>	 I think what you should really be doing is changing this.$pulsatingDot.is( ':visible' ) to this.$pulsatingDot && this.$pulsatingDot.is( ':visible' )
[23:30:33] <Krenair>	 this code will not call the parent
[23:30:46] <RoanKattouw>	 Oh ahm
[23:30:48] <RoanKattouw>	 I admit I didn't
[23:30:50] <RoanKattouw>	 Looking
[23:31:02] <RoanKattouw>	 Crap, yeah, you're right
[23:33:04] <krrrit-wm>	 (03PS2) 10Catrope: Followup 9d6fbc894e: fix JS error in education popup [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/246441 
[23:34:06] <RoanKattouw>	 Hmm
[23:34:20] <RoanKattouw>	 So when you click "Got it", it doesn't take the action, you have to click the tool again?
[23:34:50] <RoanKattouw>	 I guess for some things that could actually be good
[23:35:16] <RoanKattouw>	 It wasn't what I was expecting initially but it may not be as bad as I first thought