[00:20:51] (03CR) 10Jforrester: [C: 032] Revert "[Browser tests] Wait for save button to be enabled" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/246397 (owner: 10Esanders) [00:22:23] (03CR) 10Jforrester: [C: 031] "Oops." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/246441 (owner: 10Catrope) [00:23:07] (03CR) 10Jforrester: [C: 031] User education popup for citations [extensions/Citoid] - 10https://gerrit.wikimedia.org/r/246428 (https://phabricator.wikimedia.org/T108620) (owner: 10Alex Monk) [00:24:09] (03Merged) 10jenkins-bot: Revert "[Browser tests] Wait for save button to be enabled" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/246397 (owner: 10Esanders) [00:26:30] (03CR) 10Jforrester: [C: 032] Browser tests: Fix table test [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/246405 (owner: 10Esanders) [00:26:58] (03CR) 10Jforrester: [C: 032] Browser tests: Fix media insert test [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/246404 (owner: 10Esanders) [00:27:11] (03CR) 10Jforrester: [C: 032] "Can't make them work less." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/246403 (owner: 10Esanders) [00:30:43] (03Merged) 10jenkins-bot: Browser tests: Update link inspector tests [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/246403 (owner: 10Esanders) [00:30:46] (03Merged) 10jenkins-bot: Browser tests: Fix media insert test [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/246404 (owner: 10Esanders) [00:32:56] (03Merged) 10jenkins-bot: Browser tests: Fix table test [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/246405 (owner: 10Esanders) [00:36:14] (03CR) 10Alex Monk: [C: 032] Followup 9d6fbc894e: fix JS error in education popup [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/246441 (owner: 10Catrope) [00:38:50] (03Merged) 10jenkins-bot: Followup 9d6fbc894e: fix JS error in education popup [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/246441 (owner: 10Catrope) [01:47:56] 10VisualEditor, 10Graph-VisualEditor, 5Patch-For-Review, 5WMF-deploy-2015-10-20_(1.27.0-wmf.4): Edit graph padding in VisualEditor - https://phabricator.wikimedia.org/T113856#1727206 (10ferdbold) 5Open>3Resolved [02:13:20] (03CR) 10Divec: "@Esanders , does this look mergeable?" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/241144 (https://phabricator.wikimedia.org/T113797) (owner: 10Divec) [02:45:41] How would I proceed if I want to add an item to the VE toolbar (specifically, a sub-item to the Insert menu) [02:52:48] I understand it has to do with commands and the command registry, I think I just need some good examples [07:06:57] (03PS7) 10Mvolz: Introducing template format [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/243138 (https://phabricator.wikimedia.org/T64217) (owner: 10Eranroz) [10:08:19] 10VisualEditor, 10VisualEditor-ContentEditable, 10MediaWiki-Gallery: Gallery popup should be stable - https://phabricator.wikimedia.org/T113837#1727591 (10Juandev) I am not sure, that it is a duplicate of that bug. Moreover, that bug is resolved, but this problem is still happening e.g. yeasterday on cs.wp. [10:10:43] !time [10:10:48] @time [10:11:15] hey bots dont be lazy [10:12:26] it' about 10:12:25 Juandev [10:12:29] 10VisualEditor, 6Editing-Analysis, 6Editing-Department: Investigate why visual editor users have a higher save rate in EventLogging data but didn't in the A/B test - https://phabricator.wikimedia.org/T108241#1727604 (10Alsee) What you're seeing on the edit analysis dashboard is that editors using wikitext op... [10:13:12] Krenair: I wonder what is the time in US, so probably 4 am on the east coast [10:13:36] Krenair: is it allready time to set bugs for within project file upload? [10:13:43] In SF it's usually 8 hours behind [10:13:49] But things get complicated in March/October, so... [10:14:08] Oh, sorry, looks like it's going to be the start of November that the confusion begins this year [10:15:17] or not, because we go back earlier. sigh [10:15:25] it's the other way around in march I think [10:16:15] October 25th through to the 1st will have the -7 difference [10:16:29] (03PS3) 10Esanders: Make data-mw/body.html attribute comparable [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/240722 [10:17:19] ummm maybe foundatioun should open the office in europe also:-) [10:19:07] so anyway, what was the question exactly? [10:19:21] can you file bugs for file uploads yet? [10:20:14] (03CR) 10jenkins-bot: [V: 04-1] Make data-mw/body.html attribute comparable [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/240722 (owner: 10Esanders) [10:20:58] (03PS4) 10Esanders: Make data-mw/body.html attribute comparable [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/240722 [10:21:45] 10VisualEditor, 10VisualEditor-MediaWiki, 7Design, 7Epic: Provide a single edit tab which has both visual and wikitext modes and allows on-the-fly switching between them - https://phabricator.wikimedia.org/T102398#1727657 (10Alsee) If the two edit buttons are merged, with mode-switching button inside the e... [10:24:45] (03CR) 10jenkins-bot: [V: 04-1] Make data-mw/body.html attribute comparable [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/240722 (owner: 10Esanders) [10:44:04] 10Citoid: Improve language code validation - https://phabricator.wikimedia.org/T93561#1727681 (10Elitre) Hey @mvolz, I guess that [[ https://www.mediawiki.org/w/index.php?title=Topic:Sgikbv81nxsv7oy6&topic_showPostId=sqt0thxnx0gx69xc#flow-post-sqt0thxnx0gx69xc | this report ]] by a Polish Wikipedian also belongs... [11:08:41] Krenair: yep [11:09:06] Krenair: like "date" you can load from exif, who knows what you mean, when you ask for date! [11:53:42] 10VisualEditor, 10Phlogiston, 3Discovery-Analysis-Sprint, 3Team-Practices-This-Week: Help requested from an R expert to help tweak phlogiston (burnup chart scripts) - https://phabricator.wikimedia.org/T110080#1727801 (10Ironholds) >>! In T110080#1651403, @JAufrecht wrote: > Sorry for the delay. I could de... [12:05:34] 10TemplateData: TemplateData doesn't let you have conditional meanings of parameters based on other parameters - https://phabricator.wikimedia.org/T51743#1727808 (10Trizek-WMF) Based [[ https://fr.wikipedia.org/wiki/Wikip%C3%A9dia:%C3%89diteurVisuel/Avis#infobox_logiciel | on a discussion on frwp ]], it appears... [12:42:32] 10VisualEditor, 6Editing-Department, 10MediaWiki-extensions-ContentTranslation, 7Design, 7Epic: [Epic] replace plain contenteditable with VisualEditor in ContentTranslation - https://phabricator.wikimedia.org/T105447#1727919 (10Amire80) [13:39:29] 10VisualEditor, 10VisualEditor-MediaWiki-References: Make it easy to find existing citations in the body of an article - https://phabricator.wikimedia.org/T110364#1728047 (10Trizek-WMF) [[https://fr.wikipedia.org/wiki/Wikip%C3%A9dia:%C3%89diteurVisuel/Avis#Lien_entre_section_r.C3.A9f.C3.A9rence_et_ref_dans_le_... [14:49:29] (03PS1) 10Esanders: Browser tests: Fix selectors for strikethrough and underline [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/246683 [15:00:59] (03CR) 10Jforrester: [C: 032] "Yay language specificity." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/246683 (owner: 10Esanders) [15:03:45] (03Merged) 10jenkins-bot: Browser tests: Fix selectors for strikethrough and underline [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/246683 (owner: 10Esanders) [15:12:39] (03CR) 10Esanders: [C: 04-1] "Yep, one naming suggestion" (031 comment) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/241144 (https://phabricator.wikimedia.org/T113797) (owner: 10Divec) [15:18:04] (03PS14) 10Divec: De-Houdini-fy the handling of observed DOM changes [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/241144 (https://phabricator.wikimedia.org/T113797) [15:20:52] 10VisualEditor, 10MediaWiki-General-or-Unknown: The Web visual editor forgets to save the change of case in the link - https://phabricator.wikimedia.org/T115617#1728314 (10Nnemo) 3NEW [15:22:19] 10VisualEditor, 10MediaWiki-General-or-Unknown: The Web visual editor forgets to save the change of case in the link - https://phabricator.wikimedia.org/T115617#1728314 (10Nnemo) [15:23:12] (03CR) 10Divec: "Done method rename, and rebased" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/241144 (https://phabricator.wikimedia.org/T113797) (owner: 10Divec) [15:28:56] (03PS15) 10Divec: De-Houdini-fy the handling of observed DOM changes [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/241144 (https://phabricator.wikimedia.org/T113797) [15:29:13] (03CR) 10Divec: "Rebased" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/241144 (https://phabricator.wikimedia.org/T113797) (owner: 10Divec) [15:40:00] 10VisualEditor, 10MediaWiki-General-or-Unknown: The Web visual editor fails to erase the character - https://phabricator.wikimedia.org/T115618#1728327 (10Nnemo) 3NEW [15:56:59] 10VisualEditor: Problem with copying bulletlists visualeditor - https://phabricator.wikimedia.org/T115620#1728369 (10benjli) 3NEW a:3Amire80 [16:29:04] 10VisualEditor, 10VisualEditor-MediaWiki, 5Patch-For-Review, 5WMF-deploy-2015-10-20_(1.27.0-wmf.4), 7user-notice: On user's first use of VE-MW, provide a couple of educational pop-ups for links and for citations with some toolbar highlights to trigger the... - https://phabricator.wikimedia.org/T108620#1728479 [16:44:07] (03PS1) 10DLynch: Run renderContents before finding nodes by offset [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/246702 [16:46:31] (03PS2) 10DLynch: Run renderContents before finding nodes by offset [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/246702 (https://phabricator.wikimedia.org/T110378) [16:57:37] 10VisualEditor, 10VisualEditor-EditingTools, 5Patch-For-Review: Inspector crashes while trying to open it in a position where another inspector was opened previously - https://phabricator.wikimedia.org/T110378#1728596 (10DLynch) So, that's one approach to task 1. It's sort of the brute-force approach, but it... [17:20:31] Krinkle, are you aware of this http://www.techinsight.io/review/devops-and-automation/browser-automation-using-selenium-webdriver-and-nodejs/ [17:20:38] and is there any reason we can't use it? [17:54:46] 10VisualEditor, 10VisualEditor-Media: Dragging an image to the top of an association list (aka definition list) breaks the list formatting - https://phabricator.wikimedia.org/T115635#1728773 (10Jdforrester-WMF) [17:54:52] 10VisualEditor: Problem with copying bulletlists visualeditor - https://phabricator.wikimedia.org/T115620#1728776 (10Esanders) Can you provide a snippet of what you see when you click "Review changes". Are *all* spaces changed, or just ones inside links. If it's just inside links then spaces and _ are equivalent... [17:56:15] 10VisualEditor: Problem with copying bulletlists visualeditor - https://phabricator.wikimedia.org/T115620#1728777 (10Amire80) a:5Amire80>3None [17:56:45] 10VisualEditor: Problem with copying bulletlists visualeditor - https://phabricator.wikimedia.org/T115620#1728779 (10Esanders) Looks like some links being normalised with underscores: https://he.wikipedia.org/w/index.php?title=%D7%A7%D7%9C%D7%90%D7%95%D7%A0%D7%99%D7%99%D7%9D&type=revision&diff=17611433&oldid=161... [17:57:18] 10VisualEditor: Spaces converted to underscores sometimes when copying links - https://phabricator.wikimedia.org/T115620#1728781 (10Esanders) p:5Triage>3Low [17:59:43] 10VisualEditor, 10MediaWiki-General-or-Unknown: The Web visual editor fails to erase the character - https://phabricator.wikimedia.org/T115618#1728783 (10Esanders) [17:59:45] 10VisualEditor, 10VisualEditor-MediaWiki-Mobile, 7Browser-Support-Google-Chrome: VisualEditor Mobile: Chrome for mobile keyboard doesn't fire useful key events for backspace - https://phabricator.wikimedia.org/T69262#1728784 (10Esanders) [18:04:22] (03PS1) 10Amire80: [i18] Change "wiki article" to "wiki page" for consistency [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/246713 [18:05:31] (03CR) 10Jforrester: [C: 04-1] "This language got Comms sign-off. I'd rather not go through that again. Also this is first-run welcoming language; though you can link to " [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/246713 (owner: 10Amire80) [18:05:34] 10VisualEditor, 10VisualEditor-MediaWiki-Links: [Regression ?] Cannot escape out of the blue highlight of a newly created link even after explicitly clicking outside of it - https://phabricator.wikimedia.org/T114802#1728794 (10Esanders) When you click at the end of a link the browser chooses on side of the 10VisualEditor, 10VisualEditor-MediaWiki-Links: Cannot place cursor on a specific side of the link cartouche with the mouse - https://phabricator.wikimedia.org/T114802#1728795 (10Esanders) [18:10:03] 10VisualEditor, 10VisualEditor-ContentEditable, 10VisualEditor-Links, 10VisualEditor-MediaWiki-Links: Cannot place cursor on a specific side of the link cartouche with the mouse - https://phabricator.wikimedia.org/T114802#1728798 (10Jdforrester-WMF) p:5Triage>3Low [18:45:18] 10TemplateData: Enable multiline descriptions : allow line breaks with \n or
- https://phabricator.wikimedia.org/T115641#1728880 (10Pols12) 3NEW [18:45:47] 10VisualEditor, 10VisualEditor-CopyPaste: Spaces converted to underscores sometimes when copying links - https://phabricator.wikimedia.org/T115620#1728893 (10Jdforrester-WMF) [19:21:04] 10VisualEditor, 10VisualEditor-EditingTools: VisualEditor: Image should not change size when going from read to edit - https://phabricator.wikimedia.org/T69047#1729012 (10Pols12) This issue has been pointed on fr.wp too. With the given example I see the image 1.66 bigger while reading than while editing. [19:26:09] 10Cite, 10Parsoid, 5WMF-deploy-2015-10-06_(1.27.0-wmf.2), 7user-notice: Show an error if a named is defined multiple times with different content - https://phabricator.wikimedia.org/T85386#1729027 (10matmarex) >>! In T85386#1716636, @Ashot1997 wrote: > Hi, thanks for this great idea. But in not latin... [19:26:32] Krenair: do you think you could merge https://gerrit.wikimedia.org/r/#/c/244194/ ? [19:27:13] no [19:27:36] Usually when I give +1 like this it's because someone asked me to review but I didn't feel comfortable with merging [19:28:18] hmph. [19:29:07] edsanders: ping about https://phabricator.wikimedia.org/T112290#1716082 ? [19:40:45] (03CR) 10Bartosz Dziewoński: [C: 04-1] "I think it'd be better to use the list of files allowed on the local wiki, rather than hard-coded. In third-party scenarios the uploads wi" (031 comment) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/245961 (owner: 10Esanders) [20:14:22] (03CR) 10Esanders: "The fall back between foreign upload to local upload is not finished yet. Currently only foreign upload works, so we need to have the list" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/245961 (owner: 10Esanders) [20:15:10] (03CR) 10Esanders: Media upload: Get allowed file extensions and mime types from MW core (031 comment) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/245961 (owner: 10Esanders) [20:20:32] (03CR) 10Bartosz Dziewoński: "It works perfectly fine for me." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/245961 (owner: 10Esanders) [21:12:33] (03PS1) 10Esanders: EducationPopup: Tidy up DOM and CSS [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/246784 [21:15:35] (03CR) 10Alex Monk: [C: 04-1] EducationPopup: Tidy up DOM and CSS (031 comment) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/246784 (owner: 10Esanders) [21:15:43] (03CR) 10jenkins-bot: [V: 04-1] EducationPopup: Tidy up DOM and CSS [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/246784 (owner: 10Esanders) [21:17:25] 10VisualEditor, 10VisualEditor-MediaWiki-Media, 10Parsoid: Parsoid/VE adds images with pointless link parameter - https://phabricator.wikimedia.org/T108504#1729510 (10ssastry) See >>! In T108504#1593835, @Esanders wrote: > Can't reproduce - is this a common occurence? https://en.wikipedia.org/w/index.php?... [21:26:34] 10Cite, 10Parsoid, 5WMF-deploy-2015-10-06_(1.27.0-wmf.2), 7user-notice: Show an error if a named is defined multiple times with different content - https://phabricator.wikimedia.org/T85386#1729558 (10Ashot1997) @IKhitron, thank you very much, it works fine. Displaying the error message next to the af... [21:35:41] (03PS2) 10Esanders: EducationPopup: Tidy up DOM and CSS [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/246784 [21:35:43] (03CR) 10Esanders: EducationPopup: Tidy up DOM and CSS (031 comment) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/246784 (owner: 10Esanders) [21:37:40] (03PS1) 10Tchanders: WIP Make new error element [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/246789 [21:44:11] (03PS2) 10Tchanders: WIP Make new error element [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/246789 [21:47:27] (03CR) 10Catrope: [C: 04-1] WIP Make new error element (035 comments) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/246789 (owner: 10Tchanders) [21:48:32] 10VisualEditor, 10Math: Make math syntax helper dialog - https://phabricator.wikimedia.org/T114163#1729626 (10Nirzar) @Jdforrester-WMF @Tchanders https://phabricator.wikimedia.org/M96/285/ what about something like this? tabs on top to scroll to the correct section of the vertical list. the tabs represent t... [21:53:14] (03CR) 10Esanders: WIP Make new error element (032 comments) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/246789 (owner: 10Tchanders) [22:13:57] (03CR) 10Esanders: WIP Make new error element (034 comments) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/246789 (owner: 10Tchanders) [22:21:26] (03CR) 10Alex Monk: [C: 032] EducationPopup: Tidy up DOM and CSS [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/246784 (owner: 10Esanders) [22:24:24] (03Merged) 10jenkins-bot: EducationPopup: Tidy up DOM and CSS [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/246784 (owner: 10Esanders) [23:25:25] (03PS1) 10Alex Monk: Education popup dot changes [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/246799 [23:25:53] nzr, ^ [23:41:40] (03CR) 10Catrope: [C: 04-1] Education popup dot changes (031 comment) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/246799 (owner: 10Alex Monk) [23:42:07] Krenair: Does pulsatingDot overlap stillDot or something? [23:42:16] * RoanKattouw admits to being lazy and not having downloaded the patch [23:42:23] yes [23:43:04] (03PS2) 10Alex Monk: Education popup dot changes [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/246799