[00:04:37] <krrrit-wm>	 (03PS4) 10Alex Monk: [WIP][POC][DONOTMERGE] Allow switching from wikitext to VE [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/245593 (https://phabricator.wikimedia.org/T49779) 
[00:04:39] <krrrit-wm>	 (03PS1) 10Alex Monk: Make the wikitext switch confirmation dialog indepedent of the target [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/247484 
[00:04:41] <krrrit-wm>	 (03PS1) 10Alex Monk: [WIP] Dialog for switching between wikitext and visual editing [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/247485 
[00:04:46] <krrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] [WIP][POC][DONOTMERGE] Allow switching from wikitext to VE [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/245593 (https://phabricator.wikimedia.org/T49779) (owner: 10Alex Monk)
[00:04:48] <krrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] [WIP] Dialog for switching between wikitext and visual editing [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/247485 (owner: 10Alex Monk)
[00:04:53] <Krenair>	 go away jenkins
[00:06:28] <James_F>	 :-)
[00:06:38] <krrrit-wm>	 (03PS2) 10Alex Monk: [WIP] Dialog for switching between wikitext and visual editing [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/247485 
[00:06:40] <krrrit-wm>	 (03PS2) 10Alex Monk: Make the wikitext switch confirmation dialog indepedent of the target [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/247484 
[00:06:43] <krrrit-wm>	 (03PS5) 10Alex Monk: [WIP][POC][DONOTMERGE] Allow switching from wikitext to VE [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/245593 (https://phabricator.wikimedia.org/T49779) 
[00:06:50] <Krenair>	 It failed to rebase over the scrubWikitext -> scrub_wikitext change James_F 
[00:07:12] <James_F>	 That's pretty lame.
[00:07:27] <Krenair>	 I have a feeling that horrible hack in the switch dialog might've been due to waiting for the dialog to close when you press 'keep'
[00:07:31] <Krenair>	 I may just use a separate dialog instead
[00:07:38] <James_F>	 :-(
[00:07:41] <James_F>	 At least re-use the i18n
[00:09:06] <Krenair>	 Oh, we do need to add a way to get rid of the 'keep' option if the wiki does not support it, I guess
[00:09:42] <Krenair>	 and maybe squash that other dialog commit into the main one
[00:10:24] <krrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] [WIP] Dialog for switching between wikitext and visual editing [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/247485 (owner: 10Alex Monk)
[00:11:12] <Krenair>	 there is a dialog which shows now though
[00:11:15] <Krenair>	 so progress, sort of
[00:13:28] <krrrit-wm>	 (03PS3) 10Alex Monk: [WIP] Dialog for switching between wikitext and visual editing [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/247485 
[00:22:02] <Krenair>	 James_F, what to do about https://phabricator.wikimedia.org/T104663 ?
[00:22:28] <James_F>	 Krenair: I dunno.
[00:22:31] * James_F heads off.
[00:22:32] <Krenair>	 RESTBase seems to have added the bits necessary, VRS doesn't need changes
[00:22:33] <Krenair>	 k
[00:23:12] <wikibugs>	 10VisualEditor, 10VisualEditor-MediaWiki, 10WikiEditor, 10RESTBase, and 3 others: Provide a way for the user to switch between VisualEditor and wikitext source editor modes without saving - https://phabricator.wikimedia.org/T49779#1737139 (10Krenair)
[00:23:15] <wikibugs>	 10VisualEditor, 10Parsoid, 10RESTBase, 6Services: Provide a mechanism in VRS/RESTbase for switching between WT and DOM - https://phabricator.wikimedia.org/T104663#1737137 (10Krenair) 5Open>3Resolved a:5Krenair>3mobrovac
[01:37:56] <grrrit-wm>	 (03PS1) 10Krinkle: build: Use my gmail address for attribution [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/247498 
[01:38:37] <grrrit-wm>	 (03PS1) 10Krinkle: build: Use my gmail address for attribution [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/247499 
[01:46:22] <grrrit-wm>	 (03CR) 10Jforrester: [C: 032] build: Use my gmail address for attribution [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/247498 (owner: 10Krinkle)
[01:46:34] <grrrit-wm>	 (03CR) 10Jforrester: [C: 032] build: Use my gmail address for attribution [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/247499 (owner: 10Krinkle)
[01:46:39] <Krinkle>	 James_F|Away: Thx
[01:52:28] <grrrit-wm>	 (03Merged) 10jenkins-bot: build: Use my gmail address for attribution [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/247498 (owner: 10Krinkle)
[01:57:28] <grrrit-wm>	 (03Merged) 10jenkins-bot: build: Use my gmail address for attribution [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/247499 (owner: 10Krinkle)
[06:44:57] <grrrit-wm>	 (03PS1) 10Divec: Update my .mailmap and AUTHORS.txt entries [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/247516 
[07:52:49] <grrrit-wm>	 (03PS1) 10DLynch: ce.Surface afterKeyDown to better cope with adjacent grouped nodes [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/247519 (https://phabricator.wikimedia.org/T114545) 
[08:15:12] <grrrit-wm>	 (03CR) 10Siebrand: [C: 031] "i18n/L10n reviewed." [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/243138 (https://phabricator.wikimedia.org/T64147) (owner: 10Eranroz)
[08:20:13] <grrrit-wm>	 (03CR) 10Divec: "Thanks, this changeset reveals the actual root cause is a coding error, which we hadn't suspected." (031 comment) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/247519 (https://phabricator.wikimedia.org/T114545) (owner: 10DLynch)
[08:41:30] <wikibugs>	 10VisualEditor, 10MediaWiki-Vagrant, 10Parsoid, 10RESTBase, and 2 others: Update vagrant to use VRS to configure VisualEditor/Flow - https://phabricator.wikimedia.org/T111223#1737531 (10mobrovac) 5Open>3Resolved Landed in MW-Vagrant, and so VE's role now works out of the box.
[08:42:22] <wikibugs>	 10VisualEditor, 10MediaWiki-Vagrant, 10Parsoid, 10RESTBase, 6Services: Update vagrant to use VRS to configure VisualEditor/Flow - https://phabricator.wikimedia.org/T111223#1737533 (10mobrovac)
[08:44:13] <grrrit-wm>	 (03PS2) 10DLynch: ce.Surface afterKeyDown shouldn't assume .contenteditable is boolean [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/247519 (https://phabricator.wikimedia.org/T114545) 
[08:46:07] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] ce.Surface afterKeyDown shouldn't assume .contenteditable is boolean [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/247519 (https://phabricator.wikimedia.org/T114545) (owner: 10DLynch)
[08:53:47] <grrrit-wm>	 (03PS3) 10DLynch: ce.Surface afterKeyDown shouldn't assume .contenteditable is boolean [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/247519 (https://phabricator.wikimedia.org/T114545) 
[08:55:40] <grrrit-wm>	 (03CR) 10Divec: "@Krinkle , is there a good reason to do" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/247519 (https://phabricator.wikimedia.org/T114545) (owner: 10DLynch)
[09:05:13] <grrrit-wm>	 (03CR) 10Divec: [C: 031] "I'm happy with this, aside from the isContentEditable question for @Krinkle ." (031 comment) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/247519 (https://phabricator.wikimedia.org/T114545) (owner: 10DLynch)
[09:21:50] <wikibugs>	 10VisualEditor, 6Multimedia, 7Design: Insert image in content after it's uploaded  - https://phabricator.wikimedia.org/T115865#1737611 (10Esanders)
[09:23:44] <wikibugs>	 10VisualEditor, 6Multimedia, 7Design: Insert image in content after it's uploaded - https://phabricator.wikimedia.org/T115865#1734858 (10Esanders) Removed "use image description as caption" as that is a matter for the parent bug.  I agree we shouldn't have the image metadata page, but currently the upload fl...
[09:32:48] <wikibugs>	 10VisualEditor, 10VisualEditor-EditingTools, 5Patch-For-Review: When inserting an image, set its caption by default to be the Commons image description - https://phabricator.wikimedia.org/T53032#1737649 (10Esanders)
[09:34:20] <wikibugs>	 10VisualEditor, 10VisualEditor-EditingTools, 5Patch-For-Review: When inserting an image, set its caption by default to be the Commons image description - https://phabricator.wikimedia.org/T53032#1737653 (10Esanders) >>! In T53032#1390028, @Whatamidoing-WMF wrote: > Inserting the author (if machine-readable)...
[09:35:15] <wikibugs>	 10VisualEditor, 10VisualEditor-EditingTools, 5Patch-For-Review: When inserting an image, set its caption by default to be the Commons image description - https://phabricator.wikimedia.org/T53032#1737655 (10Esanders)
[09:35:17] <wikibugs>	 10VisualEditor, 6Multimedia, 7Design: Insert image in content after it's uploaded - https://phabricator.wikimedia.org/T115865#1737654 (10Esanders)
[09:40:27] <wikibugs>	 10VisualEditor, 6Multimedia, 7Design: Insert image in content after it's uploaded - https://phabricator.wikimedia.org/T115865#1737696 (10Esanders) So I've marked this as blocked by T53032 but our case is slightly simpler because we're dealing with a new image so we know the description won't contain a bunch...
[12:39:20] <wikibugs>	 10VisualEditor, 10VisualEditor-EditingTools, 5Patch-For-Review: When inserting an image, set its caption by default to be the Commons image description - https://phabricator.wikimedia.org/T53032#1738011 (10Pginer-WMF)  In reply to @Esanders comment on the duplicated ticket (T115864):  > The main issue I had...
[13:49:13] <grrrit-wm>	 (03PS1) 10Prtksxna: Use mw.Upload.Dialog to upload and insert file [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/247563 
[13:49:48] <grrrit-wm>	 (03CR) 10Prtksxna: [C: 04-1] "* i18n" [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/247563 (owner: 10Prtksxna)
[13:50:24] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Use mw.Upload.Dialog to upload and insert file [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/247563 (owner: 10Prtksxna)
[13:53:55] <grrrit-wm>	 (03CR) 10Prtksxna: "Use Idd391382292f31d0570a6548c3b89d5e3795e832" [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/247563 (owner: 10Prtksxna)
[14:03:49] <grrrit-wm>	 (03CR) 10Bartosz Dziewoński: "Looks good to me, just needs the details you mentioned. Also left a comment inline." (031 comment) [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/247563 (owner: 10Prtksxna)
[14:06:20] <grrrit-wm>	 (03CR) 10Bartosz Dziewoński: "Also needs a link to the associated task :)" [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/247563 (owner: 10Prtksxna)
[14:18:06] <wikibugs>	 10VisualEditor, 10VisualEditor-MediaWiki, 10SyntaxHighlight: Consider converting the Language selector drop-down in SyntaxHighlight VE from a combo-box to a drop-down since we are not letting user insert any other language - https://phabricator.wikimedia.org/T114201#1738193 (10Esanders) 5Open>3declined a...
[14:47:29] <wikibugs>	 10VisualEditor: Show sequence shortcuts in the help dialog (CommandHelpDialog) - https://phabricator.wikimedia.org/T116013#1738351 (10Esanders) 3NEW
[14:53:28] <wikibugs>	 10VisualEditor: Show sequence shortcuts in the help dialog (CommandHelpDialog) - https://phabricator.wikimedia.org/T116013#1738392 (10Esanders)
[14:56:17] <wikibugs>	 10VisualEditor: Show sequence shortcuts in the help dialog (CommandHelpDialog) - https://phabricator.wikimedia.org/T116013#1738402 (10Esanders) Potentially some of these can be merged with their existing entries in the CommandHelpDialog, e.g.  **Link** - `CTRL + K`, or type `[[`
[15:06:24] <grrrit-wm>	 (03CR) 10Jforrester: [C: 04-1] Update my .mailmap and AUTHORS.txt entries (031 comment) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/247516 (owner: 10Divec)
[15:33:37] <grrrit-wm>	 (03PS1) 10Esanders: Surface drop: Show branch node drop markers for file drop [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/247586 (https://phabricator.wikimedia.org/T115859) 
[15:35:48] <grrrit-wm>	 (03CR) 10Divec: Update my .mailmap and AUTHORS.txt entries (031 comment) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/247516 (owner: 10Divec)
[15:36:00] <grrrit-wm>	 (03PS2) 10Divec: Update my .mailmap and AUTHORS.txt entries [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/247516 
[15:36:26] <grrrit-wm>	 (03CR) 10Jforrester: [C: 032] Update my .mailmap and AUTHORS.txt entries [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/247516 (owner: 10Divec)
[15:37:28] <grrrit-wm>	 (03PS2) 10Esanders: Surface drop: Show branch node drop markers for file drop [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/247586 (https://phabricator.wikimedia.org/T115859) 
[15:39:35] <grrrit-wm>	 (03Merged) 10jenkins-bot: Update my .mailmap and AUTHORS.txt entries [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/247516 (owner: 10Divec)
[15:44:08] <wikibugs>	 10VisualEditor, 6Multimedia, 7Design, 5Patch-For-Review: Add hover state to VE when image file in being dragged onto in for uploading - https://phabricator.wikimedia.org/T115859#1738633 (10Esanders) The above patch uses the branch node drop markers we use when dragging images around internally. We can add...
[15:44:19] <grrrit-wm>	 (03CR) 10Esanders: [C: 04-1] "Improving" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/247586 (https://phabricator.wikimedia.org/T115859) (owner: 10Esanders)
[15:58:07] <grrrit-wm>	 (03PS2) 10Prtksxna: Use mw.Upload.Dialog to upload and insert file [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/247563 (https://phabricator.wikimedia.org/T115748) 
[15:59:17] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Use mw.Upload.Dialog to upload and insert file [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/247563 (https://phabricator.wikimedia.org/T115748) (owner: 10Prtksxna)
[16:01:21] <grrrit-wm>	 (03PS3) 10Prtksxna: Use mw.Upload.Dialog to upload and insert file [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/247563 (https://phabricator.wikimedia.org/T115748) 
[16:02:25] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Use mw.Upload.Dialog to upload and insert file [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/247563 (https://phabricator.wikimedia.org/T115748) (owner: 10Prtksxna)
[16:05:18] <grrrit-wm>	 (03PS1) 10Jforrester: .mailmap: Update for recent commits [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/247598 
[16:05:20] <grrrit-wm>	 (03PS1) 10Jforrester: AUTHORS.txt: Update for Autumn 2015 [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/247599 
[16:07:30] <grrrit-wm>	 (03PS4) 10Prtksxna: Use mw.Upload.Dialog to upload and insert file [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/247563 (https://phabricator.wikimedia.org/T115748) 
[16:07:32] <grrrit-wm>	 (03PS1) 10Jforrester: .mailmap: Update e-mail addresses for David Chan and Thalia [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/247600 
[16:45:11] <grrrit-wm>	 (03PS1) 10Jforrester: Revert "[BrowserTest] Use English if i18n file does not exists to convert the text" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/247611 
[17:04:17] <edsanders>	 Krinkle, you remember the stuff with .prop('contenteditable') returning sting 'true'/'false'?
[17:04:25] <Krinkle>	 Yes
[17:04:37] <Krinkle>	 contentEditable contains string 'true', 'false' or 'inherit'
[17:04:44] <edsanders>	 Kemayo has this patch https://gerrit.wikimedia.org/r/#/c/247519/3/src/ce/ve.ce.Surface.js which uses 'isContentEditable' prop
[17:04:46] <edsanders>	 is that ok?
[17:05:08] <edsanders>	 i.e. well supported and not problematic
[17:05:17] <Krinkle>	 David pointed me to it earlier, will look at it in a bit. First thing after my meeting. In 1-2 hour.
[17:07:01] <James_F>	 Krinkle: You're awesome, thanks.
[17:13:00] <grrrit-wm>	 (03PS3) 10Esanders: Surface drop: Show branch node drop markers for file drop [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/247586 (https://phabricator.wikimedia.org/T115859) 
[17:17:17] <wikibugs>	 10VisualEditor: Adding site link to Wikidata from wiki while in VE edit, cause a refresh and lose of editing context - https://phabricator.wikimedia.org/T116040#1739039 (10eranroz) 3NEW
[17:25:35] <wikibugs>	 10VisualEditor, 10VisualEditor-MediaWiki-Media: Display the license on the first screen of the media upload dialog - https://phabricator.wikimedia.org/T116046#1739095 (10Whatamidoing-WMF) 3NEW
[17:26:06] <wikibugs>	 10Citoid, 10VisualEditor, 5Patch-For-Review: Add ability to request base types in citoid, and offer use of both in extension for backwards compatibility until all templateData has been updated. - https://phabricator.wikimedia.org/T114515#1739111 (10kaldari)
[17:26:08] <wikibugs>	 10Citoid, 6Community-Tech: Add Citoid support to RefToolbar gadget - https://phabricator.wikimedia.org/T114156#1739110 (10kaldari)
[17:32:33] <wikibugs>	 10VisualEditor: Can't clear italics from text - https://phabricator.wikimedia.org/T116049#1739157 (10Whatamidoing-WMF) 3NEW
[17:57:32] <wikibugs>	 10Citoid, 10VisualEditor: WorldCat URLs not importing ISBN information correctly - https://phabricator.wikimedia.org/T116056#1739344 (10Whatamidoing-WMF) 3NEW
[18:06:45] <grrrit-wm>	 (03PS4) 10Esanders: Surface drop: Show branch node drop markers for file drop [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/247586 (https://phabricator.wikimedia.org/T115859) 
[18:32:45] <edsanders>	 James_F, don't merged those checkbox/radio changes
[18:32:55] <James_F>	 edsanders: … now you tell me.
[18:33:12] <James_F>	 edsanders: The checkbox and toggle changes are significant improvements.
[18:33:17] <edsanders>	 nope
[18:33:23] <James_F>	 edsanders: They stand regardless of the radio issue.
[18:33:30] <edsanders>	 they make everything blue
[18:33:39] <James_F>	 edsanders: Green for a set state is wrong and out of keeping with the design.
[18:34:04] <edsanders>	 leave your comments on the bug, Volker says he wants to come back to it after solving the focus confusion
[18:34:26] <James_F>	 edsanders: I guess we're not doing an OOUI cut this week, then.
[18:34:27] * James_F sighs.
[18:34:33] <James_F>	 C-2 code that isn't good to go.
[18:35:03] <edsanders>	 I'll have a look
[18:35:50] <James_F>	 And I already C-1'ed the radio thing for the design being awkward.
[18:39:09] <grrrit-wm>	 (03PS1) 10Vikassy: [BrowserTest] Select english when language screenshot code config is not set [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/247630 (https://phabricator.wikimedia.org/T111525) 
[18:39:43] <wikibugs>	 10Citoid, 10VisualEditor: WorldCat URLs not importing ISBN information correctly - https://phabricator.wikimedia.org/T116056#1739603 (10Mvolz) A problem with our validator, almost certainly. Possibly an issue with translator as well although not nessecarily. Will look into it.
[18:40:06] <wikibugs>	 10Citoid, 10VisualEditor: WorldCat URLs not importing ISBN information correctly - https://phabricator.wikimedia.org/T116056#1739606 (10Mvolz) p:5Triage>3Normal a:3Mvolz
[18:42:05] <edsanders>	 Also the radio thing re-increases the size. I don't want to have that debate again :/
[18:42:21] <James_F>	 True.
[18:42:53] <grrrit-wm>	 (03PS2) 10Vikassy: [BrowserTest] Select english when language screenshot code config is not set [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/247630 (https://phabricator.wikimedia.org/T111525) 
[18:45:00] <grrrit-wm>	 (03PS3) 10Vikassy: [BrowserTest] Select english when language screenshot code config is not set [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/247630 (https://phabricator.wikimedia.org/T111525) 
[18:56:20] <wikibugs>	 10VisualEditor, 10MediaWiki-Uploading, 6Multimedia: Insert media dialog hangs during image upload - https://phabricator.wikimedia.org/T116073#1739678 (10awight) 3NEW
[18:56:53] <wikibugs>	 10VisualEditor, 10MediaWiki-Uploading, 6Multimedia: Insert media dialog hangs during image upload - https://phabricator.wikimedia.org/T116073#1739687 (10awight)
[18:58:26] <wikibugs>	 10VisualEditor, 10MediaWiki-Uploading, 6Multimedia: Insert media dialog hangs during image upload - https://phabricator.wikimedia.org/T116073#1739692 (10awight) Trying another time, I get the first error, then a second one: > Error: Filename not included in file data.  Also, here's a stack trace from the fir...
[18:59:40] <edsanders>	 James_F, you going to merge the reverts?
[19:01:24] <wikibugs>	 10VisualEditor, 6Commons, 10MediaWiki-Categories: Different categories available in VE insert media dialog vs. commons upload wizard - https://phabricator.wikimedia.org/T116075#1739709 (10awight) 3NEW
[19:07:03] <wikibugs>	 10VisualEditor, 6Commons, 10MediaWiki-Categories, 6Multimedia: Local categories rather than Commons's are prompted in the upload media dialog - https://phabricator.wikimedia.org/T116075#1739739 (10Jdforrester-WMF) p:5Triage>3Normal a:3Prtksxna
[19:07:20] <wikibugs>	 10VisualEditor, 6Commons, 10MediaWiki-Categories, 6Multimedia: Local categories rather than Commons's are prompted in the upload media dialog - https://phabricator.wikimedia.org/T116075#1739747 (10Whatamidoing-WMF) https://www.mediawiki.org/wiki/Category:Mediawiki_Manual is a local category.
[19:07:42] <wikibugs>	 10VisualEditor, 10MediaWiki-Uploading, 6Multimedia: Insert media dialog hangs during image upload - https://phabricator.wikimedia.org/T116073#1739750 (10Jdforrester-WMF) 5Open>3Invalid a:3Jdforrester-WMF Gadget bugs aren't tracked in Phab.
[19:09:13] <wikibugs>	 10VisualEditor, 10VisualEditor-MediaWiki-Media, 6Multimedia: Name the licence on the first screen of the media upload dialog - https://phabricator.wikimedia.org/T116046#1739756 (10Jdforrester-WMF) p:5Triage>3Low
[19:09:22] <wikibugs>	 10VisualEditor, 10VisualEditor-MediaWiki-Media, 6Multimedia: Name the licence on the first screen of the media upload dialog - https://phabricator.wikimedia.org/T116046#1739763 (10Jdforrester-WMF) This'll need Legal to re-approve the text.
[19:10:23] <wikibugs>	 10VisualEditor, 10VisualEditor-MediaWiki, 10Wikidata: Wikidata "add site link" tool should be disabled whilst VE is active; using it breaks everything - https://phabricator.wikimedia.org/T116040#1739768 (10Jdforrester-WMF) p:5Triage>3Low
[19:10:51] <wikibugs>	 10VisualEditor, 10VisualEditor-EditingTools: Show sequence shortcuts in the help dialog (CommandHelpDialog) - https://phabricator.wikimedia.org/T116013#1739776 (10Jdforrester-WMF) p:5Triage>3Normal a:3DLynch
[19:12:38] <wikibugs>	 10VisualEditor, 10VisualEditor-EditingTools: Can't clear some random styling copied off the Internet which makes text appear italics - https://phabricator.wikimedia.org/T116049#1739800 (10Jdforrester-WMF) p:5Triage>3Low
[19:15:06] <wikibugs>	 10VisualEditor, 6Multimedia: "A file with name "$1" already exists in the shared file repository, and cannot be overwritten"  shows up while trying to rename a file with single letter which is different from standard format - https://phabricator.wikimedia.org/T115946#1739815 (10Jdforrester-WMF) p:5Triage>3N...
[19:15:21] <wikibugs>	 10VisualEditor, 10VisualEditor-EditingTools: Can't clear some random styling copied off the Internet which makes text appear italics - https://phabricator.wikimedia.org/T116049#1739820 (10Whatamidoing-WMF) This happened in Firefox 41 on Mac OS 10.10.
[19:15:39] <wikibugs>	 10VisualEditor, 6Multimedia: While uploading image, clicking on "Try again" allows renaming the filename, even though it previously complained about it - https://phabricator.wikimedia.org/T115944#1739826 (10Jdforrester-WMF) p:5Triage>3Low
[19:16:03] <wikibugs>	 10VisualEditor, 10Phlogiston: Restore VE tranches to report - https://phabricator.wikimedia.org/T115941#1739832 (10Jdforrester-WMF) p:5Triage>3Unbreak!
[19:17:04] <wikibugs>	 10VisualEditor, 10VisualEditor-MediaWiki-Media, 6Multimedia, 7Design: Insert image in content immediately after it's uploaded, skipping the "General settings" step - https://phabricator.wikimedia.org/T115865#1739839 (10Jdforrester-WMF)
[19:17:50] <wikibugs>	 10VisualEditor, 10VisualEditor-MediaWiki-Media, 6Multimedia: Cannot select date from calendar inside Media upload dialog when the browser window is resized in a way that it overlaps with the calendar - https://phabricator.wikimedia.org/T115939#1739843 (10Jdforrester-WMF) p:5Triage>3Low
[19:18:45] <wikibugs>	 10VisualEditor, 6Multimedia, 7Design, 5Patch-For-Review: Make it clear in VE (hover state?) when a media file is being dragged in that shows it will do something - https://phabricator.wikimedia.org/T115859#1739854 (10Jdforrester-WMF) p:5Triage>3Normal
[19:19:44] <wikibugs>	 10VisualEditor, 10VisualEditor-MediaWiki, 7Epic: Provide an auto-correct feature - https://phabricator.wikimedia.org/T115847#1739859 (10Jdforrester-WMF) p:5Triage>3Low
[19:20:49] <wikibugs>	 10VisualEditor: Use a template instead of span tags concerning language in a text - https://phabricator.wikimedia.org/T115839#1739865 (10Jdforrester-WMF) 5Open>3declined a:3Jdforrester-WMF This is the anti-pattern we're getting away from.
[19:22:31] <wikibugs>	 10VisualEditor: Adding a new category adds wikitext at the end of the article even if there is some other content after the existing categories - https://phabricator.wikimedia.org/T115688#1739868 (10Jdforrester-WMF)
[19:22:32] <wikibugs>	 10VisualEditor, 10VisualEditor-EditingTools: VisualEditor: Place page meta-data in expected order - https://phabricator.wikimedia.org/T52882#1739869 (10Jdforrester-WMF)
[19:23:12] <wikibugs>	 10VisualEditor, 10MediaWiki-General-or-Unknown: [iOS Safari on Desktop] In the Web visual editor, the first press of Backspace fails to erase the last character of the link - https://phabricator.wikimedia.org/T115618#1739874 (10Jdforrester-WMF) p:5Triage>3Lowest
[19:23:23] <wikibugs>	 10VisualEditor: [iOS Safari on Desktop] The Web visual editor forgets to save the change of case in the link - https://phabricator.wikimedia.org/T115617#1739877 (10Jdforrester-WMF) p:5Triage>3Lowest
[19:24:55] <wikibugs>	 10VisualEditor, 10VisualEditor-MediaWiki-Links: [Regression ?] Context menu for link inspector does not appear after typing something after the link unless user goes to next line - https://phabricator.wikimedia.org/T114333#1739884 (10Jdforrester-WMF) p:5High>3Low
[19:26:34] <wikibugs>	 10VisualEditor, 10VisualEditor-MediaWiki-Media, 6Multimedia: If the user Saves an upload, but does not then insert it, reset the form correctly - https://phabricator.wikimedia.org/T115380#1739889 (10Jdforrester-WMF) p:5Triage>3Low
[19:27:21] <wikibugs>	 10VisualEditor, 10VisualEditor-EditingTools, 7Design: Come up with a user experience design for editing definition-lists - https://phabricator.wikimedia.org/T102987#1739900 (10Jdforrester-WMF)
[19:27:23] <wikibugs>	 10VisualEditor, 10VisualEditor-Media: Dragging an image to the top of an association list (aka definition list) breaks the list formatting - https://phabricator.wikimedia.org/T115635#1739899 (10Jdforrester-WMF)
[19:27:32] <wikibugs>	 10VisualEditor, 10VisualEditor-EditingTools, 10VisualEditor-Media: Dragging an image to the top of an association list (aka definition list) breaks the list formatting - https://phabricator.wikimedia.org/T115635#1739901 (10Jdforrester-WMF) p:5Triage>3Low
[19:29:01] <wikibugs>	 10VisualEditor: On Firefox, insert wikitext on a citation template to create a link generates an incorrect link as long as you didn't save the page - https://phabricator.wikimedia.org/T115089#1739915 (10Jdforrester-WMF) Related to T110413.
[19:29:44] <wikibugs>	 10VisualEditor, 10VisualEditor-MediaWiki-References, 10VisualEditor-MediaWiki-Templates: Template/reference preview of links is relative to current page, not the correct base, until saved - https://phabricator.wikimedia.org/T115089#1739919 (10Jdforrester-WMF) p:5Triage>3Low
[19:43:43] <wikibugs>	 10VisualEditor, 10VisualEditor-CopyPaste, 7Browser-Support-Firefox: Pasting into a VE surface in Firefox adds spurious line breaks and nowikis - https://phabricator.wikimedia.org/T104790#1739937 (10Pols12) At home and by Vatadoshu too, VE does not add nowiki markups : VE automatically delete spaces when they...
[19:59:27] <wikibugs>	 10VisualEditor, 10VisualEditor-ContentEditable: When typing into a selection in Firefox, DM annotations can get out of sync with the DOM - https://phabricator.wikimedia.org/T113869#1678845 (10Jdforrester-WMF)
[20:01:05] <Krinkle>	 divec: edsanders: Kemayo: Checking out the isContentEditable prop now. There's a bunch of edge cases I recall when we last tried that. But I'm hopeful. using browserstack now to check out behaviour
[20:02:31] <wikibugs>	 10VisualEditor, 10VisualEditor-MediaWiki-References, 10VisualEditor-MediaWiki-Templates: Template/reference preview of links is relative to current page, not the correct base, until saved - https://phabricator.wikimedia.org/T115089#1739984 (10Pols12) "is relative to current page" Right except when we are on...
[20:10:18] <Kemayo>	 Krinkle: it's no great hardship if that turns out to still be the case, fortunately.
[20:10:40] <Krinkle>	 Kemayo: Are we currently doing inheritance correctly?
[20:10:44] <Krinkle>	 (e.g. is there a bug)
[20:11:49] <Kemayo>	 There's a bug in the current code, but it's not inheritance-related, it's just that we're assuming the value of contenteditable is a boolean rather than a string.
[20:14:20] <Kemayo>	 The bug would be entirely fixed by just switching to "node.contenteditable === 'true'". But if isContentEditable doesn't have any hidden flaws, that seems better / more-futureproof, so...
[20:14:46] <Krinkle>	 Kemayo: yeah, definitely.
[20:15:00] <Krinkle>	 Though 'true' seems insufficient, since it can also be inherited. Most children won't have it set.
[20:15:17] <Krinkle>	 But maybe the IDL property is implicit (the attribute won't be though)
[20:15:40] <Krinkle>	 the closest [contenteditable] solves that at the moment I imagine.
[20:16:18] <Kemayo>	 Yeah, closest sort of subs in for thinking about inheritance, though admittedly in a sort of flawed way.
[20:17:48] <Krinkle>	 contenteditable isn't very well specified, or rather, not consistently implemented, so it's quite important to test in the wild and see what happens :) - I'm hoping work of the w3c editing-tf will help smoothen things a bit (see http://www.w3.org/wiki/Editing_Taskforce and https://github.com/w3c/editing )
[20:34:40] <Krinkle>	 Kemayo: http://codepen.io/Krinkle/pen/JYMryg?editors=011 - running http://codepen.io/Krinkle/debug/JYMryg in various browsers now to see the results. So far looking good, but haven't tried older Firefox/IE yet. We only have to support IE9 and Firefox 5 at this point though (I think, James_F  ?)
[20:35:24] <James_F>	 Krinkle: No, IE9+ (10+ right now) and FF 10+ (15+ right now).
[20:35:49] <James_F>	 Krinkle: Fixes that made us incompatible with IE9 might make us sad, though.
[20:39:03] <Krinkle>	 Passed in Chrome stable, Firefox stable, Safari 8, Firefox 15, Firefox 10, Edge 12, IE 11, IE 10, IE 9, Safari-Windows 5.1, Safari-Mac 4.0, 
[20:39:07] <Krinkle>	 Couldn't find any failure
[20:40:14] <grrrit-wm>	 (03CR) 10Krinkle: [C: 031] "There were issues with isContentEditable in the past, but none that I could find/rediscover in the present." [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/247519 (https://phabricator.wikimedia.org/T114545) (owner: 10DLynch)
[20:40:21] <James_F>	 Krinkle: Nice.
[20:41:14] <James_F>	 Krinkle: What's the jsDuck way to say the type is an array of Foo objects? Array[Foo] is failing.
[20:41:16] <Krinkle>	 Kemayo: Though, prop 'contenteditable' doesn't exist. It's named 'contentEditable'
[20:41:18] <Krinkle>	 node.contenteditable is undefined.
[20:41:28] <Krinkle>	 So I'm suspicious of the current code.
[20:42:01] <Kemayo>	 It's currently accessing via jquery, which magically fixes it up.
[20:42:38] <grrrit-wm>	 (03CR) 10Krinkle: ce.Surface afterKeyDown shouldn't assume .contenteditable is boolean (031 comment) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/247519 (https://phabricator.wikimedia.org/T114545) (owner: 10DLynch)
[20:42:45] <Krinkle>	 Kemayo: yeah, propFix.
[20:43:00] <Krinkle>	 Most of that got dropped in jQuery 1.8 but some of it remained I see
[20:45:00] <Krinkle>	 Kemayo: So the current code then it flawed, because it doesn't follow inheritance (considered truethy) and also doesn't consider 'false'
[20:45:58] <Krinkle>	 Ah, Kemayo  == DLynch.
[20:46:00] <Krinkle>	 Welcome :)
[20:46:29] <Kemayo>	 Yeah, with the current code that function will _always_ hit the `return null;` path.
[20:46:39] <Kemayo>	 Hi. :D
[20:48:01] <Krinkle>	 Kemayo: You may enjoy https://krinkle.github.io/dom-ce/ and https://krinkle.github.io/dom-ce/plain.html 
[21:19:18] <grrrit-wm>	 (03CR) 10Alex Monk: "Damn... I think this is the code that forces the dialog to stay open until the process of swapping html to wikitext to post off to the edi" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/247484 (owner: 10Alex Monk)
[21:20:57] <wikibugs>	 10VisualEditor, 10VisualEditor-MediaWiki-Media, 6Multimedia, 7Verified-in-Phase0, 5WMF-deploy-2015-10-13_(1.27.0-wmf.3): Switching between "Upload" and "Search" tabs in the upload dialog clears state of the upload form - https://phabricator.wikimedia.org/T115059#1740171 (10Ryasmeen)
[21:21:17] <wikibugs>	 10VisualEditor, 10VisualEditor-MediaWiki-Media, 6Multimedia: Name the licence on the first screen of the media upload dialog - https://phabricator.wikimedia.org/T116046#1740173 (10matmarex) Eh, why? Legal only approved the legalese, not all the other text. We could just change "under a different license" to...
[21:22:41] <wikibugs>	 10VisualEditor, 10VisualEditor-MediaWiki, 10OOjs-UI, 7Verified-in-Phase0, and 3 others: Focusing a template field or adding a new field focusses the info icon, not the text widget - https://phabricator.wikimedia.org/T114562#1740175 (10Ryasmeen)
[21:22:50] <wikibugs>	 10VisualEditor, 10VisualEditor-MediaWiki, 10VisualEditor-MediaWiki-Media, 6Multimedia: Give guidance in the new upload form, to prevent the most common errors - e.g. bad file titles - https://phabricator.wikimedia.org/T116086#1740176 (10Quiddity) 3NEW
[21:22:54] <wikibugs>	 10VisualEditor, 10VisualEditor-MediaWiki-Media, 6Multimedia: Name the licence on the first screen of the media upload dialog - https://phabricator.wikimedia.org/T116046#1740183 (10matmarex) p:5Low>3High I don't think this is low priority, it's a pretty glaring mistake we have somehow all overlooked. I th...
[21:25:51] <wikibugs>	 10VisualEditor, 6Multimedia, 5MW-1.26-release, 5Patch-For-Review, and 3 others: The drop down for categories in Upload image dialog opens too slowly, even sometimes after moving to the next field - https://phabricator.wikimedia.org/T114945#1740188 (10Ryasmeen)
[21:27:17] <wikibugs>	 10VisualEditor, 10VisualEditor-MediaWiki-Media, 6Multimedia, 5MW-1.26-release, and 3 others: Trying to upload image under blacklisted title in the upload image dialog throws error "<api-error-titleblacklist-custom-imagename>" - https://phabricator.wikimedia.org/T114940#1740191 (10Ryasmeen)
[21:29:09] <wikibugs>	 10VisualEditor, 10MediaWiki-Uploading, 6Multimedia: Insert media dialog hangs during image upload - https://phabricator.wikimedia.org/T116073#1740195 (10matmarex) 5Invalid>3Open If you got "Error: Filename not included in file data.", then that's not from the gadget, but from our code.  Can you still rep...
[21:29:51] <wikibugs>	 10VisualEditor, 6Multimedia, 5MW-1.26-release, 7Verified-in-Phase0, 5WMF-deploy-2015-10-13_(1.27.0-wmf.3): Previously added Categories and Date value for another image remains selected while trying to upload a new image - https://phabricator.wikimedia.org/T114947#1740197 (10Ryasmeen)
[21:30:31] <wikibugs>	 10VisualEditor, 6Multimedia, 5MW-1.26-release, 7Verified, and 2 others: The checkbox for "This is my own work" remains selected for the next time user tries to upload an image - https://phabricator.wikimedia.org/T114936#1740199 (10Ryasmeen)
[21:32:28] <edsanders>	 James_F, you going to merge those reverts?
[21:32:38] <James_F>	 edsanders: No, I was just going to skip the release.
[21:32:56] <edsanders>	 how does that help?
[21:32:59] <edsanders>	 we need to revert any
[21:33:07] <James_F>	 We can fix it at leisure.
[21:33:08] <edsanders>	 especially the radio size
[21:34:02] <edsanders>	 I don't think there's anything to suggest there is going to be a fix within the week
[21:34:05] <wikibugs>	 10VisualEditor, 6Multimedia, 5MW-1.26-release, 7Verified, and 2 others: The date-picker in Upload image dialog does not close after selecting a date, requires clicking somewhere else to close it - https://phabricator.wikimedia.org/T114942#1740207 (10Ryasmeen)
[21:34:11] <James_F>	 There's no change to the radio size merged.
[21:39:34] <edsanders>	 it's going to be a while before it's fixed, and those changes shouldn't be merged as is
[21:44:51] <wikibugs>	 10VisualEditor, 10MediaWiki-Uploading, 6Multimedia: Insert media dialog hangs during image upload - https://phabricator.wikimedia.org/T116073#1740228 (10matmarex) Hmm… any chance that your file was last modified on Thursday, 1 January 1970, or that Firefox would think so?
[21:46:48] <wikibugs>	 10VisualEditor, 10VisualEditor-MediaWiki-References, 7Verified-in-Phase0, 5WMF-deploy-2015-10-13_(1.27.0-wmf.3): Trying to re-use a reference replacing itself crashes; should instead be a no-op - https://phabricator.wikimedia.org/T90476#1740240 (10Ryasmeen)
[21:56:37] <wikibugs>	 10VisualEditor, 10MediaWiki-Uploading, 6Multimedia: Insert media dialog hangs during image upload - https://phabricator.wikimedia.org/T116073#1740277 (10matmarex) a:5Jdforrester-WMF>3matmarex
[22:03:18] <MatmaRex>	 >> m2 = "20"; i = 0; str = ( +m2 + i + 1 ) + ''; console.log( str );
[22:03:19] <ecmabot-wm>	 MatmaRex: undefined; Console: '21'
[22:03:32] <MatmaRex>	 >> m2 = "20"; i = 0; str = String( m2 + i + 1 ); console.log( str );
[22:03:32] <ecmabot-wm>	 MatmaRex: undefined; Console: '2001'
[22:03:34] <MatmaRex>	 James_F: ^
[22:03:49] <James_F>	 >> m2 = "20"; i = 0; str = String( +m2 + i + 1 ); console.log( str );
[22:03:50] <ecmabot-wm>	 James_F: undefined; Console: '21'
[22:03:52] <James_F>	 Bah.
[22:03:53] <James_F>	 OK.
[22:04:03] <MatmaRex>	 it probably needs Number( m2 )?
[22:04:13] <MatmaRex>	 isn't the + what jscs complained about?
[22:04:14] <MatmaRex>	 anywya.
[22:04:52] <James_F>	 No, funnily enough jscs doesn't complain about + as a cast, but does about + ''.
[22:05:59] <wikibugs>	 10VisualEditor, 6Commons, 10MediaWiki-Categories, 6Multimedia: Local categories rather than Commons's are prompted in the upload media dialog - https://phabricator.wikimedia.org/T116075#1740309 (10matmarex) a:5Prtksxna>3matmarex Woooow this is incredibly super stupid.  @prtksxna is probably not around...
[22:06:07] <wikibugs>	 10VisualEditor, 6Commons, 10MediaWiki-Categories, 6Multimedia: Local categories rather than Commons's are prompted in the upload media dialog - https://phabricator.wikimedia.org/T116075#1740311 (10matmarex) p:5Normal>3High
[22:16:58] <wikibugs>	 10VisualEditor, 10MediaWiki-Uploading, 6Multimedia: Insert media dialog hangs during image upload - https://phabricator.wikimedia.org/T116073#1740364 (10Jdforrester-WMF) 5Open>3Resolved p:5Triage>3Low
[22:34:33] <wikibugs>	 10VisualEditor, 10VisualEditor-MediaWiki-Media, 6Multimedia: Name the licence on the first screen of the media upload dialog - https://phabricator.wikimedia.org/T116046#1740422 (10Jdforrester-WMF) Re-arrangement means no need to re-validate it with Legal, so +1.
[22:45:10] <grrrit-wm>	 (03PS3) 10Alex Monk: Make the wikitext switch confirmation dialog independent of the target [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/247484 
[22:46:39] <grrrit-wm>	 (03PS4) 10Alex Monk: Make the wikitext switch confirmation dialog independent of the target [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/247484 
[22:46:59] <wikibugs>	 10VisualEditor, 6Editing-Analysis: Provide VE-related data for the Galician Wikipedia - https://phabricator.wikimedia.org/T86944#1740467 (10Neil_P._Quinn_WMF) @Elitre, is there still any interest in this data? I expect it has probably passed by now.
[22:47:24] <grrrit-wm>	 (03PS5) 10Alex Monk: Make the wikitext switch confirmation dialog independent of the target [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/247484 
[22:51:26] <wikibugs>	 10VisualEditor, 10VisualEditor-MediaWiki-Media, 6Multimedia: Name the licence on the first screen of the media upload dialog - https://phabricator.wikimedia.org/T116046#1740496 (10Whatamidoing-WMF) Rearranging is totally fine with me.  Naming the license would be fine with me.  Even just a CC-BY-SA 4.0 icon...
[22:52:03] <wikibugs>	 10VisualEditor, 6Editing-Analysis: Please generate a list of Most referenced domains on the Dutch Wikipedia - https://phabricator.wikimedia.org/T107788#1740497 (10Neil_P._Quinn_WMF) @Elitre, is there still an outstanding request here, or did Edgars2007's work take care of it? If so, feel free to close the task...
[22:53:25] <wikibugs>	 10VisualEditor, 10VisualEditor-MediaWiki-Media, 6Multimedia: Name the licence on the first screen of the media upload dialog - https://phabricator.wikimedia.org/T116046#1740498 (10Whatamidoing-WMF) One more thought:  Aren't the licenses different on some projects, e.g., Wikinews?    Naming it in the text, e....
[22:55:33] <wikibugs>	 10VisualEditor, 10VisualEditor-MediaWiki-Media, 6Multimedia: Name the licence on the first screen of the media upload dialog - https://phabricator.wikimedia.org/T116046#1740504 (10Jdforrester-WMF) >>! In T116046#1740498, @Whatamidoing-WMF wrote: > One more thought:  Aren't the licenses different on some proj...
[23:06:17] <wikibugs>	 10TemplateData, 6Community-Liaison, 6Editing-Analysis, 10WMF-Product-Strategy: Please make me a list of commonly used templates in Wikipedia articles - https://phabricator.wikimedia.org/T96323#1740609 (10Neil_P._Quinn_WMF) @Elitre, are you still looking for data here, or is this more or less resolved?  (So...