[04:57:02] 10VisualEditor: Using VisualEditor hovering over link no longer pulls up correct infobox image - https://phabricator.wikimedia.org/T116261#1747443 (10Checkingfax) >>! In T116261#1746690, @Krenair wrote: > VisualEditor isn't the software making the decision of which to use. How do we get it remedied? Thank you. [05:47:32] 10Cite, 10Math, 10MediaWiki-extensions-MathSearch, 5Patch-For-Review: Hook Cite::checkRefsNoReferences has invalid call signature; - https://phabricator.wikimedia.org/T105598#1747469 (10Physikerwelt) see also T108819 [09:29:55] 10VisualEditor, 10Parsoid:
in headers - https://phabricator.wikimedia.org/T116367#1747644 (10eranroz) 3NEW [09:36:46] (03PS1) 10Esanders: [PULL THROUGH] Remove resize detection now that TextInputWidget implements it [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/248306 [09:37:04] (03PS2) 10Esanders: [PULL THROUGH] Remove resize detection now that TextInputWidget implements it [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/248306 [09:37:45] 10VisualEditor, 10Parsoid:
in headers - https://phabricator.wikimedia.org/T116367#1747670 (10Esanders) How are these created? [11:41:37] 10VisualEditor: VE: unexpected additional focusableNode - https://phabricator.wikimedia.org/T100792#1747800 (10Sunpriat) now it looks normal. probably something related with this has been corrected. this bug may be closed [11:41:51] 10VisualEditor: VE: unexpected additional focusableNode - https://phabricator.wikimedia.org/T100792#1747803 (10Sunpriat) 5stalled>3Resolved [13:04:25] 10Cite: Invisible citation error - https://phabricator.wikimedia.org/T116377#1747897 (10Aklapper) Thanks for reporting. Why would you expect it to create an error? ([[ https://www.mediawiki.org/wiki/How_to_report_a_bug | Actual outcome and expected outcome always welcome ]], to avoid misunderstandings.) [13:37:12] 10Cite: Invisible citation error - https://phabricator.wikimedia.org/T116377#1747929 (10IKhitron) From the same reason of T85386 - "Show an error if a named is defined multiple times with different content" [13:43:06] 10Cite: Invisible citation error - https://phabricator.wikimedia.org/T116377#1747937 (10IKhitron) [14:33:41] 10VisualEditor, 10Math: Make math syntax helper dialog - https://phabricator.wikimedia.org/T114163#1748005 (10Esanders) [14:36:04] 10VisualEditor, 10OOjs-UI, 6WMF-Design, 7Design, 5Patch-For-Review: Use progressive for selected states in OOUI - https://phabricator.wikimedia.org/T107953#1748010 (10Esanders) Now we have access to Ace Editor in VE (https://gerrit.wikimedia.org/r/#/c/247851/) we can also put LaTeX syntax highlighting in... [15:14:21] 10VisualEditor, 10VisualEditor-EditingTools: VisualEditor: Clear formatting button should not remove links - https://phabricator.wikimedia.org/T53757#1748103 (10Esanders) 5Open>3declined a:3Esanders [15:17:04] 10VisualEditor, 10Parsoid:
in headers - https://phabricator.wikimedia.org/T116367#1748114 (10Esanders) This would be for the Parsoid HTML cleaner, but unless users are regularly creating these accidentally I'm inclined not to add it. [15:18:08] 10VisualEditor, 10Math: Make math syntax helper dialog - https://phabricator.wikimedia.org/T114163#1748117 (10Esanders) Now we have access to Ace Editor in VE (https://gerrit.wikimedia.org/r/#/c/247851/) we can also put LaTeX syntax highlighting in the text input. [15:35:47] 10VisualEditor, 10VisualEditor-MediaWiki: GalleryInspector: Selector for gallery mode (normal/etc.) - https://phabricator.wikimedia.org/T110641#1748156 (10Esanders) Sounds like a good idea. Looking at the Math inspector would be a good place to start. [15:37:32] 10VisualEditor, 10VisualEditor-MediaWiki, 10MediaWiki-Gallery: VisualEditor: User should be able to add gallery inside reference - https://phabricator.wikimedia.org/T65022#1748168 (10Esanders) I'm not sure that's something we want to encourage? [15:41:25] (03PS1) 10Jforrester: build: Upgrade mediawiki-codesniffer from v0.4.0 to v0.5.0 [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/248350 [16:05:33] (03PS1) 10Esanders: DesktopTarget: Fix opacity of #siteSub and #contentSub [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/248356 [16:10:13] (03PS2) 10Esanders: DesktopTarget: Fix opacity of #siteSub and #contentSub [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/248356 [16:10:50] (03PS3) 10Esanders: DesktopTarget: Fix opacity of #siteSub and #contentSub [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/248356 [16:31:49] (03CR) 10Bartosz Dziewoński: [C: 04-1] "I think the button should just say "Upload", since clicking it doesn't actually insert anything (you need to click "Insert" after uploadin" [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/247563 (https://phabricator.wikimedia.org/T115748) (owner: 10Prtksxna) [16:48:15] MatmaRex: I agree; make the change and merge? [16:50:17] sure [16:50:24] https://commons.wikimedia.org/w/index.php?title=Special:RecentChanges&tagfilter=cross-wiki-upload whoa, that picked up some speed [16:53:30] https://commons.wikimedia.org/w/index.php?title=File:Gubaidullin_Naill_Shagbinovich.jpeg&action=edit hmm, we're duplicating the description and categories sometimes? [16:53:59] 10VisualEditor, 10Score: Provide better error message when emp - https://phabricator.wikimedia.org/T116392#1748401 (10Esanders) [16:54:14] (03PS5) 10Bartosz Dziewoński: Use mw.Upload.Dialog to upload and insert file [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/247563 (https://phabricator.wikimedia.org/T115748) (owner: 10Prtksxna) [16:54:26] (03PS6) 10Bartosz Dziewoński: Use mw.Upload.Dialog to upload and insert file [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/247563 (https://phabricator.wikimedia.org/T115748) (owner: 10Prtksxna) [16:54:32] (03CR) 10Bartosz Dziewoński: [C: 032] Use mw.Upload.Dialog to upload and insert file [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/247563 (https://phabricator.wikimedia.org/T115748) (owner: 10Prtksxna) [16:55:44] 10WikiEditor, 6Multimedia, 7user-notice: Allow uploading files directly from the wikitext editor - https://phabricator.wikimedia.org/T115748#1748405 (10matmarex) 5Open>3Resolved [16:55:52] (03Merged) 10jenkins-bot: Use mw.Upload.Dialog to upload and insert file [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/247563 (https://phabricator.wikimedia.org/T115748) (owner: 10Prtksxna) [16:57:44] 10VisualEditor, 10Score: Provide better error message when empty - https://phabricator.wikimedia.org/T116392#1748416 (10Jdforrester-WMF) p:5Triage>3High [16:58:34] 10VisualEditor, 10MediaWiki-General-or-Unknown, 6Multimedia: Categories and descriptions are sometimes multiplicated in mw.Upload uploads - https://phabricator.wikimedia.org/T116394#1748421 (10matmarex) 3NEW [17:02:45] 10VisualEditor, 10MediaWiki-General-or-Unknown, 6Multimedia: All mw.Upload uploads use {{en|...}} in the description, they should probably be marked with the source wiki language - https://phabricator.wikimedia.org/T116395#1748486 (10matmarex) 3NEW [17:15:13] (03PS1) 10Alex Monk: [WIP] Single edit tab [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/248369 (https://phabricator.wikimedia.org/T114530) [17:23:09] (03PS1) 10DLynch: Include sequences in the command help dialog [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/248370 [17:23:30] (03PS2) 10DLynch: Include sequences in the command help dialog [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/248370 (https://phabricator.wikimedia.org/T116013) [17:25:34] Krenair: :-) [17:26:30] It sort of half does some things [17:26:47] e.g. switching from VE but discarding changes is broken [17:27:14] and it uses veaction=edit when clicking on the single tab, whereas I think we actually want action=edit [17:28:29] and we need to do all the compatibility checking still [17:29:54] * James_F nods. [17:30:06] Good start though. [17:30:25] I haven't actually tested it in non-single mode yet [17:30:43] (03PS1) 10DLynch: Add mediawiki-specific sequences to the command help dialog [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/248373 (https://phabricator.wikimedia.org/T116013) [17:32:08] Kemayo, cool - looking [17:33:23] I actually realized as I was rebasing it before submitting that you'd added some new sequences to the registry yesterday, so it doesn't include those in the help dialog yet. [17:34:52] (03CR) 10jenkins-bot: [V: 04-1] Add mediawiki-specific sequences to the command help dialog [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/248373 (https://phabricator.wikimedia.org/T116013) (owner: 10DLynch) [17:38:51] (03PS2) 10DLynch: Add mediawiki-specific sequences to the command help dialog [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/248373 (https://phabricator.wikimedia.org/T116013) [17:40:02] There's a small chance that I keep forgetting `grunt lint` doesn't cover both projects at once. [17:43:18] 10VisualEditor, 10VisualEditor-EditingTools, 5Patch-For-Review: Show sequence shortcuts in the help dialog (CommandHelpDialog) - https://phabricator.wikimedia.org/T116013#1748692 (10DLynch) {F2760461} [17:45:57] 10VisualEditor, 10VisualEditor-MediaWiki, 7Epic, 5Patch-For-Review: Change VE integration to only use one edit tab - https://phabricator.wikimedia.org/T114530#1748715 (10Elitre) Users who //only// use VE or wikitext would certainly love having one tab rather than two, and the fact that it only reads "Edit"... [17:53:36] (03CR) 10Legoktm: [C: 032] build: Upgrade mediawiki-codesniffer from v0.4.0 to v0.5.0 [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/248350 (owner: 10Jforrester) [17:56:11] (03Merged) 10jenkins-bot: build: Upgrade mediawiki-codesniffer from v0.4.0 to v0.5.0 [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/248350 (owner: 10Jforrester) [18:00:04] 10VisualEditor, 10VisualEditor-MediaWiki, 7Epic, 5Patch-For-Review: Change VE integration to only use one edit tab - https://phabricator.wikimedia.org/T114530#1748805 (10Amire80) WordPress has a visual mode and an HTML mode, and my last mode is remembered. I'm fairly happy about it. I find it sensible that... [18:05:22] legoktm: Want to power up lego-git-bot do to a run of those? :-) [18:05:49] James_F: sure :) [18:13:19] 10VisualEditor, 10VisualEditor-MediaWiki: When a editors have a single edit tab, keep the existing keyboard shortcuts that allow them to explicitly choose which editing environment to open - https://phabricator.wikimedia.org/T116406#1748859 (10Whatamidoing-WMF) 3NEW [18:14:24] 10VisualEditor, 10VisualEditor-MediaWiki: When a editors have a single edit tab, keep the existing keyboard shortcuts that allow them to explicitly choose which editing environment to open - https://phabricator.wikimedia.org/T116406#1748859 (10Whatamidoing-WMF) IMO it's not necessary for this keyboard shortcut... [18:22:53] 10VisualEditor, 10VisualEditor-MediaWiki, 7Design, 7Epic: Provide a single edit tab which has both visual and wikitext modes and allows on-the-fly switching between them - https://phabricator.wikimedia.org/T102398#1748903 (10Esanders) Going a bit deeper into discoverability issue, I think it can be separat... [18:57:29] 10VisualEditor, 6Collaboration-Team-Backlog, 10Flow, 6WMF-Design, 7Design: Switch editor-mode button, is confusing, and hard to discover - https://phabricator.wikimedia.org/T116417#1749049 (10Quiddity) 3NEW [18:58:35] 10VisualEditor, 6Collaboration-Team-Backlog, 10Flow, 10UI-Standardization, 7Design: Come up with a better re-usable UI concept for a button to switch editor-mode; the current one is confusing, and hard to discover - https://phabricator.wikimedia.org/T116417#1749062 (10Jdforrester-WMF) [19:00:48] 10VisualEditor, 6Collaboration-Team-Backlog, 10Flow, 10UI-Standardization, 7Design: Come up with a better re-usable UI concept for a button to switch editor-mode; the current one is confusing, and hard to discover - https://phabricator.wikimedia.org/T116417#1749066 (10Whatamidoing-WMF) I'm particularly c... [19:09:12] 10WikiEditor, 6Multimedia, 5WMF-deploy-2015-10-27_(1.27.0-wmf.4), 7user-notice: Allow uploading files directly from the wikitext editor - https://phabricator.wikimedia.org/T115748#1749089 (10Quiddity) [19:28:23] 10VisualEditor, 10VisualEditor-MediaWiki: When a editors have a single edit tab, keep the existing keyboard shortcuts that allow them to explicitly choose which editing environment to open - https://phabricator.wikimedia.org/T116406#1749158 (10Krenair) I don't think it makes a lot of sense for this to be a sep... [19:41:53] 10Cite: Invisible citation errors - https://phabricator.wikimedia.org/T116377#1749217 (10IKhitron) [19:42:23] 10Cite: Invisible citation error - https://phabricator.wikimedia.org/T116377#1749220 (10IKhitron) [19:44:00] 10Cite: Two cite errors get empty error messages. - https://phabricator.wikimedia.org/T116411#1749222 (10IKhitron) [19:52:19] Kemayo, is your patch adding to the commandHelp dialog or creating a new one? [19:52:28] Adding to. [19:52:57] I put a picture in phabricator showing what it does: https://phab.wmfusercontent.org/file/data/tk24mplhvzdnqw2vfudj/PHID-FILE-iggcqviknlw5nctmioam/Screenshot_2015-10-23_12.03.58.png [19:54:04] Oops, I see that left a reference to a brief stab I took at a separate dialog in there. I'll strip that out. [19:54:08] ah [19:54:11] also I [19:54:24] also I'm not seeing any sequences in my help page [19:54:30] oh wait - let me check MW [19:55:34] The core VE experience contains only two sequences, the "* " and "1. " ones. [19:56:10] (03PS3) 10DLynch: Include sequences in the command help dialog [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/248370 (https://phabricator.wikimedia.org/T116013) [19:57:00] The MW one needs https://gerrit.wikimedia.org/r/#/c/248373/ applied to that repo as well, to register those sequences in the MWCommandHelpDialog. [19:58:47] oh, I see them now [19:59:40] my instinct is that we need a way of distinguishing them from shortcuts [20:00:09] are you aware of other people who have done this, I'll have a look too [20:01:35] Oh, there's also the autolink sequence. That one is a bit harder to convey, without just writing out "[any url][space]". [20:04:31] I couldn't think of anywhere else that does it, at least not mixed in with shortcuts like this. [20:06:49] What _might_ make sense would be to make a fairly major change to that dialog -- wrap every single key in a little box like I used on "[space]" to emphasize that it's representing a single key-press, then for the existing shortcut-triggers include a "+" between the keys, to say "press these at the same time". [20:07:18] I like that idea. [20:08:05] I suspect that switching to "[ctrl]" from "^" would make more sense to most random editors, also. :) [20:08:19] I wouldn't worry about the autolink sequence [20:08:36] Yeah. [20:08:41] (To both.) [20:09:30] Isn't "^" a mac thing? [20:10:17] No. [20:10:35] It is, actually -- it's what the OS uses in keyboard shortcuts in menus. [20:10:46] It's also ^ on UNIX I think? [20:10:59] e.g. https://usercontent.irccloud-cdn.com/file/P5T9cQaq/ [20:11:53] Ctrl is standard for "Windows" keyboards [20:11:58] 10Citoid, 10VisualEditor, 10ContentTranslation-Deployments, 10MediaWiki-ResourceLoader: Messages randomly missing in some languages when populating MessageBlobStore - https://phabricator.wikimedia.org/T93800#1749303 (10Krinkle) [20:12:41] I suppose this could just be me proving that despite years spent using OSX, I still haven't quite internalized what the standard platform representation of that key is. [20:12:46] 10Citoid, 10VisualEditor, 10ContentTranslation-Deployments, 10MediaWiki-ResourceLoader: Messages randomly missing in some languages when populating MessageBlobStore - https://phabricator.wikimedia.org/T93800#1439278 (10Krinkle) [20:12:55] we have mac mappings [20:12:56] var names = { [20:12:56] meta: '⌘', [20:12:57] shift: '⇧', [20:12:57] backspace: '⌫', [20:12:57] ctrl: '^', [20:12:58] alt: '⎇', [20:13:00] escape: '⎋' [20:13:02] }; [20:14:05] Kemayo, can you post a screenshot of your proposal? [20:14:22] Sure. Give me a minute to mock it up. [20:14:34] yeah no hurry [20:16:03] Kemayo, so in PC mode it shows ' + ' [20:16:55] I think it doesn't in Mac mode because the shorthand ⌘C is more common? but I didn't write that, maybe it was TrevorP|Away [20:17:37] Google image search of "mac keyboard shortcuts" shows that appears to be the case [20:17:56] but some people do the box thing, [⌘] + [C] [20:18:04] In Mac mode it's making an effort to adhere to the system UI convention for shortcuts, like in that menu-screenshot I shared. Which makes sense. It's just that once we include the text replacements as well, it might make sense to deviate from the system convention for clarity. [20:18:19] * James_F nods. [20:18:33] [⌘] + [C] instead of ⌘C WFM. [20:20:36] what about "Type *[Space]" [20:21:45] With "Type" in a non-fixed-width font [20:24:18] That'd look like: https://usercontent.irccloud-cdn.com/file/7gZBFJlO/ [20:25:18] Maybe italicised [20:25:19] ? [20:25:25] (The "type" command) [20:25:37] (Woo, design by committee. I'll shut up. :-)) [20:29:22] 10VisualEditor, 10VisualEditor-MediaWiki, 7Design, 7Epic: Provide a single edit tab which has both visual and wikitext modes and allows on-the-fly switching between them - https://phabricator.wikimedia.org/T102398#1749346 (10Neil_P._Quinn_WMF) @Esanders, I think there's also another class of discoverabilit... [20:32:47] (03CR) 10Esanders: [C: 04-1] Include sequences in the command help dialog (031 comment) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/248370 (https://phabricator.wikimedia.org/T116013) (owner: 10DLynch) [20:48:43] edsanders / James_F: here's the keys version. https://usercontent.irccloud-cdn.com/file/1EONArmT/ [20:49:21] I do like that. [20:50:19] There's probably more that could be done to make those outlines say "I am a key!" via design. [20:50:30] e.g. IRCcloud does: https://usercontent.irccloud-cdn.com/file/3xZ6jFNQ/ [20:50:36] Giving them a little more weight. [20:51:10] I think the difference between [A]+[B] and [A][B] is quite subtle [20:52:17] Could merge these things together and add "type: " to the key-version. [20:53:12] Yeah [20:55:37] That'd get us approximately this: https://usercontent.irccloud-cdn.com/file/vtVXlSmk/ [21:00:06] And here, with a bit more in the way of key-styling: https://usercontent.irccloud-cdn.com/file/9m2bdauo/ [21:01:27] nice [21:02:54] be careful there's still room in PC mode [21:04:10] It still seems to work out: https://usercontent.irccloud-cdn.com/file/Hnqn9bwB/ [21:06:21] ew, keeping the monospace? [21:06:38] keyboards don't have monospace fonts written on them anymore. :) [21:08:00] the "[Ctrl]+[(1-6)]" looks pretty weird… i'd format it as "[Ctrl]+[1], [Ctrl]+[2], ..." or something [21:08:51] Here's the full MW version, also: https://usercontent.irccloud-cdn.com/file/sH6Cc9de/ [21:12:13] MatmaRex: I'll grant that non-mono would mostly be more accurate... but it also has a general connotation of user-input which is nice to keep... [21:13:16] (03PS4) 10DLynch: Include sequences in the command help dialog [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/248370 (https://phabricator.wikimedia.org/T116013) [21:14:10] MatmaRex: I also think that (1-6) is probably an acceptable compromise to avoid taking up a bunch of space. Though with the key-borders, we could probably dump the brackets around them at least. [21:21:28] (03PS5) 10DLynch: Include sequences in the command help dialog [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/248370 (https://phabricator.wikimedia.org/T116013) [21:23:36] Ed raised the point that we should perhaps be internationalizing the "space" key there. I'm of two minds about that. On the one hand, obviously it must be called other things in other countries... but on the other hand, we're not currently internationalizing the other modifier-keys (control, meta, etc), so it might be more consistent to keep this one [21:23:36] untranslated as well. [21:24:49] You probably do want to translate the modifier keys [21:24:56] German has all sorts of strange names for them [21:25:19] OTOH I don't know how much those are used any more [21:25:33] 10VisualEditor, 10VisualEditor-EditingTools, 5Patch-For-Review: Show sequence shortcuts in the help dialog (CommandHelpDialog) - https://phabricator.wikimedia.org/T116013#1749479 (10DLynch) Following a bunch of feedback, it now looks like: {F2760885} This has changed the rendering of existing shortcuts, to... [21:34:04] you can do that as a separate commit [21:49:19] edsanders: All of them at once, or should I get the space in here while I'm touching it anyway? [22:15:12] (03PS2) 10Alex Monk: [WIP] Single edit tab [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/248369 (https://phabricator.wikimedia.org/T114530) [22:17:49] (03CR) 10jenkins-bot: [V: 04-1] [WIP] Single edit tab [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/248369 (https://phabricator.wikimedia.org/T114530) (owner: 10Alex Monk) [22:19:14] (03PS3) 10Alex Monk: [WIP] Single edit tab [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/248369 (https://phabricator.wikimedia.org/T114530) [22:33:31] (03PS1) 10Legoktm: build: Updating development dependencies [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/248550 [22:34:26] (03PS1) 10Legoktm: build: Updating development dependencies [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/248557 [22:40:00] Kemayo, either's fine [22:43:34] (03CR) 10Jforrester: [C: 032] build: Updating development dependencies [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/248557 (owner: 10Legoktm) [22:43:50] (03CR) 10Jforrester: [C: 032] build: Updating development dependencies [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/248550 (owner: 10Legoktm) [22:44:01] 10VisualEditor, 10VisualEditor-Performance, 10MediaWiki-General-or-Unknown, 10MediaWiki-Interface, and 10 others: Use Parsoid HTML for all page views - https://phabricator.wikimedia.org/T55784#1749754 (10GWicke) [22:44:58] Kemayo: Do it as follow-up including the space with ctrl/alt/meta/etc. [22:46:25] Works for me. [22:46:47] (03Merged) 10jenkins-bot: build: Updating development dependencies [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/248557 (owner: 10Legoktm) [22:46:52] (03Merged) 10jenkins-bot: build: Updating development dependencies [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/248550 (owner: 10Legoktm)