[00:14:25] (03CR) 10Alex Monk: "I think we should fix core rather than hide it in VE..." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/249022 (https://phabricator.wikimedia.org/T116693) (owner: 10Catrope) [00:54:00] (03CR) 10Krinkle: [C: 032] DesktopArticleTarget.init: Tolerate missing wgRelevantPageName [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/249022 (https://phabricator.wikimedia.org/T116693) (owner: 10Catrope) [00:54:07] (03PS1) 10Krinkle: DesktopArticleTarget.init: Tolerate missing wgRelevantPageName [extensions/VisualEditor] (wmf/1.27.0-wmf.3) - 10https://gerrit.wikimedia.org/r/249040 (https://phabricator.wikimedia.org/T116693) [00:54:34] (03CR) 10Krinkle: [C: 032] DesktopArticleTarget.init: Tolerate missing wgRelevantPageName [extensions/VisualEditor] (wmf/1.27.0-wmf.3) - 10https://gerrit.wikimedia.org/r/249040 (https://phabricator.wikimedia.org/T116693) (owner: 10Krinkle) [00:56:52] (03Merged) 10jenkins-bot: DesktopArticleTarget.init: Tolerate missing wgRelevantPageName [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/249022 (https://phabricator.wikimedia.org/T116693) (owner: 10Catrope) [00:59:19] (03Merged) 10jenkins-bot: DesktopArticleTarget.init: Tolerate missing wgRelevantPageName [extensions/VisualEditor] (wmf/1.27.0-wmf.3) - 10https://gerrit.wikimedia.org/r/249040 (https://phabricator.wikimedia.org/T116693) (owner: 10Krinkle) [01:00:53] (03CR) 10Alex Monk: "Feel like addressing my comment, Krinkle?" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/249022 (https://phabricator.wikimedia.org/T116693) (owner: 10Catrope) [01:01:23] (03CR) 10Krinkle: "Yes, I'm actively working with Roan to fix this in core. But UBN." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/249022 (https://phabricator.wikimedia.org/T116693) (owner: 10Catrope) [01:02:25] Krenair: we're in #wikimedia-perf [01:02:34] fair enough [01:07:48] (03PS1) 10Krinkle: Revert "DesktopArticleTarget.init: Tolerate missing wgRelevantPageName" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/249042 [01:38:25] (03PS4) 10Alex Monk: [WIP] Dialog for switching between wikitext and visual editing [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/247485 [01:38:27] (03PS6) 10Alex Monk: [WIP] Allow switching from wikitext to VE [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/245593 (https://phabricator.wikimedia.org/T49779) [01:38:45] (03Abandoned) 10Alex Monk: Make the wikitext switch confirmation dialog independent of the target [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/247484 (owner: 10Alex Monk) [01:39:49] (03PS5) 10Alex Monk: [WIP] Dialog for switching between wikitext and visual editing [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/247485 [01:41:39] (03CR) 10jenkins-bot: [V: 04-1] [WIP] Allow switching from wikitext to VE [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/245593 (https://phabricator.wikimedia.org/T49779) (owner: 10Alex Monk) [01:43:13] (03CR) 10jenkins-bot: [V: 04-1] [WIP] Dialog for switching between wikitext and visual editing [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/247485 (owner: 10Alex Monk) [01:46:45] (03PS6) 10Alex Monk: [WIP] Dialog for switching between wikitext and visual editing [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/247485 [01:46:47] (03PS7) 10Alex Monk: [WIP] Allow switching from wikitext to VE [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/245593 (https://phabricator.wikimedia.org/T49779) [02:27:56] (03CR) 10Krinkle: [C: 04-1] Introduce template format (032 comments) [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/243138 (https://phabricator.wikimedia.org/T64147) (owner: 10Eranroz) [07:16:27] (03PS4) 10Divec: WIP: Diff richtext to build model changes [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/247800 [09:29:28] (03PS1) 10Divec: WIP: Build model transactions from richtext DOM diff [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/249077 [09:29:37] (03CR) 10jenkins-bot: [V: 04-1] WIP: Build model transactions from richtext DOM diff [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/249077 (owner: 10Divec) [09:35:26] 10VisualEditor, 10VisualEditor-ContentEditable, 7Technical-Debt: Break up ve.ce.Surface.js by functionality - https://phabricator.wikimedia.org/T78696#1756554 (10Esanders) [09:36:42] (03PS4) 10Esanders: Remove selectionStart and selectionEnd events [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/248919 [09:36:44] (03PS2) 10Esanders: Introduce key down handlers to spearate logic from ce surface [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/248911 (https://phabricator.wikimedia.org/T78696) [09:36:46] (03PS1) 10Esanders: ve.dm.Selection: Add getter for name static property [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/249078 [09:36:48] (03PS1) 10Esanders: DataTransferHandlerFactory: Fix documentation [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/249079 [09:39:04] (03CR) 10Gilles: [C: 032] Revert "DesktopArticleTarget.init: Tolerate missing wgRelevantPageName" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/249042 (owner: 10Krinkle) [09:40:20] (03CR) 10jenkins-bot: [V: 04-1] Introduce key down handlers to spearate logic from ce surface [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/248911 (https://phabricator.wikimedia.org/T78696) (owner: 10Esanders) [09:47:25] (03CR) 10jenkins-bot: [V: 04-1] Revert "DesktopArticleTarget.init: Tolerate missing wgRelevantPageName" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/249042 (owner: 10Krinkle) [10:19:30] 10VisualEditor, 6Collaboration-Team-Backlog, 10Flow, 10UI-Standardization, 7Design: Come up with a better re-usable UI concept for a button to switch editor-mode; the current one is confusing, and hard to discover - https://phabricator.wikimedia.org/T116417#1756670 (10Trizek-WMF) >>! In T116417#1752597,... [10:49:35] (03CR) 10Jforrester: "recheck" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/249042 (owner: 10Krinkle) [10:52:51] (03CR) 10Jforrester: [C: 032] DataTransferHandlerFactory: Fix documentation [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/249079 (owner: 10Esanders) [10:54:02] (03CR) 10Jforrester: [C: 032] ve.dm.Selection: Add getter for name static property [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/249078 (owner: 10Esanders) [10:54:42] (03CR) 10Jforrester: [C: 032] Remove selectionStart and selectionEnd events [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/248919 (owner: 10Esanders) [10:59:52] (03CR) 10Jforrester: [C: 032] Revert "DesktopArticleTarget.init: Tolerate missing wgRelevantPageName" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/249042 (owner: 10Krinkle) [11:02:29] (03PS3) 10Esanders: Introduce key down handlers to spearate logic from ce surface [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/248911 (https://phabricator.wikimedia.org/T78696) [11:21:28] (03Merged) 10jenkins-bot: Remove selectionStart and selectionEnd events [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/248919 (owner: 10Esanders) [11:21:30] (03Merged) 10jenkins-bot: ve.dm.Selection: Add getter for name static property [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/249078 (owner: 10Esanders) [11:21:32] (03Merged) 10jenkins-bot: DataTransferHandlerFactory: Fix documentation [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/249079 (owner: 10Esanders) [11:21:34] (03Merged) 10jenkins-bot: Revert "DesktopArticleTarget.init: Tolerate missing wgRelevantPageName" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/249042 (owner: 10Krinkle) [11:45:28] Krenair, I think we should separate the UE popups [11:45:44] so instead of mixins they are separate classes [11:46:07] they can reference a tool by name, and be stored in a registry [11:47:13] at a point in DesktopArticleTarget when the toolbar is built, we can iterate the whole registry and they can be attached to the relevant tool [11:51:44] 10VisualEditor, 7Browser-Support-Apple-Safari: [iOS Safari on desktop site] References do not get updated - https://phabricator.wikimedia.org/T116520#1756887 (10Nnemo) >>! In T116520#1751503, @Aklapper wrote: > @Nnemo: Thanks! What does "I change the ref" mean, for better steps to reproduc? I click the ref c... [11:53:18] edsanders, sounds like a good idea [11:54:01] (03CR) 10Jforrester: [C: 032] "Neat." [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/248911 (https://phabricator.wikimedia.org/T78696) (owner: 10Esanders) [11:55:15] (03CR) 10Divec: Introduce key down handlers to spearate logic from ce surface (031 comment) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/248911 (https://phabricator.wikimedia.org/T78696) (owner: 10Esanders) [12:13:00] 10VisualEditor, 10MediaWiki-Page-editing, 7Browser-Support-Apple-Safari: [iOS Safari on desktop site] References do not get updated - https://phabricator.wikimedia.org/T116520#1756949 (10Nnemo) [12:19:30] >>> JSON.stringify(NaN); [12:19:30] Krenair: (string) 'null' [12:21:59] >>> 0 - undefined [12:22:00] Krenair: (number) NaN [12:24:07] 10VisualEditor, 10VisualEditor-MediaWiki-Mobile, 6Editing-Department, 10MediaWiki-Page-editing, and 2 others: Make the mobile edit conflict screen nicer to use - https://phabricator.wikimedia.org/T113844#1756971 (10Nnemo) "Right now it's the desktop screen" Is it? Until now, for me, whenever the mobile... [12:27:23] 10VisualEditor, 10VisualEditor-MediaWiki-Mobile, 6Editing-Department, 10MediaWiki-Page-editing, and 2 others: Make the mobile edit conflict screen nicer to use - https://phabricator.wikimedia.org/T113844#1756981 (10Krenair) As of https://gerrit.wikimedia.org/r/#/c/241249/ that was the case, yes. [12:36:58] 10VisualEditor, 10VisualEditor-MediaWiki, 7Wikimedia-log-errors: Invalid value None for integer property "action.abort.timing" (schema:Edit) - https://phabricator.wikimedia.org/T116718#1757009 (10Krenair) [13:12:13] 10VisualEditor, 7Technical-Debt: Abstract away Selection handling from the surface - https://phabricator.wikimedia.org/T116748#1757078 (10Esanders) 3NEW [13:14:55] (03CR) 10Esanders: Introduce key down handlers to spearate logic from ce surface (031 comment) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/248911 (https://phabricator.wikimedia.org/T78696) (owner: 10Esanders) [13:14:59] (03CR) 10Jforrester: "(Removed C+2 per David's question.)" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/248911 (https://phabricator.wikimedia.org/T78696) (owner: 10Esanders) [13:16:57] (03PS4) 10Esanders: Introduce key down handlers to spearate logic from ce surface [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/248911 (https://phabricator.wikimedia.org/T78696) [13:22:19] 10VisualEditor, 10VisualEditor-MediaWiki, 7Design, 7Epic: Provide a single edit tab which has both visual and wikitext modes and allows on-the-fly switching between them - https://phabricator.wikimedia.org/T102398#1757113 (10Esanders) > When someone click edit the first time, a splash screen with these cho... [13:28:08] 10VisualEditor, 10VisualEditor-MediaWiki, 7Design, 7Epic: Provide a single edit tab which has both visual and wikitext modes and allows on-the-fly switching between them - https://phabricator.wikimedia.org/T102398#1757124 (10Esanders) Copying comment over from T114530 >>! In T114530#1748715, @Elitre wrote:... [13:33:12] 10VisualEditor, 10VisualEditor-MediaWiki, 7Design, 7Epic: Provide a single edit tab which has both visual and wikitext modes and allows on-the-fly switching between them - https://phabricator.wikimedia.org/T102398#1757133 (10Esanders) I am also concerned that due to the progress we have made getting establ... [13:40:05] 10VisualEditor, 10Parsoid: Unbalanced div tags, damaged title, ... - https://phabricator.wikimedia.org/T116751#1757142 (10NicoV) 3NEW [13:51:09] 10VisualEditor, 10VisualEditor-ContentEditable: VisualEditor: Ctrl-Space to insert a non-breaking space (NBSP), and a way to see the difference - https://phabricator.wikimedia.org/T53045#1757182 (10Esanders) >>! In T70429#1224015, @Esanders wrote: > Or you could somehow annotate the whole word as nowrap. Argua... [14:38:35] 10VisualEditor, 10VisualEditor-MediaWiki, 7Design, 7Epic: Provide a single edit tab which has both visual and wikitext modes and allows on-the-fly switching between them - https://phabricator.wikimedia.org/T102398#1757352 (10Trizek-WMF) >>! In T102398#1757113, @Esanders wrote: > As we are not changing anyo... [14:41:34] 10VisualEditor, 10VisualEditor-MediaWiki: Site subtitle lighter that title in edit mode - https://phabricator.wikimedia.org/T116755#1757361 (10Esanders) 3NEW a:3Esanders [14:41:46] (03PS4) 10Esanders: DesktopTarget: Fix opacity of #siteSub and #contentSub [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/248356 (https://phabricator.wikimedia.org/T116755) [14:45:54] 10VisualEditor, 10Parsoid, 7Epic: HTML diffs of edits for everything - https://phabricator.wikimedia.org/T105173#1757382 (10Esanders) @cscott Does Parsoid generate HTML string diffs or DOM diffs? We had briefly looked at https://github.com/fiduswriter/diffDOM. [14:52:37] 10VisualEditor, 10VisualEditor-MediaWiki, 7Epic: VisualEditor: Implement some form of auto-save - https://phabricator.wikimedia.org/T57370#1757412 (10Esanders) [14:55:17] (03CR) 10Esanders: [C: 032] Disable input field on lookup, too [extensions/Citoid] - 10https://gerrit.wikimedia.org/r/248616 (https://phabricator.wikimedia.org/T116471) (owner: 10Florianschmidtwelzow) [14:56:52] (03Merged) 10jenkins-bot: Disable input field on lookup, too [extensions/Citoid] - 10https://gerrit.wikimedia.org/r/248616 (https://phabricator.wikimedia.org/T116471) (owner: 10Florianschmidtwelzow) [15:12:29] 10VisualEditor, 10Parsoid, 7Epic: HTML diffs of edits for everything - https://phabricator.wikimedia.org/T105173#1757547 (10ssastry) We generate DOM diffs internally for selective serialization, if that is what you are asking about. [15:14:25] 10VisualEditor: On French WIkipedia, collapsible templates should at their default state when you've saved your edit - https://phabricator.wikimedia.org/T116765#1757551 (10Trizek-WMF) 3NEW [15:21:54] 10VisualEditor, 7Browser-Support-Apple-Safari: [iOS Safari on desktop site] References do not get updated - https://phabricator.wikimedia.org/T116520#1757585 (10Aklapper) [15:27:23] >> timeStamp = 1/0; ( timeStamp === undefined || timeStamp === NaN ) [15:27:23] James_F: (boolean) false [15:28:11] Meh. [15:28:52] >>> 1/0 [15:28:52] Krenair: (number) Infinity [15:28:56] Yup. [15:29:14] >> timeStamp = NaN; ( timeStamp === undefined || Number.isNaN( timeStamp ) ) [15:29:14] James_F: (boolean) true [15:29:19] >> timeStamp = 1/0; ( timeStamp === undefined || Number.isNaN( timeStamp ) ) [15:29:19] James_F: (boolean) false [15:29:23] >> timeStamp = -1/0; ( timeStamp === undefined || Number.isNaN( timeStamp ) ) [15:29:23] James_F: (boolean) false [15:29:48] >> timeStamp = -1/0; ( timeStamp === undefined || Number.isNaN( timeStamp ) || !Number.isFinite( timeStamp ) ) [15:29:48] James_F: (boolean) true [15:29:50] (03PS1) 10Esanders: Save dialog: Fix border radii [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/249142 [15:29:53] That'll do. [15:32:47] (03PS1) 10Jforrester: mw.trackSubscriber: Handle timeStamp being undef/NaN/infinite [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/249143 (https://phabricator.wikimedia.org/T116718) [15:32:53] Krenair: ^^^ Look sane? [15:33:30] I don't think that's what's going wrong here [15:33:46] >>> undefined - 0 [15:33:47] Krenair: (number) NaN [15:33:56] >>> 0 - undefined [15:33:57] Krenair: (number) NaN [15:34:10] I suspect it's the second of those happening in this case, timing.ready is not set [15:34:21] but timeStamp is given [15:34:56] Hmm. Possible. [15:35:10] Should I do the same with timing.X? [15:35:21] did you see https://phabricator.wikimedia.org/T116718#1757007 ? [15:35:53] I managed to reproduce the error locally earlier like this [15:36:04] No. Interesting. [15:39:05] Hallo. [15:39:52] Hi [15:45:39] 10VisualEditor, 10Wikimedia-Site-Requests, 5Patch-For-Review: Activate the visual editor on ns-102 (Projet) namespace on French Wikipedia - https://phabricator.wikimedia.org/T116603#1757674 (10Jdforrester-WMF) 5Open>3Resolved This is now done. [15:55:08] (03CR) 10Alex Monk: [C: 032] Check lookup button state when handle input 'enter' event [extensions/Citoid] - 10https://gerrit.wikimedia.org/r/248836 (https://phabricator.wikimedia.org/T116471) (owner: 10Esanders) [15:55:16] (03PS1) 10Jforrester: mw.trackSubscriber: If the number is NaN/falsy, return -1; [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/249149 (https://phabricator.wikimedia.org/T116718) [16:01:18] 10Citoid, 10VisualEditor, 5Patch-For-Review, 5WMF-deploy-2015-10-27_(1.27.0-wmf.4): VE Cite widget: It's possible to submit the form twice - https://phabricator.wikimedia.org/T116471#1757798 (10Jdforrester-WMF) 5Open>3Resolved [16:03:39] (03Merged) 10jenkins-bot: Check lookup button state when handle input 'enter' event [extensions/Citoid] - 10https://gerrit.wikimedia.org/r/248836 (https://phabricator.wikimedia.org/T116471) (owner: 10Esanders) [16:09:05] Krenair: 249149 as well maybe? [16:09:25] sorry, I'm trying to juggle like 3 things at once here [16:09:36] No worries. :-) [16:19:12] (03CR) 10Jforrester: DesktopTarget: Fix opacity of #siteSub and #contentSub (031 comment) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/248356 (https://phabricator.wikimedia.org/T116755) (owner: 10Esanders) [16:27:00] 10VisualEditor, 10MediaWiki-General-or-Unknown: Subpages of special pages shouldn't be marked as "redlinks" - https://phabricator.wikimedia.org/T116775#1757909 (10Florian) 3NEW [16:29:59] 10VisualEditor, 10MediaWiki-General-or-Unknown: Subpages of special pages shouldn't be marked as "redlinks" - https://phabricator.wikimedia.org/T116775#1757922 (10Jdforrester-WMF) [16:30:01] 10VisualEditor, 10VisualEditor-MediaWiki, 10GlobalUserPage, 10MediaWiki-extensions-EducationProgram: VisualEditor redlink detection should obey Title::isAlwaysKnown (so that links to Special pages, EducationProgram pages and GlobalUserPages render correctly) - https://phabricator.wikimedia.org/T72123#1757923... [16:40:52] (03CR) 10Mvolz: [C: 04-1] Add button to convert plain URL references (031 comment) [extensions/Citoid] - 10https://gerrit.wikimedia.org/r/248849 (https://phabricator.wikimedia.org/T114564) (owner: 10Esanders) [17:01:08] (03PS1) 10Esanders: Remove non-existent browser prefix [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/249164 [17:27:09] (03PS9) 10DLynch: Include sequences in the command help dialog [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/248370 (https://phabricator.wikimedia.org/T116013) [17:28:21] (03PS4) 10DLynch: Add mediawiki-specific sequences to the command help dialog [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/248373 (https://phabricator.wikimedia.org/T116013) [17:30:08] (03CR) 10jenkins-bot: [V: 04-1] Add mediawiki-specific sequences to the command help dialog [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/248373 (https://phabricator.wikimedia.org/T116013) (owner: 10DLynch) [17:32:19] Heh, right, using @inheritdoc when the doc it'd be inheriting doesn't exist yet because it's in a different changeset. [17:34:58] :-) [18:00:35] (03PS1) 10Jforrester: Update OOjs UI to v0.13.0 [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/249186 [18:18:18] 10VisualEditor, 7Tracking: Tracking IME issues on Korean Wikipedia - https://phabricator.wikimedia.org/T110654#1758638 (10Trizek-WMF) [18:18:19] 10VisualEditor, 7Tracking: Tracking IME issues on Japanese Wikipedia - https://phabricator.wikimedia.org/T109818#1758639 (10Trizek-WMF) [18:19:26] 10VisualEditor, 10Phlogiston, 7WorkType-NewFunctionality: Restore VE tranches to report - https://phabricator.wikimedia.org/T115941#1758651 (10JAufrecht) [18:21:22] 10Cite: Invalid HTML markup standalone LI element when using references on main page - https://phabricator.wikimedia.org/T73023#766851 (10Jdlrobson) [18:41:50] (03CR) 10Bartosz DziewoƄski: [C: 032] Update OOjs UI to v0.13.0 [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/249186 (owner: 10Jforrester) [18:53:53] (03Merged) 10jenkins-bot: Update OOjs UI to v0.13.0 [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/249186 (owner: 10Jforrester) [19:03:06] (03PS1) 10Esanders: AceEditorWidget: Make setters chainable and support invalid flag [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/249204 [19:22:14] (03CR) 10Jforrester: [C: 032] AceEditorWidget: Make setters chainable and support invalid flag [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/249204 (owner: 10Esanders) [19:40:02] (03PS1) 10Jforrester: Update VE core submodule to master (956db1c) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/249226 [19:40:15] (03Merged) 10jenkins-bot: AceEditorWidget: Make setters chainable and support invalid flag [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/249204 (owner: 10Esanders) [20:07:52] (03CR) 10Esanders: Add button to convert plain URL references (031 comment) [extensions/Citoid] - 10https://gerrit.wikimedia.org/r/248849 (https://phabricator.wikimedia.org/T114564) (owner: 10Esanders) [21:13:47] (03CR) 10Krinkle: [C: 04-1] mw.trackSubscriber: Handle timeStamp being undef/NaN/infinite (031 comment) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/249143 (https://phabricator.wikimedia.org/T116718) (owner: 10Jforrester) [21:14:02] (03PS2) 10Krinkle: mw.trackSubscriber: If the number is NaN/falsy, return -1; [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/249149 (https://phabricator.wikimedia.org/T116718) (owner: 10Jforrester) [21:16:05] (03CR) 10Krinkle: "It'll depend on how the data is consumed, but if this is what I think it is (ve.timing, puppet/webperf/ve.py, statsd, graphite) then -1 wi" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/249149 (https://phabricator.wikimedia.org/T116718) (owner: 10Jforrester) [21:51:15] 10VisualEditor, 10Phlogiston, 3Discovery-Analysis-Sprint, 3Team-Practices-This-Week, 7WorkType-NewFunctionality: Help requested from an R expert to help tweak phlogiston (burnup chart scripts) - https://phabricator.wikimedia.org/T110080#1759690 (10JAufrecht) [21:52:46] 10VisualEditor, 10Phlogiston, 7WorkType-NewFunctionality: Create third version of VE burnup report - https://phabricator.wikimedia.org/T107482#1759704 (10JAufrecht) [22:06:12] (03PS4) 10Esanders: Add button to convert plain URL references [extensions/Citoid] - 10https://gerrit.wikimedia.org/r/248849 (https://phabricator.wikimedia.org/T114564) [22:19:46] 10VisualEditor, 10Graph-VisualEditor: Styling regressions in table widget - https://phabricator.wikimedia.org/T116854#1759869 (10Esanders) 3NEW a:3ferdbold [22:22:51] (03CR) 10Alex Monk: [C: 04-1] "per Krinkle" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/249149 (https://phabricator.wikimedia.org/T116718) (owner: 10Jforrester) [22:28:00] 10Cite: Two cite errors get empty error messages. - https://phabricator.wikimedia.org/T116411#1759898 (10IKhitron) p:5Triage>3High [23:37:55] are the VE education features using GuidedTour? [23:38:08] or something else? [23:41:27] no