[00:01:06] ty [05:26:45] 10VisualEditor: VE adds span tags with lang and dir attributes - https://phabricator.wikimedia.org/T116887#1760925 (10Magioladitis) 3NEW [05:53:44] I added Template data to https://www.mediawiki.org/wiki/Template:Tech_talk_video/doc , yet VE says 'You are adding the "Tech talk video" template to this page. It doesn't yet have a description' Does VE cache template data? [06:04:15] The action=templatedata request doesn't find the template data that's in the /doc subpage [06:08:38] It's a pageprop, but e.g. Template:Irc has a templatedata pageprop, while Template:Tech_talk_video doesn't. Maybe the cache will catch up overnight, good night [07:40:35] 10VisualEditor, 10VisualEditor-MediaWiki, 6Editing-Analysis, 5Patch-For-Review, 7Wikimedia-log-errors: Invalid value None for integer property "action.abort.timing" (schema:Edit) - https://phabricator.wikimedia.org/T116718#1761075 (10Jdforrester-WMF) p:5Triage>3High a:3Jdforrester-WMF [07:52:22] Also, npm's Markdown formatter doesn't work like GitHub's – see "major changes should be discussed". [08:22:02] (03PS1) 10Jforrester: Fix two uses of now-removed OOUI mixin aliases [extensions/Citoid] - 10https://gerrit.wikimedia.org/r/249362 [08:29:37] (03CR) 10Jforrester: mw.trackSubscriber: Handle timeStamp being undef/NaN/infinite (031 comment) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/249143 (https://phabricator.wikimedia.org/T116718) (owner: 10Jforrester) [08:31:34] (03PS2) 10Jforrester: mw.trackSubscriber: Handle timeStamp being undef/NaN/infinite [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/249143 (https://phabricator.wikimedia.org/T116718) [08:35:29] (03CR) 10Jforrester: "We already explicitly return -1 where there isn't a valid value, and have been doing this for the entire duration of this schema." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/249149 (https://phabricator.wikimedia.org/T116718) (owner: 10Jforrester) [08:35:38] (03PS3) 10Jforrester: mw.trackSubscriber: If the number is NaN/falsy, return -1; [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/249149 (https://phabricator.wikimedia.org/T116718) [08:35:47] (03CR) 10jenkins-bot: [V: 04-1] mw.trackSubscriber: Handle timeStamp being undef/NaN/infinite [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/249143 (https://phabricator.wikimedia.org/T116718) (owner: 10Jforrester) [09:30:00] edsanders: Ready when you are [09:32:01] Krenair: Are you joining too? [09:32:33] ("No" is a fine answer.) [09:35:29] edsanders: … [09:35:38] "trying to join the call..." [11:12:16] 10VisualEditor, 6Collaboration-Team-Backlog, 10Flow, 10UI-Standardization, 7Design: Come up with a better re-usable UI concept for a button to switch editor-mode; the current one is confusing, and hard to discover - https://phabricator.wikimedia.org/T116417#1761384 (10Pginer-WMF) > I may have other examp... [11:24:04] 10VisualEditor, 10VisualEditor-Performance, 10MediaWiki-General-or-Unknown, 10MediaWiki-Interface, and 10 others: Use Parsoid HTML for all page views - https://phabricator.wikimedia.org/T55784#1761422 (10Qgil) With so many blocking/blocked tasks, no specific Summit plans specified in the description, and n... [11:30:55] 10VisualEditor, 10VisualEditor-Performance, 10MediaWiki-General-or-Unknown, 10MediaWiki-Interface, and 10 others: Use Parsoid HTML for all page views - https://phabricator.wikimedia.org/T55784#1761442 (10mobrovac) @Qgil, the reason is that this requires a wide cross-org consensus (and later work), so I'd s... [11:47:24] (03CR) 10Siebrand: [C: 031] "i18n/L10n reviewed." [extensions/Citoid] - 10https://gerrit.wikimedia.org/r/248849 (https://phabricator.wikimedia.org/T114564) (owner: 10Esanders) [12:33:50] James_F, my alarm didn't go off as expected so I missed this, sorry. Was almost late for class too [12:39:21] was anything decided? [12:46:24] 10Cite: Two cite errors get empty error messages. - https://phabricator.wikimedia.org/T116411#1761587 (10Aklapper) @IKhitron: Thanks for reporting this. Could you elaborate [[ https://www.mediawiki.org/wiki/Phabricator/Project_management#Setting_task_priorities | why you think this task is urgent ]]? [12:51:03] 10Cite: Two cite errors get empty error messages. - https://phabricator.wikimedia.org/T116411#1761595 (10IKhitron) I think it is urgent for you to know this. After 5 days without answer it seems like noone saw this. If "Cite" project programmer thinks it is not urgent - he can always change this. And why do I th... [13:22:51] 10Cite: Two cite errors get empty error messages. - https://phabricator.wikimedia.org/T116411#1761669 (10matmarex) I can't reproduce either of these issues. [13:24:17] 10Cite: Two cite errors get empty error messages. - https://phabricator.wikimedia.org/T116411#1761677 (10IKhitron) Hi, @matmarex. Try [[https://he.wikipedia.org/wiki/%D7%9E%D7%A9%D7%AA%D7%9E%D7%A9:IKhitron/%D7%98%D7%99%D7%95%D7%98%D7%94|here]]. [13:27:02] Krenair: A bit. Talk to edsanders? [13:45:52] 10Cite: The key shown in the "Cite error references duplicate key" error message contains underscores instead of spaces - https://phabricator.wikimedia.org/T116532#1761705 (10matmarex) [13:45:54] 10Cite: Coded unreadable reference name in 3 media wiki messages in non-ASCII languages - https://phabricator.wikimedia.org/T115809#1761706 (10matmarex) [13:46:41] 10Cite: Two cite errors get empty error messages. - https://phabricator.wikimedia.org/T116411#1761709 (10matmarex) Hmm, yeah, I can reproduce on the Hebrew Wikipedia, but not anywhere else. I'm pretty sure it has something to do with the override of [[https://he.wikipedia.org/w/index.php?title=%D7%9E%D7%93%D7%99... [13:47:39] 10Cite: Coded unreadable reference name in 3 media wiki messages in non-ASCII languages - https://phabricator.wikimedia.org/T115809#1733206 (10matmarex) >>! In T85386#1730550, @matmarex wrote: > The other error messages are usually generated immediately when parsing the `` tags, at which point they have acc... [13:50:54] 10Cite: Two cite errors get empty error messages. - https://phabricator.wikimedia.org/T116411#1761730 (10matmarex) Oooh, I have a thought. The 'cite_error_group_refs_without_references' message contains a few '=' characters, and after it replaces the $1 in `{{פענוח/הערות|$1}}`, it might be treated as parameter n... [13:51:44] MatmaRex: Having fun? [13:52:40] James_F: nothing more enjoyable than mixing wikitext and RTL languages [13:59:11] My sympathies. [15:38:59] (03PS1) 10Jforrester: Fix two uses of now-removed OOUI mixin aliases [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/249413 [15:39:04] Krenair, I updated the etherpad [15:39:09] (03PS1) 10Esanders: FindAndReplace: Start search at current offset [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/249422 [15:39:10] edsanders: Neat. [15:39:11] 10Cite, 5Patch-For-Review: Duplicate refs inside don't cause a citation error - https://phabricator.wikimedia.org/T116377#1761849 (10matmarex) a:3matmarex [15:39:11] 10Cite: Two cite errors get empty error messages. - https://phabricator.wikimedia.org/T116411#1761859 (10IKhitron) @matmarex, you are genius, and I am stupid. By the way, for me, this code does not create any message in enwiki, an this is not good. [16:10:53] 10VisualEditor, 10VisualEditor-MediaWiki-References: "Re-use" does not allow changes specific to the new use (like correct page numbers, quotes) - https://phabricator.wikimedia.org/T96536#1762194 (10Elitre) I think T96000 is related. [16:12:51] (03CR) 10DLynch: "I added some upstream changes to make it easier to register new commands from extensions. A side-effect of this is that some of the build " [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/248373 (https://phabricator.wikimedia.org/T116013) (owner: 10DLynch) [16:23:59] 10VisualEditor, 10Parsoid: Uppercase one-letter interwiki prefixes - https://phabricator.wikimedia.org/T116619#1762261 (10ssastry) p:5Triage>3Normal [16:24:59] 10VisualEditor, 10Parsoid:
in headers - https://phabricator.wikimedia.org/T116367#1762266 (10ssastry) T116751 is another instance of it [16:29:04] 10VisualEditor, 10Parsoid: Edits to/near headings are being serialised as

rather than \n=== - https://phabricator.wikimedia.org/T113173#1762289 (10ssastry) This looks like another case of reuse of ids from copy-paste. Merging with T116460. [16:29:25] 10VisualEditor, 10Parsoid: Edits to/near headings are being serialised as

rather than \n=== - https://phabricator.wikimedia.org/T113173#1762291 (10ssastry) [16:29:27] 10VisualEditor, 10Parsoid, 10RESTBase: VE / RESTBase: Incorrect id reuse after copy-paste? - https://phabricator.wikimedia.org/T116460#1750152 (10ssastry) [16:31:25] 10VisualEditor, 10Parsoid: Tag 10VisualEditor: Tag Kemayo, hey [16:32:25] Hey indeed. [16:33:38] so I'm code reviewing [16:34:08] I note that the keys are just sorted alphabetically [16:34:17] is that what it does? [16:34:37] Yup. It's actually not too bad, as an effect. [16:34:53] https://usercontent.irccloud-cdn.com/file/4crrQvLZ/ [16:35:18] ...in English [16:36:00] Order is consistent between languages -- it's going off of a key you give it when registering the command, not the localized text. [16:36:11] yeah [16:36:43] so the order is going to be pseudo random in many languages [16:36:50] we should probably have a pre-defined ordering [16:37:28] 'zClear' feels a bit hacky [16:37:48] Yeah, I'll grant the "zClear" thing. [16:38:04] I think for things which are registered later (extensions) sort by anything is fine [16:38:19] but for core we want certain things at the top [16:38:32] The main reason I went for this is that it lets the extension which adds a new level of header get sorted right next to the existing header shortcut, which seemed to make sense. [16:38:51] ah, I see [16:39:14] Here, the extension version: https://usercontent.irccloud-cdn.com/file/haxkwJKa/ [16:39:22] thanks [16:40:19] so we have a similar problem in the toolbar itself [16:40:49] there we have promote and demote flags [16:41:02] so basically 3 sub groups [16:41:30] or rather promote and demote arrays [16:41:47] so if you want, you can just specify the entire ordering [16:43:41] so text styling might be promote=[bold,italic,link], demote=[clear] with key sorting in between [16:43:57] Can we re-use the ordering? [16:44:09] 10VisualEditor, 10VisualEditor-CopyPaste: Pasted lists of multiple lines are treated as one list item with
- https://phabricator.wikimedia.org/T108357#1762352 (10ssastry) [16:44:14] re use what ordering? [16:44:14] It's not really possible to take the tool and get the sequence, I guess. [16:44:21] oh [16:44:25] The toolbar's ordering. It's already split into styling and non-styling. [16:44:41] yeah also you can have a command without a tool [16:45:39] True. [16:46:56] Yeah, there's overlap in functionality between the toolbars, shortcuts, and sequences, but... [16:47:05] 10VisualEditor, 10VisualEditor-CopyPaste: Pasted lists of multiple lines are treated as one list item with
- https://phabricator.wikimedia.org/T108357#1762366 (10ssastry) I removed Parsoid here, since this is not really a Parsoid issue but a VE interface issue with copy-pasting of text. I use this workaro... [16:50:46] (03CR) 10Esanders: [C: 04-1] Include sequences in the command help dialog (038 comments) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/248370 (https://phabricator.wikimedia.org/T116013) (owner: 10DLynch) [16:52:32] (03CR) 10Jforrester: [C: 032] FindAndReplace: Start search at current offset [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/249422 (owner: 10Esanders) [16:52:50] (03CR) 10Jforrester: [C: 032] Remove non-existent browser prefix [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/249164 (owner: 10Esanders) [16:53:32] 10VisualEditor, 10VisualEditor-ContentEditable, 5Patch-For-Review, 7Technical-Debt: Abstract away Selection handling from the surface - https://phabricator.wikimedia.org/T116748#1762419 (10Jdforrester-WMF) p:5Triage>3Normal a:3Esanders [16:54:14] (03CR) 10Jforrester: [C: 031] Introduce key down handlers to spearate logic from ce surface [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/248911 (https://phabricator.wikimedia.org/T78696) (owner: 10Esanders) [16:56:08] (03Merged) 10jenkins-bot: FindAndReplace: Start search at current offset [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/249422 (owner: 10Esanders) [16:56:10] (03Merged) 10jenkins-bot: Remove non-existent browser prefix [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/249164 (owner: 10Esanders) [16:56:18] 10VisualEditor, 10Parsoid, 10RESTBase: Possible cases where scrubWikitext wasn't being passed? - https://phabricator.wikimedia.org/T110153#1762429 (10ssastry) 5Open>3declined a:3ssastry We still don't know what happened there but there haven't been reports of these again. So, we can open another ticket... [17:03:32] James_F|Away, why hasn't gerritbot tagged both bugs https://gerrit.wikimedia.org/r/#/c/248911/ ? [17:03:58] 10VisualEditor, 6Collaboration-Team-Backlog, 10Flow, 6Language-Engineering, and 3 others: Provide an API flag to suppress auto-generated - https://phabricator.wikimedia.org/T113331#1762448 (10ssastry) [17:05:03] 10VisualEditor, 10Parsoid, 7Parsoid-Web-API: API call which gives the rendering of a data-mw node from the data-mw & tyepof - https://phabricator.wikimedia.org/T114409#1762463 (10ssastry) p:5Triage>3Normal [17:41:13] (03PS10) 10DLynch: Include sequences in the command help dialog [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/248370 (https://phabricator.wikimedia.org/T116013) [18:01:55] 10VisualEditor, 6Community-Liaison, 10WMF-Product-Strategy, 3Discovery-Analysis-Sprint: How many active editors are using VisualEditor at large Wikipedias? - https://phabricator.wikimedia.org/T94637#1762684 (10Elitre) Linking to T90641 (it's mainly for my sanity). [18:10:54] (03CR) 10Divec: "Good stuff :-)" (037 comments) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/248911 (https://phabricator.wikimedia.org/T78696) (owner: 10Esanders) [18:21:33] hey guillom, was there a page where you explained about https://en.wikipedia.org/wiki/Wikipedia:VisualEditor/Feedback/Diffs and how to export that system to a different wiki? [18:29:20] Elitre: Hmm, let me check. [18:29:41] Elitre: There's probably a Phabricator ticket with that kind of information. Looking through my reports now. [18:31:08] Elitre: https://phabricator.wikimedia.org/T90894 has information about the process and the tool, and https://phabricator.wikimedia.org/T94767 about the actual reviews. [18:31:16] thank you. [18:32:44] sure :) [18:44:51] 10Cite, 5Patch-For-Review: Duplicate refs inside don't cause a citation error - https://phabricator.wikimedia.org/T116377#1762796 (10matmarex) p:5Triage>3Normal [19:06:21] 10VisualEditor, 10VisualEditor-MediaWiki, 6Community-Tech, 3Community-Tech-Sprint: HotCat doesn't load after saving a page in VisualEditor (must refresh/reload first) [AOI] - https://phabricator.wikimedia.org/T103285#1762891 (10DannyH) [19:10:57] 10VisualEditor, 10VisualEditor-MediaWiki, 3Community-Tech-Sprint: HotCat doesn't load after saving a page in VisualEditor (must refresh/reload first) [AOI] - https://phabricator.wikimedia.org/T103285#1762933 (10DannyH) [19:11:26] 10Cite: Two cite errors get empty error messages. - https://phabricator.wikimedia.org/T116411#1762934 (10matmarex) >>! In T116411#1761859, @IKhitron wrote: > By the way, for me, this code does not create any message in enwiki, an this is not good. They wrap all their errors in the {{broken ref}} template which... [19:11:57] 10Cite: Two cite errors get empty error messages. - https://phabricator.wikimedia.org/T116411#1762936 (10matmarex) 5Open>3Invalid a:3matmarex Happy to have helped :) [19:12:15] 10Cite: Two cite errors get empty error messages. - https://phabricator.wikimedia.org/T116411#1762940 (10IKhitron) I see. Thank you very much for all your help. [19:27:00] (03CR) 10Bartosz Dziewoński: [C: 032] Fix two uses of now-removed OOUI mixin aliases [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/249413 (owner: 10Jforrester) [19:27:25] (03CR) 10Bartosz Dziewoński: [C: 032] Fix two uses of now-removed OOUI mixin aliases [extensions/Citoid] - 10https://gerrit.wikimedia.org/r/249362 (owner: 10Jforrester) [19:28:31] (03Merged) 10jenkins-bot: Fix two uses of now-removed OOUI mixin aliases [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/249413 (owner: 10Jforrester) [19:28:35] (03Merged) 10jenkins-bot: Fix two uses of now-removed OOUI mixin aliases [extensions/Citoid] - 10https://gerrit.wikimedia.org/r/249362 (owner: 10Jforrester) [19:29:17] (03CR) 10Bartosz Dziewoński: "Whoops, merged too quickly." (032 comments) [extensions/Citoid] - 10https://gerrit.wikimedia.org/r/249362 (owner: 10Jforrester) [19:42:35] 10VisualEditor, 10VisualEditor-Performance, 10MediaWiki-General-or-Unknown, 10MediaWiki-Interface, and 10 others: Use Parsoid HTML for all page views - https://phabricator.wikimedia.org/T55784#1763147 (10RobLa-WMF) @mobrovac: if you really think this should happen, you should drive it rather than delegate... [20:13:15] (03CR) 10DLynch: Include sequences in the command help dialog (036 comments) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/248370 (https://phabricator.wikimedia.org/T116013) (owner: 10DLynch) [21:33:43] (03PS2) 10Jforrester: Update VE core submodule to master (ec09198) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/249226 [21:42:28] (03PS1) 10Bartosz Dziewoński: ve.ui.MWMediaDialog: Wait for upload booklet to initialize when setting up [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/249568 [21:43:12] 10VisualEditor, 10MediaWiki-General-or-Unknown, 6Multimedia: Show not logged in error before uploading to stash in mw.Upload.BookletLayout - https://phabricator.wikimedia.org/T115866#1763636 (10matmarex) https://gerrit.wikimedia.org/r/249567 should help with the first part of that. [21:43:22] 10VisualEditor, 10Phlogiston, 7WorkType-NewFunctionality: Create third version of VE burnup report - https://phabricator.wikimedia.org/T107482#1763639 (10JAufrecht) [21:43:23] 10VisualEditor, 10Phlogiston, 3Team-Practices-This-Week, 7WorkType-NewFunctionality: Create an article/essay version of the charts - https://phabricator.wikimedia.org/T110081#1763637 (10JAufrecht) 5Resolved>3Open Now that all pages are parameterized and automatic (rather than copy/paste), should add mo... [21:45:04] 10VisualEditor, 10Phlogiston, 7WorkType-NewFunctionality: Restore VE tranches to report - https://phabricator.wikimedia.org/T115941#1763645 (10JAufrecht) [21:48:58] 10VisualEditor, 7Verified-in-Phase0, 5WMF-deploy-2015-10-13_(1.27.0-wmf.3), 5WMF-deploy-2015-10-27_(1.27.0-wmf.4): link tool doesn't work in VisualEditor in mediawiki.org - https://phabricator.wikimedia.org/T115448#1763673 (10Ryasmeen) [21:58:47] 10VisualEditor: [Regression pre wmf.5] Cannot open Citaion dialog - https://phabricator.wikimedia.org/T116982#1763749 (10Ryasmeen) 3NEW [22:12:05] (03CR) 10Alex Monk: [C: 032] Update VE core submodule to master (ec09198) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/249226 (owner: 10Jforrester) [22:27:59] (03Merged) 10jenkins-bot: Update VE core submodule to master (ec09198) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/249226 (owner: 10Jforrester) [22:41:32] 10VisualEditor, 10VisualEditor-MediaWiki, 5Patch-For-Review: Site subtitle lighter than title in edit mode - https://phabricator.wikimedia.org/T116755#1763977 (10Esanders) [23:18:33] (03PS1) 10Bartosz Dziewoński: Fix remaining uses of now-removed OOUI mixin aliases [extensions/Citoid] - 10https://gerrit.wikimedia.org/r/249606 [23:18:39] (03CR) 10Bartosz Dziewoński: "Follow-up: https://gerrit.wikimedia.org/r/249606" [extensions/Citoid] - 10https://gerrit.wikimedia.org/r/249362 (owner: 10Jforrester) [23:41:15] 10VisualEditor, 10VisualEditor-Performance, 10Parsoid: Parsoid should return the full srcset for high DPI devices - https://phabricator.wikimedia.org/T88827#1021211 (10ssastry)