[00:06:57] <wikibugs>	 10VisualEditor, 10VisualEditor-ContentEditable, 10VisualEditor-EditingTools, 5Patch-For-Review, 5WMF-deploy-2015-10-27_(1.27.0-wmf.4): Inspector crashes while trying to open it in a position where another inspector was opened previously - https://phabricator.wikimedia.org/T110378#1764387 (10Ryasmeen) 5R...
[00:11:28] <wikibugs>	 10VisualEditor: [Regression pre wmf.5] TypeError "OO.ui.GroupWidget is undefined" appears when trying to open Citaion dialog - https://phabricator.wikimedia.org/T116982#1764407 (10Ryasmeen) p:5Triage>3High
[00:13:57] <grrrit-wm>	 (03PS2) 10Bartosz Dziewoński: Fix remaining uses of now-removed OOUI mixin aliases [extensions/Citoid] - 10https://gerrit.wikimedia.org/r/249606 (https://phabricator.wikimedia.org/T116982) 
[00:29:04] <wikibugs>	 10VisualEditor, 10VisualEditor-MediaWiki, 7Design, 7Epic: Provide a single edit tab which has both visual and wikitext modes and allows on-the-fly switching between them - https://phabricator.wikimedia.org/T102398#1764471 (10John_Broughton) In my last 50 edits in mainspace, I used VE 22 times. For some thi...
[06:25:39] <grrrit-wm>	 (03CR) 10Jforrester: [C: 032] Fix remaining uses of now-removed OOUI mixin aliases [extensions/Citoid] - 10https://gerrit.wikimedia.org/r/249606 (https://phabricator.wikimedia.org/T116982) (owner: 10Bartosz Dziewoński)
[06:26:11] <grrrit-wm>	 (03Merged) 10jenkins-bot: Fix remaining uses of now-removed OOUI mixin aliases [extensions/Citoid] - 10https://gerrit.wikimedia.org/r/249606 (https://phabricator.wikimedia.org/T116982) (owner: 10Bartosz Dziewoński)
[07:44:32] <legoktm>	 Is it known that if I add a code block using VE, syntax highlighting doesn't show up until after I save and refresh the page?
[07:47:07] <James_F>	 legoktm: Yeah.
[07:47:15] <James_F>	 legoktm: But we should fix that.
[07:47:29] <James_F>	 legoktm: So many damn magic things to re-invoke on page paint.
[07:47:40] <legoktm>	 :/
[07:48:22] <legoktm>	 once I figured out the keyboard shortcut for <code>, things got a lot easier and better.
[07:48:26] <James_F>	 If there was a proper system for it, it'd be a whole lot easier.
[07:48:47] <James_F>	 Oh, yes, don't use <syntaxhighlight> for <code> please. :-)
[07:49:06] <legoktm>	 no, I needed both
[07:49:14] <James_F>	 Hmm.
[07:49:16] <legoktm>	 https://www.mediawiki.org/wiki/Echo_%28Notifications%29/New_formatter_system
[07:49:23] <James_F>	 Ah, fun.
[07:49:34] <James_F>	 There's a keyboard sequence for syntaxhighlight.
[07:50:30] <James_F>	 But only in master, maybe?
[07:50:42] <legoktm>	 I used insert -> more -> code block
[07:50:54] <James_F>	 I think '<syntax' will load it.
[07:50:55] * James_F heads to WMDE; back online in ~30 minutes.
[07:50:58] <legoktm>	 o/
[07:51:01] <legoktm>	 enjoy the party!
[07:51:11] * legoktm zzz
[08:06:42] <wikibugs>	 10VisualEditor, 10VisualEditor-MediaWiki, 7Design, 7Epic: Provide a single edit tab which has both visual and wikitext modes and allows on-the-fly switching between them - https://phabricator.wikimedia.org/T102398#1764853 (10Ricordisamoa) >>! In T102398#1764471, @John_Broughton wrote: > What I like, now, i...
[08:22:30] <James_F>	 legoktm: Slacker!
[08:44:46] <parmanand>	 jkghghhgh
[08:44:52] <parmanand>	 fhgvfjgvjfhgdkfksj
[08:44:56] <parmanand>	 hjjgshsdfgdfkgjsdhirigfturyighjifhtuieryuighfjk
[08:45:00] <parmanand>	 vhjbvfhcgfjkghifhgkjhdkfjhsdjkhfijsdhfjkhdjkfhjksd
[08:45:05] <parmanand>	 jsidfgyurhsdfgkheruiotyeriutyirghjksdfgirueytuidhysfjkhsdjktyruiet
[08:45:08] <parmanand>	 vfnjkghfjkhgjkfhgkhfkghjkfhgjkhfg
[09:22:51] <thedj>	 thank u for barfing into our channel... :)
[09:30:57] * James_F grins
[09:48:34] <grrrit-wm>	 (03CR) 10Esanders: DesktopTarget: Fix opacity of #siteSub and #contentSub (031 comment) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/248356 (https://phabricator.wikimedia.org/T116755) (owner: 10Esanders)
[09:53:42] <grrrit-wm>	 (03CR) 10Jforrester: DesktopTarget: Fix opacity of #siteSub and #contentSub (031 comment) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/248356 (https://phabricator.wikimedia.org/T116755) (owner: 10Esanders)
[12:43:42] <wikibugs>	 10VisualEditor, 10VisualEditor-MediaWiki-Media: Search results not in order - https://phabricator.wikimedia.org/T117036#1765102 (10Esanders) 3NEW
[12:43:52] <wikibugs>	 10VisualEditor, 10VisualEditor-MediaWiki-Media: Search results not in order - https://phabricator.wikimedia.org/T117036#1765109 (10Esanders) >>! In T95223#1741139, @Dreamyshade wrote: > I recently helped new editors learn how to use VisualEditor at an in-person workshop (funded by an Inspire grant, yay!), and...
[12:44:13] <wikibugs>	 10VisualEditor, 10VisualEditor-MediaWiki-Media, 10CirrusSearch, 6Discovery: VisualEditor media search results often include irrelevant PDFs due to full-text search - https://phabricator.wikimedia.org/T95223#1183416 (10Esanders) @Dreamyshade Thanks, I've filed another bug for that: T117036
[12:52:23] <grrrit-wm>	 (03PS1) 10Esanders: MediaSearch: Order search results correctly [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/249726 (https://phabricator.wikimedia.org/T117036) 
[13:05:05] <wikibugs>	 10Cite, 7Regression: Named ref are considered different when the content is a whitespace for refs 2 to n - https://phabricator.wikimedia.org/T117037#1765125 (10NicoV) 3NEW
[13:17:04] <wikibugs>	 10VisualEditor, 10VisualEditor-MediaWiki-Links: Link inspector search results not ordered correctly - https://phabricator.wikimedia.org/T117039#1765144 (10Esanders) 3NEW a:3Esanders
[14:13:21] <wikibugs>	 10Cite, 7Regression: Named ref are considered different when the content is a whitespace for refs 2 to n - https://phabricator.wikimedia.org/T117037#1765239 (10TTO) Fix should be as simple as adding a `trim()` function at https://git.wikimedia.org/blob/mediawiki%2Fextensions%2FCite/HEAD/Cite_body.php#L461.   I...
[14:15:18] <wikibugs>	 10Cite, 7Regression: Named ref are considered different when the content is a whitespace for refs 2 to n - https://phabricator.wikimedia.org/T117037#1765243 (10matmarex) This is a corner-case, but I think that's the expected behavior. (And yes, the error message for duplicate references with different contents...
[14:34:33] <wikibugs>	 10Cite, 7Regression: Named ref are considered different when the content is a whitespace for refs 2 to n - https://phabricator.wikimedia.org/T117037#1765306 (10NicoV) @matmarex Yes, removing the space works, that's my fix for the second example I provided ;-) So, it wasn't really correct before, it's just that...
[15:05:41] <grrrit-wm>	 (03CR) 10Jforrester: [C: 032] MediaSearch: Order search results correctly [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/249726 (https://phabricator.wikimedia.org/T117036) (owner: 10Esanders)
[15:16:12] <grrrit-wm>	 (03Merged) 10jenkins-bot: MediaSearch: Order search results correctly [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/249726 (https://phabricator.wikimedia.org/T117036) (owner: 10Esanders)
[15:22:04] <wikibugs>	 10VisualEditor, 6Editing-Department, 10MediaWiki-extensions-ContentTranslation, 7Design, 7Epic: [Epic] replace plain contenteditable with VisualEditor in ContentTranslation - https://phabricator.wikimedia.org/T105447#1765421 (10Amire80)
[15:51:01] <wikibugs>	 10VisualEditor, 10VisualEditor-MediaWiki-Links: Link inspector search results not ordered correctly - https://phabricator.wikimedia.org/T117039#1765536 (10Jdforrester-WMF) 5Open>3Resolved p:5Triage>3High
[15:51:19] <wikibugs>	 10VisualEditor: Too big pages edition make the browser crash - https://phabricator.wikimedia.org/T117053#1765542 (10Pols12) 3NEW
[15:51:21] <wikibugs>	 10VisualEditor, 10VisualEditor-MediaWiki-Media: Media search results not in order - https://phabricator.wikimedia.org/T117036#1765551 (10Jdforrester-WMF) 5Open>3Resolved p:5Triage>3High a:3Esanders
[15:55:49] <wikibugs>	 10Cite: <references/> in ordered list or unordered list closes surrounding element - https://phabricator.wikimedia.org/T27939#1765565 (10Fomafix)
[16:11:30] <grrrit-wm>	 (03CR) 10Esanders: "Yeah the afterKeyDown stuff seemed complicated enough to leave for later. This commit is designed to be inoffensive enough to merge quickl" (032 comments) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/248911 (https://phabricator.wikimedia.org/T78696) (owner: 10Esanders)
[16:12:02] <wikibugs>	 10VisualEditor, 10VisualEditor-ContentEditable, 7Technical-Debt: Break up ve.ce.Surface.js by functionality - https://phabricator.wikimedia.org/T78696#1765599 (10Esanders) https://gerrit.wikimedia.org/r/#/c/248911/
[16:16:45] <grrrit-wm>	 (03CR) 10Esanders: [C: 04-1] Include sequences in the command help dialog (037 comments) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/248370 (https://phabricator.wikimedia.org/T116013) (owner: 10DLynch)
[16:20:42] <wikibugs>	 10VisualEditor, 10VisualEditor-MediaWiki, 5Patch-For-Review, 5WMF-deploy-2015-10-27_(1.27.0-wmf.4), 7user-notice: On user's first use of VE-MW, provide a couple of educational pop-ups for links and for citations with some toolbar highlights to trigger the... - https://phabricator.wikimedia.org/T108620#1765620
[16:25:59] <wikibugs>	 10VisualEditor, 10VisualEditor-MediaWiki, 5Patch-For-Review: 'Save page' is not enabled for a short time (<1s) after the first transaction - https://phabricator.wikimedia.org/T115483#1765644 (10Esanders) 5Open>3Resolved
[16:33:17] <wikibugs>	 10VisualEditor, 10VisualEditor-DataModel: VE crashes on trying to save a document with an empty heading, throws error " Offset could not be translated to a DOM element and offset: 1" - https://phabricator.wikimedia.org/T114730#1765662 (10Esanders) 5Open>3Resolved a:3Esanders Fixed by https://gerrit.wikim...
[16:37:17] <wikibugs>	 10VisualEditor, 10VisualEditor-EditingTools: [Regression wmf12] Uncaught Error: “Offset could not be translated to a DOM element and offset: 2” when selecting a heading format with language inspector open. - https://phabricator.wikimedia.org/T76717#818828 (10Esanders) T98820 is probably a duplicate too
[16:38:49] <grrrit-wm>	 (03CR) 10Bartosz Dziewoński: [C: 04-1] Introduce key down handlers to spearate logic from ce surface (031 comment) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/248911 (https://phabricator.wikimedia.org/T78696) (owner: 10Esanders)
[16:40:21] <wikibugs>	 10VisualEditor, 10VisualEditor-ContentEditable, 10VisualEditor-EditingTools, 5Patch-For-Review, 5WMF-deploy-2015-10-27_(1.27.0-wmf.4): Inspector crashes while trying to open it in a position where another inspector was opened previously - https://phabricator.wikimedia.org/T110378#1765680 (10Esanders) 5O...
[16:40:48] <wikibugs>	 10VisualEditor, 10VisualEditor-MediaWiki-Links: VE crashes after opening Link inspector in the same position after deleting link - https://phabricator.wikimedia.org/T114064#1683612 (10Esanders) Video: F2888117
[16:49:11] <wikibugs>	 10VisualEditor, 10Graph-VisualEditor: Styling regressions in table widget - https://phabricator.wikimedia.org/T116854#1765701 (10ferdbold) https://gerrit.wikimedia.org/r/#/c/246456/ fixes this, I removed some problematic styles that were necessary in previous versions of OOUI
[16:49:24] <wikibugs>	 10VisualEditor, 10Graph-VisualEditor: Styling regressions in table widget - https://phabricator.wikimedia.org/T116854#1765702 (10ferdbold) p:5Triage>3Normal
[16:50:57] <wikibugs>	 10VisualEditor: Too big pages edition make the browser crash - https://phabricator.wikimedia.org/T117053#1765707 (10Aklapper) 5Open>3stalled Hi @Pols12, thanks for taking the time to report this! Unfortunately this report lacks some information. If you have time and can still reproduce the problem, please [[...
[16:59:46] <wikibugs>	 10VisualEditor, 10VisualEditor-MediaWiki, 5Patch-For-Review, 5WMF-deploy-2015-10-27_(1.27.0-wmf.4), 7user-notice: On user's first use of VE-MW, provide a couple of educational pop-ups for links and for citations with some toolbar highlights to trigger the... - https://phabricator.wikimedia.org/T108620#1765749
[17:07:26] <grrrit-wm>	 (03CR) 10DLynch: Include sequences in the command help dialog (037 comments) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/248370 (https://phabricator.wikimedia.org/T116013) (owner: 10DLynch)
[17:07:45] <grrrit-wm>	 (03PS11) 10DLynch: Include sequences in the command help dialog [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/248370 (https://phabricator.wikimedia.org/T116013) 
[17:08:19] <grrrit-wm>	 (03PS5) 10DLynch: Add mediawiki-specific sequences to the command help dialog [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/248373 (https://phabricator.wikimedia.org/T116013) 
[17:15:23] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Add mediawiki-specific sequences to the command help dialog [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/248373 (https://phabricator.wikimedia.org/T116013) (owner: 10DLynch)
[17:18:35] <wikibugs>	 10VisualEditor, 10VisualEditor-MediaWiki: Possible to trigger "Error: Invalid start offset: -1" when opening Page Settings on once-contentful, currently blank, page - https://phabricator.wikimedia.org/T107553#1765810 (10Esanders) I get an exception when I hit backspace
[17:27:47] <Krenair>	 edsanders, hey
[17:27:57] <edsanders>	  yo
[17:29:13] <grrrit-wm>	 (03PS1) 10DLynch: Make jsonlint ignore more node_modules [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/249785 
[17:30:15] <grrrit-wm>	 (03CR) 10Jforrester: [C: 031] "This works but it seems a bit magic; I'd prefer to explicitly ignore the built docs directory. What do you think?" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/249785 (owner: 10DLynch)
[17:31:19] <Krenair>	 edsanders, so when you go WE -> VE -> WE, you lose your work
[17:31:32] <Krenair>	 because when loading VE, VE assumes no changes have been made by default
[17:32:14] <edsanders>	 are you we talking about your patch here, or current master?
[17:32:53] <grrrit-wm>	 (03CR) 10Esanders: [C: 032] Make jsonlint ignore more node_modules [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/249785 (owner: 10DLynch)
[17:32:54] <Krenair>	 my patch
[17:33:01] <Krenair>	 you can't go WE -> VE on current master
[17:33:46] <grrrit-wm>	 (03CR) 10DLynch: "It's lightly magic, insofar as it's using globs, but I think that it's magic applied in a good direction. There's no reason we'd ever actu" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/249785 (owner: 10DLynch)
[17:34:43] <grrrit-wm>	 (03CR) 10Jforrester: "True, but we might also want to ignore other, non-node_modules JSON files in the generated docs… eh." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/249785 (owner: 10DLynch)
[17:36:21] <grrrit-wm>	 (03Merged) 10jenkins-bot: Make jsonlint ignore more node_modules [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/249785 (owner: 10DLynch)
[17:38:06] <Kemayo>	 James_F: I could throw up another one to add "!docs/" and "!vendor/" to the exclusions.
[17:38:20] <James_F>	 Kemayo: Eh. We'll deal when it happens. :-)
[17:39:01] <Krenair>	 edsanders, basically we use ve.dm.Surface.prototype.hasBeenModified in VE-MW code to determine whether we can just switch from VE into WT without worrying about preserving the document (which involves asking the user and converting it)
[17:39:27] <Krenair>	 When you've loaded VE by switching from WT, we want this to always return true
[17:43:07] <whatami>	 Krenair, I wanted to make sure that you saw the bug report at https://phabricator.wikimedia.org/T108620#1765749
[17:43:27] <Krenair>	 That's a closed task, whatami 
[17:44:04] <whatami>	 I can copy it to a new task if you'd like.
[17:44:20] <Krenair>	 Are you able to reproduce the issue reported?
[17:44:28] <whatami>	 Elitre is.
[17:44:32] <whatami>	 I haven't tried.
[17:44:56] <Krenair>	 What does Elitre do to reveal the issue?
[17:45:41] <whatami>	 I think she just clicks the button in the toolbar, but I'll ask.
[17:46:17] <Elitre>	 yes.
[17:47:28] <whatami>	 Browser/OS?
[17:47:34] <Elitre>	 I edit, save. refresh the page. edit again, it still shows the dot. save. refresh. edit again, dots are still there.
[17:47:58] <Elitre>	 safari, os x yosemite
[17:48:52] <whatami>	 So it's once per opening the page, but if you make six links (without saving in between), you'll only see it once, right?
[17:54:35] <Elitre>	 yes.
[18:07:20] <wikibugs>	 10Cite, 7Regression: Named ref are considered different when the content is a whitespace for refs 2 to n - https://phabricator.wikimedia.org/T117037#1765957 (10eranroz) Yes the error report on refs with same name and different content is a new behavior which we added to Cite extension recently as there were ma...
[18:11:32] <wikibugs>	 10VisualEditor, 10VisualEditor-MediaWiki, 5Patch-For-Review, 5WMF-deploy-2015-10-27_(1.27.0-wmf.4), 7user-notice: On user's first use of VE-MW, provide a couple of educational pop-ups for links and for citations with some toolbar highlights to trigger the... - https://phabricator.wikimedia.org/T108620#1765961
[18:12:29] <wikibugs>	 10Cite, 7Regression: Named ref are considered different when the content is a whitespace for refs 2 to n - https://phabricator.wikimedia.org/T117037#1765965 (10NicoV) OK ! I think a content with **only** whitespace characters could at least be treated as empty (a ref with only whitespace characters is useless)...
[18:14:40] <Krenair>	 Elitre, are you logged in?
[18:19:05] <grrrit-wm>	 (03CR) 10Esanders: [C: 032] Include sequences in the command help dialog [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/248370 (https://phabricator.wikimedia.org/T116013) (owner: 10DLynch)
[18:19:42] <grrrit-wm>	 (03CR) 10Esanders: [C: 04-2] Include sequences in the command help dialog [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/248370 (https://phabricator.wikimedia.org/T116013) (owner: 10DLynch)
[18:19:54] <grrrit-wm>	 (03PS12) 10Esanders: [BREAKING CHANGE] Include sequences in the command help dialog [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/248370 (https://phabricator.wikimedia.org/T116013) (owner: 10DLynch)
[18:20:00] <grrrit-wm>	 (03CR) 10Esanders: [C: 032] [BREAKING CHANGE] Include sequences in the command help dialog [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/248370 (https://phabricator.wikimedia.org/T116013) (owner: 10DLynch)
[18:20:25] <grrrit-wm>	 (03PS6) 10Esanders: [PULL THROUGH] Add mediawiki-specific sequences to the command help dialog [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/248373 (https://phabricator.wikimedia.org/T116013) (owner: 10DLynch)
[18:20:42] <grrrit-wm>	 (03CR) 10Esanders: [C: 031] "Needs pull through" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/248373 (https://phabricator.wikimedia.org/T116013) (owner: 10DLynch)
[18:22:12] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] [PULL THROUGH] Add mediawiki-specific sequences to the command help dialog [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/248373 (https://phabricator.wikimedia.org/T116013) (owner: 10DLynch)
[18:22:13] <wikibugs>	 10VisualEditor, 6Collaboration-Team-Backlog, 10Flow, 6Language-Engineering, and 4 others: Provide an API flag to suppress auto-generated <references /> - https://phabricator.wikimedia.org/T113331#1766011 (10ssastry) Here is a summary of a lengthy IRC discussion on #mediawiki-parsoid.  @GWicke raises the co...
[18:23:14] <Elitre>	 Yes. See my meta sandbox?
[18:24:15] <grrrit-wm>	 (03Merged) 10jenkins-bot: [BREAKING CHANGE] Include sequences in the command help dialog [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/248370 (https://phabricator.wikimedia.org/T116013) (owner: 10DLynch)
[18:27:53] <wikibugs>	 10VisualEditor, 10VisualEditor-MediaWiki: Possible to trigger "Error: Invalid start offset: -1" when opening Page Settings on once-contentful, currently blank, page - https://phabricator.wikimedia.org/T107553#1766026 (10Esanders) Minimal test document in ve core:  ``` <div rel="ve:Alien">Alien</div> <p>Foo</p>...
[18:28:29] <Krenair>	 think I've just seen the same thing
[18:39:01] <wikibugs>	 10VisualEditor, 10VisualEditor-MediaWiki: Possible to trigger "Error: Invalid start offset: -1" when opening Page Settings on once-contentful, currently blank, page - https://phabricator.wikimedia.org/T107553#1766039 (10Esanders) a:5eranroz>3Esanders
[19:00:33] <grrrit-wm>	 (03PS1) 10Esanders: ElementLinearData: Add another case to hasContent [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/249800 
[19:00:35] <grrrit-wm>	 (03PS1) 10Esanders: SurfaceFragment: Improve handling of delete all [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/249801 (https://phabricator.wikimedia.org/T107553) 
[19:02:07] <grrrit-wm>	 (03PS2) 10Esanders: SurfaceFragment: Improve handling of delete all [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/249801 (https://phabricator.wikimedia.org/T107553) 
[19:02:15] <grrrit-wm>	 (03PS2) 10Ferdbold: AUTHORS: Update for October 2015 [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/247950 (owner: 10Jforrester)
[19:02:51] <grrrit-wm>	 (03CR) 10Ferdbold: [C: 031] "yay" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/247950 (owner: 10Jforrester)
[19:03:16] <grrrit-wm>	 (03CR) 10Esanders: "I didn't end up using this for anything, but it seems like a sensible thing to do." [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/249800 (owner: 10Esanders)
[19:04:19] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] SurfaceFragment: Improve handling of delete all [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/249801 (https://phabricator.wikimedia.org/T107553) (owner: 10Esanders)
[19:06:39] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] AUTHORS: Update for October 2015 [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/247950 (owner: 10Jforrester)
[19:14:31] <Krenair>	 edsanders, so, any ideas about how we should do this?
[19:17:33] <edsanders>	 hmm
[19:19:41] <Krenair>	 Elitre, whatami: can you open a ticket please?
[19:24:29] <grrrit-wm>	 (03CR) 10Esanders: [C: 032] AUTHORS: Update for October 2015 [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/247950 (owner: 10Jforrester)
[19:29:25] <grrrit-wm>	 (03Merged) 10jenkins-bot: AUTHORS: Update for October 2015 [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/247950 (owner: 10Jforrester)
[19:29:29] <grrrit-wm>	 (03CR) 10Alex Monk: "Think the only thing preventing this from having the WIP tag removed is making VE think of WT->VE switching as a modification" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/245593 (https://phabricator.wikimedia.org/T49779) (owner: 10Alex Monk)
[19:34:34] <whatami>	 Krenair, the ticket you want for the link dialog is at https://phabricator.wikimedia.org/T117083
[19:34:50] <wikibugs>	 10Cite, 7Wikimedia-log-errors: Undefined index: lower-roman in cite_body.php - https://phabricator.wikimedia.org/T117084#1766228 (10mmodell) 3NEW
[19:35:43] <wikibugs>	 10VisualEditor, 10VisualEditor-MediaWiki, 10VisualEditor-MediaWiki-Links: Link education pop-up appears at the start of every editing session, not just once per user, at Meta - https://phabricator.wikimedia.org/T117083#1766240 (10Whatamidoing-WMF)
[19:36:05] <wikibugs>	 10VisualEditor, 10VisualEditor-MediaWiki, 10VisualEditor-MediaWiki-Links: Link education pop-up appears at the start of every editing session, not just once per user, at Meta - https://phabricator.wikimedia.org/T117083#1766242 (10Whatamidoing-WMF) a:3Krenair
[19:36:53] <wikibugs>	 10VisualEditor, 10VisualEditor-MediaWiki, 5Patch-For-Review, 5WMF-deploy-2015-10-27_(1.27.0-wmf.4), 7user-notice: On user's first use of VE-MW, provide a couple of educational pop-ups for links and for citations with some toolbar highlights to trigger the... - https://phabricator.wikimedia.org/T108620#1766244
[19:41:30] <wikibugs>	 10Cite, 7Wikimedia-log-errors: Undefined index: lower-roman in cite_body.php - https://phabricator.wikimedia.org/T117084#1766278 (10mmodell) p:5Triage>3Unbreak! 1.27.0-wmf.4 had to be rolled back because this was spamming logs a lot.
[19:42:04] <wikibugs>	 10Cite, 7Wikimedia-log-errors: Undefined index: lower-roman in cite_body.php - https://phabricator.wikimedia.org/T117084#1766289 (10greg) {F2893235}
[19:42:16] <wikibugs>	 10Cite, 7Wikimedia-log-errors: Undefined index: lower-roman in cite_body.php - https://phabricator.wikimedia.org/T117084#1766291 (10greg)
[19:47:34] <wikibugs>	 10Cite, 7Wikimedia-log-errors: Undefined index: lower-roman in cite_body.php - https://phabricator.wikimedia.org/T117084#1766300 (10greg) Fatal logs during wmf.4 being on wikipedias: https://logstash.wikimedia.org/#dashboard/temp/AVC1I9wyptxhN1Xaf0VE
[19:52:07] <wikibugs>	 10Cite, 7Wikimedia-log-errors: Undefined index: lower-roman in cite_body.php - https://phabricator.wikimedia.org/T117084#1766315 (10matmarex) Looks caused by c00cf4a204954acef2f50712c38d33f3741df5f7.
[20:00:34] <wikibugs>	 10Cite, 7Wikimedia-log-errors: Undefined index: lower-roman in cite_body.php - https://phabricator.wikimedia.org/T117084#1766362 (10Southparkfan) I guess it happens because "!$this->mRefs[$group]" is used instead of "!isset( $this->mRefs[$group] )"?
[20:01:45] <wikibugs>	 10VisualEditor, 10VisualEditor-MediaWiki, 5Patch-For-Review, 5WMF-deploy-2015-10-27_(1.27.0-wmf.4), 7user-notice: On user's first use of VE-MW, provide a couple of educational pop-ups for links and for citations with some toolbar highlights to trigger the... - https://phabricator.wikimedia.org/T108620#1766368
[20:03:02] <wikibugs>	 10VisualEditor, 10Phlogiston, 7WorkType-NewFunctionality: Restore VE tranches to report - https://phabricator.wikimedia.org/T115941#1766380 (10JAufrecht) 5Open>3Resolved
[20:05:38] <wikibugs>	 10Cite, 7Wikimedia-log-errors: Undefined index: lower-roman in cite_body.php - https://phabricator.wikimedia.org/T117084#1766391 (10mmodell)
[20:09:40] <wikibugs>	 10Cite, 7Wikimedia-log-errors: Undefined index: lower-roman in cite_body.php - https://phabricator.wikimedia.org/T117084#1766416 (10mmodell) The gerrit code review comments are amusing: https://gerrit.wikimedia.org/r/#/c/223250/
[20:10:05] <grrrit-wm>	 (03PS3) 10Esanders: SurfaceFragment: Improve handling of delete all [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/249801 (https://phabricator.wikimedia.org/T107553) 
[20:13:12] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] SurfaceFragment: Improve handling of delete all [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/249801 (https://phabricator.wikimedia.org/T107553) (owner: 10Esanders)
[20:31:45] <wikibugs>	 10VisualEditor, 10Phlogiston, 6Team-Practices, 7WorkType-NewFunctionality: Create an article/essay version of the charts - https://phabricator.wikimedia.org/T110081#1568435 (10JAufrecht)
[20:46:34] <wikibugs>	 10Cite, 10MediaWiki-Categories: Cite extension: allow different tracking categories depending on the kind of error detected - https://phabricator.wikimedia.org/T117099#1766572 (10NicoV) 3NEW
[20:47:07] <wikibugs>	 10Cite, 10MediaWiki-Categories: Cite extension: allow different tracking categories depending on the kind of error detected - https://phabricator.wikimedia.org/T117099#1766584 (10NicoV)
[21:10:32] <grrrit-wm>	 (03PS1) 10DLynch: Update VE core submodule to master (be148ae) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/249883 
[21:12:57] <ferdbold1>	 How can I both insert a node to the surface and apply initial edits to it without creating two events in history? Is there some sort of "staging merge" functionality I can use?
[21:30:35] <grrrit-wm>	 (03PS7) 10Alex Monk: [WIP] Dialog for switching between wikitext and visual editing [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/247485 
[21:30:37] <grrrit-wm>	 (03PS8) 10Alex Monk: Allow switching from wikitext to VE [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/245593 (https://phabricator.wikimedia.org/T49779) 
[21:30:39] <Krenair>	 edsanders, I decided to just hack around it in the end
[21:32:42] <edsanders>	 Krenair, I guess set a flag if you load VE from wikitext editor, and check for that as well as "hasBeenModified"?
[21:32:58] <Krenair>	 Yes, that's what I've done.
[21:35:35] <edsanders>	 I wouldn't call that a hack - I don't think you need to change hasBeenModified
[21:57:26] <wikibugs>	 10Cite, 7Wikimedia-log-errors: Undefined index: lower-roman in cite_body.php - https://phabricator.wikimedia.org/T117084#1766893 (10Krinkle) >>! In T117084#1766416, @mmodell wrote: > The gerrit code review comments are amusing: https://gerrit.wikimedia.org/r/#/c/223250/  They are amusing and related to array c...
[22:09:06] <wikibugs>	 10VisualEditor, 10VisualEditor-MediaWiki, 10VisualEditor-MediaWiki-Links: Link education pop-up appears at the start of every editing session, not just once per user, at Meta - https://phabricator.wikimedia.org/T117083#1766943 (10Ryasmeen) This happened on Beta for me as well, thought this is a Beta specific...
[22:34:33] <grrrit-wm>	 (03PS4) 10Tchanders: Make new error element [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/246789 (https://phabricator.wikimedia.org/T114754) 
[22:38:32] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Make new error element [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/246789 (https://phabricator.wikimedia.org/T114754) (owner: 10Tchanders)
[22:38:54] <grrrit-wm>	 (03CR) 10Tchanders: Make new error element (034 comments) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/246789 (https://phabricator.wikimedia.org/T114754) (owner: 10Tchanders)
[22:42:06] <grrrit-wm>	 (03CR) 10Esanders: [C: 032] Make new error element [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/246789 (https://phabricator.wikimedia.org/T114754) (owner: 10Tchanders)
[22:44:58] <grrrit-wm>	 (03Merged) 10jenkins-bot: Make new error element [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/246789 (https://phabricator.wikimedia.org/T114754) (owner: 10Tchanders)
[22:54:44] <wikibugs>	 10VisualEditor, 10VisualEditor-MediaWiki-Media, 6Commons, 6Multimedia: Commons' TitleBlacklist messages are messy and not parseable by jqueryMsg - https://phabricator.wikimedia.org/T115259#1767147 (10matmarex)
[22:55:12] <grrrit-wm>	 (03CR) 10Esanders: [C: 04-1] "This should be merged with your pull through commit that unbreaks the breaking change." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/249883 (owner: 10DLynch)
[23:04:52] <Kemayo>	 edsanders|away:  Should I merge that into the same commit, then, or just leave it separate?
[23:06:50] <RoanKattouw>	 Kemayo: Merge the submodule update and the unbreaking change into the same commit
[23:06:57] <RoanKattouw>	 Otherwise CI won't let it be merged
[23:07:17] <RoanKattouw>	 Given that, however you order those two commits, the first one will put the repo in a broken state
[23:14:28] <grrrit-wm>	 (03PS7) 10DLynch: Add mediawiki-specific sequences to the command help dialog [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/248373 (https://phabricator.wikimedia.org/T116013) 
[23:15:57] <grrrit-wm>	 (03Abandoned) 10DLynch: Update VE core submodule to master (be148ae) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/249883 (owner: 10DLynch)
[23:50:48] <Krinkle>	 Woah, what is pulsatingDot ?
[23:51:00] <Krinkle>	 I thought I was losing my vision.
[23:51:03] <Krinkle>	 But i's really there.
[23:51:22] <Krenair>	 Are those poups showing more than once to you as well Krinkle?
[23:52:19] <Krinkle>	 I don't see any popups, I see a  a regular toolbar as usual (on wikitech). But underneath the link icon there is a pulsating dot. Doesn't do anything when clicked, stays when hovering the menu, and is actually slighly cut off due to the overflow of the toolnbar
[23:54:50] <Krenair>	 So when the toolbar active you should be able to click the tool the dot is over to trigger the popup
[23:55:00] <Krinkle>	 hm..
[23:55:01] <Krinkle>	 Ah!
[23:55:09] <Krinkle>	 It didn't do anything because I already had the link inspector open
[23:55:25] <Krinkle>	 When not in an inspector the pulsating dot and its menu trigger an education popup indeed
[23:55:26] <Krinkle>	 (only once)
[23:55:29] <Krinkle>	 as expected
[23:55:46] <Krinkle>	 maybe the dot shouldn't pulsate when the link inspector is alreadyopen since clciking the tolbar button doesn't bring up the popup 
[23:55:57] <Krinkle>	 it felt broken to me. Genuine first experience!
[23:56:26] <Krinkle>	 (either that, or the popup shoudl open even if the inspector is open)
[23:58:06] <wikibugs>	 10Cite, 7Easy, 7I18n, 7Voice & Tone: Cite: Error message for an empty reference should be more appropriate and helpful - https://phabricator.wikimedia.org/T59619#1767402 (10jrbs)