[00:26:59] 10VisualEditor, 10VisualEditor-CopyPaste: Copying text {{Blah}} creates a template invocation - https://phabricator.wikimedia.org/T117376#1772430 (10Yurik) 3NEW [05:10:00] 10VisualEditor, 10VisualEditor-Tables, 7Browser-Support-Internet-Explorer: Table editing tools interfere with informational flyout in IE11 - https://phabricator.wikimedia.org/T117387#1772564 (10TTO) 3NEW [05:37:45] 10VisualEditor, 7Browser-Support-Internet-Explorer: Can't edit translatable pages in IE11 using VE - https://phabricator.wikimedia.org/T117389#1772588 (10TTO) 3NEW [09:01:34] 10VisualEditor, 10VisualEditor-CopyPaste: Wikitext paste handler should be undoable - https://phabricator.wikimedia.org/T117376#1772776 (10Esanders) [09:03:03] 10VisualEditor, 10VisualEditor-CopyPaste: Wikitext paste handler should be undoable - https://phabricator.wikimedia.org/T117376#1772430 (10Esanders) We have a wikitext paste handler that parses pasted wikitext. I think this feature is very useful but there should be a way to undo it for edge cases like writing... [09:33:57] (03CR) 10Hashar: "Any reason the basic browser test job invokes translate() ? Causing:" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/247630 (https://phabricator.wikimedia.org/T111525) (owner: 10Vikassy) [10:17:30] 10VisualEditor, 10MediaWiki-extensions-ContentTranslation, 10Parsoid, 7Parsoid-Nowiki, 7WorkType-Maintenance: "[[New York ]]population" should be automatically changed to "[[New York]] population" - https://phabricator.wikimedia.org/T117399#1772899 (10Amire80) 3NEW [10:25:28] (03PS7) 10Divec: WIP: Diff richtext to build model changes [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/247800 [10:25:41] (03PS3) 10Divec: WIP: Build model transactions from richtext DOM diff [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/249077 [10:28:43] (03CR) 10jenkins-bot: [V: 04-1] WIP: Build model transactions from richtext DOM diff [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/249077 (owner: 10Divec) [11:41:45] 10Cite, 10MediaWiki-Parser, 10MediaWiki-extensions-ContentTranslation, 7WorkType-Maintenance: ContentTranslation creates references that render themselves as UNIQ--nowiki-00000007-QINU - https://phabricator.wikimedia.org/T107303#1773106 (10Amire80) [11:42:45] 10VisualEditor, 10MediaWiki-extensions-ContentTranslation, 10Parsoid, 7Parsoid-Nowiki, 7WorkType-Maintenance: "[[New York ]]population" should be automatically changed to "[[New York]] population" - https://phabricator.wikimedia.org/T117399#1773108 (10Amire80) [11:48:21] 10VisualEditor, 10VisualEditor-MediaWiki, 7Design, 7Epic: Provide a single edit tab which has both visual and wikitext modes and allows on-the-fly switching between them - https://phabricator.wikimedia.org/T102398#1773130 (10Trizek-WMF) [11:51:51] 10VisualEditor, 10VisualEditor-MediaWiki, 7Design, 7Epic: Provide a single edit tab which has both visual and wikitext modes and allows on-the-fly switching between them - https://phabricator.wikimedia.org/T102398#1363629 (10Trizek-WMF) {T117281} is blocked by this task on these points: - video recording... [12:16:46] (03CR) 10Zfilipin: "The commit fixes the problem:" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/247630 (https://phabricator.wikimedia.org/T111525) (owner: 10Vikassy) [12:18:08] (03PS4) 10Zfilipin: [BrowserTest] Select English when LANGUAGE_SCREENSHOT_CODE environment variable is not set [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/247630 (https://phabricator.wikimedia.org/T111525) (owner: 10Vikassy) [12:18:15] (03CR) 10Zfilipin: [C: 032] [BrowserTest] Select English when LANGUAGE_SCREENSHOT_CODE environment variable is not set [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/247630 (https://phabricator.wikimedia.org/T111525) (owner: 10Vikassy) [12:22:41] (03Merged) 10jenkins-bot: [BrowserTest] Select English when LANGUAGE_SCREENSHOT_CODE environment variable is not set [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/247630 (https://phabricator.wikimedia.org/T111525) (owner: 10Vikassy) [12:22:48] 10VisualEditor, 10VisualEditor-MediaWiki: Clicking on "Read" after enabling VisualEditor does not go to the original page - https://phabricator.wikimedia.org/T117360#1773190 (10He7d3r) [12:24:30] 10VisualEditor: after creating a link in VisualEditor, put the caret after the link - https://phabricator.wikimedia.org/T117408#1773193 (10Amire80) 3NEW [12:31:55] (03PS4) 10Divec: WIP: Build model transactions from richtext DOM diff [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/249077 [12:36:24] (03CR) 10jenkins-bot: [V: 04-1] WIP: Build model transactions from richtext DOM diff [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/249077 (owner: 10Divec) [12:51:58] 10VisualEditor, 10VisualEditor-MediaWiki, 7Design, 7Epic: Provide a single edit tab which has both visual and wikitext modes and allows on-the-fly switching between them - https://phabricator.wikimedia.org/T102398#1773233 (10Alsee) The more I read and the more I think about it, the more it seems that a sin... [12:56:15] 10VisualEditor, 10Wikimedia-Site-Requests: Enable VisualEditor for some user groups at the Spanish Wikipedia - https://phabricator.wikimedia.org/T117410#1773234 (10Elitre) 3NEW a:3Jdforrester-WMF [13:06:29] 10VisualEditor, 10Browser-Tests, 10Continuous-Integration-Infrastructure: browsertests-VisualEditor-language-screenshot-os_x_10.10-firefox jenkins job failing - https://phabricator.wikimedia.org/T111510#1773258 (10zeljkofilipin) [13:06:31] 10VisualEditor, 10Browser-Tests, 5Patch-For-Review: Delete or fix failed VisualEditor browsertests Jenkins jobs - https://phabricator.wikimedia.org/T94162#1773259 (10zeljkofilipin) [13:06:34] 10VisualEditor, 10Browser-Tests, 5Patch-For-Review: No such file or directory - i18n/af.json (Errno::ENOENT) - https://phabricator.wikimedia.org/T111525#1773256 (10zeljkofilipin) 5Open>3Resolved Fixed in https://gerrit.wikimedia.org/r/#/c/247630/ [13:12:41] have I told you lately that I love you, guys? 'cause I do. [13:15:00] 10VisualEditor, 10Browser-Tests, 5Patch-For-Review: Delete or fix failed VisualEditor browsertests Jenkins jobs - https://phabricator.wikimedia.org/T94162#1773277 (10zeljkofilipin) a:5zeljkofilipin>3None @vikassy has fixed the problem that caused all VisualEditor browser tests to fail (T111525). I have... [15:14:25] Elitre: We love you too! Anything in particular? [15:17:29] 10VisualEditor, 10VisualEditor-EditingTools, 10MediaWiki-extensions-WikibaseClient, 10Wikidata: [Story] VisualEditor: Ability to edit language links on Wikidata from within the editor - https://phabricator.wikimedia.org/T54105#1773761 (10Jonas) [15:37:30] James_F: Nope, just a general heads-up. [15:37:50] * James_F grins. [15:38:10] Elitre: How do you want to go with eswiki? Do existing users first, then start with new users? [15:38:28] (That's hard, but if you insist.) [15:38:36] James_F: how about the other way around? :p [15:38:45] That's easier. :-) [15:38:59] When do you want us to start? I could schedule it for 20 minutes' time… [15:40:39] I don't have preferences about that, but if you're going to only deploy for, say, 25% of newly registered users, then maybe that should be ok. Should we do 50% next Monday? [15:41:11] I was going to start at 10%. [15:41:18] But 25% works too. [15:41:23] How quickly do you want to go? [15:41:55] 25-50-75-100, then after a week all registered editors? [15:42:17] and if this doesn't work for them, hopefully they'll shout. [15:44:46] I'm going to write about this in Phab. [15:44:55] OK. [15:45:03] Maybe start tomorrow not today, given the short notice? [15:45:45] 10VisualEditor, 10Wikimedia-Site-Requests: Enable VisualEditor for some user groups at the Spanish Wikipedia - https://phabricator.wikimedia.org/T117410#1773881 (10Jdforrester-WMF) p:5Triage>3Normal [15:46:56] yeah, sure, I won't be around then, but luckily you don't need me for that. [15:47:41] :-0 [15:47:45] I always need you! [15:48:47] nah. [15:49:27] 10VisualEditor, 10VisualEditor-ContentEditable, 10Browser-Tests: VisualEditor: Inserting some content in a QA script doesn't round-trip (null diff) - failure to inserting CE content into DM somehow? - https://phabricator.wikimedia.org/T55721#1773897 (10zeljkofilipin) Is this still a problem, or can the task... [15:53:28] 10VisualEditor, 10Wikimedia-Site-Requests: Enable VisualEditor for some user groups at the Spanish Wikipedia - https://phabricator.wikimedia.org/T117410#1773918 (10Elitre) Current plan is starting the rollout progressively for newly registered editors, then extending VE to all logged-in editors after that: **... [15:55:06] James_F: maybe you wanted the other dates to be Mondays? can change that. [15:55:12] Elitre: It's fine. [15:55:23] ok, notifying es.wiki. [16:12:36] 10VisualEditor, 10Browser-Tests: VE cursor test invokes ULS IME in Firefox on test2wiki - https://phabricator.wikimedia.org/T57972#1773984 (10zeljkofilipin) Is this still a problem, or can this task be resolved? [16:31:11] 10VisualEditor, 10MediaWiki-extensions-ContentTranslation, 10Parsoid, 7Parsoid-Nowiki, 7WorkType-Maintenance: "[[New York ]]population" should be automatically changed to "[[New York]] population" - https://phabricator.wikimedia.org/T117399#1774063 (10Whatamidoing-WMF) I think that [[https://en.... [16:35:49] Elitre: Oh, wait. We can't do 75% easily. [16:39:22] James_F: I think I remember something about that... so what should the percentage actually be? [16:39:38] Elitre: We could do 10%, 25%, 50%, 100%? [16:39:51] Elitre: Or just 25/50/100 in three steps? [16:40:16] ok. changing to 10 etc. [16:41:31] Excuse me, is there anyone familiar with the ve-ce-Surface code here? If so, could they explain what a unicorn is? [16:42:14] Glenn_: It's a piece of VisualEditor magic which inserts an invisible image into certain places in the text to trick browsers into behaving correctly. [16:43:36] thanks [16:44:14] 10VisualEditor, 10MediaWiki-extensions-ContentTranslation, 10Parsoid, 7Parsoid-Nowiki, 7WorkType-Maintenance: "[[New York ]]population" should be automatically changed to "[[New York]] population" - https://phabricator.wikimedia.org/T117399#1774152 (10Amire80) No, this is most likely because the... [16:56:03] 10VisualEditor, 10MediaWiki-extensions-ContentTranslation, 10Parsoid, 7Parsoid-Nowiki, 7WorkType-Maintenance: "[[New York ]]population" should be automatically changed to "[[New York ]] population" (note embedded space) - https://phabricator.wikimedia.org/T117399#1774212 (10cscott) [17:02:07] 10VisualEditor, 10MediaWiki-extensions-ContentTranslation, 10Parsoid, 7Parsoid-Nowiki, 7WorkType-Maintenance: "[[New York ]]population" should be automatically changed to "[[New York]] population" - https://phabricator.wikimedia.org/T117399#1774256 (10Amire80) [17:03:17] 10VisualEditor, 10MediaWiki-extensions-ContentTranslation, 10Parsoid, 7Parsoid-Nowiki, 7WorkType-Maintenance: "[[New York ]]population" should be automatically changed to "[[New York]] population" - https://phabricator.wikimedia.org/T117399#1772899 (10Amire80) Regarding the task title change: I... [17:29:55] (03CR) 10Esanders: [C: 032] Add mediawiki-specific sequences to the command help dialog [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/248373 (https://phabricator.wikimedia.org/T116013) (owner: 10DLynch) [17:30:22] 10VisualEditor, 10VisualEditor-EditingTools: Show sequence shortcuts in the help dialog (CommandHelpDialog) - https://phabricator.wikimedia.org/T116013#1774390 (10Jdforrester-WMF) 5Open>3Resolved [17:33:54] (03Merged) 10jenkins-bot: Add mediawiki-specific sequences to the command help dialog [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/248373 (https://phabricator.wikimedia.org/T116013) (owner: 10DLynch) [17:41:05] (03PS2) 10Jforrester: Update VE core submodule to master (062cb26) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/250285 [17:42:01] (03CR) 10Jforrester: [C: 031] Allow switching from wikitext to VE [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/245593 (https://phabricator.wikimedia.org/T49779) (owner: 10Alex Monk) [17:42:06] (03CR) 10Jforrester: [C: 031] Dialog for switching between wikitext and visual editing [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/247485 (owner: 10Alex Monk) [17:42:33] edsanders: It'd be great if those ^^^ could be merged ASAP so we can do final testing and release this week. [17:42:39] [17:46:25] (03CR) 10jenkins-bot: [V: 04-1] Update VE core submodule to master (062cb26) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/250285 (owner: 10Jforrester) [17:46:30] Meh. [18:21:00] 10VisualEditor, 10MediaWiki-extensions-ContentTranslation, 10Parsoid, 7Parsoid-Nowiki, 7WorkType-Maintenance: "[[New York ]]population" should be automatically changed to "[[New York]] population" - https://phabricator.wikimedia.org/T117399#1774673 (10cscott) I don't think Parsoid would serializ... [18:21:25] (03CR) 10Esanders: Allow switching from wikitext to VE (032 comments) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/245593 (https://phabricator.wikimedia.org/T49779) (owner: 10Alex Monk) [18:32:57] 10VisualEditor, 10MediaWiki-extensions-ContentTranslation, 10Parsoid, 7Parsoid-Nowiki, 7WorkType-Maintenance: "[[New York ]]population" should be automatically changed to "[[New York]] population" - https://phabricator.wikimedia.org/T117399#1774745 (10ssastry) cscott: we already do migrate trail... [18:33:00] 10VisualEditor: Null edits in VisualEditor don't fire the postEdit hook - https://phabricator.wikimedia.org/T117455#1774746 (10kaldari) 3NEW [18:34:08] 10VisualEditor, 6Community-Liaison, 6Editing-Analysis: Find out why the visual editor is so used at the Portuguese Wikipedia - https://phabricator.wikimedia.org/T115724#1774755 (10Elitre) Is there a wildly popular site in the Portuguese-speaking world which VE's interface may remind people of? Which are the... [18:35:16] 10VisualEditor, 10MediaWiki-extensions-ContentTranslation, 10Parsoid, 7Parsoid-Nowiki, 7WorkType-Maintenance: "[[New York ]]population" should be automatically changed to "[[New York]] population" - https://phabricator.wikimedia.org/T117399#1774767 (10Arlolra) We already do this: https://github.... [19:04:09] (03CR) 10Jforrester: [C: 032] ve.ui.MWMediaDialog: Wait for upload booklet to initialize when setting up [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/249568 (owner: 10Bartosz Dziewoński) [19:08:07] (03Merged) 10jenkins-bot: ve.ui.MWMediaDialog: Wait for upload booklet to initialize when setting up [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/249568 (owner: 10Bartosz Dziewoński) [19:09:53] 10VisualEditor, 10VisualEditor-ContentLanguage: Clarify the purpose of the Language character styling option - https://phabricator.wikimedia.org/T117460#1774886 (10Whatamidoing-WMF) 3NEW [19:10:07] dismissing the education popup on mobile, then trying to use the tool seems to cause some sort of loop resulting in RangeError: Maximum call stack size exceeded [19:12:34] James_F: https://gerrit.wikimedia.org/r/250474 is not about IPs, right? :) We'll have to wait for a new vote on those. [19:23:00] don't yet understand why it's only mobile [19:25:13] Oh... [19:25:24] ept.constructor.name [19:25:24] "VeUiMwMobileLinkInspectorTool" [19:26:48] Krinkle, hey [19:28:01] 10VisualEditor, 10Wikimedia-Site-Requests, 5Patch-For-Review: Enable VisualEditor for some user groups at the Spanish Wikipedia - https://phabricator.wikimedia.org/T117410#1774965 (10Elitre) [19:47:10] 10VisualEditor, 10VisualEditor-MediaWiki, 3Community-Tech-Sprint: HotCat doesn't load after saving a page in VisualEditor (must refresh/reload first) [AOI] - https://phabricator.wikimedia.org/T103285#1775077 (10kaldari) 5Open>3Resolved Fixed on Commons (and all wikis that import HotCat from Commons): htt... [19:49:36] Krenair: Hi [19:49:48] Are you familiar with the education popup tool code? [19:49:54] No [19:50:16] basically I made a mixin class that you add to Tools [19:50:23] we added it to the link inspector tool [19:50:42] I only first saw it last weekend. Wasn't sure it was an issue with my eye or a real dot on the screen ;-) [19:50:53] however, it relies on the mixin being applied to the constructor itself, not their parent [19:51:15] this breaks on mobile because mobile uses it's own link inspector tool subclass [19:51:35] I'm wondering what the proper way to deal with this is in OOjs [19:52:56] 10VisualEditor, 10VisualEditor-MediaWiki: Education popup pulsating dot is cut off - https://phabricator.wikimedia.org/T117469#1775085 (10Krinkle) 3NEW [19:53:29] Krenair: I'm confused. What is the class hiearchy? [19:53:35] Why would it need to be in the parent? [19:55:32] The Tools all extend ve.ui.Tool or a subclass [19:56:02] I'm looking at MWEducationPopupTool now [19:56:10] that initialises its own class, so it's not abstract [19:56:12] it's not a mixin [19:56:19] I'd expect this class to be used directly [19:56:22] or inherited from [19:56:24] stuff breaks if you make a tool that inherits from a class which uses MWEducationPopupTool as a mixin [19:56:31] MWEducationPopupTool is not a mixin [19:56:47] Checking usage now [19:57:26] modules/ve-mw/ui/tools/ve.ui.MWLinkInspectorTool.js:OO.mixinClass( ve.ui.MWLinkInspectorTool, ve.ui.MWEducationPopupTool ); [19:57:48] Yeah, it's not properly defined as mixin though. Because it's not @abstract, and has initClass. Which should be fixed. [19:58:06] OK. So in MWLinkInspectorTool it seems used as a regular mixin [19:58:20] but there's also this: modules/ve-mw/ui/tools/ve.ui.MWMobileLinkInspectorTool.js:OO.inheritClass( ve.ui.MWMobileLinkInspectorTool, ve.ui.MWLinkInspectorTool ); [19:58:53] And this: modules/ve-mw/ui/tools/ve.ui.MWEducationPopupTool.js: return this.constructor.super.prototype.onSelect.apply( this, arguments ); [19:59:26] this.constructor.super is what makes the lop [19:59:29] you can't use that [19:59:29] yes [19:59:32] I know that [19:59:34] use Foo.super instead [19:59:50] Foo? [20:00:01] Whatever the current class is where the call is made [20:00:27] if Foo extends Bar and you want to call Bar without hardcoding it you use Foo.super [20:00:33] that's the pattern we use for oojs [20:00:49] but what is Foo in this context? [20:00:49] https://github.com/wikimedia/oojs/blob/e73c17080a9c728bf540cd893cd8e75d99299bad/src/core.js#L63 [20:00:58] The class where the code is used [20:01:29] You can't use .super in a mixin [20:01:34] Also doesn't make sense conceptually [20:01:40] 10VisualEditor, 6Community-Liaison, 6Editing-Analysis: Find out why the visual editor is so used at the Portuguese Wikipedia - https://phabricator.wikimedia.org/T115724#1775131 (10He7d3r) Probably Microsoft Word and/or LibreOffice Writer. I'm not aware of any popular site which might be similar to VE's inter... [20:02:12] What is this.constructor.super.prototype.onSelect intending to refer to? [20:02:31] I think mixin is the wrong way to approach this [20:02:57] Is it intending to refer to the class mixing it in (e.g. MWLinkInspectorTool) or to the parent of that class? [20:02:59] the onSelect function of the class it's mixed into [20:02:59] the education popups should be in their own registry and pointed at tools [20:03:11] Krenair: That doesnt' work because mixin will overwrite the function [20:03:20] that is what a mixin does. It's like $.extend(targetclass, mixin) [20:03:25] or it's parent [20:03:26] it's just a bag of some functions to copy over [20:03:49] So whatever method you define in the target class it is mixed in to will overwrite, so the one you mixed in no longer exists. [20:04:49] Or, if you mixin at the bottom of the file, then the mixin will win, but either way the class can only have the method defined one. [20:05:04] If you want this as a mixin, then the target class for onSelect should probably be a config option [20:05:56] I guess this works on desktoip because the mixins' onSelect is never called? [20:06:09] ... no [20:06:15] it's definitely called [20:06:42] constructor.super.... call will always cause a loop [20:07:18] because 'this' will remain the same when you go up, so you always go back to the same one [20:07:38] unless the parent doesn't call its parent of course, then it will terminiate there [20:07:49] I think this works on desktop [20:08:02] I think what you may be looking for is to put some logic in the education popup mixin, and call it from the link inspector's onSelect method [20:08:06] and call the parent from there [20:08:18] so the mixin just provides the logic as a separate method under a different name and you make use of it [20:08:40] either that, or it runs itself via an event handler if an event is fired from onSelect (but that's probably too late) [20:09:39] Yeah, the parent class doesn't call its parent so it works on desktop. [20:10:06] but on mobile there is a subclass, so since 'this' is always the final object , its parent is the mw link inspector [20:45:43] 10VisualEditor, 10VisualEditor-MediaWiki, 3Community-Tech-Sprint: HotCat doesn't load after saving a page in VisualEditor (must refresh/reload first) [AOI] - https://phabricator.wikimedia.org/T103285#1775322 (10TheDJ) ehm, but postEdit is not the appropriate hook of course. I'm not really in favor af abusing... [20:56:25] (03PS9) 10Alex Monk: Allow switching from wikitext to VE [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/245593 (https://phabricator.wikimedia.org/T49779) [21:00:41] (03CR) 10jenkins-bot: [V: 04-1] Allow switching from wikitext to VE [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/245593 (https://phabricator.wikimedia.org/T49779) (owner: 10Alex Monk) [21:01:24] (03CR) 10Alex Monk: "recheck" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/245593 (https://phabricator.wikimedia.org/T49779) (owner: 10Alex Monk) [21:05:18] 10VisualEditor, 10VisualEditor-MediaWiki, 3Community-Tech-Sprint: HotCat doesn't load after saving a page in VisualEditor (must refresh/reload first) [AOI] - https://phabricator.wikimedia.org/T103285#1775390 (10kaldari) >ehm, but postEdit is not the appropriate hook of course. Why is postEdit not appropriat... [21:06:28] 10VisualEditor, 7Performance: Large/big page can make the browser freeze - https://phabricator.wikimedia.org/T117053#1775392 (10Pols12) {T50429} could probably help to fix this issue. [21:06:39] 10VisualEditor, 10VisualEditor-MediaWiki: When editing, prompt the user with suggested images used in other languages' version of this article - https://phabricator.wikimedia.org/T114233#1775403 (10CennoxX) When the user inserts an image, he is already prompted with suggested images, so I don's know if the men... [21:08:29] 10VisualEditor, 10Phlogiston: Recently Closed report should be easier to read for last 1-3 weeks - https://phabricator.wikimedia.org/T117481#1775428 (10JAufrecht) 3NEW a:3JAufrecht [21:39:46] 10VisualEditor, 10Design Research Archive, 6WMF-Design: Consider ways to visually differentiate low-level subheadings - https://phabricator.wikimedia.org/T99629#1775576 (10Jdlrobson) [21:42:21] 10VisualEditor: Impossible to add relative section link [[#section|text]] - https://phabricator.wikimedia.org/T117487#1775592 (10Pols12) 3NEW [22:10:48] 10VisualEditor, 10VisualEditor-MediaWiki: Null edits in VisualEditor don't fire the postEdit hook - https://phabricator.wikimedia.org/T117455#1775691 (10Jdforrester-WMF) p:5Triage>3Low [22:11:17] 10VisualEditor, 10VisualEditor-MediaWiki: Null edits in VisualEditor don't fire the postEdit hook - https://phabricator.wikimedia.org/T117455#1774746 (10Jdforrester-WMF) @TheDJ – you expressed some concerns about doing this on T103285? [22:15:13] edsanders: So… [22:15:26] wut [22:15:49] edsanders: https://gerrit.wikimedia.org/r/#/c/245593/ [22:22:04] (03CR) 10Jforrester: [C: 031] Allow switching from wikitext to VE [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/245593 (https://phabricator.wikimedia.org/T49779) (owner: 10Alex Monk) [22:32:31] (03CR) 10Esanders: [C: 032] Allow switching from wikitext to VE [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/245593 (https://phabricator.wikimedia.org/T49779) (owner: 10Alex Monk) [22:39:35] 10VisualEditor, 10VisualEditor-EditingTools: Commons file uploads through Visual Editor should not shadow local files - https://phabricator.wikimedia.org/T117498#1775837 (10Stefan2) 3NEW [22:40:00] 10TemplateData, 6Community-Liaison, 7Documentation, 7Easy, 3Google-Code-In-2015: Check documentation for the TemplateData editor for completeness, accuracy, and ease of understanding by adding TemplateData to templates on Wikipedia - https://phabricator.wikimedia.org/T117499#1775845 (10Whatamidoing-WMF)... [22:43:13] (03CR) 10jenkins-bot: [V: 04-1] Allow switching from wikitext to VE [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/245593 (https://phabricator.wikimedia.org/T49779) (owner: 10Alex Monk) [22:48:31] 10TemplateData, 6Community-Liaison, 7Documentation, 7Easy, 3Google-Code-In-2015: Check documentation for the TemplateData editor for completeness, accuracy, and ease of understanding by adding TemplateData to templates on Wikipedia - https://phabricator.wikimedia.org/T117499#1775901 (10Whatamidoing-WMF)... [23:14:22] Well, that's unhelpful. [23:15:52] (03CR) 10Jforrester: [C: 032] Allow switching from wikitext to VE [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/245593 (https://phabricator.wikimedia.org/T49779) (owner: 10Alex Monk) [23:18:35] (03Merged) 10jenkins-bot: Allow switching from wikitext to VE [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/245593 (https://phabricator.wikimedia.org/T49779) (owner: 10Alex Monk) [23:18:44] Whee. [23:18:56] (03PS9) 10Jforrester: Dialog for switching between wikitext and visual editing [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/247485 (owner: 10Alex Monk) [23:22:45] edsanders|away: https://gerrit.wikimedia.org/r/#/c/247485/ good to go too? [23:34:08] James_F, by the way, to make this actually work we will need to add a new setting to the config [23:34:29] * James_F nods. [23:34:32] it's not really the intended function, but I guess that actually functions as an on/off switch :) [23:35:14] Krenair: Want to write the config patch for VisualEditorFullRestbaseURL now? SWAT's in 24 minutes' time. :-) [23:35:26] I should get the vagrant patch done as well [23:35:36] That'd be nice. Config first. :-) [23:35:39] yes [23:35:47] * James_F cracks the whip. [23:42:16] https://gerrit.wikimedia.org/r/#/c/250590/1 [23:42:41] Thanks! [23:43:09] Krenair: I'll put it in Deployments, you do the MW-Vagrant one. [23:43:16] ok [23:45:49] 10VisualEditor, 10VisualEditor-MediaWiki: Education popup pulsating dot is cut off - https://phabricator.wikimedia.org/T117469#1776051 (10Krinkle) [23:50:14] 10VisualEditor, 10VisualEditor-MediaWiki: Education popup pulsating dots are cut off - https://phabricator.wikimedia.org/T117469#1776066 (10Jdforrester-WMF) p:5Triage>3Normal