[00:00:50] 10VisualEditor, 10VisualEditor-MediaWiki-Mobile, 6Editing-Department, 10MobileFrontend: Rewrite VisualEditorOverlay header using OOjs UI - https://phabricator.wikimedia.org/T96187#1776139 (10Jdlrobson) [00:03:15] I don't have a simple solution to the popups on mobile problem by the way, James_F [00:03:20] :-( [00:03:31] Disable for now? [01:07:37] (03CR) 10Jforrester: [C: 032] Dialog for switching between wikitext and visual editing [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/247485 (owner: 10Alex Monk) [01:11:32] (03CR) 10Jforrester: [C: 032] AceEditorWidget: Preserve selection on setValue [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/250031 (owner: 10Esanders) [01:13:28] (03PS3) 10Jforrester: [PULL THROUGH] Remove resize detection now that TextInputWidget implements it [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/248306 (owner: 10Esanders) [01:13:34] (03CR) 10Jforrester: [C: 032] [PULL THROUGH] Remove resize detection now that TextInputWidget implements it [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/248306 (owner: 10Esanders) [01:14:17] (03PS4) 10Jforrester: MWEducationPopupTool: Changes to the dot [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/246799 (owner: 10Alex Monk) [01:14:25] (03PS5) 10Jforrester: MWEducationPopupTool: Changes to the dot [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/246799 (owner: 10Alex Monk) [01:14:43] (03CR) 10Jforrester: [C: 04-1] "More useful commit summary requested. Looks OK…" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/246799 (owner: 10Alex Monk) [01:15:13] Krenair: Can I steal a +2 on https://gerrit.wikimedia.org/r/#/c/237736/ ? :-) [01:15:23] (03CR) 10jenkins-bot: [V: 04-1] Dialog for switching between wikitext and visual editing [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/247485 (owner: 10Alex Monk) [01:15:28] Eh. [01:15:45] (03PS6) 10Alex Monk: MWEducationPopupTool: Changes to the dot [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/246799 [01:16:47] (03CR) 10Alex Monk: [C: 032] Tags: Switch 'VisualEditor' out for 'the visual editor' as elsewhere [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/237736 (owner: 10Jforrester) [01:16:52] Ta. [01:17:21] (03Merged) 10jenkins-bot: AceEditorWidget: Preserve selection on setValue [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/250031 (owner: 10Esanders) [01:17:32] (03PS5) 10Jforrester: Ensure magic link nodes inherit the annotations of their text [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/238609 (owner: 10Cscott) [01:18:53] (03CR) 10jenkins-bot: [V: 04-1] [PULL THROUGH] Remove resize detection now that TextInputWidget implements it [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/248306 (owner: 10Esanders) [01:19:02] * James_F sighs at CI. [01:19:25] (03CR) 10Jforrester: "Was 6cae77b an unflagged breaking change?" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/250285 (owner: 10Jforrester) [01:20:53] (03PS2) 10Jforrester: MWSaveDialog: Fix styling of border radii [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/249142 (owner: 10Esanders) [01:20:59] (03CR) 10Jforrester: [C: 032] MWSaveDialog: Fix styling of border radii [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/249142 (owner: 10Esanders) [01:24:37] (03Merged) 10jenkins-bot: MWEducationPopupTool: Changes to the dot [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/246799 (owner: 10Alex Monk) [01:24:39] (03Merged) 10jenkins-bot: Tags: Switch 'VisualEditor' out for 'the visual editor' as elsewhere [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/237736 (owner: 10Jforrester) [01:25:16] (03CR) 10jenkins-bot: [V: 04-1] Ensure magic link nodes inherit the annotations of their text [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/238609 (owner: 10Cscott) [01:25:47] is jenkins -1ing things more often than usual? [01:26:14] Yes. [01:26:27] It's sometimes just throwing its toys on the floor. [01:26:33] I'm being somewhat impatient. [01:28:33] (03Merged) 10jenkins-bot: MWSaveDialog: Fix styling of border radii [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/249142 (owner: 10Esanders) [01:36:33] (03PS10) 10Jforrester: Dialog for switching between wikitext and visual editing [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/247485 (owner: 10Alex Monk) [01:38:49] (03CR) 10Jforrester: [C: 032] Dialog for switching between wikitext and visual editing [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/247485 (owner: 10Alex Monk) [01:42:00] (03Merged) 10jenkins-bot: Dialog for switching between wikitext and visual editing [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/247485 (owner: 10Alex Monk) [01:43:25] (03CR) 10Jforrester: [C: 032] [PULL THROUGH] Remove resize detection now that TextInputWidget implements it [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/248306 (owner: 10Esanders) [01:47:43] (03Merged) 10jenkins-bot: [PULL THROUGH] Remove resize detection now that TextInputWidget implements it [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/248306 (owner: 10Esanders) [07:51:20] (03CR) 10DLynch: [C: 04-1] "Isn't 24de6b2 a breaking change as well? It needs some new files added to `extension.json` before merging, I think." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/250285 (owner: 10Jforrester) [07:53:09] (03PS1) 10DLynch: Forcibly trigger a selection when using a Tool, to close inspectors [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/250646 (https://phabricator.wikimedia.org/T76717) [07:54:13] ^^^ I put that up with pretty solid expectations of being given a -1 and pointed towards a better way to communicate between points in the code. :) [10:24:30] (03CR) 10Esanders: "We don't usually bother marking new files as a breaking change. The fact that MW doesn't build it's ve core file manifest auto" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/250285 (owner: 10Jforrester) [10:24:42] (03CR) 10Esanders: "...matically is a bug." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/250285 (owner: 10Jforrester) [10:37:10] (03PS3) 10Esanders: Update VE core submodule to master (062cb26) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/250285 (owner: 10Jforrester) [10:54:50] (03CR) 10Esanders: [C: 032] Update VE core submodule to master (062cb26) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/250285 (owner: 10Jforrester) [10:58:09] (03PS1) 10Esanders: CommandHelpDialog: Use new method for getting access key prefix [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/250658 [10:59:25] (03Merged) 10jenkins-bot: Update VE core submodule to master (062cb26) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/250285 (owner: 10Jforrester) [11:01:38] (03CR) 10jenkins-bot: [V: 04-1] CommandHelpDialog: Use new method for getting access key prefix [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/250658 (owner: 10Esanders) [11:05:04] (03PS1) 10Esanders: CommandHelpDialog: Rename 'category' to 'groupName' [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/250661 [11:07:18] (03PS2) 10Esanders: CommandHelpDialog: Use new method for getting access key prefix [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/250658 [11:23:14] (03PS1) 10Esanders: CommandHelpDialog: Move extensions into separate group [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/250664 [11:23:16] (03PS1) 10Esanders: CommandHelpDialog: Move registrations to where sequences are defined [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/250665 [11:28:41] (03CR) 10jenkins-bot: [V: 04-1] CommandHelpDialog: Move registrations to where sequences are defined [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/250665 (owner: 10Esanders) [14:13:20] 10Citoid: Unrecognized language link - https://phabricator.wikimedia.org/T117305#1777187 (10Mvolz) [14:13:21] 10Citoid: "Unknown language" error on it.wp for sources in Italian - https://phabricator.wikimedia.org/T115326#1777188 (10Mvolz) [14:29:36] 10VisualEditor, 10VisualEditor-MediaWiki-Media, 6Multimedia: Upload can timeout causing an unhandled exception - https://phabricator.wikimedia.org/T117545#1777212 (10Esanders) 3NEW [14:32:46] 10VisualEditor, 10VisualEditor-MediaWiki-Media, 6Multimedia: Upload can timeout causing an unhandled exception - https://phabricator.wikimedia.org/T117545#1777232 (10Esanders) There probably shouldn't be a timeout at all - it would help if we had a progress bar though. [14:33:41] 10VisualEditor, 10VisualEditor-MediaWiki-Media, 6Multimedia: Show progress during media upload - https://phabricator.wikimedia.org/T117546#1777236 (10Esanders) 3NEW [14:36:21] 10VisualEditor, 10VisualEditor-MediaWiki-Media, 6Multimedia: Pre-populate date from EXIF information - https://phabricator.wikimedia.org/T117547#1777243 (10Esanders) 3NEW [14:36:24] 10VisualEditor, 10VisualEditor-MediaWiki-Media, 6Multimedia: Show progress during media upload - https://phabricator.wikimedia.org/T117546#1777249 (10matmarex) [14:37:25] 10VisualEditor, 10VisualEditor-MediaWiki-Media, 6Multimedia: Pre-populate date from EXIF information - https://phabricator.wikimedia.org/T117547#1777262 (10matmarex) T115863? [14:46:39] 10Citoid: "Unknown language" error on it.wp for sources in Italian - https://phabricator.wikimedia.org/T115326#1777280 (10Mvolz) So, this is basically the result of us now scraping more data. Our language validator has always allowed xx-XX style language codes, we just weren't getting them as often so it wasn't... [14:48:07] 10Citoid: Improve language code validation - https://phabricator.wikimedia.org/T93561#1777282 (10Mvolz) @Elitre yup, related, thanks! [14:49:34] 10Citoid: Many language wiki templates (pl, it, en) don't accept xx-XX style language codes - https://phabricator.wikimedia.org/T115326#1777284 (10Mvolz) [14:50:31] 10Citoid: Many language wiki templates (pl, it, en) don't accept xx-XX style language codes - https://phabricator.wikimedia.org/T115326#1721484 (10Mvolz) [15:21:30] 10VisualEditor, 10VisualEditor-MediaWiki-Media, 10MediaWiki-General-or-Unknown, 6Multimedia: Show determinate progress bar for the image upload in mw.ForeignStructuredUpload.BookletLayout - https://phabricator.wikimedia.org/T115861#1777361 (10Esanders) [15:28:34] 10VisualEditor, 10VisualEditor-MediaWiki, 5WMF-deploy-2015-11-03_(1.27.0-wmf.5): Possible to trigger "Error: Invalid start offset: -1" when opening Page Settings on once-contentful, currently blank, page - https://phabricator.wikimedia.org/T107553#1777383 (10Jdforrester-WMF) 5Open>3Resolved [15:28:52] 10VisualEditor, 10VisualEditor-ContentEditable, 7Technical-Debt, 5WMF-deploy-2015-11-03_(1.27.0-wmf.5): Abstract away Selection handling from the surface - https://phabricator.wikimedia.org/T116748#1777386 (10Jdforrester-WMF) [15:28:53] 10VisualEditor, 10VisualEditor-ContentEditable, 7Technical-Debt: Break up ve.ce.Surface.js by functionality - https://phabricator.wikimedia.org/T78696#1777385 (10Jdforrester-WMF) [15:29:26] (03CR) 10Jforrester: [C: 032] "Yay for no console whining." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/250658 (owner: 10Esanders) [15:29:52] (03CR) 10Jforrester: [C: 032] CommandHelpDialog: Move extensions into separate group [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/250664 (owner: 10Esanders) [15:30:35] (03CR) 10Jforrester: [C: 04-1] "Actually, no, some of these aren't extensions at all." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/250664 (owner: 10Esanders) [15:31:04] (03CR) 10Jforrester: [C: 04-1] "Needs rebase." [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/247586 (https://phabricator.wikimedia.org/T115859) (owner: 10Esanders) [15:33:38] (03CR) 10jenkins-bot: [V: 04-1] CommandHelpDialog: Use new method for getting access key prefix [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/250658 (owner: 10Esanders) [15:33:40] (03CR) 10jenkins-bot: [V: 04-1] CommandHelpDialog: Move extensions into separate group [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/250664 (owner: 10Esanders) [15:34:36] 10VisualEditor, 10VisualEditor-MediaWiki-Media, 10MediaWiki-General-or-Unknown, 6Multimedia: Show determinate progress bar for the image upload in mw.ForeignStructuredUpload.BookletLayout - https://phabricator.wikimedia.org/T115861#1777437 (10Jdforrester-WMF) >>! In T115861#1777359, @Esanders wrote: > We c... [15:36:17] Krenair: Hmm. Trying to switch on Beta doesn't offer a choice to switch with, and throws "Cannot read property 'pushPending' of undefined". Config not working? [15:37:20] (03CR) 10Jforrester: [C: 032] CommandHelpDialog: Use new method for getting access key prefix [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/250658 (owner: 10Esanders) [15:39:25] James_F, I need to go but I'll take a look when I'm back in an hour and a half [15:39:52] Krenair: Sure. [15:40:53] (03Merged) 10jenkins-bot: CommandHelpDialog: Use new method for getting access key prefix [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/250658 (owner: 10Esanders) [15:42:37] 10VisualEditor, 10Parsoid, 7Parsoid-Nowiki: "[[Link]]
Word" should not be automatically changed to "[[Link]]Word" - https://phabricator.wikimedia.org/T117554#1777466 (10Whatamidoing-WMF) 3NEW [15:47:45] 10VisualEditor, 10Parsoid, 7Parsoid-Nowiki: "[[Link]]
Word" should not be automatically changed to "[[Link]]Word" - https://phabricator.wikimedia.org/T117554#1777485 (10Whatamidoing-WMF) [15:54:40] 10VisualEditor, 10VisualEditor-MediaWiki-Media, 10MediaWiki-General-or-Unknown, 6Multimedia: Show determinate progress bar for the image upload in mw.ForeignStructuredUpload.BookletLayout - https://phabricator.wikimedia.org/T115861#1777555 (10Prtksxna) I like the idea of showing the ETA and the %, but disl... [16:22:17] 10VisualEditor, 10Wikimedia-Site-Requests, 5Patch-For-Review: Enable VisualEditor for some user groups at the Spanish Wikipedia - https://phabricator.wikimedia.org/T117410#1777658 (10Jdforrester-WMF) [16:24:29] 10VisualEditor, 10Wikimedia-Site-Requests, 5Patch-For-Review: Enable VisualEditor for some user groups at the Spanish Wikipedia - https://phabricator.wikimedia.org/T117410#1777661 (10Jdforrester-WMF) [16:25:19] 10VisualEditor, 10VisualEditor-MediaWiki-Media, 6Multimedia: In the upload dialog, pre-populate date information from the file's EXIF data - https://phabricator.wikimedia.org/T117547#1777663 (10Jdforrester-WMF) p:5Triage>3Normal [16:26:51] 10VisualEditor, 10VisualEditor-MediaWiki-Media, 10MediaWiki-General-or-Unknown, 6Multimedia: Show determinate progress bar for the image upload in mw.ForeignStructuredUpload.BookletLayout - https://phabricator.wikimedia.org/T115861#1777671 (10Jdforrester-WMF) [16:29:56] 10VisualEditor, 10VisualEditor-EditingTools, 10VisualEditor-MediaWiki-Media, 6Multimedia: In the cross-wiki upload tool, check that the name of the file doesn't duplicate a local files elsewise they can't use the file - https://phabricator.wikimedia.org/T117498#1777687 (10Jdforrester-WMF) [16:30:56] 10VisualEditor, 10VisualEditor-EditingTools, 10VisualEditor-MediaWiki-Media, 6Multimedia: In the cross-wiki upload tool, check that the name of the file doesn't duplicate a local files elsewise they can't use the file - https://phabricator.wikimedia.org/T117498#1777696 (10Jdforrester-WMF) p:5Triage>3Nor... [16:33:31] 10VisualEditor, 10VisualEditor-MediaWiki, 5WMF-deploy-2015-11-03_(1.27.0-wmf.5): Education popup pulsating dots are cut off - https://phabricator.wikimedia.org/T117469#1777710 (10Jdforrester-WMF) 5Open>3Resolved a:3Krenair [16:36:17] 10VisualEditor: Impossible to add relative section link [[#section|text]] - https://phabricator.wikimedia.org/T117487#1777727 (10Jdforrester-WMF) [16:36:19] 10VisualEditor, 10VisualEditor-MediaWiki-Links: [Regression wmf23] On creating an inter-wiki link, the nice regex strips section parts of the link - https://phabricator.wikimedia.org/T112898#1777728 (10Jdforrester-WMF) [16:39:38] 10VisualEditor, 10VisualEditor-ContentLanguage, 7Design: Clarify the purpose of the Language character styling option - https://phabricator.wikimedia.org/T117460#1777744 (10Jdforrester-WMF) [17:04:00] (03CR) 10DLynch: [C: 032] CommandHelpDialog: Rename 'category' to 'groupName' [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/250661 (owner: 10Esanders) [17:04:34] 10VisualEditor, 10Parsoid, 7Parsoid-Nowiki: "[[Link]]
Word" should not be automatically changed to "[[Link]]Word" - https://phabricator.wikimedia.org/T117554#1777849 (10ssastry) Can you give me a bit more info about what exactly you did in VE to get this output? Because Parsoid preserves the
(03Merged) 10jenkins-bot: CommandHelpDialog: Rename 'category' to 'groupName' [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/250661 (owner: 10Esanders) [17:08:51] (03PS2) 10Esanders: CommandHelpDialog: Move insertions into a separate group [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/250664 [17:08:53] (03PS2) 10Esanders: CommandHelpDialog: Move registrations to where sequences are defined [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/250665 [17:12:54] (03CR) 10Esanders: "Created an insertions group that mirrors the toolbar. Doesn't exist in core because comment & table (the only insertions) don't have seque" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/250664 (owner: 10Esanders) [17:14:07] (03CR) 10jenkins-bot: [V: 04-1] CommandHelpDialog: Move registrations to where sequences are defined [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/250665 (owner: 10Esanders) [17:20:18] (03CR) 10DLynch: [C: 032] CommandHelpDialog: Move insertions into a separate group [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/250664 (owner: 10Esanders) [17:26:21] (03Merged) 10jenkins-bot: CommandHelpDialog: Move insertions into a separate group [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/250664 (owner: 10Esanders) [17:50:16] James_F, okay, so clearly discard changes is broken [17:50:31] keep changes relies on wgVisualEditorConfig.fullRestbaseUrl being set up which it hasn't... not sure why yet [17:50:52] Krenair: Fun. Maybe RESTbase isn't updated in beta? [17:51:21] (Maybe subbu knows?) [17:52:01] ? [17:52:06] nothing to do with restbase [17:52:09] it's our config [17:52:13] Oh, OK. [17:52:17] Sorry, subbu. [17:52:33] np [17:53:32] oh, I know why [17:53:40] I missed a bit in my config patch yesterday [17:54:46] Ha. Whoops. [17:55:08] I think [17:56:22] why is this patch not fixing it... [17:56:33] Is scap broken in beta? [17:56:36] bd808, hey [17:56:38] Plausibly. [18:04:00] it synch'd to mira but not to the local deployment-bastion dir? [18:07:06] James_F|Away, WT -> VE keeping changes should now work on beta [18:13:24] Krenair, I'm hitting "new OO.ui.WindowManager()" inside onEditTabClick [18:13:57] you're hitting it? [18:14:03] it's throwing an error? [18:14:03] which obviously doesn't work... [18:14:14] yeah ooui hasn't loaded at this point [18:14:22] on action=edit? [18:14:25] (from read mode) [18:14:31] um [18:14:35] veaction=edit [18:14:48] read mode -> VE (using 'edit tab') [18:16:11] you seeing that? [18:17:03] (03PS1) 10Alex Monk: Unbreak loading of VE in the read page [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/250713 [18:17:30] Yes, I realised it hits the error and has to change page instead of loading inside the existing one [18:17:34] I think that commit should fix it [18:17:46] yep - that's what I was thinking [18:18:14] is the assumption that OOui is then available a bit magic? [18:18:34] there's some magic to load it on action=edit, yeah [18:18:39] i.e. should we wrap it in a mw.loader call to be safe? [18:18:55] (03CR) 10Esanders: [C: 032] Unbreak loading of VE in the read page [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/250713 (owner: 10Alex Monk) [18:19:02] In VisualEditorHooks::onBeforePageDisplay [18:19:03] if ( in_array( Action::getActionName( RequestContext::getMain() ), array( 'edit', 'submit' ) ) ) { [18:19:04] $output->addModules( 'ext.visualEditor.switching' ); [18:19:04] } [18:19:14] which depends on ooui [18:19:16] yeah - I trust that is is loaded now [18:19:45] but I feel uneasy about using some indirect if statement to tell us if OOUI is available [18:19:55] yeah [18:20:05] Ideally OOUI would be available on every page and we wouldn't have this mess [18:20:06] if we wrapped the WindowManager stuff in mw.loader.using('ooui').done(function(){.... [18:20:22] then that bit of code won't break again in the next few months [18:21:00] hmm... yeah we could do that [18:21:56] (03CR) 10Esanders: "maybe wrap in mw.loader.using('ooui') to be safe" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/250713 (owner: 10Alex Monk) [18:22:32] am doing, edsanders [18:22:40] (03Merged) 10jenkins-bot: Unbreak loading of VE in the read page [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/250713 (owner: 10Alex Monk) [18:24:25] Krenair, did you install restbase from scratch or use vagrant? [18:24:41] from scratch on my machine, tested using vagrant [18:25:11] (well, I tested it on my machine before, but then I also set up vagrant and tested it there) [18:25:23] I have the code checked out and the config.yaml setup - do I need to edit the parsoid config? [18:25:37] or mediawiki config? [18:26:49] the only thing you should need to configure is connecting to restbase directly, with the new restbase full url setting [18:27:03] where is that? [18:27:23] you have VisualEditorRestbaseURL already set in your MW config, right? [18:28:07] you just need to add a similar line for VisualEditorFullRestbaseURL, but without 'v1' and everything after it [18:28:32] it's equal to false [18:28:48] as is full restbase url [18:28:48] $wgVisualEditorRestbaseURL is false? [18:29:06] well they're not defined in localsettings [18:29:17] you need to set them up [18:30:20] to? [18:31:05] oh I see [18:31:08] found the docs [18:31:19] Something like this: $wgVisualEditorFullRestbaseURL = "http://localhost:7231/your-wikis-restbase-hostname-here/"; [18:40:55] do we need to have two configs? [18:42:18] I think I made it work with just the full url [18:42:26] also bug: If I go WE -> edit -> VE (keep edit) -> WE, I get no OOUI prompt, and my changes are lost [18:42:44] (yeah the other one should be deprecated) [18:42:59] are you using the latest version of the code? [18:43:10] I thought I fixed an issue like that [18:43:15] I am [18:43:28] anyway, fiddling with modules at the moment, got this error: [18:43:29] Exception in module-execute in module ext.visualEditor.mwcore: [18:43:33] TypeError: Cannot read property 'getMessage' of undefined TypeError: Cannot read property 'getMessage' of undefined(�) [18:43:39] stack trace is useless [18:43:50] you should be able to find out what undefined is? [18:43:56] git submodule update? [18:44:42] submodule is up to date [18:45:06] ugh, right, a more useful stack trace was behind the (...) [18:45:20] Cannot read property 'getMessage' of undefined [18:45:20] at Object.ve.msg [18:45:23] what. [18:46:03] is this is master -or with some changes? [18:46:05] ve.init.platform.getMessage.apply( ve.init.platform, arguments ); [18:46:15] ve.init.platform is undefined [18:46:23] some changes [18:48:41] looks like I need the ext.visualEditor.mediawiki module too [18:48:56] In the using() call? [18:49:27] yes [18:49:43] alongside the mwcore module :S [18:50:04] Surely ext.visualEditor.mediawiki pulls in ext.visualEditor.mwcore [18:52:10] Urgh. [18:52:22] I thought I had it working, but then on save: Uncaught TypeError: Cannot read property 'replace' of undefined [18:52:28] From $.byteLength? wtf? [18:52:54] byteLength is being passed undefined? [18:53:34] from code that handles API errors... [18:54:10] because it timed out [18:55:21] Helpful. [18:55:36] I should fix that in a separate commit [18:55:44] Yes. [18:55:59] 10VisualEditor, 10Phlogiston: Recently Closed report should be easier to read for last 1-3 weeks - https://phabricator.wikimedia.org/T117481#1775428 (10Jdforrester-WMF) [18:56:09] (03PS1) 10Alex Monk: Use mw.loader.using instead of weird hacks to load OOjs UI on action=edit [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/250719 [18:56:13] edsanders, ^ [18:57:19] Krenair: Doesn't that add ext.visualEditor.mediawiki to every non-read page, not just edit pages? [18:58:44] James_F, this function can only be called if we're on the read page, action=edit or action=submit [18:59:07] if ( pageCanLoadVE ) { $caVeEdit.click( init.onEditTabClick ); } [18:59:50] (03PS1) 10Esanders: VESwitchConfirmDialog: Use modes to hide 'keep' button [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/250721 [18:59:52] (03PS1) 10Esanders: VESwitchConfirmDialog: Set pending on the correct button [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/250722 [18:59:53] Krenair, ^ [19:00:54] (03CR) 10jenkins-bot: [V: 04-1] Use mw.loader.using instead of weird hacks to load OOjs UI on action=edit [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/250719 (owner: 10Alex Monk) [19:01:37] does your patch mean the dialog doesn't display immediately after you click it? [19:04:16] edsanders, yeah [19:05:22] (03CR) 10jenkins-bot: [V: 04-1] VESwitchConfirmDialog: Use modes to hide 'keep' button [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/250721 (owner: 10Esanders) [19:05:24] (03CR) 10Alex Monk: [C: 032] VESwitchConfirmDialog: Use modes to hide 'keep' button [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/250721 (owner: 10Esanders) [19:06:32] (03CR) 10Alex Monk: [C: 032] VESwitchConfirmDialog: Set pending on the correct button [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/250722 (owner: 10Esanders) [19:09:47] (03Merged) 10jenkins-bot: VESwitchConfirmDialog: Use modes to hide 'keep' button [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/250721 (owner: 10Esanders) [19:09:54] * Krenair goes to get dinner [19:12:33] (03CR) 10jenkins-bot: [V: 04-1] VESwitchConfirmDialog: Set pending on the correct button [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/250722 (owner: 10Esanders) [19:12:42] * James_F sighs at CI. [19:23:28] James_F, TrevorParscal how do you feel about pre-loading OOUI for the switch to VE dialog, vs loading it on click? [19:23:44] hmmm [19:23:45] edsanders: I'd rather we pre-load. [19:23:53] ori might have strong feelings [19:26:00] yeah [19:30:41] TrevorParscal: I asked, he was OK before. [19:30:59] Also, if we're using an OOUI icon in the wikitext editor toolbar we'll need it on load anyway. [19:32:53] Krenair, in which case we should preload OOUI [19:33:11] (03CR) 10Esanders: [C: 04-1] "we should preload OOUI so that the dialog shows instantly on click" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/250719 (owner: 10Alex Monk) [19:39:21] 10VisualEditor, 10Parsoid, 7Parsoid-Nowiki: "[[Link]]
Word" should not be automatically changed to "[[Link]]Word" - https://phabricator.wikimedia.org/T117554#1778627 (10Whatamidoing-WMF) I pasted a line into the cell. I deleted a word (and the spaces on either side of it) and pressed the Return... [19:48:42] (03CR) 10Esanders: [C: 032] VESwitchConfirmDialog: Set pending on the correct button [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/250722 (owner: 10Esanders) [19:52:30] (03CR) 10jenkins-bot: [V: 04-1] VESwitchConfirmDialog: Set pending on the correct button [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/250722 (owner: 10Esanders) [19:55:27] (03PS1) 10Jforrester: Unbreak loading of VE in the read page [extensions/VisualEditor] (wmf/1.27.0-wmf.5) - 10https://gerrit.wikimedia.org/r/250745 [19:56:16] (03PS1) 10Jforrester: VESwitchConfirmDialog: Use modes to hide 'keep' button [extensions/VisualEditor] (wmf/1.27.0-wmf.5) - 10https://gerrit.wikimedia.org/r/250747 [20:06:04] 10VisualEditor: [Regression pre-wmf.5]Getting "Switch to Visual Editing?" dialog after saving a page and trying to re-open VE - https://phabricator.wikimedia.org/T117596#1778822 (10Ryasmeen) [20:06:17] 10VisualEditor, 10VisualEditor-MediaWiki-Media, 6Multimedia: In the cross-wiki upload system, the upload can timeout causing an unhandled exception - https://phabricator.wikimedia.org/T117545#1778828 (10Jdforrester-WMF) p:5Triage>3Normal [20:06:33] edsanders, so we can just add a mw.loader.load call under certain conditions on edit page load? [20:07:05] 10VisualEditor: after creating a link in VisualEditor, put the caret after the link - https://phabricator.wikimedia.org/T117408#1778837 (10Jdforrester-WMF) [20:07:07] 10VisualEditor, 10VisualEditor-ContentEditable, 10VisualEditor-EditingTools, 10VisualEditor-Links: On applying new link annotation, place cursor outside of the link - https://phabricator.wikimedia.org/T113082#1778839 (10Jdforrester-WMF) [20:08:44] 10VisualEditor, 10VisualEditor-EditingTools, 10VisualEditor-MediaWiki, 10VisualEditor-Tables: Editing tools interfere with informational flyouts - https://phabricator.wikimedia.org/T117387#1778854 (10Jdforrester-WMF) p:5Triage>3Normal [20:09:15] 10VisualEditor, 10VisualEditor-CopyPaste, 10VisualEditor-MediaWiki: Wikitext paste handler should be undoable - https://phabricator.wikimedia.org/T117376#1778862 (10Jdforrester-WMF) p:5Triage>3Low [20:10:06] 10VisualEditor: Unable to cancel VisualEditor **instantaneously** when I click on "edit" by accident - https://phabricator.wikimedia.org/T117359#1778871 (10Jdforrester-WMF) What browser aborts clicks with Escape? Mine doesn't. [20:10:16] 10VisualEditor: Unable to cancel VisualEditor **instantaneously** when I click on "edit" by accident - https://phabricator.wikimedia.org/T117359#1778873 (10Jdforrester-WMF) 5Open>3stalled p:5Triage>3Lowest [20:11:43] 10VisualEditor, 10VisualEditor-MediaWiki: Clicking on "Read" after enabling VisualEditor does not go to the original page - https://phabricator.wikimedia.org/T117360#1778877 (10Jdforrester-WMF) p:5Triage>3Low [20:12:28] 10VisualEditor, 7WorkType-Maintenance: Adding
tag into section headings - https://phabricator.wikimedia.org/T117169#1778879 (10Jdforrester-WMF) [20:12:30] 10VisualEditor, 10VisualEditor-ContentEditable: VisualEditor: Sometimes it's somehow possible for VE/Parsoid to insert a
at the start of a heading - https://phabricator.wikimedia.org/T53444#1778881 (10Jdforrester-WMF) [20:13:27] 10VisualEditor, 10VisualEditor-MediaWiki: Sometimes user-inserted ISBNs don't get converted to magic links somehow, meaning Parsoid has to nowiki them… - https://phabricator.wikimedia.org/T117165#1778887 (10Jdforrester-WMF) p:5Triage>3Normal [20:13:55] 10VisualEditor: Consider opening the link inspector/citation dialog after user clicks "Okay got it" on educational pop-up - https://phabricator.wikimedia.org/T117273#1778897 (10Jdforrester-WMF) Maybe. [20:14:12] 10VisualEditor, 10VisualEditor-MediaWiki: Consider opening the link inspector/citation dialog after user clicks "Okay got it" on educational pop-up - https://phabricator.wikimedia.org/T117273#1778899 (10Jdforrester-WMF) p:5Triage>3Low [20:14:58] 10TemplateData, 10VisualEditor: VisualEditor thinks there's no templatedata for my template with /doc subpage - https://phabricator.wikimedia.org/T117164#1778908 (10Jdforrester-WMF) 5Open>3stalled Did you do a null edit to make MW propagate it immediately? [20:15:36] 10VisualEditor, 10VisualEditor-MediaWiki: [Regression pre-wmf.5]Getting "Switch to Visual Editing?" dialog after saving a page and trying to re-open VE - https://phabricator.wikimedia.org/T117596#1778914 (10Jdforrester-WMF) p:5Triage>3High [20:18:29] 10VisualEditor: Recreating deleted page in VE gets "Error loading data from server: ve-api: Revision IDs ... do not match" - https://phabricator.wikimedia.org/T117163#1778925 (10Jdforrester-WMF) [20:19:15] 10VisualEditor, 7Performance: Large/big page can make the browser freeze - https://phabricator.wikimedia.org/T117053#1778929 (10Jdforrester-WMF) [20:19:17] 10VisualEditor, 10VisualEditor-Initialisation, 10VisualEditor-Performance, 7Browser-Support-Firefox, 7Performance: Improve VisualEditor's loading performance in Firefox - https://phabricator.wikimedia.org/T52616#1778931 (10Jdforrester-WMF) [20:19:29] 10VisualEditor, 10VisualEditor-MediaWiki, 5Patch-For-Review: Site subtitle lighter than title in edit mode - https://phabricator.wikimedia.org/T116755#1778933 (10Jdforrester-WMF) p:5Triage>3Low [20:20:35] 10VisualEditor, 10VisualEditor-MediaWiki: Provide a way for extensions embedding VE to turn off education popups - https://phabricator.wikimedia.org/T116659#1778942 (10Jdforrester-WMF) p:5Triage>3Low [20:21:19] 10VisualEditor, 10VisualEditor-MediaWiki, 10VisualEditor-MediaWiki-Links: VE redlink when link edited, but page exists - https://phabricator.wikimedia.org/T116651#1778945 (10Jdforrester-WMF) p:5Triage>3Low [20:22:40] 10VisualEditor, 10Parsoid:
in headers - https://phabricator.wikimedia.org/T116367#1778958 (10ssastry) [20:22:42] 10VisualEditor, 10VisualEditor-ContentEditable: VisualEditor: Sometimes it's somehow possible for VE/Parsoid to insert a
at the start of a heading - https://phabricator.wikimedia.org/T53444#1778960 (10ssastry) [20:31:20] (03CR) 10Alex Monk: [C: 032] VESwitchConfirmDialog: Set pending on the correct button [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/250722 (owner: 10Esanders) [20:32:38] 10VisualEditor: Unable to cancel VisualEditor **instantaneously** when I click on "edit" by accident - https://phabricator.wikimedia.org/T117359#1778996 (10He7d3r) Firefox 41.0.2, Google Chrome 46.0.2490.80 (64-bit) and Opera 33.0 (I tested all of them on Debian) [20:34:49] (03Merged) 10jenkins-bot: VESwitchConfirmDialog: Set pending on the correct button [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/250722 (owner: 10Esanders) [20:35:25] James_F, I guess we need to cherry-pick that as well? ^ [20:35:35] (03PS1) 10Jforrester: VESwitchConfirmDialog: Set pending on the correct button [extensions/VisualEditor] (wmf/1.27.0-wmf.5) - 10https://gerrit.wikimedia.org/r/250763 [20:35:41] Krenair: :-) [20:35:52] edsanders: Are you doing the switch button? Should Krenair? [20:36:06] I'll do them [20:36:14] ok [20:36:16] That and the education feature on it would be nice to do today, and push out immediately. [20:36:18] thanks [20:36:22] I guess I should write some copy. [20:36:35] (03CR) 10Esanders: [C: 032] VESwitchConfirmDialog: Use modes to hide 'keep' button [extensions/VisualEditor] (wmf/1.27.0-wmf.5) - 10https://gerrit.wikimedia.org/r/250747 (owner: 10Jforrester) [20:36:38] edsanders, so tell me about this factory idea for education popups? [20:37:16] you add popups to the factory [20:37:27] a popup is a separate OO.ui.Element [20:37:41] with a pointer to a tool [20:38:05] 10VisualEditor: Unable to cancel VisualEditor **instantaneously** when I click on "edit" by accident - https://phabricator.wikimedia.org/T117359#1779007 (10Jdforrester-WMF) 5stalled>3Open Aha, interesting, the link I tested must have been a JS one. "Real" link navigation does indeed get terminated by Escape.... [20:38:25] (like we point inspectors to certain DM nodes) [20:38:56] then when you build the toolbar, for each tool you search the registry for a popup which points to it [20:39:03] and attach any popups found [20:39:26] think I have another patch for cherry-picking, by the way [20:39:50] * James_F nods. [20:40:02] Krenair: Plus the config patch. And the new stuff not yet written. [20:40:39] sorry this has ended up being such a mess [20:40:51] (03Merged) 10jenkins-bot: VESwitchConfirmDialog: Use modes to hide 'keep' button [extensions/VisualEditor] (wmf/1.27.0-wmf.5) - 10https://gerrit.wikimedia.org/r/250747 (owner: 10Jforrester) [20:40:54] Eh, no worries. :_) [20:46:45] do have a ticket for the mobile education popup issue? [20:47:43] (03PS1) 10Alex Monk: Fix check for loading from modified action=edit [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/250765 (https://phabricator.wikimedia.org/T117596) [20:51:07] no [20:54:28] 10VisualEditor, 6Collaboration-Team-Backlog, 10Flow, 7Epic: Associate non-body content such as annotations and talk to a location in the article - https://phabricator.wikimedia.org/T89575#1779066 (10GWicke) [21:05:16] edsanders, so we can just add a mw.loader.load call under certain conditions on edit page load? [21:05:30] then the .using call should be done immediately [21:05:53] Krenair: I'll make one. [21:05:57] yeah [21:06:30] 10VisualEditor, 10VisualEditor-MediaWiki-Media, 10MediaWiki-General-or-Unknown, 6Multimedia: Show determinate progress bar for the image upload in mw.ForeignStructuredUpload.BookletLayout - https://phabricator.wikimedia.org/T115861#1779106 (10Esanders) While the thin progress bar does look smart - I think... [21:06:44] There. [21:06:44] 10VisualEditor, 10VisualEditor-MediaWiki: Education pop-ups work badly in mobile, in some cases being impossible to close - https://phabricator.wikimedia.org/T117603#1779109 (10Jdforrester-WMF) 3NEW a:3Krenair [21:07:14] 10VisualEditor, 10VisualEditor-MediaWiki: Education pop-ups work badly in mobile, in some cases being impossible to close - https://phabricator.wikimedia.org/T117603#1779121 (10Jdforrester-WMF) [21:07:46] In my experience you can close it, but when you do everything breaks [21:08:00] (i.e. everything else, except the closing process which works) [21:08:27] 10VisualEditor, 10VisualEditor-MediaWiki: Education pop-ups work badly in mobile, in some cases being impossible to close - https://phabricator.wikimedia.org/T117603#1779109 (10Jdforrester-WMF) [21:08:47] (03CR) 10Esanders: [C: 032] VESwitchConfirmDialog: Set pending on the correct button [extensions/VisualEditor] (wmf/1.27.0-wmf.5) - 10https://gerrit.wikimedia.org/r/250763 (owner: 10Jforrester) [21:09:16] Krenair: I couldn't close the keyboard to close it. [21:09:31] huh, ok [21:12:19] (03CR) 10Esanders: "recheck" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/250665 (owner: 10Esanders) [21:12:38] (03Merged) 10jenkins-bot: VESwitchConfirmDialog: Set pending on the correct button [extensions/VisualEditor] (wmf/1.27.0-wmf.5) - 10https://gerrit.wikimedia.org/r/250763 (owner: 10Jforrester) [21:12:40] edsanders: What's the status of https://gerrit.wikimedia.org/r/#/c/204871/1 and related patch? Does VE have a work around? [21:13:18] Krinkle: Yes, but let's not discuss today. [21:13:23] No - I think it's stalled [21:13:46] VE patch is https://gerrit.wikimedia.org/r/#/c/204509/ [21:15:03] yeah but we don't have a workaround for the problem [21:15:26] 10VisualEditor-LanguageTool, 6Editing-Department, 6Language-Engineering, 3Google-Summer-of-Code-2015, 7I18n: Unified language proofing tools integration framework - https://phabricator.wikimedia.org/T89107#1779166 (10Qgil) Was there any progress in October? Is the deployment to Wikimedia still planned? [21:16:32] (03CR) 10Esanders: "recheck" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/250032 (owner: 10Esanders) [21:19:46] OK. Let me know if/when there's something I can do to help. I'll leave it alone for now though. [21:19:55] Krinkle: Thanks. [21:20:50] Brion and saper were also making some improvements recently on gallery rendering with regards to videos and other stuff. could be intersting to see if somethign is salveable there. [21:20:59] salvageable [21:21:53] * James_F nods. [21:22:44] (03PS2) 10Alex Monk: Use mw.loader.using instead of weird hacks to load OOjs UI on action=edit [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/250719 [21:23:44] 10VisualEditor, 10Phlogiston, 15User-JAufrecht: Recently Closed report should be easier to read for last 1-3 weeks - https://phabricator.wikimedia.org/T117481#1779217 (10JAufrecht) [21:24:33] Krenair: mw.config.get( 'wgAction' ) === 'submit' || wikitextModified -> switching will only load VE on preview? [21:24:41] Or do I misunderstand? [21:24:54] s/load VE/load ability to switch to VE/ [21:25:08] This code determines whether we need to show the prompt or not. [21:25:21] If changes have been made or we're on action=submit, the prompt is shown. [21:25:33] Otherwise, assume we're discarding changes (there's nothing to keep) [21:26:00] Oh, right. [21:26:10] Yeah, that makes sense. Forgive me. [21:27:30] Assumption being that if you're on action=submit, you've probably made changes. [21:27:33] Yeah. [21:27:54] If you haven't, meh, it's no big problem. You just have to chose which option makes sense. [21:33:45] edsanders: For educational pop-out copy, I think "Switch to the visual editor. Powerful tools let you make changes quickly and easily without knowing the special markup." for the to-VE one, and "Switch to the source editor. Special markup lets you make complex changes not yet supported here." for the to-WT one. [21:33:57] edsanders: But if you have edits to that, go for it. :-) [21:34:11] (03CR) 10Jforrester: [C: 031] Use mw.loader.using instead of weird hacks to load OOjs UI on action=edit [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/250719 (owner: 10Alex Monk) [21:39:24] edsanders, so we need a way to catch the onSelect events still... should a ve.ui.MWTool be made, capable of having an attached education popup? [21:40:00] but then if we do that, what's the point in having a separate popup system? it can just default to no popups unless a subclass configures one? [21:41:11] (03PS3) 10Jforrester: AceEditorWidget: Add method to clear undo stack [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/250032 (owner: 10Esanders) [21:41:29] (03CR) 10Jforrester: [C: 032] AceEditorWidget: Add method to clear undo stack [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/250032 (owner: 10Esanders) [21:44:29] (03Merged) 10jenkins-bot: AceEditorWidget: Add method to clear undo stack [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/250032 (owner: 10Esanders) [21:46:42] (03PS1) 10Jforrester: Update OOjs UI to v0.13.1 [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/250834 [21:48:22] (03CR) 10Catrope: [C: 032] Update OOjs UI to v0.13.1 [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/250834 (owner: 10Jforrester) [22:03:11] wikiEditor still uses sprites :'/ [22:03:36] ...with background offsets hard coded in JS [22:05:14] 10VisualEditor, 10VisualEditor-MediaWiki: Education pop-ups work badly in mobile, in some cases being impossible to close - https://phabricator.wikimedia.org/T117603#1779577 (10Saidb) `**what for this . im new account**` [22:05:16] curse the TrevorParscal of 5 years ago [22:10:53] (03Merged) 10jenkins-bot: Update OOjs UI to v0.13.1 [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/250834 (owner: 10Jforrester) [22:24:08] edsanders: Yeah [22:24:14] edsanders: But our new button doesn't have to. [22:24:47] yeah - I'm going to hack it in [22:27:42] Cool. [22:30:20] (03CR) 10Alex Monk: Use mw.loader.using instead of weird hacks to load OOjs UI on action=edit (031 comment) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/250719 (owner: 10Alex Monk) [22:34:30] (03CR) 10Esanders: Use mw.loader.using instead of weird hacks to load OOjs UI on action=edit (031 comment) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/250719 (owner: 10Alex Monk) [22:40:06] edsanders, we also need ve.ui set... [22:40:31] what for? [22:40:54] the window factory? [22:41:07] aren't you attaching it to a different window manager anyway? [22:41:24] or the namespace? [22:41:28] so we can set ve.ui.MWVESwitchConfirmDialog [22:41:49] as it's part of init, you could put it in the ve.init namespace [22:42:12] and leave it out of the window manager [22:44:45] it isn't part of the VE UI, so I think that's fine - it's part of the pre-edit initialisation [22:48:41] TypeError: Cannot read property 'register' of undefined TypeError: Cannot read property 'register' of undefined [22:48:42] at mw.loader.implement.visualeditor-mweditmodesource-warning-cancel [22:48:43] what... [22:49:22] oh, because I tried to ve.init.windowFactory.register. oops. [22:52:06] still, mw.loader.implement.visualeditor-mweditmodesource-warning-cancel? wtf? [22:53:48] edsanders, so to put this in ve.init.mw we need to load ext.visualEditor.mediawiki [23:01:32] edsanders, we could just make it ve.init.MWVESwitchConfirmDialog I guess... [23:02:10] Krenair: That would work. [23:10:58] Krenair: What do we have left to pull into the SWAT? [23:13:54] (03PS3) 10Alex Monk: Use mw.loader.using instead of weird hacks to load OOjs UI on action=edit [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/250719 [23:13:59] https://gerrit.wikimedia.org/r/250712 https://gerrit.wikimedia.org/r/250719 https://gerrit.wikimedia.org/r/250765 and your cherry-picked stuff [23:14:14] (03CR) 10jenkins-bot: [V: 04-1] Use mw.loader.using instead of weird hacks to load OOjs UI on action=edit [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/250719 (owner: 10Alex Monk) [23:14:21] CI says no. :-) [23:15:09] https://gerrit.wikimedia.org/r/250745 needs merging into the wmf branch [23:15:42] (03CR) 10Jforrester: [C: 032] Unbreak loading of VE in the read page [extensions/VisualEditor] (wmf/1.27.0-wmf.5) - 10https://gerrit.wikimedia.org/r/250745 (owner: 10Jforrester) [23:16:26] "[wmf.5] TOCOME VisualEditor editor switching fixes back-port" [23:16:27] :-) [23:16:39] TOCOME? [23:17:36] Well, I've not made the pull-through MW core patch yet, for obvious reasons. [23:18:15] (03PS4) 10Alex Monk: Use mw.loader.using instead of weird hacks to load OOjs UI on action=edit [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/250719 [23:18:20] oh I see [23:19:15] (03Merged) 10jenkins-bot: Unbreak loading of VE in the read page [extensions/VisualEditor] (wmf/1.27.0-wmf.5) - 10https://gerrit.wikimedia.org/r/250745 (owner: 10Jforrester) [23:19:40] (03CR) 10Jforrester: [C: 031] Use mw.loader.using instead of weird hacks to load OOjs UI on action=edit [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/250719 (owner: 10Alex Monk) [23:19:57] 10VisualEditor: Write a scheduler singleton to execute code after some other code - https://phabricator.wikimedia.org/T117620#1779901 (10dchan) 3NEW a:3DLynch [23:20:52] Kemayo: Seems sane. [23:21:43] It's a path to perhaps someday being more consistently promise-y throughout. [23:21:56] * James_F nods. [23:22:29] 10VisualEditor, 10VisualEditor-ContentEditable, 7Technical-Debt: Review and document setTimeout usage - https://phabricator.wikimedia.org/T116237#1779929 (10dchan) [23:23:51] 10VisualEditor: Write a scheduler singleton to execute code after some other code - https://phabricator.wikimedia.org/T117620#1779901 (10dchan) [23:23:53] 10VisualEditor, 10VisualEditor-EditingTools, 5Patch-For-Review: [Regression wmf12] Uncaught Error: “Offset could not be translated to a DOM element and offset: 2” when selecting a heading format with language inspector open. - https://phabricator.wikimedia.org/T76717#1779948 (10dchan) [23:26:35] 10VisualEditor, 10VisualEditor-EditingTools, 5Patch-For-Review: [Regression wmf12] Uncaught Error: “Offset could not be translated to a DOM element and offset: 2” when selecting a heading format with language inspector open. - https://phabricator.wikimedia.org/T76717#1779961 (10dchan) @DLynch and I decided t... [23:26:36] (03CR) 10jenkins-bot: [V: 04-1] Use mw.loader.using instead of weird hacks to load OOjs UI on action=edit [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/250719 (owner: 10Alex Monk) [23:27:33] Krenair: Ha, jsduck. [23:27:50] 23:19:41 Warning: /mnt/jenkins-workspace/workspace/mwext-VisualEditor-jsduck/.jsduck/categories.json Class 've.init.MWVESwitchConfirmDialog' not found in categories file [23:27:58] Yeah. [23:28:11] We have ve.ui.*Dialog in jsduck's categories file, so new dialogs don't need registration. [23:28:17] But you moved it to ve.init, so… [23:28:17] * Krenair grumbles [23:28:20] (03CR) 10Divec: [C: 04-2] "@DLynch and I decided this should wait for the basic scheduler singleton (T117620 ), rather than further increasing the setTimeout complex" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/250646 (https://phabricator.wikimedia.org/T76717) (owner: 10DLynch) [23:29:17] (03PS5) 10Alex Monk: Use mw.loader.using instead of weird hacks to load OOjs UI on action=edit [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/250719 [23:32:36] (03CR) 10jenkins-bot: [V: 04-1] Use mw.loader.using instead of weird hacks to load OOjs UI on action=edit [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/250719 (owner: 10Alex Monk) [23:33:07] Krenair, do we event need .base? [23:33:30] *even need [23:34:11] edsanders, if we want to be able to use ve.init, yes [23:34:36] James_F, what's that failure? [23:34:55] Krenair, do we? [23:35:07] Krenair: You need to do a grunt run after changing the categories file. I'll fix. [23:35:34] it's just a namespace [23:36:02] I think we should do what we need to do to just load the one file [23:36:28] alex@alex-laptop:~/Development/MediaWiki/extensions/VisualEditor (ve-switch)$ grep "ve.init =" lib/ve/src/* -R [23:36:29] lib/ve/src/init/ve.init.js:ve.init = { [23:36:47] That script is part of ext.visualEditor.base. [23:36:54] Therefore we must depend on ext.visualEditor.base. [23:39:25] edsanders: How's the button stuff coming? [23:39:35] fine [23:39:59] Krenair, I don't think the namespace is necessary [23:40:15] just put it in MW or something [23:40:19] it's not really part of VE [23:40:37] (03PS6) 10Jforrester: Use mw.loader.using instead of weird hacks to load OOjs UI on action=edit [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/250719 (owner: 10Alex Monk) [23:42:10] edsanders, you want me to put this under mw.? [23:42:53] sure - why not [23:44:34] mw.ve.sorry [23:44:36] :-) [23:45:17] (03CR) 10jenkins-bot: [V: 04-1] Use mw.loader.using instead of weird hacks to load OOjs UI on action=edit [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/250719 (owner: 10Alex Monk) [23:46:03] I don't think it matters too much, as long as we aren't pre-loading a whole bunch of files unnecessarily just to initalize a namespace [23:47:26] we could do some reshuffling to get it in the ve namespace without loading extra files, but it's not really part of ve anyway, so mw is fine [23:48:01] I just remembered we had mw.libs.ve [23:49:28] I'll use that edsanders [23:49:48] Oh is this for the dialog that lets you decide how to switch from WT to VE? [23:49:56] yes [23:49:59] Right [23:51:06] Krenair: You have 10 minutes to get it into the SWAT… [23:51:14] (No pressure.) [23:52:07] (03PS7) 10Alex Monk: Use mw.loader.using instead of weird hacks to load OOjs UI on action=edit [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/250719 [23:52:34] Krenair: That will fail jsduck; [23:52:58] .jsduck/categories.json is a generated file. [23:53:10] You can't make changes directly to it. [23:53:53] There's mw-categories.json or whatever it's called [23:53:57] Yeah. [23:54:04] edsanders: ^^^ CR on that? [23:54:07] You make changes to that, then grunt builds them into the main categories.json file (along with VE core stuff) [23:54:36] (03CR) 10jenkins-bot: [V: 04-1] Use mw.loader.using instead of weird hacks to load OOjs UI on action=edit [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/250719 (owner: 10Alex Monk) [23:55:21] (03PS8) 10Alex Monk: Use mw.loader.using instead of weird hacks to load OOjs UI on action=edit [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/250719 [23:56:26] (03CR) 10Jforrester: [C: 031] Use mw.loader.using instead of weird hacks to load OOjs UI on action=edit [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/250719 (owner: 10Alex Monk) [23:57:39] edsanders: ^^ OK to +2? [23:59:04] Jenkins didn't -1 it. [23:59:11] Indeed. An improvement. :_)