[00:00:38] <grrrit-wm>	 (03CR) 10Jforrester: [C: 032] "Less bad." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/250719 (owner: 10Alex Monk)
[00:00:48] <grrrit-wm>	 (03PS1) 10Jforrester: Use mw.loader.using instead of weird hacks to load OOjs UI on action=edit [extensions/VisualEditor] (wmf/1.27.0-wmf.5) - 10https://gerrit.wikimedia.org/r/250865 
[00:00:53] <grrrit-wm>	 (03CR) 10Jforrester: [C: 032] Use mw.loader.using instead of weird hacks to load OOjs UI on action=edit [extensions/VisualEditor] (wmf/1.27.0-wmf.5) - 10https://gerrit.wikimedia.org/r/250865 (owner: 10Jforrester)
[00:05:14] <grrrit-wm>	 (03Merged) 10jenkins-bot: Use mw.loader.using instead of weird hacks to load OOjs UI on action=edit [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/250719 (owner: 10Alex Monk)
[00:05:16] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Use mw.loader.using instead of weird hacks to load OOjs UI on action=edit [extensions/VisualEditor] (wmf/1.27.0-wmf.5) - 10https://gerrit.wikimedia.org/r/250865 (owner: 10Jforrester)
[00:05:35] <grrrit-wm>	 (03CR) 10Jforrester: [C: 032] "…" [extensions/VisualEditor] (wmf/1.27.0-wmf.5) - 10https://gerrit.wikimedia.org/r/250865 (owner: 10Jforrester)
[00:06:02] <wikibugs>	 10TemplateData, 6Community-Liaison, 7Documentation, 7Easy, 3Google-Code-In-2015: Check documentation for the TemplateData editor for completeness, accuracy, and ease of understanding by adding TemplateData to templates on Wikipedia - https://phabricator.wikimedia.org/T117499#1780230 (10SalixAlba) I've no...
[00:07:17] <wikibugs>	 10VisualEditor: On mw.org after clicking on pulsating dot , the pulse goes away not the dot - https://phabricator.wikimedia.org/T117627#1780234 (10Ryasmeen) 3NEW
[00:08:57] <grrrit-wm>	 (03Merged) 10jenkins-bot: Use mw.loader.using instead of weird hacks to load OOjs UI on action=edit [extensions/VisualEditor] (wmf/1.27.0-wmf.5) - 10https://gerrit.wikimedia.org/r/250865 (owner: 10Jforrester)
[00:11:16] <wikibugs>	 10VisualEditor: [Regression wmf.5] On mw.org after clicking on pulsating dot for the educational pop-up , the pulse goes away but not the dot - https://phabricator.wikimedia.org/T117627#1780254 (10Ryasmeen)
[00:16:27] <wikibugs>	 10VisualEditor: Blue highlight shield goes over the educational pop-up - https://phabricator.wikimedia.org/T117629#1780266 (10Ryasmeen) 3NEW
[00:18:27] <grrrit-wm>	 (03PS2) 10Jforrester: Fix check for loading from modified action=edit [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/250765 (https://phabricator.wikimedia.org/T117596) (owner: 10Alex Monk)
[00:19:31] <grrrit-wm>	 (03PS3) 10Jforrester: Fix check for loading from modified action=edit [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/250765 (https://phabricator.wikimedia.org/T117596) (owner: 10Alex Monk)
[00:20:11] <grrrit-wm>	 (03CR) 10Jforrester: [C: 031] "PS2 is a manual rebase (and PS3 fixing an accidental backspace)." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/250765 (https://phabricator.wikimedia.org/T117596) (owner: 10Alex Monk)
[00:20:52] <wikibugs>	 10VisualEditor: [Regression wmf.5] On Beta cluster and on mw.org after clicking on pulsating dot for the educational pop-up , the pulse goes away but not the dot - https://phabricator.wikimedia.org/T117627#1780292 (10Ryasmeen)
[00:21:11] <wikibugs>	 10VisualEditor: [Regression wmf.5] On Beta cluster and on mw.org after clicking on pulsating dot for the educational pop-up , the pulse goes away but not the dot - https://phabricator.wikimedia.org/T117627#1780234 (10Ryasmeen) Also getting it on Beta cluster now
[00:22:06] <wikibugs>	 10VisualEditor: Blue highlight shield goes over the educational pop-up - https://phabricator.wikimedia.org/T117629#1780297 (10matmarex) See also T116577.
[00:25:38] <wikibugs>	 10VisualEditor: The pulse is not aligned properly for pulsating dot for educational pop-up - https://phabricator.wikimedia.org/T117633#1780310 (10Ryasmeen) 3NEW
[00:33:25] <wikibugs>	 10VisualEditor: [Regression wmf.5] After opening one of the educational pop-ups, the pulsating dot disappears from other educational pop up too - https://phabricator.wikimedia.org/T117638#1780357 (10Ryasmeen) 3NEW
[00:34:15] <Krenair>	 oh, we were supposed to get https://gerrit.wikimedia.org/r/250765 into swat
[00:34:38] <wikibugs>	 10VisualEditor, 10VisualEditor-MediaWiki: Educational popups overlap with toolbar dialogs, selection highlights - https://phabricator.wikimedia.org/T116577#1780364 (10Jdforrester-WMF)
[00:34:53] <wikibugs>	 10VisualEditor, 10VisualEditor-MediaWiki: Educational popups overlap with toolbar dialogs, selection highlights - https://phabricator.wikimedia.org/T116577#1780367 (10Jdforrester-WMF)
[00:35:06] <wikibugs>	 10VisualEditor, 10VisualEditor-MediaWiki: Educational popups overlap with toolbar dialogs, selection highlights - https://phabricator.wikimedia.org/T116577#1780368 (10Jdforrester-WMF) p:5Triage>3Normal
[00:35:47] <grrrit-wm>	 (03CR) 10Jforrester: [C: 032] Fix check for loading from modified action=edit [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/250765 (https://phabricator.wikimedia.org/T117596) (owner: 10Alex Monk)
[00:35:49] <James_F>	 Krenair: Let's just do it.
[00:35:58] <grrrit-wm>	 (03PS1) 10Jforrester: Fix check for loading from modified action=edit [extensions/VisualEditor] (wmf/1.27.0-wmf.5) - 10https://gerrit.wikimedia.org/r/250872 (https://phabricator.wikimedia.org/T117596) 
[00:36:26] <grrrit-wm>	 (03CR) 10Alex Monk: [C: 032] Fix check for loading from modified action=edit [extensions/VisualEditor] (wmf/1.27.0-wmf.5) - 10https://gerrit.wikimedia.org/r/250872 (https://phabricator.wikimedia.org/T117596) (owner: 10Jforrester)
[00:39:04] <grrrit-wm>	 (03Merged) 10jenkins-bot: Fix check for loading from modified action=edit [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/250765 (https://phabricator.wikimedia.org/T117596) (owner: 10Alex Monk)
[00:41:13] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Fix check for loading from modified action=edit [extensions/VisualEditor] (wmf/1.27.0-wmf.5) - 10https://gerrit.wikimedia.org/r/250872 (https://phabricator.wikimedia.org/T117596) (owner: 10Jforrester)
[00:42:14] <grrrit-wm>	 (03CR) 10Alex Monk: [V: 032] Fix check for loading from modified action=edit [extensions/VisualEditor] (wmf/1.27.0-wmf.5) - 10https://gerrit.wikimedia.org/r/250872 (https://phabricator.wikimedia.org/T117596) (owner: 10Jforrester)
[00:47:30] <wikibugs>	 10VisualEditor, 10VisualEditor-MediaWiki, 5WMF-deploy-2015-11-03_(1.27.0-wmf.5), 5WMF-deploy-2015-11-10_(1.27.0-wmf.6): [Regression wmf.5] Getting "Switch to Visual Editing?" dialog after saving a page and trying to re-open VE - https://phabricator.wikimedia.org/T117596#1780408 (10Jdforrester-WMF) 5Open>...
[00:57:05] <wikibugs>	 10VisualEditor, 10VisualEditor-MediaWiki: [Regression wmf.5] On Beta cluster and on mw.org after clicking on pulsating dot for the educational pop-up , the pulse goes away but not the dot - https://phabricator.wikimedia.org/T117627#1780433 (10Jdforrester-WMF) p:5Triage>3Low
[00:57:10] <wikibugs>	 10VisualEditor, 10VisualEditor-MediaWiki: [Regression wmf.5] On Beta cluster and on mw.org after clicking on pulsating dot for the educational pop-up , the pulse goes away but not the dot - https://phabricator.wikimedia.org/T117627#1780234 (10Jdforrester-WMF)
[01:03:43] <wikibugs>	 10VisualEditor: The text "Editing" is appearing before the article title  when I switch to VisualEditor and it also stays after saving the page - https://phabricator.wikimedia.org/T117643#1780474 (10Ryasmeen) 3NEW
[01:04:05] <wikibugs>	 10VisualEditor: [Regression wmf.5] The text "Editing" is appearing before the article title  when I switch to VisualEditor and it also stays after saving the page - https://phabricator.wikimedia.org/T117643#1780485 (10Ryasmeen)
[01:04:30] <wikibugs>	 10VisualEditor, 10VisualEditor-MediaWiki: [Regression wmf.5] The text "Editing" is appearing before the article title  when I switch to VisualEditor and it also stays after saving the page - https://phabricator.wikimedia.org/T117643#1780487 (10Jdforrester-WMF) p:5Triage>3Normal
[01:05:53] <wikibugs>	 10VisualEditor, 10VisualEditor-MediaWiki, 5WMF-deploy-2015-11-03_(1.27.0-wmf.5), 5WMF-deploy-2015-11-10_(1.27.0-wmf.6): [Regression wmf.5] Getting "Switch to Visual Editing?" dialog after saving a page and trying to re-open VE - https://phabricator.wikimedia.org/T117596#1780493 (10Ryasmeen) 5Resolved>3O...
[01:12:26] <wikibugs>	 10VisualEditor, 10VisualEditor-MediaWiki, 5WMF-deploy-2015-11-03_(1.27.0-wmf.5), 5WMF-deploy-2015-11-10_(1.27.0-wmf.6): [Regression wmf.5] Getting "Switch to Visual Editing?" dialog after saving a page and trying to re-open VE - https://phabricator.wikimedia.org/T117596#1780510 (10Krenair) 5Open>3Resolv...
[01:19:55] <grrrit-wm>	 (03PS1) 10DLynch: [BREAKING CHANGE] Create CommandHelpRegistry for CommandHelpDialog [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/250881 
[01:20:05] <James_F>	 Krenair: Hmm, I can still reproduce T117596 on MW.org with debug=true…
[01:20:37] <Krenair>	 but not without debug=true?
[01:21:27] <James_F>	 Sorry, with both.
[01:21:34] <James_F>	 VE -> WT -> VE, save; load VE.
[01:22:48] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] [BREAKING CHANGE] Create CommandHelpRegistry for CommandHelpDialog [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/250881 (owner: 10DLynch)
[01:23:00] <wikibugs>	 10VisualEditor, 10VisualEditor-MediaWiki: The pulse is not aligned properly for pulsating dot for educational pop-up - https://phabricator.wikimedia.org/T117633#1780537 (10Jdforrester-WMF) p:5Triage>3Lowest
[01:23:40] <wikibugs>	 10VisualEditor, 10VisualEditor-MediaWiki-Templates, 6Language-Engineering, 7I18n: Message cache broken for visualeditor-dialog-transclusion-no-template-description - https://phabricator.wikimedia.org/T117145#1780541 (10Jdforrester-WMF)
[01:26:05] <James_F>	 Kemayo: All those errors from one missing ';'. :_)
[01:26:14] <Krenair>	 James_F, I just noticed you can't create a page in VE on mw.o
[01:28:26] <grrrit-wm>	 (03PS2) 10DLynch: [BREAKING CHANGE] Create CommandHelpRegistry for CommandHelpDialog [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/250881 
[01:28:43] <Kemayo>	 Missing comma, actually. :D
[01:32:45] <wikibugs>	 10VisualEditor, 10VisualEditor-MediaWiki, 5WMF-deploy-2015-11-03_(1.27.0-wmf.5), 5WMF-deploy-2015-11-10_(1.27.0-wmf.6): [Regression wmf.5] Getting "Switch to Visual Editing?" dialog after saving a page and trying to re-open VE - https://phabricator.wikimedia.org/T117596#1780561 (10Krenair) James found a mo...
[01:35:15] <wikibugs>	 10VisualEditor, 10VisualEditor-MediaWiki, 5WMF-deploy-2015-11-03_(1.27.0-wmf.5), 5WMF-deploy-2015-11-10_(1.27.0-wmf.6): [Regression wmf.5] Getting "Switch to Visual Editing?" dialog after saving a page and trying to re-open VE - https://phabricator.wikimedia.org/T117596#1780572 (10Krenair) We should also c...
[01:47:29] <wikibugs>	 10VisualEditor, 10VisualEditor-MediaWiki, 5WMF-deploy-2015-11-03_(1.27.0-wmf.5), 5WMF-deploy-2015-11-10_(1.27.0-wmf.6): [Regression wmf.5] Getting "Switch to Visual Editing?" dialog after saving a page and trying to re-open VE - https://phabricator.wikimedia.org/T117596#1780605 (10Krenair) 5Resolved>3Op...
[01:47:35] <grrrit-wm>	 (03PS1) 10Alex Monk: Set wgAction when messing with the action URL parameter [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/250892 (https://phabricator.wikimedia.org/T117596) 
[01:52:34] <wikibugs>	 10VisualEditor: VE adds span tags with lang and dir attributes - https://phabricator.wikimedia.org/T116887#1780612 (10Whatamidoing-WMF) @Magioladitis:  This feature provides good HTML markup and prevents problems when different scripts are combined.  It may be helpful to some readers if they are reading in Engli...
[02:17:49] <wikibugs>	 10VisualEditor, 10OOjs-UI, 6WMF-Design, 7Design, 5Patch-For-Review: Use progressive for selected states in OOUI - https://phabricator.wikimedia.org/T107953#1780665 (10Prtksxna) 5Open>3stalled
[02:18:08] <wikibugs>	 10VisualEditor, 10OOjs-UI, 6WMF-Design, 7Design, 5Patch-For-Review: Use progressive for selected states in OOUI - https://phabricator.wikimedia.org/T107953#1508192 (10Prtksxna)
[02:55:58] <grrrit-wm>	 (03CR) 10Jforrester: [C: 031] Set wgAction when messing with the action URL parameter [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/250892 (https://phabricator.wikimedia.org/T117596) (owner: 10Alex Monk)
[03:35:30] <grrrit-wm>	 (03PS3) 10DLynch: [BREAKING CHANGE] Create CommandHelpRegistry for CommandHelpDialog [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/250881 
[04:14:39] <wikibugs>	 10VisualEditor, 10Graph-VisualEditor, 5Patch-For-Review: Basic UI for bar chart editing - https://phabricator.wikimedia.org/T100353#1780749 (10ferdbold) This is kinda unclear now, as this task was made way back at the start of GSoC when my proposal got accepted. I'm unsure now this represents now a distinct...
[04:20:46] <grrrit-wm>	 (03PS1) 10DLynch: Add ve.Scheduler, use it to avoid conflict in ve.ui.Tool [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/250904 (https://phabricator.wikimedia.org/T117620) 
[04:23:54] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Add ve.Scheduler, use it to avoid conflict in ve.ui.Tool [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/250904 (https://phabricator.wikimedia.org/T117620) (owner: 10DLynch)
[04:26:23] <grrrit-wm>	 (03PS2) 10DLynch: Add ve.Scheduler, use it to avoid conflict in ve.ui.Tool [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/250904 (https://phabricator.wikimedia.org/T117620) 
[04:26:38] <Kemayo>	 One of these days I'm going to remember that grunt lint doesn't check whether the docs build.
[04:26:46] <Kemayo>	 (I am lying.)
[04:31:37] <wikibugs>	 10VisualEditor, 10VisualEditor-MediaWiki-Media, 6Multimedia: In the upload dialog, pre-populate date information from the file's EXIF data - https://phabricator.wikimedia.org/T117547#1780771 (10Babygirl.md7565)
[04:35:52] <wikibugs>	 10VisualEditor, 10VisualEditor-MediaWiki-Media, 6Multimedia: In the upload dialog, pre-populate date information from the file's EXIF data - https://phabricator.wikimedia.org/T117547#1780780 (10greg)
[04:54:31] <wikibugs>	 10VisualEditor-LanguageTool, 6Editing-Department, 6Language-Engineering, 7I18n: Unified language proofing tools integration framework - https://phabricator.wikimedia.org/T89107#1780810 (10Ankita-ks) There has not been any progress in October. I haven't been able to find time. The work is still stuck at set...
[07:11:59] <grrrit-wm>	 (03CR) 10Divec: [C: 04-1] "This is great stuff - I'm very excited about it." (033 comments) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/250904 (https://phabricator.wikimedia.org/T117620) (owner: 10DLynch)
[07:22:32] <grrrit-wm>	 (03CR) 10Divec: Add ve.Scheduler, use it to avoid conflict in ve.ui.Tool (032 comments) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/250904 (https://phabricator.wikimedia.org/T117620) (owner: 10DLynch)
[08:43:11] <grrrit-wm>	 (03CR) 10DLynch: Add ve.Scheduler, use it to avoid conflict in ve.ui.Tool (032 comments) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/250904 (https://phabricator.wikimedia.org/T117620) (owner: 10DLynch)
[09:13:36] <wikibugs>	 10VisualEditor, 10MediaWiki-History-or-Diffs, 10MediaWiki-Page-editing: Say "Your edit has been saved" instead of "The page has been restored" - https://phabricator.wikimedia.org/T117662#1781022 (10Nnemo) 3NEW
[09:15:26] <grrrit-wm>	 (03PS5) 10Divec: WIP: Build model transactions from richtext DOM diff [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/249077 
[09:19:07] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] WIP: Build model transactions from richtext DOM diff [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/249077 (owner: 10Divec)
[09:33:01] <grrrit-wm>	 (03PS3) 10DLynch: Add ve.Scheduler, use it to avoid conflict in ve.ui.Tool [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/250904 (https://phabricator.wikimedia.org/T117620) 
[09:41:30] <wikibugs>	 10VisualEditor, 10MediaWiki-History-or-Diffs, 10MediaWiki-Page-editing: Say "Your edit has been saved" instead of "The page has been restored" - https://phabricator.wikimedia.org/T117662#1781067 (10Aklapper)
[10:13:09] <grrrit-wm>	 (03PS1) 10Esanders: Target init: Add edit mode switch icons to VE and WE toolbars [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/250939 (https://phabricator.wikimedia.org/T49779) 
[10:15:15] <wikibugs>	 10VisualEditor, 10VisualEditor-MediaWiki, 10WikiEditor, 10RESTBase, and 4 others: Provide a way for the user to switch between VisualEditor and wikitext source editor modes without saving - https://phabricator.wikimedia.org/T49779#1781155 (10Esanders) More prominent VE switcher: {F2913511}  WikiEditor swit...
[11:56:55] <grrrit-wm>	 (03CR) 10Esanders: [C: 032] [BREAKING CHANGE] Create CommandHelpRegistry for CommandHelpDialog [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/250881 (owner: 10DLynch)
[11:59:07] <grrrit-wm>	 (03CR) 10Esanders: Add ve.Scheduler, use it to avoid conflict in ve.ui.Tool (031 comment) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/250904 (https://phabricator.wikimedia.org/T117620) (owner: 10DLynch)
[12:00:05] <grrrit-wm>	 (03Merged) 10jenkins-bot: [BREAKING CHANGE] Create CommandHelpRegistry for CommandHelpDialog [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/250881 (owner: 10DLynch)
[12:09:57] <grrrit-wm>	 (03PS2) 10Esanders: Target init: Add edit mode switch icons to VE and WE toolbars [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/250939 (https://phabricator.wikimedia.org/T49779) 
[12:09:59] <grrrit-wm>	 (03PS1) 10Esanders: Source icon: Use double brakcets [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/250952 (https://phabricator.wikimedia.org/T111038) 
[13:49:07] <James_F>	 edsanders|away, Kemayo: Is "[BREAKING CHANGE] Create CommandHelpRegistry for CommandHelpDialog" sufficiently breaking that it needs a pull-through for VE-MW?
[13:54:32] <grrrit-wm>	 (03CR) 10Jforrester: [C: 04-1] "Looks great, but…" (031 comment) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/250939 (https://phabricator.wikimedia.org/T49779) (owner: 10Esanders)
[13:55:32] <grrrit-wm>	 (03CR) 10Jforrester: Target init: Add edit mode switch icons to VE and WE toolbars (031 comment) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/250939 (https://phabricator.wikimedia.org/T49779) (owner: 10Esanders)
[13:58:57] <grrrit-wm>	 (03CR) 10Jforrester: [C: 032] Set wgAction when messing with the action URL parameter [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/250892 (https://phabricator.wikimedia.org/T117596) (owner: 10Alex Monk)
[14:00:07] <grrrit-wm>	 (03PS1) 10Esanders: Slugs: Remove vertical alignment hack [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/250958 
[14:01:11] <wikibugs>	 10VisualEditor: "Error loading data from server: ve-api..." when creating a new page with VisualEditor - https://phabricator.wikimedia.org/T117697#1781685 (10Qgil) 3NEW
[14:05:33] <grrrit-wm>	 (03CR) 10Jforrester: [C: 031] "Or we could remove this downstream?" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/250958 (owner: 10Esanders)
[14:07:21] <grrrit-wm>	 (03CR) 10Esanders: Target init: Add edit mode switch icons to VE and WE toolbars (032 comments) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/250939 (https://phabricator.wikimedia.org/T49779) (owner: 10Esanders)
[14:08:29] <grrrit-wm>	 (03PS2) 10Esanders: Source icon: Use double brakcets [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/250952 (https://phabricator.wikimedia.org/T111038) 
[14:08:31] <grrrit-wm>	 (03PS3) 10Esanders: Target init: Add edit mode switch icons to VE and WE toolbars [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/250939 (https://phabricator.wikimedia.org/T49779) 
[14:09:01] <grrrit-wm>	 (03CR) 10Jforrester: [C: 032] Target init: Add edit mode switch icons to VE and WE toolbars [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/250939 (https://phabricator.wikimedia.org/T49779) (owner: 10Esanders)
[14:09:31] <grrrit-wm>	 (03CR) 10Jforrester: [C: 032] Source icon: Use double brakcets [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/250952 (https://phabricator.wikimedia.org/T111038) (owner: 10Esanders)
[14:11:54] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Target init: Add edit mode switch icons to VE and WE toolbars [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/250939 (https://phabricator.wikimedia.org/T49779) (owner: 10Esanders)
[14:12:40] <edsanders>	 I think it would break the help dialog
[14:12:42] <edsanders>	 I haven't seen the pull through code yet
[14:12:57] <edsanders>	 I don't imagine it's a big commit though
[14:12:58] <edsanders>	 Kemayo, ?
[14:13:57] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Source icon: Use double brakcets [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/250952 (https://phabricator.wikimedia.org/T111038) (owner: 10Esanders)
[14:14:47] <grrrit-wm>	 (03Merged) 10jenkins-bot: Set wgAction when messing with the action URL parameter [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/250892 (https://phabricator.wikimedia.org/T117596) (owner: 10Alex Monk)
[14:14:51] <grrrit-wm>	 (03Merged) 10jenkins-bot: Target init: Add edit mode switch icons to VE and WE toolbars [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/250939 (https://phabricator.wikimedia.org/T49779) (owner: 10Esanders)
[14:14:54] <grrrit-wm>	 (03Merged) 10jenkins-bot: Source icon: Use double brakcets [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/250952 (https://phabricator.wikimedia.org/T111038) (owner: 10Esanders)
[14:15:56] <grrrit-wm>	 (03PS1) 10Jforrester: Replace 'source' icon with OOUI's 'wikiText' one [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/250962 
[14:16:15] <grrrit-wm>	 (03PS1) 10Jforrester: Set wgAction when messing with the action URL parameter [extensions/VisualEditor] (wmf/1.27.0-wmf.5) - 10https://gerrit.wikimedia.org/r/250963 (https://phabricator.wikimedia.org/T117596) 
[14:16:30] <grrrit-wm>	 (03PS1) 10Jforrester: Source icon: Use double brakcets [extensions/VisualEditor] (wmf/1.27.0-wmf.5) - 10https://gerrit.wikimedia.org/r/250964 (https://phabricator.wikimedia.org/T111038) 
[14:17:26] <wikibugs>	 10VisualEditor, 10VisualEditor-MediaWiki, 7Design, 7Epic: Provide a single edit tab which has both visual and wikitext modes and allows on-the-fly switching between them - https://phabricator.wikimedia.org/T102398#1781717 (10Jdforrester-WMF)
[14:17:29] <wikibugs>	 10VisualEditor, 10VisualEditor-MediaWiki, 10WikiEditor, 10RESTBase, and 4 others: Provide a way for the user to switch between VisualEditor and wikitext source editor modes without saving - https://phabricator.wikimedia.org/T49779#1781715 (10Jdforrester-WMF) 5Open>3Resolved a:3Jdforrester-WMF
[14:19:55] <grrrit-wm>	 (03PS1) 10Jforrester: Target init: Add edit mode switch icons to VE and WE toolbars [extensions/VisualEditor] (wmf/1.27.0-wmf.5) - 10https://gerrit.wikimedia.org/r/250965 (https://phabricator.wikimedia.org/T49779) 
[14:20:05] <wikibugs>	 10Citoid: Consider adding a "file bug" button to citoid - https://phabricator.wikimedia.org/T95827#1781720 (10Mvolz) 5stalled>3declined
[14:22:49] <wikibugs>	 10VisualEditor, 10VisualEditor-MediaWiki-References: Come up with a better way to auto-label references - https://phabricator.wikimedia.org/T92432#1781739 (10Anomie) Another reason to fix this bug: If people are copying wikitext between articles (which happens often enough that enwiki has a bot to look for it)...
[14:23:00] <wikibugs>	 10VisualEditor, 10MediaWiki-History-or-Diffs, 10MediaWiki-Page-editing: Say "Your edit has been saved" instead of "The page has been restored" - https://phabricator.wikimedia.org/T117662#1781741 (10Jdforrester-WMF) The introduction of a different text was explicitly requested, because if you're undoing someo...
[14:24:25] <grrrit-wm>	 (03CR) 10Jforrester: [C: 032] Set wgAction when messing with the action URL parameter [extensions/VisualEditor] (wmf/1.27.0-wmf.5) - 10https://gerrit.wikimedia.org/r/250963 (https://phabricator.wikimedia.org/T117596) (owner: 10Jforrester)
[14:24:35] <grrrit-wm>	 (03CR) 10Jforrester: [C: 032] Source icon: Use double brakcets [extensions/VisualEditor] (wmf/1.27.0-wmf.5) - 10https://gerrit.wikimedia.org/r/250964 (https://phabricator.wikimedia.org/T111038) (owner: 10Jforrester)
[14:24:55] <grrrit-wm>	 (03CR) 10Jforrester: [C: 032] Target init: Add edit mode switch icons to VE and WE toolbars [extensions/VisualEditor] (wmf/1.27.0-wmf.5) - 10https://gerrit.wikimedia.org/r/250965 (https://phabricator.wikimedia.org/T49779) (owner: 10Jforrester)
[14:25:24] <grrrit-wm>	 (03CR) 10Jforrester: "Probably worth waiting on Ia84f0594 to land in OOUI first?" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/250962 (owner: 10Jforrester)
[14:27:59] <wikibugs>	 10VisualEditor: "Error loading data from server: ve-api..." when creating a new page with VisualEditor - https://phabricator.wikimedia.org/T117697#1781750 (10Aklapper) Reminds me of T39843. https://www.mediawiki.org/wiki/ThisIsATestEtcEtcEtc?debug=true&veaction=edit does not even finish loading. Meh.  ``` GET  X...
[14:36:11] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Set wgAction when messing with the action URL parameter [extensions/VisualEditor] (wmf/1.27.0-wmf.5) - 10https://gerrit.wikimedia.org/r/250963 (https://phabricator.wikimedia.org/T117596) (owner: 10Jforrester)
[14:36:18] <James_F>	 Meh.
[14:36:30] <grrrit-wm>	 (03CR) 10Jforrester: [C: 032] Set wgAction when messing with the action URL parameter [extensions/VisualEditor] (wmf/1.27.0-wmf.5) - 10https://gerrit.wikimedia.org/r/250963 (https://phabricator.wikimedia.org/T117596) (owner: 10Jforrester)
[14:38:45] <grrrit-wm>	 (03Merged) 10jenkins-bot: Source icon: Use double brakcets [extensions/VisualEditor] (wmf/1.27.0-wmf.5) - 10https://gerrit.wikimedia.org/r/250964 (https://phabricator.wikimedia.org/T111038) (owner: 10Jforrester)
[14:40:58] <grrrit-wm>	 (03Merged) 10jenkins-bot: Target init: Add edit mode switch icons to VE and WE toolbars [extensions/VisualEditor] (wmf/1.27.0-wmf.5) - 10https://gerrit.wikimedia.org/r/250965 (https://phabricator.wikimedia.org/T49779) (owner: 10Jforrester)
[14:42:33] <wikibugs>	 10VisualEditor, 10VisualEditor-MediaWiki, 5Patch-For-Review, 5WMF-deploy-2015-11-03_(1.27.0-wmf.5), 5WMF-deploy-2015-11-10_(1.27.0-wmf.6): [Regression wmf.5] Getting "Switch to Visual Editing?" dialog after saving a page and trying to re-open VE - https://phabricator.wikimedia.org/T117596#1781785 (10Jdfor...
[14:50:47] <James_F>	 edsanders: So… single edit tab stuff. Also, did you reply to K.renair's questions about popup factories?
[14:51:01] <edsanders>	 I replied in IRC
[14:51:13] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Set wgAction when messing with the action URL parameter [extensions/VisualEditor] (wmf/1.27.0-wmf.5) - 10https://gerrit.wikimedia.org/r/250963 (https://phabricator.wikimedia.org/T117596) (owner: 10Jforrester)
[14:51:24] <James_F>	 I didn't see them?
[14:51:29] <James_F>	 Argh.
[14:51:35] <James_F>	 Bugger this.
[14:51:41] <grrrit-wm>	 (03CR) 10Jforrester: [V: 032] Set wgAction when messing with the action URL parameter [extensions/VisualEditor] (wmf/1.27.0-wmf.5) - 10https://gerrit.wikimedia.org/r/250963 (https://phabricator.wikimedia.org/T117596) (owner: 10Jforrester)
[14:52:11] <edsanders>	 <Krenair> edsanders, so tell me about this factory idea for education popups?
[14:52:11] <edsanders>	 <edsanders> you add popups to the factory
[14:52:11] <edsanders>	 <edsanders> a popup is a separate OO.ui.Element
[14:52:11] <edsanders>	 <edsanders> with a pointer to a tool
[14:52:11] <edsanders>	 <edsanders> (like we point inspectors to certain DM nodes)
[14:52:13] <edsanders>	 <edsanders> then when you build the toolbar, for each tool you search the registry for a popup which points to it
[14:52:16] <edsanders>	 <edsanders> and attach any popups found
[14:52:18] <edsanders>	 <Krenair> think I have another patch for cherry-picking, by the way
[14:52:20] <edsanders>	 * James_F nods.
[14:52:45] <James_F>	 I meant the follow-ups
[14:52:46] <James_F>	 "<Krenair> edsanders, so we need a way to catch the onSelect events still... should a ve.ui.MWTool be made, capable of having an attached education popup?"
[14:52:58] <James_F>	 "<Krenair> but then if we do that, what's the point in having a separate popup system? it can just default to no popups unless a subclass configures one?"
[14:53:15] <James_F>	 Yes?
[14:53:39] <wikibugs>	 10VisualEditor, 10VisualEditor-MediaWiki-Media, 6Multimedia: In the upload dialog, pre-populate date information from the file's EXIF data - https://phabricator.wikimedia.org/T117547#1781836 (10Esanders)
[14:54:09] <wikibugs>	 10VisualEditor, 10VisualEditor-MediaWiki-Media, 6Multimedia: In the upload dialog, pre-populate date information from the file's EXIF data - https://phabricator.wikimedia.org/T117547#1781839 (10Jdforrester-WMF)
[14:55:09] <grrrit-wm>	 (03CR) 10Esanders: Source icon: Use double brakcets (031 comment) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/250952 (https://phabricator.wikimedia.org/T111038) (owner: 10Esanders)
[14:55:24] <James_F>	 edsanders: :-)
[14:56:04] * edsanders needs CI spellchecking
[15:13:16] <grrrit-wm>	 (03PS1) 10Esanders: Icons: Remove 'source' icon in favour of identical OOUI 'wikiText' icon [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/250972 (https://phabricator.wikimedia.org/T111038) 
[15:21:21] <edsanders>	 Krenair, I think we have two options
[15:21:29] <Krenair>	 ok
[15:21:37] <edsanders>	 one is that we intercept events using CSS, depending on what interaction we want
[15:21:50] <edsanders>	 that might be hover, hover for some time, or click
[15:22:36] <edsanders>	 that sticks with the model that these poups are just being attached over tools
[15:23:46] <edsanders>	 the tools are already position:relative, so you just make the popup position:absolute;top:0;right:0;bottom:0;left:0;
[15:24:42] <edsanders>	 the tool will then be unusable until the popup is dismissed
[15:25:28] <edsanders>	 the other option is to hook into onSelect like you say - so you'd have to add some code to ve.ui.Tool#onSelect which feels less clean
[15:32:53] <grrrit-wm>	 (03PS1) 10Alex Monk: Unbreak 404 handling code [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/250974 (https://phabricator.wikimedia.org/T117697) 
[15:45:34] <Krenair>	 James_F, ^  probably another thing to get in before swat
[15:57:19] <grrrit-wm>	 (03PS1) 10Alex Monk: Apply same hide/show logic to both education popup dots [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/250980 (https://phabricator.wikimedia.org/T117627) 
[16:01:47] * James_F nods.
[16:01:59] <grrrit-wm>	 (03CR) 10Jforrester: [C: 032] Unbreak 404 handling code [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/250974 (https://phabricator.wikimedia.org/T117697) (owner: 10Alex Monk)
[16:02:12] <wikibugs>	 10VisualEditor, 10VisualEditor-MediaWiki, 5Patch-For-Review: [Regression wmf.5] On Beta cluster and on mw.org after clicking on pulsating dot for the educational pop-up , the pulse goes away but not the dot - https://phabricator.wikimedia.org/T117627#1782009 (10Krenair) a:3Krenair
[16:02:20] <grrrit-wm>	 (03CR) 10Jforrester: [C: 032] Apply same hide/show logic to both education popup dots [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/250980 (https://phabricator.wikimedia.org/T117627) (owner: 10Alex Monk)
[16:03:11] <wikibugs>	 10VisualEditor, 10VisualEditor-MediaWiki, 5Patch-For-Review: [Regression wmf.5] "Error loading data from server: ve-api..." when creating a new page with VisualEditor - https://phabricator.wikimedia.org/T117697#1782010 (10Jdforrester-WMF) p:5Triage>3Unbreak! a:3Krenair
[16:06:11] <grrrit-wm>	 (03Merged) 10jenkins-bot: Unbreak 404 handling code [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/250974 (https://phabricator.wikimedia.org/T117697) (owner: 10Alex Monk)
[16:06:23] <grrrit-wm>	 (03PS1) 10Jforrester: Unbreak 404 handling code [extensions/VisualEditor] (wmf/1.27.0-wmf.5) - 10https://gerrit.wikimedia.org/r/250981 (https://phabricator.wikimedia.org/T117697) 
[16:06:30] <grrrit-wm>	 (03CR) 10Jforrester: [C: 032] Unbreak 404 handling code [extensions/VisualEditor] (wmf/1.27.0-wmf.5) - 10https://gerrit.wikimedia.org/r/250981 (https://phabricator.wikimedia.org/T117697) (owner: 10Jforrester)
[16:06:32] <grrrit-wm>	 (03PS2) 10Alex Monk: Unbreak 404 handling code [extensions/VisualEditor] (wmf/1.27.0-wmf.5) - 10https://gerrit.wikimedia.org/r/250981 (https://phabricator.wikimedia.org/T117697) (owner: 10Jforrester)
[16:06:36] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Apply same hide/show logic to both education popup dots [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/250980 (https://phabricator.wikimedia.org/T117627) (owner: 10Alex Monk)
[16:06:38] <grrrit-wm>	 (03PS1) 10Alex Monk: Apply same hide/show logic to both education popup dots [extensions/VisualEditor] (wmf/1.27.0-wmf.5) - 10https://gerrit.wikimedia.org/r/250983 (https://phabricator.wikimedia.org/T117627) 
[16:06:51] <grrrit-wm>	 (03CR) 10Jforrester: [C: 032] Apply same hide/show logic to both education popup dots [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/250980 (https://phabricator.wikimedia.org/T117627) (owner: 10Alex Monk)
[16:07:08] <grrrit-wm>	 (03CR) 10Jforrester: [C: 032] Apply same hide/show logic to both education popup dots [extensions/VisualEditor] (wmf/1.27.0-wmf.5) - 10https://gerrit.wikimedia.org/r/250983 (https://phabricator.wikimedia.org/T117627) (owner: 10Alex Monk)
[16:09:43] <wikibugs>	 10VisualEditor: Loss of article content if editing a section - https://phabricator.wikimedia.org/T117713#1782050 (10Yurik) 3NEW
[16:10:58] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Unbreak 404 handling code [extensions/VisualEditor] (wmf/1.27.0-wmf.5) - 10https://gerrit.wikimedia.org/r/250981 (https://phabricator.wikimedia.org/T117697) (owner: 10Jforrester)
[16:11:02] <wikibugs>	 10VisualEditor, 10VisualEditor-MediaWiki: Switching from a WT section edit to VE only switches with the wikitext of the section, not the article - https://phabricator.wikimedia.org/T117713#1782059 (10Jdforrester-WMF) p:5Triage>3High a:3Krenair
[16:11:28] <grrrit-wm>	 (03CR) 10Jforrester: [C: 032 V: 032] Unbreak 404 handling code [extensions/VisualEditor] (wmf/1.27.0-wmf.5) - 10https://gerrit.wikimedia.org/r/250981 (https://phabricator.wikimedia.org/T117697) (owner: 10Jforrester)
[16:11:29] <Krenair>	 James_F, we'll just have to disallow switching from section wikitext editing
[16:12:20] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Apply same hide/show logic to both education popup dots [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/250980 (https://phabricator.wikimedia.org/T117627) (owner: 10Alex Monk)
[16:13:17] <grrrit-wm>	 (03CR) 10Jforrester: [C: 032] Apply same hide/show logic to both education popup dots [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/250980 (https://phabricator.wikimedia.org/T117627) (owner: 10Alex Monk)
[16:14:18] <James_F>	 Krenair: Can't we fetch the wikitext of the rest of the article and merge it?
[16:14:46] <Krenair>	 Not AFAIK
[16:14:54] <James_F>	 Eh.
[16:15:13] <Krenair>	 maybe a parsoid/restbase feature request
[16:15:21] <James_F>	 Sure.
[16:15:24] <James_F>	 Should be disabled, not missing.
[16:16:19] <RoanKattouw>	 There is a PHP implementation of section merging, but I don't think that's exposed through any sort of API
[16:16:27] <James_F>	 RoanKattouw: Helpful.
[16:16:49] <RoanKattouw>	 Actually I'm fairly sure it lives in EditPage.php
[16:17:19] <James_F>	 I guess we'd want to splice with the wikitext of the oldId of the edit start, not the curId wikitext, so we'd not have to work out what we'd do with edit conflicts, thankfully.
[16:18:35] <RoanKattouw>	 Yes
[16:18:38] <RoanKattouw>	 I think that's what PHP does too
[16:18:52] <James_F>	 $this->mArticle->replaceSectionContent
[16:18:58] <RoanKattouw>	 Also you may want to use the PHP logic, since the PHP logic is what was used to decide the section boundaries that gave you the edit form you're looking at
[16:19:08] <RoanKattouw>	 Oh it's in Article.php / WikiPage.php
[16:19:47] <James_F>	 WikiPage.php
[16:20:10] <grrrit-wm>	 (03PS1) 10Alex Monk: Don't allow keeping changes when switching from wikitext *section* editing [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/250987 (https://phabricator.wikimedia.org/T117713) 
[16:20:16] <James_F>	 replaceSectionAtRev rather.
[16:20:47] <James_F>	 Krenair: Does that hold for section=new as well as section=34 or whatever?
[16:20:58] <Krenair>	 >>> !"new"
[16:20:59] <ecmabot-wm>	 Krenair: (boolean) false
[16:21:03] <Krenair>	 >>> !"34"
[16:21:04] <ecmabot-wm>	 Krenair: (boolean) false
[16:21:04] <James_F>	 Krenair: Or is that stored differently?
[16:21:06] <Krenair>	 >>> !""
[16:21:06] <ecmabot-wm>	 Krenair: (boolean) true
[16:21:08] <Krenair>	 yep
[16:21:21] <James_F>	 Sure, but is it stored in "input[name=wpSection]"?
[16:21:24] <grrrit-wm>	 (03Merged) 10jenkins-bot: Apply same hide/show logic to both education popup dots [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/250980 (https://phabricator.wikimedia.org/T117627) (owner: 10Alex Monk)
[16:21:44] <Krenair>	 yes
[16:21:48] <James_F>	 OK.
[16:22:17] <James_F>	 Hmm. Maybe in future we can explain why they can't switch-with, but sure.
[16:22:23] <grrrit-wm>	 (03CR) 10Jforrester: [C: 032] Don't allow keeping changes when switching from wikitext *section* editing [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/250987 (https://phabricator.wikimedia.org/T117713) (owner: 10Alex Monk)
[16:22:40] <wikibugs>	 10VisualEditor, 10VisualEditor-CopyPaste, 10VisualEditor-MediaWiki: Wikitext paste handler should be undoable - https://phabricator.wikimedia.org/T117376#1782114 (10Yurik) Is it possible to have a custom content format when copying? So that VE can identify that the content was copied from VE itself, and thus...
[16:23:39] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Don't allow keeping changes when switching from wikitext *section* editing [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/250987 (https://phabricator.wikimedia.org/T117713) (owner: 10Alex Monk)
[16:23:41] <wikibugs>	 10VisualEditor, 10VisualEditor-MediaWiki, 10MediaWiki-Page-editing: Expose WikiPage.php's replaceSectionAtRev function through the API - https://phabricator.wikimedia.org/T117715#1782119 (10Jdforrester-WMF) 3NEW
[16:24:32] <wikibugs>	 10VisualEditor, 10VisualEditor-MediaWiki: Be able to switch editors after starting to edit a section - https://phabricator.wikimedia.org/T117716#1782130 (10Jdforrester-WMF) 3NEW
[16:24:48] <wikibugs>	 10VisualEditor, 10VisualEditor-MediaWiki, 10MediaWiki-Page-editing: Expose WikiPage.php's replaceSectionAtRev function through the API - https://phabricator.wikimedia.org/T117715#1782137 (10Jdforrester-WMF)
[16:24:51] <wikibugs>	 10VisualEditor, 10VisualEditor-MediaWiki: Be able to switch editors after starting to edit a section - https://phabricator.wikimedia.org/T117716#1782130 (10Jdforrester-WMF)
[16:24:58] <wikibugs>	 10VisualEditor, 10VisualEditor-MediaWiki: Be able to switch editors after starting to edit a section - https://phabricator.wikimedia.org/T117716#1782130 (10Jdforrester-WMF)
[16:25:09] <wikibugs>	 10VisualEditor, 10VisualEditor-MediaWiki, 10MediaWiki-Page-editing: Expose WikiPage.php's replaceSectionAtRev function through the API - https://phabricator.wikimedia.org/T117715#1782119 (10Jdforrester-WMF)
[16:28:17] <grrrit-wm>	 (03CR) 10Jforrester: "Duplicate of Id66d436…" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/250972 (https://phabricator.wikimedia.org/T111038) (owner: 10Esanders)
[16:28:56] <grrrit-wm>	 (03CR) 10Jforrester: [C: 032] Don't allow keeping changes when switching from wikitext *section* editing [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/250987 (https://phabricator.wikimedia.org/T117713) (owner: 10Alex Monk)
[16:32:21] <Krenair>	 We've gone through a worryingly high amount of swat fixes for this :/
[16:32:54] <wikibugs>	 10VisualEditor, 10VisualEditor-ContentEditable: Unable to select more than one paragraph using the keyboard - https://phabricator.wikimedia.org/T97809#1782168 (10Esanders) 5Open>3Resolved Fixed by https://gerrit.wikimedia.org/r/#/c/239388/
[16:33:37] <James_F>	 Krenair: Yeah.
[16:34:36] <wikibugs>	 10VisualEditor, 10VisualEditor-ContentEditable: Unable to select more than one paragraph using the keyboard - https://phabricator.wikimedia.org/T97809#1782170 (10Jdforrester-WMF) a:5Esanders>3dchan
[16:34:55] <grrrit-wm>	 (03Merged) 10jenkins-bot: Don't allow keeping changes when switching from wikitext *section* editing [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/250987 (https://phabricator.wikimedia.org/T117713) (owner: 10Alex Monk)
[16:35:47] <wikibugs>	 10VisualEditor, 10VisualEditor-MediaWiki, 5WMF-deploy-2015-11-03_(1.27.0-wmf.5), 5WMF-deploy-2015-11-10_(1.27.0-wmf.6): [Regression wmf.5] Getting "Switch to Visual Editing?" dialog after saving a page and trying to re-open VE - https://phabricator.wikimedia.org/T117596#1782175 (10Jdforrester-WMF)
[16:35:58] <wikibugs>	 10VisualEditor, 10VisualEditor-MediaWiki, 10WikiEditor, 10RESTBase, and 4 others: Provide a way for the user to switch between VisualEditor and wikitext source editor modes without saving - https://phabricator.wikimedia.org/T49779#1782177 (10Jdforrester-WMF)
[16:36:07] <wikibugs>	 10VisualEditor, 6Collaboration-Team-Backlog, 10Flow, 10OOjs-UI, and 3 others: Duplicate icons: 'source' (in VE) and 'WikiText' - https://phabricator.wikimedia.org/T111038#1782178 (10Jdforrester-WMF)
[16:36:20] <wikibugs>	 10VisualEditor, 10VisualEditor-MediaWiki, 5WMF-deploy-2015-11-03_(1.27.0-wmf.5), 5WMF-deploy-2015-11-10_(1.27.0-wmf.6): [Regression wmf.5] On Beta cluster and on mw.org after clicking on pulsating dot for the educational pop-up , the pulse goes away but not... - https://phabricator.wikimedia.org/T117627#1782180
[16:36:34] <wikibugs>	 10VisualEditor, 10VisualEditor-MediaWiki, 5WMF-deploy-2015-11-03_(1.27.0-wmf.5), 5WMF-deploy-2015-11-10_(1.27.0-wmf.6): [Regression wmf.5] "Error loading data from server: ve-api..." when creating a new page with VisualEditor - https://phabricator.wikimedia.org/T117697#1782182 (10Jdforrester-WMF) 5Open>...
[16:37:30] <wikibugs>	 10VisualEditor, 10VisualEditor-MediaWiki, 5Patch-For-Review: Switching from a WT section edit to VE only switches with the wikitext of the section, not the article - https://phabricator.wikimedia.org/T117713#1782184 (10Krenair) 5Open>3Resolved -> {T117716}
[16:38:16] <grrrit-wm>	 (03PS1) 10Jforrester: Don't allow keeping changes when switching from wikitext *section* editing [extensions/VisualEditor] (wmf/1.27.0-wmf.5) - 10https://gerrit.wikimedia.org/r/250992 (https://phabricator.wikimedia.org/T117713) 
[16:38:23] <wikibugs>	 10VisualEditor, 10VisualEditor-MediaWiki: Switching from a WT section edit to VE only switches with the wikitext of the section, not the article - https://phabricator.wikimedia.org/T117713#1782189 (10Krenair)
[16:38:50] <James_F>	 Krenair: Do you have enough from edsanders to improve the education pop-ups? Before we add one to the 'switch' button…
[16:39:39] <wikibugs>	 10VisualEditor, 10VisualEditor-MediaWiki, 5WMF-deploy-2015-11-03_(1.27.0-wmf.5), 5WMF-deploy-2015-11-10_(1.27.0-wmf.6): Switching from a WT section edit to VE only switches with the wikitext of the section, not the article - https://phabricator.wikimedia.org/T117713#1782191 (10Jdforrester-WMF)
[16:40:15] <Krenair>	 Hmm. Maybe
[16:42:58] <wikibugs>	 10VisualEditor, 10VisualEditor-MediaWiki, 6Multimedia, 5WMF-deploy-2015-10-27_(1.27.0-wmf.4): Cannot edit any image because while trying to edit an existing image, instead of "Apply Changes", there is now "Upload" button - https://phabricator.wikimedia.org/T116217#1743517 (10Jdforrester-WMF)
[16:44:41] <wikibugs>	 10VisualEditor: Language-appropriate icons for italic and bold for Serbian language - https://phabricator.wikimedia.org/T95761#1782223 (10Jdforrester-WMF)
[16:49:05] <edsanders>	 James_F, the switch education popup might be slightly different in that it may auto-open in some cases
[16:49:28] <Krenair>	 edsanders, so I still haven't figured out how the factory idea can help us fix the mobile issue
[16:50:26] <Krenair>	 we're still going to need to hook onSelect because we need to set pref/cookie/localstorage
[17:12:45] <James_F>	 edsanders: Hmm. I think glowing-balls could work for the switch one too, but maybe.
[17:13:04] <edsanders>	 I think we need to lose the animation
[17:13:35] <James_F>	 I rather like them.
[17:13:36] <edsanders>	 Krenair, why? the preference will be stored per popup - and we will detect clicks on the popup directly
[17:14:14] <edsanders>	 James_F, one or two are bearable, but it doesn't scale
[17:14:58] <James_F>	 edsanders: Two max, plus an auto-open switch one.
[17:16:03] <edsanders>	 until someone asks us to add another one
[17:16:13] <James_F>	 I said two max a couple of months ago.
[17:16:48] <edsanders>	 anyway - there's a ticket for this
[17:17:47] <Krenair>	 okay, yes, we should probably be doing that when the user closes the popup anyway
[17:18:05] <Krenair>	 how are we going to suppress the link tool when we want to show the popup for it instead?
[17:19:35] <edsanders>	 the popup click target will fully mask the button
[17:19:50] <edsanders>	 <edsanders> the tools are already position:relative, so you just make the popup position:absolute;top:0;right:0;bottom:0;left:0;
[17:20:14] <edsanders>	 that is the alternative approach to overriding onSelect...
[17:20:23] <edsanders>	 if you mask the tool there will be no onSelect
[17:48:52] <Krenair>	 edsanders|away, we'll have to change the way we set top and left CSS on the popup element then
[17:49:26] <Krenair>	 or... hm, maybe not
[17:51:06] <Krenair>	 still no luck getting it to suppress the tool though
[17:53:34] <grrrit-wm>	 (03PS1) 10DLynch: MWCommandHelpDialog: udpate for core changes [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/251006 
[17:54:21] <Krenair>	 edsanders, wouldn't the popup have to be visible as well?
[17:54:21] <James_F>	 Kemayo: Cool, thanks for that.
[17:54:39] <edsanders>	 yes, but no the click target
[17:54:42] <Kemayo>	 James_F / edsanders: Indeed, it'll break the help dialog.
[17:54:52] <James_F>	 Groovy.
[17:55:39] <grrrit-wm>	 (03PS2) 10DLynch: MWCommandHelpDialog: update for core changes [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/251006 
[17:55:49] <Kemayo>	 (Can't have a typo in the subject.)
[17:57:58] <grrrit-wm>	 (03CR) 10DLynch: Add ve.Scheduler, use it to avoid conflict in ve.ui.Tool (031 comment) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/250904 (https://phabricator.wikimedia.org/T117620) (owner: 10DLynch)
[17:59:16] <Krenair>	 edsanders, the popup would have to be visible so it can prevent the tool itself being clicked...?
[17:59:26] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] MWCommandHelpDialog: update for core changes [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/251006 (owner: 10DLynch)
[17:59:28] <edsanders>	 it can be transparent
[18:01:53] <grrrit-wm>	 (03PS3) 10DLynch: MWCommandHelpDialog: update for core changes [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/251006 
[18:11:43] <grrrit-wm>	 (03CR) 10Jforrester: [C: 032] MWCommandHelpDialog: update for core changes [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/251006 (owner: 10DLynch)
[18:13:58] <edsanders>	 Krenair, basically a click shield like we used to do with focusable nodes
[18:14:34] <Krenair>	 I never had to touch that code
[18:15:06] <Krenair>	 I'll see if I can find it
[18:21:10] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] MWCommandHelpDialog: update for core changes [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/251006 (owner: 10DLynch)
[18:22:50] <James_F>	 Meh.
[18:23:14] <grrrit-wm>	 (03CR) 10Jforrester: [C: 032] "Jenkins you suck." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/251006 (owner: 10DLynch)
[18:23:59] <wikibugs>	 10VisualEditor, 10VisualEditor-MediaWiki: VisualEditor: Provide a get-me-into-the-wikitext-editor link on every header inside the VisualEditor - https://phabricator.wikimedia.org/T51665#1782927 (10Whatamidoing-WMF) Is this still relevant now that {T49779} is resolved?
[18:24:45] <Krenair>	 edsanders, where was the code that did this?
[18:25:06] <edsanders>	 it's about 2 years ago
[18:25:19] <edsanders>	 but basically if you position a div over something else it will capture the events first
[18:25:27] <edsanders>	 it's not complicated
[18:25:27] <Krenair>	 was this shields?
[18:25:33] <Krenair>	 yes, I got that bit
[18:25:41] <Krenair>	 But you're suggesting I use the popup itself
[18:25:59] <edsanders>	 no, the popup would have a shield component
[18:26:30] <edsanders>	 for capturing tool interactions (click at the moment, maybe hover in the future)
[18:27:06] <grrrit-wm>	 (03Merged) 10jenkins-bot: MWCommandHelpDialog: update for core changes [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/251006 (owner: 10DLynch)
[18:27:42] <James_F>	 edsanders: Thoughts on my comment on https://gerrit.wikimedia.org/r/#/c/250958/ ?
[18:29:59] <grrrit-wm>	 (03CR) 10Esanders: "It might not even been better in all browsers. It's just one of this things with centring." [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/250958 (owner: 10Esanders)
[18:31:11] <grrrit-wm>	 (03CR) 10Jforrester: [C: 032] "Fine." [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/250958 (owner: 10Esanders)
[18:32:29] <wikibugs>	 10VisualEditor, 10VisualEditor-MediaWiki, 10WikiEditor: Bi-directional switching causes an error message when you try to navigate to a different page - https://phabricator.wikimedia.org/T117769#1783003 (10Whatamidoing-WMF) 3NEW
[18:32:49] <wikibugs>	 10VisualEditor, 10VisualEditor-MediaWiki, 10WikiEditor: Bi-directional switching causes an error message when you try to navigate to a different page - https://phabricator.wikimedia.org/T117769#1783014 (10Whatamidoing-WMF)
[18:34:03] <grrrit-wm>	 (03PS1) 10Alex Monk: Restructure education popup code to work without overriding onSelect [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/251016 (https://phabricator.wikimedia.org/T117603) 
[18:34:33] <grrrit-wm>	 (03Merged) 10jenkins-bot: Slugs: Remove vertical alignment hack [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/250958 (owner: 10Esanders)
[18:34:47] <Krenair>	 jenkins qunit -1 in 3..2..
[18:35:49] * James_F grins.
[18:36:13] <James_F>	 Unused variable.
[18:36:17] <James_F>	 https://integration.wikimedia.org/ci/job/mwext-VisualEditor-npm/10374/console
[18:37:10] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Restructure education popup code to work without overriding onSelect [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/251016 (https://phabricator.wikimedia.org/T117603) (owner: 10Alex Monk)
[18:38:48] <grrrit-wm>	 (03PS2) 10Alex Monk: Restructure education popup code to work without overriding onSelect [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/251016 (https://phabricator.wikimedia.org/T117603) 
[18:42:33] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Restructure education popup code to work without overriding onSelect [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/251016 (https://phabricator.wikimedia.org/T117603) (owner: 10Alex Monk)
[18:43:24] <Krenair>	 qunit, predictably
[18:43:35] <Krenair>	 the usual disconnected message
[18:58:41] <wikibugs>	 10TemplateData: TemplateData editor appears to be broken at eo.wikipedia.org - https://phabricator.wikimedia.org/T117772#1783116 (10Whatamidoing-WMF) 3NEW
[19:06:34] <wikibugs>	 10TemplateData: TemplateData editor appears to be broken at eo.wikipedia.org - https://phabricator.wikimedia.org/T117772#1783174 (10Elitre) The second time I clicked on the link, everything looked fine for me?
[19:08:24] <wikibugs>	 10TemplateData, 10MediaWiki-ResourceLoader: TemplateData editor appears to be broken at eo.wikipedia.org - https://phabricator.wikimedia.org/T117772#1783193 (10matmarex) Hah, yeah, I experienced the same thing as @Elitre. The first time it looked as if none of the OOjs UI styles were loaded (but all the JavaSc...
[19:10:56] <wikibugs>	 10VisualEditor, 10Phlogiston, 6Team-Practices, 7WorkType-NewFunctionality: Create an article/essay version of the charts - https://phabricator.wikimedia.org/T110081#1783243 (10JAufrecht) 5Open>3Resolved making a new task for this.
[19:10:58] <wikibugs>	 10VisualEditor, 10Phlogiston, 15User-JAufrecht, 7WorkType-NewFunctionality: Create third version of VE burnup report - https://phabricator.wikimedia.org/T107482#1783245 (10JAufrecht)
[19:19:16] <wikibugs>	 10VisualEditor: Getting 400 error while trying to switch from wikitext editor to VisualEditor when clicked on "discard changes" - https://phabricator.wikimedia.org/T117780#1783296 (10Ryasmeen) 3NEW
[19:22:10] <wikibugs>	 10VisualEditor: Getting 400 error while trying to switch from wikitext editor for section editing to VisualEditor when clicked on "discard changes" - https://phabricator.wikimedia.org/T117780#1783338 (10Ryasmeen)
[19:27:52] <wikibugs>	 10VisualEditor: [Regression wmf.5] Getting 400 error while trying to switch from wikitext editor for section editing to VisualEditor when clicked on "discard changes" - https://phabricator.wikimedia.org/T117780#1783397 (10Ryasmeen)
[19:40:15] <wikibugs>	 10TemplateData, 10MediaWiki-ResourceLoader: TemplateData editor appears to be broken at eo.wikipedia.org - https://phabricator.wikimedia.org/T117772#1783497 (10Elitre) (Or something in that's site common.js that messes stuff up?)
[19:58:05] <wikibugs>	 10TemplateData, 10MediaWiki-ResourceLoader: TemplateData editor appears to be broken at eo.wikipedia.org - https://phabricator.wikimedia.org/T117772#1783579 (10Krinkle) I can consistently reproduce this by running `localStorage.clear();` and then refreshing the page.  This is not caused by a change in Resource...
[19:58:24] <wikibugs>	 10TemplateData: TemplateData editor appears to be broken at eo.wikipedia.org - https://phabricator.wikimedia.org/T117772#1783581 (10Krinkle)
[21:01:25] <grrrit-wm>	 (03CR) 10Alex Monk: "recheck" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/251016 (https://phabricator.wikimedia.org/T117603) (owner: 10Alex Monk)
[21:11:26] <wikibugs>	 10TemplateData: TemplateData editor appears to be broken at eo.wikipedia.org - https://phabricator.wikimedia.org/T117772#1783804 (10Jdforrester-WMF) Thank you @Krinkle!
[21:12:01] <wikibugs>	 10TemplateData, 5WMF-deploy-2015-11-03_(1.27.0-wmf.5): TemplateData editor broken at eo.wikipedia.org due to local Common.css being broken - https://phabricator.wikimedia.org/T117772#1783805 (10Jdforrester-WMF) 5Open>3Resolved p:5Triage>3Normal a:3Krinkle
[21:27:39] <grrrit-wm>	 (03PS1) 10Jforrester: Follow-up d6ddbe4: Fix build for added language 'sd' [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/251125 
[21:35:19] <grrrit-wm>	 (03CR) 10Jforrester: [C: 031] Restructure education popup code to work without overriding onSelect [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/251016 (https://phabricator.wikimedia.org/T117603) (owner: 10Alex Monk)
[21:35:29] <grrrit-wm>	 (03CR) 10Alex Monk: [C: 032] Follow-up d6ddbe4: Fix build for added language 'sd' [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/251125 (owner: 10Jforrester)
[21:36:51] <James_F>	 Krenair: What are you working on now? Need help with anything?
[21:38:29] <Krenair>	 I just had dinner, haven't looked at my list yet
[21:38:38] <James_F>	 Kk.
[21:39:44] <grrrit-wm>	 (03Merged) 10jenkins-bot: Follow-up d6ddbe4: Fix build for added language 'sd' [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/251125 (owner: 10Jforrester)
[21:41:33] <Krenair>	 Cleaned up my email inbox though
[21:41:57] <Krenair>	 I don't have a nice solution for https://phabricator.wikimedia.org/T117643
[21:42:25] <Krenair>	 I think I saw https://phabricator.wikimedia.org/T117769 myself at some point, will investigate
[21:42:36] <wikibugs>	 10VisualEditor, 10VisualEditor-MediaWiki: Bi-directional switching causes an error message when you try to navigate to a different page - https://phabricator.wikimedia.org/T117769#1783899 (10Krenair)
[21:43:06] <Krenair>	 (By the way, it's helpful if people either subscribe me or, if appropriate, add visualeditor-mediawiki to tasks that relate to code I wrote)
[21:43:26] <wikibugs>	 10VisualEditor, 6Collaboration-Team-Backlog, 10Flow, 6Language-Engineering, and 4 others: Provide an API flag to suppress auto-generated <references /> - https://phabricator.wikimedia.org/T113331#1783900 (10ssastry) <James_F> subbu: Doing the same thing in every client sucks. <James_F> subbu: Also, the nam...
[21:43:59] <James_F>	 Krenair: I can assign a couple if it'd help?
[21:44:10] <Krenair>	 what do you have in mind?
[21:45:36] <James_F>	 Krenair: CR on https://gerrit.wikimedia.org/r/#/c/247275/ and https://gerrit.wikimedia.org/r/#/c/247276/ would be awesome (TitleBlacklist stuff for uploading and VE).
[21:46:58] <wikibugs>	 10VisualEditor, 10VisualEditor-MediaWiki, 10VisualEditor-MediaWiki-Media, 6Multimedia, 7Design: Give guidance in the new upload form, to prevent the most common errors - e.g. bad file titles - https://phabricator.wikimedia.org/T116086#1783919 (10Jdforrester-WMF) p:5Triage>3Normal a:3Prtksxna
[21:47:12] <wikibugs>	 10VisualEditor, 10VisualEditor-MediaWiki: VisualEditor does not handle TitleBlacklist errors with custom error messages - https://phabricator.wikimedia.org/T116198#1783923 (10Jdforrester-WMF) p:5Triage>3Normal
[21:47:39] <James_F>	 Maybe https://phabricator.wikimedia.org/T116278.
[21:47:39] <Krenair>	 James_F, sure, I'll take a loo
[21:47:40] <Krenair>	 look
[21:47:47] <James_F>	 Thank you.
[21:47:49] <wikibugs>	 10VisualEditor, 10VisualEditor-MediaWiki: Auto edit conflict on VE is not warned - https://phabricator.wikimedia.org/T116278#1783926 (10Jdforrester-WMF) p:5Triage>3Low
[21:48:50] <wikibugs>	 10VisualEditor, 10VisualEditor-EditingTools, 10VisualEditor-MediaWiki, 10VisualEditor-Tables: Editing tools interfere with informational flyouts - https://phabricator.wikimedia.org/T117387#1783942 (10Jdforrester-WMF)
[21:48:54] <wikibugs>	 10VisualEditor, 10VisualEditor-EditingTools, 10VisualEditor-MediaWiki, 10VisualEditor-Tables: Editing tools interfere with informational flyouts - https://phabricator.wikimedia.org/T117387#1772564 (10Jdforrester-WMF)
[21:49:10] <wikibugs>	 10VisualEditor, 10VisualEditor-MediaWiki: Educational popups overlap with toolbar dialogs, selection highlights - https://phabricator.wikimedia.org/T116577#1783947 (10Jdforrester-WMF) a:3Krenair
[21:49:13] <James_F>	 And that one maybe.
[21:50:28] <Krenair>	 Maybe there's some $overlay thing to mess with for that... if not, I might not know how to fix it
[22:43:57] <wikibugs>	 10VisualEditor, 10VisualEditor-MediaWiki: VisualEditor does not handle TitleBlacklist errors with custom error messages - https://phabricator.wikimedia.org/T116198#1784056 (10Krenair)
[22:44:01] <wikibugs>	 10VisualEditor, 10VisualEditor-MediaWiki-Media, 6Commons, 10MediaWiki-extensions-TitleBlacklist, 6Multimedia: Provide precise information for errors caused by title blacklist in upload image dialog - https://phabricator.wikimedia.org/T115260#1784057 (10Krenair)
[22:47:39] <James_F>	 Krenair: Maybe?
[22:47:48] <Krenair>	 ?
[22:47:59] <James_F>	 "Maybe there's some $overlay thing to mess with for that... if not, I might not know how to fix it "
[22:48:12] <James_F>	 Only 58 minutes delayed response. ;-)
[22:50:56] <Krenair>	 yes, I said that
[22:52:01] <James_F>	 My reply was mostly encouragement tinged with doubt that it might be that simple.
[22:52:25] <Krenair>	 ok...
[22:55:00] <grrrit-wm>	 (03Abandoned) 10Jforrester: Icons: Remove 'source' icon in favour of identical OOUI 'wikiText' icon [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/250972 (https://phabricator.wikimedia.org/T111038) (owner: 10Esanders)
[22:55:34] <Krenair>	 exception: TypeError: Cannot read property 'prototype' of undefined
[22:55:34] <Krenair>	     at Object.oo.mixinClass (http://mediawi�, module: "ext.citoid.visualEditor"
[22:55:36] <Krenair>	 urgh... what is this
[22:55:44] <James_F>	 Err.
[22:55:49] <James_F>	 That's… not good.
[22:55:52] <James_F>	 Where did you get that?
[22:56:29] <Krenair>	 opening ve on a new page
[22:56:53] <Krenair>	 could this be due to the class rename?
[22:57:16] <James_F>	 Renamed to a string starting "http://mediawi"?
[22:57:25] <Krenair>	 no
[22:57:28] <James_F>	 Oooh.
[22:57:34] <Krenair>	 The education popup class rename
[22:57:38] <Krenair>	 it was referenced in citoid
[22:57:45] <Krenair>	 but why did this never break before?
[22:57:49] <James_F>	 Err.
[22:58:16] <James_F>	 Not broken for me in Beta Cluster.
[22:58:51] <Krenair>	 it still references ve.ui.MWEducationPopupTool though
[22:58:59] <grrrit-wm>	 (03CR) 10Esanders: [C: 04-2] "Yes." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/250962 (owner: 10Jforrester)
[23:00:48] <Krenair>	 no, wait, was it education popup tool we renamed?
[23:01:07] <Krenair>	 I may be confusing this with the VE switch dialog
[23:01:13] <Krenair>	 urgh
[23:04:03] <Krenair>	 now my restbase is broken
[23:04:04] <grrrit-wm>	 (03PS3) 10Jforrester: CommandHelpDialog: Move registrations to where sequences are defined [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/250665 (owner: 10Esanders)
[23:04:15] <Krenair>	 GET http://localhost:7231/mediawiki.krenair.dev/v1/page/html/Main_Page 404 (OK)
[23:04:16] <Krenair>	 What.
[23:04:38] <James_F>	 Krenair: I thought it was the switch dialog we renamed.
[23:04:50] <Krenair>	 yeah
[23:05:35] <wikibugs>	 10VisualEditor, 10VisualEditor-MediaWiki-Mobile, 6Design Research Backlog, 7Design, and 3 others: Agree a new overall design for VisualEditor on mobile phone-sized devices - https://phabricator.wikimedia.org/T93325#1784080 (10Jdforrester-WMF) Some quick thoughts:  * no change toolbar; drop the title, switc...
[23:08:54] <Krenair>	 I can't do anything about this with restbase broken
[23:10:02] <James_F>	 :-(
[23:13:03] <Krenair>	 or anything really
[23:15:49] <wikibugs>	 10VisualEditor, 10VisualEditor-MediaWiki-Mobile, 6Design Research Backlog, 7Design, and 3 others: Agree a new overall design for VisualEditor on mobile phone-sized devices - https://phabricator.wikimedia.org/T93325#1784094 (10Nirzar) @Jdforrester-WMF  here are the iterated designs for smaller toolbar with...
[23:25:17] <Krenair>	 I left a message in the services channel
[23:25:19] * Krenair goes afk
[23:33:37] <wikibugs>	 10VisualEditor: Section edit link is appearing next to the article title in test2 - https://phabricator.wikimedia.org/T117814#1784155 (10Ryasmeen) 3NEW
[23:36:50] <wikibugs>	 10VisualEditor: Section edit link is appearing next to the article title in test2 - https://phabricator.wikimedia.org/T117814#1784162 (10Ryasmeen) Also, it stays when VisualEditor is open on the page {F2915330}
[23:37:04] <wikibugs>	 10VisualEditor: Section edit link is appearing next to the article title in test2 - https://phabricator.wikimedia.org/T117814#1784163 (10Ryasmeen)
[23:41:27] <wikibugs>	 10VisualEditor: Section edit link is appearing next to the article title in test2 - https://phabricator.wikimedia.org/T117814#1784171 (10Krenair) Isn't this a gadget?
[23:45:48] <wikibugs>	 10VisualEditor: Section edit link is appearing next to the article title in test2 - https://phabricator.wikimedia.org/T117814#1784179 (10Krenair) 5Open>3Invalid a:3Krenair Yes, you have the 'gadget-edittop' preference on test2wiki.
[23:50:48] <grrrit-wm>	 (03CR) 10Jforrester: [C: 032] CommandHelpDialog: Move registrations to where sequences are defined [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/250665 (owner: 10Esanders)
[23:51:18] <James_F>	 Krenair: Don't feel we can SWAT https://gerrit.wikimedia.org/r/#/c/251016/ right now.
[23:51:25] <grrrit-wm>	 (03CR) 10Jforrester: [C: 032] Don't allow keeping changes when switching from wikitext *section* editing [extensions/VisualEditor] (wmf/1.27.0-wmf.5) - 10https://gerrit.wikimedia.org/r/250992 (https://phabricator.wikimedia.org/T117713) (owner: 10Jforrester)
[23:51:45] <Krenair>	 James_F, OK
[23:52:10] <Krenair>	 I should probably test that actually fixes it on mobile
[23:52:12] <James_F>	 Krenair: Unless edsanders|away comes online and +2s in the next seven minutes.
[23:52:16] <James_F>	 Ha. That too. :-)
[23:52:20] <Krenair>	 but like... when I can actually test VE at all
[23:52:24] <James_F>	 :-(