[06:07:06] 10Cite: Changing text of Mediawiki:Cite error ref no key - https://phabricator.wikimedia.org/T115810#1792559 (10darthbhyrava) a:3darthbhyrava Can I submit a patch for this? As in, the suggested edit is simple, but is it acceptable or should be provide another message? [06:26:34] 10Cite, 5Patch-For-Review: Changing text of Mediawiki:Cite error ref no key - https://phabricator.wikimedia.org/T115810#1792591 (10darthbhyrava) Up for review. If there are any changes to the message suggested, I'd gladly update my commit. :) [07:18:21] 10VisualEditor: moving from source editing to VisualEditor on an empty newly-created page gives an HTTP 400 error - https://phabricator.wikimedia.org/T118118#1792614 (10Aklapper) [07:46:59] (03PS2) 10DLynch: Close inspectors before executing a ve.ui.Tool command [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/250646 (https://phabricator.wikimedia.org/T76717) [07:58:39] (03PS7) 10DLynch: Add ve.Scheduler [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/250904 (https://phabricator.wikimedia.org/T117620) [08:01:05] (03CR) 10jenkins-bot: [V: 04-1] Add ve.Scheduler [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/250904 (https://phabricator.wikimedia.org/T117620) (owner: 10DLynch) [08:02:25] (03PS8) 10DLynch: Add ve.Scheduler [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/250904 (https://phabricator.wikimedia.org/T117620) [08:13:16] (03PS3) 10DLynch: Close inspectors before executing a ve.ui.Tool command [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/250646 (https://phabricator.wikimedia.org/T76717) [08:14:54] (03CR) 10Divec: [C: 032] Add ve.Scheduler [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/250904 (https://phabricator.wikimedia.org/T117620) (owner: 10DLynch) [08:18:15] (03Merged) 10jenkins-bot: Add ve.Scheduler [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/250904 (https://phabricator.wikimedia.org/T117620) (owner: 10DLynch) [08:24:07] (03CR) 10Divec: [C: 031] "Seems like the right way to do this" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/250646 (https://phabricator.wikimedia.org/T76717) (owner: 10DLynch) [10:00:34] 10VisualEditor, 10VisualEditor-MediaWiki, 10WikiEditor: Switch to VE button presented on Create page but doesn't function - https://phabricator.wikimedia.org/T118152#1792739 (10TheDJ) 3NEW [10:12:13] 10VisualEditor, 6Collaboration-Team-Backlog, 10Flow, 7Performance: VE preview on Flow pages take too long (1min+) to load in debug mode - https://phabricator.wikimedia.org/T118090#1792767 (10Aklapper) [11:55:08] 10VisualEditor: moving from source editing to VisualEditor on an empty newly-created page gives an HTTP 400 error - https://phabricator.wikimedia.org/T118118#1793047 (10TTO) [12:18:04] 10VisualEditor, 10MediaWiki-History-or-Diffs, 10MediaWiki-Page-editing: Say "Your edit has been saved" instead of "The page has been restored" - https://phabricator.wikimedia.org/T117662#1793078 (10Nnemo) >>! In T117662#1781741, @Jdforrester-WMF wrote: > The introduction of a different text was explicitly re... [12:53:55] 10VisualEditor, 10VisualEditor-MediaWiki, 10WikiEditor: Switch to VE button presented on Create page but doesn't function - https://phabricator.wikimedia.org/T118152#1793178 (10Krenair) [14:43:24] 10VisualEditor, 7Browser-Tests: Delete or fix failed VisualEditor browsertests Jenkins jobs - https://phabricator.wikimedia.org/T94162#1793441 (10zeljkofilipin) [15:02:30] 10VisualEditor, 10VisualEditor-MediaWiki, 10WikiEditor: Switch to VE button presented on Create page but doesn't function - https://phabricator.wikimedia.org/T118152#1793494 (10TheDJ) Wouldn't it be handier to set this ticket as "blocked by" instead of duplicate ? Separating the higher level user story from... [15:16:52] (03PS8) 10Divec: WIP: Diff richtext to build model changes [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/247800 [15:17:11] (03CR) 10Jforrester: [C: 032] Unset 'action' query parameter from veEditUri, which should always point to VE [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/251843 (https://phabricator.wikimedia.org/T117780) (owner: 10Alex Monk) [15:17:15] 10VisualEditor, 10VisualEditor-MediaWiki: [Regression wmf.5] Getting 400 error while trying to switch from wikitext editor for section editing to VisualEditor when clicked on "discard changes" - https://phabricator.wikimedia.org/T117780#1793559 (10Jdforrester-WMF) 5Open>3Resolved p:5Triage>3High a:3Kr... [15:20:23] (03PS6) 10Divec: WIP: Build model transactions from richtext DOM diff [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/249077 [15:22:21] (03CR) 10jenkins-bot: [V: 04-1] Unset 'action' query parameter from veEditUri, which should always point to VE [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/251843 (https://phabricator.wikimedia.org/T117780) (owner: 10Alex Monk) [15:22:47] (03CR) 10Jforrester: [C: 032] "…" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/251843 (https://phabricator.wikimedia.org/T117780) (owner: 10Alex Monk) [15:23:46] (03CR) 10jenkins-bot: [V: 04-1] WIP: Build model transactions from richtext DOM diff [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/249077 (owner: 10Divec) [15:26:19] (03Merged) 10jenkins-bot: Unset 'action' query parameter from veEditUri, which should always point to VE [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/251843 (https://phabricator.wikimedia.org/T117780) (owner: 10Alex Monk) [15:28:08] (03PS1) 10Jforrester: Unset 'action' query parameter from veEditUri, which should always point to VE [extensions/VisualEditor] (wmf/1.27.0-wmf.5) - 10https://gerrit.wikimedia.org/r/251969 (https://phabricator.wikimedia.org/T117780) [15:28:26] (03CR) 10Jforrester: [C: 032] Unset 'action' query parameter from veEditUri, which should always point to VE [extensions/VisualEditor] (wmf/1.27.0-wmf.5) - 10https://gerrit.wikimedia.org/r/251969 (https://phabricator.wikimedia.org/T117780) (owner: 10Jforrester) [15:28:46] (03CR) 10Jforrester: [C: 032] Drop any beforeunload handlers when loading from existing wikitext [extensions/VisualEditor] (wmf/1.27.0-wmf.5) - 10https://gerrit.wikimedia.org/r/251717 (https://phabricator.wikimedia.org/T117769) (owner: 10Jforrester) [15:30:22] (03Abandoned) 10Jforrester: Revert "Use mw.loader.using instead of weird hacks to load OOjs UI on action=edit" [extensions/VisualEditor] (wmf/1.27.0-wmf.5) - 10https://gerrit.wikimedia.org/r/251733 (owner: 10Ori.livneh) [15:32:29] (03CR) 10jenkins-bot: [V: 04-1] Unset 'action' query parameter from veEditUri, which should always point to VE [extensions/VisualEditor] (wmf/1.27.0-wmf.5) - 10https://gerrit.wikimedia.org/r/251969 (https://phabricator.wikimedia.org/T117780) (owner: 10Jforrester) [15:32:39] Eurgh. [15:33:10] (03Merged) 10jenkins-bot: Unset 'action' query parameter from veEditUri, which should always point to VE [extensions/VisualEditor] (wmf/1.27.0-wmf.5) - 10https://gerrit.wikimedia.org/r/251969 (https://phabricator.wikimedia.org/T117780) (owner: 10Jforrester) [15:33:14] (03Merged) 10jenkins-bot: Drop any beforeunload handlers when loading from existing wikitext [extensions/VisualEditor] (wmf/1.27.0-wmf.5) - 10https://gerrit.wikimedia.org/r/251717 (https://phabricator.wikimedia.org/T117769) (owner: 10Jforrester) [15:40:12] (03PS2) 10Jforrester: WikiEditor integration: Only add VE switch button if VE is available [extensions/VisualEditor] (wmf/1.27.0-wmf.5) - 10https://gerrit.wikimedia.org/r/251651 (https://phabricator.wikimedia.org/T117968) [15:40:54] (03CR) 10Jforrester: [C: 032] "PS2: Rebase onto If86701ed." [extensions/VisualEditor] (wmf/1.27.0-wmf.5) - 10https://gerrit.wikimedia.org/r/251651 (https://phabricator.wikimedia.org/T117968) (owner: 10Jforrester) [15:43:07] (03CR) 10Jforrester: [C: 04-2] "This violates one of the principal rules of VE design (the toolbar's tools should always be present, but disabled if inappropriate in this" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/251834 (https://phabricator.wikimedia.org/T53154) (owner: 10Bartosz Dziewoński) [15:45:43] (03CR) 10jenkins-bot: [V: 04-1] WikiEditor integration: Only add VE switch button if VE is available [extensions/VisualEditor] (wmf/1.27.0-wmf.5) - 10https://gerrit.wikimedia.org/r/251651 (https://phabricator.wikimedia.org/T117968) (owner: 10Jforrester) [15:47:35] (03CR) 10Jforrester: [C: 032] "…" [extensions/VisualEditor] (wmf/1.27.0-wmf.5) - 10https://gerrit.wikimedia.org/r/251651 (https://phabricator.wikimedia.org/T117968) (owner: 10Jforrester) [15:50:25] (03Merged) 10jenkins-bot: WikiEditor integration: Only add VE switch button if VE is available [extensions/VisualEditor] (wmf/1.27.0-wmf.5) - 10https://gerrit.wikimedia.org/r/251651 (https://phabricator.wikimedia.org/T117968) (owner: 10Jforrester) [15:50:57] 10VisualEditor, 10VisualEditor-MediaWiki, 6Editing-Department, 10MediaWiki-Page-editing, and 3 others: API requests fail to load captcha information for some requests - https://phabricator.wikimedia.org/T118052#1793704 (10Jdforrester-WMF) [15:51:01] 10VisualEditor, 10VisualEditor-MediaWiki, 6Editing-Department, 10MediaWiki-Page-editing, and 3 others: API requests fail to load captcha information for some requests - https://phabricator.wikimedia.org/T118052#1790295 (10Jdforrester-WMF) [16:38:25] 10VisualEditor, 10Flow, 3Collaboration-Team-Current: Cannot paste category into editor in VE mode (master, beta, mw.org) - https://phabricator.wikimedia.org/T118191#1793855 (10Mattflaschen) [16:43:37] 10VisualEditor: "References list" should be an item in the Cite menu, not in the Insert one - https://phabricator.wikimedia.org/T118193#1793862 (10Elitre) 3NEW [16:44:01] 10VisualEditor: "References list" should be an item in the Cite menu, not in the Insert one - https://phabricator.wikimedia.org/T118193#1793870 (10Jdforrester-WMF) Why? It's not a citation. [16:44:23] 10VisualEditor: "References list" should be an item in the Cite menu, not in the Insert one - https://phabricator.wikimedia.org/T118193#1793871 (10Elitre) [16:45:17] 10VisualEditor: "References list" should be an item in the Cite menu, not in the Insert one - https://phabricator.wikimedia.org/T118193#1793862 (10Elitre) Because it has to do with adding citations, I guess. [16:46:29] 10VisualEditor, 6Collaboration-Team-Backlog, 10Flow, 10UI-Standardization, 7Design: Come up with a better re-usable UI concept for a button to switch editor-mode; the current one is confusing, and hard to discover - https://phabricator.wikimedia.org/T116417#1793877 (10Pginer-WMF) >>! In T116417#1770006,... [16:51:23] (03PS3) 10Jforrester: Restructure education popup code to work without overriding onSelect [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/251016 (https://phabricator.wikimedia.org/T117603) (owner: 10Alex Monk) [16:51:50] 10VisualEditor, 10VisualEditor-MediaWiki, 5WMF-deploy-2015-11-03_(1.27.0-wmf.5), 5WMF-deploy-2015-11-10_(1.27.0-wmf.6): Switching from WE to VE and saving, then navigating a different page causes an unsaved changes warning - https://phabricator.wikimedia.org/T117769#1793896 (10Jdforrester-WMF) [16:53:49] 10VisualEditor, 10VisualEditor-MediaWiki, 7Performance, 5WMF-deploy-2015-11-03_(1.27.0-wmf.5), 5WMF-deploy-2015-11-10_(1.27.0-wmf.6): Half a megabyte of JavaScript / CSS loading on view pages - https://phabricator.wikimedia.org/T118088#1793900 (10Jdforrester-WMF) p:5High>3Unbreak! [16:55:03] 10VisualEditor, 10Wikimedia-Site-Requests, 5Patch-For-Review: Enable Visual Editor in draft namespace in Persian Wikipedia - https://phabricator.wikimedia.org/T118060#1793913 (10Krenair) 5Open>3Resolved [16:56:10] (03PS1) 10Zfilipin: Added Rakefile [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/252004 (https://phabricator.wikimedia.org/T117993) [16:58:16] 10VisualEditor, 6Collaboration-Team-Backlog, 10Flow, 7Performance: VE preview on Flow pages take too long (1min+) to load in debug mode - https://phabricator.wikimedia.org/T118090#1793940 (10Mattflaschen) I would prefer it be faster too as a developer, but debug mode is not for normal usage. Also, this is... [16:58:23] 10VisualEditor, 7Performance: VE preview on Flow pages take too long (1min+) to load in debug mode - https://phabricator.wikimedia.org/T118090#1793942 (10Mattflaschen) [17:01:06] (03CR) 10jenkins-bot: [V: 04-1] Added Rakefile [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/252004 (https://phabricator.wikimedia.org/T117993) (owner: 10Zfilipin) [17:02:54] 10VisualEditor, 10VisualEditor-CopyPaste, 10VisualEditor-Tables: Table pasting problem in visual Editor - https://phabricator.wikimedia.org/T117859#1793952 (10Elitre) [17:02:56] 10VisualEditor, 7Performance: VE preview on Flow pages take too long (1min+) to load in debug mode - https://phabricator.wikimedia.org/T118090#1793954 (10Jdforrester-WMF) Per @Krinkle, you should not ever use debug mode and it's going away. Or something. [17:03:01] 10VisualEditor, 6Collaboration-Team-Backlog, 10Flow, 7Performance: VE preview on Flow pages take too long (1min+) to load in debug mode - https://phabricator.wikimedia.org/T118090#1793956 (10Mattflaschen) We might be able to not load (though a lot is accessible through keyboard shortcuts even though it app... [17:03:25] 10VisualEditor, 10VisualEditor-MediaWiki, 10WikiEditor: Switch to VE button presented on Create page but doesn't function - https://phabricator.wikimedia.org/T118152#1793963 (10Krenair) Not if they end up being fixed by the same change... [17:06:36] 10VisualEditor, 10VisualEditor-CopyPaste, 10VisualEditor-Tables: Table pasting problem in visual Editor - https://phabricator.wikimedia.org/T117859#1793964 (10NehalDaveND) @Elitre Thank you. Can you tell me this is a solvable problem or it is very long processed hard problem ? [17:11:35] (03PS2) 10Zfilipin: Added Rakefile [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/252004 (https://phabricator.wikimedia.org/T117993) [17:13:45] 10VisualEditor, 10VisualEditor-CopyPaste, 10VisualEditor-Tables: Table pasting problem in visual Editor - https://phabricator.wikimedia.org/T117859#1793980 (10Elitre) I don't know, I don't have MS Word and therefore can't try to reproduce, and I don't recall about recent changes that meant VE lost the abilit... [17:22:22] (03CR) 10Jforrester: "Still needs to audit all the uses of 'msie' to add 'edge' except where proven unnecessary." [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/221171 (owner: 10Paladox) [17:23:34] (03CR) 10Jforrester: [C: 031] "Good to merge once the rake CI job is enabled." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/252004 (https://phabricator.wikimedia.org/T117993) (owner: 10Zfilipin) [17:34:00] 10VisualEditor, 10VisualEditor-MediaWiki, 7Design, 7Epic: Provide a single edit tab which has both visual and wikitext modes and allows on-the-fly switching between them - https://phabricator.wikimedia.org/T102398#1794046 (10Jdforrester-WMF) >>! In T102398#1792341, @Risker wrote: > There is no benefit to t... [17:36:32] 10VisualEditor, 10VisualEditor-MediaWiki, 7Design, 7Epic: Provide a single edit tab which has both visual and wikitext modes and allows on-the-fly switching between them - https://phabricator.wikimedia.org/T102398#1794055 (10Jdforrester-WMF) >>! In T102398#1792429, @APerson wrote: > I guess I see why this... [17:37:02] (03CR) 10Zfilipin: "check experimental" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/252004 (https://phabricator.wikimedia.org/T117993) (owner: 10Zfilipin) [17:45:29] 10VisualEditor, 10VisualEditor-MediaWiki, 10WikiEditor: Switch to VE button presented on Create page but doesn't function - https://phabricator.wikimedia.org/T118152#1794096 (10matmarex) 5duplicate>3Open This is //so// not a duplicate, and should be fixed in VE regardless of RESTBase problems. [17:51:52] 10VisualEditor, 10VisualEditor-MediaWiki, 10WikiEditor: Switch to VE button presented on Create page but doesn't function - https://phabricator.wikimedia.org/T118152#1794123 (10Krenair) You mean special cased in VE because RESTBase can't handle it? [17:55:34] (03PS1) 10Bartosz Dziewoński: ve.init.mw.DesktopArticleTarget.init: Make switching to VE for new pages work [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/252014 (https://phabricator.wikimedia.org/T118152) [17:56:01] 10VisualEditor, 10VisualEditor-MediaWiki, 10WikiEditor, 5Patch-For-Review: Switch to VE button presented on Create page but doesn't function - https://phabricator.wikimedia.org/T118152#1794145 (10matmarex) p:5Triage>3Unbreak! This literally prevents users from starting new articles using VE. I think it... [18:00:01] (03CR) 10Alex Monk: [C: 04-1] "I don't think this is the proper way to solve the issue." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/252014 (https://phabricator.wikimedia.org/T118152) (owner: 10Bartosz Dziewoński) [18:00:43] 10VisualEditor, 10VisualEditor-MediaWiki, 10WikiEditor, 5Patch-For-Review: Switch to VE button presented on Create page but doesn't function - https://phabricator.wikimedia.org/T118152#1794171 (10Krenair) [18:18:41] 10VisualEditor, 10VisualEditor-MediaWiki, 7Design, 7Epic: Provide a single edit tab which has both visual and wikitext modes and allows on-the-fly switching between them - https://phabricator.wikimedia.org/T102398#1794230 (10John_Broughton) I'm going to repeat most of an earlier comment, because I think it... [18:38:02] 10VisualEditor, 10VisualEditor-MediaWiki, 7Design, 7Epic: Provide a single edit tab which has both visual and wikitext modes and allows on-the-fly switching between them - https://phabricator.wikimedia.org/T102398#1794292 (10matmarex) I think a single tab would be better than two, but I also think a prefer... [18:38:37] 10VisualEditor, 10VisualEditor-MediaWiki, 7Design, 7Epic: Provide a single edit tab which has both visual and wikitext modes and allows on-the-fly switching between them - https://phabricator.wikimedia.org/T102398#1794297 (10Jdforrester-WMF) >>! In T102398#1794292, @matmarex wrote: > I think a single tab w... [18:59:38] 10VisualEditor, 6Collaboration-Team-Backlog, 10Flow, 7Performance: VE preview on Flow pages take too long (1min+) to load in debug mode - https://phabricator.wikimedia.org/T118090#1794350 (10He7d3r) Well, how else can I find the source of bugs such as T110182 if not using debug mode? An URL like https://pt... [19:09:48] 10VisualEditor, 10VisualEditor-MediaWiki, 7Design, 7Epic: Provide a single edit tab which has both visual and wikitext modes and allows on-the-fly switching between them - https://phabricator.wikimedia.org/T102398#1794370 (10Jdforrester-WMF) >>! In T102398#1794230, @John_Broughton wrote: > I'm going to rep... [19:10:28] Kemayo: https://phabricator.wikimedia.org/T49344 is the relevant task about sub-documents, BTW. [19:10:39] 10VisualEditor, 10VisualEditor-MediaWiki, 7Design, 7Epic: Provide a single edit tab which has both visual and wikitext modes and allows on-the-fly switching between them - https://phabricator.wikimedia.org/T102398#1794372 (10Quiddity) [19:13:26] 10VisualEditor, 10VisualEditor-MediaWiki, 7Design, 7Epic: Provide a single edit tab which has both visual and wikitext modes and allows on-the-fly switching between them - https://phabricator.wikimedia.org/T102398#1794380 (10Jdforrester-WMF) Also, all these comments about design, how it should work //etc./... [19:14:43] 10VisualEditor, 10VisualEditor-MediaWiki, 7Design, 7Epic: Migrate wikis to use a single edit tab which has both visual and wikitext modes and allows on-the-fly switching between them - https://phabricator.wikimedia.org/T102398#1794381 (10Jdforrester-WMF) [19:27:08] 10VisualEditor, 10VisualEditor-MediaWiki, 7Epic, 5Patch-For-Review: Change VE integration to only use one edit tab - https://phabricator.wikimedia.org/T114530#1794403 (10Jdforrester-WMF) [19:27:30] (03CR) 10GWicke: [C: 031] "A quick fix like this would be good to stop this impacting users" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/252014 (https://phabricator.wikimedia.org/T118152) (owner: 10Bartosz Dziewoński) [19:40:50] edsanders: Review on https://gerrit.wikimedia.org/r/#/c/248369/ please? :-) [19:51:34] 10VisualEditor, 10VisualEditor-MediaWiki, 7Design, 7Epic: Migrate wikis to use a single edit tab which has both visual and wikitext modes and allows on-the-fly switching between them - https://phabricator.wikimedia.org/T102398#1794506 (10APerson) >>! In T102398#1794297, @Jdforrester-WMF wrote: >>>! In T102... [20:00:48] (03CR) 10Alex Monk: [C: 032] ve.init.mw.DesktopArticleTarget.init: Make switching to VE for new pages work [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/252014 (https://phabricator.wikimedia.org/T118152) (owner: 10Bartosz Dziewoński) [20:08:06] (03CR) 10jenkins-bot: [V: 04-1] ve.init.mw.DesktopArticleTarget.init: Make switching to VE for new pages work [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/252014 (https://phabricator.wikimedia.org/T118152) (owner: 10Bartosz Dziewoński) [20:30:42] 10VisualEditor, 10VisualEditor-MediaWiki, 7Design, 7Epic: Migrate wikis to use a single edit tab which has both visual and wikitext modes and allows on-the-fly switching between them - https://phabricator.wikimedia.org/T102398#1794545 (10Jdforrester-WMF) >>! In T102398#1794506, @APerson wrote: >>>! In T102... [21:10:20] 10VisualEditor, 10Flow, 3Collaboration-Team-Current: Cannot paste category into editor in VE mode (master, beta, mw.org) - https://phabricator.wikimedia.org/T118191#1794577 (10Etonkovidova) The same problem with non-Flow page - checked in betalabs. [22:17:07] (03CR) 10Alex Monk: [C: 032] ve.init.mw.DesktopArticleTarget.init: Make switching to VE for new pages work [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/252014 (https://phabricator.wikimedia.org/T118152) (owner: 10Bartosz Dziewoński) [22:21:13] (03CR) 10jenkins-bot: [V: 04-1] ve.init.mw.DesktopArticleTarget.init: Make switching to VE for new pages work [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/252014 (https://phabricator.wikimedia.org/T118152) (owner: 10Bartosz Dziewoński) [22:23:13] (03CR) 10Alex Monk: [C: 032] ve.init.mw.DesktopArticleTarget.init: Make switching to VE for new pages work [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/252014 (https://phabricator.wikimedia.org/T118152) (owner: 10Bartosz Dziewoński) [22:25:25] Krenair: Having fun? [22:27:30] Something like that [22:28:08] 10VisualEditor, 10VisualEditor-MediaWiki, 7Design, 7Epic: Migrate wikis to use a single edit tab which has both visual and wikitext modes and allows on-the-fly switching between them - https://phabricator.wikimedia.org/T102398#1794703 (10RandomDSdevel) >>! In T102398#1794297, @Jdforrester-WMF wrote: >>>! I... [22:28:16] (03CR) 10jenkins-bot: [V: 04-1] ve.init.mw.DesktopArticleTarget.init: Make switching to VE for new pages work [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/252014 (https://phabricator.wikimedia.org/T118152) (owner: 10Bartosz Dziewoński) [22:28:26] what the hell is wrong with jenkins today [22:28:35] can't we force-merge this? [22:29:40] (03CR) 10Jforrester: [C: 032] ve.init.mw.DesktopArticleTarget.init: Make switching to VE for new pages work [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/252014 (https://phabricator.wikimedia.org/T118152) (owner: 10Bartosz Dziewoński) [22:29:44] MatmaRex: No. [22:31:19] new means of enforcing code freeze, i guess. [22:32:05] * James_F grins. [22:34:54] (03CR) 10jenkins-bot: [V: 04-1] ve.init.mw.DesktopArticleTarget.init: Make switching to VE for new pages work [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/252014 (https://phabricator.wikimedia.org/T118152) (owner: 10Bartosz Dziewoński) [22:35:41] At what point do we consider jenkins too disruptive to our work with this test voting? [22:36:27] (03CR) 10Alex Monk: [C: 032] ve.init.mw.DesktopArticleTarget.init: Make switching to VE for new pages work [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/252014 (https://phabricator.wikimedia.org/T118152) (owner: 10Bartosz Dziewoński) [22:37:06] Krenair: The tests would pass if we e.g. emptied the MF repo. [22:37:16] Krenair: Maybe not this time around… [22:40:07] (03CR) 10jenkins-bot: [V: 04-1] ve.init.mw.DesktopArticleTarget.init: Make switching to VE for new pages work [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/252014 (https://phabricator.wikimedia.org/T118152) (owner: 10Bartosz Dziewoński) [22:42:34] (03CR) 10Alex Monk: [C: 032 V: 032] "Meh." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/252014 (https://phabricator.wikimedia.org/T118152) (owner: 10Bartosz Dziewoński) [22:44:16] Krenair: Tsk. :-) [22:44:26] Yeah, I gave up in the end. [22:44:56] One day I'll learn how the CI system works and submit a commit to make that test non-voting until someone who can fix it does. [22:48:16] 10VisualEditor, 6Collaboration-Team-Backlog, 10Flow, 7Performance: VE preview on Flow pages take too long (1min+) to load in debug mode - https://phabricator.wikimedia.org/T118090#1794739 (10Mattflaschen) >>! In T118090#1794350, @He7d3r wrote: > Well, how else can I find the source of bugs such as T110182... [22:48:20] (03PS1) 10Jforrester: ve.init.mw.DesktopArticleTarget.init: Make switching to VE for new pages work [extensions/VisualEditor] (wmf/1.27.0-wmf.5) - 10https://gerrit.wikimedia.org/r/252123 (https://phabricator.wikimedia.org/T118152) [22:48:29] (Here we go again.) [22:49:55] edsanders: https://gerrit.wikimedia.org/r/#/c/251016/ [22:50:44] (03CR) 10Esanders: [C: 032] Restructure education popup code to work without overriding onSelect [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/251016 (https://phabricator.wikimedia.org/T117603) (owner: 10Alex Monk) [22:51:37] 10VisualEditor, 10VisualEditor-MediaWiki: Education pop-ups work badly in mobile, in some cases being impossible to close - https://phabricator.wikimedia.org/T117603#1794743 (10Jdforrester-WMF) 5Open>3Resolved [22:51:54] (03CR) 10jenkins-bot: [V: 04-1] ve.init.mw.DesktopArticleTarget.init: Make switching to VE for new pages work [extensions/VisualEditor] (wmf/1.27.0-wmf.5) - 10https://gerrit.wikimedia.org/r/252123 (https://phabricator.wikimedia.org/T118152) (owner: 10Jforrester) [22:52:36] Am I imagining things or is it worse than normal? [22:54:08] (03CR) 10Esanders: [C: 032] Close inspectors before executing a ve.ui.Tool command [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/250646 (https://phabricator.wikimedia.org/T76717) (owner: 10DLynch) [22:54:39] Krenair: It's worse than normal. [22:55:26] (03CR) 10jenkins-bot: [V: 04-1] Restructure education popup code to work without overriding onSelect [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/251016 (https://phabricator.wikimedia.org/T117603) (owner: 10Alex Monk) [22:55:56] (03PS2) 10Esanders: Move binarySearch to OOJS [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/246844 [22:56:39] Krenair: hey, i know where it could be disabled, i think. i couldn't merge/deploy, though. [22:56:46] * James_F sighs. [22:57:07] (03CR) 10Esanders: "The failure is JSCS" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/251835 (owner: 10Bartosz Dziewoński) [22:58:01] (03CR) 10Bartosz Dziewoński: "Yeah, I'm saying JSCS is wrong, sorry." [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/251835 (owner: 10Bartosz Dziewoński) [22:58:15] (03CR) 10Esanders: ve.ui.Sequence: Allow sequences to insert content (031 comment) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/251835 (owner: 10Bartosz Dziewoński) [22:58:32] (03Merged) 10jenkins-bot: Close inspectors before executing a ve.ui.Tool command [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/250646 (https://phabricator.wikimedia.org/T76717) (owner: 10DLynch) [22:58:55] edsanders: Krinkle is going to complain about that. he really hates trailing line comments, last i asked. [22:59:10] i'm not sure if this preference got encoded into our jscs config. ;) [22:59:19] (03CR) 10jenkins-bot: [V: 04-1] Move binarySearch to OOJS [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/246844 (owner: 10Esanders) [23:00:15] (03CR) 10Jforrester: [C: 032] Restructure education popup code to work without overriding onSelect [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/251016 (https://phabricator.wikimedia.org/T117603) (owner: 10Alex Monk) [23:00:16] MatmaRex: It didn't, but should. Yeah, in this case, just add a line comment over the parmeter like // Explain \b param, [23:00:18] \n [23:00:39] Im surprised JSCS complains about use of /* */ inline though [23:00:54] (03PS1) 10DLynch: Watch for hashchance on the demo [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/252124 [23:00:57] I think because it's the first thing on that line [23:01:39] Krinkle: what you're saying is that this is obviously a JSCS bug. :) [23:02:59] 10VisualEditor: Cannot paste category into editor in VE mode (master, beta, mw.org) - https://phabricator.wikimedia.org/T118191#1794775 (10Mattflaschen) [23:03:09] (03PS2) 10DLynch: Watch for hashchange on the demo [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/252124 [23:03:13] (03CR) 10jenkins-bot: [V: 04-1] Watch for hashchange on the demo [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/252124 (owner: 10DLynch) [23:03:45] Heh, I got my fix in before jenkins could even tell me I needed it. [23:04:06] Kemayo: :-) [23:05:06] (03CR) 10Jforrester: [C: 032] Surface drop: Show branch node drop markers for file drop [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/247586 (https://phabricator.wikimedia.org/T115859) (owner: 10Esanders) [23:06:16] (03CR) 10Bartosz Dziewoński: ve.ui.Sequence: Allow sequences to insert content (031 comment) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/251835 (owner: 10Bartosz Dziewoński) [23:09:18] (03PS2) 10Jforrester: ve.ui.Sequence: Allow sequences to insert content [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/251835 (owner: 10Bartosz Dziewoński) [23:09:20] (03Merged) 10jenkins-bot: Surface drop: Show branch node drop markers for file drop [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/247586 (https://phabricator.wikimedia.org/T115859) (owner: 10Esanders) [23:09:45] (03CR) 10Jforrester: ve.ui.Sequence: Allow sequences to insert content (031 comment) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/251835 (owner: 10Bartosz Dziewoński) [23:11:26] 10VisualEditor: an unnecessary warning is shown when saving a page in mobile VisualEditor using Firefox for Android - https://phabricator.wikimedia.org/T116537#1794810 (10Krenair) I just made http://en.wikipedia.beta.wmflabs.org/w/index.php?title=UserMergefdiixo&diff=prev&oldid=285443 without a warning on Firefox [23:11:32] (03PS3) 10Bartosz Dziewoński: ve.ui.Sequence: Allow sequences to insert content [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/251835 [23:11:54] (03CR) 10Bartosz Dziewoński: ve.ui.Sequence: Allow sequences to insert content (031 comment) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/251835 (owner: 10Bartosz Dziewoński) [23:12:53] (03CR) 10Esanders: [C: 032] Watch for hashchange on the demo [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/252124 (owner: 10DLynch) [23:14:50] (03CR) 10Jforrester: [C: 04-1] "Eww." [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/251835 (owner: 10Bartosz Dziewoński) [23:16:07] (03CR) 10Bartosz Dziewoński: "I like this way better. I could also do "/* noAutoSelect =*/true,", which almost looks like named function parameters. Or we could wrap th" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/251835 (owner: 10Bartosz Dziewoński) [23:16:18] (03Merged) 10jenkins-bot: Watch for hashchange on the demo [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/252124 (owner: 10DLynch) [23:16:40] (03CR) 10Jforrester: "I think comments touching code looks terrible." [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/251835 (owner: 10Bartosz Dziewoński) [23:17:09] (03PS4) 10Jforrester: MediaSizeWidget: Allow an user to really use a custom size [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/243979 (owner: 10Florianschmidtwelzow) [23:18:03] (03PS4) 10Jforrester: Restructure education popup code to work without overriding onSelect [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/251016 (https://phabricator.wikimedia.org/T117603) (owner: 10Alex Monk) [23:18:11] (03CR) 10Jforrester: [C: 032] Restructure education popup code to work without overriding onSelect [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/251016 (https://phabricator.wikimedia.org/T117603) (owner: 10Alex Monk) [23:18:50] 10VisualEditor, 10VisualEditor-MediaWiki: Nothing happens when clicking on the glowing blue (education) dots in Firefox 41/Windows 7 - https://phabricator.wikimedia.org/T118219#1794818 (10Whatamidoing-WMF) 3NEW a:3Krenair [23:20:12] 10VisualEditor, 10VisualEditor-MediaWiki: Nothing happens when clicking on the glowing blue (education) dots in Firefox 41/Windows 7 - https://phabricator.wikimedia.org/T118219#1794827 (10Jdforrester-WMF) a:5Krenair>3None [23:20:19] huh [23:20:25] ^ guess there could be a JS error going on there [23:20:36] I imagine whatever it is will be changed by the commit we're just sending through now though [23:21:15] Probably. [23:21:18] James_F: i'll file a jscs bug about that, btw [23:22:13] (03CR) 10jenkins-bot: [V: 04-1] Restructure education popup code to work without overriding onSelect [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/251016 (https://phabricator.wikimedia.org/T117603) (owner: 10Alex Monk) [23:23:10] (03Merged) 10jenkins-bot: Restructure education popup code to work without overriding onSelect [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/251016 (https://phabricator.wikimedia.org/T117603) (owner: 10Alex Monk) [23:23:36] MatmaRex: Hmm. Yeah, though they might say the 'bug' is with jscs-preset-wikimedia's desire. [23:24:16] James_F: then they'd be wrong [23:26:19] MatmaRex: Sure. [23:27:17] https://github.com/jscs-dev/node-jscs/issues/1968 [23:27:38] (03CR) 10Bartosz Dziewoński: "https://github.com/jscs-dev/node-jscs/issues/1968" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/251835 (owner: 10Bartosz Dziewoński) [23:29:14] 10VisualEditor, 5Patch-For-Review: Write a scheduler singleton to execute code after some other code - https://phabricator.wikimedia.org/T117620#1794845 (10Jdforrester-WMF) [23:29:16] 10VisualEditor, 10VisualEditor-EditingTools, 5Patch-For-Review: [Regression wmf12] Uncaught Error: “Offset could not be translated to a DOM element and offset: 2” when selecting a heading format with language inspector open. - https://phabricator.wikimedia.org/T76717#1794844 (10Jdforrester-WMF) [23:30:33] (03CR) 10Jforrester: [C: 031] "Fine." [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/251835 (owner: 10Bartosz Dziewoński) [23:31:46] 10VisualEditor, 10VisualEditor-MediaWiki: Nothing happens when clicking on the glowing blue (education) dots in Firefox 41/Windows 7 - https://phabricator.wikimedia.org/T118219#1794850 (10Krenair) We just changed how this works in T117603. Were you able to reproduce the issue? If not, can we ask Risker to chec... [23:32:14] 10VisualEditor, 10VisualEditor-MediaWiki: Nothing happens when clicking on the glowing blue (education) dots in Firefox 41/Windows 7 - https://phabricator.wikimedia.org/T118219#1794852 (10Jdforrester-WMF) 5Open>3stalled [23:41:41] 10VisualEditor, 10VisualEditor-MediaWiki: Be able to switch editors after starting to edit a section - https://phabricator.wikimedia.org/T117716#1794864 (10Whatamidoing-WMF) This is a page-blanking bug. Steps to reproduce: 1) Click "Edit source" on a section in a long page. 2) Switch to the visual editor....