[00:18:35] (03CR) 10Esanders: [C: 04-1] "I agree with James. We don't do this anywhere else, and it breaks the alignment so makes it harder to read. Use either:" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/251835 (owner: 10Bartosz Dziewoński) [00:19:06] (03CR) 10Bartosz Dziewoński: "grumblegrumble" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/251835 (owner: 10Bartosz Dziewoński) [00:20:17] (03PS4) 10Bartosz Dziewoński: ve.ui.Sequence: Allow sequences to insert content [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/251835 [00:21:36] (03CR) 10Esanders: Provide a tool to insert a signature in namespaces that need it (031 comment) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/251834 (https://phabricator.wikimedia.org/T53154) (owner: 10Bartosz Dziewoński) [00:23:05] (03CR) 10Bartosz Dziewoński: "James, we can do this differently – always display the signature tool if, on the given wiki, VE is enabled in any namespaces that want sig" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/251834 (https://phabricator.wikimedia.org/T53154) (owner: 10Bartosz Dziewoński) [00:24:00] MatmaRex: Do you mean "… on other wikis"? [00:24:18] (03PS1) 10Krinkle: Enable new module versioning for VisualEditorDataModule [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/252138 [00:24:34] James_F: no. let me rephrase [00:24:50] 10VisualEditor, 10VisualEditor-MediaWiki: Be able to switch editors after starting to edit a section - https://phabricator.wikimedia.org/T117716#1794913 (10Krenair) That sounds like T117713, @Whatamidoing-WMF [00:25:30] Krenair: Sorry, yeah, mentioned in IM not on-Phab. [00:25:58] James_F: if a wiki has no namespaces that have both VE and signatures, this tool would not appear at all. if a wiki has such namespaces, the tool would appear in them, and it would appear as disabled in all other namespaces. [00:26:14] James_F: this would be consistent within a wiki (but not necessarily across wikis), like other tools. [00:26:33] (since available tools already depend on what extensions a wiki has installed.) [00:26:35] (03PS2) 10Krinkle: Enable new module versioning for VisualEditorDataModule [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/252138 [00:28:00] (03CR) 10Esanders: [C: 031] "Admittedly it's a ugly solution to a problem VE wasn't designed to fix, but I don't think having a tool appear in a certain namespace is t" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/251834 (https://phabricator.wikimedia.org/T53154) (owner: 10Bartosz Dziewoński) [00:28:08] MatmaRex: Hmm. Yeah. But I don't think a "signature" button should be hidden in the insert menu if you're editing a talk/signed page. [00:28:18] MatmaRex: Also, we really need DL editing first before we can enable this sanely. [00:28:38] (03CR) 10Esanders: [C: 032] lib: Add AUTHORS, LICENSE and README files for libraries missing them [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/251682 (owner: 10Jforrester) [00:28:41] Thanks edsanders. [00:29:11] (03CR) 10Esanders: [C: 032] ve.ui.Sequence: Allow sequences to insert content [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/251835 (owner: 10Bartosz Dziewoński) [00:29:11] James_F: people could/should just use * instead of :. it's nicer. and i think the use cases i've seen were more like voting, or signups, than serious discussion [00:29:20] MatmaRex: Should, but they don't. [00:29:59] MatmaRex: The only wiki this would impact without changing config would be with Wikidata. [00:30:17] MatmaRex: (Where it's enabled in the Project: namespace.) [00:30:24] (03CR) 10Esanders: "T111081" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/221171 (owner: 10Paladox) [00:30:36] James_F: hmm, do they have the $wgExtraSigNamespaces thing set up there? [00:30:50] MatmaRex: Umm. [00:30:52] * James_F checks. [00:31:16] MatmaRex: https://www.wikidata.org/w/index.php?title=Wikidata:Database_reports/Constraint_violations/P1977&action=edit has a sign button. [00:31:17] James_F: by default, the only namespaces that "wantSignatures" is all talk ones, i think. [00:31:18] MatmaRex: So… yes. [00:31:25] okay, yeah, so probably. [00:31:38] (Note it also has VE, if you've got the BF enabled.) [00:32:52] Krinkle: Is there a task for https://gerrit.wikimedia.org/r/#/c/252138/ (or the issue more generally)? Sounds sane, but it'd be nice to have it validated by other uses. :_) [00:33:55] 10VisualEditor, 7Browser-Support-Internet-Explorer, 7Browser-Support-Microsoft-Edge, 7Technical-Debt: Check if IE hacks are still required in Edge - https://phabricator.wikimedia.org/T111081#1794922 (10Esanders) https://www.mediawiki.org/wiki/User:Catrope/IE_bugs [00:34:44] MatmaRex: Fine. I'll +2 if you change the way it works to be enabled/disabled rather than present/not-present as you suggested. [00:35:35] (03Merged) 10jenkins-bot: lib: Add AUTHORS, LICENSE and README files for libraries missing them [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/251682 (owner: 10Jforrester) [00:35:37] (03Merged) 10jenkins-bot: ve.ui.Sequence: Allow sequences to insert content [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/251835 (owner: 10Bartosz Dziewoński) [00:35:45] James_F: can you comment? will do tomorrow [00:35:49] OK. [00:36:35] (03CR) 10Jforrester: "I'm OK with it being enabled/disabled per namespace, and shown on all pages on a wiki if it's ever possible to be disabled, per MatmaRex's" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/251834 (https://phabricator.wikimedia.org/T53154) (owner: 10Bartosz Dziewoński) [00:43:52] James_F: It was implemented as part of T94074 last quarter. It is currently part of the wider T102578 for this quarter. [00:44:15] James_F: I switched VE a while back with https://github.com/wikimedia/mediawiki-extensions-VisualEditor/commit/2e050ff4981b1abb00ce955d022ed02490baa129 [00:44:25] * James_F nods. [00:44:29] But this logic of using getScript() is now part of core. [00:44:42] * Krinkle adds to commit msg [00:44:47] Should it be tagged as T102578 ? [00:44:51] Thank you. [00:44:56] (Also, yay.) [00:46:15] 10VisualEditor, 5Patch-For-Review, 7Technical-Debt: Write a scheduler singleton to execute code after some other code - https://phabricator.wikimedia.org/T117620#1794926 (10Jdforrester-WMF) [00:46:39] (03PS3) 10Krinkle: Enable new module versioning for VisualEditorDataModule [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/252138 [00:46:56] (03PS4) 10Krinkle: Enable new module versioning for VisualEditorDataModule [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/252138 (https://phabricator.wikimedia.org/T102578) [00:47:03] 10VisualEditor, 10VisualEditor-EditingTools: Uncaught Error: “Offset could not be translated to a DOM element and offset: 2” when selecting a heading format with language inspector open. - https://phabricator.wikimedia.org/T76717#1794931 (10Jdforrester-WMF) 5Open>3Resolved a:3DLynch [00:47:08] 10VisualEditor, 10VisualEditor-EditingTools, 5WMF-deploy-2015-11-10_(1.27.0-wmf.6): Uncaught Error: “Offset could not be translated to a DOM element and offset: 2” when selecting a heading format with language inspector open. - https://phabricator.wikimedia.org/T76717#818828 (10Jdforrester-WMF) [00:50:47] Krinkle: Is getGitHeadHash() done in core the same way? [00:50:52] (03CR) 10Jforrester: [C: 031] Enable new module versioning for VisualEditorDataModule [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/252138 (https://phabricator.wikimedia.org/T102578) (owner: 10Krinkle) [00:51:05] James_F: unchanged? [00:51:18] Krinkle: Yes, but nearly-identical code. [00:51:26] James_F: Identical to what [00:51:28] Krinkle: Wondering if that can be killed/simplified in a later commit. [00:52:05] Krinkle: To what I imagine every other one looks like? Ignore if I'm talking nonsense. [00:52:35] James_F: This is getting the revision of the VE extension isntalled, aka Special:Version kind of thing. [00:52:46] Yeah. [00:52:55] $this->gitHeadHash = $this->gitInfo->getHeadSHA1(); [00:52:59] Aside from the generic GitInfo class (which VE data module uses) there is no similar code for it in core. [00:53:05] Oh, OK. [00:53:08] * James_F shrugs. [00:53:11] Certainly not in RL. [00:53:17] Maybe it should be the default implementation in RL? [00:53:28] Ve data module doesn't track it to track changes. It tracks it before the UI displays it. [00:53:33] * James_F nods. [00:53:42] s/RL/MW/ [00:53:44] so it tracks it for the text that it is. [00:54:11] James_F: It is already in MediaWiki core? [00:54:24] There is a single line in the ve data module that calls it, getHeadSHA1 [00:54:35] Which part would prefer is not there? [00:55:00] Maybe I'm missing the obvious, assume I'm an idiot please :) [00:56:43] Krinkle: VE is implementing a function called getGitHeadHash. This is for core to call, yes? It in turn turns around and calls core's gitInfo with no custom work. Surely we could solve things by having the default inheritance be of a version of getGitHeadHash which does what VE's one does, so that VE doesn't need to implement. [00:57:01] James_F: No, it is not for core to call. [00:57:14] I thought you said Special:Version calls it? [00:57:27] James_F: It is for ve.data.id = getGitHeadHash() for the ve toolbar to display it. It tracks it because it needs to invalidate ve.datamodule if it changes. [00:57:52] Oh, and this isn't a common thing? [00:57:57] I was merely clarifying that this is not the module version, in case you confused it with that. So was explaining it is the extension version, kind of like Special:Version. [00:58:01] No, nobody does this :P [00:58:07] Doesn't SyntaxHighlighter have the same thing? [00:58:11] How does it invalidate? [00:58:26] SyntaxHighlighter does not display its git hash to end users on an output page in any way. [00:58:40] Special:Version doesn't use this at all? [00:58:45] No, it does not. [00:59:02] Where does it get its data from? [00:59:04] We don't have an entry for VisualEditorDataModule-resourceloader on Special:Version [00:59:17] 10VisualEditor: "References list" should be an item in the Cite menu, not in the Insert one - https://phabricator.wikimedia.org/T118193#1794953 (10Esanders) At the moment with Citoid enabled there is no cite menu, just a button. It's certainly going to be used a lot less than Cite (only on page creation) so does... [00:59:21] And even if we would, it would not display this. [00:59:21] Ah, just for the overall thing? [00:59:33] Kk. Ignore me. :-) [00:59:37] Because getGitHeadHash returns the git hash of mediawiki/extensions/VisualEditor.git [00:59:59] which is included here because it exports it to ve.data in JS so that the VE UI can display it in MWPopupTool [01:00:18] It is not tracking VisualEditorDataModule itself. [01:06:01] (03PS1) 10Krinkle: Remove redundant VisualEditorDataModule::getGitHeadHash static cache [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/252143 [01:07:38] (03PS2) 10Krinkle: Remove redundant VisualEditorDataModule::getGitHeadHash static cache [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/252143 [01:07:45] In fact, we don't even need the method :) [01:08:10] Krinkle: Ha. [01:31:42] 10VisualEditor, 10VisualEditor-MediaWiki: Auto edit conflict on VE is not warned - https://phabricator.wikimedia.org/T116278#1794999 (10Krenair) 5Open>3Invalid a:3Krenair I guess it's not obvious what's really going on here. VisualEditor doesn't detect edit conflicts itself - we just send off data to the... [01:36:34] (03PS1) 10Jforrester: Update VE core submodule to master (6f8f3db) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/252146 [01:37:38] 10VisualEditor, 10VisualEditor-MediaWiki: Auto edit conflict on VE is not warned - https://phabricator.wikimedia.org/T116278#1795007 (10Krenair) Oh, and to make things slightly more confusing - the "saving user is the last editor of that page" check will never suppress full-page self-conflicts with anonymous u... [01:39:08] James_F: http://i.imgur.com/ooGQ6En.png - the right ring is not aligned with the ring it emits from [01:39:15] offset to the right [01:39:37] I have a feeling there's a task about that somewhere [01:39:39] Krinkle: Yes, I know, marked as Low. [01:39:55] James_F: OK. Note this is not the same I filed last week [01:40:00] that was fixed I see [01:40:10] (the cut-off) [01:40:19] Krinkle: Yeah. [01:40:24] OK :) [01:40:51] (03CR) 10jenkins-bot: [V: 04-1] Update VE core submodule to master (6f8f3db) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/252146 (owner: 10Jforrester) [01:42:13] (03CR) 10Jforrester: "recheck" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/252146 (owner: 10Jforrester) [01:42:26] * James_F grumbles at mwext-VisualEditor-qunit. [01:42:40] (03CR) 10Esanders: [C: 032] Update VE core submodule to master (6f8f3db) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/252146 (owner: 10Jforrester) [01:42:57] Krinkle: Could you look at https://gerrit.wikimedia.org/r/252130 (CI change for VE) and comment/+2? [01:44:11] (03PS6) 10DLynch: Fix deletion inside a structural node at start/end of document [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/107142 (https://bugzilla.wikimedia.org/50250) (owner: 10Esanders) [01:45:57] (03Merged) 10jenkins-bot: Update VE core submodule to master (6f8f3db) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/252146 (owner: 10Jforrester) [01:50:09] James_F: My only concern there is T116258 [01:50:14] https://phabricator.wikimedia.org/T116258 [01:50:24] Which seems significantly more prominent when run along with other tests. [01:50:44] and we'll need to closely check that the group execution is indeed accurate and covering the same as the solo run [01:52:58] James_F: mooeypoo: https://gerrit.wikimedia.org/r/#/c/243068/ - I can amend if you like. [01:53:03] let me know [02:19:43] 10VisualEditor, 6Multimedia, 7Design: Make it clear in VE (hover state?) when a media file is being dragged in that shows it will do something - https://phabricator.wikimedia.org/T115859#1795040 (10matmarex) [02:31:39] Krinkle: If you could that'd be great. [02:35:32] 10VisualEditor, 7Technical-Debt, 5WMF-deploy-2015-11-10_(1.27.0-wmf.6): Write a scheduler singleton to execute code after some other code - https://phabricator.wikimedia.org/T117620#1795046 (10Jdforrester-WMF) 5Open>3Resolved [03:00:17] 10VisualEditor, 10VisualEditor-MediaWiki: Nothing happens when clicking on the glowing blue (education) dots in Firefox 41/Windows 7 - https://phabricator.wikimedia.org/T118219#1795062 (10Krenair) I discussed this with Risker. There doesn't seem to be anything coming up in the JS console. She observed that som... [03:58:50] (03PS8) 10Jforrester: [WIP] MW test cases for new structural deletion logic [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/98515 (https://phabricator.wikimedia.org/T52250) (owner: 10Esanders) [03:59:16] (03CR) 10Jforrester: "PS8 is just a rebase. Not tested with the new version of I1ca31b2c yet." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/98515 (https://phabricator.wikimedia.org/T52250) (owner: 10Esanders) [04:01:43] (03CR) 10jenkins-bot: [V: 04-1] [WIP] MW test cases for new structural deletion logic [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/98515 (https://phabricator.wikimedia.org/T52250) (owner: 10Esanders) [06:48:27] 10VisualEditor, 10VisualEditor-MediaWiki: Nothing happens when clicking on the glowing blue (education) dots in Firefox 41/Windows 7 - https://phabricator.wikimedia.org/T118219#1795165 (10Risker) (copied from the enwiki feedback page, so you'll have it here) I did some work tonight with Krenair (thanks for t... [07:47:20] 10VisualEditor, 10VisualEditor-MediaWiki, 7Epic, 5Patch-For-Review: Change VE integration to only use one edit tab - https://phabricator.wikimedia.org/T114530#1795196 (10Alsee) I've used Flow quite a bit and //Remember last editor I used// is utterly awful. It is extremely bad UX design to effectively code... [09:50:16] 10VisualEditor, 10VisualEditor-CopyPaste, 10VisualEditor-Tables: Table pasting problem in visual Editor - https://phabricator.wikimedia.org/T117859#1795260 (10Aklapper) a:5Aklapper>3None @NehalDaveND: Hmm, [[ https://www.mediawiki.org/wiki/Phabricator/Project_management#Assigning_tasks | why did you assi... [10:03:52] 10VisualEditor, 10VisualEditor-CopyPaste, 10VisualEditor-Tables: Table pasting problem in visual Editor - https://phabricator.wikimedia.org/T117859#1795271 (10NehalDaveND) I think you forgot me. I talked to you at test.wiki. That same reason. [10:04:13] 10VisualEditor, 10VisualEditor-CopyPaste, 10VisualEditor-Tables: Table pasting problem in visual Editor - https://phabricator.wikimedia.org/T117859#1795273 (10NehalDaveND) a:3Catrope [10:24:41] (03PS3) 10Hashar: Added Rakefile [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/252004 (https://phabricator.wikimedia.org/T117993) (owner: 10Zfilipin) [10:25:24] 10VisualEditor, 10Wikimedia-Site-Requests: Enable Visual Editor in draft namespace in Persian Wikipedia - https://phabricator.wikimedia.org/T118060#1795288 (10revi) [10:39:36] 10VisualEditor: editing a section in the source editor, moving to VE, and saving deletes all other sections - https://phabricator.wikimedia.org/T118233#1795317 (10Amire80) 3NEW [10:54:51] (03CR) 10Hashar: [C: 032] Added Rakefile [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/252004 (https://phabricator.wikimedia.org/T117993) (owner: 10Zfilipin) [10:58:58] (03Merged) 10jenkins-bot: Added Rakefile [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/252004 (https://phabricator.wikimedia.org/T117993) (owner: 10Zfilipin) [11:15:07] (03PS1) 10Hashar: Added Rakefile [extensions/VisualEditor] (REL1_26) - 10https://gerrit.wikimedia.org/r/252185 (https://phabricator.wikimedia.org/T117993) [11:29:20] (03CR) 10Hashar: [C: 032] Added Rakefile [extensions/VisualEditor] (REL1_26) - 10https://gerrit.wikimedia.org/r/252185 (https://phabricator.wikimedia.org/T117993) (owner: 10Hashar) [11:33:07] (03Merged) 10jenkins-bot: Added Rakefile [extensions/VisualEditor] (REL1_26) - 10https://gerrit.wikimedia.org/r/252185 (https://phabricator.wikimedia.org/T117993) (owner: 10Hashar) [11:40:06] 10VisualEditor: VE saturates CPU when losing internet connection and then trying an AJAX load - https://phabricator.wikimedia.org/T118001#1795462 (10Krenair) I opened VE, made changes, tried to switch to wikitext editing, disabled my network connection, and selected 'Keep changes'. It did not make my browser try... [11:42:35] 10VisualEditor: VE saturates CPU when losing internet connection and then trying an AJAX load - https://phabricator.wikimedia.org/T118001#1795466 (10Krenair) Also, when the switch confirmation dialog gets stuck due to loss of internet connection, if you press the 'keep changes' button again it will retry. I have... [11:52:20] (03CR) 10Hashar: "recheck" [extensions/VisualEditor] (wmf/1.27.0-wmf.5) - 10https://gerrit.wikimedia.org/r/252123 (https://phabricator.wikimedia.org/T118152) (owner: 10Jforrester) [11:57:22] 10VisualEditor, 10VisualEditor-MediaWiki, 7Epic, 5Patch-For-Review: Change VE integration to only use one edit tab - https://phabricator.wikimedia.org/T114530#1795484 (10He7d3r) >>! In T114530#1795196, @Alsee wrote: > I've used Flow quite a bit and //Remember last editor I used// is utterly awful. Indeed. [12:57:21] 10VisualEditor: [Regression wmf.5] After opening one of the educational pop-ups, the pulsating dot disappears from other educational pop up too - https://phabricator.wikimedia.org/T117638#1795563 (10Krenair) This is a regression? I think it's been like this since the feature was introduced. [12:57:50] 10VisualEditor: After opening one of the educational pop-ups, the pulsating dot disappears from other educational pop up too - https://phabricator.wikimedia.org/T117638#1795564 (10Krenair) [12:58:11] 10VisualEditor, 10VisualEditor-MediaWiki: The text "Editing" is appearing before the article title when I switch to VisualEditor and it also stays after saving the page - https://phabricator.wikimedia.org/T117643#1795566 (10Krenair) [13:54:44] (03PS1) 10Alex Monk: Fix updating of display title upon save [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/252217 (https://phabricator.wikimedia.org/T117643) [13:54:46] (03PS1) 10Alex Monk: When switching from WE to VE, parse display title on the server and replace the title shown [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/252218 (https://phabricator.wikimedia.org/T117643) [15:51:05] 10VisualEditor, 10VisualEditor-Tables: Visual Editor's table support should allow you to drag rows - https://phabricator.wikimedia.org/T118269#1795993 (10MarkAHershberger) 3NEW [15:52:11] 10VisualEditor, 10VisualEditor-Tables: Visual Editor's table support should allow you to drag rows - https://phabricator.wikimedia.org/T118269#1796008 (10Krenair) [15:52:13] 10VisualEditor, 10VisualEditor-Tables, 7notice, 7user-notice: Be able to re-order the columns or rows of a table by dragging them to another position in VisualEditor - https://phabricator.wikimedia.org/T88694#1796009 (10Krenair) [16:18:47] James_F: Krenair: hmm, did we want to deploy https://gerrit.wikimedia.org/r/#/c/252123/ ? [16:18:53] (03CR) 10Jforrester: [C: 032] Fix updating of display title upon save [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/252217 (https://phabricator.wikimedia.org/T117643) (owner: 10Alex Monk) [16:19:09] MatmaRex: Ak, yes, last night. [16:19:21] MatmaRex: For some reason I was rather distracted. [16:19:24] (03CR) 10Jforrester: "recheck" [extensions/VisualEditor] (wmf/1.27.0-wmf.5) - 10https://gerrit.wikimedia.org/r/252123 (https://phabricator.wikimedia.org/T118152) (owner: 10Jforrester) [16:19:47] inexplicably [16:20:11] Indeed. [16:21:51] 10VisualEditor, 10VisualEditor-ContentEditable, 7Browser-Support-Internet-Explorer: VisualEditor: Drag-and-drop in IE doesn't work (?) - https://phabricator.wikimedia.org/T75240#1796123 (10MarkAHershberger) Just re-tested against https://en.wikipedia.org/w/index.php?oldid=678508180 ([[Ray County, Missouri]])... [16:23:35] (03CR) 10Jforrester: [C: 032 V: 032] ve.init.mw.DesktopArticleTarget.init: Make switching to VE for new pages work [extensions/VisualEditor] (wmf/1.27.0-wmf.5) - 10https://gerrit.wikimedia.org/r/252123 (https://phabricator.wikimedia.org/T118152) (owner: 10Jforrester) [16:23:40] (03CR) 10jenkins-bot: [V: 04-1] Fix updating of display title upon save [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/252217 (https://phabricator.wikimedia.org/T117643) (owner: 10Alex Monk) [16:31:04] (03CR) 10Jforrester: [C: 032] Fix updating of display title upon save [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/252217 (https://phabricator.wikimedia.org/T117643) (owner: 10Alex Monk) [16:36:59] (03CR) 10jenkins-bot: [V: 04-1] Fix updating of display title upon save [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/252217 (https://phabricator.wikimedia.org/T117643) (owner: 10Alex Monk) [16:37:14] Oy. [16:39:13] (03CR) 10Jforrester: [C: 032] Fix updating of display title upon save [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/252217 (https://phabricator.wikimedia.org/T117643) (owner: 10Alex Monk) [16:42:10] yay T117410 :) [16:42:27] Elitre: Yup. :-) [16:42:36] 10VisualEditor, 10Wikimedia-Site-Requests, 5Patch-For-Review: Enable VisualEditor for some user groups at the Spanish Wikipedia - https://phabricator.wikimedia.org/T117410#1796188 (10Jdforrester-WMF) [16:42:39] * Elitre hi5s James [16:43:02] Elitre: So far there's been a very slight up-tick in use of VE on eswiki, but only just. [16:43:09] (As you'd expect at 10% of new users.) [16:43:30] yup, noticed that. [16:49:44] (03Merged) 10jenkins-bot: Fix updating of display title upon save [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/252217 (https://phabricator.wikimedia.org/T117643) (owner: 10Alex Monk) [16:59:14] Krenair: Is there a way to do this without doing another parse? We worked hard to reduce the number of parses, I'd rather not re-increase it. [16:59:23] possibly [16:59:42] I don't want to do this either [17:08:12] 10VisualEditor, 6Multimedia, 7Design: Make it clear in VE (hover state?) when a media file is being dragged in that shows it will do something - https://phabricator.wikimedia.org/T115859#1796287 (10Esanders) > Just want to make sure that I understand this correctly, are you talking about the horizontal line... [17:10:07] 10VisualEditor, 10WikiEditor: WikiEditor's search and replace box stays open after moving from source editing to visual editing - https://phabricator.wikimedia.org/T118282#1796293 (10Amire80) 3NEW [17:18:30] Meh. [17:23:09] Ugh. [17:25:55] Krenair: No no no. [17:26:12] ? [17:26:14] Krenair: Rebase https://gerrit.wikimedia.org/r/#/c/248369/ now please. [17:26:27] Krenair: Not fix random minor issues. [17:26:27] :-) [17:26:44] okay... [17:28:37] Krenair, so we pass veswitched=1 to WE, but we don't pass any information about if there were changes made in VE [17:30:01] don't we just post to action=submit? [17:30:47] right [17:30:57] so veswitched just mean they came from VE with no changes? [17:31:09] means they came from VE [17:31:16] but with no changes [17:31:46] otherwise they would bounce to action=submit as you say [17:31:55] ... it's given to action=submit as well [17:31:55] I mean after redirects [17:32:03] ... in the query string [17:32:09] just in the post body instead of the url [17:32:12] yeah [17:32:34] ok [17:34:06] the server detects this and adds the field either way [17:34:56] I think the problem is going the other way actually [17:35:01] so WE -> VE -> WE [17:35:43] were you working on that or shall I? [17:36:32] What is the problem? [17:36:38] I don't know what issue you're trying to solve [17:36:45] if you go WE -> VE, then VE assumes there are changes [17:36:56] yes [17:37:05] if you keep changes [17:37:30] but also if there are no changes [17:37:55] if you discard changes it does a page reload - so there is no problem [17:38:21] (we should change that as it's slower than loading it in place) [17:41:54] edsanders: I don't think that's a priority. [17:51:14] (03PS1) 10Esanders: Edit mode switching: Tell VE if the wikitext was modified [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/252246 [17:54:06] (03CR) 10jenkins-bot: [V: 04-1] Edit mode switching: Tell VE if the wikitext was modified [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/252246 (owner: 10Esanders) [17:57:02] (03PS1) 10Esanders: Edit switching: Only show WE toolbar button once module is loaded [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/252247 [18:00:22] (03PS4) 10Alex Monk: [WIP] Single edit tab [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/248369 (https://phabricator.wikimedia.org/T114530) [18:17:24] I dislike hangouts on mobile even more than normal hangouts. [18:17:33] But ugh, it seems to be the only way for other people to hear me. [18:17:46] (that was over wifi, by the way) [18:19:11] Does narrow it down to "something is wrong with your laptop", at least. [18:20:19] I guess so [18:20:29] I tested it with James yesterday and it all seemed fine :/ [18:20:53] The rebased single edit tab commit is up [18:21:14] It doesn't trigger the WE->VE switch button being shown [18:21:21] need to deal with that and the previous things [18:21:34] and I'll need to go through this document James mentioned [18:21:41] (but after dinner) [18:23:18] If it worked with just you and James, perhaps it's hitting some CPU threshold when there's all those extra video streams from the larger hangout. [18:30:27] (03PS1) 10Bartosz Dziewoński: ve.ui.DialogTool: Do not require that a command is set [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/252250 [18:30:34] Could be. But there were only two video streams today. [18:31:11] 10VisualEditor, 10VisualEditor-MediaWiki, 10WikiEditor, 5Patch-For-Review, and 2 others: Switch to VE button presented on Create page but doesn't function - https://phabricator.wikimedia.org/T118152#1796797 (10Jdforrester-WMF) 5duplicate>3Resolved a:3Jdforrester-WMF [18:32:47] (03PS2) 10Bartosz Dziewoński: Provide a tool to insert a signature in namespaces that need it [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/251834 (https://phabricator.wikimedia.org/T53154) [18:33:50] (03CR) 10jenkins-bot: [V: 04-1] ve.ui.DialogTool: Do not require that a command is set [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/252250 (owner: 10Bartosz Dziewoński) [18:34:55] is like, all CI for VE/VE broken right now? [18:37:02] (03PS3) 10Bartosz Dziewoński: Provide a tool to insert a signature in namespaces that need it [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/251834 (https://phabricator.wikimedia.org/T53154) [18:37:15] MatmaRex: And for OOUI and … [18:38:33] okay… [18:39:22] Oh, wait. [18:39:30] WTF is rake-jessie doing in VE/VE? [18:40:56] * James_F fixes. [18:42:27] (03PS1) 10Jforrester: test: Add a Rakefile for new CI requirement [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/252251 [18:42:37] MatmaRex: ^^^ Could you +2? [18:43:09] eww, rubocop [18:43:11] Yeah. [18:43:15] But it makes the repo work. [18:43:37] (03CR) 10Bartosz Dziewoński: [C: 032] "Eh, that piece of junk?" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/252251 (owner: 10Jforrester) [18:43:53] (03PS2) 10Esanders: Edit mode switching: Only show WE toolbar button once module is loaded [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/252247 [18:43:55] (03PS1) 10Esanders: Edit mode switching: Separate styles [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/252252 [18:43:56] I know VE/Parsoid tries to avoid dirty diffs, but it would be really nice if I could hit a button that intentionally converts all external links that can be into [[wikilinks]] or interwiki ones. [18:44:06] reverting poorly thought-out CI changes does, too. [18:44:38] MatmaRex: Sure, but what are you going to do? [18:44:54] well, myself, not much right now, i don't have the permissions. [18:45:00] i should infiltrate releng. [18:45:03] Indeed. That's rather the problem. [18:48:23] (03Merged) 10jenkins-bot: test: Add a Rakefile for new CI requirement [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/252251 (owner: 10Jforrester) [18:48:43] (03CR) 10jenkins-bot: [V: 04-1] Edit mode switching: Separate styles [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/252252 (owner: 10Esanders) [18:48:54] (03CR) 10jenkins-bot: [V: 04-1] Edit mode switching: Only show WE toolbar button once module is loaded [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/252247 (owner: 10Esanders) [18:49:17] We missed you, jenkins, and your harsh disapproval of our work. [18:50:21] (03PS2) 10Esanders: Edit mode switching: Tell VE if the wikitext was modified [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/252246 [18:50:28] 10VisualEditor, 10VisualEditor-MediaWiki, 7Epic, 5Patch-For-Review: Change VE integration to only use one edit tab - https://phabricator.wikimedia.org/T114530#1796843 (10Whatamidoing-WMF) The experience in Flow isn't comparable. Flow uses VisualEditor as a fake "preview" system. The wikitext editor does... [18:50:53] (03CR) 10Esanders: "recheck" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/252247 (owner: 10Esanders) [19:05:03] (03CR) 10Jforrester: [C: 031] "Meh. I'd rather show it disabled and then enable it when possible. Flashing in afterwards isn't particularly cool." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/252247 (owner: 10Esanders) [19:06:05] (03CR) 10Jforrester: [C: 031] Edit mode switching: Separate styles [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/252252 (owner: 10Esanders) [19:06:11] (03CR) 10Jforrester: "recheck" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/252252 (owner: 10Esanders) [19:07:13] (03PS2) 10Jforrester: ve.ui.DialogTool: Do not require that a command is set [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/252250 (owner: 10Bartosz Dziewoński) [19:16:07] Krenair: The document I mentioned was just the description of https://phabricator.wikimedia.org/T114530 [19:19:20] (03CR) 10Jforrester: [C: 032] ve.ui.DialogTool: Do not require that a command is set [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/252250 (owner: 10Bartosz Dziewoński) [19:23:02] (03Merged) 10jenkins-bot: ve.ui.DialogTool: Do not require that a command is set [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/252250 (owner: 10Bartosz Dziewoński) [19:53:14] (03CR) 10Jforrester: [C: 032] Enable new module versioning for VisualEditorDataModule [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/252138 (https://phabricator.wikimedia.org/T102578) (owner: 10Krinkle) [19:53:20] (03CR) 10Jforrester: [C: 032] Remove redundant VisualEditorDataModule::getGitHeadHash static cache [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/252143 (owner: 10Krinkle) [19:56:05] 10VisualEditor, 10VisualEditor-MediaWiki, 6Community-Tech: HotCat doesn't load after saving a page in VisualEditor (must refresh/reload first) [AOI] - https://phabricator.wikimedia.org/T103285#1797108 (10DannyH) [20:03:29] 10VisualEditor: editing a section in the source editor, moving to VE, and saving deletes all other sections - https://phabricator.wikimedia.org/T118233#1797129 (10Jdforrester-WMF) [20:03:31] 10VisualEditor, 10VisualEditor-MediaWiki, 5WMF-deploy-2015-11-03_(1.27.0-wmf.5), 5WMF-deploy-2015-11-10_(1.27.0-wmf.6): Switching from a WT section edit to VE only switches with the wikitext of the section, not the article - https://phabricator.wikimedia.org/T117713#1797130 (10Jdforrester-WMF) [20:03:47] 10VisualEditor, 10VisualEditor-MediaWiki, 10WikiEditor: WikiEditor's search and replace box stays open after moving from source editing to visual editing - https://phabricator.wikimedia.org/T118282#1797132 (10Jdforrester-WMF) p:5Triage>3Low [20:04:37] 10VisualEditor: "References list" should be an item in the Cite menu, not in the Insert one - https://phabricator.wikimedia.org/T118193#1797144 (10Jdforrester-WMF) 5Open>3declined a:3Jdforrester-WMF Per Ed; a better solution to this issue will be {T56906}. [20:05:32] 10VisualEditor, 10VisualEditor-MediaWiki: Pasting the wikitext to instantiate a category link into VE throws a fatal - https://phabricator.wikimedia.org/T118191#1797149 (10Jdforrester-WMF) p:5Triage>3Low [20:06:14] (03Merged) 10jenkins-bot: Enable new module versioning for VisualEditorDataModule [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/252138 (https://phabricator.wikimedia.org/T102578) (owner: 10Krinkle) [20:06:24] 10VisualEditor, 10MediaWiki-extensions-InputBox: The "create" InputBox always uses the source editor and not the VisualEditor - https://phabricator.wikimedia.org/T118123#1797158 (10Jdforrester-WMF) [20:06:28] 10VisualEditor, 10VisualEditor-EditingTools, 10MediaWiki-Page-editing: Add support for (the equivalent of?) editintro and preload - https://phabricator.wikimedia.org/T51622#1797159 (10Jdforrester-WMF) [20:07:09] 10VisualEditor, 10VisualEditor-MediaWiki: VisualEditor should let users click on the links under page title (inside contentSub) - https://phabricator.wikimedia.org/T118116#1797161 (10Jdforrester-WMF) p:5Triage>3Low [20:08:20] 10VisualEditor, 10VisualEditor-EditingTools: VE dialogs become pretty confusing with the insert symbol panel open - https://phabricator.wikimedia.org/T118092#1797168 (10Jdforrester-WMF) [20:08:22] 10VisualEditor, 10VisualEditor-MediaWiki-Links, 7Design: Maximum height of the link editor should take into account the toolbar height too - https://phabricator.wikimedia.org/T114614#1797169 (10Jdforrester-WMF) [20:08:24] (03Merged) 10jenkins-bot: Remove redundant VisualEditorDataModule::getGitHeadHash static cache [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/252143 (owner: 10Krinkle) [20:08:51] 10VisualEditor, 10VisualEditor-MediaWiki, 6Editing-Analysis: Review Schema:Edit now that VE allows WE->VE switching - https://phabricator.wikimedia.org/T118063#1797173 (10Jdforrester-WMF) p:5Triage>3Normal a:3Neil_P._Quinn_WMF [20:10:32] 10VisualEditor: Context menu obscures context below the cursor, which in some pathological cases is problematic - https://phabricator.wikimedia.org/T118040#1797178 (10Jdforrester-WMF) p:5Triage>3Lowest [20:11:14] 10VisualEditor: VisualEditor should warn the editor when a newly added template parameter would also add - https://phabricator.wikimedia.org/T117964#1797186 (10Jdforrester-WMF) 5Open>3declined a:3Jdforrester-WMF How on Earth do you expect VisualEditor to know this? [20:12:57] (03PS5) 10Esanders: Add removable flag to meta items [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/205291 (https://phabricator.wikimedia.org/T96528) [20:13:19] 10VisualEditor, 7Design, 7I18n, 7RTL: The letter "T" in the RTL VisualEditor welcome image should be replaced for RTL languages - https://phabricator.wikimedia.org/T117952#1797190 (10Jdforrester-WMF) 5Open>3declined a:3Jdforrester-WMF I think varying this image per language or language group (and thu... [20:14:08] 10VisualEditor, 7Design, 7I18n, 7RTL: VisualEditor citation hint box image should not flip the digits for RTL - https://phabricator.wikimedia.org/T117949#1797193 (10Jdforrester-WMF) p:5Normal>3Low [20:15:14] 10VisualEditor: VE saturates CPU when losing internet connection and then trying an AJAX load - https://phabricator.wikimedia.org/T118001#1797199 (10Jdforrester-WMF) 5Open>3stalled [20:15:24] (03CR) 10jenkins-bot: [V: 04-1] Add removable flag to meta items [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/205291 (https://phabricator.wikimedia.org/T96528) (owner: 10Esanders) [20:16:19] 10VisualEditor, 10VisualEditor-MediaWiki, 10WikiEditor: Consider moving the switch-to-VisualEditor button near the Save button in the wikitext editor - https://phabricator.wikimedia.org/T117892#1797206 (10Jdforrester-WMF) 5Open>3declined a:3Jdforrester-WMF The integration with WikiEditor is temporary f... [20:16:23] (03PS2) 10Esanders: [WIP] Failing test case for removable meta items [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/206846 (owner: 10Catrope) [20:17:45] 10VisualEditor, 10SyntaxHighlight: SyntaxHighlight's VE editor does not open to its largest size when opening a long elements - https://phabricator.wikimedia.org/T117926#1797219 (10Jdforrester-WMF) p:5Triage>3Low [20:18:37] 10VisualEditor: Templates’ closing curly brackets to be placed on a different line than the final parameter - https://phabricator.wikimedia.org/T117891#1797226 (10Jdforrester-WMF) [20:18:40] 10TemplateData, 10VisualEditor, 10VisualEditor-MediaWiki-Templates, 10Parsoid: Parsoid on serialisation should use the `format` field from TemplateData if available to set the whitespace formatting of new/edited transclusions - https://phabricator.wikimedia.org/T111674#1797227 (10Jdforrester-WMF) [20:18:50] (03CR) 10jenkins-bot: [V: 04-1] [WIP] Failing test case for removable meta items [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/206846 (owner: 10Catrope) [20:19:13] 10TemplateData, 10VisualEditor, 7Design: Alert the user when adding template parameter not defined by TemplateData - https://phabricator.wikimedia.org/T117890#1797229 (10Jdforrester-WMF) p:5Triage>3Low [20:19:40] hallo [20:19:45] 10VisualEditor, 10VisualEditor-MediaWiki, 10WikiEditor, 10MediaWiki-extensions-UniversalLanguageSelector: Keyboard icon overlaps with switch-to-VisualEditor icon in the wiktext editor - https://phabricator.wikimedia.org/T117889#1797241 (10Jdforrester-WMF) Which browser? This is ULS's IME inserter… [20:20:02] 10VisualEditor, 10VisualEditor-MediaWiki, 10WikiEditor, 10MediaWiki-extensions-UniversalLanguageSelector: Keyboard icon overlaps with switch-to-VisualEditor icon in the wiktext editor for some users (?) - https://phabricator.wikimedia.org/T117889#1797242 (10Jdforrester-WMF) p:5Triage>3Low [20:20:58] Is https://phabricator.wikimedia.org/T117964 really impossible? When an article is being saved, you can see a diff, and you can clearly see a there. Can't it do something like that while adding template parameters? [20:21:53] 10VisualEditor, 10VisualEditor-CopyPaste, 10VisualEditor-Tables: Table pasting problem in visual Editor - https://phabricator.wikimedia.org/T117859#1797272 (10Jdforrester-WMF) a:5Catrope>3None Please do not assign tasks to engineers in the hope that they will work on them. They won't. [20:22:45] 10VisualEditor, 10VisualEditor-CopyPaste, 10VisualEditor-Tables: Wikitext paste conversion tool interferes with table pasting from MS Word for one user(?) - https://phabricator.wikimedia.org/T117859#1797286 (10Jdforrester-WMF) p:5Triage>3Low [20:23:13] (03PS1) 10Esanders: ve.ui.Tool: Fix documentation for getCommandName [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/252268 [20:25:46] 10VisualEditor, 10VisualEditor-MediaWiki: On French Wikipedia, the gadget that collapses templates should run after the user saves their edit to restore their default state - https://phabricator.wikimedia.org/T116765#1797320 (10Jdforrester-WMF) p:5Triage>3Normal a:3Esanders [20:26:33] 10VisualEditor, 10VisualEditor-MediaWiki, 7Browser-Support-Firefox: an unnecessary warning is shown when saving a page in mobile VisualEditor using Firefox for Android - https://phabricator.wikimedia.org/T116537#1797333 (10Jdforrester-WMF) 5Open>3stalled [20:27:09] 10VisualEditor, 10VisualEditor-MediaWiki: On French Wikipedia, the gadget that collapses templates should run after the user saves their edit to restore their default state - https://phabricator.wikimedia.org/T116765#1797345 (10Krenair) Don't we have a hook for this? Also, probably should be a community tech b... [20:27:39] 10VisualEditor, 10VisualEditor-MediaWiki: Flaky test "MWTransclusionNode getWikitext FAILED: Pending AJAX request" - https://phabricator.wikimedia.org/T116258#1797348 (10Jdforrester-WMF) [20:27:41] 10VisualEditor, 10MediaWiki-Unit-tests: ve.dm.MWTransclusionNode getWikitext flaky qunit test? - https://phabricator.wikimedia.org/T116457#1797346 (10Jdforrester-WMF) [20:28:01] 10VisualEditor, 10Score: Provide better error message when a Score is empty - https://phabricator.wikimedia.org/T116392#1797350 (10Jdforrester-WMF) [20:29:18] 10VisualEditor, 10VisualEditor-MediaWiki: Once you've dismissed one of the educational pop-ups, the pulsating dot for the other stays, but disappears when you load the page for a second/later time time - https://phabricator.wikimedia.org/T117638#1797353 (10Jdforrester-WMF) p:5Triage>3Normal [20:29:54] 10VisualEditor, 10VisualEditor-ContentEditable, 7Epic: DM/DOM sync can break if you use an IME - https://phabricator.wikimedia.org/T116275#1797363 (10Jdforrester-WMF) p:5Triage>3Normal [20:52:31] 10VisualEditor: VisualEditor should warn the editor when a newly added template parameter would also add - https://phabricator.wikimedia.org/T117964#1797411 (10Amire80) Is it really impossible? When an article is being saved, you can see a diff, and you can clearly see a there. Can't it do some... [22:15:39] (03PS5) 10Alex Monk: [WIP] Single edit tab [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/248369 (https://phabricator.wikimedia.org/T114530) [22:34:13] (03CR) 10Esanders: "ping" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/248356 (https://phabricator.wikimedia.org/T116755) (owner: 10Esanders) [22:58:42] 10VisualEditor: VisualEditor should warn when user enters wikitext but the editor is expecting plaintext - https://phabricator.wikimedia.org/T107441#1797916 (10DLynch) "Noticing if wikitext was contained somewhere in a massive paste and explaining our objection to it" is a bit awkward. But we could perhaps detec... [23:04:18] (03PS1) 10Esanders: Edit mode switch: Show popup next to switch button [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/252345 [23:09:09] (03CR) 10jenkins-bot: [V: 04-1] Edit mode switch: Show popup next to switch button [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/252345 (owner: 10Esanders) [23:11:13] 10VisualEditor, 10VisualEditor-MediaWiki-Links: [Regression wmf.1] Search results appear in the drop down even after clearing the search term inside the link inspector - https://phabricator.wikimedia.org/T114178#1797964 (10DLynch) Reproduction note: I can only reproduce this by holding down backspace to delet... [23:26:44] oh btw: https://en.wikipedia.org/wiki/MediaWiki_talk:Monobook.css#Protected_edit_request_on_9_November_2015 [23:27:03] i had the coordinates repositioned in VE mode in monobook. [23:35:18] (03CR) 10Jforrester: [C: 032] DesktopTarget: Fix opacity of #siteSub and #contentSub [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/248356 (https://phabricator.wikimedia.org/T116755) (owner: 10Esanders) [23:35:49] 10VisualEditor, 10VisualEditor-MediaWiki, 5WMF-deploy-2015-11-17_(1.27.0-wmf.7): Site subtitle lighter than title in edit mode - https://phabricator.wikimedia.org/T116755#1798036 (10Jdforrester-WMF) 5Open>3Resolved [23:39:05] (03Merged) 10jenkins-bot: DesktopTarget: Fix opacity of #siteSub and #contentSub [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/248356 (https://phabricator.wikimedia.org/T116755) (owner: 10Esanders) [23:45:09] (03PS1) 10Jforrester: Update OOjs UI to v0.13.2 [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/252358 [23:47:37] (03CR) 10Esanders: [C: 032] Update OOjs UI to v0.13.2 [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/252358 (owner: 10Jforrester) [23:54:44] (03Merged) 10jenkins-bot: Update OOjs UI to v0.13.2 [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/252358 (owner: 10Jforrester) [23:58:17] 10VisualEditor, 10VisualEditor-MediaWiki-Links: [Regression wmf.1] Search results appear in the drop down even after clearing the search term inside the link inspector - https://phabricator.wikimedia.org/T114178#1798070 (10DLynch) a:5Esanders>3DLynch