[00:09:22] Marks my first patch against mediawiki/core. [00:10:00] (03CR) 10Esanders: [WIP] Single edit tab (031 comment) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/248369 (https://phabricator.wikimedia.org/T114530) (owner: 10Alex Monk) [00:13:54] (03CR) 10Esanders: "We can't show it until OOJS has loaded anyway, and it will take about the same time to load ve.switching as it does to load oojs." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/252247 (owner: 10Esanders) [00:20:13] Kemayo: Woo. [00:20:26] Your excitement is infectious. [00:21:56] :-) [00:22:54] (03CR) 10Esanders: WIP: Fix cartouche wrapping glitch with temporary block style on img (031 comment) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/233740 (https://phabricator.wikimedia.org/T111672) (owner: 10Divec) [00:23:02] (03PS12) 10Esanders: WIP: Fix cartouche wrapping glitch with temporary block style on img [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/233740 (https://phabricator.wikimedia.org/T111672) (owner: 10Divec) [00:24:11] (03PS13) 10Esanders: WIP: Fix cartouche wrapping glitch with temporary block style on img [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/233740 (https://phabricator.wikimedia.org/T111672) (owner: 10Divec) [00:43:58] Thalia|away: https://en.wikipedia.org/api/rest_v1/?doc#!/Math/post_media_math_format [01:21:55] 10VisualEditor, 10VisualEditor-MediaWiki, 10WikiEditor, 10MediaWiki-extensions-UniversalLanguageSelector: Keyboard icon overlaps with switch-to-VisualEditor icon in the wiktext editor for some users (?) - https://phabricator.wikimedia.org/T117889#1798201 (10Whatamidoing-WMF) I can reproduce this in both Sa... [01:34:58] (03CR) 10Esanders: [C: 032] Replace 'source' icon with OOUI's 'wikiText' one [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/250962 (owner: 10Jforrester) [01:41:01] (03PS1) 10Esanders: Add icon: Rename 'insert' to 'add' [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/252380 [01:42:03] (03Merged) 10jenkins-bot: Replace 'source' icon with OOUI's 'wikiText' one [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/250962 (owner: 10Jforrester) [01:54:38] (03CR) 10Jforrester: [C: 032] Add icon: Rename 'insert' to 'add' [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/252380 (owner: 10Esanders) [01:58:19] (03Merged) 10jenkins-bot: Add icon: Rename 'insert' to 'add' [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/252380 (owner: 10Esanders) [02:09:31] (03CR) 10Jforrester: [C: 032] ve.ui.Tool: Fix documentation for getCommandName [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/252268 (owner: 10Esanders) [02:10:53] (03CR) 10Esanders: [C: 04-1] Provide a tool to insert a signature in namespaces that need it (031 comment) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/251834 (https://phabricator.wikimedia.org/T53154) (owner: 10Bartosz Dziewoński) [02:17:44] (03CR) 10Jforrester: [C: 032] "> We can't show it until [OOUI] has loaded anyway" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/252247 (owner: 10Esanders) [02:18:30] (03CR) 10Jforrester: [C: 032] Edit mode switching: Separate styles [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/252252 (owner: 10Esanders) [02:18:41] (03Merged) 10jenkins-bot: ve.ui.Tool: Fix documentation for getCommandName [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/252268 (owner: 10Esanders) [02:19:51] 10VisualEditor, 10VisualEditor-MediaWiki-Links: [Regression wmf.1] Search results appear in the drop down even after clearing the search term inside the link inspector - https://phabricator.wikimedia.org/T114178#1798255 (10Jdforrester-WMF) 5Open>3Resolved [02:21:05] (03Merged) 10jenkins-bot: Edit mode switching: Only show WE toolbar button once module is loaded [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/252247 (owner: 10Esanders) [02:21:09] 10VisualEditor, 10VisualEditor-ContentEditable: When a link is the first element on a page, don't launch the link context menu automatically - https://phabricator.wikimedia.org/T114376#1798263 (10Jdforrester-WMF) [02:22:33] 10Citoid, 10VisualEditor: WorldCat URLs not importing ISBN information correctly - https://phabricator.wikimedia.org/T116056#1798268 (10Jdforrester-WMF) [02:22:43] 10VisualEditor, 10Parsoid, 7Parsoid-Nowiki: "[[Link]]
Word" should not be automatically changed to "[[Link]]Word" - https://phabricator.wikimedia.org/T117554#1798270 (10Jdforrester-WMF) [02:22:54] 10VisualEditor, 10VisualEditor-MediaWiki: Sometimes user-inserted ISBNs don't get converted to magic links somehow, meaning Parsoid has to nowiki them… - https://phabricator.wikimedia.org/T117165#1798271 (10Jdforrester-WMF) [02:23:21] (03CR) 10jenkins-bot: [V: 04-1] Edit mode switching: Separate styles [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/252252 (owner: 10Esanders) [02:23:48] 10VisualEditor, 10VisualEditor-MediaWiki-Templates, 6Language-Engineering, 7I18n: Message cache broken for visualeditor-dialog-transclusion-no-template-description - https://phabricator.wikimedia.org/T117145#1798273 (10Jdforrester-WMF) [02:24:53] 10VisualEditor, 10VisualEditor-MediaWiki: Flaky test "MWTransclusionNode getWikitext FAILED: Pending AJAX request" - https://phabricator.wikimedia.org/T116258#1798278 (10Jdforrester-WMF) [02:30:21] (03CR) 10Jforrester: [C: 032] Edit mode switching: Separate styles [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/252252 (owner: 10Esanders) [02:35:49] (03CR) 10jenkins-bot: [V: 04-1] Edit mode switching: Separate styles [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/252252 (owner: 10Esanders) [05:34:50] 10VisualEditor, 10Wikipedia-iOS-App-Product-Backlog: Webkit paste problem - https://phabricator.wikimedia.org/T118364#1798421 (10Matthewrbowker) Ref: https://bugs.webkit.org/show_bug.cgi?id=49141 [07:10:17] 10VisualEditor, 10VisualEditor-CopyPaste, 10VisualEditor-Tables: Wikitext paste conversion tool interferes with table pasting from MS Word for one user(?) - https://phabricator.wikimedia.org/T117859#1798455 (10NehalDaveND) @JDforrester-WMF What is the meaning of "for one user(?)" ? https://meta.wikimedia.or... [08:19:26] 10VisualEditor, 10VisualEditor-MediaWiki, 7Epic, 5Patch-For-Review: Change VE integration to only use one edit tab - https://phabricator.wikimedia.org/T114530#1798530 (10Pastakhov) I could not find information about the future of [[ https://www.mediawiki.org/wiki/Manual:Hooks/EditFormPreloadText | EditForm... [09:42:08] (03PS1) 10Zfilipin: WIP [BrowserTest] Fix broken browser test [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/252409 (https://phabricator.wikimedia.org/T94162) [09:46:05] (03CR) 10jenkins-bot: [V: 04-1] WIP [BrowserTest] Fix broken browser test [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/252409 (https://phabricator.wikimedia.org/T94162) (owner: 10Zfilipin) [09:52:51] (03PS2) 10Zfilipin: WIP [BrowserTest] Fix broken browser test [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/252409 (https://phabricator.wikimedia.org/T94162) [13:35:23] Hey guys, why is my VisualEditor so big? http://imgur.com/RdzWRTQ [13:36:00] I'm on MediaWiki 1.25.3 (stable) VE 0.1.0 [13:38:29] Looks like it is zoomed, but it is not :/ [13:39:12] VE-Version: VisualEditor-REL1_25-be84313 [13:46:39] huh. [13:47:05] i remember issues like that, i thought they were all fixed before 1.25 [13:51:58] Can you tell me what is the latest stable working VE-version for MediaWiki 1.25.3? I guess REL1_25 should be allright? [14:04:05] hmrc87: yeah, that should work. you can try out newer versions of VE, but they're likely incompatible [14:04:46] I just cloned REL1_25 https://gerrit.wikimedia.org/r/p/mediawiki/extensions/VisualEditor.git and did the submodule init. It is still really big - that has to do something with the vector-skin? [14:06:40] hmm? [14:07:15] ah, "big" as in font size [14:07:30] hmrc87: are you using REL1_25 of Vector too? [14:07:34] Yeah, somehow the buttons are also quite clunky, I think they scale relativley to the font-size [14:07:47] they do [14:07:56] but the font size should be consistent [14:08:17] Hm it does not show me any vector-version on the Specialpage, just a "-" [14:09:03] i dunno. file a bug? :( [14:09:26] or you could try upgrading everything to 1.26 (which is due to be released soon, REL1_26 branches already exist and should be stable) [14:10:06] Ok, I could try that. I just checked out the REL 1_25 branch of Vectorskin - still huge fonts [14:10:48] 10Cite: Missing error message and tracking category on cite with unclosed ref tag - https://phabricator.wikimedia.org/T118391#1798995 (10IKhitron) 3NEW [14:11:18] I'm not that super familar with git therefore I sometimes hesitate to file bugs since they might be just a stupid mistake on my side [14:12:06] i've got to leave, but i'll be back here later today. see you [14:12:09] It is a huge project with a lot of dependencies, I'm used to smaller projects and not a developer [14:12:18] we did have some really stupid bugs in release versions in the past [14:12:38] Thank you for your time! Have a great day [14:12:45] or night, wherever you are [14:12:51] afternoon :) [14:54:35] (03PS6) 10Alex Monk: [WIP] Single edit tab [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/248369 (https://phabricator.wikimedia.org/T114530) [14:54:53] (03CR) 10jenkins-bot: [V: 04-1] [WIP] Single edit tab [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/248369 (https://phabricator.wikimedia.org/T114530) (owner: 10Alex Monk) [15:22:45] 10TemplateData, 6Community-Liaison, 6Editing-Analysis, 10WMF-Product-Strategy: Please make me a list of commonly used templates in Wikipedia articles - https://phabricator.wikimedia.org/T96323#1799119 (10Elitre) It isn't resolved, but looks like MZ isn't going to work on it anymore, so we can just declare... [15:23:17] 10TemplateData, 6Community-Liaison, 6Editing-Analysis, 10WMF-Product-Strategy: Please make me a list of commonly used templates in Wikipedia articles - https://phabricator.wikimedia.org/T96323#1799123 (10Jdforrester-WMF) 5Open>3Resolved a:3Jdforrester-WMF [15:29:22] (03PS7) 10Alex Monk: [WIP] Single edit tab [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/248369 (https://phabricator.wikimedia.org/T114530) [15:48:53] 10VisualEditor, 10VisualEditor-MediaWiki: Flaky test "MWTransclusionNode getWikitext FAILED: Pending AJAX request" - https://phabricator.wikimedia.org/T116258#1799145 (10Jdforrester-WMF) Looked at this. It's rather confusing - there's no async behaviour in this functionality or its testing. Preceding tests are... [16:12:51] (03CR) 10Bartosz Dziewoński: Provide a tool to insert a signature in namespaces that need it (031 comment) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/251834 (https://phabricator.wikimedia.org/T53154) (owner: 10Bartosz Dziewoński) [16:14:02] 10VisualEditor, 10VisualEditor-MediaWiki-Templates, 6Language-Engineering, 7I18n: Message cache broken for visualeditor-dialog-transclusion-no-template-description - https://phabricator.wikimedia.org/T117145#1799196 (10matmarex) 5Open>3Resolved [16:59:46] 10VisualEditor, 6Collaboration-Team-Backlog, 10Flow, 10OOjs-UI, and 4 others: Duplicate icons: 'source' (in VE) and 'WikiText' - https://phabricator.wikimedia.org/T111038#1799298 (10Jdforrester-WMF) [17:02:48] (03PS1) 10Jforrester: Update OOjs to v1.1.10 [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/252451 [17:08:16] (03CR) 10jenkins-bot: [V: 04-1] Update OOjs to v1.1.10 [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/252451 (owner: 10Jforrester) [17:48:17] 10VisualEditor: Page title wrong after switching between visual and wikitext editors and saving the page - https://phabricator.wikimedia.org/T118407#1799376 (10Whatamidoing-WMF) 3NEW [17:53:54] (03PS2) 10Jforrester: Update OOjs to v1.1.10 [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/252451 [18:03:34] 10VisualEditor: Choose capitalization for internal links - https://phabricator.wikimedia.org/T118408#1799406 (10Whatamidoing-WMF) 3NEW [18:42:43] (03CR) 10Esanders: [C: 032] Edit mode switching: Separate styles [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/252252 (owner: 10Esanders) [18:46:32] (03CR) 10Esanders: Provide a tool to insert a signature in namespaces that need it (031 comment) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/251834 (https://phabricator.wikimedia.org/T53154) (owner: 10Bartosz Dziewoński) [18:47:17] (03CR) 10jenkins-bot: [V: 04-1] Edit mode switching: Separate styles [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/252252 (owner: 10Esanders) [18:48:31] (03CR) 10Catrope: [C: 032] Update OOjs to v1.1.10 [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/252451 (owner: 10Jforrester) [18:50:56] (03PS2) 10Jforrester: Edit mode switching: Separate styles [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/252252 (owner: 10Esanders) [18:51:50] (03Merged) 10jenkins-bot: Update OOjs to v1.1.10 [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/252451 (owner: 10Jforrester) [18:56:54] (03CR) 10jenkins-bot: [V: 04-1] Edit mode switching: Separate styles [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/252252 (owner: 10Esanders) [18:57:13] (03CR) 10Jforrester: "Running I643449c1 still fails for me with this – something I'm doing wrong or an actual failure?" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/107142 (https://bugzilla.wikimedia.org/50250) (owner: 10Esanders) [19:31:50] (03CR) 10DLynch: "It's an actual failure, but it looks like it's actually in large part that some of the TODOs in the code have been accomplished since it w" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/107142 (https://bugzilla.wikimedia.org/50250) (owner: 10Esanders) [19:32:07] Kemayo: :-) [19:32:28] i.e. the code is now less buggy than the tests expect it to be. [19:33:41] (Not the specific code in the patch -- the general VE deletion behavior.) [19:38:00] 10VisualEditor, 10VisualEditor-CopyPaste, 10VisualEditor-Tables: Wikitext paste conversion tool interferes with table pasting from MS Word for one user(?) - https://phabricator.wikimedia.org/T117859#1799574 (10cscott) I wrote that paste code, I believe. I am not aware of any changes in the past weeks. We'd... [19:38:29] * James_F nods. [19:49:12] (03PS9) 10DLynch: MW test cases for new structural deletion logic [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/98515 (https://phabricator.wikimedia.org/T52250) (owner: 10Esanders) [19:51:57] (03CR) 10jenkins-bot: [V: 04-1] MW test cases for new structural deletion logic [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/98515 (https://phabricator.wikimedia.org/T52250) (owner: 10Esanders) [19:59:04] (03PS7) 10Jforrester: Fix deletion inside a structural node at start/end of document [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/107142 (https://phabricator.wikimedia.org/T52250) (owner: 10Esanders) [19:59:13] (03CR) 10Jforrester: [C: 032] Fix deletion inside a structural node at start/end of document [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/107142 (https://phabricator.wikimedia.org/T52250) (owner: 10Esanders) [19:59:44] 10VisualEditor, 10VisualEditor-DataModel, 5Patch-For-Review, 5WMF-deploy-2015-11-17_(1.27.0-wmf.7): Can't remove list items immediately after a template - https://phabricator.wikimedia.org/T52250#1799639 (10Jdforrester-WMF) a:5Esanders>3DLynch [20:00:44] (03PS3) 10Jforrester: Move binarySearch to OOJS [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/246844 (owner: 10Esanders) [20:01:11] (03PS4) 10Jforrester: ve.utils: Use binarySearch from OOjs [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/246844 (owner: 10Esanders) [20:04:12] (03Merged) 10jenkins-bot: Fix deletion inside a structural node at start/end of document [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/107142 (https://phabricator.wikimedia.org/T52250) (owner: 10Esanders) [20:06:48] (03CR) 10Jforrester: [C: 032] ve.utils: Use binarySearch from OOjs [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/246844 (owner: 10Esanders) [20:13:23] (03Merged) 10jenkins-bot: ve.utils: Use binarySearch from OOjs [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/246844 (owner: 10Esanders) [20:14:18] 10VisualEditor, 10VisualEditor-MediaWiki, 10WikiEditor, 5Patch-For-Review, and 2 others: Switch to VE button presented on Create page but doesn't function - https://phabricator.wikimedia.org/T118152#1799699 (10matmarex) T118070 should be fixed now, should we revert the workaround on master? [20:15:28] 10VisualEditor, 10VisualEditor-MediaWiki, 10WikiEditor, 5Patch-For-Review, and 2 others: Switch to VE button presented on Create page but doesn't function - https://phabricator.wikimedia.org/T118152#1799701 (10Jdforrester-WMF) >>! In T118152#1799699, @matmarex wrote: > T118070 should be fixed now, should w... [20:19:37] (03PS1) 10Esanders: Image/gallery icons: Rename and use new upstream versions [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/252500 [20:20:02] (03CR) 10Esanders: [C: 04-2] "needs next release of oojs-ui" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/252500 (owner: 10Esanders) [20:22:10] (03PS1) 10Jforrester: Update VE core submodule to master (77d786a) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/252501 [20:23:31] (03CR) 10jenkins-bot: [V: 04-1] Image/gallery icons: Rename and use new upstream versions [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/252500 (owner: 10Esanders) [20:26:00] (03CR) 10jenkins-bot: [V: 04-1] Update VE core submodule to master (77d786a) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/252501 (owner: 10Jforrester) [20:27:23] 10VisualEditor, 10VisualEditor-MediaWiki-Links: [Regression wmf.1] Suggestions from previous search should not appear on opening the link inspector - https://phabricator.wikimedia.org/T114187#1799735 (10DLynch) a:5Esanders>3DLynch [20:27:54] (03PS10) 10Jforrester: Update VE core submodule to master (77d786a) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/98515 (https://phabricator.wikimedia.org/T52250) (owner: 10Esanders) [20:28:02] 10VisualEditor, 10VisualEditor-MediaWiki-Links: [Regression wmf.1] Suggestions from previous search should not appear on opening the link inspector - https://phabricator.wikimedia.org/T114187#1687412 (10DLynch) This will have been fixed by the fix for T114178. [20:28:15] (03Abandoned) 10Jforrester: Update VE core submodule to master (77d786a) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/252501 (owner: 10Jforrester) [20:29:15] 10VisualEditor, 10VisualEditor-MediaWiki-Links: [Regression wmf.1] Suggestions from previous search should not appear on opening the link inspector - https://phabricator.wikimedia.org/T114187#1799744 (10Jdforrester-WMF) 5Open>3Resolved Confirmed. [20:29:32] 10VisualEditor, 10VisualEditor-MediaWiki-Links, 5WMF-deploy-2015-11-17_(1.27.0-wmf.7): [Regression wmf.1] Suggestions from previous search should not appear on opening the link inspector - https://phabricator.wikimedia.org/T114187#1799750 (10Jdforrester-WMF) [20:29:59] 10VisualEditor, 10VisualEditor-MediaWiki-Links, 5MW-1.27-release-notes, 5WMF-deploy-2015-11-17_(1.27.0-wmf.7): [Regression wmf.1] Suggestions from previous search should not appear on opening the link inspector - https://phabricator.wikimedia.org/T114187#1799754 (10DLynch) [20:30:49] (03CR) 10jenkins-bot: [V: 04-1] Update VE core submodule to master (77d786a) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/98515 (https://phabricator.wikimedia.org/T52250) (owner: 10Esanders) [20:34:26] (03PS11) 10Jforrester: Update VE core submodule to master (77d786a) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/98515 (https://phabricator.wikimedia.org/T52250) (owner: 10Esanders) [20:34:43] (03PS12) 10DLynch: MW test cases for new structural deletion logic [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/98515 (https://phabricator.wikimedia.org/T52250) (owner: 10Esanders) [20:35:01] 10VisualEditor, 10VisualEditor-MediaWiki, 7Design, 7Epic: Provide a modern wikitext editor - https://phabricator.wikimedia.org/T104479#1799767 (10Neil_P._Quinn_WMF) [20:35:57] (03PS13) 10Jforrester: Update VE core submodule to master (77d786a) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/98515 (https://phabricator.wikimedia.org/T52250) (owner: 10Esanders) [20:40:25] (03CR) 10Jforrester: [C: 032] Update VE core submodule to master (77d786a) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/98515 (https://phabricator.wikimedia.org/T52250) (owner: 10Esanders) [20:44:41] (03CR) 10jenkins-bot: [V: 04-1] Update VE core submodule to master (77d786a) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/98515 (https://phabricator.wikimedia.org/T52250) (owner: 10Esanders) [20:54:10] 10VisualEditor, 10VisualEditor-MediaWiki, 10WikiEditor, 5Patch-For-Review, and 2 others: Switch to VE button presented on Create page but doesn't function - https://phabricator.wikimedia.org/T118152#1799800 (10matmarex) Pretty sure we didn't. That page still has the behavior I implemented in the workaround... [21:26:18] (03CR) 10Bartosz Dziewoński: Provide a tool to insert a signature in namespaces that need it (031 comment) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/251834 (https://phabricator.wikimedia.org/T53154) (owner: 10Bartosz Dziewoński) [21:29:12] (03PS4) 10Bartosz Dziewoński: Provide a tool to insert a signature in namespaces that need it [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/251834 (https://phabricator.wikimedia.org/T53154) [21:29:52] (03PS5) 10Bartosz Dziewoński: Provide a tool to insert a signature in namespaces that need it [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/251834 (https://phabricator.wikimedia.org/T53154) [21:32:22] (03CR) 10Bartosz Dziewoński: [C: 04-1] "Okay, poop, because it stopped working now (the tool does not appear at all). I really don't feel like debugging what causes that… :/" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/251834 (https://phabricator.wikimedia.org/T53154) (owner: 10Bartosz Dziewoński) [21:32:29] * MatmaRex curses edsanders [21:33:48] (03CR) 10jenkins-bot: [V: 04-1] Provide a tool to insert a signature in namespaces that need it [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/251834 (https://phabricator.wikimedia.org/T53154) (owner: 10Bartosz Dziewoński) [22:04:35] (03CR) 10Jforrester: [C: 032] "…" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/98515 (https://phabricator.wikimedia.org/T52250) (owner: 10Esanders) [22:10:10] (03Merged) 10jenkins-bot: Update VE core submodule to master (77d786a) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/98515 (https://phabricator.wikimedia.org/T52250) (owner: 10Esanders) [22:12:23] 10VisualEditor, 10VisualEditor-DataModel, 5WMF-deploy-2015-11-17_(1.27.0-wmf.7): Can't remove list items immediately after a template - https://phabricator.wikimedia.org/T52250#1799968 (10Jdforrester-WMF) 5Open>3Resolved [22:15:26] 10VisualEditor, 10VisualEditor-CopyPaste, 10VisualEditor-Tables: Wikitext paste conversion tool interferes with table pasting from MS Word for one user(?) - https://phabricator.wikimedia.org/T117859#1799989 (10Neil_P._Quinn_WMF) @NehalDaveND, can you upload a example Word document which has this problem? If... [22:19:47] 10VisualEditor, 10VisualEditor-MediaWiki-Links: [Regression wmf.1] Search is not returning matched article names in the link target suggestion drop down inside link inspector - https://phabricator.wikimedia.org/T114175#1800002 (10DLynch) a:5Esanders>3DLynch Since this is the same cause as T114178, my fix f... [22:21:20] (03PS11) 10Jforrester: Introduce template format [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/243138 (https://phabricator.wikimedia.org/T64147) (owner: 10Eranroz) [22:21:24] (03CR) 10Jforrester: Introduce template format (032 comments) [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/243138 (https://phabricator.wikimedia.org/T64147) (owner: 10Eranroz) [22:22:00] (03CR) 10Esanders: [C: 04-1] "Proportional scaling is controlled by ve.dm.Scalable. If this widget is going to toggle that value there should be a setter added to ve.dm" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/243979 (owner: 10Florianschmidtwelzow) [22:25:58] 10VisualEditor, 10VisualEditor-MediaWiki: Sometimes user-inserted ISBNs don't get converted to magic links somehow, meaning Parsoid has to nowiki them… - https://phabricator.wikimedia.org/T117165#1800017 (10cscott) I took a look at the edits; it's hard to say what was going wrong there. There were a bunch of... [22:30:04] (03CR) 10Jforrester: [C: 032] Edit mode switching: Separate styles [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/252252 (owner: 10Esanders) [22:33:39] (03Merged) 10jenkins-bot: Edit mode switching: Separate styles [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/252252 (owner: 10Esanders) [23:12:08] 10VisualEditor, 10VisualEditor-MediaWiki-Links: [Regression ?] Context menu for link inspector does not appear after typing something after the link unless user goes to next line - https://phabricator.wikimedia.org/T114333#1800090 (10DLynch) Works fine in Chrome. Error is only reproducible in Firefox. [23:23:06] 10VisualEditor, 10VisualEditor-EditingTools: VisualEditor: Link, Formula and Text Styles etc. should be disabled when focus is inside the comment/gallery/math/hieroglypics/… editors - https://phabricator.wikimedia.org/T72343#1800094 (10Esanders) Inspectors are non-modal so opening them keeps the selection in... [23:25:00] 10VisualEditor, 10VisualEditor-EditingTools: VisualEditor: Link, Formula and Text Styles etc. should be disabled when focus is inside the comment/gallery/math/hieroglypics/… editors - https://phabricator.wikimedia.org/T72343#1800095 (10Jdforrester-WMF) I disagree. Disabling the surface (greyed out, like we do... [23:37:36] (03PS12) 10Krinkle: Introduce template format [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/243138 (https://phabricator.wikimedia.org/T64147) (owner: 10Eranroz) [23:38:09] (03CR) 10Jforrester: Introduce template format (031 comment) [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/243138 (https://phabricator.wikimedia.org/T64147) (owner: 10Eranroz) [23:42:28] 10VisualEditor, 10VisualEditor-MediaWiki-Mobile: [Regression ?] Newline is appearing before every listed item in mobile VE - https://phabricator.wikimedia.org/T114716#1800099 (10Esanders) WFM in Chrome. Can you reproduce? [23:46:17] (03CR) 10Krinkle: "I didn't previously check it out locally to render a preview. It seems the note about the format is output as a plain text paragraph above" [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/243138 (https://phabricator.wikimedia.org/T64147) (owner: 10Eranroz) [23:46:27] James_F: I'd like your opinion on ^ [23:46:54] Krinkle: See the child commit of Ed's that provides an icon to use instead. [23:47:10] James_F: That's about the editor. [23:47:22] I mean when reading documentation on the tempalte page [23:47:25] Krinkle: I was going to replace the

above the table with an icon with the text as a label. [23:48:13] Krinkle: What do you think? [23:48:22] And perhaps a more elaborate tooltip. Something that at least mentions something about source format, or some such. [23:48:27] I'll check it out [23:48:28] * James_F nods. [23:48:34] I can't view icons in either Gerrit or GitBlit [23:48:37] No. [23:48:40] "Security". [23:48:41] * James_F sighs. [23:48:41] crap [23:48:49] Yeah, I raised that flag abotu Gerrit actually [23:48:51] * Krinkle regrets [23:48:59] So you only have yourself to blame. [23:49:12] Particularly, I liked gerrit's SVG side-by-side diff. [23:49:14] It was useful. [23:49:39] Ah, okay. So the icon focus on formatting of the parameters. [23:50:05] I think that's a good word to use. It avoids clarification with words like "source" or "wikitext", since parameters are naturally about source editing I think. [23:50:47] * James_F nods. [23:53:40] (03PS13) 10Krinkle: Introduce new 'format' template property [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/243138 (https://phabricator.wikimedia.org/T64147) (owner: 10Eranroz) [23:53:57] (03CR) 10Krinkle: [C: 031] Introduce new 'format' template property [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/243138 (https://phabricator.wikimedia.org/T64147) (owner: 10Eranroz) [23:54:32] James_F: +1 on language? [23:54:39] (03CR) 10Jforrester: [C: 031] Introduce new 'format' template property [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/243138 (https://phabricator.wikimedia.org/T64147) (owner: 10Eranroz) [23:54:45] We can move to icons as soon as ready there. Just initial stab at it [23:54:46] Was already reading it. :-) [23:54:52] (03CR) 10Krinkle: [C: 032] Introduce new 'format' template property [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/243138 (https://phabricator.wikimedia.org/T64147) (owner: 10Eranroz) [23:54:53] alrighty [23:54:56] Yay. [23:55:32] We've now personalised templates as having preferences. [23:55:36] 10TemplateData, 10VisualEditor, 10VisualEditor-MediaWiki-Templates, 10Parsoid: Parsoid on serialisation should use the `format` field from TemplateData if available to set the whitespace formatting of new/edited transclusions - https://phabricator.wikimedia.org/T111674#1800111 (10Jdforrester-WMF) [23:55:37] I hope that goes well in localisation [23:55:40] Yeah, well. [23:55:41] 10TemplateData, 10VisualEditor, 10VisualEditor-MediaWiki, 10VisualEditor-MediaWiki-Templates, and 3 others: Add an option in TemplateData to specify desired wikitext whitespace formatting of parameters - https://phabricator.wikimedia.org/T64147#1800108 (10Jdforrester-WMF) 5Open>3Resolved a:3eranroz [23:55:53] Using the undirected-we would be worse. [23:55:56] James_F: It's a habit I picked up from Hemingway app. [23:56:05] (03Merged) 10jenkins-bot: Introduce new 'format' template property [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/243138 (https://phabricator.wikimedia.org/T64147) (owner: 10Eranroz) [23:56:06] "Whether we like this template to have its parameters laid out…" [23:56:07] As a way to avoid active voice like "It is preferred to <..>" [23:56:23] 10TemplateData, 10VisualEditor, 10VisualEditor-MediaWiki, 10VisualEditor-MediaWiki-Templates, and 3 others: Add an option in TemplateData to specify desired wikitext whitespace formatting of parameters - https://phabricator.wikimedia.org/T64147#1800114 (10Jdforrester-WMF) [23:58:40] 10TemplateData, 10VisualEditor, 10VisualEditor-MediaWiki-Templates, 10Parsoid: Parsoid on serialisation should use the `format` field from TemplateData if available to set the whitespace formatting of new/edited transclusions - https://phabricator.wikimedia.org/T111674#1800115 (10Jdforrester-WMF) Now we've...