[00:37:07] (03CR) 10Divec: [C: 032] Remove duplicated check for surrogates [unicodejs] - 10https://gerrit.wikimedia.org/r/252734 (owner: 10Esanders) [00:41:44] (03CR) 10Divec: [C: 032] Upgrade JSCS and fix style errors [unicodejs] - 10https://gerrit.wikimedia.org/r/252628 (owner: 10Esanders) [00:42:54] (03Merged) 10jenkins-bot: Upgrade JSCS and fix style errors [unicodejs] - 10https://gerrit.wikimedia.org/r/252628 (owner: 10Esanders) [00:43:47] (03Merged) 10jenkins-bot: Remove duplicated check for surrogates [unicodejs] - 10https://gerrit.wikimedia.org/r/252734 (owner: 10Esanders) [01:32:19] 10WikiEditor, 7Regression, 7Wikimedia-log-errors: WikiEditor tries to load 26 messages that don't exist (wikieditor-toolbar-characters, wikieditor-toolbar-help-content, ..) - https://phabricator.wikimedia.org/T118541#1802870 (10Krinkle) 3NEW [01:42:12] 10VisualEditor, 10VisualEditor-MediaWiki-Links, 7Browser-Support-Firefox, 5WMF-deploy-2015-11-17_(1.27.0-wmf.7): [Regression ?] Context menu for link inspector does not appear after typing something after the link unless user goes to next line in Firefox - https://phabricator.wikimedia.org/T114333#1802878 (... [01:55:35] (03PS8) 10Esanders: [WIP] Single edit tab [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/248369 (https://phabricator.wikimedia.org/T114530) (owner: 10Alex Monk) [01:57:52] 10VisualEditor, 10VisualEditor-CopyPaste, 10VisualEditor-Tables: Wikitext paste conversion tool interferes with table pasting from MS Word for one user(?) - https://phabricator.wikimedia.org/T117859#1802887 (10NehalDaveND) @cscott I am confirming that "This bug is still occurring." I want to say that before... [02:05:13] (03PS1) 10Jforrester: extension.json: Remove calls to non-existent wikieditor-toolbar-characters-* [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/252888 (https://phabricator.wikimedia.org/T118541) [02:05:16] (03PS1) 10Jforrester: extension.json: Remove calls to non-existent wikieditor-toolbar-help-content-heading1-* [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/252889 (https://phabricator.wikimedia.org/T118541) [02:05:19] (03PS1) 10Jforrester: extension.json: Remove call to non-existent wikieditor-toolbar-tool-file-pre i18n [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/252890 [02:05:33] Krinkle: ^^ For you. :-) [02:06:26] (03CR) 10Krinkle: [C: 032] extension.json: Remove calls to non-existent wikieditor-toolbar-characters-* [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/252888 (https://phabricator.wikimedia.org/T118541) (owner: 10Jforrester) [02:06:44] Krinkle: (Couldn't find the origin of the other two sets.) [02:07:41] (03CR) 10Krinkle: [C: 032] extension.json: Remove calls to non-existent wikieditor-toolbar-help-content-heading1-* [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/252889 (https://phabricator.wikimedia.org/T118541) (owner: 10Jforrester) [02:08:04] (03Merged) 10jenkins-bot: extension.json: Remove calls to non-existent wikieditor-toolbar-characters-* [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/252888 (https://phabricator.wikimedia.org/T118541) (owner: 10Jforrester) [02:08:53] (03CR) 10Krinkle: [C: 032] extension.json: Remove call to non-existent wikieditor-toolbar-tool-file-pre i18n [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/252890 (owner: 10Jforrester) [02:08:56] (03Merged) 10jenkins-bot: extension.json: Remove calls to non-existent wikieditor-toolbar-help-content-heading1-* [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/252889 (https://phabricator.wikimedia.org/T118541) (owner: 10Jforrester) [02:10:07] (03Merged) 10jenkins-bot: extension.json: Remove call to non-existent wikieditor-toolbar-tool-file-pre i18n [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/252890 (owner: 10Jforrester) [02:22:59] 10VisualEditor, 10VisualEditor-MediaWiki-Links, 5Patch-For-Review: [Regression wmf.1] Search is not returning matched article names in the link target suggestion drop down inside link inspector - https://phabricator.wikimedia.org/T114175#1802904 (10DLynch) My OOUI patch landed. After the next OOUI release (T... [04:55:21] (03PS9) 10Divec: WIP: Diff richtext to build model changes [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/247800 [04:56:49] (03Abandoned) 10Divec: WIP: Build model transactions from richtext DOM diff [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/249077 (owner: 10Divec) [04:58:34] (03PS10) 10Divec: WIP: Diff richtext to build model changes [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/247800 [04:58:52] (03CR) 10Divec: "rebase" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/247800 (owner: 10Divec) [05:03:13] (03CR) 10jenkins-bot: [V: 04-1] WIP: Diff richtext to build model changes [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/247800 (owner: 10Divec) [08:10:03] 10VisualEditor, 10MediaWiki-Parser, 10Parsoid: Do not permit blank lines between list elements (== do not permit adjacent lists with no intervening elements) - https://phabricator.wikimedia.org/T109905#1803165 (10GOIII) [10:29:18] 10VisualEditor, 10VisualEditor-CopyPaste, 10VisualEditor-Tables: Automatically give pasted tables class="wikitable" in VE-MW - https://phabricator.wikimedia.org/T85577#1803258 (10Elitre) Question: Are we stripping any table classes? [10:40:29] 10VisualEditor, 10VisualEditor-MediaWiki: Sometimes user-inserted ISBNs don't get converted to magic links somehow, meaning Parsoid has to nowiki them… - https://phabricator.wikimedia.org/T117165#1803263 (10NicoV) @cscott If you want a much simpler example, you can take a look at this edit https://fr.wikipedia... [12:00:44] cscott: I mailed you about the Sanskrit table thing. I asked the guy to provide a screencast if possible. HTH. [12:06:32] 10VisualEditor, 10VisualEditor-CopyPaste, 10VisualEditor-Tables: Wikitext paste conversion tool interferes with table pasting from MS Word for one user(?) - https://phabricator.wikimedia.org/T117859#1803344 (10Elitre) {F2959570} Although I don't have Word, I could "reproduce" the issue with this doc. When co... [12:46:32] 10VisualEditor, 10VisualEditor-CopyPaste, 10VisualEditor-Tables: Wikitext paste conversion tool interferes with table pasting from MS Word for one user(?) - https://phabricator.wikimedia.org/T117859#1803386 (10NehalDaveND) see attached.... - {F2959651, layout=link} [13:22:40] 10VisualEditor, 10VisualEditor-CopyPaste, 10VisualEditor-Tables: Wikitext paste conversion tool interferes with table pasting from MS Word for one user(?) - https://phabricator.wikimedia.org/T117859#1803421 (10Elitre) >>! In T117859#1803386, @NehalDaveND wrote: > see attached.... > > - {F2959651, layout=l... [13:47:59] 10VisualEditor, 10VisualEditor-CopyPaste, 10VisualEditor-Tables: Wikitext paste conversion tool interferes with table pasting from MS Word for one user(?) - https://phabricator.wikimedia.org/T117859#1803461 (10Elitre) To clarify further, as I chatted a bit with the editor: he expects that the table he pastes... [13:50:15] 10VisualEditor, 10VisualEditor-MediaWiki, 7Browser-Support-Firefox, 7Browser-Support-Internet-Explorer, 7Performance: Animation on the educational pop-ups is CPU-intensive for Gecko/Trident, but not for Webkit/Blink - https://phabricator.wikimedia.org/T117190#1803463 (10matmarex) [13:50:21] 10VisualEditor, 10VisualEditor-MediaWiki, 7Browser-Support-Firefox, 7Browser-Support-Internet-Explorer, 7Performance: Animation on the educational pop-ups is CPU-intensive for Gecko/Trident, but not for Webkit/Blink - https://phabricator.wikimedia.org/T117190#1768329 (10matmarex) Whoops, sorry. [14:21:24] 10VisualEditor, 6Collaboration-Team-Backlog, 10Flow, 10UI-Standardization, 7Design: Come up with a better re-usable UI concept for a button to switch editor-mode; the current one is confusing, and hard to discover - https://phabricator.wikimedia.org/T116417#1803556 (10Alsee) A submenu might be acceptable... [15:20:53] (03PS11) 10Divec: WIP: Diff richtext to build model changes [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/247800 [15:23:56] (03CR) 10jenkins-bot: [V: 04-1] WIP: Diff richtext to build model changes [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/247800 (owner: 10Divec) [16:25:54] (03PS3) 10Jforrester: Edit mode switching: Tell VE if the wikitext was modified [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/252246 (owner: 10Esanders) [16:26:48] (03PS3) 10Jforrester: mailmap: Remove unused alias for ttijhof@wikimedia.org [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/252604 (owner: 10Krinkle) [16:30:44] (03CR) 10Jforrester: [C: 032] "One way to get the job to work — remove it." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/252604 (owner: 10Krinkle) [16:31:18] (03PS3) 10Jforrester: mw.trackSubscriber: Handle timeStamp being undef/NaN/infinite [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/249143 (https://phabricator.wikimedia.org/T116718) [16:31:51] (03CR) 10Jforrester: mw.trackSubscriber: Handle timeStamp being undef/NaN/infinite (031 comment) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/249143 (https://phabricator.wikimedia.org/T116718) (owner: 10Jforrester) [16:32:07] (03PS4) 10Jforrester: mw.trackSubscriber: If the number is NaN/falsy, return -1; [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/249149 (https://phabricator.wikimedia.org/T116718) [16:32:29] (03PS2) 10Jforrester: Image/gallery icons: Rename and use new upstream versions [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/252500 (owner: 10Esanders) [16:32:46] (03PS6) 10Jforrester: Provide a tool to insert a signature in namespaces that need it [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/251834 (https://phabricator.wikimedia.org/T53154) (owner: 10Bartosz Dziewoński) [16:35:09] 10VisualEditor, 10MediaWiki-Parser, 10Parsoid: Do not permit blank lines between list elements (== do not permit adjacent lists with no intervening elements) - https://phabricator.wikimedia.org/T109905#1803873 (10Jdforrester-WMF) 5Open>3declined a:3Jdforrester-WMF On reflection, I can't imagine any way... [16:35:35] (03Merged) 10jenkins-bot: mailmap: Remove unused alias for ttijhof@wikimedia.org [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/252604 (owner: 10Krinkle) [16:36:32] Krinkle: Yay! [16:37:14] 10VisualEditor, 10VisualEditor-Tables, 7Epic: Fully support basic table editing in the visual editor - https://phabricator.wikimedia.org/T108245#1803879 (10Timeshifter) If this isn't possible within the normal visual editor, then I suggest creating a good table editor at the Wikimedia Tool Labs: *http://too... [17:44:47] 10VisualEditor, 10VisualEditor-MediaWiki-Links: Stage insertion and application of new links with a "preview" interstitial step before you actually apply - https://phabricator.wikimedia.org/T98273#1804050 (10DLynch) Do we actually want this? It seems... ugly and awkward, requires lots of work to change everyth... [17:54:02] (03PS5) 10Florianschmidtwelzow: MediaSizeWidget: Allow an user to really use a custom size [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/243979 [17:55:50] (03CR) 10Florianschmidtwelzow: "> Proportional scaling is controlled by ve.dm.Scalable. If this widget is going to toggle that value there should be a setter added to ve." [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/243979 (owner: 10Florianschmidtwelzow) [17:56:21] (03CR) 10jenkins-bot: [V: 04-1] MediaSizeWidget: Allow an user to really use a custom size [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/243979 (owner: 10Florianschmidtwelzow) [17:59:05] 10VisualEditor, 10VisualEditor-MediaWiki-Links: Stage insertion and application of new links with a "preview" interstitial step before you actually apply - https://phabricator.wikimedia.org/T98273#1804106 (10Nirzar) 5Open>3Invalid [19:22:08] 10VisualEditor, 10VisualEditor-MediaWiki-Links: Stage insertion and application of new links with a "preview" interstitial step before you actually apply - https://phabricator.wikimedia.org/T98273#1804404 (10Jdforrester-WMF) 5Invalid>3declined a:3Jdforrester-WMF [19:23:41] 10VisualEditor, 10VisualEditor-ContentEditable: Cursoring over an MWLinkNode takes you two characters to the right/left, not one - https://phabricator.wikimedia.org/T96307#1804419 (10DLynch) a:5dchan>3DLynch [19:25:06] (03CR) 10Esanders: [C: 04-1] Provide a tool to insert a signature in namespaces that need it (032 comments) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/251834 (https://phabricator.wikimedia.org/T53154) (owner: 10Bartosz Dziewoński) [19:25:20] (03PS7) 10Esanders: Provide a tool to insert a signature in namespaces that need it [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/251834 (https://phabricator.wikimedia.org/T53154) (owner: 10Bartosz Dziewoński) [19:25:26] 10VisualEditor, 10VisualEditor-ContentEditable: Cursoring over an MWLinkNode takes you two characters to the right/left, not one - https://phabricator.wikimedia.org/T96307#1804423 (10DLynch) 5Open>3Resolved I declare this fixed by incidental other changes (specifically: that other task, which stopped all n... [19:26:36] (03PS1) 10Esanders: ContentAction: Add 'collapseToEnd' option to 'insert' [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/252971 [19:28:17] (03CR) 10Esanders: "Added:" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/251834 (https://phabricator.wikimedia.org/T53154) (owner: 10Bartosz Dziewoński) [19:28:49] (03CR) 10jenkins-bot: [V: 04-1] Provide a tool to insert a signature in namespaces that need it [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/251834 (https://phabricator.wikimedia.org/T53154) (owner: 10Bartosz Dziewoński) [19:32:02] (03CR) 10Jforrester: [C: 032] ContentAction: Add 'collapseToEnd' option to 'insert' [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/252971 (owner: 10Esanders) [19:34:57] (03PS8) 10Esanders: Provide a tool to insert a signature in namespaces that need it [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/251834 (https://phabricator.wikimedia.org/T53154) (owner: 10Bartosz Dziewoński) [19:35:26] (03Merged) 10jenkins-bot: ContentAction: Add 'collapseToEnd' option to 'insert' [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/252971 (owner: 10Esanders) [19:36:27] (03PS4) 10Esanders: Add block/inline icons [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/243155 [19:46:51] (03PS1) 10Esanders: Use checkbox widgets instead of toggle widgets [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/252975 [19:50:48] (03CR) 10Esanders: [C: 04-1] Use checkbox widgets instead of toggle widgets [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/252975 (owner: 10Esanders) [20:06:07] (03PS2) 10Esanders: Use checkbox widgets instead of toggle widgets [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/252975 [20:14:38] (03CR) 10Esanders: "This commit is ready to go." [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/243155 (owner: 10Esanders) [20:36:02] (03PS1) 10Esanders: Display format icon and message inside parameters table caption [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/253027 [20:36:23] (03CR) 10Esanders: "http://i.imgur.com/E5EMWLr.png" [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/253027 (owner: 10Esanders) [20:37:36] (03PS6) 10Esanders: Ensure magic link nodes inherit the annotations of their text [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/238609 (owner: 10Cscott) [20:40:39] (03CR) 10Esanders: [C: 04-1] "Looks good." (033 comments) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/238609 (owner: 10Cscott) [21:45:53] (03CR) 10Jforrester: Ensure magic link nodes inherit the annotations of their text (033 comments) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/238609 (owner: 10Cscott) [21:48:24] (03PS7) 10Jforrester: Ensure magic link nodes inherit the annotations of their text [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/238609 (owner: 10Cscott) [21:48:36] (03CR) 10Jforrester: [C: 032] Ensure magic link nodes inherit the annotations of their text [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/238609 (owner: 10Cscott) [21:49:50] 10Cite: False duplicate errors ("defined multiple times with different content") when using {{#tag:ref}} with XML-style tags inside - https://phabricator.wikimedia.org/T118603#1804727 (10matmarex) 3NEW [21:52:11] (03Merged) 10jenkins-bot: Ensure magic link nodes inherit the annotations of their text [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/238609 (owner: 10Cscott) [22:04:11] (03CR) 10Jforrester: [C: 032] Add block/inline icons [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/243155 (owner: 10Esanders) [22:04:19] (03CR) 10Jforrester: [C: 032] Display format icon and message inside parameters table caption [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/253027 (owner: 10Esanders) [22:04:38] (03CR) 10Jforrester: [C: 032] Use checkbox widgets instead of toggle widgets [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/252975 (owner: 10Esanders) [22:06:25] (03Merged) 10jenkins-bot: Add block/inline icons [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/243155 (owner: 10Esanders) [22:06:32] (03Merged) 10jenkins-bot: Display format icon and message inside parameters table caption [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/253027 (owner: 10Esanders) [22:06:34] (03Merged) 10jenkins-bot: Use checkbox widgets instead of toggle widgets [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/252975 (owner: 10Esanders) [22:11:22] 10TemplateData, 10VisualEditor, 10VisualEditor-MediaWiki-Templates, 10Parsoid: Parsoid on serialisation should use the `format` field from TemplateData if available to set the whitespace formatting of new/edited transclusions - https://phabricator.wikimedia.org/T111674#1804754 (10AdHuikeshoven) Adding a pa... [22:15:55] 10TemplateData, 10VisualEditor, 10VisualEditor-MediaWiki-Templates, 10Parsoid: Parsoid on serialisation should use the `format` field from TemplateData if available to set the whitespace formatting of new/edited transclusions - https://phabricator.wikimedia.org/T111674#1804762 (10Jdforrester-WMF) This deci... [22:28:19] 10TemplateData, 10VisualEditor, 10VisualEditor-MediaWiki-Templates, 10Parsoid: Parsoid on serialisation should use the `format` field from TemplateData if available to set the whitespace formatting of new/edited transclusions - https://phabricator.wikimedia.org/T111674#1804787 (10AdHuikeshoven) James, Tha... [22:44:06] (03PS2) 10Jforrester: [WIP] Edit mode switch: Show popup next to switch button [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/252345 (owner: 10Esanders) [22:44:08] (03PS4) 10Jforrester: Edit mode switching: Tell VE if the wikitext was modified [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/252246 (owner: 10Esanders) [22:44:36] (03CR) 10Jforrester: "PS2: Rebase." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/252345 (owner: 10Esanders) [22:56:53] 10VisualEditor, 10VisualEditor-CopyPaste, 10VisualEditor-Tables: Wikitext paste conversion tool interferes with table pasting from MS Word for one user(?) - https://phabricator.wikimedia.org/T117859#1804851 (10Whatamidoing-WMF) @Sphilbrick is encountering a very similar problem in Excel, and he can reproduce... [23:18:20] 10VisualEditor, 10VisualEditor-Performance, 7Epic, 5Patch-For-Review, and 2 others: Internal nodes should eventually be in a separate document ("sub-documents") - https://phabricator.wikimedia.org/T49344#484277 (10Catrope) Notes on transaction history: https://etherpad.wikimedia.org/p/SubDocumentsVE