[00:37:23] (03PS1) 10Tchanders: Add autocomplete options to AceEditorWidget config options [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/255300 (https://phabricator.wikimedia.org/T119549) [01:22:58] (03PS1) 10Jforrester: Update OOjs UI to v0.14.0 [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/255311 [01:27:06] (03CR) 10jenkins-bot: [V: 04-1] Update OOjs UI to v0.14.0 [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/255311 (owner: 10Jforrester) [01:27:41] (03CR) 10Jforrester: "recheck" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/255311 (owner: 10Jforrester) [02:08:04] (03CR) 10Esanders: [C: 032] Update OOjs UI to v0.14.0 [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/255311 (owner: 10Jforrester) [02:17:54] (03Merged) 10jenkins-bot: Update OOjs UI to v0.14.0 [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/255311 (owner: 10Jforrester) [02:18:13] (03CR) 10Jforrester: "recheck" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/254632 (https://phabricator.wikimedia.org/T111100) (owner: 10Jforrester) [02:24:08] 10VisualEditor, 10VisualEditor-EditingTools, 10Math: VisualEditor should display formulae using the user's preferred method, not just the default PNG one - https://phabricator.wikimedia.org/T62728#1830469 (10Jdforrester-WMF) a:3Tchanders [02:27:16] (03CR) 10Esanders: [C: 04-1] Add autocomplete options to AceEditorWidget config options (032 comments) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/255300 (https://phabricator.wikimedia.org/T119549) (owner: 10Tchanders) [02:28:36] 10VisualEditor, 10Math, 5Patch-For-Review: Let users click on a list of all the formula fragments to insert them - https://phabricator.wikimedia.org/T114163#1830475 (10Jdforrester-WMF) >>! In T114163#1827464, @Physikerwelt wrote: > @Tchanders that looks really nice. Is there a demo where one can try that? >... [02:28:47] 10VisualEditor, 10VisualEditor-MediaWiki, 10Math, 7Epic: [Objective] Improve support for math editing by improving the UX of the Math extension and researching its usability - https://phabricator.wikimedia.org/T118616#1830481 (10Jdforrester-WMF) [02:28:50] 10VisualEditor, 10Math, 5WMF-deploy-2015-12-08_(1.27.0-wmf.8): Let users click on a list of all the formula fragments to insert them - https://phabricator.wikimedia.org/T114163#1830478 (10Jdforrester-WMF) 5Open>3Resolved [02:29:04] 10VisualEditor, 10Math, 5WMF-deploy-2015-12-08_(1.27.0-wmf.8): Let users click on a list of all the formula fragments to insert them - https://phabricator.wikimedia.org/T114163#1686597 (10Jdforrester-WMF) [02:29:07] 10VisualEditor, 10Math, 5WMF-deploy-2015-12-08_(1.27.0-wmf.8): Show users a list of all the formula fragments they can insert - https://phabricator.wikimedia.org/T118617#1830482 (10Jdforrester-WMF) 5Open>3Resolved [02:29:24] 10VisualEditor, 10VisualEditor-MediaWiki, 10Math, 7Epic: [Objective] Improve support for math editing by improving the UX of the Math extension and researching its usability - https://phabricator.wikimedia.org/T118616#1804998 (10Jdforrester-WMF) [02:29:27] 10VisualEditor, 10VisualEditor-MediaWiki, 10Math, 7Epic, 5WMF-deploy-2015-12-08_(1.27.0-wmf.8): Use syntax highlighting so that users can understand the LaTeX they type more easily - https://phabricator.wikimedia.org/T118618#1830488 (10Jdforrester-WMF) 5Open>3Resolved [02:31:13] 10VisualEditor, 10OOjs-UI, 7I18n, 5OOjs-UI-0.14.0, and 2 others: "Select a file" does not appear localized in the VisualEditor - https://phabricator.wikimedia.org/T119307#1830492 (10Jdforrester-WMF) [02:31:47] 10VisualEditor, 10VisualEditor-MediaWiki, 10OOjs-UI, 5OOjs-UI-0.14.0, 5WMF-deploy-2015-12-08_(1.27.0-wmf.8): Duplicate icons: 'clock' and 'time' (in VE) - https://phabricator.wikimedia.org/T111100#1830494 (10Jdforrester-WMF) [02:33:03] (03PS2) 10Jforrester: MWMediaDialog: Use OOUI's 'clock' icon rather than a home-brew one [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/254632 (https://phabricator.wikimedia.org/T111100) [02:35:33] (03CR) 10jenkins-bot: [V: 04-1] MWMediaDialog: Use OOUI's 'clock' icon rather than a home-brew one [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/254632 (https://phabricator.wikimedia.org/T111100) (owner: 10Jforrester) [02:36:22] (03PS3) 10Jforrester: MWMediaDialog: Use OOUI's 'clock' icon rather than a home-brew one [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/254632 (https://phabricator.wikimedia.org/T111100) [02:38:25] (03CR) 10jenkins-bot: [V: 04-1] MWMediaDialog: Use OOUI's 'clock' icon rather than a home-brew one [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/254632 (https://phabricator.wikimedia.org/T111100) (owner: 10Jforrester) [02:40:22] (03PS4) 10Jforrester: MWMediaDialog: Use OOUI's 'clock' icon rather than a home-brew one [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/254632 (https://phabricator.wikimedia.org/T111100) [02:50:38] (03CR) 10Esanders: [C: 032] MWMediaDialog: Use OOUI's 'clock' icon rather than a home-brew one [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/254632 (https://phabricator.wikimedia.org/T111100) (owner: 10Jforrester) [02:53:37] (03Merged) 10jenkins-bot: MWMediaDialog: Use OOUI's 'clock' icon rather than a home-brew one [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/254632 (https://phabricator.wikimedia.org/T111100) (owner: 10Jforrester) [02:55:04] 10VisualEditor, 10VisualEditor-MediaWiki, 10OOjs-UI, 5OOjs-UI-0.14.0, 5WMF-deploy-2015-12-08_(1.27.0-wmf.8): Duplicate icons: 'clock' and 'time' (in VE) - https://phabricator.wikimedia.org/T111100#1830508 (10Jdforrester-WMF) 5Open>3Resolved [02:55:44] (03PS2) 10Tchanders: Add autocomplete options to AceEditorWidget config options [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/255300 (https://phabricator.wikimedia.org/T119549) [03:11:56] (03CR) 10Tchanders: Add autocomplete options to AceEditorWidget config options (032 comments) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/255300 (https://phabricator.wikimedia.org/T119549) (owner: 10Tchanders) [03:12:37] (03PS3) 10Tchanders: Add autocomplete options to AceEditorWidget config options [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/255300 (https://phabricator.wikimedia.org/T119549) [03:16:30] (03CR) 10jenkins-bot: [V: 04-1] Add autocomplete options to AceEditorWidget config options [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/255300 (https://phabricator.wikimedia.org/T119549) (owner: 10Tchanders) [03:19:18] (03PS4) 10Tchanders: Add autocomplete options to AceEditorWidget config options [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/255300 (https://phabricator.wikimedia.org/T119549) [03:44:49] (03PS5) 10Tchanders: Add autocomplete options to AceEditorWidget config options [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/255300 (https://phabricator.wikimedia.org/T119549) [03:45:09] (03CR) 10Esanders: [C: 032] Add autocomplete options to AceEditorWidget config options [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/255300 (https://phabricator.wikimedia.org/T119549) (owner: 10Tchanders) [03:45:53] 10VisualEditor, 10Math, 5Patch-For-Review: Make use of Ace Editor's autocompletion in the math dialog - https://phabricator.wikimedia.org/T119549#1830514 (10Jdforrester-WMF) [03:45:56] 10VisualEditor, 10VisualEditor-MediaWiki, 10Math, 7Epic: [Objective] Improve support for math editing by improving the UX of the Math extension and researching its usability - https://phabricator.wikimedia.org/T118616#1830513 (10Jdforrester-WMF) [03:46:40] 10VisualEditor, 10Math: Fix empty math editing box for users of MathML rendering mode - https://phabricator.wikimedia.org/T118435#1830516 (10Jdforrester-WMF) [03:46:43] 10VisualEditor, 10VisualEditor-EditingTools, 10Math: VisualEditor should display formulae using the user's preferred method, not just the default PNG one - https://phabricator.wikimedia.org/T62728#1830517 (10Jdforrester-WMF) [03:46:46] 10VisualEditor, 10VisualEditor-MediaWiki, 10Math, 7Epic: [Objective] Improve support for math editing by improving the UX of the Math extension and researching its usability - https://phabricator.wikimedia.org/T118616#1804998 (10Jdforrester-WMF) [03:48:40] (03Merged) 10jenkins-bot: Add autocomplete options to AceEditorWidget config options [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/255300 (https://phabricator.wikimedia.org/T119549) (owner: 10Tchanders) [03:51:03] 10VisualEditor, 10Math: Allow the VE dialog for math elements to be movable and resizable - https://phabricator.wikimedia.org/T59437#1830524 (10Jdforrester-WMF) [03:55:02] 10VisualEditor, 10Math, 7JavaScript: Math: VisualEditor JavaScript should only be added if VisualEditor is installed - https://phabricator.wikimedia.org/T88231#1830529 (10Jdforrester-WMF) p:5Triage>3Lowest [03:59:11] 10VisualEditor, 10VisualEditor-MediaWiki, 10Math, 7Epic: [Objective] Improve support for math editing by improving the UX of the Math extension and researching its usability - https://phabricator.wikimedia.org/T118616#1830534 (10Jdforrester-WMF) [03:59:14] 10VisualEditor, 10Math: Make use of Ace Editor's autocompletion in the math dialog - https://phabricator.wikimedia.org/T119549#1830532 (10Jdforrester-WMF) 5Open>3Resolved [04:12:19] 10Citoid, 10VisualEditor, 5Patch-For-Review: Add ability to request base types in citoid, and offer use of both in extension for backwards compatibility until all templateData has been updated. - https://phabricator.wikimedia.org/T114515#1830536 (10kaldari) This seemed to have been going well for a bit and t... [05:19:06] 10VisualEditor, 10Math, 7JavaScript: Math: VisualEditor JavaScript should only be added if VisualEditor is installed - https://phabricator.wikimedia.org/T88231#1830544 (10Physikerwelt) @Jdforrester-wmf from my point of we can close this [08:55:18] 10Citoid, 10VisualEditor, 5Patch-For-Review: Add ability to request base types in citoid, and offer use of both in extension for backwards compatibility until all templateData has been updated. - https://phabricator.wikimedia.org/T114515#1830651 (10Mvolz) Nope, just started working on it again, it'll get the... [08:58:48] 10VisualEditor: When a user introduces an internal link with an anchor, VisualEditor silently trims it - https://phabricator.wikimedia.org/T119599#1830657 (10QuimGil) 3NEW [09:50:06] (03CR) 10Fomafix: "This change breaks support for IE8 because it uses" [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/253167 (owner: 10Paladox) [10:10:54] 10VisualEditor, 10VisualEditor-MediaWiki: Sometimes user-inserted ISBNs don't get converted to magic links somehow, meaning Parsoid has to nowiki them… - https://phabricator.wikimedia.org/T117165#1830774 (10NicoV) @cscott I'm only using the edit filter that detects the addition of nowiki tags, no automated too... [10:32:53] (03PS1) 10Paladox: Fix ie 8 support in js follows-up: I039bc4c17fbba3c74a5050066b20af05434ca482 [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/255352 [10:35:16] (03CR) 10Paladox: "Fixed in https://gerrit.wikimedia.org/r/#/c/255352/" [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/253167 (owner: 10Paladox) [10:54:12] (03PS1) 10Gerrit Patch Uploader: Restore support for IE8 [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/255358 [10:54:15] (03CR) 10Gerrit Patch Uploader: "This commit was uploaded using the Gerrit Patch Uploader [1]." [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/255358 (owner: 10Gerrit Patch Uploader) [11:09:16] 10VisualEditor: Delete link action seems inconsistent - https://phabricator.wikimedia.org/T119615#1830945 (10Pginer-WMF) 3NEW [11:36:55] [13grunt-banana-checker] 15paladox opened pull request #45: Update grunt-jscs to 2.3.0 (06master...06patch-3) 02https://github.com/wikimedia/grunt-banana-checker/pull/45 [11:57:32] Hi is someone around who is familar with oojs I would like to upgrade a form in the mathsearch extension to oojs ui and created a custom Title Input widget which stoppen working after having changed my form from old html to OOUIHTMLForm . https://www.mediawiki.org/wiki/Using_OOjs_UI_in_MediaWiki#MediaWiki-specific_OOjs_UI_widgets suggests that there is already a compatible TitleInputWidget but a "TODO Wri [12:03:11] ah it's actually super simple 'class' => 'HTMLTitleTextField', [13:16:32] 10VisualEditor, 6Phabricator: Fix edit permissions of VisualEditor Phabricator projects - https://phabricator.wikimedia.org/T119622#1831177 (10Aklapper) 3NEW [13:27:53] 10VisualEditor, 6Phabricator: Fix edit permissions of VisualEditor Phabricator projects - https://phabricator.wikimedia.org/T119622#1831191 (10Aklapper) [13:46:27] (03CR) 10Fomafix: "Please abandon this change. It is a duplicate to Change-Id: Icfea4cedde88efb88307cbb1842edc8a17ebf83a" [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/255358 (owner: 10Gerrit Patch Uploader) [14:36:30] (03CR) 10Bartosz Dziewoński: [C: 032] Fix ie 8 support in js follows-up: I039bc4c17fbba3c74a5050066b20af05434ca482 [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/255352 (owner: 10Paladox) [14:39:12] (03Merged) 10jenkins-bot: Fix ie 8 support in js follows-up: I039bc4c17fbba3c74a5050066b20af05434ca482 [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/255352 (owner: 10Paladox) [15:38:56] (03Abandoned) 10Legoktm: Restore support for IE8 [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/255358 (owner: 10Gerrit Patch Uploader) [16:41:16] 10VisualEditor, 10Wikimedia-Site-Requests: Enable VisualEditor for future newly registered users on Dutch Wikipedia - https://phabricator.wikimedia.org/T119347#1831722 (10Aklapper) **General request:** Phrasing that directly refers to a person (or interprets the intentions of a person in a certain way) is not... [17:31:01] (03PS8) 10Paladox: Link dialog: do basic URI validation [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/141367 (https://phabricator.wikimedia.org/T30789) (owner: 10TheDJ) [17:31:29] (03CR) 10Paladox: "Please support detecting http or https." [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/141367 (https://phabricator.wikimedia.org/T30789) (owner: 10TheDJ) [17:31:38] (03CR) 10Paladox: "Rebased." [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/141367 (https://phabricator.wikimedia.org/T30789) (owner: 10TheDJ) [17:32:24] (03CR) 10jenkins-bot: [V: 04-1] Link dialog: do basic URI validation [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/141367 (https://phabricator.wikimedia.org/T30789) (owner: 10TheDJ) [17:33:36] (03PS9) 10Paladox: Link dialog: do basic URI validation [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/141367 (https://phabricator.wikimedia.org/T30789) (owner: 10TheDJ) [17:35:15] (03CR) 10jenkins-bot: [V: 04-1] Link dialog: do basic URI validation [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/141367 (https://phabricator.wikimedia.org/T30789) (owner: 10TheDJ) [17:35:52] (03PS10) 10Paladox: Link dialog: do basic URI validation [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/141367 (https://phabricator.wikimedia.org/T30789) (owner: 10TheDJ) [17:37:18] (03CR) 10jenkins-bot: [V: 04-1] Link dialog: do basic URI validation [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/141367 (https://phabricator.wikimedia.org/T30789) (owner: 10TheDJ) [17:37:33] (03PS11) 10Paladox: Link dialog: do basic URI validation [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/141367 (https://phabricator.wikimedia.org/T30789) (owner: 10TheDJ) [17:38:33] (03CR) 10Paladox: "recheck" [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/176927 (https://phabricator.wikimedia.org/T40829) (owner: 10Happy5214) [17:39:14] (03PS12) 10Paladox: Link dialog: do basic URI validation [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/141367 (https://phabricator.wikimedia.org/T30789) (owner: 10TheDJ) [17:39:55] (03CR) 10jenkins-bot: [V: 04-1] Pre-fill fields in image dialog when image code is selected in editor [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/176927 (https://phabricator.wikimedia.org/T40829) (owner: 10Happy5214) [17:43:27] (03PS11) 10Paladox: Pre-fill fields in image dialog when image code is selected in editor [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/176927 (https://phabricator.wikimedia.org/T40829) (owner: 10Happy5214) [17:43:50] (03CR) 10Paladox: "Fixed all npm errors." [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/176927 (https://phabricator.wikimedia.org/T40829) (owner: 10Happy5214) [17:47:49] (03CR) 10Paladox: "recheck" [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/255083 (https://phabricator.wikimedia.org/T62695) (owner: 102nd-player) [17:51:08] (03CR) 10jenkins-bot: [V: 04-1] Substitute {{SITENAME}} in the title of dialogs [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/255083 (https://phabricator.wikimedia.org/T62695) (owner: 102nd-player) [17:59:31] (03PS15) 10Paladox: Replace step-by-step publishing with publish-staying-in-editmode [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/71617 (owner: 10VitaliyFilippov) [17:59:41] (03CR) 10Paladox: "Rebased." [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/71617 (owner: 10VitaliyFilippov) [18:00:52] (03CR) 10jenkins-bot: [V: 04-1] Replace step-by-step publishing with publish-staying-in-editmode [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/71617 (owner: 10VitaliyFilippov) [18:02:29] (03PS16) 10Paladox: Replace step-by-step publishing with publish-staying-in-editmode [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/71617 (owner: 10VitaliyFilippov) [18:04:05] (03CR) 10jenkins-bot: [V: 04-1] Replace step-by-step publishing with publish-staying-in-editmode [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/71617 (owner: 10VitaliyFilippov) [18:06:46] (03PS17) 10Paladox: Replace step-by-step publishing with publish-staying-in-editmode [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/71617 (owner: 10VitaliyFilippov) [18:08:01] (03CR) 10jenkins-bot: [V: 04-1] Replace step-by-step publishing with publish-staying-in-editmode [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/71617 (owner: 10VitaliyFilippov) [18:20:10] (03CR) 10Paladox: [C: 04-1] "Needs documentation" [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/71617 (owner: 10VitaliyFilippov) [18:23:34] (03PS2) 10Paladox: Substitute {{SITENAME}} in the title of dialogs [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/255083 (https://phabricator.wikimedia.org/T62695) (owner: 102nd-player) [18:24:06] (03CR) 10Paladox: "Fixed npm errors." [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/255083 (https://phabricator.wikimedia.org/T62695) (owner: 102nd-player) [18:39:16] 10VisualEditor, 10VisualEditor-MediaWiki: Sometimes user-inserted ISBNs don't get converted to magic links somehow, meaning Parsoid has to nowiki them… - https://phabricator.wikimedia.org/T117165#1832011 (10Bgwhite) @cscott As Shakespeare said, "Don't shoot the messenger" [19:54:02] edsanders|away: You reviewing https://gerrit.wikimedia.org/r/#/c/254648/ ? [19:55:10] Krenair, looking good - you working on the edit tab preference dialog next? [19:55:15] Kemayo, so as far as TAB and SHIFT+TAB are concerned [19:55:21] we should add them to this list of blocked commands [19:55:26] they should no nothing, unless they do something [19:55:31] currently they natively focus the next widget on the page, blurring the surface, unless you are in a list [20:06:24] (03CR) 10Esanders: [C: 04-1] Fix range mapping logic for node merging on deletion (032 comments) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/254648 (https://phabricator.wikimedia.org/T118870) (owner: 10Divec) [20:16:18] 10WikiEditor, 5Patch-For-Review: {{SITENAME}} not parsed: "Publish to {{SITENAME}}" as message box title when $wgDefaultUserOptions['wikieditor-publish'] = 1 - https://phabricator.wikimedia.org/T62695#1832348 (10Fomafix) `{{SITENAME}}` should parsed on server side. [20:57:35] edsanders: Where's this blocking list located? [21:05:40] (03CR) 10Esanders: [C: 032] "Left a tech-debt comment" (031 comment) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/254648 (https://phabricator.wikimedia.org/T118870) (owner: 10Divec) [21:09:31] well [21:09:38] Kemayo, we have one for triggers [21:09:49] (03Merged) 10jenkins-bot: Fix range mapping logic for node merging on deletion [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/254648 (https://phabricator.wikimedia.org/T118870) (owner: 10Divec) [21:16:48] I think that will work [21:16:50] ve.ce.Surface.prototype.isBlockedTrigger [21:17:52] 10VisualEditor, 10Graph, 10Graph-VisualEditor: VisualEditor throws exception while trying to open empty node - https://phabricator.wikimedia.org/T109667#1555725 (10Yurik) [21:18:33] I can write the patch [21:22:26] 10VisualEditor, 10VisualEditor-ContentEditable, 5WMF-deploy-2015-12-08_(1.27.0-wmf.8): Enter,Enter,Backspace at the beginning of a paragraph breaks the selection - https://phabricator.wikimedia.org/T118870#1832488 (10Jdforrester-WMF) 5Open>3Resolved [21:30:59] edsanders: Actually, adding the linear handler for it makes it nigh-impossible for blockedtrigger to ever come up, I think? [21:31:28] yes, but there won't be a linear handler for now [21:31:34] There is, though. [21:31:51] only in a list [21:32:33] Once my patch is approved there would be, though. [21:32:47] ...which I suppose means I should check whether it's now blocking the list behavior of tab. [21:32:51] Also the idea behind the block list is that we never want the native behaviour, even if someone creates a VE target that doesn't load various triggers [21:33:10] e.g. if a light editor didn't load the Underline trigger - we'd still want to block CTRL+U native [21:33:34] Okay, side-effect of my table-tab keydown patch: the list trigger on tabs doesn't run any more. [21:35:55] (03PS1) 10Esanders: Add tab and shift+tab to blocked triggers list [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/255452 [21:36:00] Suggested alternative to our current behavior in ve.ce.Surface: instead of `if handler then handler() else trigger() end`, how about `if handler then handler() end; if not event.defaultPrevented() then trigger() end` [21:38:37] * James_F waits for Kemayo and edsanders to work out strategy before doing another pull-through. [21:38:43] edsanders: Think that'd cause any weird side effects? I don't know if there are any handlers out there which might want to do something but not cancel the default... [21:39:33] (In a trigger-colliding sort of way.) [21:41:49] hm [21:42:25] arrow keys may or may not prevent default - with no meaningful difference [21:42:51] Enter? maybe [21:43:09] I guess that prevents default as well [21:45:51] Could also adjust the returns of KeyDownHandlerFactory.executeHandlersForKey and KeyDownHandler.execute to "@return [boolean] did something happen?" rather than the current "was there a handler at all?" [21:46:33] Bigger change, requiring more reading through and thinking about it, but arguably more explicit. [21:46:51] Honestly, I think e.preventDefault() is a good proxy for that, though. [21:48:25] except for the cases where we don't preventDefault for linear arrow keys (even though they have been "handled") [21:49:15] That's true. I suppose it's an edge case if someone ever does decide to add a trigger that fires on an arrow key press. [21:49:39] We can be pretty certain that as-is nobody has one, since it'd currently never ever be possible to have it execute, at least. :D [21:50:18] 10VisualEditor: Update display and ID attributes in the math dialog - https://phabricator.wikimedia.org/T119663#1832526 (10Tchanders) 3NEW a:3Tchanders [21:50:37] so I think returning a boolean is probably best [21:50:51] there's only seven files to modify and they're all in core [21:51:12] Want me to knock up a quick patch for it, or will you extend you tab-blocking change? [21:51:21] then we fix executeHandlersForKey to check if execute returns true [21:51:25] go for it [21:51:51] the tab-block change should be merged regardless [21:52:11] ... I think [21:52:22] :-) [21:52:29] edsanders: If you break everything you have to fix it. [21:52:39] ... we may want an advanced feature in future that allows users to enable it with config [21:53:13] Yeah, arguably "tabbing out to a submit button" or similar is a pretty valid use case. [21:53:16] so if you have a super-light VE surface (paragraph+annotations) you can tab out of it like a text input [21:53:34] but for now that doesn't exist [21:54:06] Would it perhaps hurt our existing users who're employing accessibility tools, even outside of that case? [21:54:22] Kemayo: We have a short-cut to the save button already in VE-MW. [21:54:41] You could also achieve that by having "execute" claimed it was handled (using your patch), but then not preventing default :) [21:54:42] Kemayo: VE-WordPress or whatever would have to implement it too to be accessible, which is not ideal but… [21:55:25] I think it's common for rich text editors to not allow tab [21:55:32] we could use escape to blur [21:55:52] currently escape tries to switch to read mode in VE-MW [21:56:03] which is arguably not so helpful [21:56:30] we could have escape -> blur document + focus toolbar, escape again -> switch to read [21:56:40] the former would be a core feature [21:56:58] although then you can't get to the next focusable element, hmm [22:09:54] (03PS1) 10DLynch: Change behavior of keydownhandler execution [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/255461 [22:12:34] 10VisualEditor: Ensure the formula preview is vertically centered in the math dialog - https://phabricator.wikimedia.org/T119670#1832616 (10Tchanders) 3NEW a:3Tchanders [22:13:49] (03CR) 10DLynch: [C: 032] "As was mentioned, we might want to add a way to suppress this in the future for accessibility reasons. Doesn't really apply to our current" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/255452 (owner: 10Esanders) [22:17:23] (03Merged) 10jenkins-bot: Add tab and shift+tab to blocked triggers list [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/255452 (owner: 10Esanders) [22:18:42] I know in Flow there are no tools for lists, but they deliberately left the commands and sequences to you can still write them. [22:19:36] We could also take the GMail approach [22:19:49] which is that TAB/Shift+TAB are *never* overriden [22:20:06] and identation is done with CTRL+[ [22:20:57] Please let's not. [22:21:41] The problem is we're using the same keyboard mappings for a document editor as for a micro text input [22:22:27] * James_F nods. [22:24:58] document editors typically have separate keyboard shortcuts for focussing the menu (alt+F(ile), E(dit) etc.) [22:25:28] we have the problem of having other things on the page (sidebar, search bar, personal nav bar) [22:27:07] CKEditor uses our current behaviour (pre-these patches), so tab/shift+tab changes list indentation if possible, otherwise changes focus [22:28:44] 10VisualEditor, 10Math, 5WMF-deploy-2015-12-08_(1.27.0-wmf.8): Ensure the formula preview is vertically centered in the math dialog - https://phabricator.wikimedia.org/T119670#1832672 (10Jdforrester-WMF) 5Open>3Resolved p:5Triage>3Normal [22:30:05] 10VisualEditor, 10Math, 5WMF-deploy-2015-12-08_(1.27.0-wmf.8): [Regression pre-wmf.8] Update display and ID attributes in the math dialog - https://phabricator.wikimedia.org/T119663#1832677 (10Jdforrester-WMF) 5Open>3Resolved p:5Triage>3High [22:30:12] 10VisualEditor, 10Math, 5WMF-deploy-2015-12-08_(1.27.0-wmf.8): [Regression pre-wmf.8] Update display and ID attributes in the math dialog - https://phabricator.wikimedia.org/T119663#1832526 (10Jdforrester-WMF) [22:56:56] (03CR) 10Esanders: [C: 04-1] Change behavior of keydownhandler execution (032 comments) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/255461 (owner: 10DLynch) [22:58:20] Kemayo: Want me to fix? [22:58:37] (03PS2) 10DLynch: Change behavior of keydownhandler execution [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/255461 [22:58:41] Ha. [22:59:06] I of course maintain that tablen is clearly a recognized variant spelling of taken. [22:59:16] :-) [23:01:12] (03CR) 10Esanders: [C: 032] Change behavior of keydownhandler execution [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/255461 (owner: 10DLynch) [23:02:42] [19:55:10] Krenair, looking good - you working on the edit tab preference dialog next? [23:02:44] hi [23:02:46] did you test it? [23:03:05] I did [23:03:06] Is that part of the task now? [23:03:13] did you not manage to break it? [23:03:16] um [23:03:30] well - I had to use a new account to get it to work [23:03:42] but I think I have preferences and cookies set in my existing one [23:04:00] the dialog is a blocker to use releasing this at least [23:06:48] (03Merged) 10jenkins-bot: Change behavior of keydownhandler execution [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/255461 (owner: 10DLynch) [23:10:36] (03PS4) 10DLynch: When the cursor is inside a table cell, tab moves between cells [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/255160 (https://phabricator.wikimedia.org/T119545) [23:10:59] Okay, that now no longer conflicts with the tab-in-lists. [23:11:19] That sounds like a good outcome. :-) [23:11:57] Though I suppose that if you ever try to edit a list inside a table cell, it might have some concerns. :-P [23:12:09] Eh. We have those from time to time. [23:18:36] Kemayo: Do you think it should wrap if at the last cell in a row? [23:20:30] Also, if you have a cursor active in a merged cell and tab/shift-tab, the result is a multi-cell selection covering the whole area of the previous cell, but if you do it from a cell selection it's just the single next/previous cell. [23:20:34] I was just about to ask [23:20:46] [23:20:47] lists inside table cells is actually not going to be as rare as you think [23:21:49] Hmm. Wrapping at the end could actually be useful, I suppose. Particularly if when you reach the very last cell in the table, it then jumps the cursor out of the table entirely -- something there's currently no way to do at all. [23:21:53] e.g. https://en.wikipedia.org/wiki/David_Bowie_discography [23:22:18] Kemayo: Yeah. [23:22:27] Lists in tables is fine. [23:22:44] Kemayo: You clocking off for the holiday? Should I whine on gerrit instead? :-) [23:23:04] I'm still around for a little bit at least. [23:23:07] I'm not sure about magically changing the behaviour based on the grandparent context [23:23:47] I think it's better than adding a list in a cell -> table navigation is broken. [23:24:01] Table navigation is more important than indent/outdent. [23:25:44] Could make it so that it looks to see whether it's contained in a list first. But then you'd have to perhaps create a place outside the list so that you can navigate the table. [23:26:18] :-( [23:26:18] Could also bypass this somewhat by adding cmd-[ and cmd-] as secondary bindings to the indent/outdent command. Then they'd always be accessible in this case. [23:28:41] Should the existing arrow-key navigation make the table selection wrap as well? [23:30:39] double binding might be useful [23:31:17] assuming it is unused [23:38:15] It is, yeah. [23:44:13] Well. Apart from the mac back/forward history bindings, I suppose. [23:47:18] Though we already suppress the cmd-arrow bindings for the same, so. [23:53:18] Heh, funny story. isBlockedTrigger is entirely broken on macs. [23:53:38] Because it's written with "cmd+", and what it's getting passed is "meta+". [23:57:03] (03PS1) 10DLynch: isBlockedTrigger should use meta+ for macs, not cmd+ [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/255474