[00:09:50] (03CR) 10Jforrester: [C: 031] "This might explain some Safari gremlins…" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/255474 (owner: 10DLynch) [00:09:50] Kemayo, our bold trigger is cmd+b [00:10:05] see ve.ui.TriggerRegistry.js [00:10:43] Yeah, but my point is that none of those things in isBlockedTrigger would /ever/ do anything. [00:11:19] You press 'cmd+b', and trigger.toString() in that check is going to output 'meta+b'. [00:11:28] only if bold trigger is registered [00:11:42] if I created a surface that unregistered it, we should still preventDefault [00:12:07] (03CR) 10Esanders: [C: 04-1] "we still need to block cmd+b etc. as a fall through" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/255474 (owner: 10DLynch) [00:12:14] It has no relation to whether the trigger's registered, though. [00:12:42] that is correct [00:12:45] This change is what'll actually make it be preventDefault'd if we unregister it. [00:13:15] cmd+b triggers *native* CE behaviour if not prevented [00:13:27] (03CR) 10DLynch: "Nope! 'cmd+b' doesn't exist as a possible output of trigger.toString()." [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/255474 (owner: 10DLynch) [00:14:08] so if cmd+b isn't possible, how is our bold trigger working? [00:14:19] When you create a trigger it normalizes things. [00:14:29] Via ve.ui.Trigger.static.keyAliases [00:14:38] One of which is `cmd: 'meta'` [00:15:51] esanders: console demo: https://usercontent.irccloud-cdn.com/file/d3IfagRu/ [00:17:42] ah [00:18:03] I guess we should use the normalised form to avoid confusion [00:18:14] Also to make it work at all, yes. [00:18:29] :-) [00:18:45] (03CR) 10Jforrester: [C: 032] isBlockedTrigger should use meta+ for macs, not cmd+ [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/255474 (owner: 10DLynch) [00:19:16] I mean in the trigger registry [00:19:54] Alternately, and less prone to errors... we could actually create a ve.ui.Trigger from each of those strings in the blocked registry and then compare the toString() of those to the toString() of the trigger passed into it. [00:20:18] Then we never have to actually care about what the aliases are. [00:20:41] yeah - although we can probably cache the results [00:21:07] Definitely should -- right now it's creating that list every time. Could stick it as a static property and have it just be made on startup. [00:21:44] Given that it gets checked on every keypress, the initial overhead doesn't seem like much of a waste. [00:23:42] (03CR) 10Jforrester: [C: 04-1] "* If you have a cursor active in a merged cell and tab/shift-tab, the result is a multi-cell selection covering the whole area of the prev" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/255160 (https://phabricator.wikimedia.org/T119545) (owner: 10DLynch) [00:26:38] James_F: "merged cell"? [00:26:52] (03Merged) 10jenkins-bot: isBlockedTrigger should use meta+ for macs, not cmd+ [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/255474 (owner: 10DLynch) [00:27:08] Kemayo: E.g. cell "16" in demos/ve/desktop.html#!pages/tables.html [00:27:32] Kemayo: Multi-cell? Eh. [00:28:07] Is there actually any way to create those in-VE without having dropped down to wikitext / HTML somewhere? :) [00:28:17] Yes. [00:28:23] Same way as in SA. [00:28:45] Select multiple ones and click the "table" icon in the toolbar to find the menu with the option. [00:28:46] the table toolbar menu [00:28:58] Ah, right, I forget about that button. [00:29:05] And yes, this is a hack that edsanders needs to fix by making it a table context menu. [00:31:47] (03CR) 10Esanders: "shift tab in the first cell does nothing in Google docs. I'm ok if it does nothing for this patch" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/255160 (https://phabricator.wikimedia.org/T119545) (owner: 10DLynch) [00:31:56] edsanders: Sure. [00:32:41] (03PS1) 10DLynch: Add cmd+[ / cmd+] as extra bindings for indent/outdent trigger [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/255482 [00:35:25] (03CR) 10Jforrester: [C: 031] Add cmd+[ / cmd+] as extra bindings for indent/outdent trigger [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/255482 (owner: 10DLynch) [00:42:22] (03CR) 10DLynch: "Interestingly, the merged cell behavior can be replicated by putting a cursor into a merged cell, pressing escape to select the whole cell" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/255160 (https://phabricator.wikimedia.org/T119545) (owner: 10DLynch) [00:42:50] Kemayo: Existing bug? [00:43:14] If exiting a cell via esc is supposed to produce an identical state to having clicked on that cell, yes. [00:43:28] * James_F loads master and tries. [00:45:53] It does seem to happen on master, definitely. [00:50:49] Difference being that the ve.dm.TableSelection produced has different values for the "intendedTo/From" column/row. [00:50:57] * James_F nods [00:52:17] I'm inclined to think that collapsing the intended to the top-left like clicking does generally makes sense, in this case. [00:53:52] Or, the only thing that could arguably make more sense is analyzing the cursor position and trying to line it up to the table grid. [00:54:27] Which sounds like a lot more work, in the name of probably feeling very unpredictable to people who use it. [00:54:37] The behaviour right now with that patch when the initial selection is correct is perfect. [00:54:45] s/correct/a cell/ [00:54:48] * James_F sighs. [00:59:55] (03PS1) 10Jforrester: Update VE core submodule to master (3163552) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/255486 [01:04:10] (03PS5) 10DLynch: When the cursor is inside a table cell, tab moves between cells [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/255160 (https://phabricator.wikimedia.org/T119545) [01:05:05] James_F: Want me to change how pressing escape behaves as well, or does that make more sense? [01:23:30] 10VisualEditor, 10VisualEditor-MediaWiki: VisualEditor: Provide buttons for locally-configured frequent edit summary contents - https://phabricator.wikimedia.org/T54085#1833125 (10Quiddity) [01:27:35] 10VisualEditor, 10VisualEditor-MediaWiki: VisualEditor: For edit summary field, give users an auto-fill drop-down (or similar) of recent edit summaries they've used - https://phabricator.wikimedia.org/T50274#1833143 (10Quiddity) [02:18:56] (03PS1) 10DLynch: Collapse table selection when pressing escape [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/255494 [02:21:35] On reflection, I think it's the right thing to do regardless, so. [06:45:36] 10VisualEditor, 10VisualEditor-MediaWiki, 10Math, 7Epic: [Objective] Improve support for math editing by improving the UX of the Math extension and researching its usability - https://phabricator.wikimedia.org/T118616#1833292 (10SalixAlba) My first though on trying the editor on http://en.wikipedia.beta.wm... [07:12:37] 10VisualEditor: Delete link action seems inconsistent - https://phabricator.wikimedia.org/T119615#1833315 (10Florian) > having a different height I wanted to report this problem, and found this task, which already mentions it. But one thought: The task itself seems to report (and tries to address) multiple probl... [09:48:04] 10Cite: Cite extension has started acting weirdly - https://phabricator.wikimedia.org/T119692#1833384 (10fbstj) 3NEW [10:19:50] 10VisualEditor: Delete link action seems inconsistent - https://phabricator.wikimedia.org/T119615#1833411 (10Pginer-WMF) >>! In T119615#1833315, @Florian wrote: >> having a different height > I wanted to report this problem, and found this task, which already mentions it. But one thought: The task itself seems t... [11:06:30] 10Cite: Raw "" tag displayed on wiki page after upgrade to 1.26 - https://phabricator.wikimedia.org/T119692#1833498 (10Aklapper) [11:09:02] 10Cite: Raw "" tag displayed on wiki page after upgrade to 1.26 - https://phabricator.wikimedia.org/T119692#1833506 (10Aklapper) Hi @fbstj, thanks for taking the time to report this! I hope I changed the task summary correctly. From which version did you upgrade? Any pattern? On the given link, n... [11:32:03] 10Cite: Raw "" tag displayed on wiki page after upgrade to 1.26 - https://phabricator.wikimedia.org/T119692#1833537 (10fbstj) Hey @aklapper I've not yet spotted any consistently here's another example, this time of ` ... ` being weird http://coppermind.net/wiki/Dalinar_Kho... [11:43:41] 10Cite: Raw "" tag displayed on wiki page after upgrade to 1.26 - https://phabricator.wikimedia.org/T119692#1833565 (10fbstj) The main problem is that it's very inconsistent; most of the pages are still working fine. Some pages break with `` but not `` ([[ http://coppermi... [12:56:51] 10VisualEditor, 10VisualEditor-EditingTools: empty link parameter inside image transclusion inside a templates breaks the Template editor - https://phabricator.wikimedia.org/T119706#1833704 (10TheDJ) 3NEW [13:30:38] 10VisualEditor, 10MediaWiki-extensions-MultimediaViewer, 10OOjs-UI: Delete link action seems inconsistent - https://phabricator.wikimedia.org/T119615#1833793 (10Florian) Makes sense :) I know found the same problem for the MultimediaViewer button on a file description page: {F3016334} (source: e.g. https://... [14:07:31] 10VisualEditor, 10MediaWiki-extensions-MultimediaViewer, 10OOjs-UI: Delete link action seems inconsistent - https://phabricator.wikimedia.org/T119615#1833852 (10matmarex) {T113495}. [14:45:29] 10VisualEditor, 10MediaWiki-extensions-MultimediaViewer, 10OOjs-UI: Delete link action seems inconsistent - https://phabricator.wikimedia.org/T119615#1830945 (10Pginer-WMF) [14:46:38] 10VisualEditor, 10MediaWiki-extensions-MultimediaViewer, 10OOjs-UI: Delete link action seems inconsistent - https://phabricator.wikimedia.org/T119615#1830945 (10Pginer-WMF) I added the examples to T113495, which is the ticket for the general issue and connected both tickets properly. Thanks @Florian and @mat... [14:47:56] 10VisualEditor, 10MediaWiki-extensions-MultimediaViewer, 10OOjs-UI: Delete link action seems inconsistent - https://phabricator.wikimedia.org/T119615#1833935 (10Pginer-WMF) [15:22:54] 10WikiEditor: Localized toolbar buttons to the Chechen language - https://phabricator.wikimedia.org/T119716#1833987 (10Reedy) p:5High>3Normal [15:24:17] 10WikiEditor: Localized toolbar buttons to the Chechen language - https://phabricator.wikimedia.org/T119716#1833960 (10Reedy) So you want https://github.com/wikimedia/mediawiki-extensions-WikiEditor/blob/master/modules/images/toolbar/format-bold-ru.png replacing with https://commons.wikimedia.org/wiki/File:Toolb... [15:39:35] 10WikiEditor: Localized toolbar buttons to the Chechen language - https://phabricator.wikimedia.org/T119716#1833993 (10Umar) I do not know English, and I do not understand [15:42:23] 10WikiEditor: Localized toolbar buttons to the Chechen language - https://phabricator.wikimedia.org/T119716#1834001 (10Umar) so this change in the https://commons.wikimedia.org/wiki/File:Toolbaricon_bold_%D3%80%D0%B0%D1%8C.png [15:44:04] 10WikiEditor: Localized toolbar buttons to the Chechen language - https://phabricator.wikimedia.org/T119716#1834002 (10Umar) Ж → Ӏаь [15:47:10] 10WikiEditor: Localized toolbar buttons to the Chechen language - https://phabricator.wikimedia.org/T119716#1834003 (10Umar) It must be so http://pastenow.ru/Upload/Paste/FUUE.png I hope I have explained [16:44:21] 10Citoid: imbd not working on zotero on localhost (looks like in production too) - https://phabricator.wikimedia.org/T119729#1834168 (10Mvolz) 3NEW [17:37:36] 10Citoid: imbd not working on zotero on localhost (looks like in production too) - https://phabricator.wikimedia.org/T119729#1834284 (10mobrovac) Citoid in production returns: ``` $ curl "http://localhost:1970/api?format=mediawiki&search=http%3A%2F%2Fwww.imdb.com%2Ftitle%2Ftt0133093%2F" > GET /api?format=mediaw... [17:59:24] 10VisualEditor, 10MediaWiki-extensions-MultimediaViewer, 10OOjs-UI: Delete link action seems inconsistent - https://phabricator.wikimedia.org/T119615#1834293 (10Jhernandez) p:5Triage>3Normal [18:02:23] 10WikiEditor: Localized toolbar buttons to the Chechen language - https://phabricator.wikimedia.org/T119716#1834296 (10Aklapper) p:5Normal>3Low [21:27:12] (03CR) 10Esanders: "what bug does this fix?" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/255494 (owner: 10DLynch) [21:28:32] Stop working on a holiday, Ed. [21:32:18] (03CR) 10DLynch: "If you open up the tables demo and choose the merged cell labeled "16", get your cursor into it, then press escape to select the entire ce" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/255494 (owner: 10DLynch) [21:35:35] (03CR) 10Esanders: [C: 032] Collapse table selection when pressing escape [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/255494 (owner: 10DLynch) [21:39:04] (03Merged) 10jenkins-bot: Collapse table selection when pressing escape [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/255494 (owner: 10DLynch)