[00:49:00] 10VisualEditor, 10VisualEditor-MediaWiki, 5Patch-For-Review, 7Performance: ext.visualEditor.data causes cache churn - https://phabricator.wikimedia.org/T119750#1837480 (10ori) >>! In T119750#1837209, @Esanders wrote: > @Ori would it be better if we moved this to a separate module which is only loaded when... [01:06:29] 10VisualEditor, 10VisualEditor-MediaWiki, 5Patch-For-Review, 7Performance: ext.visualEditor.data causes cache churn - https://phabricator.wikimedia.org/T119750#1837484 (10ori) You could get this information from the API, via `/w/api.php?action=query&meta=siteinfo&format=json&siprop=extensions`. If you did... [05:46:50] 10TemplateData, 10MediaWiki-Templates: Add ignoreCase flag to templates {{{param}}} - https://phabricator.wikimedia.org/T118754#1837549 (10Liuxinyu970226) [06:10:44] (03CR) 10Divec: [C: 031] "This looks good to me, but someone should play around in a variety of browsers checking the effects of "white-space: pre-wrap" on text ent" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/255931 (https://phabricator.wikimedia.org/T55931) (owner: 10Bartosz Dziewoński) [06:26:18] 10TemplateData: TemplateData: Add a tracking category to all templates that don't have a TemplateData block - https://phabricator.wikimedia.org/T72242#1837582 (10Liuxinyu970226) [06:26:42] 10Cite: MediaWiki message with tracking category and - https://phabricator.wikimedia.org/T46504#1837586 (10Liuxinyu970226) [07:25:23] 10VisualEditor, 10VisualEditor-ContentLanguage: In 2-Set Korean IME when typing inside a table cell and pressing space selection and cursor disappear - https://phabricator.wikimedia.org/T86592#1837609 (10dchan) Hi, I think this may work OK now: can you try https://rawgit.com/wikimedia/VisualEditor/master/demos... [08:00:08] 10VisualEditor, 10VisualEditor-ContentEditable, 10VisualEditor-ContentLanguage: After selecting table cell by single clicking, typing with any IME does not work - https://phabricator.wikimedia.org/T86589#1837613 (10dchan) Inez, now that we've fixed some timing issues I think this solution may be safe - I'll... [08:05:52] (03PS19) 10Divec: Diff richtext to build model changes [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/247800 (https://phabricator.wikimedia.org/T76056) [08:07:37] 10VisualEditor, 10VisualEditor-ContentEditable, 10VisualEditor-ContentLanguage, 5Patch-For-Review: Observed changes: widen heuristic criteria for guessing a change is simple - https://phabricator.wikimedia.org/T114260#1837623 (10dchan) With change 247800, every observed DOM change should be simple (i.e. th... [08:09:14] 10VisualEditor, 10VisualEditor-ContentEditable, 10VisualEditor-ContentLanguage, 7Epic, 5Patch-For-Review: Non-local text changes cause CE updates that close IME candidate window - https://phabricator.wikimedia.org/T76056#1837624 (10dchan) With change 247800, every observed DOM change should be simple (i.... [08:10:04] (03PS20) 10Divec: Diff richtext to build model changes [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/247800 (https://phabricator.wikimedia.org/T72353) [08:12:52] 10VisualEditor, 10VisualEditor-ContentLanguage, 5Patch-For-Review: Cannot type in Korean using Mozilla on Windows 7 with dual-script keyboard - https://phabricator.wikimedia.org/T72353#1837627 (10dchan) I have optimistically tagged this bug in change 247800, because it will fix many DOM/DM synchronization er... [08:38:00] 10Citoid, 10VisualEditor: In Citoid, magically follow URLs provided in non-link fields (e.g. link rel="publisher") to scrape more info from there - https://phabricator.wikimedia.org/T118773#1837644 (10Mvolz) p:5Low>3High [08:38:23] 10Citoid, 10VisualEditor: In Citoid, magically follow URLs provided in non-link fields (e.g. link rel="publisher") to scrape more info from there - https://phabricator.wikimedia.org/T118773#1837646 (10Mvolz) p:5High>3Normal a:3Mvolz [08:39:02] 10Citoid, 10VisualEditor: In Citoid, magically follow URLs provided in non-link fields (e.g. link rel="publisher") to scrape more info from there - https://phabricator.wikimedia.org/T118773#1808999 (10Mvolz) Raising to Normal as the community seems to think this is more of a priority :) [08:43:39] 10Citoid, 10VisualEditor: In Citoid, magically follow URLs provided in non-link fields (e.g. link rel="publisher") to scrape more info from there - https://phabricator.wikimedia.org/T118773#1837648 (10Mvolz) [08:55:12] 10Citoid, 10VisualEditor: WorldCat URLs not importing ISBN information correctly - https://phabricator.wikimedia.org/T116056#1837681 (10Mvolz) @mobrovac - tested, and this seems to be due to an outdated translator- https://github.com/zotero/translators/commit/d422595a602080b89ee850e045695af4c20df74c Can we up... [08:58:13] 10Citoid, 10VisualEditor: ISBN field validation bug chunks multiple ISBNs in a field inappropriately. - https://phabricator.wikimedia.org/T116056#1837687 (10Mvolz) [08:59:01] 10Citoid, 10VisualEditor, 6Services: Update translators from upstream (to fix worldcat bug) - https://phabricator.wikimedia.org/T119860#1837695 (10Mvolz) 3NEW [09:01:03] 10Citoid: Citoid picks up a 'pl-pl' language for a page - https://phabricator.wikimedia.org/T118045#1837701 (10Mvolz) [09:01:05] 10Citoid: Many language wiki templates (pl, it, en) don't accept xx-XX style language codes - https://phabricator.wikimedia.org/T115326#1837702 (10Mvolz) [09:03:14] 10Citoid: Many language wiki templates (pl, it, en) don't accept xx-XX style language codes - https://phabricator.wikimedia.org/T115326#1837712 (10Mvolz) @Elitre, re moving things forward- I think we are basically still undecided on what to do. A possible fix, which is safe probably for most templates, is to st... [09:03:45] 10Citoid: Many language wiki templates (pl, it, en) don't accept xx-XX style language codes - https://phabricator.wikimedia.org/T115326#1837713 (10Mvolz) p:5Triage>3Normal [09:04:08] 10Citoid: Many language wiki templates (pl, it, en) don't accept xx-XX style language codes - https://phabricator.wikimedia.org/T115326#1837714 (10Mvolz) a:3Mvolz [09:05:27] 10Citoid, 10VisualEditor, 3Google-Code-In-2015: Use en dash instead of hyphen-minus between page numbers - https://phabricator.wikimedia.org/T113570#1837719 (10Mvolz) [09:27:23] 10WikiEditor: Localized toolbar buttons to the Chechen language - https://phabricator.wikimedia.org/T119716#1837768 (10Paladox) Hi could there also be a svg version too please. Since it carnt be replaced without an svg version since the svg version of buttons will show not pong only pong will be a fallback if th... [09:52:45] 10Citoid: Many language wiki templates (pl, it, en) don't accept xx-XX style language codes - https://phabricator.wikimedia.org/T115326#1837806 (10mobrovac) >>! In T115326#1837712, @Mvolz wrote: > A possible fix, which is safe probably for most templates, is to stick to two-three letter language codes, but there... [10:49:51] 10WikiEditor: Localized toolbar buttons to the Chechen language - https://phabricator.wikimedia.org/T119716#1837889 (10Umar) this? https://commons.wikimedia.org/wiki/File:Toolbaricon_bold_%D3%80%D0%B0%D1%8C.svg [11:19:16] (03PS2) 10Esanders: Avoid embedding Git metadata in ext.visualEditor.data [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/255812 (https://phabricator.wikimedia.org/T119750) (owner: 10Ori.livneh) [11:19:43] (03CR) 10Esanders: [C: 031] "Added API call replacement as suggested on T119750" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/255812 (https://phabricator.wikimedia.org/T119750) (owner: 10Ori.livneh) [11:21:44] (03CR) 10jenkins-bot: [V: 04-1] Avoid embedding Git metadata in ext.visualEditor.data [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/255812 (https://phabricator.wikimedia.org/T119750) (owner: 10Ori.livneh) [11:22:52] (03PS1) 10Esanders: Re-order contributors [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/255979 [11:23:40] (03PS1) 10Esanders: Re-order contributors [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/255980 [11:35:04] (03PS3) 10Krinkle: Avoid embedding Git metadata in ext.visualEditor.data [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/255812 (https://phabricator.wikimedia.org/T119750) (owner: 10Ori.livneh) [11:35:21] (03CR) 10Krinkle: [C: 031] Avoid embedding Git metadata in ext.visualEditor.data [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/255812 (https://phabricator.wikimedia.org/T119750) (owner: 10Ori.livneh) [11:37:18] (03CR) 10Krinkle: Avoid embedding Git metadata in ext.visualEditor.data (032 comments) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/255812 (https://phabricator.wikimedia.org/T119750) (owner: 10Ori.livneh) [11:44:13] (03CR) 10Esanders: [C: 032] Define 'space' as a trigger key [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/255935 (owner: 10Bartosz Dziewoński) [11:45:39] (03CR) 10Esanders: [C: 032] Avoid embedding Git metadata in ext.visualEditor.data [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/255812 (https://phabricator.wikimedia.org/T119750) (owner: 10Ori.livneh) [11:48:29] (03Merged) 10jenkins-bot: Avoid embedding Git metadata in ext.visualEditor.data [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/255812 (https://phabricator.wikimedia.org/T119750) (owner: 10Ori.livneh) [12:03:16] 10Citoid: Many language wiki templates (pl, it, en) don't accept xx-XX style language codes - https://phabricator.wikimedia.org/T115326#1838011 (10Mvolz) I think we agree on that, just which standard, is the issue. [12:15:27] 10VisualEditor: Edit box for undescribed templates mentions "adding" template even if editing previously added template - https://phabricator.wikimedia.org/T119868#1838015 (10Yair_rand) 3NEW [12:54:16] (03PS2) 10Bartosz Dziewoński: Define 'space' as a trigger key [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/255935 [12:54:26] (03CR) 10Bartosz Dziewoński: "Just realized I put them in a weird order, fixed now." [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/255935 (owner: 10Bartosz Dziewoński) [12:55:44] 10VisualEditor, 10OOjs-UI, 7I18n, 5OOjs-UI-0.14.0, and 2 others: "Select a file" does not appear localized in the VisualEditor - https://phabricator.wikimedia.org/T119307#1838063 (10Amire80) Thank you for the quick fix! [12:59:13] (03CR) 10Esanders: [C: 032] Define 'space' as a trigger key [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/255935 (owner: 10Bartosz Dziewoński) [14:25:09] 10Citoid, 10VisualEditor: ISBN field validation bug chunks multiple ISBNs in a field inappropriately. - https://phabricator.wikimedia.org/T116056#1838150 (10mobrovac) >>! In T116056#1837681, @Mvolz wrote: > Can we update upstream? There are more than 300 new commits in upstream. @mvolz, please create a patch... [15:12:12] (03CR) 10Esanders: "Tested this on iOS Safari:" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/247800 (https://phabricator.wikimedia.org/T72353) (owner: 10Divec) [15:20:24] (03CR) 10Esanders: "Reproduced in Chrome as well." [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/247800 (https://phabricator.wikimedia.org/T72353) (owner: 10Divec) [15:24:28] edsanders: You testing out https://gerrit.wikimedia.org/r/#/c/255931/ ? [15:43:44] (03CR) 10Esanders: [C: 04-1] Diff richtext to build model changes (031 comment) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/247800 (https://phabricator.wikimedia.org/T72353) (owner: 10Divec) [15:43:46] (03PS21) 10Divec: Diff richtext to build model changes [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/247800 (https://phabricator.wikimedia.org/T72353) [15:45:37] (03PS22) 10Divec: Diff richtext to build model changes [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/247800 (https://phabricator.wikimedia.org/T72353) [15:47:07] (03CR) 10Divec: "Thanks, fixed (it wasn't excluding inline slug spans from being treated as annotations)" (031 comment) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/247800 (https://phabricator.wikimedia.org/T72353) (owner: 10Divec) [15:49:49] 10VisualEditor, 10VisualEditor-MediaWiki, 7Performance, 5WMF-deploy-2015-12-08_(1.27.0-wmf.8): ext.visualEditor.data causes cache churn - https://phabricator.wikimedia.org/T119750#1838245 (10Jdforrester-WMF) 5Open>3Resolved a:3ori [15:50:04] (03PS1) 10Jforrester: Avoid embedding Git metadata in ext.visualEditor.data [extensions/VisualEditor] (wmf/1.27.0-wmf.7) - 10https://gerrit.wikimedia.org/r/256015 (https://phabricator.wikimedia.org/T119750) [15:58:27] 10VisualEditor, 10VisualEditor-ContentEditable, 10VisualEditor-ContentLanguage: After selecting table cell by single clicking, typing with any IME does not work - https://phabricator.wikimedia.org/T86589#1838275 (10dchan) Hah, contrary to my prediction, with this change I can consistently *segfault* Firefox... [15:59:03] 10VisualEditor, 10VisualEditor-ContentEditable, 10VisualEditor-ContentLanguage: After selecting table cell by single clicking, typing with any IME does not work - https://phabricator.wikimedia.org/T86589#1838278 (10Jdforrester-WMF) Gosh. Another one for @Catrope's list. [16:25:10] 10VisualEditor, 10VisualEditor-ContentEditable, 5Patch-For-Review, 7Technical-Debt: VisualEditor: Move to using white-space: pre-wrap instead of using nbsp's to fake spaces - https://phabricator.wikimedia.org/T55931#1838400 (10Jdforrester-WMF) a:3matmarex [16:33:20] James_F: the two (unrelated) things i was hoping to swat: https://gerrit.wikimedia.org/r/#/c/255946/ (VE) and https://gerrit.wikimedia.org/r/#/c/255559/ (core, needs merge) [16:37:48] MatmaRex: Meh. I'd rather not do 1= unconditionally. [16:38:27] UploadWizard has always done so, and it makes it easier to edit. [16:39:51] Easier to code, you mean. :-P [16:39:57] VE fixes it automatically. [16:43:12] 10VisualEditor, 10VisualEditor-DataModel, 10VisualEditor-EditingTools: empty link parameter inside image transclusion inside a templates breaks the Template editor - https://phabricator.wikimedia.org/T119706#1838542 (10TheDJ) [16:43:47] James_F: no, it doesn't, because it's a nested template [16:44:10] MatmaRex: OK, VE /will/ fix it automatically when we do DOM template editing. [16:44:15] Aka Parsoid does it for us. [16:44:26] James_F: by that time, we'll probably also have heredoc template parameters. :P [16:44:39] I doubt it. :-) [16:46:29] (03CR) 10Jforrester: [C: 031] "This looked OK to me in Chrome, Firefox and Safari on Mac." [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/255931 (https://phabricator.wikimedia.org/T55931) (owner: 10Bartosz Dziewoński) [16:46:45] 10VisualEditor, 10VisualEditor-ContentEditable, 5Patch-For-Review: In VisualEditor, footnote immediately following a period sometimes wraps to new line even though there is space left in the line - https://phabricator.wikimedia.org/T96487#1838576 (10Jdforrester-WMF) a:3matmarex [17:54:39] (03CR) 10Jforrester: [C: 032] Add cmd+[ / cmd+] as extra bindings for indent/outdent trigger [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/255482 (owner: 10DLynch) [17:58:18] (03Merged) 10jenkins-bot: Add cmd+[ / cmd+] as extra bindings for indent/outdent trigger [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/255482 (owner: 10DLynch) [18:01:45] (03PS1) 10Jforrester: Update VE core submodule to master (3ab893c) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/256035 [18:02:43] (03CR) 10Catrope: [C: 032] Update VE core submodule to master (3ab893c) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/256035 (owner: 10Jforrester) [18:06:21] (03Merged) 10jenkins-bot: Update VE core submodule to master (3ab893c) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/256035 (owner: 10Jforrester) [18:15:39] 10VisualEditor: When a user introduces an internal link with an anchor, VisualEditor silently trims it - https://phabricator.wikimedia.org/T119599#1839107 (10Mattflaschen) [18:29:34] 10VisualEditor, 10MediaWiki-extensions-CodeEditor, 10SyntaxHighlight, 5Patch-For-Review, and 2 others: Can't open two code blocks in one editor session (aka Uncaught TypeError: Cannot read property 'fail' of null) - https://phabricator.wikimedia.org/T119815#1839159 (10Jdforrester-WMF) [18:30:41] 10VisualEditor, 10VisualEditor-ContentEditable, 5Patch-For-Review: Make non-breaking spaces (nbsp) visible in VisualEditor - https://phabricator.wikimedia.org/T96666#1839172 (10Jdforrester-WMF) [18:31:20] 10VisualEditor, 10VisualEditor-ContentEditable, 5Patch-For-Review: Make non-breaking spaces (nbsp) visible in VisualEditor - https://phabricator.wikimedia.org/T96666#1839186 (10Jdforrester-WMF) a:3matmarex [18:33:39] 10VisualEditor, 10VisualEditor-ContentEditable, 5Patch-For-Review: VisualEditor: Ctrl+Space/Opt+Space to insert a non-breaking space (NBSP) - https://phabricator.wikimedia.org/T53045#1839210 (10Jdforrester-WMF) a:3matmarex [18:38:11] divec: I updated https://phabricator.wikimedia.org/P2363 to show where the re-enabling can happen. [18:44:52] https://phabricator.wikimedia.org/P2363 (wrap the whole "if" control block in jscs:disable/enable directives): thanks [18:45:55] divec: Why do you need empty blocks? Something like if ( condition ) { code } else if ( something ) {} else { other code } ? [18:46:07] Exactly [18:46:46] divec_: Can't you just do "if ( condition ) { code } else if ( !something ) { other code }"? [18:48:30] My actual example is: if ( condition1 ) { code } else if ( condition2 ) { /* do nothing */ } else if ( condition3 ) { code } else if ( condition4 ) { code } else if ( condition5 ) { code } [18:48:45] divec_: Sounds like a switch statement. :-) [18:48:49] lol [18:52:41] James_F: Oh yeah true, but my *actual* example has more crazy conditions too (line 73 of https://gerrit.wikimedia.org/r/#/c/247800/22/src/ce/ve.ce.TextState.js ) [18:53:22] divec_: Can't you invert the logic and embed? [18:53:30] So… [18:53:42] if ( condition1 ) { code } else if ( !condition2 ) { if ( condition3 ) { code } else if ( condition4 ) { code } else if ( condition5 ) { code } } [18:53:58] * James_F is horrible. [18:56:25] James_F: haha, you mustn't encourage me with tricks like that :-) [18:56:48] divec_: It's what it logically means. If anything, it's clearer. [18:56:55] * James_F personally really dislikes else-ifs. [19:07:06] 10VisualEditor, 10Flow, 3Collaboration-Team-Current: Insert a mention in any Flow editor (in VE mode) is broken (on master) - https://phabricator.wikimedia.org/T119773#1839371 (10Mattflaschen) [19:29:51] 10VisualEditor, 10Graph, 10Graph-VisualEditor, 10MediaWiki-extensions-CodeEditor: "Script file not found: worker-json.js" appears after opening the Graph editor dialog - https://phabricator.wikimedia.org/T118895#1839434 (10TheDJ) [19:36:17] 10VisualEditor, 10Graph, 10Graph-VisualEditor, 10MediaWiki-extensions-CodeEditor: "Script file not found: worker-json.js" appears after opening the Graph editor dialog - https://phabricator.wikimedia.org/T118895#1839451 (10TheDJ) This is because the editor was not correctly initialized. Please see first pa... [19:37:23] I prefer switch( true ) [19:40:16] divec: you can call $.noop() inside the empty block, too. :P [19:41:31] (i agree that it's sometimes clearer, and i dislike switches because the syntax in javascript is quite awkward) [19:45:53] 10VisualEditor, 6Editing-Department, 10MobileFrontend, 10OOjs-UI, 5WMF-deploy-2015-12-08_(1.27.0-wmf.8): [Regression pre-wmf.8] Opening the wikitext editor fails - https://phabricator.wikimedia.org/T119109#1839490 (10Jdlrobson) This bug concerned me. Did this issue hit production or did we squash it befo... [20:26:42] 10VisualEditor, 6Editing-Department, 10MobileFrontend, 10OOjs-UI, 5WMF-deploy-2015-12-08_(1.27.0-wmf.8): [Regression pre-wmf.8] Opening the wikitext editor fails - https://phabricator.wikimedia.org/T119109#1839535 (10Jdforrester-WMF) >>! In T119109#1839490, @Jdlrobson wrote: > This bug concerned me. Did... [20:35:03] Oh man, switch(true) [20:35:09] C doesn't let you have non-constant case expressions [20:50:23] 10VisualEditor: [Regression pre-wmf.8] Formulae inspector is broken - https://phabricator.wikimedia.org/T119900#1839579 (10Ryasmeen) 3NEW [20:54:53] 10VisualEditor: [Regression pre-wmf.8] Graph editor crashes upon opening, error in the console "ReferenceError: vg is not defined" - https://phabricator.wikimedia.org/T119902#1839598 (10Ryasmeen) 3NEW [20:55:50] (03PS23) 10Divec: Diff richtext to build model changes [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/247800 (https://phabricator.wikimedia.org/T72353) [20:56:22] (03PS2) 10Jforrester: AUTHORS.txt: Be more strict about 'principal' authors and update addresses [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/255979 (owner: 10Esanders) [20:56:24] (03PS1) 10Jforrester: .mailmap: Add some extra addresses and change default for rmoen [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/256116 [20:57:26] 10VisualEditor, 10Graph-VisualEditor: [Regression pre-wmf.8] Graph editor crashes upon opening, error in the console "ReferenceError: vg is not defined" - https://phabricator.wikimedia.org/T119902#1839605 (10Ryasmeen) [20:58:55] (03CR) 10Esanders: "What is the threshold?" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/255979 (owner: 10Esanders) [20:59:15] (03CR) 10Esanders: [C: 032] AUTHORS.txt: Be more strict about 'principal' authors and update addresses [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/255979 (owner: 10Esanders) [22:33:48] (03CR) 10Jforrester: "> What is the threshold?" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/255979 (owner: 10Esanders) [22:45:14] (03PS2) 10Jforrester: AUTHORS.txt: Be more strict about 'principal' authors and update addresses [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/255980 (owner: 10Esanders) [22:45:16] (03PS1) 10Jforrester: .mailmap: Add some extra addresses and change default for rmoen [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/256126 [22:47:10] (03CR) 10Jforrester: [C: 032] AUTHORS.txt: Be more strict about 'principal' authors and update addresses [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/255980 (owner: 10Esanders) [23:11:33] (03PS1) 10Mooeypoo: Fix the beta feature image [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/256131 [23:20:53] (03CR) 10Jforrester: [C: 032] Fix the beta feature image [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/256131 (owner: 10Mooeypoo) [23:23:05] mooeypoo: https://gerrit.wikimedia.org/r/#/c/256116/ https://gerrit.wikimedia.org/r/#/c/256126/ [23:23:36] (03Merged) 10jenkins-bot: Fix the beta feature image [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/256131 (owner: 10Mooeypoo) [23:24:00] (03CR) 10Mooeypoo: [C: 032] .mailmap: Add some extra addresses and change default for rmoen [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/256116 (owner: 10Jforrester) [23:26:46] (03Merged) 10jenkins-bot: .mailmap: Add some extra addresses and change default for rmoen [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/256116 (owner: 10Jforrester) [23:27:40] (03CR) 10Mooeypoo: [C: 032] .mailmap: Add some extra addresses and change default for rmoen [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/256126 (owner: 10Jforrester) [23:27:42] (03Merged) 10jenkins-bot: AUTHORS.txt: Be more strict about 'principal' authors and update addresses [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/255979 (owner: 10Esanders) [23:33:01] (03Merged) 10jenkins-bot: .mailmap: Add some extra addresses and change default for rmoen [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/256126 (owner: 10Jforrester) [23:33:03] (03Merged) 10jenkins-bot: AUTHORS.txt: Be more strict about 'principal' authors and update addresses [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/255980 (owner: 10Esanders) [23:46:10] (03CR) 10Bartosz Dziewoński: "I scheduled this change for SWAT today." [extensions/VisualEditor] (wmf/1.27.0-wmf.7) - 10https://gerrit.wikimedia.org/r/255946 (https://phabricator.wikimedia.org/T119815) (owner: 10Florianschmidtwelzow) [23:51:54] MatmaRex: You didn't 'schedule' it, I got g.reg-g's permission. :-P [23:52:29] psst, it would have gone under the radar if you hadn't mentioned it. :> [23:52:39] Tsk. :-) [23:52:57] James_F: but to be serious, there isn't anything terrible happening right now, right? no fundraising and no holidays? [23:53:07] Yes fundraising. [23:53:23] 6 minutes' time to 00:00 UTC on 1 Dec. [23:53:40] oh, starts today. huh. [23:54:17] I think? [23:54:25] So I'm swatting during the first few minutes of it? :D [23:54:31] Certainly, it's be-very-careful-time. [23:56:08] (03CR) 10Jforrester: [C: 032] Avoid embedding Git metadata in ext.visualEditor.data [extensions/VisualEditor] (wmf/1.27.0-wmf.7) - 10https://gerrit.wikimedia.org/r/256015 (https://phabricator.wikimedia.org/T119750) (owner: 10Jforrester) [23:56:14] (03CR) 10Jforrester: [C: 032] AceEditorWidget: Ensure loadingPromise is set when setupEditor runs [extensions/VisualEditor] (wmf/1.27.0-wmf.7) - 10https://gerrit.wikimedia.org/r/255946 (https://phabricator.wikimedia.org/T119815) (owner: 10Florianschmidtwelzow) [23:59:13] (03Merged) 10jenkins-bot: Avoid embedding Git metadata in ext.visualEditor.data [extensions/VisualEditor] (wmf/1.27.0-wmf.7) - 10https://gerrit.wikimedia.org/r/256015 (https://phabricator.wikimedia.org/T119750) (owner: 10Jforrester) [23:59:41] (03Merged) 10jenkins-bot: AceEditorWidget: Ensure loadingPromise is set when setupEditor runs [extensions/VisualEditor] (wmf/1.27.0-wmf.7) - 10https://gerrit.wikimedia.org/r/255946 (https://phabricator.wikimedia.org/T119815) (owner: 10Florianschmidtwelzow)