[00:35:23] (03PS26) 10Divec: Diff richtext to build model changes [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/247800 (https://phabricator.wikimedia.org/T63884) [01:27:41] (03PS26) 10Alex Monk: [WIP] Single edit tab [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/248369 (https://phabricator.wikimedia.org/T58337) [01:29:11] Krenair: For "how are we going to check for "any account who has seen/used two edit tabs in the past"?", edsanders|away and I thought of "a user who has 1+ edits from before 2016" as a quick and dirty version… [01:30:07] We can't do that calculation on the client, needs a new preference. [01:30:25] What about for IPs? [01:30:44] Um, good point. No preferences for IPs. [01:30:46] (Can't we make it part of ApiVisualEditor.php's response?) [01:30:56] No, wait [01:31:00] IPs will never see this dialog [01:31:03] We load a lot of stuff from MediaWiki including a bunch of data. [01:31:10] On English they won't. [01:31:21] On French/Italian/etc. they will, right? [01:32:48] (03PS27) 10Alex Monk: [WIP] Single edit tab [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/248369 (https://phabricator.wikimedia.org/T58337) [01:33:55] James_F, the dialog is to show preference options [01:34:15] Oh, yes, I was forgetting. [01:34:23] Good thing one of us is paying attention. :-) [01:34:32] no point displaying them to IPs, it'll just error [02:08:04] 10VisualEditor, 10VisualEditor-ContentLanguage, 10Wikimedia-Site-Requests: Make VisualEditor work by default in some "easier" phase 6 Wikipedias - https://phabricator.wikimedia.org/T116523#1843658 (10Jdforrester-WMF) [02:08:22] 10VisualEditor, 10VisualEditor-ContentLanguage, 10Wikimedia-Site-Requests: Make VisualEditor work by default in some "easier" phase 6 Wikipedias - https://phabricator.wikimedia.org/T116523#1751469 (10Jdforrester-WMF) [02:08:55] 10VisualEditor, 10VisualEditor-ContentLanguage, 10Wikimedia-Site-Requests: Make VisualEditor work by default in some "easier" phase 6 Wikipedias - https://phabricator.wikimedia.org/T116523#1751469 (10Jdforrester-WMF) [02:28:18] 10VisualEditor, 10VisualEditor-ContentEditable: Forwards-delete at the end of a document blanks the entire document - https://phabricator.wikimedia.org/T120052#1843697 (10Jdforrester-WMF) 3NEW [02:28:27] 10VisualEditor, 10VisualEditor-ContentEditable: Forwards-delete at the end of a document blanks the entire document - https://phabricator.wikimedia.org/T120052#1843704 (10Jdforrester-WMF) [02:31:07] (03CR) 10Jforrester: [C: 031] "Tested on Mac OS X in Chrome, Firefox and Safari. Works beautifully in browser native annotations (bold, italic, underline), substitutions" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/247800 (https://phabricator.wikimedia.org/T63884) (owner: 10Divec) [02:34:23] (03CR) 10BBlack: [C: 031] "+1 for the cookie part not being problematic from varnish's perspective" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/248369 (https://phabricator.wikimedia.org/T58337) (owner: 10Alex Monk) [02:36:26] 10VisualEditor, 10VisualEditor-ContentEditable, 10VisualEditor-ContentLanguage, 7Epic, 5Patch-For-Review: Non-local text changes cause CE updates that close IME candidate window - https://phabricator.wikimedia.org/T76056#1843713 (10Jdforrester-WMF) [02:36:27] 10VisualEditor, 10VisualEditor-ContentEditable, 10VisualEditor-ContentLanguage, 5Patch-For-Review: Observed changes: widen heuristic criteria for guessing a change is simple - https://phabricator.wikimedia.org/T114260#1843714 (10Jdforrester-WMF) [02:36:32] 10VisualEditor, 10VisualEditor-ContentEditable, 10VisualEditor-ContentLanguage, 5Patch-For-Review: Observed changes: widen heuristic criteria for guessing a change is simple - https://phabricator.wikimedia.org/T114260#1689837 (10Jdforrester-WMF) [02:36:34] 10VisualEditor, 10VisualEditor-ContentLanguage, 5Patch-For-Review: Cannot type in Korean using Mozilla on Windows 7 with dual-script keyboard - https://phabricator.wikimedia.org/T72353#1843715 (10Jdforrester-WMF) [02:37:07] 10VisualEditor, 10VisualEditor-ContentEditable, 10VisualEditor-ContentLanguage, 5Patch-For-Review: Observed changes: widen heuristic criteria for guessing a change is simple - https://phabricator.wikimedia.org/T114260#1689837 (10Jdforrester-WMF) [02:37:08] 10VisualEditor, 10VisualEditor-ContentEditable: DM/DOM sync errors can arise from spellchecking in Firefox - https://phabricator.wikimedia.org/T116273#1843725 (10Jdforrester-WMF) [02:37:25] 10VisualEditor, 10VisualEditor-ContentEditable, 10VisualEditor-ContentLanguage, 5Patch-For-Review: Observed changes: widen heuristic criteria for guessing a change is simple - https://phabricator.wikimedia.org/T114260#1689837 (10Jdforrester-WMF) [02:37:26] 10VisualEditor, 10VisualEditor-ContentEditable, 7Browser-Support-Apple-Safari, 7Epic, 5Patch-For-Review: Native browser font styling tool fails to get content into DM, just CE, in Safari - https://phabricator.wikimedia.org/T63884#1843727 (10Jdforrester-WMF) [02:37:40] 10VisualEditor, 10VisualEditor-ContentEditable, 10VisualEditor-ContentLanguage, 5Patch-For-Review: Observed changes: widen heuristic criteria for guessing a change is simple - https://phabricator.wikimedia.org/T114260#1689837 (10Jdforrester-WMF) [02:37:41] 10VisualEditor, 10VisualEditor-ContentEditable, 7Epic: DM/DOM sync can break if you use an IME - https://phabricator.wikimedia.org/T116275#1843729 (10Jdforrester-WMF) [02:39:39] 10VisualEditor, 10VisualEditor-ContentEditable: When typing into a selection in Firefox, DM annotations can get out of sync with the DOM - https://phabricator.wikimedia.org/T113869#1843731 (10Jdforrester-WMF) [02:39:40] 10VisualEditor, 10VisualEditor-ContentEditable, 10VisualEditor-ContentLanguage, 5Patch-For-Review: Observed changes: widen heuristic criteria for guessing a change is simple - https://phabricator.wikimedia.org/T114260#1843732 (10Jdforrester-WMF) [02:40:18] 10VisualEditor, 10VisualEditor-ContentEditable, 7Browser-Tests: VisualEditor: Inserting some content in a QA script doesn't round-trip (null diff) - failure to inserting CE content into DM somehow? - https://phabricator.wikimedia.org/T55721#1843733 (10Jdforrester-WMF) 5Open>3Resolved a:3Jdforrester-WMF... [02:41:33] 10VisualEditor, 10VisualEditor-ContentEditable, 10VisualEditor-Links, 10VisualEditor-MediaWiki-Links: Model and view out of sync when link deleted and replaced with text - https://phabricator.wikimedia.org/T115001#1843737 (10Jdforrester-WMF) Still an issue after (the current version of) https://gerrit.wiki... [02:43:12] (03CR) 10Jforrester: "Tested and confirmed that this version also fixes T113869 and T116273. I assume T55682 and T116275 would also be fixed but can't confirm. " [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/247800 (https://phabricator.wikimedia.org/T63884) (owner: 10Divec) [02:45:07] 10VisualEditor, 10VisualEditor-MediaWiki-Media, 7Technical-Debt: VisualEditor: dm.Document seems to not get the right lang and dir settings inside the Media Dialog in insert mode - https://phabricator.wikimedia.org/T70888#1843739 (10Jdforrester-WMF) [02:45:12] 10VisualEditor, 10VisualEditor-MediaWiki-Media, 7Technical-Debt: VisualEditor: dm.Document seems to not get the right lang and dir settings inside the Media Dialog in insert mode - https://phabricator.wikimedia.org/T70888#1843743 (10Jdforrester-WMF) Is this now fixed? [02:47:49] 10VisualEditor, 10VisualEditor-ContentEditable: When typing into a selection in Firefox, DM annotations can get out of sync with the DOM - https://phabricator.wikimedia.org/T113869#1843744 (10Jdforrester-WMF) 5stalled>3Open [02:48:00] 10VisualEditor, 10VisualEditor-ContentEditable, 7Browser-Support-Apple-Safari, 7Epic, 5Patch-For-Review: Native browser font styling tool fails to get content into DM, just CE, in Safari - https://phabricator.wikimedia.org/T63884#1843745 (10Jdforrester-WMF) a:3dchan [02:48:07] 10VisualEditor, 10VisualEditor-ContentEditable: DM/DOM sync errors can arise from spellchecking in Firefox - https://phabricator.wikimedia.org/T116273#1843746 (10Jdforrester-WMF) a:3dchan [02:48:45] 10VisualEditor, 10VisualEditor-ContentEditable, 10VisualEditor-ContentLanguage, 7Epic, 5Patch-For-Review: Non-local text changes cause CE updates that close IME candidate window - https://phabricator.wikimedia.org/T76056#1843747 (10Jdforrester-WMF) a:3dchan [02:55:56] James_F, so if we add a hidden preference to everyone who has ever made a VE edit, then if it's present on VE load we show the dialog and remove the preference? [02:56:15] Krenair: Eww. [02:56:29] Krenair: Why does it need to be a preference? Can't we inject it into the page payload? [02:57:10] well then how are we going to prevent it from showing more than once? [02:58:01] RoanKattouw: https://gerrit.wikimedia.org/r/#/admin/groups/uuid-c46f4782767ebf11cd4f45582c3f20192cd7216f,members [02:58:29] Krenair: Record that they've seen it || account first edit time > {arbitrary date}. [02:58:42] Rather than mass-setting a priv. [02:59:55] RoanKattouw: https://gerrit.wikimedia.org/r/#/admin/groups/658,members [03:03:06] still has to be a preference [03:03:31] Krenair: Yes, my objection wasn't to a preference, it was to having a preference that we have to write a script to mass-set for people. [03:04:17] RoanKattouw: https://integration.wikimedia.org/ci/job/mediawiki-extensions-qunit/21804/console [03:06:27] so [03:06:35] if single edit tab is enabled [03:06:40] when a logged in user makes a request for VE page metadata [03:07:22] if they've either not got our pref or they've not edited before an arbitrary (configurable?) time [03:07:41] sorry [03:07:52] if they've not got our pref and they edited before an arbitrary (configurable?) time* [03:08:13] set a response key to indicate to the client to show the dialog [03:08:23] and add the hidden pref to their account [03:08:46] Yes. [03:10:46] actually running the edit time check involves an extra sql query, but I think that should be okay considering it'll only be the first time a user opens VE after this is enabled [03:10:51] (03PS2) 10Jforrester: Update VE core submodule to master (d72270f) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/256156 [03:11:01] * James_F nods. [03:11:08] I think the query itself should be fine [03:11:50] BTW, the 'default' configuration we'll have to put in mw-config is for everyone to get two tabs and for the preference to be hidden, right? That will mean this patch has no impact on users? [03:12:43] there's a single global that should enable/disable all the new behaviour properly, in theory [03:13:16] Oh, right VisualEditorUseSingleEditTab [03:13:22] yes [03:14:00] But it's not used in ve.init.mw.DesktopArticleTarget.init.js ? [03:14:18] Oh, I see, if ( conf.singleEditTab ) { [03:14:33] Ignore me. :-) [03:14:54] :) [03:15:12] OK, I'm going to go. [03:15:18] Have fun! Get some sleep. :-) [03:15:26] * Krenair waves [03:16:21] (03CR) 10Catrope: [C: 032] Update VE core submodule to master (d72270f) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/256156 (owner: 10Jforrester) [03:19:45] (03Merged) 10jenkins-bot: Update VE core submodule to master (d72270f) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/256156 (owner: 10Jforrester) [03:32:31] Medium put out an article about their editor, and why they hate contenteditable. https://medium.com/medium-eng/why-contenteditable-is-terrible-122d8a40e480#.7k98jpk6g :) [03:47:12] query would be something like "select 1 from revision_userindex where rev_user = $UID and year(rev_timestamp) < 2016 limit 1;" [03:47:22] but obviously without the _userindex, I was just testing in labs [06:24:02] 10VisualEditor: Editing Infobox display - https://phabricator.wikimedia.org/T119843#1843894 (10Lieutenant_Jade) Do you know where i can for wikia wiki [10:08:12] 10VisualEditor, 10VisualEditor-MediaWiki-Media, 10MediaWiki-General-or-Unknown, 6Multimedia: Show determinate progress bar for the image upload in mw.ForeignStructuredUpload.BookletLayout - https://phabricator.wikimedia.org/T115861#1844174 (10Pginer-WMF) >>! In T115861#1842879, @Volker_E wrote: > What do y... [10:37:38] 10VisualEditor, 10VisualEditor-EditingTools, 10VisualEditor-Links, 10VisualEditor-MediaWiki-Links, 7Design: Change the action buttons in context menus to be separate buttons, not a button group - https://phabricator.wikimedia.org/T119615#1844265 (10Pginer-WMF) Thanks for the update @Jdforrester-WMF > Th... [10:59:20] Krenair, whatever is easiest [10:59:50] James_F|Away suggested anyone who has an edit? [11:50:35] 10VisualEditor, 10VisualEditor-ContentEditable, 10VisualEditor-ContentLanguage: After selecting table cell by single clicking, typing with any IME does not work - https://phabricator.wikimedia.org/T86589#1844412 (10dchan) The crashing behaviour seems similar to this minimal test case http://jsfiddle.net/s1ry... [12:37:38] 10Citoid, 10TemplateData: Missing parameter in citation - https://phabricator.wikimedia.org/T93355#1844470 (10mobrovac) [12:37:41] 10Citoid, 6Community-Tech: Add Citoid support to RefToolbar gadget - https://phabricator.wikimedia.org/T114156#1844469 (10mobrovac) [12:37:43] 10Citoid, 10VisualEditor: Citoid/VisualEditor doesn't handle citations for book chapters correctly - https://phabricator.wikimedia.org/T114450#1844468 (10mobrovac) [12:37:45] 10Citoid, 10VisualEditor, 5Patch-For-Review: Add ability to request base types in citoid, and offer use of both in extension for backwards compatibility until all templateData has been updated. - https://phabricator.wikimedia.org/T114515#1844466 (10mobrovac) 5Open>3Resolved Deployed, resolving. [12:37:52] 10Citoid, 10VisualEditor: Add ability to request base types in citoid, and offer use of both in extension for backwards compatibility until all templateData has been updated. - https://phabricator.wikimedia.org/T114515#1844471 (10mobrovac) [15:21:34] 10VisualEditor, 10VisualEditor-ContentEditable: Forwards-delete at the end of a document blanks the entire document - https://phabricator.wikimedia.org/T120052#1844841 (10Esanders) Caused by https://gerrit.wikimedia.org/r/#/c/107142/ an old patch by me recently reworked by @DLynch [15:29:59] (03PS1) 10Esanders: Failing test case for delete at end of doc [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/256415 (https://phabricator.wikimedia.org/T120052) [15:33:56] (03CR) 10jenkins-bot: [V: 04-1] Failing test case for delete at end of doc [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/256415 (https://phabricator.wikimedia.org/T120052) (owner: 10Esanders) [16:51:33] James_F, https://people.wikimedia.org/~krenair/ve-set-pref-dialog.png [16:52:11] Krenair: Looks good. Might want to tweak the copy but not crisis-urgent. [16:52:20] sure [16:52:25] this isn't even in the i18n files yet [16:52:28] :-)( [16:52:30] it's just what I've shoved into the code [16:52:36] * James_F nods. [16:52:59] Should we have a separate page confirming preference change, if they use one of those buttons? [16:53:01] Also, welcome back netsplitters. [16:53:16] Krenair: No, trust them. [16:53:55] So if they press 'Always use the wikitext editor'... we're going to close the dialog and leave them in VE until they refresh [16:53:58] MatmaRex: Did you find you needed a separate patch for VE-MW? [16:54:42] Krenair: Not sure. Maybe we should switch them too, but then the language will need to reflect it. [16:55:03] James_F: it shouldn't be needed. it would just be cleanup, but it'd touch both ve.sa and ve.mw and i really just couldn't be bothered to juggle them [16:55:12] MatmaRex: Kk. [16:56:19] James_F, could say something along the lines of 'by default your last choice of editor will be remembered, but you can choose in future edits:' instead [16:56:34] that wording sucks, I know [16:56:48] Krenair: It needs to be 2–3 words per button maximum. [16:57:02] I'll work on wording. [16:57:06] this is the text at the top of the dialog [16:57:06] ok [16:59:58] I'll update the copy of the code on visualeditor-switch.wmflabs.org soon [17:00:12] Neat. [17:00:15] 10Citoid, 10VisualEditor: Add ability to request base types in citoid, and offer use of both in extension for backwards compatibility until all templateData has been updated. - https://phabricator.wikimedia.org/T114515#1845131 (10mobrovac) Oh right, sorry! [17:00:23] 10Citoid, 10VisualEditor: Add ability to request base types in citoid, and offer use of both in extension for backwards compatibility until all templateData has been updated. - https://phabricator.wikimedia.org/T114515#1845132 (10mobrovac) [17:16:17] (03PS28) 10Alex Monk: [WIP] Single edit tab [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/248369 (https://phabricator.wikimedia.org/T58337) [17:21:51] (03CR) 10jenkins-bot: [V: 04-1] [WIP] Single edit tab [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/248369 (https://phabricator.wikimedia.org/T58337) (owner: 10Alex Monk) [17:22:21] Krenair: npm really doesn't like you, does it? [17:32:11] ugh [17:32:44] something like a third of those patch sets has been V-1'd by jenkins [17:34:06] (03PS29) 10Alex Monk: [WIP] Single edit tab [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/248369 (https://phabricator.wikimedia.org/T58337) [17:37:01] (03CR) 10jenkins-bot: [V: 04-1] [WIP] Single edit tab [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/248369 (https://phabricator.wikimedia.org/T58337) (owner: 10Alex Monk) [17:38:27] (03PS30) 10Alex Monk: [WIP] Single edit tab [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/248369 (https://phabricator.wikimedia.org/T58337) [17:52:51] edsanders: Could I get CR on https://gerrit.wikimedia.org/r/#/c/256436/ in core? [17:52:55] Sorry, MW-core. [17:54:05] are those the only binding? [17:54:07] s [18:02:07] 10VisualEditor, 10VisualEditor-ContentEditable, 5Patch-For-Review: Forwards-delete at the end of a document blanks the entire document - https://phabricator.wikimedia.org/T120052#1845270 (10DLynch) a:3DLynch [18:33:44] 10VisualEditor, 10VisualEditor-ContentEditable, 10VisualEditor-ContentLanguage: After selecting table cell by single clicking, typing with any IME does not work - https://phabricator.wikimedia.org/T86589#1845400 (10dchan) It seems there's a problem specific to IME listeners in Firefox: # An alert() in a comp... [18:56:14] (03CR) 10Esanders: "Confirmed T116275 fixed" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/247800 (https://phabricator.wikimedia.org/T63884) (owner: 10Divec) [18:56:42] edsanders: Let's merge? [18:56:52] discussing [18:57:19] DoItDoItDoIt™ [19:01:41] (03PS27) 10Divec: Diff richtext to build model changes [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/247800 (https://phabricator.wikimedia.org/T55682) [19:04:39] 10VisualEditor, 10VisualEditor-ContentEditable, 10VisualEditor-Links, 10VisualEditor-MediaWiki-Links: Model and view out of sync when link deleted and replaced with text - https://phabricator.wikimedia.org/T115001#1845551 (10dchan) It might be fixed if we set "ve.dm.LinkAnnotation.static.inferFromDom = tru... [19:21:45] (03PS28) 10Divec: Diff richtext to build model changes [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/247800 (https://phabricator.wikimedia.org/T63884) [19:25:02] 10VisualEditor, 10VisualEditor-ContentEditable, 5Patch-For-Review: VisualEditor: Trigger keys can end up in CE surface, but not in DM - https://phabricator.wikimedia.org/T55682#1845595 (10dchan) Actually I think this was already fixed before Change 247800: On Ubuntu 15.10 with French keyboard, Alt+8 into a n... [19:25:56] divec: Stop disclaiming work. :_) [19:41:39] 10VisualEditor, 10Phlogiston, 15User-JAufrecht: Filter VE report by task priority - https://phabricator.wikimedia.org/T119107#1845633 (10JAufrecht) 5Open>3Resolved This is done for VE, using the custom SQL reprocessing (see https://github.com/wikimedia/phlogiston/commit/73cb540a3f80e34faa56870377c68daa34... [19:42:28] 10VisualEditor, 10Phlogiston, 15User-JAufrecht: Filter VE report by task priority - https://phabricator.wikimedia.org/T119107#1845638 (10Jdforrester-WMF) [19:58:25] (03PS3) 10Jforrester: Show non-breaking spaces in the editor [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/255936 (https://phabricator.wikimedia.org/T96666) (owner: 10Bartosz Dziewoński) [19:58:45] (03PS3) 10Jforrester: Add command to insert non-breaking space, triggered by Ctrl+Space (PC) / Opt+Space (Mac) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/255937 (https://phabricator.wikimedia.org/T53045) (owner: 10Bartosz Dziewoński) [20:02:42] (03CR) 10Jforrester: [C: 031] Show non-breaking spaces in the editor [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/255936 (https://phabricator.wikimedia.org/T96666) (owner: 10Bartosz Dziewoński) [21:22:09] So, I'm not sure of this... if you're in a list node at the very end of the document (

  • foo|

, and you hit delete, should that

foo

get unwrapped from the list node, or should the keystroke just be ignored? [21:23:43] If it _wasn't_ at the end of the document, it'd just merge the next paragraph into the list. [21:28:36] 10VisualEditor, 10Graph-VisualEditor: [Regression pre-wmf.8] Graph editor crashes upon opening, error in the console "ReferenceError: vg is not defined" - https://phabricator.wikimedia.org/T119902#1845939 (10ferdbold) This is weird, I'm able to reproduce this. Graphs in read mode aren't being rendered, though... [21:34:09] 10VisualEditor, 10VisualEditor-ContentEditable, 5Patch-For-Review: Forwards-delete at the end of a document blanks the entire document - https://phabricator.wikimedia.org/T120052#1845957 (10DLynch) I can easily fix the delete-the-document case. But, there's something not covered by our current tests, and I'... [21:35:37] 10VisualEditor, 10VisualEditor-ContentEditable, 5Patch-For-Review: Forwards-delete at the end of a document blanks the entire document - https://phabricator.wikimedia.org/T120052#1845970 (10Jdforrester-WMF) I think I agree with your suggestion (special-case empty list to unwrap, otherwise do nothing). [22:27:18] 10VisualEditor, 10VisualEditor-CopyPaste, 7Browser-Support-Firefox: Pasting into a VE surface in Firefox adds spurious spaces - https://phabricator.wikimedia.org/T120139#1846168 (10Pols12) 3NEW a:3Esanders [22:29:01] 10VisualEditor, 10VisualEditor-CopyPaste, 7Browser-Support-Firefox: Pasting into a VE surface in Firefox adds spurious spaces - https://phabricator.wikimedia.org/T120139#1846183 (10Jdforrester-WMF) a:5Esanders>3None Please do not assign tasks to developers. [23:45:24] (03CR) 10Esanders: [C: 032] Diff richtext to build model changes [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/247800 (https://phabricator.wikimedia.org/T63884) (owner: 10Divec) [23:48:49] (03Merged) 10jenkins-bot: Diff richtext to build model changes [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/247800 (https://phabricator.wikimedia.org/T63884) (owner: 10Divec)