[00:01:07] (03CR) 10Esanders: "not a fan of the styling" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/255936 (https://phabricator.wikimedia.org/T96666) (owner: 10Bartosz Dziewoński) [00:12:00] edsanders: Gosh. [00:12:43] edsanders: You good to merge the pull-through? [00:12:58] (I'd really like to ask ko/ja typers to try it out on Beta Cluster.) [00:13:44] 10VisualEditor, 10VisualEditor-ContentEditable, 5Patch-For-Review: VisualEditor: Trigger keys can end up in CE surface, but not in DM - https://phabricator.wikimedia.org/T55682#1846531 (10Esanders) 5Open>3Resolved a:3Esanders [00:16:13] 10VisualEditor, 10VisualEditor-ContentEditable, 5WMF-deploy-2015-12-08_(1.27.0-wmf.8): VisualEditor: Trigger keys can end up in CE surface, but not in DM - https://phabricator.wikimedia.org/T55682#1846534 (10Jdforrester-WMF) [00:16:26] (03PS1) 10Jforrester: Update VE core submodule to master (71cbcff) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/256612 [00:16:29] edsanders: ^^^ [00:32:54] Or Krenair. :-) [00:34:38] looking [00:36:28] (03CR) 10Alex Monk: [C: 032] Update VE core submodule to master (71cbcff) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/256612 (owner: 10Jforrester) [00:36:39] Thank you. [00:38:06] James_F, you going to mark those bugs as resolved? [00:38:12] Yes. [00:38:19] I was going to test them in Beta Cluster individually first. :-) [00:38:35] Do you think I should just go for it? [00:38:55] 10VisualEditor, 10VisualEditor-ContentEditable, 7Browser-Support-Apple-Safari, 7Epic, 5WMF-deploy-2015-12-08_(1.27.0-wmf.8): Native browser font styling tool fails to get content into DM, just CE, in Safari - https://phabricator.wikimedia.org/T63884#1846629 (10Jdforrester-WMF) [00:38:59] 10VisualEditor, 10VisualEditor-ContentEditable, 7Browser-Support-Apple-Safari, 7Epic, 5WMF-deploy-2015-12-08_(1.27.0-wmf.8): Native browser font styling tool fails to get content into DM, just CE, in Safari - https://phabricator.wikimedia.org/T63884#1846630 (10Jdforrester-WMF) 5Open>3Resolved [00:39:29] 10VisualEditor, 10VisualEditor-ContentEditable, 10VisualEditor-ContentLanguage, 7Epic, 5WMF-deploy-2015-12-08_(1.27.0-wmf.8): Non-local text changes cause CE updates that close IME candidate window - https://phabricator.wikimedia.org/T76056#1846632 (10Jdforrester-WMF) 5Open>3Resolved [00:39:30] 10VisualEditor, 10VisualEditor-MediaWiki: Release VisualEditor-MediaWiki as "1.0" - https://phabricator.wikimedia.org/T84936#1846634 (10Jdforrester-WMF) [00:39:48] (03Merged) 10jenkins-bot: Update VE core submodule to master (71cbcff) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/256612 (owner: 10Jforrester) [00:40:02] 10VisualEditor, 10VisualEditor-ContentEditable, 5WMF-deploy-2015-12-08_(1.27.0-wmf.8): When typing into a selection in Firefox, DM annotations can get out of sync with the DOM - https://phabricator.wikimedia.org/T113869#1846637 (10Jdforrester-WMF) 5Open>3Resolved [00:40:16] 10VisualEditor, 10VisualEditor-ContentEditable, 10VisualEditor-ContentLanguage, 5WMF-deploy-2015-12-08_(1.27.0-wmf.8): Observed changes: widen heuristic criteria for guessing a change is simple - https://phabricator.wikimedia.org/T114260#1846640 (10Jdforrester-WMF) [00:40:21] 10VisualEditor, 10VisualEditor-ContentEditable, 5WMF-deploy-2015-12-08_(1.27.0-wmf.8): When typing into a selection in Firefox, DM annotations can get out of sync with the DOM - https://phabricator.wikimedia.org/T113869#1678845 (10Jdforrester-WMF) [00:40:22] 10VisualEditor, 10VisualEditor-ContentEditable, 5Patch-For-Review: DM/DOM sync errors can arise from spellchecking in Firefox - https://phabricator.wikimedia.org/T116273#1846643 (10Jdforrester-WMF) [00:40:24] 10VisualEditor, 10VisualEditor-ContentEditable, 10VisualEditor-ContentLanguage, 7Epic, 5WMF-deploy-2015-12-08_(1.27.0-wmf.8): Non-local text changes cause CE updates that close IME candidate window - https://phabricator.wikimedia.org/T76056#788865 (10Jdforrester-WMF) [00:40:26] 10VisualEditor, 10VisualEditor-ContentLanguage, 5Patch-For-Review: Cannot type in Korean using Mozilla on Windows 7 with dual-script keyboard - https://phabricator.wikimedia.org/T72353#1846646 (10Jdforrester-WMF) [00:40:28] 10VisualEditor, 10VisualEditor-ContentEditable, 10VisualEditor-ContentLanguage, 5WMF-deploy-2015-12-08_(1.27.0-wmf.8): Observed changes: widen heuristic criteria for guessing a change is simple - https://phabricator.wikimedia.org/T114260#1846641 (10Jdforrester-WMF) 5Open>3Resolved [00:40:30] 10VisualEditor, 10VisualEditor-ContentEditable, 7Browser-Support-Apple-Safari, 7Epic, 5WMF-deploy-2015-12-08_(1.27.0-wmf.8): Native browser font styling tool fails to get content into DM, just CE, in Safari - https://phabricator.wikimedia.org/T63884#652205 (10Jdforrester-WMF) [00:40:37] 10VisualEditor, 10VisualEditor-ContentEditable, 5WMF-deploy-2015-12-08_(1.27.0-wmf.8): DM/DOM sync errors can arise from spellchecking in Firefox - https://phabricator.wikimedia.org/T116273#1846649 (10Jdforrester-WMF) 5Open>3Resolved [00:40:55] 10VisualEditor, 10VisualEditor-ContentEditable, 7Epic, 5WMF-deploy-2015-12-08_(1.27.0-wmf.8): DM/DOM sync can break if you use an IME - https://phabricator.wikimedia.org/T116275#1846651 (10Jdforrester-WMF) 5Open>3Resolved [00:43:02] edsanders: Do you have a Korean IME that exhibits https://phabricator.wikimedia.org/T72353 to test? [00:46:34] no [00:48:41] * James_F is trying Mac OS X native Korean IMEs. [00:54:32] 가나다 [00:57:40] 승리 [01:05:13] 10VisualEditor, 10VisualEditor-ContentEditable: Uncommitted Korean IME candidate text ignored when user presses enter, causing CE/DM desync - https://phabricator.wikimedia.org/T120156#1846709 (10Jdforrester-WMF) 3NEW a:3dchan [01:05:19] 10VisualEditor, 10VisualEditor-ContentEditable: Uncommitted Korean IME candidate text ignored when user presses enter, causing CE/DM desync - https://phabricator.wikimedia.org/T120156#1846709 (10Jdforrester-WMF) [01:06:08] 10VisualEditor, 10VisualEditor-MediaWiki: Release VisualEditor-MediaWiki as "1.0" - https://phabricator.wikimedia.org/T84936#1846727 (10Jdforrester-WMF) [01:06:09] 10VisualEditor, 7Tracking: Tracking IME issues on Korean Wikipedia - https://phabricator.wikimedia.org/T110654#1846726 (10Jdforrester-WMF) [01:06:11] 10VisualEditor, 10VisualEditor-ContentLanguage, 5Patch-For-Review: Cannot type in Korean using Mozilla on Windows 7 with dual-script keyboard - https://phabricator.wikimedia.org/T72353#1846721 (10Jdforrester-WMF) 5Open>3Resolved a:3Jdforrester-WMF OK, @revi, any chance you could re-check http://deploym... [01:06:19] 10VisualEditor, 10VisualEditor-ContentLanguage, 5WMF-deploy-2015-12-08_(1.27.0-wmf.8): Cannot type in Korean using Mozilla on Windows 7 with dual-script keyboard - https://phabricator.wikimedia.org/T72353#1846728 (10Jdforrester-WMF) a:5Jdforrester-WMF>3dchan [01:08:32] Deskana: 하하 [01:10:03] 10VisualEditor, 10VisualEditor-ContentLanguage: In 2-Set Korean IME when typing inside a table cell and pressing space selection and cursor disappear - https://phabricator.wikimedia.org/T86592#1846731 (10Jdforrester-WMF) I believe this works now, yes. (Test in Chrome and Firefox on Mac OS X using GongjinCheong... [01:10:22] 10VisualEditor, 10VisualEditor-ContentLanguage, 5WMF-deploy-2015-12-08_(1.27.0-wmf.8): In 2-Set Korean IME when typing inside a table cell and pressing space selection and cursor disappear - https://phabricator.wikimedia.org/T86592#1846732 (10Jdforrester-WMF) 5Open>3Resolved a:3dchan [01:10:23] 10VisualEditor, 7Tracking: Tracking IME issues on Korean Wikipedia - https://phabricator.wikimedia.org/T110654#1846736 (10Jdforrester-WMF) [01:11:19] 10VisualEditor, 10VisualEditor-ContentEditable: Uncommitted Korean IME candidate text ignored when user presses enter, causing CE/DM desync - https://phabricator.wikimedia.org/T120156#1846748 (10Catrope) To clarify: between step 4 and step 5, the last character is underlined, probably indicating that it's unco... [01:12:38] 10VisualEditor, 6Editing-Department, 10MobileFrontend, 10OOjs-UI, 5WMF-deploy-2015-12-08_(1.27.0-wmf.8): [Regression pre-wmf.8] Opening the wikitext editor fails - https://phabricator.wikimedia.org/T119109#1818268 (10Jdforrester-WMF) [01:12:52] 10VisualEditor, 10VisualEditor-ContentEditable, 7Technical-Debt, 5WMF-deploy-2015-12-08_(1.27.0-wmf.8): Abstract getSelectionRects by selection type - https://phabricator.wikimedia.org/T118798#1846757 (10Jdforrester-WMF) [01:26:39] 10VisualEditor, 6Phabricator: Fix edit permissions of VisualEditor Phabricator projects - https://phabricator.wikimedia.org/T119622#1846782 (10Jdforrester-WMF) These are set up as discussed with you when they were created. What's changed? [01:30:47] 10VisualEditor, 10VisualEditor-MediaWiki, 10RESTBase: RESTBase doesn't purge restored/recreated pages -> VisualEditor unable to edit restored/recreated pages - https://phabricator.wikimedia.org/T119780#1846792 (10Jdforrester-WMF) [01:31:33] 10VisualEditor, 10VisualEditor-MediaWiki, 10RESTBase: RESTBase doesn't purge restored/recreated pages -> VisualEditor unable to edit restored/recreated pages - https://phabricator.wikimedia.org/T119780#1835645 (10Jdforrester-WMF) p:5Triage>3Normal Aha, so, I think this is the 'deletion' equivalent of {T1... [01:32:15] 10VisualEditor, 10VisualEditor-CopyPaste, 7Browser-Support-Firefox: Pasting into a VE surface in Firefox adds spurious double spaces in some circumstances - https://phabricator.wikimedia.org/T120139#1846808 (10Jdforrester-WMF) p:5Normal>3Lowest [01:37:56] 10VisualEditor, 10VisualEditor-MediaWiki, 10RESTBase: RESTBase doesn't purge restored/recreated pages -> VisualEditor unable to edit restored/recreated pages - https://phabricator.wikimedia.org/T119780#1846814 (10Jdforrester-WMF) RB URL: https://test2.wikipedia.org/api/rest_v1/page/html/Drong-7/161406 [01:39:14] 10VisualEditor, 10VisualEditor-CopyPaste, 7Browser-Support-Firefox: Pasting into a VE surface in Firefox adds spurious double spaces in some circumstances - https://phabricator.wikimedia.org/T120139#1846816 (10Esanders) I added a check for whitespace after the newline, but not before... [01:41:26] 10VisualEditor, 10VisualEditor-MediaWiki: Save dialog hang - https://phabricator.wikimedia.org/T105610#1846821 (10Jdforrester-WMF) 5Open>3Resolved a:3Jdforrester-WMF I'm going to provisionally close this. I don't like so to do, but no reproduction steps and no reports of the same happening in six months. [01:42:07] Are the education popups FragmentInspectors? I assume not. [01:42:17] T116577 is just T114614 for them. [01:42:43] 10VisualEditor, 10VisualEditor-MediaWiki-Links, 7Design, 5Patch-For-Review: Maximum height of the link editor should take into account the toolbar height too - https://phabricator.wikimedia.org/T114614#1846826 (10Jdforrester-WMF) Note that {T116577} is just this task for the education pop-ups. [01:44:32] (03PS1) 10Esanders: Paste sanitization: Check for whitespace *before* newlines [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/256620 (https://phabricator.wikimedia.org/T120139) [01:45:35] 10VisualEditor, 10VisualEditor-CopyPaste, 7Browser-Support-Firefox, 5Patch-For-Review: Pasting into a VE surface in Firefox adds spurious double spaces in some circumstances - https://phabricator.wikimedia.org/T120139#1846831 (10Esanders) a:3Esanders [01:47:24] 10VisualEditor, 10Flow, 3Collaboration-Team-Current: [Regression pre-wmf.8] Insert a mention in any Flow editor (in VE mode) is broken (on master) - https://phabricator.wikimedia.org/T119773#1846833 (10Jdforrester-WMF) I get > load.php?debug=false&lang=en-gb&modules=ext.flow.visualEditor|ext.visualEditor.ba... [01:47:29] 10VisualEditor, 10Flow, 3Collaboration-Team-Current: [Regression pre-wmf.8] Insert a mention in any Flow editor (in VE mode) is broken (on master) - https://phabricator.wikimedia.org/T119773#1846834 (10Catrope) I can't reproduce that particular error, but now it's worse: ``` Uncaught TypeError: Cannot read... [01:51:44] 10VisualEditor, 10VisualEditor-MediaWiki-Links, 10VisualEditor-MediaWiki-Mobile: [Regression ?] Auto-numbered external links are not appearing, only their external link icons in mobile VE - https://phabricator.wikimedia.org/T114713#1846835 (10Jdforrester-WMF) [01:52:28] 10VisualEditor, 10VisualEditor-MediaWiki-Links, 10VisualEditor-MediaWiki-Mobile: [Regression ?] Auto-numbered external links are not appearing, only their external link icons in mobile VE - https://phabricator.wikimedia.org/T114713#1703717 (10Jdforrester-WMF) 5Open>3Resolved a:3Jdforrester-WMF This loo... [01:53:50] edsanders: If you're looking for something quick and fun, https://phabricator.wikimedia.org/T112898 would be nice. :_) [01:55:07] (03CR) 10Jforrester: [C: 032] Paste sanitization: Check for whitespace *before* newlines [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/256620 (https://phabricator.wikimedia.org/T120139) (owner: 10Esanders) [01:55:24] 10VisualEditor, 10VisualEditor-CopyPaste, 7Browser-Support-Firefox, 5WMF-deploy-2015-12-08_(1.27.0-wmf.8): Pasting into a VE surface in Firefox adds spurious double spaces in some circumstances - https://phabricator.wikimedia.org/T120139#1846841 (10Jdforrester-WMF) 5Open>3Resolved [01:59:58] Krenair: Copy! Damn, sorry. [02:00:09] (03Merged) 10jenkins-bot: Paste sanitization: Check for whitespace *before* newlines [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/256620 (https://phabricator.wikimedia.org/T120139) (owner: 10Esanders) [02:05:26] Krenair: How about: [02:05:33] "Wikipedia now remembers which editor you used last when you click on the "Edit" tab." [02:05:36] Options: [02:05:40] (in order) [02:05:44] [ Always give me the wikitext editor ] => set pref, WE if in VE [02:05:48] [ Always give me the visual editor if possible ] => set pref, VE if in WE and possible [02:05:52] [ Show me both editor tabs ] => set pref, change to two tabs on page refresh, don't try now [02:06:04] [ **OK** ] => (** == primary) proceed, no pref [02:06:10] Krenair: Does that work for you? [02:06:20] VE if in WE? [02:06:33] you mean this dialog is supposed to show in the wikitext editor too? [02:06:39] Ideally, yeah. [02:06:51] Because before the change, if I click "edit" I always got VE. [02:06:59] And it'll be a change for those people too. [02:07:07] Is that do-able? [02:07:35] maybe [02:08:18] For "Wikipedia" substitute wgSitename, and for "Edit" substitute vector-ca-edit-label or whatever. [02:08:42] vector-view-edit apparently. [02:09:13] by "WE if in VE" you mean pressing the button should actually switch to the wikitext editor? [02:11:43] Yeah. If we've unexpectedly lured an editor into the 'wrong' editor, the least we can do is help them by switching to the one they wanted. [02:15:58] This is far, far more than just changing the text [02:16:50] True. [02:17:03] Do you think it's better for users, though? [02:17:04] whatever... I'll try to make it work, but I seriously doubt this is getting merged next week [02:17:24] * Krenair sleeps [02:17:27] See you. [02:29:08] (03PS1) 10Jforrester: MWMediaDialog: Add a margin back to the border checkbox [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/256621 (https://phabricator.wikimedia.org/T119547) [02:29:22] 10VisualEditor, 10VisualEditor-MediaWiki-Media, 5Patch-For-Review: [Regression pre-wmf.8] Checkbox for border in media settings dialog is overlapping with Thumbnail option - https://phabricator.wikimedia.org/T119547#1846851 (10Jdforrester-WMF) a:3Jdforrester-WMF [02:41:45] 10VisualEditor, 10VisualEditor-ContentEditable, 10VisualEditor-Links: Clicking the 'remove' button in the link context doesn't work if the cursor is at the beginning of the link text - https://phabricator.wikimedia.org/T119923#1846864 (10Jdforrester-WMF) Delving into this, in `ve.ui.AnnotationContextItem.pro... [05:04:18] 10VisualEditor, 10Graph, 5Patch-For-Review: [Regression pre-wmf.8] Graph editor crashes upon opening, error in the console "ReferenceError: vg is not defined" - https://phabricator.wikimedia.org/T119902#1846996 (10ferdbold) [05:04:51] 10VisualEditor, 10Graph: While using the resize handler on a graph, the lowest limit for resizing is 60x60px, but not when resizing from dialog - https://phabricator.wikimedia.org/T119261#1846999 (10ferdbold) [07:02:16] 10VisualEditor, 10VisualEditor-MediaWiki, 10Math, 7Epic: [Objective] Improve support for math editing by improving the UX of the Math extension and researching its usability - https://phabricator.wikimedia.org/T118616#1847209 (10Tchanders) Thanks for the feedback - I agree, it's a problem not being able to... [07:34:51] Hi, is someone around who could have a look at https://gerrit.wikimedia.org/r/#/c/256638/3 ? [07:56:26] (03PS3) 10DLynch: Forward-delete at end of document shouldn't do anything [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/256415 (https://phabricator.wikimedia.org/T120052) (owner: 10Esanders) [08:02:11] (03PS4) 10DLynch: Forward-delete at end of document shouldn't do anything [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/256415 (https://phabricator.wikimedia.org/T120052) (owner: 10Esanders) [08:05:10] (03CR) 10DLynch: Forward-delete at end of document shouldn't do anything (031 comment) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/256415 (https://phabricator.wikimedia.org/T120052) (owner: 10Esanders) [09:31:47] 10VisualEditor, 6Phabricator: Fix edit permissions of VisualEditor Phabricator projects - https://phabricator.wikimedia.org/T119622#1847450 (10Aklapper) The edit policies are not set to "All Users" but to "VisualEditor (Project)" which does not make much sense as it's just one additional click to join the proj... [10:08:42] 10VisualEditor, 10VisualEditor-MediaWiki, 10WikiEditor, 6Editing-Department, and 6 others: To help desktop users ensure pages look OK for mobile, let them "preview" how it will look as they edit on desktop, regardless of editor - https://phabricator.wikimedia.org/T119252#1847535 (10Moushira) [15:27:09] (03CR) 10Esanders: [C: 032] MWMediaDialog: Add a margin back to the border checkbox [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/256621 (https://phabricator.wikimedia.org/T119547) (owner: 10Jforrester) [15:30:24] (03Merged) 10jenkins-bot: MWMediaDialog: Add a margin back to the border checkbox [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/256621 (https://phabricator.wikimedia.org/T119547) (owner: 10Jforrester) [15:31:43] 10VisualEditor, 10VisualEditor-MediaWiki-Media, 5WMF-deploy-2015-12-08_(1.27.0-wmf.8): [Regression pre-wmf.8] Checkbox for border in media settings dialog is overlapping with Thumbnail option - https://phabricator.wikimedia.org/T119547#1848268 (10Jdforrester-WMF) 5Open>3Resolved [15:33:04] 10VisualEditor, 10Graph, 5WMF-deploy-2015-12-08_(1.27.0-wmf.8): [Regression pre-wmf.8] Graph editor crashes upon opening, error in the console "ReferenceError: vg is not defined" - https://phabricator.wikimedia.org/T119902#1848278 (10Jdforrester-WMF) 5Open>3Resolved [15:44:41] 10VisualEditor: When the begin of a word is formatted, adding a link for this word will create two links instead of one - https://phabricator.wikimedia.org/T120226#1848346 (10Pols12) 3NEW [15:46:30] 10VisualEditor: When the begin of a word is formatted, adding a link for this word will create two links instead of one - https://phabricator.wikimedia.org/T120226#1848369 (10Jdforrester-WMF) [15:46:32] 10VisualEditor, 10VisualEditor-DataModel, 7Epic: Ordered application of annotations to avoid fragmentation (e.g. ''[[Foo|Fo]]''[[Foo|o]]) - https://phabricator.wikimedia.org/T52098#1848370 (10Jdforrester-WMF) [15:49:23] 10VisualEditor, 10VisualEditor-DataModel, 7Epic: Ordered application of annotations to avoid fragmentation (e.g. ''[[Foo|Fo]]''[[Foo|o]]) - https://phabricator.wikimedia.org/T52098#1848384 (10ssastry) Is this still an issue? We've implemented tag minimization for tags and it has been in production for a... [15:57:49] edsanders: What do you think about adding a "debug mode" control in MW-VE somewhere to open the debug bar? Opening with ?debug=true is painfully slow and doesn't always work in production. [15:58:16] sure [16:02:31] 10VisualEditor, 10VisualEditor-DataModel, 7Epic: Ordered application of annotations to avoid fragmentation (e.g. ''[[Foo|Fo]]''[[Foo|o]]) - https://phabricator.wikimedia.org/T52098#1848435 (10Jdforrester-WMF) In the merged example, VE is generating `

Foo we can go full table cell [17:32:02] yep [17:32:16] (03CR) 10Jforrester: [C: 032] Fix-up Ie5414f62c: Fix call to non existant method [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/256718 (owner: 10Esanders) [17:32:26] happy with all that - but focusing on things I need urgently [17:32:30] (03CR) 10Jforrester: [C: 032] "Let's fix the icon later." [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/256721 (owner: 10Esanders) [17:32:49] It's a difficult thing to express incredibly-well as an icon. [17:33:00] True. [17:33:06] Especially in a cross-cultural way. [17:33:16] edsanders: You OK with 256415 ? [17:33:18] what's wrong with words? text? letters? :( [17:33:35] MatmaRex: "RegEx" isn't more obvious to people either. :-) [17:34:11] "regex" is obvious to people who know what regex is. an icon here is not obvious to anyone at all. :) [17:34:47] (the icons in sublime for find-and-replace and also awful. they're so bad, i learned the keyboard shortcuts to toggle each of them.) [17:35:01] Atom goes with '.*' for regex, which probably gets the point across to anyone who'd also understand "regex". Sublime's '[ ]' is a bit less obvious, I think. [17:36:27] This reminds me that I need to get back to nagging the atom people about accepting my pull request. It's totally unusable for me in our vagrant setup with how they have the file finder working right now. :-P [17:37:26] I like Atom's icons in general. [17:37:54] (03Merged) 10jenkins-bot: Fix-up Ie5414f62c: Fix call to non existant method [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/256718 (owner: 10Esanders) [17:38:03] (03Merged) 10jenkins-bot: FindAndReplace: Implement whole word matching [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/256721 (owner: 10Esanders) [17:38:16] Yeah, them having more resources to throw at polish than Sublime shows. Still a shame about the lower performance, though. [17:39:07] The performance problem isn't much of an issue in practice for me. [17:40:57] I remember it annoyed me last time I tried it. Though the bigger problem for me is that I've really internalized using sublime's project-wide symbol search, and Atom relies on you setting up and regularly running ctags for that. [17:41:21] It does? [17:41:24] (What's ctags?) [17:42:46] (03PS2) 10Jforrester: Update VE core submodule to master (d6f2d75) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/256722 (owner: 10Esanders) [17:42:56] ctags is a utility that reads all the files in a directory and saves a list of symbols for easy lookup. Atom does per-file symbol lookup without it, but it doesn't do indexing of a whole project on its own. [17:43:31] Oh, interesting. [17:43:59] (03CR) 10Jforrester: [C: 032] Update VE core submodule to master (d6f2d75) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/256722 (owner: 10Esanders) [17:44:09] Whereas Sublime does a background indexing run using the same syntax-definitions it uses for per-file stuff. [17:44:45] * James_F nods. [17:46:27] (03CR) 10Jforrester: [C: 032] "Documentation wording is simple enough, I think." [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/256415 (https://phabricator.wikimedia.org/T120052) (owner: 10Esanders) [17:47:09] (03PS6) 10Jforrester: Provide methods to (de)serialize transactions [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/231017 (https://phabricator.wikimedia.org/T74658) (owner: 10Esanders) [17:47:19] edsanders: You reviewing https://gerrit.wikimedia.org/r/#/c/254195/ ? [17:50:14] That patch did leave me thinking that I should probably expand the documentation comments to add some deeper explanation of what the semantic meaning of things like "canContainContent" is. [17:50:41] And should it actually be "could contain content"? ;-) [17:51:22] It's really "could contain things that could contain content, but cannot itself contain content". [17:51:36] Which, admittedly, is a bit verbose as a function name. [17:52:02] (03Merged) 10jenkins-bot: Update VE core submodule to master (d6f2d75) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/256722 (owner: 10Esanders) [17:52:04] (03Merged) 10jenkins-bot: Forward-delete at end of document shouldn't do anything [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/256415 (https://phabricator.wikimedia.org/T120052) (owner: 10Esanders) [17:52:39] Kemayo: CanContainContentfulNodes? [17:52:53] Would probably be more exact, yeah. [18:10:59] 10VisualEditor, 10VisualEditor-ContentEditable, 10VisualEditor-Links: Clicking the 'remove' button in the link context doesn't work if the cursor is at the beginning of the link text - https://phabricator.wikimedia.org/T119923#1849103 (10DLynch) Definitely has a conceptual relationship to T114376. [18:11:07] 10VisualEditor, 10Math, 5Patch-For-Review: Math dialog layout breaks down when height is limited - https://phabricator.wikimedia.org/T119900#1849106 (10Jdforrester-WMF) [18:11:10] 10VisualEditor, 10Math: Math dialog input not always focused on first open - https://phabricator.wikimedia.org/T119778#1849107 (10Jdforrester-WMF) [18:11:40] 10VisualEditor, 10VisualEditor-ContentEditable, 10VisualEditor-Links: Clicking the 'remove' button in the link context doesn't work if the cursor is at the beginning of the link text - https://phabricator.wikimedia.org/T119923#1849121 (10Jdforrester-WMF) >>! In T119923#1849103, @DLynch wrote: > Definitely ha... [18:12:40] 10VisualEditor, 10Graph, 10MediaWiki-API: Add action=parse ability to do recursivePreprocess - https://phabricator.wikimedia.org/T100570#1849122 (10Jdforrester-WMF) [18:12:58] 10VisualEditor, 10Graph: Edit graph colors in VisualEditor - https://phabricator.wikimedia.org/T109629#1849125 (10Jdforrester-WMF) [18:13:01] 10VisualEditor, 10Graph: While using the resize handler on a graph, the lowest limit for resizing is 60x60px, but not when resizing from dialog - https://phabricator.wikimedia.org/T119261#1849124 (10Jdforrester-WMF) [18:13:04] 10VisualEditor, 10Graph, 5Patch-For-Review: "TypeError: can't convert undefined to object" apperas when I delete all the co-ordinates from Data section of the Graph editor and cannot open any other inspector after that - https://phabricator.wikimedia.org/T118898#1849123 (10Jdforrester-WMF) [18:13:09] 10VisualEditor, 10Graph: While using the resize handler on a graph, the lowest limit for resizing is 60x60px, but not when resizing from dialog - https://phabricator.wikimedia.org/T119261#1822228 (10Jdforrester-WMF) [18:13:12] 10VisualEditor, 10Graph: Edit graph colors in VisualEditor - https://phabricator.wikimedia.org/T109629#1554710 (10Jdforrester-WMF) [18:13:15] 10VisualEditor, 10Graph, 5Patch-For-Review: "TypeError: can't convert undefined to object" apperas when I delete all the co-ordinates from Data section of the Graph editor and cannot open any other inspector after that - https://phabricator.wikimedia.org/T118898#1811974 (10Jdforrester-WMF) [18:13:33] 10VisualEditor, 10Graph: While using the resize handler on a graph, the lowest limit for resizing is 60x60px, but not when resizing from dialog - https://phabricator.wikimedia.org/T119261#1822228 (10Jdforrester-WMF) [18:13:36] 10VisualEditor, 10Graph: Edit graph colors in VisualEditor - https://phabricator.wikimedia.org/T109629#1554710 (10Jdforrester-WMF) [18:13:39] 10VisualEditor, 10Graph, 7Epic: [Objective] It's easier to create and edit charts from within VisualEditor - https://phabricator.wikimedia.org/T119233#1849129 (10Jdforrester-WMF) [18:18:04] 10Citoid, 10VisualEditor: Add ability to request base types in citoid, and offer use of both in extension for backwards compatibility until all templateData has been updated. - https://phabricator.wikimedia.org/T114515#1849162 (10kaldari) @Mvolz: Thanks for fixing this! [18:18:48] 10Citoid, 10VisualEditor: Add ability to request base types in citoid, and offer use of both in extension for backwards compatibility until all templateData has been updated. - https://phabricator.wikimedia.org/T114515#1849168 (10kaldari) [18:18:50] 10Citoid, 6Community-Tech: Add Citoid support to RefToolbar gadget - https://phabricator.wikimedia.org/T114156#1849167 (10kaldari) [18:37:30] 10VisualEditor, 10Graph, 10MediaWiki-API: Add action=parse ability to do recursivePreprocess - https://phabricator.wikimedia.org/T100570#1849268 (10Anomie) 5Open>3Invalid a:3Anomie This seems hopelessly confused, so I'm going to close it. `recursivePreprocess` is certainly not the right answer, as expl... [18:46:06] 10Citoid, 3Google-Code-In-2015: Add scraping of Highwire Press tags to html-metadata node library - https://phabricator.wikimedia.org/T118633#1849346 (10Aklapper) https://codein.withgoogle.com/dashboard/tasks/5751270849642496/ [18:51:39] 10VisualEditor, 10VisualEditor-EditingTools: Append a references list to bottom of the page when the first reference is added - https://phabricator.wikimedia.org/T56906#1849371 (10Jdforrester-WMF) [20:30:21] 10Citoid, 10VisualEditor: Add ability to request base types in citoid, and offer use of both in extension for backwards compatibility until all templateData has been updated. - https://phabricator.wikimedia.org/T114515#1849825 (10kaldari) I updated the documentation at https://www.mediawiki.org/wiki/Citoid/API. [21:23:21] Kemayo: Lovely work. [22:22:05] 10Citoid, 10VisualEditor: Add ability to request base types in citoid, and offer use of both in extension for backwards compatibility until all templateData has been updated. - https://phabricator.wikimedia.org/T114515#1850624 (10kaldari) @Mvolz: The new basefields argument seems to work great for book section... [22:25:19] 10Citoid, 10VisualEditor: Add ability to request base types in citoid, and offer use of both in extension for backwards compatibility until all templateData has been updated. - https://phabricator.wikimedia.org/T114515#1850653 (10kaldari) [22:40:46] James_F|Away, are we going to deploy this link suggester as a en.wiki global gadget? [22:42:31] enwiki global gadget? [22:42:40] default gadget? [22:43:13] I don't know much about gadgets [22:43:37] it's not going to be enabled for everyone [22:43:48] just people taking part in the user feedback [22:43:53] so people will have to opt-in to the gadget [22:43:58] yeah that's just an ordinary gadget [22:44:01] Kemayo, what is the viewportPadding=25 for? [22:44:30] yeah - are we allowed to deploy those without consent? [22:44:43] (in a couple of weeks) [22:45:23] Edsanders: it's just splitting out an existing magic number into a constant. [22:45:43] what is it for? [22:45:57] does it break if it is zero or just look tight? [22:46:16] On most wikis anyone with interface editing rights (admins, etc.) can add gadgets whenever they want [22:46:37] sure - but politically... [22:46:45] as for enwiki, and with (WMF) accounts involved... Yeah, not sure about that one. [22:47:16] Just looks tight. It seemed to be there to put a little padding at the top/bottom, basically. [22:48:23] with current behaviour the scrollIntoView leaves no padding [22:48:41] I could provide the unpadded values as well, for more accurate viewport sizes if something needs them, I suppose. [22:49:18] ah [22:49:29] did you get the padding from the find and replace binary search thing? [22:49:51] Yeah, it's the 50 in there. [22:50:21] right - I think that's so find results don't appear right at the edge of the viewport [22:50:28] let's make the method return unpadded [22:50:47] and use a hard-coded (commented) padding in the find and replace thing [22:51:12] for popup clipping we typically use as much space as we have [22:52:30] for find and replace you might need the context of the next line, but for this link inspector we should use all the vertical space we have so scrolling is easier [22:52:59] looks good otherwise [22:55:22] (03CR) 10Esanders: [C: 04-1] "Move the hard-coded padding back to getViewportRange." [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/254195 (https://phabricator.wikimedia.org/T114614) (owner: 10DLynch) [23:00:54] (03CR) 10Esanders: "agree with Timo's comment about legibility of 'preferve' (preserve?) vs 'prefer-ve'" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/248369 (https://phabricator.wikimedia.org/T58337) (owner: 10Alex Monk) [23:01:36] (03CR) 10Esanders: "Ironic that the Dutch guy is telling us to split our words." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/248369 (https://phabricator.wikimedia.org/T58337) (owner: 10Alex Monk) [23:01:54] lol [23:07:47] edsanders, any thoughts on the rest of the code? [23:08:30] (03PS5) 10DLynch: Limit the height of desktop-context popups [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/254195 (https://phabricator.wikimedia.org/T114614) [23:08:39] I need to give it a proper test and read - but it's looked ok up to now [23:13:46] (03CR) 10Esanders: [C: 04-1] "missed some doc" (031 comment) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/254195 (https://phabricator.wikimedia.org/T114614) (owner: 10DLynch) [23:26:39] edsanders: enwiki opt-in gadget, yes. [23:28:46] 10VisualEditor, 10Graph: Migrate ext.graph.VisualEditor to Vega 2 - https://phabricator.wikimedia.org/T120319#1850869 (10ferdbold) 3NEW [23:29:30] (03PS31) 10Alex Monk: [WIP] Single edit tab [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/248369 (https://phabricator.wikimedia.org/T58337) [23:32:35] 10VisualEditor, 10Graph: Migrate ext.graph.VisualEditor to Vega 2 - https://phabricator.wikimedia.org/T120319#1850886 (10Krenair) > Existing Vega 1 graphs should be able to be converted to Vega 2 syntax seamlessly upon an edit. So anyone editing a page will cause unrelated syntax to be updated? We specifical... [23:38:41] James_F, so to show this dialog as soon as the user clicks edit, we'll need to load OOjs UI [23:39:33] Krenair: I was thinking of showing it as a post-load dialog (like the welcome dialog), at which point we have OOUI in both editors, right? [23:40:39] yes [23:41:04] Does that work for you? [23:41:13] Don't want to make more work. :-( [23:41:33] well this is definitely more work [23:41:58] We can not do the "and then switch" bit. [23:46:10] 10VisualEditor, 10Flow, 3Collaboration-Team-Current, 5WMF-deploy-2015-12-08_(1.27.0-wmf.8): [Regression pre-wmf.8] Insert a mention in any Flow editor (in VE mode) is broken (on master) - https://phabricator.wikimedia.org/T119773#1850929 (10Jdforrester-WMF) p:5High>3Unbreak! [23:47:19] So we need to come up with a new way to signal to the client to show the dialog in the wikitext editor [23:47:43] maybe I can set some attribute on the tab [23:48:51] Why? [23:50:12] because the current way is to tell VE to show the dialog via VE's page metadata api [23:50:27] which isn't going to work in the wikitext editor [23:55:06] Hmm. Or run an onReady-equivalent for WE to check if it needs to run? [23:58:41] James_F, what? [23:58:57] the check has to be done server-side and then communicated to the client [23:59:05] Krenair: Have a tiny bit of code that loads on every editor load. [23:59:09] sure [23:59:19] Oh, yeah, the 'has the editor used this before' check. [23:59:21] we do that already for the WT->VE switch tab [23:59:21] Bah. [23:59:38] We can't do that check client-side. [23:59:51] Can we approximate it with a different check that we can do client-side?