[00:02:55] edsanders: The release happened four hours ago. [00:03:02] ok [00:03:36] (Cut happened four hours ago, that is; release happened only a few minutes ago.) [00:05:21] you left a comment saying "Should we fix this?" [00:06:29] (03PS3) 10Esanders: [DEPRECATING CHANGE] Rename link inspector tools [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/257387 [00:06:50] (03PS2) 10Esanders: [PULL THROUGH] Tool refactor [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/257589 [00:09:00] (03CR) 10jenkins-bot: [V: 04-1] [PULL THROUGH] Tool refactor [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/257589 (owner: 10Esanders) [00:10:08] (03CR) 10jenkins-bot: [V: 04-1] [DEPRECATING CHANGE] Rename link inspector tools [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/257387 (owner: 10Esanders) [00:18:05] (03PS1) 10Esanders: Fix the typo [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/257783 [00:18:50] (03PS4) 10Esanders: [DEPRECATING CHANGE] Rename link inspector tools [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/257387 [00:18:50] (03PS2) 10Jforrester: ve.ui.Icons.css: Fix inpsector typo [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/257783 (owner: 10Esanders) [00:18:55] (03CR) 10Jforrester: [C: 032] ve.ui.Icons.css: Fix inpsector typo [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/257783 (owner: 10Esanders) [00:19:21] (03CR) 10Esanders: "It's "The Typo (TM)"" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/257783 (owner: 10Esanders) [00:19:52] edsanders: :-) [00:23:23] (03CR) 10jenkins-bot: [V: 04-1] ve.ui.Icons.css: Fix inpsector typo [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/257783 (owner: 10Esanders) [00:24:10] (03CR) 10Jforrester: [C: 032] "Dear Jenkins: Hush." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/257783 (owner: 10Esanders) [00:27:56] (03Merged) 10jenkins-bot: ve.ui.Icons.css: Fix inpsector typo [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/257783 (owner: 10Esanders) [00:31:56] edsanders, and then Err. s/fix/merge/ [00:36:59] (03PS1) 10Jforrester: build: Add grunt-tyops and make pass [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/257790 [00:37:22] (03CR) 10Jforrester: build: Add grunt-tyops and make pass (031 comment) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/257790 (owner: 10Jforrester) [00:37:52] (03CR) 10Jforrester: [C: 032] "Too late." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/248369 (https://phabricator.wikimedia.org/T58337) (owner: 10Alex Monk) [00:40:49] (03Merged) 10jenkins-bot: Single edit tab and section links [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/248369 (https://phabricator.wikimedia.org/T58337) (owner: 10Alex Monk) [00:45:04] (03PS1) 10Jforrester: build: Add grunt-tyops [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/257794 [00:45:31] James_F, do we want to enable this on a beta site somewhere? [00:45:36] Krenair: Want to merge https://gerrit.wikimedia.org/r/#/c/257790/ https://gerrit.wikimedia.org/r/#/c/257794/ so those typos go away? [00:45:43] Krenair: Sure. I was thinking SWAT tomorrow. Sound OK? [00:45:48] ok [00:45:52] (Morning.) [00:46:14] Krenair: Want to write it, or should I? [00:46:24] you can [00:46:36] if you don't want to, I will [00:46:38] Kk. :-) [00:48:12] James_F, no [ "arrray", "array" ] ? :D [00:48:24] Krenair: Feel free to add it. :-) [00:51:07] (03PS2) 10Alex Monk: build: Add grunt-tyops and make pass [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/257790 (owner: 10Jforrester) [00:51:25] (03CR) 10Jforrester: [C: 031] build: Add grunt-tyops and make pass [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/257790 (owner: 10Jforrester) [00:51:44] (03CR) 10Alex Monk: [C: 032] build: Add grunt-tyops and make pass [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/257790 (owner: 10Jforrester) [00:53:53] (03PS2) 10Alex Monk: build: Add grunt-tyops [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/257794 (owner: 10Jforrester) [00:54:56] (03CR) 10Alex Monk: [C: 032] build: Add grunt-tyops [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/257794 (owner: 10Jforrester) [00:56:12] (03Merged) 10jenkins-bot: build: Add grunt-tyops and make pass [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/257790 (owner: 10Jforrester) [00:58:01] (03Merged) 10jenkins-bot: build: Add grunt-tyops [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/257794 (owner: 10Jforrester) [00:59:36] So hopefully beta still works [01:02:28] // Transfer methods [01:02:28] ve.init.mw.DesktopArticleTarget.prototype.setupSectionEditLinks = init.setupSectionLinks; [01:02:32] what is that? :| [01:03:09] Krinkle, ^ [01:07:05] back/forward button behaviour is also something to check [01:08:12] Krenair: It'd be nice if RESTbase was working in Beta Cluster first. [01:08:19] ugh [01:10:26] http 503 [01:10:29] Yeah. [01:10:36] Don't worry about that. [01:29:33] 10VisualEditor: When editing an old revision in the visual editor, switching to the wikitext editor without changes moves you to the newest revision - https://phabricator.wikimedia.org/T120898#1864381 (10Neil_P._Quinn_WMF) [01:32:38] 10VisualEditor, 10VisualEditor-ContentEditable, 10VisualEditor-Links, 10VisualEditor-MediaWiki-Links, 5WMF-deploy-2015-12-15_(1.27.0-wmf.9): Model and view out of sync when link deleted and replaced with text - https://phabricator.wikimedia.org/T115001#1864386 (10Jdforrester-WMF) [01:42:39] (03CR) 10Jforrester: [C: 031] "Breaking change, right?" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/257775 (owner: 10Esanders) [01:43:09] (03CR) 10Jforrester: [C: 031] [DEPRECATING CHANGE] Rename link inspector tools [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/257387 (owner: 10Esanders) [02:25:49] (03PS1) 10Alex Monk: Single edit tab: Deal with section link clicks [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/257814 (https://phabricator.wikimedia.org/T58337) [02:27:31] 10VisualEditor, 10VisualEditor-MediaWiki: When editing an old revision in the visual editor, switching to the wikitext editor without changes moves you to the newest revision - https://phabricator.wikimedia.org/T120898#1864451 (10Krenair) Please add #VisualEditor-MediaWiki to these bugs - I only happened to se... [02:28:55] RoanKattouw: http://en.wikipedia.beta.wmflabs.org/wiki/User:Jdforrester_(WMF)/Sandbox [03:06:23] (03PS1) 10Jforrester: Update VE core submodule to master (cd979fe) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/257818 [03:13:17] (03PS5) 10Jforrester: Edit mode switching: Tell VE if the wikitext was modified [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/252246 (owner: 10Esanders) [03:13:39] (03CR) 10Jforrester: [C: 04-1] "Per Krenair's comment on PS4." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/252246 (owner: 10Esanders) [03:16:29] (03CR) 10Jforrester: [C: 04-1] "Needs rebase." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/252345 (owner: 10Esanders) [03:27:11] (03PS5) 10Jforrester: [WIP] Convert a heading with multiple child paragraphs sanely [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/114355 (owner: 10Esanders) [03:27:53] (03CR) 10Jforrester: "Despite the new commit label being less gnomic, it's also a lie; this is just a failing test case, albeit one with an actual expected resu" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/114355 (owner: 10Esanders) [03:30:55] (03CR) 10jenkins-bot: [V: 04-1] [WIP] Convert a heading with multiple child paragraphs sanely [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/114355 (owner: 10Esanders) [06:56:41] 10Citoid, 6Security-Team: Citoid converts ignores <302::aid-ajmg13> - https://phabricator.wikimedia.org/T119494#1864612 (10Mvolz) That's true, but we can't guarantee that every consumer of the doi field is going to be html, so that makes me concerned. I think I'd be happier not using striptags just on the doi... [09:57:04] 10VisualEditor, 7Milestone: Make VisualEditor good enough to use with all common IMEs for Korean - https://phabricator.wikimedia.org/T110654#1864842 (10revi) [09:57:06] 10VisualEditor, 10VisualEditor-MediaWiki: Release VisualEditor-MediaWiki as "1.0" - https://phabricator.wikimedia.org/T84936#1864843 (10revi) [09:57:08] 10VisualEditor, 10VisualEditor-ContentLanguage, 5WMF-deploy-2015-12-08_(1.27.0-wmf.8): Cannot type in Korean using Mozilla on Windows 7 with dual-script keyboard - https://phabricator.wikimedia.org/T72353#1864840 (10revi) 5Resolved>3Open Nope., It's still happening, in different form now. ---- Current s... [10:14:48] 10VisualEditor, 10VisualEditor-ContentEditable, 7Browser-Support-Firefox: Uncommitted Korean IME candidate text ignored when user presses enter, causing CE/DM desync in Firefox - https://phabricator.wikimedia.org/T120156#1864863 (10dchan) Hi, I can't reproduce this on Ubuntu or Windows 8 - can you type the s... [11:55:11] 10VisualEditor, 6Commons, 10MediaWiki-Uploading, 6Multimedia: Copyvios via cross-wiki uploads tool - https://phabricator.wikimedia.org/T120931#1864996 (10Steinsplitter) 3NEW [11:55:47] 10VisualEditor, 6Commons, 10MediaWiki-Uploading, 6Multimedia: Copyvios via cross-wiki uploads tool - https://phabricator.wikimedia.org/T120931#1865004 (10Steinsplitter) [11:58:41] 10VisualEditor, 6Commons, 10MediaWiki-Uploading, 6Multimedia: Copyvios via cross-wiki uploads tool - https://phabricator.wikimedia.org/T120931#1864996 (10Steinsplitter) Just noticed i created a duplicate (T120867) . Sorry for that. [12:05:57] (03CR) 10Esanders: [C: 04-1] Single edit tab: Deal with section link clicks (031 comment) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/257814 (https://phabricator.wikimedia.org/T58337) (owner: 10Alex Monk) [12:07:00] (03CR) 10Esanders: [C: 032] Update VE core submodule to master (cd979fe) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/257818 (owner: 10Jforrester) [12:10:12] (03Merged) 10jenkins-bot: Update VE core submodule to master (cd979fe) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/257818 (owner: 10Jforrester) [12:52:27] 10Citoid, 6Security-Team: Citoid converts ignores <302::aid-ajmg13> - https://phabricator.wikimedia.org/T119494#1865086 (10mobrovac) I'm with @Mvolz that the best solution might be not to enforce tag stripping on all of the fields. But, before we do that, I'd like to see some research conducted into what happe... [13:40:07] (03PS1) 10Esanders: Fix more typos [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/257875 [13:54:18] Krenair, James_F|Away http://deployment.wikimedia.beta.wmflabs.org/wiki/Korea?veaction=edit link doesn't launch VE for me... [13:54:43] nor http://en.wikipedia.beta.wmflabs.org/wiki/Cat?veaction=edit - it looks like single edit tab is enabled on those wikis [13:55:37] Krenair, separately we should continue to support ?veaction=edit for old links [13:58:11] 10VisualEditor, 10VisualEditor-MediaWiki-Media, 10MediaWiki-General-or-Unknown, 6Multimedia: Show determinate progress bar for the image upload in mw.ForeignStructuredUpload.BookletLayout - https://phabricator.wikimedia.org/T115861#1865176 (10Prtksxna) @matmarex, should this be part of OOjs UI core or part... [14:04:12] 10VisualEditor, 6Commons, 10MediaWiki-Uploading, 6Multimedia: Copyvios via cross-wiki uploads tool - https://phabricator.wikimedia.org/T120931#1865184 (10zhuyifei1999) [15:44:38] (03CR) 10DLynch: [C: 032] Fix more typos [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/257875 (owner: 10Esanders) [15:50:10] (03PS1) 10Esanders: VE: Rename parent tool [extensions/Citoid] - 10https://gerrit.wikimedia.org/r/257899 [15:51:49] Heya. [15:51:51] Kemayo: Oh, you submitted as well as +2'ed? :-) [15:52:32] ...I clicked the wrong button, and am watching it to see what it's doing in response. [15:52:38] * James_F grins. [15:52:53] It will just have confused jenkins-bot a little. No worries. [15:53:04] (Had it V-1'ed it'd be a different matter.) [15:56:33] (03PS1) 10Esanders: EducationPopup: Increase z-index above toolbar dialog's [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/257902 (https://phabricator.wikimedia.org/T116577) [15:57:15] edsanders: Does that also fix being above shields? [15:58:21] yes [15:58:30] Yay. [15:58:36] * James_F tests. [15:58:43] they are z-index 1 [16:08:11] 10VisualEditor, 10VisualEditor-MediaWiki, 10VisualEditor-MediaWiki-Links: Remove button appears on context menu for MW link nodes, but does not do anything - https://phabricator.wikimedia.org/T120705#1865620 (10DLynch) a:3DLynch [16:09:12] Krenair: Ho-hum. Did I screw up the wgVisualEditorUseSingleEditTab patch? Beta Cluster seems unaffected. [16:09:34] edsanders, no single edit tab on deploymentwiki [16:10:01] Krenair, why doesn't veaction=edit work? [16:10:42] James_F, you enabled it on enwiki only [16:10:50] not deploymentwiki [16:10:55] Krenair: Yes…? [16:11:05] It's working now. Odd it took so long to take effect. [16:11:30] works for me on beta enwiki [16:11:32] ah [16:11:32] Yup. [16:12:05] (03PS1) 10DLynch: Make clear button on numbered external links remove the node [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/257907 (https://phabricator.wikimedia.org/T120705) [16:12:27] Kemayo: Neat. [16:13:09] Subclassing artifact, really. All the other links are attributes... but that particular variant down the chain is really an alien node. [16:14:01] Yeah. [16:14:07] I blame inheritance. [16:15:19] I figured it made more sense to override what the clear button does, so the context popup is consistent with other links, than to have that one link popup show a "remove" button. [16:17:05] * James_F nods. [16:17:42] (03CR) 10Jforrester: [C: 032] EducationPopup: Increase z-index above toolbar dialog's [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/257902 (https://phabricator.wikimedia.org/T116577) (owner: 10Esanders) [16:17:58] 10VisualEditor, 10VisualEditor-MediaWiki: Educational popups overlap with toolbar dialogs, selection highlights - https://phabricator.wikimedia.org/T116577#1865640 (10Jdforrester-WMF) 5Open>3Resolved a:3Esanders [16:18:29] (03CR) 10Jforrester: [C: 032] Make clear button on numbered external links remove the node [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/257907 (https://phabricator.wikimedia.org/T120705) (owner: 10DLynch) [16:25:24] 10VisualEditor, 10VisualEditor-MediaWiki, 10VisualEditor-MediaWiki-Links: Remove button appears on context menu for MW link nodes, but does not do anything - https://phabricator.wikimedia.org/T120705#1865686 (10Jdforrester-WMF) 5Open>3Resolved [16:26:29] (03Merged) 10jenkins-bot: EducationPopup: Increase z-index above toolbar dialog's [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/257902 (https://phabricator.wikimedia.org/T116577) (owner: 10Esanders) [16:26:31] (03Merged) 10jenkins-bot: Make clear button on numbered external links remove the node [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/257907 (https://phabricator.wikimedia.org/T120705) (owner: 10DLynch) [16:47:31] (03PS1) 10Esanders: Fix typos [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/257923 [16:48:50] (03PS1) 10Esanders: Fix typos [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/257924 [16:49:29] (03CR) 10Jforrester: [C: 032] Fix typos (031 comment) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/257923 (owner: 10Esanders) [16:51:20] (03CR) 10Jforrester: [C: 032] Fix typos [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/257924 (owner: 10Esanders) [16:54:43] 10VisualEditor, 10VisualEditor-MediaWiki, 10VisualEditor-MediaWiki-Links: Remove button appears on context menu for MW link nodes, but does not do anything - https://phabricator.wikimedia.org/T120705#1865819 (10Esanders) We should either change the icon to delete or remove it. [16:55:56] (03Merged) 10jenkins-bot: Fix typos [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/257923 (owner: 10Esanders) [16:57:21] (03Merged) 10jenkins-bot: Fix typos [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/257924 (owner: 10Esanders) [16:57:58] edsanders: Eh. Maybe. [16:59:55] 10VisualEditor, 10VisualEditor-MediaWiki: On single edit tabs wikis, if the user is opted-out of VE, don't show them the tab config option - https://phabricator.wikimedia.org/T120965#1865831 (10Jdforrester-WMF) 3NEW [17:02:14] 10VisualEditor, 10VisualEditor-MediaWiki: On single edit tab wikis, clicking on a section edit link gives an editor whose switching works oddly - https://phabricator.wikimedia.org/T120966#1865848 (10Jdforrester-WMF) 3NEW [17:02:41] 10VisualEditor, 10VisualEditor-MediaWiki: On single edit tab wikis, clicking on a section edit link gives an editor whose switching works oddly - https://phabricator.wikimedia.org/T120966#1865848 (10Jdforrester-WMF) [17:02:42] 10VisualEditor, 10VisualEditor-MediaWiki: On single edit tabs wikis, if the user is opted-out of VE, don't show them the tab config option - https://phabricator.wikimedia.org/T120965#1865857 (10Jdforrester-WMF) [17:02:45] 10VisualEditor, 10VisualEditor-MediaWiki, 7Design, 7Epic, and 2 others: Change VE integration to only use one edit tab, to avoid user choice paralysis - https://phabricator.wikimedia.org/T58337#1865855 (10Jdforrester-WMF) [17:09:15] (03PS2) 10Jforrester: DesktopArticleTarget: Handle section edit link clicks in single edit tab mode [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/257814 (https://phabricator.wikimedia.org/T58337) (owner: 10Alex Monk) [17:11:46] (03CR) 10Alex Monk: [C: 032] "Umm. Thanks, James" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/257814 (https://phabricator.wikimedia.org/T58337) (owner: 10Alex Monk) [17:12:07] Krenair: Ha, sorry. :-) [17:12:21] Krenair: Were you doing it? [17:12:25] I was about to [17:12:39] Then I saw it move up my inbox and realised you had [17:12:41] Saved you the hassle. :-) [17:14:20] So far I've spotted two (minor) issues, beyond the FOUC and of course the feature-detection. [17:16:14] (03Merged) 10jenkins-bot: DesktopArticleTarget: Handle section edit link clicks in single edit tab mode [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/257814 (https://phabricator.wikimedia.org/T58337) (owner: 10Alex Monk) [17:20:09] 10VisualEditor, 10VisualEditor-MediaWiki: On single edit tab wikis, if the user has a 'wt always' preference, action=edit gives a blank page - https://phabricator.wikimedia.org/T120969#1865918 (10Jdforrester-WMF) 3NEW a:3Krenair [17:23:02] 10VisualEditor, 10VisualEditor-MediaWiki: On single edit tab wikis, if the user has a 've always' preference, there's a FOUC from 'edit' to 'edit source' on non-VE namespaces - https://phabricator.wikimedia.org/T120970#1865929 (10Jdforrester-WMF) 3NEW a:3Krenair [17:24:29] Krenair: https://phabricator.wikimedia.org/T120969 is not so minor. :-( [17:35:18] (03PS1) 10Esanders: Avoid useless jQuery.click shortcut [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/257937 [17:36:51] (03CR) 10Esanders: "Technically yes, but it isn't used outside of core." [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/257775 (owner: 10Esanders) [17:39:45] (03PS6) 10Esanders: Edit mode switching: Tell VE if the wikitext was modified [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/252246 [17:45:14] (03PS7) 10Esanders: Edit mode switching: Tell VE if the wikitext was modified [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/252246 [17:46:47] (03CR) 10Esanders: Edit mode switching: Tell VE if the wikitext was modified (031 comment) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/252246 (owner: 10Esanders) [17:54:55] (03CR) 10Jforrester: [C: 032] Edit mode switching: Tell VE if the wikitext was modified [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/252246 (owner: 10Esanders) [17:55:27] (03CR) 10Jforrester: [C: 032] Annotation: Rename 'inferFromDom' to 'inferFromView' [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/257775 (owner: 10Esanders) [17:58:34] (03Merged) 10jenkins-bot: Edit mode switching: Tell VE if the wikitext was modified [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/252246 (owner: 10Esanders) [18:00:00] (03CR) 10Divec: [C: 032] Annotation: Rename 'inferFromDom' to 'inferFromView' [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/257775 (owner: 10Esanders) [18:00:02] 10VisualEditor, 10VisualEditor-ContentEditable: TextState#getChangeTransaction throws exception on first change - https://phabricator.wikimedia.org/T120975#1866092 (10Esanders) 3NEW a:3dchan [18:00:13] Ha. Whoops. [18:01:09] (03Merged) 10jenkins-bot: Annotation: Rename 'inferFromDom' to 'inferFromView' [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/257775 (owner: 10Esanders) [18:14:54] 10VisualEditor, 10VisualEditor-MediaWiki: veaction=edit not working on beta cluster - https://phabricator.wikimedia.org/T120978#1866196 (10Esanders) 3NEW a:3Krenair [18:14:54] 10VisualEditor, 10VisualEditor-MediaWiki: veaction=edit not working on beta cluster - https://phabricator.wikimedia.org/T120978#1866204 (10Esanders) [18:15:06] (03CR) 10Anomie: "No comment on whether this *should* be done." (032 comments) [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/257684 (https://phabricator.wikimedia.org/T54581) (owner: 10Eranroz) [18:16:50] (03PS3) 10Esanders: [WIP] Edit mode switch: Show popup next to switch button [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/252345 [18:19:24] (03CR) 10Esanders: "The popup points to the button for switching back to VE ("click here"), and contains an 'X' for closing (also clicking away will close it)" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/252345 (owner: 10Esanders) [18:20:12] edsanders: WFM. [18:21:37] (03PS4) 10Esanders: [WIP] Edit mode switch: Show popup next to switch button [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/252345 [18:21:43] put some copy up in PS4 ^^ [18:22:23] Err. [18:23:04] Also do we want to do the same pop-out in reverse? (WT->VE)? [18:23:16] edsanders: "You have switched to the source editing" -> "You have switched to source editing" [18:24:22] (03PS5) 10Esanders: [WIP] Edit mode switch: Show popup next to switch button [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/252345 [18:24:57] edsanders: Looks good. [18:27:30] (03PS1) 10Divec: Count chunk list bounds more carefully [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/257956 (https://phabricator.wikimedia.org/T120975) [18:31:01] 10VisualEditor, 10VisualEditor-MediaWiki: On single edit tab wikis, if the user navigates straight to 'veaction=edit' without clicking and they don't have a editor preference cookie, nothing happens (they just get a read page) - https://phabricator.wikimedia.org/T120978#1866299 (10Jdforrester-WMF) [18:31:40] 10VisualEditor, 10VisualEditor-MediaWiki: On single edit tab wikis, if the user navigates straight to 'veaction=edit' without clicking and they don't have a editor preference cookie, nothing happens (they just get a read page) - https://phabricator.wikimedia.org/T120978#1866196 (10Jdforrester-WMF) [18:31:42] 10VisualEditor, 10VisualEditor-MediaWiki, 7Design, 7Epic, and 2 others: Change VE integration to only use one edit tab, to avoid user choice paralysis - https://phabricator.wikimedia.org/T58337#1866300 (10Jdforrester-WMF) [18:38:45] Krenair: How's it going? Anything I can do to help? [18:40:16] 10WikiEditor: Localized toolbar buttons to the Chechen language - https://phabricator.wikimedia.org/T119716#1866333 (10Paladox) Ok. Thanks. Could it follow the desgn of the other icons https://phabricator.wikimedia.org/diffusion/EWED/browse/master/modules/images/toolbar/format-bold-B.svg and also to be cleare y... [18:42:58] (03PS1) 10DLynch: Switch numbered link context to "delete" instead of "clear" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/257960 (https://phabricator.wikimedia.org/T120705) [19:05:57] 10VisualEditor, 10MediaWiki-extensions-RelatedArticles, 3Reading Web Sprint 62 - D________________: RelatedArticles conflicts with VisualEditor - https://phabricator.wikimedia.org/T120443#1866417 (10Jdlrobson) p:5High>3Normal [19:10:16] (03PS6) 10Jforrester: [WIP/POC/POS] Wikitext surface [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/229567 (https://phabricator.wikimedia.org/T104479) (owner: 10Esanders) [19:12:43] (03CR) 10jenkins-bot: [V: 04-1] [WIP/POC/POS] Wikitext surface [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/229567 (https://phabricator.wikimedia.org/T104479) (owner: 10Esanders) [19:25:54] 10VisualEditor: Switching to edit source giving blank page when I have option "Show me both editors" - https://phabricator.wikimedia.org/T120987#1866462 (10Ryasmeen) 3NEW [19:29:17] 10WikiEditor: Localized toolbar buttons to the Chechen language - https://phabricator.wikimedia.org/T119716#1866483 (10Paladox) The image also need to be 22 and 22 width for svg not sure about png. [19:41:42] 10WikiEditor: Localized toolbar buttons to the Chechen language - https://phabricator.wikimedia.org/T119716#1866532 (10Umar) I'm not an expert icon. It would be good if that makes specialist. [19:56:28] 10WikiEditor: Localized toolbar buttons to the Chechen language - https://phabricator.wikimedia.org/T119716#1866577 (10Paladox) Ok. I will upload a patch. And will have someone who is good at svg editing to help add the effects. [20:06:41] (03PS1) 10Paladox: Replace format-bold-ru.png image [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/257978 (https://phabricator.wikimedia.org/T119716) [20:25:46] 10VisualEditor, 10VisualEditor-MediaWiki-Media, 10MediaWiki-General-or-Unknown, 6Multimedia: Show determinate progress bar for the image upload in mw.ForeignStructuredUpload.BookletLayout - https://phabricator.wikimedia.org/T115861#1866707 (10matmarex) I'd keep it in the upload dialog for now. If we run in... [20:30:53] 10WikiEditor, 5Patch-For-Review: Localized toolbar buttons to the Chechen language - https://phabricator.wikimedia.org/T119716#1866749 (10Paladox) @Perhelion could I have help to add the styles that are used in the bold icons and apply them to https://commons.wikimedia.org/wiki/File:Toolbaricon_bold_%D3%80%D0%... [20:38:48] (03PS1) 10Paladox: Update grunt-jscs to 2.4.0 [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/257986 [20:41:32] (03PS2) 10Paladox: Update grunt-jscs to 2.5.0 [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/257986 [20:46:08] (03CR) 10Jforrester: [C: 04-1] "Fine with the TODO being TODONE." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/252345 (owner: 10Esanders) [21:32:56] James_F: I had some fun making this edit: https://www.mediawiki.org/w/index.php?title=Wikimedia_Developer_Summit_2016%2F2016-01-04&type=revision&diff=1960185&oldid=1958882 [21:33:14] James_F: I'll show you later today, but basically I removed single quotes from a table cell and they came back when I italicized the text [21:33:34] Odd. [21:35:33] Yeah I was surprised [21:46:01] 10VisualEditor: Wait unlimited on Resume editing button (in a certain context) - https://phabricator.wikimedia.org/T121017#1867059 (10Catrope) [22:11:51] (03CR) 10Alex Monk: [C: 032] Avoid useless jQuery.click shortcut [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/257937 (owner: 10Esanders) [22:18:14] (03Merged) 10jenkins-bot: Avoid useless jQuery.click shortcut [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/257937 (owner: 10Esanders) [22:19:05] 10VisualEditor: Wait unlimited on Resume editing button (in a certain context) - https://phabricator.wikimedia.org/T121017#1867231 (10Krenair) I do see weird cursor behaviour, but it doesn't break the resume editing button for me. [22:20:17] (03CR) 10Edokter: [C: 04-1] "The SVG is rendering text. It should be converted to using paths." [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/257978 (https://phabricator.wikimedia.org/T119716) (owner: 10Paladox) [22:22:52] 10WikiEditor, 5Patch-For-Review: Localized toolbar buttons to the Chechen language - https://phabricator.wikimedia.org/T119716#1867250 (10Paladox) This is a note by Edokterfor the svg image. "The SVG is rendering text. It should be converted to using paths." [22:27:21] (03CR) 10Paladox: "@Edokter the format-bold-A.svg image does this too." [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/257978 (https://phabricator.wikimedia.org/T119716) (owner: 10Paladox) [22:29:53] 10VisualEditor, 10VisualEditor-MediaWiki: On single edit tabs wikis, if the user is opted-out of VE, don't show them the tab config option - https://phabricator.wikimedia.org/T120965#1867308 (10Krenair) So if they change the value of that, we need to dynamically hide/unhide the tab preference? [22:30:38] 10VisualEditor, 10VisualEditor-MediaWiki: On single edit tabs wikis, if the user is opted-out of VE, don't show them the tab config option - https://phabricator.wikimedia.org/T120965#1867317 (10Jdforrester-WMF) >>! In T120965#1867308, @Krenair wrote: > So if they change the value of that, we need to dynamicall... [22:38:34] 10WikiEditor, 5Patch-For-Review: Localized toolbar buttons to the Chechen language - https://phabricator.wikimedia.org/T119716#1867369 (10Umar) PNG icon looks like this http://pastenow.ru/Upload/Paste/FUUE.png [22:41:38] (03PS1) 10Alex Monk: Hide VE tabs preference when user has disabled VE [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/258052 (https://phabricator.wikimedia.org/T120965) [22:44:55] (03CR) 10Jforrester: Hide VE tabs preference when user has disabled VE (032 comments) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/258052 (https://phabricator.wikimedia.org/T120965) (owner: 10Alex Monk) [22:51:23] (03PS1) 10Alex Monk: Single edit tab: Update preference value [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/258054 (https://phabricator.wikimedia.org/T120969) [22:51:55] 10VisualEditor, 6Design-Research: Not clear how to switch to VisualEditor - https://phabricator.wikimedia.org/T121032#1867463 (10Jdlrobson) 3NEW [22:52:07] 10VisualEditor, 10VisualEditor-MediaWiki: On single edit tab wikis, if the user has a 'wt always' preference, action=edit gives a blank page - https://phabricator.wikimedia.org/T120969#1867472 (10Jdforrester-WMF) 5Open>3Resolved [22:52:10] 10VisualEditor, 10VisualEditor-MediaWiki, 7Design, 7Epic, and 2 others: Change VE integration to only use one edit tab, to avoid user choice paralysis - https://phabricator.wikimedia.org/T58337#1867476 (10Jdforrester-WMF) [22:54:35] (03PS2) 10Alex Monk: Hide VE tabs preference when user has disabled VE [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/258052 (https://phabricator.wikimedia.org/T120965) [22:54:56] (03CR) 10Jforrester: [C: 032] Hide VE tabs preference when user has disabled VE [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/258052 (https://phabricator.wikimedia.org/T120965) (owner: 10Alex Monk) [22:55:13] 10VisualEditor, 10VisualEditor-MediaWiki: On single edit tabs wikis, if the user is opted-out of VE, don't show them the tab config option - https://phabricator.wikimedia.org/T120965#1867502 (10Jdforrester-WMF) 5Open>3Resolved a:3Krenair [22:55:16] 10VisualEditor, 10VisualEditor-MediaWiki, 7Design, 7Epic, and 2 others: Change VE integration to only use one edit tab, to avoid user choice paralysis - https://phabricator.wikimedia.org/T58337#1867507 (10Jdforrester-WMF) [22:56:33] 10VisualEditor, 6Design-Research: Not clear how to switch to VisualEditor - https://phabricator.wikimedia.org/T121032#1867511 (10Krenair) You need to go to your preferences. [22:57:29] 10VisualEditor, 10WikiEditor, 6Editing-Department, 10MediaWiki-Page-editing, and 3 others: MediaWiki should provide a pluggable registry for editor interfaces - https://phabricator.wikimedia.org/T120414#1867516 (10Florian) >>! In T120414#1855043, @Legoktm wrote: > Another thing we might want to consider is... [22:57:48] 10VisualEditor, 6Design-Research: Not clear how to switch to VisualEditor - https://phabricator.wikimedia.org/T121032#1867518 (10Jdlrobson) Okay now I've noticed the edit pencil in the top right corner. I was looking around the edit menu (even in the drop down with more options). I'm not sure if it wasn't load... [22:59:27] (03Merged) 10jenkins-bot: Hide VE tabs preference when user has disabled VE [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/258052 (https://phabricator.wikimedia.org/T120965) (owner: 10Alex Monk) [23:05:22] 10WikiEditor, 5Patch-For-Review: Localized toolbar buttons to the Chechen language - https://phabricator.wikimedia.org/T119716#1867555 (10Paladox) Yes. But the svg icon doesen't. It is using the colour dark blue where as it should use black. [23:05:41] (03PS1) 10Alex Monk: Don't check editor preferences etc. if user wants veaction=edit [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/258059 (https://phabricator.wikimedia.org/T120978) [23:06:05] Krenair: Nice. [23:13:42] 10VisualEditor, 10MediaWiki-extensions-RelatedArticles, 5Patch-For-Review, 3Reading Web Sprint 62 - D________________: RelatedArticles conflicts with VisualEditor - https://phabricator.wikimedia.org/T120443#1867582 (10Jdlrobson) a:3Jdlrobson [23:15:32] (03PS2) 10Paladox: Replace format-bold-ru.png image [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/257978 (https://phabricator.wikimedia.org/T119716) [23:21:58] 10VisualEditor, 10MediaWiki-extensions-RelatedArticles, 5Patch-For-Review, 3Reading Web Sprint 62 - D________________: RelatedArticles conflicts with VisualEditor - https://phabricator.wikimedia.org/T120443#1867608 (10Jdlrobson) I decided it's probably enough to simply hide this and rely on the .ve-activat... [23:33:34] 10VisualEditor, 10WikiEditor, 6Editing-Department, 10MediaWiki-Page-editing, and 3 others: MediaWiki should provide a pluggable registry for editor interfaces - https://phabricator.wikimedia.org/T120414#1867635 (10Legoktm) >>! In T120414#1867516, @Florian wrote: >>>! In T120414#1855043, @Legoktm wrote: >>...