[00:32:41] hi VE people, what's the best mw.hook event to clean up gadgets that would othervise stick around and look weird in the edit view? [00:33:17] tgr: Krenair might know, but I'm not sure we provide one? [00:34:21] yeah I don't think we provide one [01:04:46] 10VisualEditor, 10MediaWiki-extensions-RelatedArticles, 3Reading Web Sprint 62 - D________________: RelatedArticles disappears during edit process when using VisualEditor - https://phabricator.wikimedia.org/T120443#1868094 (10Jdlrobson) [01:09:13] 10VisualEditor: VisualEditor should fire an event on opening to allow other scripts to clean up - https://phabricator.wikimedia.org/T121050#1868121 (10Tgr) 3NEW [01:10:18] 10VisualEditor: VisualEditor should fire an event on opening to allow other scripts to clean up - https://phabricator.wikimedia.org/T121050#1868121 (10Tgr) [01:10:21] 10VisualEditor, 10MediaWiki-extensions-RelatedArticles, 3Reading Web Sprint 62 - D________________: RelatedArticles disappears during edit process when using VisualEditor - https://phabricator.wikimedia.org/T120443#1853969 (10Tgr) [01:13:41] 10VisualEditor: VisualEditor should fire an event on opening to allow other scripts to clean up - https://phabricator.wikimedia.org/T121050#1868149 (10Jdforrester-WMF) Politely, I'm unconvinced that this is a good idea. We intentionally do not use hooks. Starting now to help extensions and gadgets clean up after... [01:28:10] (03CR) 10Jforrester: [C: 032] Don't check editor preferences etc. if user wants veaction=edit [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/258059 (https://phabricator.wikimedia.org/T120978) (owner: 10Alex Monk) [01:28:27] 10VisualEditor, 10VisualEditor-MediaWiki: On single edit tab wikis, if the user navigates straight to 'veaction=edit' without clicking and they don't have a editor preference cookie, nothing happens (they just get a read page) - https://phabricator.wikimedia.org/T120978#1868224 (10Jdforrester-WMF) 5Open>3Re... [01:28:30] 10VisualEditor, 10VisualEditor-MediaWiki, 7Design, 7Epic, and 2 others: Change VE integration to only use one edit tab, to avoid user choice paralysis - https://phabricator.wikimedia.org/T58337#1868227 (10Jdforrester-WMF) [01:29:00] (03CR) 10Jforrester: [C: 032] Single edit tab: Update preference value [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/258054 (https://phabricator.wikimedia.org/T120969) (owner: 10Alex Monk) [01:32:29] (03Merged) 10jenkins-bot: Don't check editor preferences etc. if user wants veaction=edit [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/258059 (https://phabricator.wikimedia.org/T120978) (owner: 10Alex Monk) [01:33:27] (03Merged) 10jenkins-bot: Single edit tab: Update preference value [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/258054 (https://phabricator.wikimedia.org/T120969) (owner: 10Alex Monk) [01:40:19] 10VisualEditor: Backspace before inserting a citation loses all changes (due to browser behavior) - https://phabricator.wikimedia.org/T121059#1868259 (10Whatamidoing-WMF) 3NEW [01:41:53] 10VisualEditor: Backspace before inserting a citation loses all changes (due to browser behavior) - https://phabricator.wikimedia.org/T121059#1868267 (10Jdforrester-WMF) None of your changes will have been lost; if there are changes, backspace will trigger an "are you sure?" question. All you'll have lost is cur... [01:43:39] 10VisualEditor: VisualEditor should fire an event on opening to allow other scripts to clean up - https://phabricator.wikimedia.org/T121050#1868277 (10Tgr) >>! In T121050#1868149, @Jdforrester-WMF wrote: > Politely, I'm unconvinced that this is a good idea. We intentionally do not use hooks. Starting now to help... [02:39:51] 10VisualEditor, 10VisualEditor-MediaWiki, 7Design, 7Epic, 5WMF-deploy-2015-12-15_(1.27.0-wmf.9): Change VE integration to only use one edit tab, to avoid user choice paralysis - https://phabricator.wikimedia.org/T58337#1868374 (10Jdforrester-WMF) [03:46:55] 10VisualEditor, 10VisualEditor-MediaWiki, 10RESTBase: RESTBase doesn't purge restored/recreated pages -> VisualEditor unable to edit restored/recreated pages - https://phabricator.wikimedia.org/T119780#1868415 (10GWicke) The latest revision of that page at https://test2.wikipedia.org/api/rest_v1/page/html/Dr... [08:56:52] 10WikiEditor, 5Patch-For-Review: Localized toolbar buttons to the Chechen language - https://phabricator.wikimedia.org/T119716#1868707 (10Umar) Icon should be 22 × 22? A possible extension 35 × 22? [09:00:22] 10WikiEditor, 7Browser-Support-Internet-Explorer: Search & Replace: Non-regex mode with regex characters like [^ ] fails in IE8 - https://phabricator.wikimedia.org/T23051#1868710 (10Paladox) [09:02:56] 10WikiEditor: side by side preview for non logged in users - https://phabricator.wikimedia.org/T24142#1868722 (10Paladox) [09:04:11] 10WikiEditor, 7Browser-Support-Internet-Explorer: Toolbar : Special character insertion moves cursor to beginning of edit box - https://phabricator.wikimedia.org/T24479#1868724 (10Paladox) [09:06:29] 10WikiEditor: Special characters can't be inserted in subject or edit summary - https://phabricator.wikimedia.org/T25571#1868728 (10Paladox) [09:06:53] 10WikiEditor: There's no easy way to configure the buttons in the enhanced toolbar - https://phabricator.wikimedia.org/T25624#1868737 (10Paladox) [09:07:14] 10WikiEditor: Recognition of local wiki links while inserting links to the URL field - https://phabricator.wikimedia.org/T25789#1868739 (10Paladox) [09:09:34] 10WikiEditor: Custom bold and italic icons for Russian & Ukrainian language - https://phabricator.wikimedia.org/T25914#1868755 (10Paladox) Would the Ukraine follow what was done to Russian by using the same icons as Russian. [09:14:34] 10WikiEditor: Loading ext.wikieditor.toolbar should not initialize it - https://phabricator.wikimedia.org/T36602#1868758 (10Paladox) Is this still a problem. [09:17:55] 10WikiEditor, 7Browser-Support-Internet-Explorer: SkinTemplateNavigation hook breaks create page in IE - https://phabricator.wikimedia.org/T62428#1868768 (10Paladox) Could this be closed as declined since the problem seems to not be happening any more. WikiEditor works for me on IE perfectly without showing a... [11:03:49] 10WikiEditor, 7Browser-Support-Internet-Explorer: SkinTemplateNavigation hook breaks create page in IE - https://phabricator.wikimedia.org/T62428#1868912 (10TheDJ) 5Open>3Invalid a:3TheDJ Closing as invalid as there was no further feedback by the reporter and it could not be reproduced by others. [11:54:05] 10WikiEditor, 6Editing-Department, 7JavaScript: Edit toolbar does not appear (NS_ERROR_FILE_CORRUPTED) - https://phabricator.wikimedia.org/T96043#1868978 (10Paladox) Could this be closed as Declined since I visited the page as it is in the picture and the edit bar shows. [11:56:27] 10WikiEditor, 6Editing-Department, 7JavaScript: Edit toolbar does not appear (NS_ERROR_FILE_CORRUPTED) - https://phabricator.wikimedia.org/T96043#1868980 (10TheDJ) 5Open>3declined a:3TheDJ Can't fix, since it's a problem with FF's localStorage sanity [13:40:28] 10VisualEditor: Wait unlimited on Resume editing button (in a certain context) - https://phabricator.wikimedia.org/T121017#1869148 (10Drongou) You have to stop just when the prompt disappears Works with Chrome 47.0 / Windows 7 Reproductible : always [14:10:07] 10TemplateData, 6Community-Liaison, 7Documentation, 7Easy, 3Google-Code-In-2015: Check documentation for the TemplateData editor for completeness, accuracy, and ease of understanding by adding TemplateData to templates on Wikipedia - https://phabricator.wikimedia.org/T117499#1869194 (10Aklapper) Created... [15:56:08] 10VisualEditor: Trigger-happy options in VE - https://phabricator.wikimedia.org/T121111#1869544 (10IKhitron) 3NEW [16:05:54] 10VisualEditor: Trigger-happy options in VE - https://phabricator.wikimedia.org/T121111#1869576 (10Aklapper) Hi @IKhitron, thanks for taking the time to report this! Could you point to a specific example edit? And I don't understand the task summary line either. :( [16:09:20] (03PS1) 10Esanders: Rename mw.Target to mw.ArticleTarget [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/258158 (https://phabricator.wikimedia.org/T97168) [16:10:20] (03CR) 10Jforrester: "Not a breaking change? There are no instanceof mw.Targets in e.g. MobileFrontend?" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/258158 (https://phabricator.wikimedia.org/T97168) (owner: 10Esanders) [16:14:10] (03CR) 10Jforrester: Rename mw.Target to mw.ArticleTarget (031 comment) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/258158 (https://phabricator.wikimedia.org/T97168) (owner: 10Esanders) [16:14:54] 10VisualEditor: Trigger-happy options in VE - https://phabricator.wikimedia.org/T121111#1869611 (10IKhitron) Sure. [[https://he.wikipedia.org/w/index.php?title=%D7%94%D7%90%D7%A7%D7%93%D7%9E%D7%99%D7%94_%D7%94%D7%A6%D7%91%D7%90%D7%99%D7%AA_%D7%A9%D7%9C_%D7%90%D7%A8%D7%A6%D7%95%D7%AA_%D7%94%D7%91%D7%A8%D7%99%D7%A... [16:14:55] (03CR) 10Esanders: "MobileFrontendArticleTarget inherits from MobileArticleTarget. AFAIK no-one is using mw.Target directly. Also checked gadget documentation" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/258158 (https://phabricator.wikimedia.org/T97168) (owner: 10Esanders) [16:23:23] (03CR) 10Jforrester: [C: 032] Rename mw.Target to mw.ArticleTarget (031 comment) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/258158 (https://phabricator.wikimedia.org/T97168) (owner: 10Esanders) [16:26:22] (03PS2) 10Esanders: Rename mw.Target to mw.ArticleTarget [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/258158 (https://phabricator.wikimedia.org/T97166) [16:27:02] (03CR) 10Jforrester: [C: 032] Rename mw.Target to mw.ArticleTarget [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/258158 (https://phabricator.wikimedia.org/T97166) (owner: 10Esanders) [16:27:36] (03CR) 10Esanders: Rename mw.Target to mw.ArticleTarget (031 comment) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/258158 (https://phabricator.wikimedia.org/T97166) (owner: 10Esanders) [16:30:30] (03Merged) 10jenkins-bot: Rename mw.Target to mw.ArticleTarget [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/258158 (https://phabricator.wikimedia.org/T97166) (owner: 10Esanders) [17:04:08] (03PS2) 10Esanders: [NEVER MERGE] Link suggestion gadget [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/257040 (https://phabricator.wikimedia.org/T119477) [17:08:08] (03PS3) 10Esanders: [NEVER MERGE] Link suggestion gadget [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/257040 (https://phabricator.wikimedia.org/T119477) [17:17:53] (03CR) 10Alex Monk: "Flow will also need to be updated" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/258158 (https://phabricator.wikimedia.org/T97166) (owner: 10Esanders) [17:18:42] 10VisualEditor, 10VisualEditor-MediaWiki, 5Patch-For-Review, 7Technical-Debt, 5WMF-deploy-2015-12-15_(1.27.0-wmf.9): Move code specific to page editing out of ve.init.mw.Target - https://phabricator.wikimedia.org/T97166#1869859 (10Krenair) ```Flow/modules/editor/editors/visualeditor/ext.flow.editors.visu... [17:19:12] Krenair: Gah, RoanKattouw_away is such a hack. [17:19:13] (03PS4) 10Esanders: [NEVER MERGE] Link suggestion gadget [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/257040 (https://phabricator.wikimedia.org/T119477) [17:40:00] 10VisualEditor, 10VisualEditor-MediaWiki, 5Patch-For-Review, 7Technical-Debt, 5WMF-deploy-2015-12-15_(1.27.0-wmf.9): Move code specific to page editing out of ve.init.mw.Target - https://phabricator.wikimedia.org/T97166#1869891 (10Jdforrester-WMF) >>! In T97166#1869859, @Krenair wrote: > ```Flow/modules/... [17:44:12] 10WikiEditor: Loading ext.wikieditor.toolbar should not initialize it - https://phabricator.wikimedia.org/T36602#1869912 (10He7d3r) [17:44:23] edsanders: Are you working on re-creating mw.Target as the parent of mw.ArticleTarget? [17:44:37] I will [17:44:54] edsanders: OK, so we should merge https://gerrit.wikimedia.org/r/258174 first? [17:49:57] 10VisualEditor, 10VisualEditor-MediaWiki, 7Browser-Support-Apple-Safari: On single edit tab wikis, the edit tab always loads VE even if the 'VEE' cookie is 'wikitext' - https://phabricator.wikimedia.org/T121122#1869930 (10Jdforrester-WMF) 3NEW a:3Krenair [17:50:37] are you logged in our out? if in, what is your tab preference set to James_F? [17:51:55] Krenair: In. Tab preference is remember my last. [17:52:09] It's very odd. [17:54:04] James_F, result of mw.user.options.get( 'visualeditor-editor' ) ? [17:54:26] Ah. Hmm. [17:54:30] 'visualeditor'? [17:54:37] The cookie says 'wikitext' but the preference says 'visualeditor', yeah. [17:54:43] Did you get that cookie set while you were logged out? It will be ignored when you log in. [17:54:54] It's being changed when I'm logged in. [17:55:04] yeah, but it will still be ignored [17:55:09] * James_F nods. [17:55:43] Aha. [17:55:48] Worked it out a bit. [17:55:56] Preference = VE, click edit -> VE [17:56:07] Switch to WT, preference = WT [17:56:14] Preference = WT, click edit -> WT [17:56:31] Switch to VE, preference = VE [17:56:41] But then Switch to WT, preference = VE [17:56:50] Second switch doesn't set preference for some reason. [17:57:35] 10VisualEditor: Wait unlimited on Resume editing button (in a certain context) - https://phabricator.wikimedia.org/T121017#1869974 (10Drongou) I mean : The bugs is always reproductible with Chrome 47.0 / Windows 7 [17:57:46] okay, will look at that today, along with the FOUC which I already started working on [17:58:16] Thank you. :-) [17:58:24] Also issues in FF. [17:59:54] 10VisualEditor, 10VisualEditor-MediaWiki, 7Browser-Support-Apple-Safari, 7Browser-Support-Firefox: On single edit tab wikis, switching editors is not always setting the visualeditor-editor option to 'wikitext' in Safari, Firefox - https://phabricator.wikimedia.org/T121122#1869985 (10Jdforrester-WMF) [18:15:17] 10VisualEditor, 10VisualEditor-MediaWiki: On single edit tab wikis, 'undo' links in history when editor will be VE don't work - https://phabricator.wikimedia.org/T121126#1870086 (10Jdforrester-WMF) 3NEW a:3Krenair [18:46:03] (03PS1) 10Jforrester: Update VE core submodule to master (0563302) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/258184 [18:46:05] (03PS1) 10Jforrester: EditingTabDialog: Shorten the copy to make snappier, drop 'Edit' tab name [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/258185 [19:27:17] 10VisualEditor, 6Design-Research: Not clear how to switch to VisualEditor - https://phabricator.wikimedia.org/T121032#1870405 (10aripstra) @Jdlrobson Thanks for the feedback! I had some of the same concerns that you do, and am interested to see what we will find in usability testing. We definitely will be test... [19:34:12] 10VisualEditor: Wait unlimited on Resume editing button (in a certain context) - https://phabricator.wikimedia.org/T121017#1870436 (10Krenair) Just reproduced it on Chrome 46 (on Ubuntu 15.10) Uncaught Error: Offset could not be translated to a DOM element and offset: 21 [19:36:09] (03PS1) 10Jforrester: Let the feedback tool be configured for a remote wiki [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/258199 (https://phabricator.wikimedia.org/T92661) [19:38:48] 10VisualEditor, 10VisualEditor-ContentEditable, 10VisualEditor-MediaWiki: When cursor is in an invalid position, cancelling the save dialog ("Resume") will cause a fatal as it tries to re-insert the cursor in a wrong place - https://phabricator.wikimedia.org/T121017#1870451 (10Jdforrester-WMF) p:5Triage>3... [19:39:45] 10VisualEditor, 10VisualEditor-ContentEditable, 10VisualEditor-MediaWiki: When cursor is in an invalid position, cancelling the save dialog ("Resume") will cause a fatal as it tries to re-insert the cursor in a wrong place - https://phabricator.wikimedia.org/T121017#1867042 (10Jdforrester-WMF) OK, yup. The c... [19:44:27] (03PS2) 10Jforrester: Let the feedback tool be configured for a remote wiki [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/258199 (https://phabricator.wikimedia.org/T92661) [19:45:04] oops [19:45:15] left a debug log call in the SET code [19:46:18] (03CR) 10Legoktm: "Maybe call the setting "feedbackApiUrl" ?" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/258199 (https://phabricator.wikimedia.org/T92661) (owner: 10Jforrester) [19:47:18] Krenair: Does that make it not work, or just very noisy? [19:47:26] noisy [19:47:36] *if* you have a specific debug log group set up [19:48:01] * James_F nods. [19:48:04] legoktm: Sure. [19:48:35] and only logs when someone triggers our pref dialog [19:49:43] Still. [19:50:23] legoktm: Am I meant to configure it with 'https://www.mediawiki.org/w/api.php'? [19:50:31] yes [19:50:34] OK. [19:57:23] 10VisualEditor, 10VisualEditor-MediaWiki: On single edit tab wikis, 'undo' links in history when editor will be VE don't work - https://phabricator.wikimedia.org/T121126#1870497 (10Krenair) Unless/until we want to explicitly support this inside VE itself, this was the sort of thing I had in mind to go on the l... [19:58:00] 10VisualEditor: Cursor repositions itself at the beginning of the article and throws error "TypeError: oldChunks[((oldChunks.length - 1) - change.end)] is undefined" while trying to type something before a an external link - https://phabricator.wikimedia.org/T121139#1870512 (10Ryasmeen) 3NEW [20:06:50] (03PS3) 10Jforrester: Let the feedback tool be configured for a remote wiki [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/258199 (https://phabricator.wikimedia.org/T92661) [20:10:59] (03CR) 10jenkins-bot: [V: 04-1] Let the feedback tool be configured for a remote wiki [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/258199 (https://phabricator.wikimedia.org/T92661) (owner: 10Jforrester) [20:13:05] (03PS4) 10Jforrester: Let the feedback tool be configured for a remote wiki [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/258199 (https://phabricator.wikimedia.org/T92661) [20:13:29] (03CR) 10Jforrester: "Config patch: I0e5545b82" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/258199 (https://phabricator.wikimedia.org/T92661) (owner: 10Jforrester) [20:16:28] 10VisualEditor: Cursor repositions itself at the beginning of the article and throws error "TypeError: oldChunks[((oldChunks.length - 1) - change.end)] is undefined" while trying to type something before a an external link - https://phabricator.wikimedia.org/T121139#1870559 (10Esanders) probably the same as T120975 [20:16:36] 10VisualEditor, 10VisualEditor-ContentEditable, 5Patch-For-Review: TextState#getChangeTransaction throws exception on first change - https://phabricator.wikimedia.org/T120975#1870561 (10Esanders) p:5High>3Unbreak! [20:17:13] (03CR) 10Esanders: [C: 032] Count chunk list bounds more carefully [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/257956 (https://phabricator.wikimedia.org/T120975) (owner: 10Divec) [20:21:00] 10VisualEditor: Cursor repositions itself at the beginning of the article and throws error "TypeError: oldChunks[((oldChunks.length - 1) - change.end)] is undefined" while trying to type something before a an external link - https://phabricator.wikimedia.org/T121139#1870584 (10Esanders) [20:21:20] edsanders: Does that need back-porting? [20:21:31] probably [20:22:15] OK. :-) [20:22:26] (03Merged) 10jenkins-bot: Count chunk list bounds more carefully [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/257956 (https://phabricator.wikimedia.org/T120975) (owner: 10Divec) [20:26:31] 10VisualEditor, 10VisualEditor-ContentEditable, 5Patch-For-Review: TextState#getChangeTransaction throws exception on first change - https://phabricator.wikimedia.org/T120975#1870611 (10Esanders) 5Open>3Resolved [20:26:50] 10VisualEditor, 10VisualEditor-ContentEditable, 5Patch-For-Review: TextState#getChangeTransaction throws exception on first change - https://phabricator.wikimedia.org/T120975#1866092 (10Esanders) [20:27:30] Meh. [20:27:35] Conflicting changes. [20:28:36] 10VisualEditor, 10Graph: [Regression wmf.8] Saving a page after adding a graph/media throws error "TypeError: rect is undefined" - https://phabricator.wikimedia.org/T120699#1870627 (10Ryasmeen) [20:28:58] 10VisualEditor, 10Graph: [Regression wmf.8] Saving a page after adding a graph/media throws error "TypeError: rect is undefined" - https://phabricator.wikimedia.org/T120699#1859506 (10Ryasmeen) This also happens after adding an image to the page and saving it [20:30:23] (03PS1) 10Jforrester: Count chunk list bounds more carefully [VisualEditor/VisualEditor] (wmf/1.27.0-wmf.8) - 10https://gerrit.wikimedia.org/r/258214 (https://phabricator.wikimedia.org/T120975) [20:30:40] (03CR) 10Jforrester: [C: 032] Count chunk list bounds more carefully [VisualEditor/VisualEditor] (wmf/1.27.0-wmf.8) - 10https://gerrit.wikimedia.org/r/258214 (https://phabricator.wikimedia.org/T120975) (owner: 10Jforrester) [20:33:55] hm [20:34:04] I appear to have accidentally made VE able to load in-page on action=history [20:34:18] lol [20:34:20] Ha. [20:34:22] (03Merged) 10jenkins-bot: Count chunk list bounds more carefully [VisualEditor/VisualEditor] (wmf/1.27.0-wmf.8) - 10https://gerrit.wikimedia.org/r/258214 (https://phabricator.wikimedia.org/T120975) (owner: 10Jforrester) [20:34:27] New feature! [20:35:02] it leaves the firstHeading and contentSub [20:35:12] * James_F grins. [20:35:23] Krenair: Need help on the FOUC stuff? [20:35:39] nope, I think I just got it to work [20:36:03] mostly. there's an annoying case involving switching from VE into WT which will require a client-side update of the text [20:36:30] * James_F nods. [20:36:30] no, wait [20:36:32] other way around [20:36:42] because VE loads in-page over the wikitext editor [20:36:56] Yeah. [20:40:48] I think some of the client-side logic I had before wasn't quite right either [20:40:55] (03PS1) 10Jforrester: Update VE core submodule to wmf/1.27.0-wmf.8 HEAD (96ef5ad) [extensions/VisualEditor] (wmf/1.27.0-wmf.8) - 10https://gerrit.wikimedia.org/r/258215 [20:41:35] (03PS2) 10Jforrester: EditingTabDialog: Shorten the copy to make snappier, drop 'Edit' tab name [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/258185 [20:42:19] (03PS2) 10Jforrester: Update VE core submodule to master (601ba8c) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/258184 [20:50:37] James_F, so when you're on the wikitext editor and switch to VE, and your SET preference is remember last editor, we need to change the tab text from Edit Source to Edit, right? [20:51:16] Krenair: Yes. And VV. [20:51:28] Krenair: (But only for logged-in users, for caching?) [20:51:30] VV? [20:51:36] Vice versa, sorry. [20:52:39] James_F, so we need a message for 'Edit'... [20:52:57] vector-ca-edit? [20:53:00] Yeah. [20:53:06] it's from Vector. :/ [20:54:25] 10VisualEditor, 10Graph: [Regression wmf.8] Saving a page after adding any focusable node throws error "TypeError: rect is undefined" - https://phabricator.wikimedia.org/T120699#1870699 (10Ryasmeen) [20:54:44] Krenair: Welcome to MediaWiki. [20:54:59] Krenair: (This is already the case if you look at the PHP code for two edit tabs.) [20:56:51] (03CR) 10Edokter: [C: 04-1] "Patch 2 is even worse. Convert to path, the remove the text and run the SVG through an optimizer." [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/257978 (https://phabricator.wikimedia.org/T119716) (owner: 10Paladox) [20:58:48] actually, where is that defined? [20:58:51] (03CR) 10Paladox: "@Edokter how do I convert to path. Is there any tool that I can use the does this." [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/257978 (https://phabricator.wikimedia.org/T119716) (owner: 10Paladox) [20:59:35] Krenair: We re-use the tab by class rather than set the text now. I think we used to recreate the tab with the text. [21:01:53] 10VisualEditor: In math inspector, when height is limited the editing section (with active cursor) is not visible - https://phabricator.wikimedia.org/T121150#1870718 (10Ryasmeen) 3NEW [21:05:06] (03CR) 10Edokter: "In Inkscape, you can convert any object to paths, which basically turns it into a traced image. I'm not an expert, but you can ask for hel" [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/257978 (https://phabricator.wikimedia.org/T119716) (owner: 10Paladox) [21:08:05] I think I can hack around it [21:09:28] oh, nope [21:11:52] Why do I feel like I've run into this problem twice before [21:12:28] Because you're in a maze of twisty code paths, all alike? [21:13:08] 10VisualEditor, 10VisualEditor-ContentEditable, 5WMF-deploy-2015-12-08_(1.27.0-wmf.8), 5WMF-deploy-2015-12-15_(1.27.0-wmf.9): TextState#getChangeTransaction throws exception on first change - https://phabricator.wikimedia.org/T120975#1870748 (10Jdforrester-WMF) [21:21:12] So I could change Vector to allow me to add data attributes and store in them the text to switch to [21:21:23] But that still won't resolve the issue with other skins [21:21:37] Ugh. [21:29:31] Krenair: Don't adjust Vector. [21:29:54] Krenair: We just use the label and it Works™ as long as you are a WMF wiki. [21:31:39] okay, I have an idea [21:33:20] (03CR) 10Jforrester: [C: 032] Update VE core submodule to wmf/1.27.0-wmf.8 HEAD (96ef5ad) [extensions/VisualEditor] (wmf/1.27.0-wmf.8) - 10https://gerrit.wikimedia.org/r/258215 (owner: 10Jforrester) [21:35:41] quiddity: BTW we just deployed Flow opt-in to cawiki (surprise early deployment because logistics) [21:38:19] (03Merged) 10jenkins-bot: Update VE core submodule to wmf/1.27.0-wmf.8 HEAD (96ef5ad) [extensions/VisualEditor] (wmf/1.27.0-wmf.8) - 10https://gerrit.wikimedia.org/r/258215 (owner: 10Jforrester) [21:38:33] (03CR) 10Esanders: [C: 032] Update VE core submodule to master (601ba8c) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/258184 (owner: 10Jforrester) [21:38:45] Thanks edsanders. [21:39:15] (03PS1) 10Alex Monk: Change tab text on server side [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/258230 (https://phabricator.wikimedia.org/T120970) [21:39:50] (03CR) 10Alex Monk: "Reviewers should be careful about how this behaves for logged out users, for caching reasons." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/258230 (https://phabricator.wikimedia.org/T120970) (owner: 10Alex Monk) [21:41:13] (03CR) 10Esanders: [C: 032] MWSaveDialog: De-flag the 'return to save' button on diffs [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/257742 (owner: 10Jforrester) [21:41:33] (03PS2) 10Alex Monk: Change tab text on server side [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/258230 (https://phabricator.wikimedia.org/T120970) [21:45:25] (03Merged) 10jenkins-bot: Update VE core submodule to master (601ba8c) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/258184 (owner: 10Jforrester) [21:45:30] (03CR) 10jenkins-bot: [V: 04-1] MWSaveDialog: De-flag the 'return to save' button on diffs [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/257742 (owner: 10Jforrester) [21:46:01] (03CR) 10Jforrester: [C: 032] "…" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/257742 (owner: 10Jforrester) [21:51:03] (03Merged) 10jenkins-bot: MWSaveDialog: De-flag the 'return to save' button on diffs [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/257742 (owner: 10Jforrester) [21:51:48] legoktm: Re-CR on https://gerrit.wikimedia.org/r/#/c/258199/ appreciated. :-) [21:53:10] (03PS5) 10Esanders: [NEVER MERGE] Link suggestion gadget [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/257040 (https://phabricator.wikimedia.org/T119477) [21:53:23] edsanders: Love that title. [21:54:17] well - probably not in this repo [21:55:00] (03CR) 10Legoktm: [C: 032] Let the feedback tool be configured for a remote wiki [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/258199 (https://phabricator.wikimedia.org/T92661) (owner: 10Jforrester) [21:59:06] * James_F nods. [22:04:25] (03Merged) 10jenkins-bot: Let the feedback tool be configured for a remote wiki [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/258199 (https://phabricator.wikimedia.org/T92661) (owner: 10Jforrester) [22:05:47] 10VisualEditor: Error "ve.dm.Document.getBranchNodeFromOffset(): offset -1 is out of bounds" appears and VE hangs after deleting any focusable node which is followed by an empty reflist - https://phabricator.wikimedia.org/T121156#1870894 (10Ryasmeen) 3NEW [22:13:55] (03PS2) 10Jforrester: MWTemplatePage: Show a link to the template even when there's a description [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/257443 (https://phabricator.wikimedia.org/T51772) [22:14:07] James_F, have you seen Trevor? [22:14:27] nevermind, found him [22:15:13] (03CR) 10Jforrester: "Not totally sold on this wording, proposed by Quiddity as a simplification. Thoughts?" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/258185 (owner: 10Jforrester) [22:27:16] (03CR) 10Quiddity: "Fwiw, I proposed the wording change because it's currently not very clear (e.g. in http://i.imgur.com/Q3kulDp.png ) that:" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/258185 (owner: 10Jforrester) [22:31:28] 10VisualEditor, 10VisualEditor-ContentEditable, 5WMF-deploy-2015-12-08_(1.27.0-wmf.8), 5WMF-deploy-2015-12-15_(1.27.0-wmf.9): TextState#getChangeTransaction throws exception on first change - https://phabricator.wikimedia.org/T120975#1870981 (10Jdforrester-WMF) [22:42:31] (03PS1) 10Jforrester: Drop support for adding prefix/appendix labels to edit tabs/links [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/258357 [22:42:33] (03PS1) 10Jforrester: Show the welcome dialog by default to new users [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/258358 [22:44:33] 10VisualEditor, 10VisualEditor-MediaWiki: The (Ctrl+Alt+S) keyboard shortcut opens the Save dialog but should also trigger save when in it - https://phabricator.wikimedia.org/T76161#1871021 (10Krenair) 5Open>3Resolved WFM in Chrome. Can you open a separate bug? [22:45:15] ^ that bug has been on my maniphest home page for a few days, rather annoying [22:45:33] (03CR) 10jenkins-bot: [V: 04-1] Show the welcome dialog by default to new users [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/258358 (owner: 10Jforrester) [22:46:10] How do you have your "maniphest home page" set up? Maybe tweak that? [22:46:37] (03CR) 10jenkins-bot: [V: 04-1] Drop support for adding prefix/appendix labels to edit tabs/links [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/258357 (owner: 10Jforrester) [22:48:21] James_F, it's just the default query showing at https://phabricator.wikimedia.org/maniphest/ [22:48:37] I have mine set to show assigned tasks without patch-for-review [22:49:10] * James_F nods. [22:54:37] 10VisualEditor: Error "this.model is null" appears upon typing inside math inspector - https://phabricator.wikimedia.org/T121162#1871068 (10Ryasmeen) 3NEW [22:58:02] 10VisualEditor: The text box for formula editing does not appear when you first time open math inspector in full size view - https://phabricator.wikimedia.org/T121164#1871084 (10Ryasmeen) 3NEW [23:01:45] (03CR) 10Jforrester: "recheck" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/258357 (owner: 10Jforrester) [23:15:09] (03PS1) 10Alex Monk: Single edit tab: Fall back to the wikitext editor when certain parameters show up [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/258370 (https://phabricator.wikimedia.org/T121126) [23:18:35] 149155 Undefined variable: wmgVisualEditorConsolidateFeedback in /srv/mediawiki/wmf-config/CommonSettings.php on line 2033 [23:18:36] 1171 Notice: Undefined variable: wmgVisualEditorUseSingleEditTab in /srv/mediawiki/wmf-config/CommonSettings.php on line 1994 [23:18:38] oops [23:18:44] Or maybe those are old? [23:18:49] The numbers aren't going up [23:21:17] Yeah, well. [23:21:50] James_F, who wrote that Math bug? [23:21:54] Volunteer? [23:22:25] edsanders: Task written by Timo, code written by Moritz, yeah. [23:23:03] it needs to be fixed properly asap or reverted [23:23:47] +2 rights come with responsibility [23:24:01] It wasn't merged by him, it was merged by Marko I think. [23:24:22] Didn't we spot that this was broken in beta on like Monday? Or last week? [23:24:52] I filed a bug a few days ago [23:26:18] RoanKattouw: There were about five things broken. [23:26:28] RoanKattouw: No-one could say which bits were whose fault. [23:26:58] I think it's a duplicate of T120383 [23:26:59] (Note that all Beta Cluster servers have RESTbase, so this isn't broken there.) [23:27:39] edsanders: I'm going to re-work T120383 into a UBN of "Math is broken without RESTbase". [23:28:34] James_F: also, mathoid ;) [23:28:42] Sure. [23:28:49] and latex [23:42:07] James_F: Parsoid/VE bug? https://office.wikimedia.org/w/index.php?title=Holiday_Party_2015&type=revision&diff=164187&oldid=164171 [23:51:28] RoanKattouw: Malformed wikitext bug. [23:52:06] Malformed enough to confuse Parsoid, but only over the course of 2 edits, and not malformed enough to break rendering? [23:52:42] RoanKattouw: Tidy is amazing.