[00:15:42] (03CR) 10Jforrester: "Maybe we should invert the logic? If anything other than known-good params are in the GET, fail to the wikitext editor?" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/258370 (https://phabricator.wikimedia.org/T121126) (owner: 10Alex Monk) [00:19:22] RoanKattouw, ^ thoughts? [00:19:55] Hmm maybe [00:20:44] I'm not completely convinced [00:20:54] I think it might be easier to enumerate unsafe params than safe ones [00:21:21] Perhaps. [00:21:39] Krenair: Maybe explicitly list the ones we think are working, and have a task for each of the ones that aren't? [00:21:52] (We already have a bunch of tasks for these.) [01:24:55] 10VisualEditor, 10VisualEditor-MediaWiki: The keyboard shortcut doesn't trigger save in the Save dialog - https://phabricator.wikimedia.org/T121183#1871853 (10APerson) 3NEW [01:25:33] 10VisualEditor, 10VisualEditor-MediaWiki: The keyboard shortcut doesn't trigger save in the Save dialog - https://phabricator.wikimedia.org/T121183#1871862 (10APerson) [01:28:09] (03CR) 10Esanders: "Flow still uses sa.Target, although I think it abusively calls some mw target methods as if they were static functions, so we should check" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/258158 (https://phabricator.wikimedia.org/T97166) (owner: 10Esanders) [01:28:37] Whoa, I just had a weird bug in VE. [01:28:43] Go on.. [01:29:11] In between hitting edit and saving, I previewed my changes, and it showed me removing a table that was never in the page in the first place when I started editing. [01:29:51] When I saved, everything looked fine, and I viewed the diff, and it showed only my changes. [01:30:20] The table was added to the article after I hit edit, but before I hit save. [01:30:35] In the end, VE did the right thing, but the preview I got was quite messed up. [01:31:51] I guess I'll file a bug for it. [01:32:46] (03CR) 10Alex Monk: "Yes, see task" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/258158 (https://phabricator.wikimedia.org/T97166) (owner: 10Esanders) [01:33:52] Deskana, so the version on the left was not the one you started with? [01:34:16] Krenair: Correct, it was not. [01:34:22] from the edit history, was there another person editing around the same time as you? [01:34:41] Krenair: Yes, there was. The person added the table that VE was showing I was removing. [01:34:50] (Just found that out now) [01:35:12] It didn't actually remove the table, which is good. [01:36:54] In the event of edit conflicts, I wonder if we're (loosely 'we' - restbase etc. are involved here) not be attempting to merge [01:37:12] When actually saving, MW attempts to do this in the event of a conflict [01:37:32] the save path is using the normal MW logic, including edit conflict detection / resolution [01:37:54] Or perhaps the preview is using the latest revision rather than the one I started with. [01:38:03] I know so little about the internals here that I have no idea. [01:38:10] by 'preview' you mean the diff, right? [01:38:22] Yes, sorry. The diff that's shown if I click "Show preview" in the save dialogue. [01:38:46] gwicke is right of course [01:39:11] we might not even be detecting conflicts when you go to preview changes [01:39:30] or just using the latest version of the page [01:39:45] which may or may not be the behaviour we want [01:40:12] have to remember that you can go back and deliberately edit old revisions, and then the diff *should* be against the latest revision, I think [01:40:41] yeah, that's tricky from an UI perspective [01:41:12] so maybe it should be against the latest revision *at the time you start editing*, or something [01:41:56] Deskana, basically it's indeed weird and probably complicated. can you file a task in phabricator please? [01:42:03] Krenair: Will do. [01:42:08] thanks [01:43:00] Krenair: your idea to always diff against the latest at time of edit start sounds good to me as well [01:51:05] Krenair: Just spoke about this with Deskana IRL; I believe VE is doing the same thing as the wikitext editor does, but yeah, it could be confusing in some edge cases. When we re-work diffs in MW changing between these modes could be a thing. [01:52:05] yeah, I suppose it is. I haven't actually tested anything, or looked at any related code [01:52:35] It sounds like the diffs might be doing this whenever there's an edit conflict that's automatically resolvable [01:52:49] maybe even on any edit conflict [01:53:00] Yeah. [01:54:33] 10VisualEditor, 10MediaWiki-Page-editing: Preview showed me removing content that I'd never added - https://phabricator.wikimedia.org/T121185#1871897 (10Deskana) 3NEW [01:54:38] ^ That should cover it [01:54:53] * James_F nods. [01:55:16] I tried to reproduce it but I couldn't, but James_F said that was probably because I was logged in as me both times [01:55:16] 10VisualEditor, 10MediaWiki-Page-editing, 7Design: Preview showed me removing content that I'd never added - https://phabricator.wikimedia.org/T121185#1871904 (10Jdforrester-WMF) p:5Triage>3Low [01:55:40] 10VisualEditor, 10VisualEditor-MediaWiki, 5Patch-For-Review: On single edit tab wikis, 'undo' links in history when editor will be VE don't work - https://phabricator.wikimedia.org/T121126#1870086 (10Jdforrester-WMF) [01:55:45] yeah, there's a bunch of checks MW does to suppress edit conflicts and save anyway [01:55:50] 10VisualEditor, 10VisualEditor-MediaWiki, 7Browser-Support-Apple-Safari, 7Browser-Support-Firefox: On single edit tab wikis, switching editors is not always setting the visualeditor-editor option to 'wikitext' in Safari, Firefox - https://phabricator.wikimedia.org/T121122#1869930 (10Jdforrester-WMF) [01:56:06] one of which involves checking who made the last edit against the current logged in user [01:56:30] 10VisualEditor, 10VisualEditor-MediaWiki, 5Patch-For-Review: On single edit tab wikis, if the user has a 've always' preference, there's a FOUC from 'edit' to 'edit source' on non-VE namespaces - https://phabricator.wikimedia.org/T120970#1865929 (10Jdforrester-WMF) [01:57:10] (Go go MediaWiki.) [01:57:25] Well, hey, at least when I saved it actually did the right thing. Could be worse. [01:57:42] :-) [01:57:46] true [01:58:13] Krenair: https://phabricator.wikimedia.org/T121122 doesn't really give you enough information to go on, does it? :-( [01:59:36] I think something you said earlier in the hangout implied that your steps to reproduce weren't fully reliable [01:59:41] (steps on IRC) [02:00:48] Dec 10 20:37:50 [17:55:56] Preference = VE, click edit -> VE [02:00:48] Dec 10 20:37:50 [17:56:08] Switch to WT, preference = WT [02:00:48] Dec 10 20:37:50 [17:56:14] Preference = WT, click edit -> WT [02:00:48] Dec 10 20:37:50 [17:56:32] Switch to VE, preference = VE [02:00:49] Dec 10 20:37:50 [17:56:42] But then Switch to WT, preference = VE [02:00:49] Dec 10 20:37:50 [17:56:50] Second switch doesn't set preference for some reason. [02:01:17] It's the second switch that seems to be when it doesn't work. [02:01:22] But the first time does? [02:05:23] 10VisualEditor, 10MediaWiki-Page-editing, 7Design: Preview showed me removing content that I'd never added - https://phabricator.wikimedia.org/T121185#1871923 (10matmarex) I think this happens for autoresolved edit conflicts with wikitext editor, too. [02:06:51] 10VisualEditor, 10MediaWiki-Page-editing, 7Design: Preview showed me removing content that I'd never added - https://phabricator.wikimedia.org/T121185#1871933 (10Jdforrester-WMF) Yeah, I'm pretty sure this is "VE and WT work the same, but it's odd…". [02:13:42] James_F, did you check that it's always the second time? [02:28:04] Krenair: No. [03:05:51] 10VisualEditor: Switching to edit source giving blank page when I have option "Show me both editors" - https://phabricator.wikimedia.org/T120987#1872067 (10Jdforrester-WMF) I think this was fixed alongside {T120969}. [03:06:11] 10VisualEditor, 10VisualEditor-MediaWiki, 5WMF-deploy-2015-12-15_(1.27.0-wmf.9): Switching to edit source giving blank page when I have option "Show me both editors" - https://phabricator.wikimedia.org/T120987#1872069 (10Jdforrester-WMF) 5Open>3Resolved p:5Triage>3High a:3Krenair [03:06:20] 10VisualEditor, 10VisualEditor-MediaWiki, 5WMF-deploy-2015-12-15_(1.27.0-wmf.9): Switching to edit source giving blank page when I have option "Show me both editors" - https://phabricator.wikimedia.org/T120987#1866462 (10Jdforrester-WMF) [03:06:25] 10VisualEditor, 10VisualEditor-MediaWiki, 7Design, 7Epic, 5WMF-deploy-2015-12-15_(1.27.0-wmf.9): Change VE integration to only use one edit tab, to avoid user choice paralysis - https://phabricator.wikimedia.org/T58337#1872075 (10Jdforrester-WMF) [03:27:41] 10VisualEditor, 10VisualEditor-MediaWiki: On single edit tab wikis, switching from VE to WT does not always set the visualeditor-editor option - https://phabricator.wikimedia.org/T121122#1872096 (10Jdforrester-WMF) [03:28:21] 10VisualEditor, 10VisualEditor-MediaWiki: On single edit tab wikis, clicking on a section edit link always gives the visual editor regardless of visualeditor-editor setting - https://phabricator.wikimedia.org/T121189#1872099 (10Jdforrester-WMF) 3NEW a:3Krenair [03:28:44] 10VisualEditor, 10VisualEditor-MediaWiki: On single edit tab wikis, clicking on a section edit link gives an editor whose switching works oddly - https://phabricator.wikimedia.org/T120966#1865848 (10Jdforrester-WMF) [03:28:47] 10VisualEditor, 10VisualEditor-MediaWiki: On single edit tab wikis, clicking on a section edit link always gives the visual editor regardless of visualeditor-editor setting - https://phabricator.wikimedia.org/T121189#1872099 (10Jdforrester-WMF) [03:29:30] (03CR) 10Jforrester: [C: 032] Single edit tab: Fall back to the wikitext editor when certain parameters show up [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/258370 (https://phabricator.wikimedia.org/T121126) (owner: 10Alex Monk) [03:29:41] 10VisualEditor, 10VisualEditor-MediaWiki: On single edit tab wikis, 'undo' links in history when editor will be VE don't work - https://phabricator.wikimedia.org/T121126#1872117 (10Jdforrester-WMF) 5Open>3Resolved [03:29:44] 10VisualEditor, 10VisualEditor-MediaWiki, 7Design, 7Epic, 5WMF-deploy-2015-12-15_(1.27.0-wmf.9): Change VE integration to only use one edit tab, to avoid user choice paralysis - https://phabricator.wikimedia.org/T58337#1872119 (10Jdforrester-WMF) [03:32:08] (03CR) 10Jforrester: "recheck" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/258357 (owner: 10Jforrester) [03:32:43] (03Merged) 10jenkins-bot: Single edit tab: Fall back to the wikitext editor when certain parameters show up [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/258370 (https://phabricator.wikimedia.org/T121126) (owner: 10Alex Monk) [06:33:11] 10VisualEditor, 10VisualEditor-MediaWiki, 7Accessibility, 7Browser-Support-Firefox: The keyboard shortcut doesn't trigger save in the Save dialog - https://phabricator.wikimedia.org/T121183#1872254 (10Aklapper) [07:44:59] 10WikiEditor, 7Browser-Support-Internet-Explorer: "Search and replace" for IE does not correctly replace words but changes others - https://phabricator.wikimedia.org/T44073#1872316 (10Aklapper) Is this still an issue in 2015? If so, which IE versions are (not) affected? [07:47:43] (03CR) 10Aklapper: [C: 04-1] "$:andre\> git review -d 184301" [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/184301 (owner: 10Gerrit Patch Uploader) [07:48:33] 10WikiEditor, 7Easy, 5Patch-For-Review: Patch Watch - existing gerrit patches that aren't associated with any specific task - https://phabricator.wikimedia.org/T86708#1872319 (10Aklapper) 5Open>3declined a:3Aklapper All listed patches are either merged or at least have received a Code Review. Closing... [08:17:18] 10WikiEditor: Loading ext.wikieditor.toolbar should not initialize it - https://phabricator.wikimedia.org/T36602#1872362 (10GOIII) Is the thing with what is selected in a User's preferences for Editing - specifically which toolbar to use by default? //Apparently//, this.... - [X] Show edit toolbar - [X] Enabl... [09:23:03] 10VisualEditor, 10Math, 5Patch-For-Review: Make it possible for users to use a smaller math dialog with fewer components so they can see more of the underlying page - https://phabricator.wikimedia.org/T120382#1872469 (10Physikerwelt) I think, we should not extend the number of configuration options, since th... [09:45:28] hi [09:45:54] is it a new feature or bug, that gallery during after editing is displayed as as one column? [10:47:18] (03PS6) 10Gerrit Patch Uploader: Use background-image instead of for spinner [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/184301 [10:47:21] (03CR) 10Gerrit Patch Uploader: "This commit was uploaded using the Gerrit Patch Uploader [1]." [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/184301 (owner: 10Gerrit Patch Uploader) [10:47:49] (03CR) 10Fomafix: "rebased" [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/184301 (owner: 10Gerrit Patch Uploader) [12:02:07] 10WikiEditor, 10MediaWiki-ResourceLoader, 10MediaWiki-extensions-SemanticForms: Uncaught ReferenceError: jQuery is not defined with action=formedit on MW 1.26 - https://phabricator.wikimedia.org/T121221#1872861 (10saper) 3NEW [12:11:33] 10WikiEditor, 10MediaWiki-ResourceLoader, 10MediaWiki-extensions-SemanticForms: Uncaught ReferenceError: jQuery is not defined with action=formedit on MW 1.26 - https://phabricator.wikimedia.org/T121221#1872896 (10saper) The site run Semantic MediaWiki 2.3, Semantic Forms 3.3.2, Semantic Result Formats 2.3 l... [12:41:44] 10Cite, 5WMF-deploy-2015-12-08_(1.27.0-wmf.8): Duplicate refs inside don't cause a citation error - https://phabricator.wikimedia.org/T116377#1872975 (10IKhitron) Sorry, @matmarex, does not work in all the cases. Try ``` jkghjkgjghjgkgk {{#tag:references|jkhkhk (03PS6) 10Esanders: [NEVER MERGE] Link suggestion gadget [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/257040 (https://phabricator.wikimedia.org/T119477) [13:12:59] (03CR) 10jenkins-bot: [V: 04-1] [NEVER MERGE] Link suggestion gadget [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/257040 (https://phabricator.wikimedia.org/T119477) (owner: 10Esanders) [13:34:04] 10VisualEditor, 10VisualEditor-MediaWiki: On single edit tab wikis, clicking on a section edit link gives an editor whose switching works oddly - https://phabricator.wikimedia.org/T120966#1873119 (10Krenair) a:3Krenair [15:02:03] (03PS1) 10Esanders: [BREAKING CHANGE] Create ve.init.mw.Target base class [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/258452 (https://phabricator.wikimedia.org/T97166) [15:13:06] (03CR) 10Esanders: "AFAICT this only breaks MF which is fixed here: I04e0085e6bd" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/258452 (https://phabricator.wikimedia.org/T97166) (owner: 10Esanders) [15:16:33] 10VisualEditor, 10VisualEditor-MediaWiki, 5Patch-For-Review, 7Technical-Debt, 5WMF-deploy-2015-12-15_(1.27.0-wmf.9): Move code specific to page editing out of ve.init.mw.Target - https://phabricator.wikimedia.org/T97166#1873232 (10Krenair) Would this be a blocker of T48580? [15:27:29] (03CR) 10Alex Monk: [BREAKING CHANGE] Create ve.init.mw.Target base class (031 comment) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/258452 (https://phabricator.wikimedia.org/T97166) (owner: 10Esanders) [15:30:39] (03CR) 10Alex Monk: [BREAKING CHANGE] Create ve.init.mw.Target base class (031 comment) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/258452 (https://phabricator.wikimedia.org/T97166) (owner: 10Esanders) [15:33:27] (03CR) 10Alex Monk: [BREAKING CHANGE] Create ve.init.mw.Target base class (031 comment) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/258452 (https://phabricator.wikimedia.org/T97166) (owner: 10Esanders) [15:44:41] 10Citoid: Many language wiki templates (pl, it, en) don't accept xx-XX style language codes - https://phabricator.wikimedia.org/T115326#1873277 (10AdHuikeshoven) nl.wp doesn't recognize xx-XX languages codes like nl-NL, the language templates accept only two letter codes (sometimes three letter codes) [15:49:45] (03CR) 10Esanders: [BREAKING CHANGE] Create ve.init.mw.Target base class (031 comment) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/258452 (https://phabricator.wikimedia.org/T97166) (owner: 10Esanders) [15:49:51] (03PS2) 10Esanders: [BREAKING CHANGE] Create ve.init.mw.Target base class [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/258452 (https://phabricator.wikimedia.org/T97166) [16:18:22] (03PS1) 10Esanders: [BREAKING CHANGE] ve.init.Target: Upstream the action toolbar from sa/mw desktop targets [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/258468 [16:20:42] (03CR) 10Jforrester: [C: 031] [BREAKING CHANGE] Create ve.init.mw.Target base class (031 comment) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/258452 (https://phabricator.wikimedia.org/T97166) (owner: 10Esanders) [16:29:57] can I stop ResourceLoaders from catching client side errors? [16:42:05] (03PS3) 10Esanders: [BREAKING CHANGE] Create ve.init.mw.Target base class [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/258452 (https://phabricator.wikimedia.org/T97166) [16:42:07] (03PS1) 10Esanders: DesktopArticleTarget: Fix signature of editNotices [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/258470 [16:43:01] (03CR) 10Jforrester: [C: 032] DesktopArticleTarget: Fix signature of editNotices [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/258470 (owner: 10Esanders) [16:43:20] edsanders: See my comment on https://gerrit.wikimedia.org/r/258452 ? [16:46:47] (03CR) 10Esanders: [BREAKING CHANGE] Create ve.init.mw.Target base class (031 comment) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/258452 (https://phabricator.wikimedia.org/T97166) (owner: 10Esanders) [16:47:13] (03PS1) 10Esanders: Use upstreamed actionGroups functionality [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/258471 [16:48:09] edsanders: https://gerrit.wikimedia.org/r/#/c/258468/ is a breaking change for Flow, right? [16:49:09] not actually, because Flow inherits from sa.Desktop [16:49:41] (03Merged) 10jenkins-bot: DesktopArticleTarget: Fix signature of editNotices [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/258470 (owner: 10Esanders) [16:49:43] Ah, of course. Fun. [16:49:50] (03CR) 10Jforrester: [C: 032] [BREAKING CHANGE] ve.init.Target: Upstream the action toolbar from sa/mw desktop targets [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/258468 (owner: 10Esanders) [16:54:07] (03PS2) 10Esanders: [BREAKING CHANGE] ve.init.Target: Upstream the action toolbar from sa/mw desktop targets [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/258468 [16:54:14] Ha. [16:54:47] edsanders: Other than the class, ve.init.sa.DesktopTarget.js is now empty? [16:55:15] Maybe we should move the src/init/sa code into demos/? [16:55:37] That'd totally break Flow, of course. For later. [17:02:49] (03CR) 10Jforrester: [C: 032] [BREAKING CHANGE] ve.init.Target: Upstream the action toolbar from sa/mw desktop targets [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/258468 (owner: 10Esanders) [17:08:24] (03Merged) 10jenkins-bot: [BREAKING CHANGE] ve.init.Target: Upstream the action toolbar from sa/mw desktop targets [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/258468 (owner: 10Esanders) [17:08:36] edsanders|away: Doing an update. [17:21:39] 10VisualEditor, 10VisualEditor-MediaWiki: Provide a GET URL option on action=edit to force loading the wikitext editor, not the visual editor, regardless of preference - https://phabricator.wikimedia.org/T121242#1873458 (10Jdforrester-WMF) 3NEW [17:25:22] (03CR) 10DLynch: [C: 032] [DEPRECATING CHANGE] Rename link inspector tools [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/257387 (owner: 10Esanders) [17:29:15] (03Merged) 10jenkins-bot: [DEPRECATING CHANGE] Rename link inspector tools [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/257387 (owner: 10Esanders) [17:29:37] 10VisualEditor, 10VisualEditor-EditingTools, 10VisualEditor-MediaWiki-References: VisualEditor: Support editing citations defined within a template - https://phabricator.wikimedia.org/T52896#1873497 (10John_Broughton) Why isn't this given a higher priority, and/or assigned to someone? This issue affects ever... [17:45:11] 10VisualEditor, 10VisualEditor-CopyPaste, 10VisualEditor-Tables: Automatically give pasted tables class="wikitable" in VE-MW - https://phabricator.wikimedia.org/T85577#1873588 (10Ckoerner) I just got bit by this while helping some folks copy over existing information from a Word document. Perhaps a solutio... [18:16:02] edsanders: No tool rename patch for Math? wikiheiro? [18:20:20] 10VisualEditor, 10VisualEditor-MediaWiki, 5Patch-For-Review, 7Technical-Debt, 5WMF-deploy-2015-12-15_(1.27.0-wmf.9): Move code specific to page editing out of ve.init.mw.Target - https://phabricator.wikimedia.org/T97166#1873670 (10Jdforrester-WMF) [18:20:23] 10VisualEditor-MediaWiki-Plugins, 10MediaWiki-extensions-ProofreadPage, 6Wikisource, 7Community-Wishlist-Survey: Create a VisualEditor plugin to integrate with ProofreadPage - https://phabricator.wikimedia.org/T48580#1873669 (10Jdforrester-WMF) [18:20:44] 10VisualEditor-MediaWiki-Plugins, 10MediaWiki-extensions-ProofreadPage, 6Wikisource, 7Community-Wishlist-Survey: Create a VisualEditor plugin to integrate with ProofreadPage - https://phabricator.wikimedia.org/T48580#493794 (10Jdforrester-WMF) [18:20:46] 10VisualEditor, 10VisualEditor-MediaWiki, 7Technical-Debt, 5WMF-deploy-2015-12-15_(1.27.0-wmf.9): Move code specific to page editing out of ve.init.mw.Target - https://phabricator.wikimedia.org/T97166#1873671 (10Jdforrester-WMF) 5Open>3Resolved a:3Esanders [18:29:22] edsanders, Krenair, Thalia|away, Kemayo etc.: https://etherpad.wikimedia.org/p/showcase for what you want to 'demo'. I put myself down as demo-ing single edit tab, but happy for Alex to do so if his computer is up to it. [18:30:04] was going to do the Math one after Thal's patch [18:30:09] thought I did wikihiero [18:30:13] there are aliases though [18:31:30] James_F, my computer was not happy during standup today so I switched to audio only [18:31:31] edsanders: I only merged Score/Graph/Citoid. [18:31:38] I doubt it could handle screen sharing [18:31:40] Krenair: Yeah. What's it like with BlueJeans? [18:31:45] Krenair: :-( OK, I'll do it. [18:31:49] I don't think I can run BlueJeans. [18:31:56] Boo. [18:32:02] Or was it WebE [18:32:04] WebEx [18:32:18] Krenair: IME BlueJeans seems to use more resources than Hangouts, so… [18:32:24] ah [18:32:26] yeah [18:35:11] bluejeans can't possibly have even higher requirements than hangouts. :o [18:41:22] 10VisualEditor, 10VisualEditor-ContentEditable, 7Browser-Support-Firefox: Uncommitted Korean IME candidate text ignored when user presses enter, causing CE/DM desync in Firefox - https://phabricator.wikimedia.org/T120156#1873760 (10Jdforrester-WMF) Firefox (where it doesn't work): ``` lang=json [ {"imeIdent... [18:43:27] 10VisualEditor, 10VisualEditor-ContentLanguage, 10MediaWiki-extensions-UniversalLanguageSelector, 7Epic, and 2 others: Make ULS input methods work in content editable divs of VisualEditor - https://phabricator.wikimedia.org/T51569#1873767 (10Jdforrester-WMF) [18:43:40] 10VisualEditor, 10VisualEditor-ContentLanguage, 10MediaWiki-extensions-UniversalLanguageSelector, 7Epic, and 3 others: Make ULS input methods work in content editable divs of VisualEditor - https://phabricator.wikimedia.org/T51569#548331 (10Jdforrester-WMF) [18:43:53] 10VisualEditor, 10VisualEditor-ContentLanguage, 10MediaWiki-extensions-UniversalLanguageSelector, 7Epic, and 2 others: Make ULS input methods work in content editable divs of VisualEditor - https://phabricator.wikimedia.org/T51569#548331 (10Jdforrester-WMF) [18:44:16] MatmaRex: And yet. [18:45:29] 10VisualEditor, 10VisualEditor-MediaWiki: Provide a GET URL option on action=edit to force loading the wikitext editor, not the visual editor, regardless of preference - https://phabricator.wikimedia.org/T121242#1873785 (10Krenair) Don't we already have this with stuff like editintro/preload etc.? [18:45:31] James_F, also, vesection vs. section [18:58:06] 10VisualEditor, 10VisualEditor-MediaWiki: Provide a GET URL option on action=edit to force loading the wikitext editor, not the visual editor, regardless of preference - https://phabricator.wikimedia.org/T121242#1873892 (10Jdforrester-PERSONAL) >>! In T121242#1873785, @Krenair wrote: > Don't we already have th... [18:58:36] Krenair: Eventually we're going to kill vesection= and veaction=, though? When we have "finished" the integration and everything is sublimely natural? [19:00:00] 10VisualEditor, 10VisualEditor-MediaWiki: Provide a GET URL option on action=edit to force loading the wikitext editor, not the visual editor, regardless of preference - https://phabricator.wikimedia.org/T121242#1873896 (10Jdforrester-WMF) Oh, oops, that was from the wrong account. :-) [19:00:06] 10VisualEditor, 10VisualEditor-MediaWiki: Provide a GET URL option on action=edit to force loading the wikitext editor, not the visual editor, regardless of preference - https://phabricator.wikimedia.org/T121242#1873897 (10Jdforrester-WMF) [19:01:22] 10VisualEditor, 10VisualEditor-MediaWiki: Provide a GET URL option on action=edit to force loading the wikitext editor, not the visual editor, regardless of preference - https://phabricator.wikimedia.org/T121242#1873906 (10Jdforrester-WMF) p:5Triage>3Normal [19:03:08] James_F, demo the Citoid convert button? [19:03:19] edsanders: Maybe? [19:03:30] edsanders: We're going to be pressed for time if we have too many. [19:03:33] * James_F shrugs. [19:03:42] I'll do a 30s demo on en.wiki... [19:04:42] or wikitext paste (an infobox?) [19:04:59] 10VisualEditor, 10VisualEditor-MediaWiki: On single edit tab wikis, if your browser is non-JS but your settings say VE you get a blank edit page and no way to fix it - https://phabricator.wikimedia.org/T121257#1873918 (10Jdforrester-WMF) 3NEW a:3Krenair [19:31:12] 10VisualEditor, 10VisualEditor-ContentEditable: Error "ve.dm.Document.getBranchNodeFromOffset(): offset -1 is out of bounds" appears and VE hangs after deleting any focusable node which is followed by an empty reflist - https://phabricator.wikimedia.org/T121156#1874049 (10Jdforrester-WMF) p:5Triage>3High [19:31:32] 10VisualEditor, 10VisualEditor-MediaWiki: On single edit tab wikis, if your browser is non-JS but your settings say VE you get a blank edit page and no way to fix it - https://phabricator.wikimedia.org/T121257#1874054 (10Jdforrester-WMF) [19:34:11] 10VisualEditor, 10MediaWiki-extensions-RelatedArticles, 3Reading Web Sprint 62 - DJ-Jazzy-Jeff-and-the-Fresh-Sprints: RelatedArticles disappears during edit process when using VisualEditor - https://phabricator.wikimedia.org/T120443#1874058 (10Jdforrester-WMF) Is this now fixed? Everything looks good in test... [19:35:17] 10VisualEditor, 6Design-Research: Not clear how to switch to VisualEditor - https://phabricator.wikimedia.org/T121032#1874064 (10Jdforrester-WMF) I'm going to merge this into the task actually making this interface first; sorry for the confusion. [19:35:23] 10VisualEditor, 6Design-Research: Not clear how to switch to VisualEditor - https://phabricator.wikimedia.org/T121032#1874065 (10Jdforrester-WMF) [19:35:27] 10VisualEditor, 10VisualEditor-MediaWiki, 7Design, 7Epic, 5WMF-deploy-2015-12-15_(1.27.0-wmf.9): Change VE integration to only use one edit tab, to avoid user choice paralysis - https://phabricator.wikimedia.org/T58337#1874066 (10Jdforrester-WMF) [19:35:48] 10VisualEditor, 15User-JAufrecht: Run Analytics/VE SLU - https://phabricator.wikimedia.org/T120879#1863923 (10Jdforrester-WMF) [19:53:44] mvolz (and others): any reaso I can't use citoid on http://dx.doi.org/10.1016/j.placenta.2006.01.010 but I can use it for the doi? [19:54:36] Josve05a: Don't know if mvolz is around; not sure I can answer usefully. :-( [19:55:06] James_F: ok, but can you check so it just isn't me pasting it wrong or something? [19:56:42] Josve05a: http://citoid.wikimedia.org/api?format=mediawiki&search=http%3A%2F%2Fdx.doi.org%2F10.1016%2Fj.placenta.2006.01.010 returns "{"Error":"Maximum number of allowed redirects reached"}" [19:57:23] ok if I file a ticket? [19:57:27] Josve05a: If I use the resolved URL, `http://www.placentajournal.org/article/S0143-4004(06)00015-4/abstract`, it gives `[{"url":"http://www.placentajournal.org/article/S0143-4004(06)00015-4/abstract","itemType":"webpage","title":"Twin Anemia–Polycythemia Sequence in Two Monochorionic Twin Pairs Without Oligo-Polyhydramnios Sequence - Placenta","accessDate":"2015-12-11","websiteTitle":"www.placentajournal.org"}]` which isn't terrib [19:57:27] le but misses the DOI. [19:57:30] Please do! [19:57:35] Josve05a: Thank you. :-) [19:57:39] 10Citoid: Citoid fails to find doi in url to dx.doi.org - https://phabricator.wikimedia.org/T121265#1874124 (10Josve05a) 3NEW [19:58:13] 10Citoid: Citoid fails to cite from link to dx.doi.org - https://phabricator.wikimedia.org/T121265#1874131 (10Josve05a) [20:01:22] 10Citoid: Citoid fails to cite from link to dx.doi.org - https://phabricator.wikimedia.org/T121265#1874146 (10Josve05a) Same with http://dx.doi.org/10.1016/j.ajog.2008.03.050 [20:02:17] 10VisualEditor, 10VisualEditor-Tables: Be able to set a table to class= "sortable" - https://phabricator.wikimedia.org/T121267#1874148 (10Whatamidoing-WMF) 3NEW [20:02:50] James_F: Since the Cite-button was removed from the "pop-out"-window, this has become really annoying and tedious work... https://drive.google.com/a/edu.nacka.se/file/d/0B9BuJYqrg4ldZ1ZrM3ltVlh4NGs/view?usp=drivesdk [20:10:19] Josve05a: Why not just press "convert"? [20:10:54] Oh, I see, someone wrote it in plain text in your example. [20:10:59] Is that common? That seems really bizzare. [20:11:06] yes. very common [20:11:46] James_F: and even if they didn't I would have to add the doi and fill out the reference with citation bot since cioid doesn't fill out missing fields for existing templates. [20:12:32] https://en.wikipedia.org/wiki/Twin_Anemia-Polycythemia_Sequence_(TAPS)#References I did 7 now [20:12:53] Yeah. [20:23:31] new epic task? :P [20:23:39] Kemayo: Quick debugging of T121156 shows that LinearDeleteKeyDownHandler#execute calls the linear fragment's delete() which ends up with a selection of -1 to -1. :-( [20:24:06] Josve05a: More like, it's probably not worth it. Easier to do the work for references on Wikidata than try to add more hacks around the template-based ones. [20:25:17] well then. I'm off to fix the rest refs on thta page semi-manually [20:25:23] that* [20:25:49] Sorry. :-( [20:26:35] not your fault people are stupid and adding text-references [20:26:41] Well. [20:26:43] Not stupid. [20:26:49] We've failed to explain to them what's useful. [20:26:56] That means our software isn't good enough. [20:28:13] 10VisualEditor, 10VisualEditor-ContentEditable: When a link is the first element on a page, don't launch the link context menu automatically; instead put the cursor in the placement outside the link - https://phabricator.wikimedia.org/T114376#1874211 (10Jdforrester-WMF) a:3DLynch [20:30:52] noooo... [20:31:05] James_F: https://en.wikipedia.org/w/index.php?title=Twin_Anemia-Polycythemia_Sequence_(TAPS)&diff=694824020&oldid=694821506 nowiki-tag was added :/ [20:31:52] James_F: hm, okay. I'm at a bus stop right now, and will be back at my laptop to look at it shortly. [20:31:59] Kemayo: No worries. [20:32:14] Josve05a: Rightfully so… [20:32:30] Josve05a: Autolink{{template}} doesn't work without a space or a . [20:33:25] Josve05a: (And of course VE has no way of knowing this to tell you to put a space in.) [20:33:32] yes it does. MediaWIki is smart [20:33:35] https://en.wikipedia.org/wiki/User:Josve05a/sandbox12 [20:34:30] Hmm. [20:34:35] OK, Parsoid bug then. [20:34:45] Though I'm surprised. [20:35:27] Yeah, I've tagged a whole lot of autolinks with {{dead link|date=foo}} in my days, so I knew that it should have worked [20:35:44] (but most times I added brackets) [20:35:54] * James_F nods. [20:40:01] I know that it's nothing to make a fuss about at all, but do you mind perhaps making a note of that on phabricator? [20:52:48] (03PS1) 10Jforrester: build: Upgrade various devDependencies to latest [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/258510 [20:54:28] wait hang on, you mentioned Wikidata-references James_F. WIll references (for doi's) soon be stored on WIkidata? [20:58:00] Josve05a: Of course. [20:58:08] Yay!! [20:58:14] Josve05a: Well, not 'soon', but there's some great work being done. [20:58:24] Still yay! [21:00:31] (03PS1) 10Jforrester: build: Update various devDependencies to latest [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/258514 [21:47:15] 10Citoid, 10VisualEditor: Add ability to request base types in citoid, and offer use of both in extension for backwards compatibility until all templateData has been updated. - https://phabricator.wikimedia.org/T114515#1874389 (10kaldari) Oh well, I guess I'll just work around the inconsistency. [21:47:44] 10Citoid, 10VisualEditor: Add ability to request base types in citoid, and offer use of both in extension for backwards compatibility until all templateData has been updated. - https://phabricator.wikimedia.org/T114515#1874391 (10kaldari) [21:47:45] 10Citoid, 6Community-Tech: Add Citoid support to RefToolbar gadget - https://phabricator.wikimedia.org/T114156#1874390 (10kaldari) [21:47:57] 10Citoid, 10VisualEditor: Add ability to request base types in citoid, and offer use of both in extension for backwards compatibility until all templateData has been updated. - https://phabricator.wikimedia.org/T114515#1874392 (10Mvolz) It's less ideal, but you could cast bookChapters to journals... We'd be un... [21:49:19] 10Citoid: Citoid fails to cite from link to dx.doi.org - https://phabricator.wikimedia.org/T121265#1874393 (10Mvolz) p:5Triage>3High [21:50:49] 10Citoid: Citoid fails to cite from link to dx.doi.org - https://phabricator.wikimedia.org/T121265#1874124 (10Mvolz) We definitely shouldn't be returning that error. Cc @mobrovac [21:51:09] 10Citoid, 6Services: Citoid fails to cite from link to dx.doi.org - https://phabricator.wikimedia.org/T121265#1874401 (10Mvolz) [21:57:02] mvolz: Good afternoon :) [21:58:23] (03PS2) 10Jforrester: Drop support for adding prefix/appendix labels to edit tabs/links [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/258357 [21:58:32] (03PS2) 10Jforrester: Show the welcome dialog by default to new users [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/258358 [21:59:28] Josve05a: I think 22:00 is late enough to call 'night'. :-) [21:59:41] 23 here ;) [22:01:58] (03CR) 10jenkins-bot: [V: 04-1] Drop support for adding prefix/appendix labels to edit tabs/links [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/258357 (owner: 10Jforrester) [22:02:09] 10Citoid, 10VisualEditor: Add ability to request base types in citoid, and offer use of both in extension for backwards compatibility until all templateData has been updated. - https://phabricator.wikimedia.org/T114515#1874474 (10kaldari) @Mvolz: I think we're talking about two different bugs. I have no intere... [22:02:19] (03PS3) 10Jforrester: Show the welcome dialog by default to new users [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/258358 [22:27:45] 10VisualEditor, 10VisualEditor-MediaWiki: Provide a GET URL option on action=edit to force loading the wikitext editor, not the visual editor, regardless of preference - https://phabricator.wikimedia.org/T121242#1874504 (10Krenair) If we make editor=wikitext, does that mean we would want to support editor=visu... [22:31:17] 10VisualEditor, 10VisualEditor-MediaWiki-References: Make a better keyboard shortcut for adding a citation - https://phabricator.wikimedia.org/T99299#1874505 (10Neil_P._Quinn_WMF) a:5Neil_P._Quinn_WMF>3None [22:31:39] 10VisualEditor, 10VisualEditor-MediaWiki-References: Come up with a better way to auto-label references - https://phabricator.wikimedia.org/T92432#1874506 (10Neil_P._Quinn_WMF) a:5Neil_P._Quinn_WMF>3None [22:31:56] 10VisualEditor, 7I18n: Reconsider the terminology around citations, references and footnotes in VisualEditor - https://phabricator.wikimedia.org/T85679#1874507 (10Neil_P._Quinn_WMF) a:5Neil_P._Quinn_WMF>3None [22:33:08] 10VisualEditor, 10VisualEditor-MediaWiki, 10MediaWiki-General-or-Unknown: On non-current revisions, content navigation view tabs should link to the same non-current revision - https://phabricator.wikimedia.org/T95985#1874511 (10Neil_P._Quinn_WMF) a:5Neil_P._Quinn_WMF>3None [22:35:13] neilpquinn: You are putting tasks up for grabs. Are you giving up on them, or are you quitting WMF or something? Just curious [22:36:13] * guillom sure hopes neil is not leaving. [22:36:18] Josve05a: no definitely not quitting the WMF! :) [22:36:36] ah good! Was worried there for a sec [22:37:12] 10VisualEditor, 10VisualEditor-MediaWiki: On single edit tab wikis, if your browser is non-JS but your settings say VE you get a blank edit page and no way to fix it - https://phabricator.wikimedia.org/T121257#1874522 (10Krenair) So we give this blank page because of concerns that by loading VE on the top of a... [22:37:30] When I started in April, the plan was for me to help James product manage VE. But since then I've essentially shifted into being a data analyst for the whole Editing department, because that need seems greater right now (and I like data!). [22:38:19] structured date > data ;) [22:38:49] Haha, yes. I guess that's what I'm supposed to do now :) [22:39:00] I actually made that shift months ago, but some things, like those task assignments, hung around. So I'm just cleaning out the closet :) [22:39:39] But in all seriousness I'm touched that you'd worry about my leaving. Thanks! [22:40:32] of course, can't have you up and leave in less than a year [22:41:21] Yeah, that's about when James_F tells me he'll remove the leg irons. [22:42:16] lol [22:42:47] 10VisualEditor, 10VisualEditor-MediaWiki: On single edit tab wikis, clicking on a section edit link gives an editor whose switching works oddly - https://phabricator.wikimedia.org/T120966#1874538 (10Krenair) Is this consistently reproducible? By 'back to the editor' you mean back into VE? [22:43:09] neilpquinn: Howabout getting yourself a Wiki[mp]edia-cloak here on IRC, like the rest of us nerds? [22:44:16] * James_F grins at neilpquinn. [22:44:25] Josve05a: and stop my guerilla advertising for IRC Cloud™? [22:44:59] All that are smart enough already uses it (me included ;). The rest can't be helped [22:45:10] neilpquinn: If you switch to my ZNC server you can advertise jdforrester.org instead. :_) [22:46:13] James_F: I like your website, but you should go super minimalist like I do: http://neilpquinn.com/ [22:46:37] It is actually registered :) [22:47:41] Josve05a: well, I do like flying the Wikimedia flag (I'm not a Wikipedia exclusivist haha) so maybe I will [22:47:42] * James_F grins. [22:47:58] maybe I should just serve a completely blank page. [22:48:33] * Josve05a got the WIkipedia-cloak while he still shied away from all the other projects for being mean [22:49:19] nyan.cat :D [22:50:30] now that's a great webpage [22:52:01] haha, I thought you were going to say that was yours. But apparently not :) https://duckduckgo.com/?q=whois+nyan.cat&t=ffab&ia=whois [22:52:24] I like the Christmas theme. [22:53:26] 10VisualEditor, 10VisualEditor-MediaWiki: On single edit tab wikis, clicking on a section edit link gives an editor whose switching works oddly - https://phabricator.wikimedia.org/T120966#1874553 (10Krenair) I think I misunderstood a bit, but it still works for me... [22:56:46] 10VisualEditor, 10VisualEditor-MediaWiki: On single edit tab wikis, switching from VE to WT does not always set the visualeditor-editor option - https://phabricator.wikimedia.org/T121122#1874556 (10Krenair) I noticed you removed the FF/Safari tags... Does this mean you reproduced it in a browser like Chrome? I... [22:58:39] neilpquinn: I wish it was my page xD [22:59:12] I think I got mine while I was involved with both wikipedia and mediawiki [22:59:20] (wikimedia/ cloak) [22:59:25] 10VisualEditor, 10VisualEditor-MediaWiki: On single edit tab wikis, switching from VE to WT does not always set the visualeditor-editor option - https://phabricator.wikimedia.org/T121122#1874560 (10Jdforrester-WMF) >>! In T121122#1874556, @Krenair wrote: > I noticed you removed the FF/Safari tags... Does this... [23:00:09] I got mine changed over when I issued them. ;-) [23:00:49] no-one here able to change my cloak? :p [23:01:18] Not for many years, sorry. [23:01:59] Josve05a, https://meta.wikimedia.org/wiki/IRC/Cloaks [23:03:04] Just remembered that it would create all kinds of problems with op-flags and stuff. Nvm :P [23:03:28] only if people are adding you to channel access lists by your cloak instead of your nickserv account name [23:04:01] right, but some channels has done that [23:08:22] James_F, so other things that I suspect will trip SET up: oldid, history states (back/forward out of/in to VE) [23:08:33] * James_F nods. [23:08:50] Not all of them need to be fixed up-front. [23:08:53] yeah [23:09:00] E.g. proper undo is a a feature, not a bug. [23:09:24] just trying to make sure the parts that I think are most likely to break get tested [23:09:31] Yeah. :-) [23:09:45] I did some testing obviously [23:09:47] Any idea for how to make the preference change stick? [23:10:09] But can't possibly hope to cover all of our probably thousands of different combinations of states [23:10:15] Indeed. [23:10:18] sorry, context? [23:10:46] T121122#1874556 [23:11:37] 10VisualEditor, 10VisualEditor-EditingTools: VisualEditor: there is no way to change the template name without re-filling all the params - https://phabricator.wikimedia.org/T70088#1874592 (10Josve05a) Somewhat similar to T97936? To be able to chnage template name easily. [23:12:34] 10Citoid, 10VisualEditor: Allow user to switch cite template in limited circumstances - https://phabricator.wikimedia.org/T97936#1255434 (10Josve05a) https://sv.wikipedia.org/wiki/Wikipedia:VisualEditor/%C3%85terkoppling#Not_a_malfunction_but_an_improvement_proposal [23:12:44] vesection vs. section might also be broken when loading via URL instead of clicking [23:16:12] oh [23:16:22] I just tried to switch from WT into VE and it loaded WT again [23:16:36] that sounds like one of the bugs you filed James_F [23:17:17] Yeah. [23:17:21] (03PS1) 10Alex Monk: Check that we really want VE before loading it for section edits [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/258635 (https://phabricator.wikimedia.org/T121189) [23:18:09] sometimes I wish I could view blocker lists like a workboard, and filter them [23:18:10] Krenair: Don't you have to declare that new var? [23:18:17] uhh... yeah [23:18:29] James_F for jenkins v2.0 [23:18:34] * James_F grins. [23:19:13] (03PS2) 10Alex Monk: Check that we really want VE before loading it for section edits [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/258635 (https://phabricator.wikimedia.org/T121189) [23:20:14] So if we could clone James... [23:20:21] :) [23:20:36] 10Citoid, 10VisualEditor: Add ability to request base types in citoid, and offer use of both in extension for backwards compatibility until all templateData has been updated. - https://phabricator.wikimedia.org/T114515#1874620 (10kaldari) @Mvolz: Also, if we're sticking strictly to the Zotero standard, what ex... [23:20:55] (03CR) 10Legoktm: [C: 032] build: Upgrade various devDependencies to latest [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/258510 (owner: 10Jforrester) [23:20:55] Krenair: I don't have the salary to pay for two of me to live in SF. :-) [23:21:06] 10VisualEditor, 10VisualEditor-MediaWiki: On single edit tab wikis, clicking on a section edit link gives an editor whose switching works oddly - https://phabricator.wikimedia.org/T120966#1874621 (10Krenair) I said that, and then when I was testing something else I reproduced the exact issue. [23:21:06] (03CR) 10Legoktm: [C: 032] build: Update various devDependencies to latest [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/258514 (owner: 10Jforrester) [23:22:24] Any reason https://phabricator.wikimedia.org/T97936#1874593 doens't have project #VisualEditor-MediaWiki-Templates attached to it? [23:23:08] Josve05a: It could, but we don't add it all the time. Relatively few people care only about templates inside VE-MW. [23:23:36] :/ [23:23:46] Well, I'm gonna add a comment... [23:23:51] Go for it. [23:24:16] 10Citoid, 10VisualEditor, 10VisualEditor-MediaWiki-Templates: Allow user to switch cite template in limited circumstances - https://phabricator.wikimedia.org/T97936#1874622 (10Josve05a) >>! In T97936#1398780, @Mvolz wrote: > Assigning to @Nirzar for either an opinion or a design :). @Mvolz: Time to put it u... [23:25:09] (03Merged) 10jenkins-bot: build: Upgrade various devDependencies to latest [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/258510 (owner: 10Jforrester) [23:25:23] (03Merged) 10jenkins-bot: build: Update various devDependencies to latest [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/258514 (owner: 10Jforrester) [23:32:27] * Josve05a feels like he has done his duty relaying comments from sv.wp about VE for today :) [23:34:53] 10VisualEditor, 10VisualEditor-MediaWiki: On single edit tab wikis, clicking on a section edit link gives an editor whose switching works oddly - https://phabricator.wikimedia.org/T120966#1874673 (10Krenair) looks like it is happening when when you try to switch from WT to VE and have the single edit tab prefe... [23:36:19] 10VisualEditor, 10VisualEditor-MediaWiki: On single edit tab wikis, clicking on a section edit link gives an editor whose switching works oddly - https://phabricator.wikimedia.org/T120966#1874677 (10Jdforrester-WMF) >>! In T120966#1874673, @Krenair wrote: > looks like it is happening when when you try to switc... [23:37:08] (03CR) 10Jforrester: [C: 032] "This code is getting ever-less readable. :-(" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/258635 (https://phabricator.wikimedia.org/T121189) (owner: 10Alex Monk) [23:39:13] (03PS1) 10Alex Monk: Remember switching into VE from WT when discarding changes [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/258643 (https://phabricator.wikimedia.org/T120966) [23:40:12] (03Merged) 10jenkins-bot: Check that we really want VE before loading it for section edits [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/258635 (https://phabricator.wikimedia.org/T121189) (owner: 10Alex Monk) [23:45:20] James_F, I know :( [23:45:41] It feels like every single thing we need to check has a different set of conditions attached to it [23:46:00] hopefully that makes some sort of sense [23:46:51] I'd really like to simplify it, but I don't think we're going to get around the problem that our current project involves an extra 4 different ways to configure the initialisation code [23:46:59] extra 3, really [23:57:32] (03PS1) 10Alex Monk: Try to clean up the WT->VE prompt opened -> closing -> closed data callbacks [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/258647