[00:18:29] <wikibugs>	 10Citoid, 10VisualEditor: Add ability to request base types in citoid, and offer use of both in extension for backwards compatibility until all templateData has been updated. - https://phabricator.wikimedia.org/T114515#1874749 (10Mvolz) Do you mean request the zotero datatype rather than the mediawiki data typ...
[00:22:21] <James_F>	 Krenair: Yeah, I think a lot of the code needs to be moved (eventually) into MediaWiki itself as part of core multi-editor support
[00:22:45] <Krenair>	 yeah
[00:23:05] <Krenair>	 hopefully we'll find some way to make that work with our 4 tab preferences
[00:23:27] <James_F>	 More than four.
[00:23:56] <James_F>	 order (2) x user preference (4) x default config (2) x user state (3)
[00:24:01] <James_F>	 Getting insane.
[00:25:59] <grrrit-wm>	 (03CR) 10Jforrester: [C: 032] Remember switching into VE from WT when discarding changes [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/258643 (https://phabricator.wikimedia.org/T120966) (owner: 10Alex Monk)
[00:26:23] <wikibugs>	 10VisualEditor, 10VisualEditor-MediaWiki, 7Design, 7Epic, 5WMF-deploy-2015-12-15_(1.27.0-wmf.9): Change VE integration to only use one edit tab, to avoid user choice paralysis - https://phabricator.wikimedia.org/T58337#1874785 (10Jdforrester-WMF)
[00:26:26] <wikibugs>	 10VisualEditor, 10VisualEditor-MediaWiki, 5Patch-For-Review: On single edit tab wikis, clicking on a section edit link gives an editor whose switching works oddly - https://phabricator.wikimedia.org/T120966#1874783 (10Jdforrester-WMF) 5Open>3Resolved Provisionally assuming fixed.
[00:27:02] <grrrit-wm>	 (03CR) 10Jforrester: [C: 032] Try to clean up the WT->VE prompt opened -> closing -> closed data callbacks [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/258647 (owner: 10Alex Monk)
[00:27:57] <James_F>	 Krenair: I was going to write some functions like switchToVEAndRemember() and switchToWTAndRemember() to share that call.
[00:28:12] <Krenair>	 ok
[00:28:27] <James_F>	 Krenair: But don't want to trip over your code changes…
[00:28:42] <grrrit-wm>	 (03CR) 10Jforrester: "Needs rebase :-(" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/258230 (https://phabricator.wikimedia.org/T120970) (owner: 10Alex Monk)
[00:28:42] <Krenair>	 I don't have anything not in gerrit at the moment
[00:28:53] <grrrit-wm>	 (03Merged) 10jenkins-bot: Remember switching into VE from WT when discarding changes [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/258643 (https://phabricator.wikimedia.org/T120966) (owner: 10Alex Monk)
[00:29:11] <Krenair>	 urgh I doubt that's going to be fun to rebase
[00:29:24] <James_F>	 Kk.
[00:32:22] <grrrit-wm>	 (03Merged) 10jenkins-bot: Try to clean up the WT->VE prompt opened -> closing -> closed data callbacks [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/258647 (owner: 10Alex Monk)
[00:32:22] <Krenair>	 oh, it's not  so bad
[00:33:01] <grrrit-wm>	 (03PS3) 10Alex Monk: Change tab text on server side [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/258230 (https://phabricator.wikimedia.org/T120970) 
[00:33:35] <wikibugs>	 10Citoid, 10VisualEditor: Automatic cite feature in VisualEditor on English Wikipedia sets edition as "X edition ed." - https://phabricator.wikimedia.org/T121295#1874788 (10kaldari) 3NEW
[00:34:34] <wikibugs>	 10Citoid, 10VisualEditor, 6Services: Citoid fails to cite from link to dx.doi.org - https://phabricator.wikimedia.org/T121265#1874795 (10Josve05a)
[00:42:43] <grrrit-wm>	 (03CR) 10GOIII: "fwiw... I haven't seen that loading 'spinner' for months now so I don't know if this change is still worthwhile." [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/184301 (owner: 10Gerrit Patch Uploader)
[00:51:46] <grrrit-wm>	 (03PS1) 10Jforrester: DesktopArticleTarget: Consolidate editor preference setting code [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/258654 
[00:52:53] <grrrit-wm>	 (03CR) 10Esanders: "But it would be better than 'Page history', or 'Editing {Page-title}'..." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/252218 (https://phabricator.wikimedia.org/T117643) (owner: 10Alex Monk)
[00:59:06] <grrrit-wm>	 (03CR) 10Alex Monk: "true... we should probably have a bug for that page history thing btw" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/252218 (https://phabricator.wikimedia.org/T117643) (owner: 10Alex Monk)
[00:59:46] <grrrit-wm>	 (03CR) 10Catrope: [C: 031] DesktopArticleTarget: Consolidate editor preference setting code [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/258654 (owner: 10Jforrester)
[01:02:30] <edsanders>	 did James_F not file one? are you going to?
[01:04:32] <grrrit-wm>	 (03CR) 10Alex Monk: DesktopArticleTarget: Consolidate editor preference setting code (031 comment) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/258654 (owner: 10Jforrester)
[01:05:53] <grrrit-wm>	 (03CR) 10Esanders: [C: 04-1] DesktopArticleTarget: Consolidate editor preference setting code (031 comment) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/258654 (owner: 10Jforrester)
[01:11:13] <grrrit-wm>	 (03CR) 10Jforrester: DesktopArticleTarget: Consolidate editor preference setting code (032 comments) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/258654 (owner: 10Jforrester)
[01:13:30] <grrrit-wm>	 (03PS2) 10Jforrester: DesktopArticleTarget: Consolidate editor preference setting code [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/258654 
[01:13:30] <James_F>	 edsanders: I didn't, no.
[01:13:30] <James_F>	 edsanders: Have you reviewed https://gerrit.wikimedia.org/r/258230 ?
[01:13:31] <edsanders>	 I've read it
[01:13:38] <James_F>	 Not sure about it?
[01:14:22] <edsanders>	 I haven't understood it yet
[01:16:25] <James_F>	 edsanders: RoanKattouw said much the same.
[01:16:25] <James_F>	 Good sign, eh?
[01:30:45] <grrrit-wm>	 (03CR) 10Alex Monk: [C: 031] DesktopArticleTarget: Consolidate editor preference setting code [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/258654 (owner: 10Jforrester)
[01:44:38] <wikibugs>	 10VisualEditor, 10VisualEditor-MediaWiki, 5Patch-For-Review, 5WMF-deploy-2015-12-15_(1.27.0-wmf.9): On single edit tab wikis, clicking on a section edit link always gives the visual editor regardless of visualeditor-editor setting - https://phabricator.wikimedia.org/T121189#1874872 (10Jdforrester-WMF) 5Op...
[01:44:41] <wikibugs>	 10VisualEditor, 10VisualEditor-MediaWiki, 7Design, 7Epic, 5WMF-deploy-2015-12-15_(1.27.0-wmf.9): Change VE integration to only use one edit tab, to avoid user choice paralysis - https://phabricator.wikimedia.org/T58337#1874874 (10Jdforrester-WMF)
[01:49:01] <grrrit-wm>	 (03CR) 10Esanders: [C: 032] DesktopArticleTarget: Consolidate editor preference setting code [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/258654 (owner: 10Jforrester)
[01:50:04] <wikibugs>	 10Citoid, 10VisualEditor, 6Services: Citoid fails to cite from link to dx.doi.org - https://phabricator.wikimedia.org/T121265#1874879 (10GWicke) There does indeed seem to be a lot of redirecting, especially on the Elsevier site. Maybe we need to slightly bump the redirect limit to be in line with browser lim...
[01:51:54] <grrrit-wm>	 (03CR) 10Jforrester: [C: 032] Update grunt-jscs to 2.5.0 [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/257986 (owner: 10Paladox)
[01:52:13] <grrrit-wm>	 (03Merged) 10jenkins-bot: DesktopArticleTarget: Consolidate editor preference setting code [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/258654 (owner: 10Jforrester)
[01:53:34] <grrrit-wm>	 (03Merged) 10jenkins-bot: Update grunt-jscs to 2.5.0 [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/257986 (owner: 10Paladox)
[02:07:12] <James_F>	 Krenair: Aha.
[02:07:15] <James_F>	 https://phabricator.wikimedia.org/T121122
[02:07:40] <James_F>	 Krenair: I'm pretty sure it only happens if you switch without changes from VE to WT so ?veswitched=1 gets set.
[02:08:31] <James_F>	 Krenair: `				uri.query.veswitched === undefined && ` can probably be dropped?
[02:09:43] <Krenair>	 probably
[02:10:32] <wikibugs>	 10VisualEditor, 10VisualEditor-MediaWiki: On single edit tab wikis, if your browser is not supported but your settings (or default) says VE you get a blank edit page and no way to fix it - https://phabricator.wikimedia.org/T121298#1874904 (10Jdforrester-WMF) 3NEW a:3Krenair
[02:10:37] <James_F>	 OK.
[02:10:39] * James_F tries that.
[02:11:30] <RoanKattouw>	 James_F: The computer scientist in me weeps at https://phabricator.wikimedia.org/T117786#1874896
[02:15:37] <grrrit-wm>	 (03PS1) 10Jforrester: DesktopArticleTarget: Don't abort in SET mode if veswitched is set [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/258660 (https://phabricator.wikimedia.org/T121122) 
[02:18:50] <James_F>	 Krenair: OK, so, review of the world as far as I know it:
[02:18:59] <grrrit-wm>	 (03CR) 10Paladox: "Thanks." [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/257986 (owner: 10Paladox)
[02:19:08] <James_F>	 T120970 (FOUC) – you have a patch, it's a bit scary but it seems like it works.
[02:19:35] <James_F>	 T121122 (preference not being set) – I have a patch, it's not totally clear it fixes it but let's find out.
[02:20:05] <James_F>	 T121298 (UA sniffing) – needs a patch, bit of a hack, has a paste of stupid code I wrote.
[02:20:54] <James_F>	 T121257 (non-JS) – needs a patch to bounce users who don't have JS from blank ?action=edit screens to something useful.
[02:20:58] <James_F>	 And that's it.
[02:21:00] <James_F>	 Sounds right?
[02:25:20] <Krenair>	 sounds about right
[02:31:02] <James_F>	 Kk. Fun.
[02:31:30] <RoanKattouw>	 James_F: Weep some more https://phabricator.wikimedia.org/T117786#1874932
[02:31:39] <Krenair>	 James_F, oh... your patch does sound like it would work
[02:31:47] <Krenair>	 from reading the commit message shown by gerrit bot on phab
[02:34:02] <James_F>	 :-)
[08:12:48] <grrrit-wm>	 (03CR) 10Fomafix: "You think of a other spinner in the toolbar." [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/184301 (owner: 10Gerrit Patch Uploader)
[09:00:56] <grrrit-wm>	 (03CR) 10GOIII: [C: 031] "Ah... you are right, I don't typically have the dialogs enabled. But the change looked fine in Edge's Dev Tools mock-up fwiw." [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/184301 (owner: 10Gerrit Patch Uploader)
[09:53:35] <wikibugs>	 10VisualEditor, 10VisualEditor-InterfaceLanguage, 10VisualEditor-MediaWiki, 7I18n: VisualEditor: As much as possible, the link to the user manual should lead directly to a manual in the user's language - https://phabricator.wikimedia.org/T53797#1875183 (10Liuxinyu970226)
[09:56:54] <wikibugs>	 10VisualEditor, 10VisualEditor-EditingTools: Create a nicer context view for the language annotation showing the language code in a box - https://phabricator.wikimedia.org/T98554#1875191 (10Liuxinyu970226)
[10:56:51] <wikibugs>	 10WikiEditor, 10MediaWiki-ResourceLoader, 10MediaWiki-extensions-SemanticForms: Uncaught ReferenceError: jQuery is not defined with action=formedit on MW 1.26 - https://phabricator.wikimedia.org/T121221#1875243 (10Paladox)
[10:58:04] <grrrit-wm>	 (03PS1) 10Paladox: Use the same icon as the russian for the ukraine [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/258674 (https://phabricator.wikimedia.org/T25914) 
[10:58:27] <grrrit-wm>	 (03PS2) 10Paladox: Use the same icon as the russian for the ukraine [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/258674 (https://phabricator.wikimedia.org/T25914) 
[15:05:59] <wikibugs>	 10WikiEditor, 10MediaWiki-ResourceLoader, 10MediaWiki-extensions-SemanticForms, 5Patch-For-Review: Uncaught ReferenceError: jQuery is not defined with action=formedit on MW 1.26 - https://phabricator.wikimedia.org/T121221#1875494 (10TheDJ) ``` <script>jQuery(function()(mw.loader.using("ext.semanticforms.wi...
[15:19:21] <wikibugs>	 10VisualEditor: Find the phrase "ISBN" from ISBN magic links with Find and replace - https://phabricator.wikimedia.org/T121315#1875502 (10CennoxX) 3NEW
[15:30:49] <wikibugs>	 10VisualEditor: Find and replace bar is too high in the vertical stacking - https://phabricator.wikimedia.org/T121317#1875519 (10CennoxX) 3NEW
[15:46:50] <wikibugs>	 10VisualEditor, 10VisualEditor-MediaWiki-Mobile: Save button (for article edits) not working in iOS 9's Safari browser - https://phabricator.wikimedia.org/T121308#1875525 (10Krenair)
[21:25:22] <MtDu_>	 mooeypoo: Hey! I've been working on the https://phabricator.wikimedia.org/T45481 task for GCI. I just submitted a patch at https://gerrit.wikimedia.org/r/#/c/258698/. I also left you a message on the GCI site. Please take a look. Thanks! :)
[21:34:18] <grrrit-wm>	 (03PS1) 10Legoktm: Remove no longer needed ContentHandlerDefaultModelFor hook [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/258704 
[21:35:01] <grrrit-wm>	 (03PS1) 10Legoktm: Remove no longer needed ContentHandlerDefaultModelFor hook [extensions/Citoid] - 10https://gerrit.wikimedia.org/r/258705 
[21:47:55] <grrrit-wm>	 (03CR) 10Alex Monk: [C: 032] Remove no longer needed ContentHandlerDefaultModelFor hook [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/258704 (owner: 10Legoktm)
[21:48:25] <grrrit-wm>	 (03CR) 10Alex Monk: [C: 032] Remove no longer needed ContentHandlerDefaultModelFor hook [extensions/Citoid] - 10https://gerrit.wikimedia.org/r/258705 (owner: 10Legoktm)
[21:52:58] <grrrit-wm>	 (03Merged) 10jenkins-bot: Remove no longer needed ContentHandlerDefaultModelFor hook [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/258704 (owner: 10Legoktm)
[21:53:00] <grrrit-wm>	 (03Merged) 10jenkins-bot: Remove no longer needed ContentHandlerDefaultModelFor hook [extensions/Citoid] - 10https://gerrit.wikimedia.org/r/258705 (owner: 10Legoktm)
[21:54:07] <grrrit-wm>	 (03PS3) 10Paladox: Replace format-bold-ru.png image [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/257978 (https://phabricator.wikimedia.org/T119716) 
[21:55:04] <grrrit-wm>	 (03CR) 10Paladox: "Ok done. It was done by user Дагиров Умар https://commons.wikimedia.org/wiki/File:Toolbaricon_bold_Ӏаь.svg I just uploaded it to gerrit." [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/257978 (https://phabricator.wikimedia.org/T119716) (owner: 10Paladox)