[00:07:22] 10WikiEditor, 5Patch-For-Review: Signature button in Hungarian should produce "– ~~~~" - https://phabricator.wikimedia.org/T26191#1876811 (10GOIII) >>! In T26191#1876619, @gerritbot wrote: > Change 258783 had a related patch set uploaded (by @Paladox): > Localise the signiture code > > [[https://gerrit.wikime... [00:35:23] 10WikiEditor, 5Patch-For-Review: Signature button in Hungarian should produce "– ~~~~" - https://phabricator.wikimedia.org/T26191#1876834 (10Paladox) @GOlll then I think that this would need to be discussed. So that we can decide weather the patch could be merged or would it cause more problems then it solves.... [00:37:06] (03PS2) 10Esanders: ve.ce.Surface: Remove selection-type awareness from fixShiftClickSelect [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/258768 [00:37:08] (03PS4) 10Esanders: ve.ce.Surface: Remove selection-type awareness from renderSelectedContentBranchNode [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/258761 [01:14:03] (03CR) 10Esanders: [C: 032] Switch numbered link context to "delete" instead of "clear" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/257960 (https://phabricator.wikimedia.org/T120705) (owner: 10DLynch) [01:19:24] (03Merged) 10jenkins-bot: Switch numbered link context to "delete" instead of "clear" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/257960 (https://phabricator.wikimedia.org/T120705) (owner: 10DLynch) [06:09:36] (03CR) 10Gergő Tisza: [C: 031] "Looks good. I wonder though if this should use a core message, given that the core editor has a signature button as well." [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/258783 (https://phabricator.wikimedia.org/T26191) (owner: 10Paladox) [06:24:47] 10WikiEditor, 5Patch-For-Review: Signature button in Hungarian should produce "– ~~~~" - https://phabricator.wikimedia.org/T26191#1877023 (10Tgr) > Whoa... I'm not so sure the original issue was about replacing the "example" text with something administrator's can customize in some newly associated MediaWiki:... [08:28:46] (03PS1) 10DLynch: Fragment delete: handle a document with no valid content offsets [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/258936 (https://phabricator.wikimedia.org/T121156) [08:30:37] (03PS2) 10DLynch: Fragment delete: handle a document with no valid content offsets [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/258936 (https://phabricator.wikimedia.org/T121156) [11:06:44] 10VisualEditor, 10MediaWiki-extensions-RelatedArticles, 3Reading Web Sprint 62 - DJ-Jazzy-Jeff-and-the-Fresh-Sprints: RelatedArticles disappears during edit process when using VisualEditor - https://phabricator.wikimedia.org/T120443#1877265 (10bmansurov) 5Open>3Resolved [15:49:31] (03CR) 10Jforrester: [C: 04-1] "A couple of minor comments around nomenclature. Have pinged Nemo bis for confirmation/more details on the translatewiki stuff." (032 comments) [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/258783 (https://phabricator.wikimedia.org/T26191) (owner: 10Paladox) [15:52:02] (03CR) 10Paladox: Localise the signiture code (031 comment) [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/258783 (https://phabricator.wikimedia.org/T26191) (owner: 10Paladox) [15:52:05] (03PS3) 10Paladox: Localise the signiture code [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/258783 (https://phabricator.wikimedia.org/T26191) [15:53:23] (03CR) 10Divec: "Slight correction of previous comment: it would currently be needed when cursoring out of a unicorned span straight onto a focusable node " [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/258761 (owner: 10Esanders) [15:57:24] (03PS4) 10Paladox: Localise the signiture code [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/258783 (https://phabricator.wikimedia.org/T26191) [16:03:07] (03CR) 10Paladox: "Ok done at https://gerrit.wikimedia.org/r/#/c/258991/ for translatewiki." [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/258783 (https://phabricator.wikimedia.org/T26191) (owner: 10Paladox) [16:28:48] (03PS5) 10Esanders: ve.ce.Surface: Remove selection-type awareness from renderSelectedContentBranchNode [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/258761 [16:28:49] (03PS1) 10Esanders: ve.ce.Surface: Remove selection-type awareness from checkSequences [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/259000 [16:35:02] (03CR) 10Jforrester: Localise the signiture code (031 comment) [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/258783 (https://phabricator.wikimedia.org/T26191) (owner: 10Paladox) [16:35:52] (03PS5) 10Jforrester: Let the signature wikitext be over-ridden locally [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/258783 (https://phabricator.wikimedia.org/T26191) (owner: 10Paladox) [16:36:31] (03CR) 10Jforrester: [C: 031] Let the signature wikitext be over-ridden locally [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/258783 (https://phabricator.wikimedia.org/T26191) (owner: 10Paladox) [16:41:36] (03CR) 10Alex Monk: [C: 032] DesktopArticleTarget: Don't abort in SET mode if veswitched is set [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/258660 (https://phabricator.wikimedia.org/T121122) (owner: 10Jforrester) [16:41:57] 10VisualEditor, 10VisualEditor-MediaWiki, 5Patch-For-Review: On single edit tab wikis, switching from VE to WT does not always set the visualeditor-editor option - https://phabricator.wikimedia.org/T121122#1877936 (10Krenair) a:5Krenair>3Jdforrester-WMF [16:42:05] Hello again, wikibugs. [16:46:05] (03Merged) 10jenkins-bot: DesktopArticleTarget: Don't abort in SET mode if veswitched is set [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/258660 (https://phabricator.wikimedia.org/T121122) (owner: 10Jforrester) [16:46:23] (03CR) 10Divec: [C: 032] ve.ce.Surface: Remove selection-type awareness from showModelSelection [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/258760 (owner: 10Esanders) [16:48:45] 10VisualEditor, 10VisualEditor-MediaWiki: SingleEditTab: Exception thrown switching from VE to WE while logged out - https://phabricator.wikimedia.org/T121343#1877955 (10Krenair) a:3Krenair [16:49:56] (03PS1) 10Alex Monk: Fix setEditorPreference call [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/259007 (https://phabricator.wikimedia.org/T121343) [16:50:14] (03Merged) 10jenkins-bot: ve.ce.Surface: Remove selection-type awareness from showModelSelection [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/258760 (owner: 10Esanders) [16:59:00] (03PS1) 10Alex Monk: Take pageCanLoadVE into account when figuring out whether VE will load in-page or not [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/259013 (https://phabricator.wikimedia.org/T121342) [16:59:20] 10VisualEditor, 10VisualEditor-MediaWiki, 5Patch-For-Review: With single edit tab enabled, VE loads directly from the history page with the wrong heading and subheading - https://phabricator.wikimedia.org/T121342#1878000 (10Krenair) a:3Krenair [17:02:46] (03CR) 10Jforrester: [C: 032] "Gah, I thought I fixed this? Must have not committed." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/259007 (https://phabricator.wikimedia.org/T121343) (owner: 10Alex Monk) [17:08:06] (03CR) 10Jforrester: [C: 032] Take pageCanLoadVE into account when figuring out whether VE will load in-page or not [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/259013 (https://phabricator.wikimedia.org/T121342) (owner: 10Alex Monk) [17:08:44] (03Merged) 10jenkins-bot: Fix setEditorPreference call [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/259007 (https://phabricator.wikimedia.org/T121343) (owner: 10Alex Monk) [17:09:06] 10VisualEditor, 10VisualEditor-MediaWiki: SingleEditTab: Exception thrown switching from VE to WE while logged out - https://phabricator.wikimedia.org/T121343#1878052 (10Jdforrester-WMF) 5Open>3Resolved [17:09:58] (03PS4) 10Jforrester: Show the welcome dialog by default to new users [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/258358 [17:10:00] (03PS1) 10Jforrester: MWWelcomeDialog: Let the user switch editors [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/259017 [17:10:15] (03CR) 10Jforrester: [C: 04-1] "Doesn't work yet." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/259017 (owner: 10Jforrester) [17:14:43] (03Merged) 10jenkins-bot: Take pageCanLoadVE into account when figuring out whether VE will load in-page or not [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/259013 (https://phabricator.wikimedia.org/T121342) (owner: 10Alex Monk) [17:29:57] (03PS1) 10Esanders: ve.ce.Selection: Freeze focusedNode when selection is created [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/259022 [17:35:52] 10VisualEditor, 10VisualEditor-MediaWiki, 5Patch-For-Review: With single edit tab enabled, VE loads directly from the history page with the wrong heading and subheading - https://phabricator.wikimedia.org/T121342#1878126 (10Krenair) [17:35:53] 10VisualEditor, 10VisualEditor-MediaWiki: SingleEditTab: Exception thrown switching from VE to WE while logged out - https://phabricator.wikimedia.org/T121343#1878125 (10Krenair) [17:35:57] 10VisualEditor, 10VisualEditor-MediaWiki, 7Design, 7Epic, 5WMF-deploy-2015-12-15_(1.27.0-wmf.9): Change VE integration to only use one edit tab, to avoid user choice paralysis - https://phabricator.wikimedia.org/T58337#1878124 (10Krenair) [17:36:26] 10VisualEditor, 10VisualEditor-MediaWiki, 5Patch-For-Review: With single edit tab enabled, VE loads directly from the history page with the wrong heading and subheading - https://phabricator.wikimedia.org/T121342#1878129 (10Krenair) 5Open>3Resolved [17:36:30] 10VisualEditor, 10VisualEditor-MediaWiki, 7Design, 7Epic, 5WMF-deploy-2015-12-15_(1.27.0-wmf.9): Change VE integration to only use one edit tab, to avoid user choice paralysis - https://phabricator.wikimedia.org/T58337#604549 (10Krenair) [17:36:50] 10VisualEditor, 10VisualEditor-MediaWiki: On single edit tab wikis, if your browser is non-JS but your settings say VE you get a blank edit page and no way to fix it - https://phabricator.wikimedia.org/T121257#1878139 (10Krenair) a:5Krenair>3Jdforrester-WMF reassign for comment [17:37:55] (03CR) 10Divec: [C: 032] ve.ce.Surface: Remove selection-type awareness from fixShiftClickSelect [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/258768 (owner: 10Esanders) [17:38:47] (03CR) 10Divec: [C: 032] ve.ce.Surface: Remove selection-type awareness from checkSequences [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/259000 (owner: 10Esanders) [17:40:20] 10VisualEditor, 10VisualEditor-MediaWiki, 5Patch-For-Review, 5WMF-deploy-2015-12-15_(1.27.0-wmf.9): On single edit tab wikis, switching from VE to WT does not always set the visualeditor-editor option - https://phabricator.wikimedia.org/T121122#1878155 (10Krenair) I think this can be closed, please check [17:41:53] James_F: [17:41:53] (03Merged) 10jenkins-bot: ve.ce.Surface: Remove selection-type awareness from fixShiftClickSelect [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/258768 (owner: 10Esanders) [17:42:00] Hmm. [17:42:05] Needs confirmation from you that it can be closed: T121122: On single edit tab wikis, switching from VE to WT does not always set the visualeditor-editor option [17:42:05] Master seems a mite broken. [17:42:10] Yeah. [17:42:15] Needs code review: T120970: On single edit tab wikis, if the user has a 've always' preference, there's a FOUC from 'edit' to 'edit source' on non-VE namespaces [17:42:24] (03PS3) 10DLynch: Fragment delete: handle a document with no valid content offsets [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/258936 (https://phabricator.wikimedia.org/T121156) [17:42:39] Kemayo: Anything big change with PS3? Was just testing. [17:42:39] Some code existing, I need to work on it: T121298: On single edit tab wikis, if your browser is not supported but your settings (or default) says VE you get a blank edit page and no way to fix it [17:42:47] Needs your comment: T121257: On single edit tab wikis, if your browser is non-JS but your settings say VE you get a blank edit page and no way to fix it [17:42:55] I think that's it. [17:43:05] (03Merged) 10jenkins-bot: ve.ce.Surface: Remove selection-type awareness from checkSequences [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/259000 (owner: 10Esanders) [17:43:11] Kk. [17:43:22] James_F: No, I just noticed a few things checking into ce.Surface, and figured it was worth double-checking whether they'd interfere. And then I had a rebased branch anyway, so I updated it. [17:43:33] Kemayo: OK. :-) [17:44:05] Krenair: Hmm. For T121257 this means that for wikis with VE-by-default, for users without JS they will always get an interstitial edit page on first run? :-( [17:44:36] Well yeah, I think so [17:44:41] Krenair: That's not great. [17:45:10] (03CR) 10Divec: [C: 032] ve.ce.Selection: Freeze focusedNode when selection is created [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/259022 (owner: 10Esanders) [17:45:32] Could we add a meta refresh to ?action=edit&editor=wikitext or something, killed by JS? [17:46:00] yeah, I didn't have any better ideas either [17:46:15] Wouldn't that result in us setting a preference in response to a GET though? [17:46:28] Only if it sets a preference. [17:47:02] yeah, okay, preference or cookie [17:47:06] cookie should be fine, I think [17:47:08] (But if we did that, we'd want to set a preference on save otherwise they'd be in an endless loops of edit->bounce->save [17:47:11] not so sure about preference [17:47:11] * James_F nods. [17:48:58] (03Merged) 10jenkins-bot: ve.ce.Selection: Freeze focusedNode when selection is created [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/259022 (owner: 10Esanders) [17:51:13] (03CR) 10Jforrester: [C: 032] Fragment delete: handle a document with no valid content offsets [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/258936 (https://phabricator.wikimedia.org/T121156) (owner: 10DLynch) [17:52:20] (03CR) 10Esanders: [C: 032] Fragment delete: handle a document with no valid content offsets [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/258936 (https://phabricator.wikimedia.org/T121156) (owner: 10DLynch) [17:52:30] edsanders: :-P [17:52:50] 10VisualEditor, 10VisualEditor-MediaWiki: With single edit tab enabled, VE loads directly from the history page with the wrong heading and subheading - https://phabricator.wikimedia.org/T121342#1878222 (10Jdforrester-WMF) p:5Triage>3Normal [17:55:28] Krenair: So… on Beta Cluster, now switching from VE->WT always gives me VE and never loads WT. [17:56:21] probably your patch [17:56:23] (03Merged) 10jenkins-bot: Fragment delete: handle a document with no valid content offsets [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/258936 (https://phabricator.wikimedia.org/T121156) (owner: 10DLynch) [17:56:24] Yeah. [17:56:56] although it works for me [17:57:03] on my local wiki [17:57:56] Yeah, for me too. [17:58:04] And it works fine logged out. [17:58:07] * James_F sighs. [17:59:13] (03PS1) 10Jforrester: Update VE core submodule to master (c9ab407) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/259030 [17:59:43] Let's merge ^^^ to test all Ed's work. [18:05:20] (03CR) 10DLynch: [C: 032] Update VE core submodule to master (c9ab407) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/259030 (owner: 10Jforrester) [18:09:38] (03Merged) 10jenkins-bot: Update VE core submodule to master (c9ab407) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/259030 (owner: 10Jforrester) [18:12:54] 10Citoid, 3Community-Tech-Sprint: Add Citoid support to RefToolbar gadget - https://phabricator.wikimedia.org/T114156#1878338 (10DannyH) [18:13:02] 10Citoid, 3Community-Tech-Sprint: Add Citoid support to RefToolbar gadget - https://phabricator.wikimedia.org/T114156#1686349 (10DannyH) [18:13:11] 10Citoid, 6Community-Tech-fixes, 3Community-Tech-Sprint: Add Citoid support to RefToolbar gadget - https://phabricator.wikimedia.org/T114156#1686349 (10DannyH) [18:14:20] Yay. [18:16:47] yeah, I think your commit broke it james [18:17:09] * James_F nods. [18:17:22] it uses veswitched=1 [18:17:41] no wait [18:17:43] veswitched=1 should trigger the wikitext editor (and switching back should drop it from the URL)? [18:17:45] I think it should still work [18:17:52] It works fine for logged-out users. [18:19:05] maybe your commit didn't fix anything [18:19:24] it just exposed an issue more [18:19:39] Perhaps. [18:19:41] :-( [18:22:29] the previous code was just hiding it better [18:26:00] still not sure why it doesn't occur locally [18:26:25] 10VisualEditor, 10VisualEditor-ContentEditable, 5WMF-deploy-2015-12-15_(1.27.0-wmf.9): Error "ve.dm.Document.getBranchNodeFromOffset(): offset -1 is out of bounds" appears and VE hangs after deleting a focusable node which is followed by another focusable no... - https://phabricator.wikimedia.org/T121156#1878398 [18:27:21] 10VisualEditor, 10VisualEditor-MediaWiki: On single edit tab wikis, if your browser is non-JS but your settings say VE you get a blank edit page and no way to fix it - https://phabricator.wikimedia.org/T121257#1878409 (10Jdforrester-WMF) a:5Jdforrester-WMF>3Krenair [Discussed in IRC; we need to have a JS-l... [18:35:50] 10VisualEditor, 10VisualEditor-MediaWiki, 10Wikimedia-Site-Requests: Enable single edit tab on test2 wiki and review - https://phabricator.wikimedia.org/T121421#1878431 (10Jdforrester-WMF) 3NEW a:3Jdforrester-WMF [18:37:29] 10VisualEditor, 10VisualEditor-MediaWiki, 5Patch-For-Review, 5WMF-deploy-2015-12-15_(1.27.0-wmf.9): On single edit tab wikis, switching from VE to WT does not always set the visualeditor-editor option - https://phabricator.wikimedia.org/T121122#1878446 (10Krenair) a:5Jdforrester-WMF>3Krenair Still seem... [18:41:50] 10VisualEditor, 6Design-Research: Not clear how to switch to VisualEditor - https://phabricator.wikimedia.org/T121032#1878466 (10Capt_Swing) I've noticed this too, and I think this change has the potential to confuse & inconvenience a lot of experienced users who are used to switching back and forth between VE... [18:48:56] 10VisualEditor, 6Community-Liaison, 6Editing-Analysis: Find out why the visual editor is so used at the Portuguese Wikipedia - https://phabricator.wikimedia.org/T115724#1878520 (10Elitre) I just noticed that https://pt.wikipedia.org/wiki/Wikip%C3%A9dia:Editor_Visual/Coment%C3%A1rios also contains more feedba... [18:49:32] James_F, oh, what is your tab pref in this beta wiki? [18:50:40] * Krenair goes to get dinner [18:51:55] Krenair: Remember. [19:00:02] (03CR) 10Gergő Tisza: "Not sure about {{notranslate}}. Isn't "--" language-specific? Hungarian uses an en dash for quotations, for example (which is what prompte" [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/258783 (https://phabricator.wikimedia.org/T26191) (owner: 10Paladox) [19:03:49] (03CR) 10Jforrester: "> Isn't "--" language-specific?" [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/258783 (https://phabricator.wikimedia.org/T26191) (owner: 10Paladox) [19:08:46] (03CR) 10Gergő Tisza: "In that case, why not make ~~~~ the default? A bot can create the MediaWiki pages on the existing wikis to avoid surprises." [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/258783 (https://phabricator.wikimedia.org/T26191) (owner: 10Paladox) [19:08:50] hello [19:09:32] any ideas about why a user at it.wp gets this ---> https://it.wikipedia.org/wiki/File:Wiki_Visual_Editor_Save_Button_Bug.JPG ? [19:10:37] on both Firefox/Win7 & Safari on Ipad (desktop site), with both skins. allegedly not happening when not logged in. [19:16:49] 1920 x 1080, zoom 125%, but I can't reproduce on FF. [19:21:36] (03CR) 10Paladox: "Which file would I need to change in mediawiki core to support this change." [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/258783 (https://phabricator.wikimedia.org/T26191) (owner: 10Paladox) [19:26:17] (03CR) 10Gergő Tisza: "includes/EditPage.php probably. You can see the core editor if you disable "Enable enhanced editing toolbar" under the Editing tab of your" [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/258783 (https://phabricator.wikimedia.org/T26191) (owner: 10Paladox) [19:35:18] Krenair: Beta Cluster is too broken to demo, I think. :-( [19:56:39] (03CR) 10Paladox: "Thanks. Found it. Will upload a patch in sec. Would I put the message in core instead of having it both in core and wikieditor or have bot" [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/258783 (https://phabricator.wikimedia.org/T26191) (owner: 10Paladox) [19:59:31] (03PS6) 10Paladox: Let the signature wikitext be over-ridden locally [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/258783 (https://phabricator.wikimedia.org/T26191) [20:00:23] (03CR) 10Paladox: "I've uploaded a patch to core for the same change at https://gerrit.wikimedia.org/r/#/c/259061/" [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/258783 (https://phabricator.wikimedia.org/T26191) (owner: 10Paladox) [20:02:54] (03PS1) 10Bartosz Dziewoński: ve.ui.MWMediaDialog: Make the dialog higher (600px) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/259069 [20:10:50] (03CR) 10Jforrester: [C: 032] ve.ui.MWMediaDialog: Make the dialog higher (600px) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/259069 (owner: 10Bartosz Dziewoński) [20:19:24] (03Merged) 10jenkins-bot: ve.ui.MWMediaDialog: Make the dialog higher (600px) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/259069 (owner: 10Bartosz Dziewoński) [20:20:07] James_F, :( [20:20:58] James_F, just happened to me locally though [20:35:55] 10VisualEditor, 10VisualEditor-MediaWiki, 6Editing-Analysis: Run experiment defaulting anonymous editors to the visual editor on the English Wikipedia - https://phabricator.wikimedia.org/T119269#1879046 (10Jdforrester-WMF) [20:36:00] 10VisualEditor, 10VisualEditor-MediaWiki, 7Design, 7Epic: Migrate wikis to use a single edit tab which has both visual and wikitext modes and allows on-the-fly switching between them - https://phabricator.wikimedia.org/T102398#1879047 (10Jdforrester-WMF) [20:36:04] 10VisualEditor, 10VisualEditor-MediaWiki, 6Editing-Analysis, 7Milestone: Run experiment defaulting anonymous editors to the visual editor on the English Wikipedia - https://phabricator.wikimedia.org/T119269#1822373 (10Jdforrester-WMF) [20:38:40] Krenair: :-( [20:40:32] 10VisualEditor, 10VisualEditor-MediaWiki, 10VisualEditor-MediaWiki-Links, 5WMF-deploy-2015-12-15_(1.27.0-wmf.9): Remove button appears on context menu for MW link nodes, but does not do anything - https://phabricator.wikimedia.org/T120705#1879055 (10Jdforrester-WMF) [20:46:09] (03PS1) 10Jforrester: Revert "DesktopArticleTarget: Don't abort in SET mode if veswitched is set" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/259078 [20:46:18] (03CR) 10Jforrester: [C: 032] "Totally breaks switching." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/259078 (owner: 10Jforrester) [20:46:45] 10VisualEditor: Consider renaming "Formula" to something more precise - https://phabricator.wikimedia.org/T121444#1879066 (10Whatamidoing-WMF) 3NEW [20:53:01] (03PS1) 10Alex Monk: Simplify some SET logic [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/259084 [20:53:31] (03Merged) 10jenkins-bot: Revert "DesktopArticleTarget: Don't abort in SET mode if veswitched is set" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/259078 (owner: 10Jforrester) [20:54:04] (03CR) 10Jforrester: [C: 032] "Sure." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/259084 (owner: 10Alex Monk) [20:54:22] thanks [20:56:25] Thank you. :-) [20:59:04] (03CR) 10jenkins-bot: [V: 04-1] Simplify some SET logic [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/259084 (owner: 10Alex Monk) [20:59:21] Meh. [20:59:22] * James_F fixes. [21:02:09] 10VisualEditor, 10VisualEditor-MediaWiki, 10VisualEditor-MediaWiki-Links, 7Verified, 5WMF-deploy-2015-12-15_(1.27.0-wmf.9): Remove button appears on context menu for MW link nodes, but does not do anything - https://phabricator.wikimedia.org/T120705#1879128 (10Ryasmeen) [21:05:42] 10VisualEditor: Remove button on link context menu does not work after adding label to a simple link - https://phabricator.wikimedia.org/T121448#1879133 (10Ryasmeen) 3NEW [21:06:51] wtf [21:06:53] cleared cookies and it unbroke [21:07:18] Logged in? [21:08:04] 'Cos cookies shouldn't make an impact there. [21:08:25] 10VisualEditor: Editing picture in table moves the picture to a different column - https://phabricator.wikimedia.org/T121449#1879146 (10JAufrecht) 3NEW [21:10:28] I was logged out [21:10:30] James_F, it's working for me now :/ [21:10:56] Krenair: Did you just update to https://gerrit.wikimedia.org/r/259078 ? [21:11:17] 10VisualEditor, 10VisualEditor-ContentEditable, 7Verified, 5WMF-deploy-2015-12-08_(1.27.0-wmf.8), 5WMF-deploy-2015-12-15_(1.27.0-wmf.9): TextState#getChangeTransaction throws exception on first change - https://phabricator.wikimedia.org/T120975#1879158 (10Ryasmeen) [21:11:27] (03PS2) 10Jforrester: Simplify some SET logic [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/259084 (owner: 10Alex Monk) [21:11:41] (03CR) 10Jforrester: [C: 032] Simplify some SET logic [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/259084 (owner: 10Alex Monk) [21:12:04] James_F, I don't have the revert on my local copy, no [21:12:11] Huh. [21:12:21] The revert fixed it for me locally. [21:12:26] And without it didn't. [21:12:29] (03PS3) 10Alex Monk: Simplify some SET logic [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/259084 [21:12:32] git bisect is a lovely thing. [21:13:01] (03CR) 10Jforrester: [C: 032] Simplify some SET logic [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/259084 (owner: 10Alex Monk) [21:13:21] I think your task is right that there is something wrong with how the preference/cookie is being set or some logic to check it [21:13:38] Yeah. :-( [21:13:45] having veswitched on the VE blacklist just hides the issue [21:13:59] Yes. [21:14:11] But 'hides' in this case means 'doesn't mean it's always broken'. [21:14:56] yes [21:15:00] I am trying to go after the underlying issue [21:15:07] Yeah. [21:15:10] which seems to appear and disappear in weird cases [21:15:33] I am /guessing/ that when we set the preference and immediately reload the page to switch to the wikitext editor, the preference setting doesn't happen. [21:15:55] that was my initial theory [21:16:10] and I did manage to reproduce the issue at some point [21:16:15] but then broke it again [21:17:06] can you still reproduce the issue? [21:17:17] (03Merged) 10jenkins-bot: Simplify some SET logic [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/259084 (owner: 10Alex Monk) [21:18:28] Krenair: RoanKattouw says we should wait for the promise from mw.Api and then navigate. [21:19:19] yes [21:19:26] if I can prove that is the issue, that is my plan [21:19:58] aha [21:20:07] Aha/ [21:20:23] I think I managed to re-break it [21:20:30] … yay? [21:20:36] by doing something no user would ever do [21:20:42] (hopefully) [21:21:31] There's also navigator.sendBeacon() but that doesn't work in any version of Safari or IE/Edge [21:21:34] http://caniuse.com/#feat=beacon [21:21:45] can sendBeacon post? [21:22:01] I used $.cookie to set a second VEE cookie, with the default path (i.e. /wiki instead of /), and managed to end up with two VEE cookies with different values. And it broke. [21:22:34] Yes, it posts [21:22:34] 10Citoid: Add scraping of PRISM tags to html-metadata node library - https://phabricator.wikimedia.org/T118636#1879201 (10Aklapper) [21:22:49] But it means you can't use mw.Api so you have to do everything manually [21:22:57] And if it comes back with badtoken you have no recourse [21:23:28] yeah, no thanks [21:23:39] :-) [21:24:30] can you check your cookies in the developer tools James_F? [21:24:35] The API is navigator.sendBeacon( url, postData ); where for postData you probably need to pass a query string-like string, and then the browser promises it'll send that POST request some time later [21:24:43] (it does then include a header saying how long it waited) [21:24:50] Krenair: They're clear. But also irrelevant; this is for logged-in behaviour. [21:25:09] (Clear or have exactly one.) [21:26:12] okay, and this is still with the broken VE->WT switching right? [21:31:56] 10VisualEditor, 10VisualEditor-MediaWiki, 10VisualEditor-MediaWiki-Templates, 7Design, and 2 others: Consider removing the extra asterisk for the required parameters inside the template dialog - https://phabricator.wikimedia.org/T107544#1879212 (10AndyTechGuy) a:3AndyTechGuy I claimed this task on the GC... [21:33:37] 10VisualEditor: [Regression pre-wmf.9] In Basic Reference dialog, typed texts are appearing overlapped with left margin - https://phabricator.wikimedia.org/T121450#1879215 (10Ryasmeen) 3NEW [21:55:59] 10VisualEditor: [Regression pre-wmf.9] In Basic Reference dialog, typed texts are appearing overlapped with left margin - https://phabricator.wikimedia.org/T121450#1879252 (10Ryasmeen) Happens for caption field in Media Settings dialog as well [22:11:42] 10VisualEditor: NEWSECTIONLINK and INDEX being added to articles - https://phabricator.wikimedia.org/T118796#1879292 (10Whatamidoing-WMF) "Per other tasks" means that this task was declined due to a reason that was explained at some other (unspecified) tasks. [22:32:00] (03PS1) 10Jforrester: Single Edit Tab: Set editor preference on switch via a session storage and a promise [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/259165 [22:32:14] Krenair: ^^^ Test please. Also, yeah, I know… [22:37:56] uh oh [22:38:23] 10Cite, 5Patch-For-Review: Changing text of Mediawiki:Cite error ref no key - https://phabricator.wikimedia.org/T115810#1879402 (10Aklapper) >>! In T115810#1855129, @darthbhyrava wrote: > Whom should I add as a reviewer to catalyse the process? :P @darthbhyrava: Very valid question! Does https://www.mediawiki... [22:39:14] (03CR) 10jenkins-bot: [V: 04-1] Single Edit Tab: Set editor preference on switch via a session storage and a promise [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/259165 (owner: 10Jforrester) [22:42:16] 10VisualEditor, 10VisualEditor-MediaWiki, 7Design, 7Epic, 5WMF-deploy-2015-12-15_(1.27.0-wmf.9): Change VE integration to only use one edit tab, to avoid user choice paralysis - https://phabricator.wikimedia.org/T58337#1879417 (10Ryasmeen) [22:42:18] 10VisualEditor, 10VisualEditor-MediaWiki, 5WMF-deploy-2015-12-15_(1.27.0-wmf.9): Switching to edit source giving blank page when I have option "Show me both editors" - https://phabricator.wikimedia.org/T120987#1879415 (10Ryasmeen) 5Resolved>3Open This is still happening, getting blank page while switchin... [23:01:17] I think we really need to get reliable steps to reproduce before we can do anything about this bug [23:06:50] 10VisualEditor, 10VisualEditor-MediaWiki, 5WMF-deploy-2015-12-15_(1.27.0-wmf.9): Switching to edit source giving blank page when I have option "Show me both editors" - https://phabricator.wikimedia.org/T120987#1879465 (10Ryasmeen) This also happens if you dont edit anything just click on "Edit source" right... [23:19:40] (03PS2) 10Jforrester: Single Edit Tab: Set editor preference on switch via a session storage and a promise [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/259165 [23:21:05] (03PS3) 10Jforrester: Single Edit Tab: Set switch editor preference via sessionStorage/promise [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/259165 (https://phabricator.wikimedia.org/T121122) [23:25:05] 10VisualEditor, 10VisualEditor-ContentEditable, 7Verified, 5WMF-deploy-2015-12-15_(1.27.0-wmf.9): Error "ve.dm.Document.getBranchNodeFromOffset(): offset -1 is out of bounds" appears and VE hangs after deleting a focusable node which is followed by another ... - https://phabricator.wikimedia.org/T121156#1879518 [23:26:23] (03CR) 10Alex Monk: "we need reliable steps to reproduce the bug" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/259165 (https://phabricator.wikimedia.org/T121122) (owner: 10Jforrester) [23:50:28] 10VisualEditor: Getting both the options even when "Always give me wikitext editor" is set - https://phabricator.wikimedia.org/T121460#1879568 (10Ryasmeen) 3NEW [23:52:09] 10VisualEditor: Getting both the options (VE and WT) for editing even when "Always give me wikitext editor" is set - https://phabricator.wikimedia.org/T121460#1879575 (10Ryasmeen) [23:55:44] Krenair: The whole point of the bug is it's unreliably reproducible. :-(