[00:25:27] (03PS1) 10Jforrester: Single Edit Tab: simplify logic; make 'prefer-wt' just disabled [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/259196 [01:55:14] James_F, I really can't do anything with it at the moment [01:55:32] Krenair: With https://gerrit.wikimedia.org/r/259165 ? Does it work for you? [01:55:44] Obviously, it works locally for me… :-) [01:55:46] It works for me without that [01:56:18] 100% of the time with switching VE->WT->VE without changes back and forth? [01:57:24] hm [01:57:26] now I think I've got something [01:57:31] only with discard changes? [01:57:48] Yeah. [01:59:44] Krenair: What about https://gerrit.wikimedia.org/r/259196 then? :-) Trying to make it simpler [02:00:59] Actually, no. [02:01:15] (03CR) 10Jforrester: [C: 04-1] "Bug with switching to VE on ?action=edit" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/259196 (owner: 10Jforrester) [02:07:03] I added console.log calls to setEditorPreference and getLastEditor [02:07:33] Set editor to: wikitext [02:07:33] Navigated to http://domain/wiki/Main_Page?action=edit&veswitched=1 [02:07:33] Last editor: visualeditor [02:07:49] * James_F nods. [02:07:52] On master? [02:08:16] it's master with Revert "DesktopArticleTarget: Don't abort in SET mode if veswitched is set" reverted [02:08:29] * James_F nods. [02:08:30] Yeah. [02:09:37] I'll try using promises a bit like in your commit [02:10:01] Do you get the same issue with my commit? If not, fix up and merge? [02:16:41] sigh [02:16:45] the problem has gone again [02:17:38] or maybe not [02:18:13] ... why am I seeing both tabs while SET is enabled and I don't have the multi-tab pref [02:18:36] Yeah, that's a different bug. [02:19:38] how is everything so much more broken than when I left it on friday [02:19:53] I don't know. [02:22:23] This is so frustrating [02:23:12] is this bug currently affecting you on http://visualeditor-switch.wmflabs.org/ James_F? [02:23:19] * James_F checks. [02:23:34] Which one? The two-edit-tabs-when-I-should-have-one one? [02:24:37] no [02:24:44] the other one that i'm trying to focus on [02:25:03] switching editors (discarding changes) sometimes just reloads the current one [02:25:11] Yeah. [02:25:46] I can't test when the double-tab comes up. [02:26:12] So… [02:26:35] what [02:28:01] ? [02:28:33] why can't you test it? [02:28:53] Because with two edit tabs shown, I have the existing two-edit-tabs behaviour. [02:29:30] Did you do something to the server? [02:29:37] Now I'm getting a single edit tab stably. [02:29:40] no [02:29:44] I didn't touch anything [02:29:48] * James_F sighs. [02:29:56] OK, now I just can't switch to wikitext at all. [02:30:14] it always shows VE? [02:30:44] Yeah. [02:31:18] this is logged in with remember-last, right? [02:31:36] Yes. [02:31:41] It loads VE in-place in the edit tab. [02:31:57] Click switch, navigates to action=edit, page is blank, then VE loads. [02:31:58] We seem to both be doing exactly the same thing [02:32:06] Yet we get completely different behaviour [02:32:14] What browser are you using? [02:32:18] chrome [02:32:21] Same. [02:32:23] Gah. [02:33:16] hmm [02:35:48] it's now showing a stable single tab [02:35:52] while I'm logged out [02:37:03] Krenair: https://dl.dropboxusercontent.com/u/17195534/Meh.mov [02:37:14] Krenair: Not 100% reproducible, but most times. [02:37:56] Maybe 95% of the time. [02:38:05] And with my patch, it seemed to never occur in my testing. [02:39:15] multiple tabs are back for me [02:40:46] :-( [02:40:55] Presumably it's a race condition. [02:41:10] The JS that adds the two tabs knows about two-tab config, though? [02:42:36] it's in a function that probably shouldn't be getting run [02:42:59] Maybe we should have it defensively check anyway. [02:43:01] Ohhh. [02:43:04] Wait a moment. [02:43:09] Wow [02:43:09] * James_F waits. [02:43:25] I screwed something up pretty badly [02:44:11] (03PS1) 10Alex Monk: Revert "Simplify some SET logic" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/259205 [02:44:36] Oh, I see. [02:44:36] Ha. [02:44:36] Revert or just fix? [02:44:53] I started with a revert commit, am going to change it a bit in PS2 [02:44:56] Kk. [02:45:35] This will probably hopefully fix the tabs [02:45:39] not sure about switching [02:45:41] * James_F nods. [02:49:11] (03PS2) 10Alex Monk: Fix up "Simplify some SET logic" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/259205 [02:50:22] (03PS3) 10Alex Monk: Fix up "Simplify some SET logic" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/259205 [02:51:48] that's now live on the labs instance [02:51:59] tabs should be working no [02:52:00] now* [02:52:00] (03CR) 10Jforrester: "Elses go with ifs. :-)" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/259205 (owner: 10Alex Monk) [02:52:08] (Yes.) [02:52:24] (03CR) 10Jforrester: [C: 032] Fix up "Simplify some SET logic" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/259205 (owner: 10Alex Monk) [02:52:53] Doesn't fix the VE->VE->VE->VE issue thought. [02:52:56] -t [02:53:11] So I've found that if you set prefer-ve, then switching from VE into WT is broken [02:53:24] unless you have veswitched on the list of parameters to suppress VE [02:53:32] which... makes sense :/ [02:53:43] * James_F nods. [02:53:55] Let's get remember-last working first. [02:53:57] given how it works [02:54:01] prefer-wt works fine, right? [02:54:07] two-tabs works fine, AFAICT. [02:54:14] Divide and conquer. :-) [02:56:18] I think I have got the issue to show itself again [02:56:24] not really sure which steps I took [02:56:40] :-( [02:56:47] (03Merged) 10jenkins-bot: Fix up "Simplify some SET logic" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/259205 (owner: 10Alex Monk) [02:56:54] Can you get to reproduce them with my patch? [02:56:56] hmm... pretty much just load VE -> try to switch to WT [02:57:21] Yeah. [02:57:55] I have my own patch that does some stuff similar to yours, but... not quite the same [02:58:08] Tsk. [02:58:13] but... [02:58:28] yeah, don't think it really works properly [02:59:23] In what way is it different? [02:59:31] (And might that cause the issue?) [03:00:37] well it starts working when I actually look at the console to see what it's doing, of course [03:00:45] Heisenbugs. [03:00:50] * James_F gives up. [03:00:57] I'm going for some (late) lunch. [03:00:58] Good night. [03:01:29] wow [03:01:32] lunch at 19:00? [03:01:36] and yeah, I should get some sleep [03:01:49] when you get a moment, try the one on the labs instance [03:02:29] my patch uses a promise but no sessionStorage etc. [03:04:03] This *seems* to work for me now, but I don't trust it [07:19:02] 10VisualEditor: Formula edits should be discarded if the dialog is cancelled - https://phabricator.wikimedia.org/T121488#1880079 (10Tchanders) 3NEW a:3Tchanders [07:23:24] 10VisualEditor: Formula edits should be discarded if the dialog is cancelled - https://phabricator.wikimedia.org/T121488#1880091 (10Tchanders) [08:01:14] (03PS1) 10DLynch: Annotation context items: expand the selection if no annotations [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/259216 (https://phabricator.wikimedia.org/T119923) [08:14:30] (03PS1) 10Gerrit Patch Uploader: Use module jquery.spinner for spinner on preview [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/259217 [08:14:33] (03CR) 10Gerrit Patch Uploader: "This commit was uploaded using the Gerrit Patch Uploader [1]." [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/259217 (owner: 10Gerrit Patch Uploader) [12:13:58] (03CR) 10Esanders: [C: 04-1] Annotation context items: expand the selection if no annotations (031 comment) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/259216 (https://phabricator.wikimedia.org/T119923) (owner: 10DLynch) [14:41:44] (03PS1) 10Esanders: ExtensionPreviewDialog: Use a deep copy when preparing sub-doc for editing [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/259253 (https://phabricator.wikimedia.org/T121488) [14:43:39] (03PS2) 10DLynch: Annotation context items: expand the selection if no annotations [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/259216 (https://phabricator.wikimedia.org/T119923) [14:48:53] (03PS1) 10Esanders: ve.dm.Document: Rename cloneSliceFromRange to shallowCloneFromRange [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/259254 [15:10:18] (03PS6) 10Esanders: [WIP] Edit mode switch: Show popup next to switch button [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/252345 [15:31:00] 10VisualEditor, 7Technical-Debt: ve.{ui,ce}.Surface#{enable,disable} should implement OO.ui.Widget#setDisabled - https://phabricator.wikimedia.org/T106908#1880831 (10Esanders) ve.ui.Surface is an OOUI element, not a widget. [15:31:38] sure [16:17:33] (03PS1) 10Esanders: [DEPRECATING CHANGE] ve.ui.Surface: Make an OO.ui.Widget and implement #setDisabled [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/259274 (https://phabricator.wikimedia.org/T106908) [16:30:01] James_F, I'm trying to get some university stuff done, but did you take a look at the labs instance with my patch on? [16:33:44] Krenair: Yes, sorry. [16:34:21] did it work? [16:35:11] In meeting. [16:36:19] ok [16:37:18] (Oy.) [16:54:45] (03PS2) 10Esanders: [DEPRECATING CHANGE] ve.ui.Surface: Make an OO.ui.Widget and implement #setDisabled [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/259274 (https://phabricator.wikimedia.org/T106908) [16:59:15] (03CR) 10jenkins-bot: [V: 04-1] [DEPRECATING CHANGE] ve.ui.Surface: Make an OO.ui.Widget and implement #setDisabled [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/259274 (https://phabricator.wikimedia.org/T106908) (owner: 10Esanders) [16:59:47] edsanders: Tests passing is nice. [17:00:07] (03PS3) 10Esanders: [DEPRECATING CHANGE] ve.ui.Surface: Make an OO.ui.Widget and implement #setDisabled [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/259274 (https://phabricator.wikimedia.org/T106908) [17:04:59] Krenair: Yeah, it seemed to work fine for me on that regard. Sometimes we're switching page and then loading VE, but that's an issue in master too. [17:05:28] shall I put that up for review then? [17:05:41] Go for it. [17:14:54] (03CR) 10Jforrester: [C: 032] [DEPRECATING CHANGE] ve.ui.Surface: Make an OO.ui.Widget and implement #setDisabled [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/259274 (https://phabricator.wikimedia.org/T106908) (owner: 10Esanders) [17:15:18] 10VisualEditor, 7Technical-Debt: ve.{ui,ce}.Surface#{enable,disable} should implement OO.ui.Widget#setDisabled - https://phabricator.wikimedia.org/T106908#1881044 (10Jdforrester-WMF) 5Open>3Resolved a:3Esanders [17:15:43] 10VisualEditor, 7Technical-Debt, 5WMF-deploy-2016-01-12_(1.27.0-wmf.10): ve.{ui,ce}.Surface#{enable,disable} should implement OO.ui.Widget#setDisabled - https://phabricator.wikimedia.org/T106908#1481321 (10Jdforrester-WMF) [17:21:54] (03Merged) 10jenkins-bot: [DEPRECATING CHANGE] ve.ui.Surface: Make an OO.ui.Widget and implement #setDisabled [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/259274 (https://phabricator.wikimedia.org/T106908) (owner: 10Esanders) [17:22:22] grr [17:22:27] the permissions in this are really messed up [17:22:32] Permissions? [17:25:17] file permissions [17:25:52] We pay attention to those? I thought we just set everything to the same? [17:26:27] 10VisualEditor, 10MediaWiki-General-or-Unknown, 6Multimedia, 5MW-1.27-release-notes, and 2 others: Show not logged in error before uploading to stash in mw.Upload.BookletLayout - https://phabricator.wikimedia.org/T115866#1881077 (10Jdforrester-WMF) [17:26:45] 10VisualEditor, 10VisualEditor-Media, 6Multimedia, 5Patch-For-Review: MWMediaDialog: exception "Local uploads are disabled" - https://phabricator.wikimedia.org/T119314#1881080 (10Jdforrester-WMF) [17:26:49] 10VisualEditor, 10MediaWiki-General-or-Unknown, 6Multimedia, 5MW-1.27-release-notes, 5WMF-deploy-2015-12-15_(1.27.0-wmf.9): Show not logged in error before uploading to stash in mw.Upload.BookletLayout - https://phabricator.wikimedia.org/T115866#1881078 (10Jdforrester-WMF) 5Open>3Resolved [17:30:31] James_F, they were messed up on my instance to the point that I couldn't do certain things in git [17:30:41] Ha. [17:30:43] That's… bad. [17:32:22] (03PS1) 10Alex Monk: Try to actually resolve visualeditor-editor preference setting when switching editors [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/259286 (https://phabricator.wikimedia.org/T121122) [17:32:23] yay [17:34:04] need to get rid of that function.bind [17:36:11] (03PS2) 10Alex Monk: Try to actually resolve visualeditor-editor preference setting when switching editors [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/259286 (https://phabricator.wikimedia.org/T121122) [17:36:14] how do newbies ever use git [17:39:14] By using a limited subset of commands which are pretty foolproof. [17:44:51] * James_F recalls last week's xkcd. [17:47:55] 10VisualEditor, 10VisualEditor-EditingTools, 10OOjs-UI, 10UI-Standardization, and 2 others: Gray for "inactive" elements in the toolbar is too light - https://phabricator.wikimedia.org/T89271#1881262 (10violetto) We're talking about using #888 for inactive elements [[ https://phabricator.wikimedia.org/T109... [17:59:14] Sorry, I'm one of those people who never had a problem with git commands. :-P [18:25:30] Kemayo: I stole lots of RoanKattouw's time until I knew git well, so I had an easy transition from svn. :-) [18:26:08] 10VisualEditor, 10VisualEditor-MediaWiki, 7Regression: [Regression] Subpage breadcrumbs not shown after saving the page with VisualEditor - https://phabricator.wikimedia.org/T97700#1881549 (10gpaumier) Friendly bump. This is a minor issue but still slightly annoying :) [18:26:19] Kemayo: Yup me too [18:26:43] I helped with our svn->git migration when I'd used git for at most 6 months [18:28:34] And pretty soon I was scripting a 90-commit interactive rebase [18:28:48] Which "condemned" me to years of helping everyone else with git :) [18:28:51] (03CR) 10Jforrester: [C: 032] Try to actually resolve visualeditor-editor preference setting when switching editors [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/259286 (https://phabricator.wikimedia.org/T121122) (owner: 10Alex Monk) [18:31:50] (03CR) 10Jforrester: [C: 031] "Needs rebase. Looks sane." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/258230 (https://phabricator.wikimedia.org/T120970) (owner: 10Alex Monk) [18:35:14] (03Merged) 10jenkins-bot: Try to actually resolve visualeditor-editor preference setting when switching editors [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/259286 (https://phabricator.wikimedia.org/T121122) (owner: 10Alex Monk) [18:45:35] (03PS4) 10Jforrester: Change tab text on server side [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/258230 (https://phabricator.wikimedia.org/T120970) (owner: 10Alex Monk) [18:47:12] (03PS5) 10Jforrester: DesktopArticleTarget: Change tab text on server side when possible [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/258230 (https://phabricator.wikimedia.org/T120970) (owner: 10Alex Monk) [18:47:17] (03CR) 10Jforrester: [C: 031] DesktopArticleTarget: Change tab text on server side when possible [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/258230 (https://phabricator.wikimedia.org/T120970) (owner: 10Alex Monk) [18:47:21] (03CR) 10jenkins-bot: [V: 04-1] DesktopArticleTarget: Change tab text on server side when possible [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/258230 (https://phabricator.wikimedia.org/T120970) (owner: 10Alex Monk) [18:48:49] (03CR) 10jenkins-bot: [V: 04-1] DesktopArticleTarget: Change tab text on server side when possible [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/258230 (https://phabricator.wikimedia.org/T120970) (owner: 10Alex Monk) [18:49:51] (03PS6) 10Jforrester: DesktopArticleTarget: Change tab text on server side when possible [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/258230 (https://phabricator.wikimedia.org/T120970) (owner: 10Alex Monk) [18:55:57] 10VisualEditor, 10VisualEditor-EditingTools: Galleries are not displaying correctly in VisualEditor (one image per row with large gaps, rather than multiple images per row) - https://phabricator.wikimedia.org/T121557#1881691 (10Whatamidoing-WMF) 3NEW [19:20:00] edsanders|away: CR on https://gerrit.wikimedia.org/r/258230 ? [19:32:40] So I've finally got VE stable, but something odd happens when I save, the edits don't appear immediately, it appears that you have to refresh the page to make it display [19:32:43] What'd I break? [19:39:55] 10VisualEditor, 10VisualEditor-EditingTools, 10MediaWiki-Gallery: Galleries are not displaying correctly in VisualEditor (one image per row with large gaps, rather than multiple images per row) - https://phabricator.wikimedia.org/T121557#1881887 (10Aklapper) [19:40:53] Ulfr: Hmm. Which version of MW? [19:41:28] ack, please resend [19:41:31] I middle clicked :( [19:41:40] Ulfr: Hmm. Which version of MW? [19:41:45] 1.25 [19:41:53] Going to go to 1.26 this evening [19:42:04] * James_F nods. [19:42:13] I haven't heard of this as an issue with 1.25 or 1.26. [19:42:21] But maybe there's something different about your setup? [19:42:24] Sorry. [19:42:33] Oh, probably lots of things. But this isn't a known issue? Fantastic. [19:44:15] 10VisualEditor, 10Phlogiston, 15User-JAufrecht: Forecast graphs should round up (so that 0.4 weeks doesn't show as 0 weeks, but as 1) - https://phabricator.wikimedia.org/T120721#1881910 (10JAufrecht) [19:47:13] 10VisualEditor, 10VisualEditor-EditingTools, 10MediaWiki-Gallery: Galleries are not displaying correctly in VisualEditor (one image per row with large gaps, rather than multiple images per row) - https://phabricator.wikimedia.org/T121557#1881915 (10TheDJ) This is due to: .ve-ce-documentNode { white-space: pr... [19:47:30] 10VisualEditor, 10VisualEditor-MediaWiki, 5WMF-deploy-2015-12-15_(1.27.0-wmf.9): On single edit tab wikis, switching from VE to WT does not always set the visualeditor-editor option - https://phabricator.wikimedia.org/T121122#1881917 (10Jdforrester-WMF) 5Open>3Resolved [19:47:33] 10VisualEditor, 10VisualEditor-MediaWiki, 7Design, 7Epic, 5WMF-deploy-2015-12-15_(1.27.0-wmf.9): Change VE integration to only use one edit tab, to avoid user choice paralysis - https://phabricator.wikimedia.org/T58337#1881919 (10Jdforrester-WMF) [19:55:16] 10VisualEditor, 10VisualEditor-MediaWiki, 6Community-Tech: HotCat doesn't load after saving a page in VisualEditor (must refresh/reload first) [AOI] - https://phabricator.wikimedia.org/T103285#1881948 (10Jdlrobson) [20:02:48] 10VisualEditor, 10VisualEditor-EditingTools, 10MediaWiki-Gallery: [Regression] Galleries are not displaying correctly in VisualEditor (one image per row with large gaps, rather than multiple images per row) due to wrapping CSS - https://phabricator.wikimedia.org/T121557#1881991 (10Jdforrester-WMF) p:5Triage... [20:03:05] 10VisualEditor, 10Math, 5Patch-For-Review: Formula edits should be discarded if the dialog is cancelled - https://phabricator.wikimedia.org/T121488#1881997 (10Jdforrester-WMF) p:5Triage>3Normal [20:03:37] 10VisualEditor, 10Math, 5Patch-For-Review: Formula edits should be discarded if the dialog is cancelled - https://phabricator.wikimedia.org/T121488#1880079 (10Jdforrester-WMF) [20:03:40] 10VisualEditor, 10VisualEditor-MediaWiki, 10Math, 7Epic, 7Milestone: [Objective] Improve support for math editing by improving the UX of the Math extension and researching its usability - https://phabricator.wikimedia.org/T118616#1882008 (10Jdforrester-WMF) [20:04:16] 10VisualEditor, 10VisualEditor-MediaWiki: On single edit tab wikis, sometimes getting both the options (VE and WT) for editing even when "Always give me wikitext editor" is set - https://phabricator.wikimedia.org/T121460#1882013 (10Jdforrester-WMF) p:5Triage>3High [20:04:46] 10VisualEditor, 10VisualEditor-MediaWiki: On single edit tab wikis, sometimes getting both the options (VE and WT) for editing even when "Always give me wikitext editor" is set - https://phabricator.wikimedia.org/T121460#1879568 (10Jdforrester-WMF) [20:04:51] 10VisualEditor, 10VisualEditor-MediaWiki, 7Design, 7Epic, 5WMF-deploy-2015-12-15_(1.27.0-wmf.9): Change VE integration to only use one edit tab, to avoid user choice paralysis - https://phabricator.wikimedia.org/T58337#1882020 (10Jdforrester-WMF) [20:05:37] James_F, https://phabricator.wikimedia.org/T121460 sounds like one of the bugs I fixed last night [20:05:56] 10VisualEditor, 10VisualEditor-MediaWiki, 10VisualEditor-MediaWiki-Media, 10VisualEditor-MediaWiki-References: [Regression wmf.9] In Basic Reference dialog or Media Caption dialog, typed texts are appearing overlapped with left margin - https://phabricator.wikimedia.org/T121450#1882024 (10Jdforrester-WMF)... [20:06:26] 10VisualEditor, 10VisualEditor-MediaWiki, 10VisualEditor-MediaWiki-Media, 10VisualEditor-MediaWiki-References: [Regression wmf.9] In Basic Reference dialog or Media Caption dialog, typed texts are appearing overlapped with left margin - https://phabricator.wikimedia.org/T121450#1879215 (10Jdforrester-WMF)... [20:07:00] 10VisualEditor, 10VisualEditor-DataModel, 10VisualEditor-Tables: Editing picture in table moves the picture to a different column - https://phabricator.wikimedia.org/T121449#1882033 (10Jdforrester-WMF) p:5Triage>3Normal [20:07:32] 10VisualEditor, 10Math: Consider renaming "Formula" to something more precise - https://phabricator.wikimedia.org/T121444#1882041 (10Jdforrester-WMF) p:5Triage>3Lowest [20:07:56] 10VisualEditor, 10VisualEditor-MediaWiki: On single edit tab wikis, sometimes getting both the options (VE and WT) for editing even when "Always give me wikitext editor" is set - https://phabricator.wikimedia.org/T121460#1882046 (10Krenair) @RYasmeen, please can you check this again? I was running into similar... [20:08:10] 10VisualEditor, 10VisualEditor-MediaWiki, 10VisualEditor-MediaWiki-Media, 6Multimedia: When a full image file name / file page title / file URL is entered in VE media dialog search, use that image directly - https://phabricator.wikimedia.org/T121354#1882048 (10Jdforrester-WMF) p:5High>3Normal [20:09:03] 10VisualEditor, 10VisualEditor-ContentEditable, 7Technical-Debt: ve.ce.Annotation methods missing documentation - https://phabricator.wikimedia.org/T121351#1882057 (10Jdforrester-WMF) [20:09:25] 10VisualEditor, 10VisualEditor-ContentEditable, 7Technical-Debt: ve.ce.Annotation methods missing documentation - https://phabricator.wikimedia.org/T121351#1882061 (10Jdforrester-WMF) p:5Triage>3Normal [20:10:06] 10VisualEditor, 10VisualEditor-ContentEditable: Cannot cursor out of a unicorned annotation - https://phabricator.wikimedia.org/T121357#1882065 (10Jdforrester-WMF) p:5Triage>3Normal [20:11:38] 10VisualEditor: Find and replace bar is too high in the vertical stacking - https://phabricator.wikimedia.org/T121317#1882082 (10Jdforrester-WMF) [20:11:40] 10VisualEditor, 10VisualEditor-MediaWiki, 5WMF-deploy-2015-12-15_(1.27.0-wmf.9): Educational popups overlap with toolbar dialogs, selection highlights - https://phabricator.wikimedia.org/T116577#1882083 (10Jdforrester-WMF) [20:12:27] 10VisualEditor, 10VisualEditor-ContentEditable, 7Technical-Debt: Abstract more selection handling by selection type - https://phabricator.wikimedia.org/T121347#1882110 (10Jdforrester-WMF) a:3Esanders [20:12:56] (03PS1) 10Alex Monk: SET: Always show wikitext editor on action=edit if multiple tabs are in use [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/259324 (https://phabricator.wikimedia.org/T120987) [20:13:25] 10VisualEditor: Find the phrase "ISBN" from ISBN magic links with Find and replace - https://phabricator.wikimedia.org/T121315#1882132 (10Jdforrester-WMF) p:5Triage>3Low [20:14:19] 10VisualEditor, 10VisualEditor-Tables: Be able to set a table to class= "sortable" - https://phabricator.wikimedia.org/T121267#1882137 (10Jdforrester-WMF) [20:14:21] 10VisualEditor, 10VisualEditor-MediaWiki, 10VisualEditor-Tables: Support sortable columns in tables - https://phabricator.wikimedia.org/T95189#1882138 (10Jdforrester-WMF) [20:15:03] 10VisualEditor, 10Math: Error "this.model is null" appears upon typing inside math inspector - https://phabricator.wikimedia.org/T121162#1882142 (10Jdforrester-WMF) p:5Triage>3Normal [20:15:43] 10VisualEditor, 10Math: In math inspector, when height is limited the editing section (with active cursor) is not visible - https://phabricator.wikimedia.org/T121150#1882156 (10Jdforrester-WMF) p:5Triage>3Normal [20:15:49] 10VisualEditor, 10Math: In math inspector, when height is limited the editing section (with active cursor) is not visible - https://phabricator.wikimedia.org/T121150#1870718 (10Jdforrester-WMF) [20:16:47] 10VisualEditor: Backspace before inserting a citation loses all changes (due to browser behavior) - https://phabricator.wikimedia.org/T121059#1882172 (10Jdforrester-WMF) Can you explain why your browser didn't show "Are you sure?"? Does it fail to do this in other contexts? That's a UBN; this is a WONTFIX. [20:16:54] 10VisualEditor: Backspace before inserting a citation loses all changes (due to browser behavior) - https://phabricator.wikimedia.org/T121059#1882173 (10Jdforrester-WMF) 5Open>3stalled [20:17:34] 10VisualEditor, 10VisualEditor-EditingTools, 10VisualEditor-MediaWiki-Links: Remove button on link context menu does not work after adding label to a simple link (because it's now the wrong context menu for the item) - https://phabricator.wikimedia.org/T121448#1882178 (10Jdforrester-WMF) p:5Triage>3Low [20:18:17] 10VisualEditor, 10VisualEditor-MediaWiki-Mobile, 7Browser-Support-Apple-Safari: Save button (for article edits) not working in iOS 9's Safari browser - https://phabricator.wikimedia.org/T121308#1882189 (10Jdforrester-WMF) p:5Triage>3High [20:20:08] 10Citoid, 10VisualEditor: Automatic cite feature in VisualEditor on English Wikipedia sets edition as "X edition ed." - https://phabricator.wikimedia.org/T121295#1882216 (10Jdforrester-WMF) 5Open>3stalled I think the template should probably be fixed, given we can't programmatically find string matches and... [20:22:06] 10VisualEditor, 10Math, 7Browser-Support-Firefox: The text box for formula editing is 0px high when you insert a formula for the first time in the math dialog in Firefox - https://phabricator.wikimedia.org/T121164#1882236 (10Jdforrester-WMF) p:5Triage>3High [20:22:38] 10VisualEditor, 10VisualEditor-MediaWiki, 7Accessibility, 7Browser-Support-Firefox: The keyboard shortcut doesn't trigger save in the Save dialog in Firefox [? for one user] - https://phabricator.wikimedia.org/T121183#1882244 (10Jdforrester-WMF) [20:23:38] 10VisualEditor, 10VisualEditor-MediaWiki, 7Accessibility, 7Browser-Support-Firefox: The keyboard shortcut doesn't trigger save in the Save dialog in Firefox [? for one user] - https://phabricator.wikimedia.org/T121183#1871853 (10Jdforrester-WMF) Can anyone else reproduce? Is this only on o... [20:24:38] 10VisualEditor, 10VisualEditor-MediaWiki: When editing an old revision in the visual editor, switching to the wikitext editor without changes moves you to the newest revision - https://phabricator.wikimedia.org/T120898#1882259 (10Jdforrester-WMF) p:5Triage>3Normal [20:28:37] 10VisualEditor: Trigger-happy options in VE - https://phabricator.wikimedia.org/T121111#1882296 (10Jdforrester-WMF) [20:28:38] 10VisualEditor: defeature __NOEDITSECTION__ from VE - https://phabricator.wikimedia.org/T100691#1882297 (10Jdforrester-WMF) [20:32:34] Krenair: Yeah. [20:32:38] Krenair: Will test and confirm. [20:37:30] 10VisualEditor: VisualEditor should fire an event on opening to allow other scripts to clean up - https://phabricator.wikimedia.org/T121050#1882387 (10Esanders) VE doesn't remove any DOM nodes, it hides the article content node and replaces it with Parsoid HTML content. If the edit is abandoned we reshow the ori... [20:52:20] 10VisualEditor, 10VisualEditor-MediaWiki: Flaky test "MWTransclusionNode getWikitext FAILED: Pending AJAX request" - https://phabricator.wikimedia.org/T116258#1882511 (10Krinkle) Still happening once or twice every day when merging commits in MediaWiki core. Again just now at 10VisualEditor, 10Phlogiston, 15User-JAufrecht: Adjust VE recently closed chart so that big spike doesn't distort the rest - https://phabricator.wikimedia.org/T120700#1882590 (10JAufrecht) 5Open>3Resolved [20:59:15] 10VisualEditor, 10VisualEditor-MediaWiki: On single edit tab wikis, sometimes getting both the options (VE and WT) for editing even when "Always give me wikitext editor" is set - https://phabricator.wikimedia.org/T121460#1882591 (10Ryasmeen) 5Open>3Resolved a:3Ryasmeen @Krenair, yeah looks like that patc... [20:59:18] 10VisualEditor, 10VisualEditor-MediaWiki, 7Design, 7Epic, 5WMF-deploy-2015-12-15_(1.27.0-wmf.9): Change VE integration to only use one edit tab, to avoid user choice paralysis - https://phabricator.wikimedia.org/T58337#1882594 (10Ryasmeen) [20:59:33] 10VisualEditor, 10VisualEditor-MediaWiki, 7Verified: On single edit tab wikis, sometimes getting both the options (VE and WT) for editing even when "Always give me wikitext editor" is set - https://phabricator.wikimedia.org/T121460#1882598 (10Ryasmeen) a:5Ryasmeen>3Krenair [21:11:40] 10VisualEditor, 6Editing-Department, 10MediaWiki-extensions-ContentTranslation, 7Design, 7Epic: [Epic] replace plain contenteditable with VisualEditor in ContentTranslation - https://phabricator.wikimedia.org/T105447#1882653 (10DannyH) [21:25:23] 10VisualEditor: defeature __NOEDITSECTION__ from VE - https://phabricator.wikimedia.org/T100691#1882765 (10IKhitron) 5declined>3Open [21:25:54] 10VisualEditor: defeature __NOEDITSECTION__ from VE - https://phabricator.wikimedia.org/T100691#1318523 (10IKhitron) I believe I should reopen the task, if the new one was merged here. [21:28:53] 10VisualEditor: defeature __NOEDITSECTION__ from VE - https://phabricator.wikimedia.org/T100691#1882779 (10Krenair) 5Open>3declined nope, getting merged into a declined task basically means declined [21:29:54] 10VisualEditor: defeature __NOEDITSECTION__ from VE - https://phabricator.wikimedia.org/T100691#1882788 (10IKhitron) So, the bug will remain forever? [21:44:22] 10VisualEditor, 10VisualEditor-EditingTools, 10MediaWiki-Gallery: [Regression] Galleries are not displaying correctly in VisualEditor (one image per row with large gaps, rather than multiple images per row) due to wrapping CSS - https://phabricator.wikimedia.org/T121557#1882828 (10TheDJ) {F3106100} Attaching... [21:53:43] 10WikiEditor, 10MediaWiki-extensions-CodeEditor, 7Community-Wishlist-Survey, 5Patch-For-Review: Code editor should not be cuffed to the enhanced toolbar - https://phabricator.wikimedia.org/T47850#1882849 (10TheDJ) There are several approaches that can be taken here: 1: Add something to the pile of preferen... [22:05:51] (03CR) 10Esanders: "FIXME: This causes https://phabricator.wikimedia.org/T121557" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/255931 (https://phabricator.wikimedia.org/T55931) (owner: 10Bartosz Dziewoński) [22:06:46] 10VisualEditor, 10VisualEditor-EditingTools, 10MediaWiki-Gallery: [Regression] Galleries are not displaying correctly in VisualEditor (one image per row with large gaps, rather than multiple images per row) due to wrapping CSS - https://phabricator.wikimedia.org/T121557#1882920 (10Esanders) Broken by https:/... [22:11:37] 10VisualEditor, 10VisualEditor-MediaWiki, 7Verified, 5WMF-deploy-2015-12-15_(1.27.0-wmf.9): On single edit tab wikis, sometimes getting both the options (VE and WT) for editing even when "Always give me wikitext editor" is set - https://phabricator.wikimedia.org/T121460#1882937 (10Jdforrester-WMF) [22:14:55] interesting... [22:15:03] phab didn't let me do that before [22:15:06] Do what? [22:15:34] nothing James_F [22:15:54] It didn't let you do nothing? :-) [22:16:06] 10VisualEditor, 10VisualEditor-EditingTools, 10MediaWiki-Gallery: [Regression] Galleries are not displaying correctly in VisualEditor (one image per row with large gaps, rather than multiple images per row) due to wrapping CSS - https://phabricator.wikimedia.org/T121557#1882958 (10matmarex) Interesting. The... [22:16:10] James_F, okay. I saw Ed move something on a workboard and wondered how he did it, given he's not in the edit policy [22:16:19] I guess they removed that requirement [22:16:43] I moved it back and forward again to test, and it let me do it [22:16:44] 10VisualEditor, 10VisualEditor-EditingTools, 10MediaWiki-Gallery: [Regression] Galleries are not displaying correctly in VisualEditor (one image per row with large gaps, rather than multiple images per row) due to wrapping CSS - https://phabricator.wikimedia.org/T121557#1882965 (10Jdforrester-WMF) >>! In T12... [22:16:52] Which workboard? [22:16:56] VisualEditor [22:17:13] Oh. [22:17:13] Huh. [22:17:13] That shouldn't be allowed. [22:17:18] lol [22:17:39] In fact, it's intentionally set up to stop even team members doing that. :-P [22:18:24] * Krenair rolls eyes [22:18:29] I'm sure your inbox is going to be so fun when you get back James_F [22:18:51] It is already. [22:19:05] well, ok [22:19:10] more fun [22:19:17] haha [22:20:54] 10VisualEditor, 10VisualEditor-MediaWiki, 7Design, 7Epic: Migrate wikis to use a single edit tab which has both visual and wikitext modes and allows on-the-fly switching between them - https://phabricator.wikimedia.org/T102398#1882986 (10Jdforrester-WMF) [22:20:56] 10VisualEditor, 10VisualEditor-MediaWiki-Mobile: [Regression] Save button (for article edits) not working in mobile VE - https://phabricator.wikimedia.org/T121308#1882987 (10Esanders) [22:20:58] 10VisualEditor, 10VisualEditor-MediaWiki, 10Wikimedia-Site-Requests, 5Patch-For-Review: Enable single edit tab on test2 wiki and review - https://phabricator.wikimedia.org/T121421#1882985 (10Jdforrester-WMF) 5Open>3Resolved [22:21:52] 10VisualEditor, 10VisualEditor-MediaWiki-Mobile: [Regression] Save button (for article edits) not working in mobile VE - https://phabricator.wikimedia.org/T121308#1875339 (10Esanders) Strange problem with RL. A whole bunch on modules aren't available on mobile: mw.loader.moduleRegistry['easy-deflate.core'] un... [22:21:55] Krinkle, https://phabricator.wikimedia.org/T121308 [22:22:05] (03CR) 10Jforrester: [C: 032] "Point." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/259324 (https://phabricator.wikimedia.org/T120987) (owner: 10Alex Monk) [22:24:01] 10VisualEditor, 10VisualEditor-MediaWiki-Mobile: [Regression] Save button (for article edits) not working in mobile VE - https://phabricator.wikimedia.org/T121308#1883007 (10Esanders) But I can't reproduce locally. [22:27:29] edsanders: looking [22:27:52] I know ContentTranslation did some stuff recently duplicating the easydeflate module [22:28:10] but other modules are missing, like unicodejs.wordbreak [22:29:21] (03Merged) 10jenkins-bot: SET: Always show wikitext editor on action=edit if multiple tabs are in use [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/259324 (https://phabricator.wikimedia.org/T120987) (owner: 10Alex Monk) [22:30:03] Krinkle, just enabled ContentTranslation on my local wiki and getting the same errors *sigh* [22:30:22] Hm.. [22:31:04] edsanders: probably because 'targets' is not specified in theirs [22:31:13] Also, they should not be unconditionally defining them [22:31:14] thanks [22:31:24] Must be same conditional as we do with ULS [22:31:33] RL throws a warning server side for duplicate registration [22:31:47] it used to even be a fatal exception, but Ori and I removed that to fail more gracefully [22:33:21] 10VisualEditor, 10VisualEditor-MediaWiki, 7Design, 7Epic, 5WMF-deploy-2015-12-15_(1.27.0-wmf.9): Change VE integration to only use one edit tab, to avoid user choice paralysis - https://phabricator.wikimedia.org/T58337#1883034 (10Krenair) [22:36:45] 10VisualEditor, 10VisualEditor-MediaWiki-Mobile: [Regression] Save button (for article edits) not working in mobile VE - https://phabricator.wikimedia.org/T121308#1883040 (10Esanders) p:5High>3Unbreak! [22:40:03] Krinkle, https://gerrit.wikimedia.org/r/#/c/259417/ [22:40:30] yeah it's because CX are re-implementing all of VE's features... [22:40:58] did you reproduce that bug edsanders? [22:41:09] (the mobile save button issue) [22:41:11] yeah [22:41:17] you have to install ContentTranslation [22:41:34] see patch ^^^ [22:41:40] edsanders: And this fixed it? [22:41:44] yeah [22:41:49] I'm backporting to prod in a few minutes [22:53:30] * James_F sighs. [22:53:46] Krinkle: I say again, let's just ignore target stuff in RL. [23:02:27] hmm.. [23:02:28] [23:02:44] that's not supposed to be in the wikitext :) [23:05:25] 10VisualEditor: data-ve-clipboard-key attribute added in wikitable - https://phabricator.wikimedia.org/T121588#1883127 (10TheDJ) 3NEW [23:20:42] 10VisualEditor, 10VisualEditor-EditingTools, 10MediaWiki-Gallery: [Regression] Galleries are not displaying correctly in VisualEditor (one image per row with large gaps, rather than multiple images per row) due to wrapping CSS - https://phabricator.wikimedia.org/T121557#1883267 (10Esanders) The real problem... [23:26:57] 10VisualEditor: [Regression wmf 9] Context menu for template is broken , showing no "Edit" button and template name is showing up as "Item" - https://phabricator.wikimedia.org/T121596#1883276 (10Ryasmeen) 3NEW [23:29:14] 10VisualEditor, 10VisualEditor-EditingTools, 10MediaWiki-Gallery: [Regression] Galleries are not displaying correctly in VisualEditor (one image per row with large gaps, rather than multiple images per row) due to wrapping CSS - https://phabricator.wikimedia.org/T121557#1883288 (10matmarex) I do think that `... [23:31:20] edsanders: Should be fixed now in prod, Can you confirm? [23:31:55] confirmed [23:32:13] 10VisualEditor: [Regression wmf 9] Context menu for template and code block is broken , showing no "Edit" button and template name is showing up as "Item" - https://phabricator.wikimedia.org/T121596#1883309 (10Ryasmeen) [23:32:29] 10VisualEditor, 10VisualEditor-MediaWiki-Mobile, 5Patch-For-Review: [Regression] Save button (for article edits) not working in mobile VE - https://phabricator.wikimedia.org/T121308#1883311 (10Esanders) 5Open>3Resolved a:3Esanders [23:34:05] 10VisualEditor: [Regression wmf .9] Context menu for template and code block is broken , showing no "Edit" button and template name is showing up as "Item" - https://phabricator.wikimedia.org/T121596#1883276 (10Ryasmeen) [23:47:53] "VE is adding infoboxes without newlines." [23:48:03] 10VisualEditor: On Single Edit tab wikis, Section edit link shows both "Edit" and "Edit Source" option , after saving an edit using VisualEditor while having preference "Remember my last editor" and "Always VE" - https://phabricator.wikimedia.org/T121599#1883334 (10Ryasmeen) 3NEW [23:48:06] was that where the "format" option of TemplateData was for ?