[00:04:54] 10VisualEditor: Remove non-requested human testicles from user test pages - https://phabricator.wikimedia.org/T121613#1886439 (10Krenair) >>! In T121613#1886389, @Deskana wrote: > A simple way to avert this problem is not to pre-populate the search field of the image box with the title of the page you're on. I d... [00:14:21] 10VisualEditor: Remove non-requested human testicles from user test pages - https://phabricator.wikimedia.org/T121613#1886478 (10Esanders) @Deskana That would solve this particular case - but there is probably a more general bug for the discovery team about serving inappropriate images for wrong-language searche... [00:14:36] 10VisualEditor: Remove non-requested human testicles from user test pages - https://phabricator.wikimedia.org/T121613#1886480 (10Deskana) >>! In T121613#1886439, @Krenair wrote: > I don't think that really solves much, all it does is hide the problem behind a 'search' button :/ You're right, it doesn't solve it... [00:14:38] 10VisualEditor, 10VisualEditor-MediaWiki-Media: Show a user's recent uploads in the MW insert media dialog - https://phabricator.wikimedia.org/T62398#1886482 (10Esanders) [00:14:39] 10VisualEditor: Remove non-requested human testicles from user test pages - https://phabricator.wikimedia.org/T121613#1886481 (10Esanders) [00:15:55] (03PS12) 10Esanders: WIP Show recent uploads in MWMediaSearchWidget [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/210831 (https://phabricator.wikimedia.org/T62398) (owner: 10MarkAHershberger) [00:19:29] (03CR) 10jenkins-bot: [V: 04-1] WIP Show recent uploads in MWMediaSearchWidget [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/210831 (https://phabricator.wikimedia.org/T62398) (owner: 10MarkAHershberger) [00:24:20] 10VisualEditor: Remove non-requested human testicles from user test pages - https://phabricator.wikimedia.org/T121613#1886516 (10Deskana) >>! In T121613#1886478, @Esanders wrote: > @Deskana That would solve this particular case - but there is probably a more general bug for the discovery team about serving inapp... [01:01:50] 10VisualEditor: On Single Edit tab wikis, Section edit link shows both "Edit" and "Edit Source" option , after saving an edit using VisualEditor while having preference "Remember my last editor" and "Always VE" - https://phabricator.wikimedia.org/T121599#1886622 (10Ryasmeen) [01:15:57] 10Citoid, 10VisualEditor, 5Patch-For-Review: Add ability to request base types in citoid, and offer use of both in extension for backwards compatibility until all templateData has been updated. - https://phabricator.wikimedia.org/T114515#1886664 (10kaldari) @Mvolz: Yeah, I see what you mean. I wonder if it w... [01:17:42] 10VisualEditor, 7I18n: Remove non-requested English matches of human testicles from user test pages on Portuguese Wikipedia - https://phabricator.wikimedia.org/T121613#1886668 (10jayvdb) p:5Triage>3High [01:19:36] 10VisualEditor, 7I18n: Remove non-requested English matches of human testicles from user test pages on Portuguese Wikipedia - https://phabricator.wikimedia.org/T121613#1886680 (10Krenair) p:5High>3Triage [01:47:14] 10VisualEditor, 7I18n: Remove non-requested English matches of human testicles from user test pages on Portuguese Wikipedia - https://phabricator.wikimedia.org/T121613#1886728 (10Teles) >>! In T121613#1886384, @Aklapper wrote: >>>! In reply to T121613#1886358: > > **[[ https://www.mediawiki.org/wiki/Bug_manag... [02:15:27] 10VisualEditor, 10VisualEditor-MediaWiki, 7Accessibility, 7Browser-Support-Firefox: The keyboard shortcut doesn't trigger save in the Save dialog in Firefox [? for one user] - https://phabricator.wikimedia.org/T121183#1886756 (10APerson) It's not a gadget's fault; I could reproduce the bug... [02:19:47] 10VisualEditor: On Single Edit tab wikis, Section edit link shows both "Edit" and "Edit Source" option , after saving an edit using VisualEditor while having preference "Remember my last editor" and "Always VE" - https://phabricator.wikimedia.org/T121599#1886758 (10Krenair) Interesting. After saving, we just cal... [02:30:37] 10VisualEditor: On Single Edit tab wikis, Section edit link shows both "Edit" and "Edit Source" option , after saving an edit using VisualEditor while having preference "Remember my last editor" and "Always VE" - https://phabricator.wikimedia.org/T121599#1886765 (10Krenair) Ah, and then try to do some magic that... [02:35:29] (03PS1) 10Alex Monk: SET: Don't try to do any client-side section link magic if we're not supposed to. [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/259631 (https://phabricator.wikimedia.org/T121599) [02:37:14] 10VisualEditor, 10VisualEditor-MediaWiki, 7Design, 7Epic, 5WMF-deploy-2015-12-15_(1.27.0-wmf.9): Change VE integration to only use one edit tab, to avoid user choice paralysis - https://phabricator.wikimedia.org/T58337#1886771 (10Krenair) [02:37:17] 10VisualEditor, 10VisualEditor-MediaWiki, 5Patch-For-Review, 5WMF-deploy-2016-01-12_(1.27.0-wmf.10): On single edit tab wikis, if the user has a 've always' preference, there's a FOUC from 'edit' to 'edit source' on non-VE namespaces - https://phabricator.wikimedia.org/T120970#1886769 (10Krenair) 5Open>... [02:37:26] 10VisualEditor, 5Patch-For-Review: On Single Edit tab wikis, Section edit link shows both "Edit" and "Edit Source" option , after saving an edit using VisualEditor while having preference "Remember my last editor" and "Always VE" - https://phabricator.wikimedia.org/T121599#1886772 (10Krenair) a:3Krenair [02:37:53] 10VisualEditor, 5Patch-For-Review: On Single Edit tab wikis, Section edit link shows both "Edit" and "Edit Source" option , after saving an edit using VisualEditor while having preference "Remember my last editor" and "Always VE" - https://phabricator.wikimedia.org/T121599#1883334 (10Krenair) [02:37:58] 10VisualEditor, 10VisualEditor-MediaWiki, 7Design, 7Epic, 5WMF-deploy-2015-12-15_(1.27.0-wmf.9): Change VE integration to only use one edit tab, to avoid user choice paralysis - https://phabricator.wikimedia.org/T58337#604549 (10Krenair) [03:35:51] There are a couple of recent posts on mediawiki-l that could use a VE developer's feedback. "MediaWiki 1.26 Visual Editor question" - https://lists.wikimedia.org/pipermail/mediawiki-l/2015-December/045107.html - and "Parsoid and Visual Editor over HTTPS" - https://lists.wikimedia.org/pipermail/mediawiki-l/2015-December/045112.html [03:46:13] I don't know why they feel the need to connect from their MW to their parsoid over HTTPS [05:17:38] Uh, I'm trying to find the "Ori Livneh mind control" ticket and totally failing. Does anyone remember which one that was? [05:19:07] if someone could add the link to https://www.mediawiki.org/w/index.php?title=Wikimedia_User_Interface%2FUse_cases%2FLoading_Indicators&action=historysubmit&type=revision&diff=1965949&oldid=1963110, that would be appreciated [05:26:09] found itttt https://phabricator.wikimedia.org/T95137 [10:06:51] 10VisualEditor, 7I18n: Create a more neutral warning message when leaving VE edit mode - https://phabricator.wikimedia.org/T121754#1887117 (10Trizek-WMF) 3NEW [11:25:03] 10VisualEditor, 7I18n: Remove non-requested English matches of human testicles from user test pages on Portuguese Wikipedia - https://phabricator.wikimedia.org/T121613#1887229 (10Thryduulf) One way around this /might/ be to search not on image title but on image description in the local language. i.e. for user... [12:02:49] (03CR) 10Esanders: Single Edit Tab: Set switch editor preference via sessionStorage/promise (031 comment) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/259165 (https://phabricator.wikimedia.org/T121122) (owner: 10Jforrester) [12:31:02] (03PS13) 10Esanders: WIP Show recent uploads in MWMediaSearchWidget [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/210831 (https://phabricator.wikimedia.org/T62398) (owner: 10MarkAHershberger) [12:33:39] (03CR) 10jenkins-bot: [V: 04-1] WIP Show recent uploads in MWMediaSearchWidget [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/210831 (https://phabricator.wikimedia.org/T62398) (owner: 10MarkAHershberger) [12:57:27] (03PS14) 10Esanders: WIP Show recent uploads in MWMediaSearchWidget [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/210831 (https://phabricator.wikimedia.org/T62398) (owner: 10MarkAHershberger) [13:00:26] (03Abandoned) 10Alex Monk: Single Edit Tab: Set switch editor preference via sessionStorage/promise [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/259165 (https://phabricator.wikimedia.org/T121122) (owner: 10Jforrester) [13:44:52] (03CR) 10Bartosz Dziewoński: [C: 031] "Thanks." [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/259488 (https://phabricator.wikimedia.org/T121557) (owner: 10Esanders) [13:52:43] 10VisualEditor, 10VisualEditor-MediaWiki-Media, 6Multimedia, 5Patch-For-Review: Show a user's recent uploads in the MW insert media dialog - https://phabricator.wikimedia.org/T62398#1887451 (10matmarex) [13:57:05] (03CR) 10Bartosz Dziewoński: "This seems to always just show my recent uploads, and ignore the search field. I think adding this as a new tab "My uploads" would be fine" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/210831 (https://phabricator.wikimedia.org/T62398) (owner: 10MarkAHershberger) [14:04:12] (03CR) 10Bartosz Dziewoński: [C: 032] "Ah, let's do it, it should be fine. This will need some tweaks in pullthrough to VE-MW for the new CSS file, right?" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/259488 (https://phabricator.wikimedia.org/T121557) (owner: 10Esanders) [14:07:16] (03PS1) 10Zfilipin: [BrowserTest] Update mediawiki_selenium Ruby gem to the latest version [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/259685 (https://phabricator.wikimedia.org/T114241) [14:09:37] (03Merged) 10jenkins-bot: Move white-space:pre-wrap hack to ContentBranchNode [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/259488 (https://phabricator.wikimedia.org/T121557) (owner: 10Esanders) [14:18:02] (03CR) 10Esanders: "Still WIP, rebasing a years worth of changes and refactoring. UX is tbd." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/210831 (https://phabricator.wikimedia.org/T62398) (owner: 10MarkAHershberger) [15:46:05] 10VisualEditor, 7I18n: Remove non-requested English matches of human testicles from user test pages on Portuguese Wikipedia - https://phabricator.wikimedia.org/T121613#1887661 (10Pginer-WMF) Anticipating user personal uploads seems a good idea when adding an image that you recently uploaded. I think we could i... [16:16:26] 10VisualEditor: defeature __NOEDITSECTION__ from VE - https://phabricator.wikimedia.org/T100691#1887696 (10eranroz) >>! In T100691#1882788, @IKhitron wrote: > So, the bug will remain forever? Yes - unless you convince product owner/devs that it is bug and this should be removed. I doubt you can find a more convi... [16:21:46] 10VisualEditor, 7Wikimedia-log-errors: Undefined property stdClass::$name in VisualEditorDataModule - https://phabricator.wikimedia.org/T121768#1887700 (10demon) 3NEW [16:27:55] 10VisualEditor, 7Wikimedia-log-errors: Undefined property stdClass::$name in VisualEditorDataModule - https://phabricator.wikimedia.org/T121768#1887731 (10Krenair) We need to know which wiki this is coming from. [16:39:05] 10VisualEditor, 7Browser-Tests, 5Patch-For-Review: Delete or fix failed VisualEditor browsertests Jenkins jobs - https://phabricator.wikimedia.org/T94162#1887752 (10zeljkofilipin) a:5zeljkofilipin>3None [16:43:23] 10VisualEditor, 7Wikimedia-log-errors: Undefined property stdClass::$name in VisualEditorDataModule - https://phabricator.wikimedia.org/T121768#1887761 (10Krenair) I made a custom mwgrep to list all of the wikis which have a MediaWiki:visualeditor-cite-tool-definition.json page. I then checked through them man... [16:44:32] 10VisualEditor, 7Wikimedia-log-errors: Undefined property stdClass::$name in VisualEditorDataModule - https://phabricator.wikimedia.org/T121768#1887773 (10demon) Wiki is not...logged? Here's the full JSON from a sample entry: ``` { "_index": "logstash-2015.12.17", "_type": "hhvm", "_id": "AVGwwgp3lAIL90Z... [16:44:50] (03CR) 10MarkAHershberger: "I'd love to use this, but I'm afraid my understanding of VE's innards isn't up to snuff. How would you recommend I approach this?" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/210831 (https://phabricator.wikimedia.org/T62398) (owner: 10MarkAHershberger) [16:45:45] 10VisualEditor, 7Wikimedia-log-errors: Undefined property stdClass::$name in VisualEditorDataModule - https://phabricator.wikimedia.org/T121768#1887776 (10Krenair) And the first error in the log is just two minutes after that was created. I'll make a patch to have VE ignore such invalid definitions and fix the... [16:46:37] 10VisualEditor, 7Wikimedia-log-errors: Undefined property stdClass::$name in VisualEditorDataModule - https://phabricator.wikimedia.org/T121768#1887777 (10demon) That makes sense. Thanks! [16:48:56] 10VisualEditor, 7I18n: Remove non-requested English matches of human testicles from user test pages on Portuguese Wikipedia - https://phabricator.wikimedia.org/T121613#1887779 (10matmarex) >>! In T121613#1886358, @Teles wrote: > If there isn't a way to improve searching, I suggest to rename local page to a les... [16:49:23] (03PS1) 10Alex Monk: Avoid checking non-set keys in user-defined data [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/259738 (https://phabricator.wikimedia.org/T121768) [16:49:33] 10VisualEditor, 5Patch-For-Review, 7Wikimedia-log-errors: Undefined property stdClass::$name in VisualEditorDataModule - https://phabricator.wikimedia.org/T121768#1887783 (10Krenair) a:3Krenair [16:52:33] 10VisualEditor, 5Patch-For-Review, 7Wikimedia-log-errors: Undefined property stdClass::$name in VisualEditorDataModule - https://phabricator.wikimedia.org/T121768#1887789 (10Krenair) https://fo.wikipedia.org/w/index.php?title=MediaWiki:Visualeditor-cite-tool-definition.json&diff=331365&oldid=331188 [16:52:49] 10VisualEditor, 5Patch-For-Review, 7Wikimedia-log-errors: Undefined property stdClass::$name in VisualEditorDataModule - https://phabricator.wikimedia.org/T121768#1887790 (10Krenair) So the errors should have stopped, but leaving this open until the patch is merged. [17:01:20] 10VisualEditor, 5Patch-For-Review, 7Wikimedia-log-errors: Undefined property stdClass::$name in VisualEditorDataModule - https://phabricator.wikimedia.org/T121768#1887811 (10demon) Can confirm errors have stopped. Thanks for quickly figuring this out :) [17:21:41] 10VisualEditor: defeature __NOEDITSECTION__ from VE - https://phabricator.wikimedia.org/T100691#1887859 (10IKhitron) Did you mean display:none, @eranroz? [17:24:21] Hello [17:26:07] I'm looking for a good Wysiwyg to install but I havent found any good install instructions. Here is where I've been looking https://www.mediawiki.org/wiki/Extension:WYSIWYG#Mediawiki_1.22.2B_and_.236_bundle_of_Download_-section and it doesnt seem to be as straight forward as installing an extension. [17:26:17] am I just missing somethign [17:30:46] this is the channel for VisualEditor, not Extension:WYSIWYG [17:32:05] 10VisualEditor, 10Parsoid: Parsoid creates incorrect wikitext by letting a user remove the newline between template and the start of a heading - https://phabricator.wikimedia.org/T105745#1887873 (10ssastry) 5Open>3Resolved [17:32:45] 10VisualEditor, 10Parsoid, 5Patch-For-Review: In complex multi-template scenarios, preserve wikitext newline constraints during html->wt of edited content - https://phabricator.wikimedia.org/T107818#1887874 (10ssastry) 5Open>3Resolved [17:45:33] (03CR) 10Legoktm: [C: 032] Avoid checking non-set keys in user-defined data [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/259738 (https://phabricator.wikimedia.org/T121768) (owner: 10Alex Monk) [17:49:15] Randy____, are you looking for advice on whether VisualEditor is suitable for your needs, and how to install it? That info is at https://www.mediawiki.org/wiki/Extension:VisualEditor [17:49:45] (03Merged) 10jenkins-bot: Avoid checking non-set keys in user-defined data [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/259738 (https://phabricator.wikimedia.org/T121768) (owner: 10Alex Monk) [17:57:18] 10VisualEditor, 10Graph: VE GraphNode tests are failing - https://phabricator.wikimedia.org/T121638#1888044 (10ferdbold) How is this possible? Doesn't jenkins run the tests before trying to merge? [18:09:18] 10VisualEditor, 10Parsoid: Parsoid removes newlines between block elements when content is inserted between them - https://phabricator.wikimedia.org/T119789#1888107 (10ssastry) {T86271} has been deployed and this looks like a similar problem. I am going to resolve this for that reason. [18:23:15] (03PS1) 10Alex Monk: SET: Set user's editor to wikitext if the browser doesn't do JS [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/259771 (https://phabricator.wikimedia.org/T121257) [19:27:25] Getting this error message on just a single page: Error loading data from server: HTTP 0 [19:27:52] The page is rather long, so I suspect it's a time out... [19:28:17] Is there anything I can do to try and track that down further? [19:28:18] link? [19:28:24] private wiki [19:28:58] wikimedia hosted? [19:29:37] Nope, internal company wiki. [19:30:15] Long is ~ 834,000 bytes [19:32:24] longer than enwiki's longest page... [19:32:53] which does load in VE [19:32:54] eventually [19:33:06] ( https://en.wikipedia.org/wiki/List_of_law_clerks_of_the_Supreme_Court_of_the_United_States?veaction=edit ) [19:33:15] 801,914 bytes [19:34:41] it eventually loads if I go straight to parsoid, just takes a while [21:11:38] `Chromium 47.0.2526 (Ubuntu 0.0.0) ve.dm.MWTransclusionNode getWikitext FAILED` is showing up again - blocking merges in MobileFrontend :( [21:11:47] anyone seen that elsewhere? [21:24:15] 10VisualEditor, 10Graph: VE GraphNode tests are failing - https://phabricator.wikimedia.org/T121638#1888668 (10Esanders) I think the graph extension isn't part of the CI test build. [21:50:02] 10VisualEditor, 10VisualEditor-MediaWiki, 7Documentation: Re-write visualeditor-dialog-meta-settings-index-help to be more accurate - https://phabricator.wikimedia.org/T121790#1888718 (10Krenair) [21:59:16] 10VisualEditor, 10VisualEditor-CopyPaste: VisualEditor: Rich content copied from sub-documents (image captions, references, etc.) down-cast to plain text when the sub-document is closed - https://phabricator.wikimedia.org/T53725#1888765 (10Pols12) Today it seems to work well. (Firefox 42) Or I have not undestood. [22:35:44] 10Citoid, 10VisualEditor, 5Patch-For-Review, 5WMF-deploy-2016-01-12_(1.27.0-wmf.10): Add ability to request base types in citoid, and offer use of both in extension for backwards compatibility until all templateData has been updated. - https://phabricator.wikimedia.org/T114515#1889042 (10kaldari) @Mvolz: I... [23:22:48] https://en.wikipedia.org/w/index.php?title=User:Legoktm&veaction=edit&debug=1 doesn't load VE? [23:23:03] legoktm: I don't think VE is enabled in the user namespace [23:23:17] but https://en.wikipedia.org/w/index.php?title=User:Legoktm&veaction=edit works fine [23:23:21] loads it for me [23:23:33] hrm. [23:23:44] in any case, leaving feedback on enwp is broken :S [23:23:47] > TypeError: api is undefined [23:24:00] and I'm pretty sure that's my fault. [23:24:06] lol [23:24:43] ok, it's working in chromium with debug=1, weeeeird. [23:24:52] er, VE is. unsure about feedback [23:25:03] I tested using debug=1 [23:25:19] But for feedback: [23:25:19] Exception in load-callback in module mediawiki.feedback: [23:25:24] TypeError: Cannot read property 'get' of undefined TypeError: Cannot read property 'get' of undefined(�) [23:26:25] Krenair: its either https://gerrit.wikimedia.org/r/#/c/258188/ or https://gerrit.wikimedia.org/r/258186 [23:26:47] legoktm and RoanKattouw's fault then :D [23:27:24] https://gerrit.wikimedia.org/r/#/c/258186/1/resources/src/mediawiki.messagePoster/mediawiki.messagePoster.factory.js [23:27:28] api = mw.Api();? [23:27:35] isn't there supposed to be a 'new' in there? [23:27:46] uhhhh [23:28:05] mw.Api(); [23:28:05] undefined [23:28:13] new mw.Api(); [23:28:13] mw.Api {defaults: Object, requests: Array[0]} [23:28:35] lol [23:28:36] wow [23:28:48] * legoktm facepalms [23:28:52] * RoanKattouw hangs head in shame for +2ing that [23:30:54] I'll put it up for SWAT [23:31:09] And no one will tell James? ;) [23:32:13] James will probably see it anyway, but sure [23:33:28] haha [23:38:17] someone here who i can talk to about templatedata?