[00:28:49] hey, anybody around who could help me with setting up VE with MW 1.26? [00:29:40] gwicke: IIRC if you have a VRS binding for RESTbase it should just work, I think [00:29:44] ? [00:29:45] * RoanKattouw looks at his settings [00:29:58] I'm creating a docker image based on the 1.26 tarball, and am checking out the REL1_26 branch of VE [00:30:04] this is the VE config: https://github.com/gwicke/mediawiki-docker-compose/blob/master/mediawiki/CustomSettings.php [00:30:10] Oh, here we go: [00:30:12] $wgVisualEditorRestbaseURL = 'http://localhost:7231/localhost/v1/page/html/'; [00:30:14] $wgVisualEditorFullRestbaseURL = 'http://localhost:7231/localhost/'; [00:30:45] But I think you only need those if you want to use RESTbase [00:30:52] I forget if $wgVirtualRestConfig was available already in 1.26 [00:31:19] I don't remember when 1.26 was cut exactly [00:32:00] I dont' want to use RB right away as I'll need to set up the update extension for that [00:32:12] that'll be the next step [00:32:16] OK [00:32:22] If VRS works, then what you have there should work AFAICT [00:32:44] Alternatively, if $wgVisualEditorParsoid* vars still exist in the VE code, you could use those [00:32:56] VE is showing up, but it's not loading anything [00:33:00] There's code in VE that sets up a VRS based on those for b/c but I don't know when that was added [00:33:11] there are no errors, and Parsoid never gets a request [00:33:19] Strange [00:33:35] yeah [00:33:44] What's the browser doing network-wise? Does it send a request to api.php that times out? or returns with an error? or...? [00:34:28] it's all 200s as far as I can tell, but let me re-run that [00:44:15] (For posterity: he hadn't init'ed his submodule) [00:47:15] (03PS1) 10Alex Monk: Preserve oldid when switching from VE into WTE [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/259955 (https://phabricator.wikimedia.org/T120898) [00:47:27] 10VisualEditor, 10VisualEditor-MediaWiki, 5Patch-For-Review: When editing an old revision in the visual editor, switching to the wikitext editor without changes moves you to the newest revision - https://phabricator.wikimedia.org/T120898#1889541 (10Krenair) a:3Krenair [00:58:39] (03PS1) 10Alex Monk: Preserve oldid when switching from WTE into VE [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/259960 [00:59:57] RoanKattouw: got it working now [01:00:04] thanks! [01:04:23] Krenair: Did you just submit two patches with identical commit messages? [01:04:55] nope [01:06:26] oh, heh [01:06:27] I see [01:06:31] They're the reverse of each other [01:22:36] 10VisualEditor, 10VisualEditor-MediaWiki, 5Patch-For-Review: Flaky test "MWTransclusionNode getWikitext FAILED: Pending AJAX request" - https://phabricator.wikimedia.org/T116258#1889640 (10Legoktm) There are other extensions inside the gate that depend upon VisualEditor, so removing it isn't going to be that... [01:24:53] Somehow my inbox has gone below 10 [01:25:03] I'm worried I've lost track of one or two things [01:25:06] This never happens [02:07:23] What VE component do bugs with copy&paste go under? [02:08:04] i.e. trying to copy rich text from gdocs, and it not pasting (anything) into VE [02:11:09] VisualEditor-CopyPaste [02:12:19] (03PS3) 10Alex Monk: SET: Browser blacklisting checks [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/259606 (https://phabricator.wikimedia.org/T121298) [02:13:53] dangit, i tried searching for that. /me mutters about phab's autocomplete... >.> [02:14:06] :p [02:14:49] (it's because it only shows 5 suggestions in the dropdown, in the search box...) [02:15:01] the maniphest search page, that is [02:15:29] there's some way to increase that limit [02:15:39] per-page-download [02:19:31] quiddity, JX.TypeaheadSource.prototype.setMaximumResultCount(100) in JS console [05:39:35] 10VisualEditor: Page scrolls by itself when editing - https://phabricator.wikimedia.org/T121838#1889781 (10awight) 3NEW [05:42:29] 10VisualEditor: Bold styling will not clear - https://phabricator.wikimedia.org/T121839#1889789 (10awight) 3NEW [07:59:53] 10Citoid, 10VisualEditor: Use en dash instead of hyphen-minus between page numbers - https://phabricator.wikimedia.org/T113570#1889859 (10Mvolz) a:3Mvolz [08:35:46] hi [08:36:12] I cannot edit template infobox -sidlo on cs.wp with ff 43 [08:37:45] If I select it, dialog box "Prvek" comes and no way to edit it [08:38:16] unfortunatelly I dont have time to test it [08:38:59] e.g. https://cs.wikipedia.org/w/index.php?title=Lhota_(Merklín) [08:40:34] there are also some peaces of code in these articles, like "] | [08:40:35] '''Lhota''' |", but it does not look to be related to this issue. I had no time to test it further [08:43:52] I cannot edit templates I could edit yeasterday with VE, there where no change in those articles since yeasterday. I have recently upgraded FF to 43 but I dont remeber if it was yesterday [09:17:09] 10VisualEditor: Page scrolls by itself when editing - https://phabricator.wikimedia.org/T121838#1889951 (10Aklapper) Which browser and browser version and operating system is this about? [09:31:51] 10VisualEditor: Editing Infobox display - https://phabricator.wikimedia.org/T119843#1889966 (10Aklapper) @Lieutenant_Jade: Please see http://community.wikia.com/wiki/Help:How_to_report_bugs [09:44:24] 10VisualEditor: Editing Infobox display - https://phabricator.wikimedia.org/T119843#1889971 (10Juandev) Same on cs.wp in the themplate Infobox - sídlo from today. Yesterday it worked, today, I cannot edit these templates. There was no change since yesterday in articles. Example is e.g.: https://cs.wikipedia.org/... [09:54:01] 10VisualEditor: Excess newline added before and after a wikilink whose label contains "χ" - https://phabricator.wikimedia.org/T121847#1889987 (10Nemo_bis) 3NEW [12:40:06] Hi all [12:41:04] Is this the correct place for asking about problems with Visual Editor? [13:16:45] eugeniolpa, yes. [13:29:14] Thanks andre__ [13:30:57] So, i have a problem when i try to edit a page with VisualEditor, sometimes the editor don't load, i click in the "Edit" link and nothing happens. [13:32:45] which MediaWiki and which VE versions? Any error output in the browser's developer tools' console? [13:35:19] Mediawiki 1,26, ME 0.1.0 (be84313) [13:36:44] Uncaught TypeError: Cannot read property 'requestPageData' of undefined [13:37:35] reminds me of https://phabricator.wikimedia.org/T107979 but that was fixed a while ago [13:43:08] may i try the git patch?: git fetch https://gerrit.wikimedia.org/r/mediawiki/extensions/VisualEditor refs/changes/76/229976/1 && git checkout FETCH_HEAD [13:54:07] the weird thing is that the error not always happens [13:54:25] and i don't see a pattern [16:50:42] i think there might be a new regression with yesterdays deploy, previously i think i could edit code blocks (from the insert menu) by clicking them and selecting something. Additionally i think it would say 'Code Block' in the little popup. Today i don't seem to be able to edit them and the popup says 'Item' [16:50:46] although, i could be mis-remembering too :) [17:53:41] (03PS1) 10DLynch: Initial cursor position: outside any nails [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/260057 (https://phabricator.wikimedia.org/T114376) [17:54:15] 10VisualEditor, 10VisualEditor-MediaWiki, 7Accessibility, 7Browser-Support-Firefox: The keyboard shortcut doesn't trigger save in the Save dialog in Firefox [? for one user] - https://phabricator.wikimedia.org/T121183#1890959 (10Pols12) Thank you APerson for opening this ticket. [[https:/... [17:57:31] (03CR) 10jenkins-bot: [V: 04-1] Initial cursor position: outside any nails [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/260057 (https://phabricator.wikimedia.org/T114376) (owner: 10DLynch) [17:58:49] 10VisualEditor, 10VisualEditor-MediaWiki, 6Editing-Analysis: Review Schema:Edit now that VE allows WE->VE switching - https://phabricator.wikimedia.org/T118063#1890978 (10Neil_P._Quinn_WMF) p:5Normal>3High [17:58:54] ...huh. I wonder why those tests passed for me. [18:04:39] (03PS2) 10DLynch: Initial cursor position: outside any nails [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/260057 (https://phabricator.wikimedia.org/T114376) [18:27:54] 10VisualEditor, 10VisualEditor-CopyPaste, 10VisualEditor-MediaWiki-Links: Pasting text for a link label removes the link - https://phabricator.wikimedia.org/T121895#1891093 (10Whatamidoing-WMF) 3NEW [18:44:42] 10VisualEditor, 10VisualEditor-CopyPaste, 10VisualEditor-MediaWiki-Links: Pasting text for a link label removes the link - https://phabricator.wikimedia.org/T121895#1891200 (10matmarex) Oooh, yes, I was meaning to complain about this. In general it seems impossible to paste things inside annotations. [18:46:11] 10VisualEditor, 10VisualEditor-CopyPaste: Pasting a list of interwiki links resulted in plain text - https://phabricator.wikimedia.org/T121900#1891203 (10Whatamidoing-WMF) 3NEW [19:22:55] (03CR) 10TheDJ: [C: 04-1] "This breaks lang ky atm. Also ru&ce is not a current convention as far as I know. Instead usually we use the name of the character as post" [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/257978 (https://phabricator.wikimedia.org/T119716) (owner: 10Paladox) [19:45:55] 10VisualEditor, 10VisualEditor-EditingTools, 10OOjs-UI, 10UI-Standardization, and 2 others: Gray for "inactive" elements in the toolbar is too light - https://phabricator.wikimedia.org/T89271#1891365 (10violetto) ping @quiddity, want to make sure I get your thoughts in before we close [[ https://phabricato... [20:29:35] Hi, i need a quick review of a tiny patch for VE-graph -- graphs are being inserted without a required attribute - https://gerrit.wikimedia.org/r/#/c/260066/ JD|cloud, around? [20:34:05] yurik: hhm? [20:34:12] I wouldn't be the one to ask [20:34:19] you may want to whois me [20:35:09] JD|cloud, oops, autocomplete ) [20:35:49] Krinkle, could you +2 https://gerrit.wikimedia.org/r/#/c/260066/ [20:35:58] its a tiny patch [20:36:58] yurik: Without a task or failing test I'm not sure I should merge things in VE. [20:37:50] Krinkle, understood - the problem is that all current graphs are saved without the version, which may break at any moment [20:38:00] and there are very few graph usages at the moment [20:38:06] so it shouldn't cause too big of a problem [20:38:10] even if it fails [20:38:17] yurik: I assume in the future version:2 will be specified, so we can default to 1? [20:38:33] (or update them with a bot) [20:38:49] Krinkle, yes, but the default is about to be changed to 2 [20:38:59] But anyway, without context that shows plans to change the default, or a test that fails due to v2 being the default I can't merge this. [20:39:09] understood [20:39:12] But someone in Editing might feel more sure. [20:40:41] Krinkle, thx. Btw, have you seen my email about sharing code between nodejs & browser? (wikitech-l) Please comment on the best practices for that [21:21:53] 10VisualEditor, 10VisualEditor-EditingTools, 10OOjs-UI, 10UI-Standardization, and 2 others: Gray for "inactive" elements in the toolbar is too light - https://phabricator.wikimedia.org/T89271#1891535 (10Quiddity) >>! In T89271#1891365, @violetto wrote: > ping @quiddity @elitre, want to make sure I get your... [21:31:55] 10VisualEditor, 10VisualEditor-CopyPaste, 10VisualEditor-MediaWiki-Links: Pasting text for a link label removes the link - https://phabricator.wikimedia.org/T121895#1891542 (10Quiddity) See also * {T113082} * {T55973} [21:32:06] 10VisualEditor, 10VisualEditor-CopyPaste, 10VisualEditor-MediaWiki-Links: Pasting text for a link label removes the link - https://phabricator.wikimedia.org/T121895#1891548 (10Quiddity) [21:32:08] 10VisualEditor, 10OOjs-UI, 10Vector: #p-personal hides OO.ui.Dialog in Vector skin - https://phabricator.wikimedia.org/T105300#1891545 (10matmarex) 5Resolved>3Open This didn't actually fix the issue at all… [21:32:40] 10VisualEditor, 10OOjs-UI, 10Vector: #p-personal hides OO.ui.Dialog in Vector skin - https://phabricator.wikimedia.org/T105300#1891553 (10matmarex) [21:32:56] 10VisualEditor, 10OOjs-UI, 10Vector: #p-personal hides OO.ui.Dialog in Vector skin - https://phabricator.wikimedia.org/T105300#1891555 (10matmarex) a:5Prtksxna>3matmarex [21:44:52] 10VisualEditor, 10VisualEditor-ContentEditable, 5Patch-For-Review: Make non-breaking spaces (nbsp) visible in VisualEditor - https://phabricator.wikimedia.org/T96666#1891604 (10matmarex) p:5Normal>3Low [22:03:13] 10VisualEditor, 10Graph: Migrate graphs from Vega 1 to Vega 2 syntax on edit with VE - https://phabricator.wikimedia.org/T120319#1891637 (10Yurik) For the current, non-aggregated graphs, the migration is very simple -- place `"version":2` at the top, and remove all `data.` from the fields. Once you use facets... [22:05:23] 10VisualEditor, 10Graph: Urgent: Mark all graphs with version attribute - https://phabricator.wikimedia.org/T121915#1891641 (10Yurik) 3NEW [22:07:25] 10VisualEditor, 10Graph, 5Patch-For-Review: Urgent: Mark all graphs with version attribute - https://phabricator.wikimedia.org/T121915#1891663 (10Yurik) [22:10:42] 10VisualEditor, 10VisualEditor-EditingTools, 10OOjs-UI, 10UI-Standardization, and 2 others: Gray for "inactive" elements in the toolbar is too light - https://phabricator.wikimedia.org/T89271#1891672 (10Volker_E) @Quiddity I'm still not 100% convinced by #888, but for the time being, it might be our best c... [22:25:10] 10VisualEditor, 10VisualEditor-EditingTools, 10OOjs-UI, 10UI-Standardization, and 2 others: Gray for "inactive" elements in the toolbar is too light - https://phabricator.wikimedia.org/T89271#1891704 (10violetto) #888 works more in favor for the old monitor users and users with vision deficiency. The contr... [22:54:48] 10VisualEditor, 10OOjs-UI, 10Vector: #p-personal hides OO.ui.Dialog in Vector skin - https://phabricator.wikimedia.org/T105300#1891819 (10matmarex) 5Open>3Resolved [23:11:43] 10VisualEditor, 10VisualEditor-EditingTools, 10OOjs-UI, 10UI-Standardization, and 2 others: Gray for "inactive" elements in the toolbar is too light - https://phabricator.wikimedia.org/T89271#1891861 (10Volker_E) @violetto Would you give an image example of `#888` applied like in the comment of [[ https://... [23:17:53] 10VisualEditor, 10VisualEditor-EditingTools, 10OOjs-UI, 10UI-Standardization, and 2 others: Gray for "inactive" elements in the toolbar is too light - https://phabricator.wikimedia.org/T89271#1891870 (10Volker_E) Just for completion: `#949494 ` is the furthest from `#000` gray that passes Level AA (18pt) a... [23:35:06] 10VisualEditor, 10VisualEditor-EditingTools, 10OOjs-UI, 10UI-Standardization, and 2 others: Gray for "inactive" elements in the toolbar is too light - https://phabricator.wikimedia.org/T89271#1891901 (10violetto) http://jsfiddle.net/zL41byxk/2