[02:09:07] 10Cite: False duplicate errors ("defined multiple times with different content") when using {{#tag:ref}} with XML-style tags inside - https://phabricator.wikimedia.org/T118603#1917274 (10matmarex) a:3matmarex @bawolff suggested that we could call unstripBoth() to replace the strip markers with real content bef... [06:41:41] (03CR) 10Alex Monk: [C: 04-1] "Unaddressed comment" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/244439 (https://phabricator.wikimedia.org/T114857) (owner: 10D3r1ck01) [10:39:27] (03CR) 10D3r1ck01: "Hey Alex, what do you suggest we do with this bug now? Abandon it?" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/244439 (https://phabricator.wikimedia.org/T114857) (owner: 10D3r1ck01) [14:01:53] (03PS2) 10Mvolz: Add PMID as hint [extensions/Citoid] - 10https://gerrit.wikimedia.org/r/260959 (https://phabricator.wikimedia.org/T122427) (owner: 10Matěj Suchánek) [14:15:27] (03CR) 10Mvolz: [C: 032] Add PMID as hint [extensions/Citoid] - 10https://gerrit.wikimedia.org/r/260959 (https://phabricator.wikimedia.org/T122427) (owner: 10Matěj Suchánek) [14:19:06] (03CR) 10Mvolz: "Whoops, didn't mean to +2 that. This is ok but should probably update the message for qqq.json as well." [extensions/Citoid] - 10https://gerrit.wikimedia.org/r/260959 (https://phabricator.wikimedia.org/T122427) (owner: 10Matěj Suchánek) [14:20:07] 10Citoid, 7Easy, 5Patch-For-Review: Message should be enhanced as citoid supports PMIDs - https://phabricator.wikimedia.org/T122427#1917767 (10Mvolz) Should probably update the message in qqq.json as well. We also offer PMCID as well, but that might be too much alphabet soup? Probably if people know PMID is... [15:52:28] (03PS1) 10Matěj Suchánek: Update /qqq documentation [extensions/Citoid] - 10https://gerrit.wikimedia.org/r/262714 (https://phabricator.wikimedia.org/T122427) [16:08:55] 10Citoid, 10VisualEditor, 3Google-Code-In-2015: ISBN field validation bug chunks multiple ISBNs in a field inappropriately. - https://phabricator.wikimedia.org/T116056#1917967 (10Mvolz) a:5Mvolz>3None [16:23:17] (03CR) 10Siebrand: [C: 032] "i18n/L10n reviewed." [extensions/Citoid] - 10https://gerrit.wikimedia.org/r/262714 (https://phabricator.wikimedia.org/T122427) (owner: 10Matěj Suchánek) [16:24:14] 10Citoid, 10VisualEditor, 3Google-Code-In-2015: ISBN field validation bug chunks multiple ISBNs in a field inappropriately. - https://phabricator.wikimedia.org/T116056#1918060 (10Mvolz) [16:25:51] (03Merged) 10jenkins-bot: Update /qqq documentation [extensions/Citoid] - 10https://gerrit.wikimedia.org/r/262714 (https://phabricator.wikimedia.org/T122427) (owner: 10Matěj Suchánek) [17:34:51] (03CR) 10Alex Monk: "Somehow fix the issue properly, or abandon, I suppose :/" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/244439 (https://phabricator.wikimedia.org/T114857) (owner: 10D3r1ck01) [18:04:48] 10VisualEditor, 10ContentTranslation-cxserver, 10Parsoid, 10RESTBase, and 2 others: Is RDFa metadata in Parsoid HTML head actually useful to you? - https://phabricator.wikimedia.org/T122390#1918192 (10GWicke) @bianjiang, revision metadata is available a) from the action api, via action=query, and b) from... [18:29:20] 10VisualEditor, 7Browser-Support-Firefox: Backspace to merge paragraph leads to second paragraph's deletion - https://phabricator.wikimedia.org/T71429#1918285 (10DLynch) I cannot reproduce this. I'd suspect it's been incidentally fixed in the last year-or-so? [18:34:43] (03CR) 10Alex Monk: [C: 04-1] MWMediaSearchWidget: Show user uploads as a tab (032 comments) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/210831 (https://phabricator.wikimedia.org/T62398) (owner: 10MarkAHershberger) [18:45:41] 10Citoid: Add Highwire Press, Eprints, BE Press, to html-metadata lib - https://phabricator.wikimedia.org/T76225#1918347 (10Mvolz) 5Open>3Resolved [18:45:50] (03PS1) 10DLynch: ve.ce.minImgDataUri was considered invalid in Safari [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/262725 [18:48:07] It's the big things for a hackathon, you know? [18:53:09] (03CR) 10jenkins-bot: [V: 04-1] ve.ce.minImgDataUri was considered invalid in Safari [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/262725 (owner: 10DLynch) [18:55:39] ...really. [18:56:07] Kemayo, I don't use Safari [18:57:11] (03CR) 10DLynch: "recheck" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/262725 (owner: 10DLynch) [18:58:08] Krenair: I started using it a month or two ago. It turns out to be pretty good at avoiding being a CPU hog. [19:07:17] I think this is a problem with the actual test-runner? https://integration.wikimedia.org/ci/job/npm/45271/console [19:09:17] (03CR) 10Jforrester: "I'd really prefer this as a media insert dialog tab with was searchable, rather than over-loading the search tab with two meanings, as it " [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/210831 (https://phabricator.wikimedia.org/T62398) (owner: 10MarkAHershberger) [19:10:44] 10VisualEditor, 7Browser-Support-Firefox: Backspace to merge paragraph leads to second paragraph's deletion - https://phabricator.wikimedia.org/T71429#1918409 (10Jdforrester-WMF) 5stalled>3Resolved a:3Jdforrester-WMF Seems likely. [19:14:23] Kemayo: Are you on 5 rather than 3? :-) [19:14:52] I am at the moment. I was thinking I'd go to 3 after lunch, since it's only 45 minutes away. [19:15:56] * James_F grins. [19:16:14] is everyone else on 3..? [19:16:31] Yeah. [19:16:38] The error in the test-runner is odd. [19:16:51] I assume you gave it a test stack that was null and it didn't work or something. [19:18:32] Trying to reproduce locally. [19:19:33] It works for me, hence confusion. [19:19:37] Likewise. [19:24:40] (03CR) 10Esanders: "I think David's comment of that variable was that it is the the smallest gif possible to create, so if that is no longer the case we shoul" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/262725 (owner: 10DLynch) [19:25:07] (03CR) 10Esanders: "Is there a bug for this?" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/262725 (owner: 10DLynch) [19:27:14] (03CR) 10DLynch: "No bug for it. I've just been noticing the errors in the console since I started using Safari, and finally decided to work out what it was" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/262725 (owner: 10DLynch) [19:28:14] (03CR) 10DLynch: "The error being: [Error] Failed to load resource: The operation couldn’t be completed. (kCFErrorDomainCFNetwork error -10.) (data:image/gi" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/262725 (owner: 10DLynch) [19:31:53] I'll update it to crib off of this person's work, actually: http://probablyprogramming.com/2009/03/15/the-tiniest-gif-ever [19:33:12] :-) [19:33:28] Still longer than what we had before, but spec-compliant. [19:33:37] (03PS2) 10DLynch: ve.ce.minImgDataUri was considered invalid in Safari [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/262725 [19:34:27] It seems that, spec-wise, you can't get smaller than that without losing the transparency. [19:37:09] And we seem to be using that only in places where it's basically an invisible image, so the transparency part is probably important. [19:39:56] (03CR) 10jenkins-bot: [V: 04-1] ve.ce.minImgDataUri was considered invalid in Safari [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/262725 (owner: 10DLynch) [19:42:15] (03PS3) 10DLynch: ve.ce.minImgDataUri was considered invalid in Safari [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/262725 [19:45:22] I suppose I should cause some other patch to exist, so I can see if jenkins hates everything. [19:47:44] * James_F grins. [19:48:09] (03CR) 10Alex Monk: [C: 032] Update VE core submodule to master (a509b1c) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/262675 (owner: 10Jforrester) [19:48:28] (03PS3) 10Jforrester: Initial cursor position: outside any nails [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/260057 (https://phabricator.wikimedia.org/T114376) (owner: 10DLynch) [19:48:34] That rebase might trigger something. [19:49:03] (03CR) 10jenkins-bot: [V: 04-1] ve.ce.minImgDataUri was considered invalid in Safari [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/262725 (owner: 10DLynch) [19:50:48] (03CR) 10Esanders: "The problem is the widgets available to us aren't sophisticated enough for our use case. SearchWidget is a text input connected to a resul" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/210831 (https://phabricator.wikimedia.org/T62398) (owner: 10MarkAHershberger) [19:52:57] (03Merged) 10jenkins-bot: Update VE core submodule to master (a509b1c) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/262675 (owner: 10Jforrester) [19:59:11] (03CR) 10jenkins-bot: [V: 04-1] Initial cursor position: outside any nails [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/260057 (https://phabricator.wikimedia.org/T114376) (owner: 10DLynch) [20:00:03] Indicative. [20:00:04] Kemayo: Yeah, looks like CI is more broken in general. [20:03:15] 10VisualEditor: [Regression wmf.8] Saving a page after adding any focusable node throws error "TypeError: rect is undefined" - https://phabricator.wikimedia.org/T120699#1918657 (10Esanders) [20:06:54] (03PS1) 10Esanders: ve.ui.Surface: Account for null viewport [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/262749 (https://phabricator.wikimedia.org/T120699) [20:11:06] 10Cite: Cite error messages save UI language text into parser cache - https://phabricator.wikimedia.org/T33216#1918682 (10matmarex) I think this is super silly. I had to debug some Cite problems on a German wiki recently and it sucked. I'd prefer user language for these. [20:16:21] 10Cite: Cite error messages save UI language text into parser cache - https://phabricator.wikimedia.org/T33216#1918683 (10Legoktm) And split the parser cache? [20:16:29] (03CR) 10jenkins-bot: [V: 04-1] ve.ui.Surface: Account for null viewport [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/262749 (https://phabricator.wikimedia.org/T120699) (owner: 10Esanders) [20:17:53] 10Cite: Cite error messages save UI language text into parser cache - https://phabricator.wikimedia.org/T33216#1918685 (10matmarex) Yeah. Cite error messages shouldn't be that common to make this a problem. [21:08:23] Hi! Anyone around? [21:08:55] Is there an easy way to add a button(s) to VE's toolbar for doing some operations on selected text, e.g. highlight it in different colors? (either background or text itself)? [21:09:40] I think it could be done with templates, but it is not so convenient - to insert a template and fill its parameters each time... [21:22:44] hey TwisteR [21:23:30] hi! live people here \o/ [21:23:33] :) [21:24:40] I was afraid it is a channel full of bots [21:24:55] TwisteR: https://www.mediawiki.org/wiki/VisualEditor/Gadgets has a small guide [21:25:44] doesn't seem to have exactly what you're looking for. the example gadgets linked at the bottom could be helpful, though [21:27:30] oh, cool [21:27:47] MatmaRex_: thanks for the link! [21:28:18] Yeah, a few of the "Real examples" at the bottom are doing toolbar-adding. [21:28:25] it would be cool to be able to highlight the text like that "Don't panic" caption is [21:33:32] That's simple enough, in its way -- the style there is done via inline styles, so your button would need to add a TextStyleAnnotation to the range. [21:35:45] (03PS1) 10Jforrester: build: Update various devDependencies to latest [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/262819 [21:43:29] (03CR) 10Alex Monk: [C: 032] build: Update various devDependencies to latest [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/262819 (owner: 10Jforrester) [21:43:46] (03CR) 10Alex Monk: [C: 032] ve.ui.Surface: Account for null viewport [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/262749 (https://phabricator.wikimedia.org/T120699) (owner: 10Esanders) [21:47:58] (03Merged) 10jenkins-bot: build: Update various devDependencies to latest [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/262819 (owner: 10Jforrester) [21:48:00] (03Merged) 10jenkins-bot: ve.ui.Surface: Account for null viewport [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/262749 (https://phabricator.wikimedia.org/T120699) (owner: 10Esanders) [21:49:39] (03PS4) 10DLynch: ve.ce.minImgDataUri was considered invalid in Safari [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/262725 [21:49:54] (03CR) 10Paladox: "recheck" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/260057 (https://phabricator.wikimedia.org/T114376) (owner: 10DLynch) [21:52:08] (03CR) 10Paladox: "recheck" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/258357 (owner: 10Jforrester) [21:55:03] 10VisualEditor, 10VisualEditor-ContentEditable, 5WMF-deploy-2016-01-12_(1.27.0-wmf.10): [Regression wmf.8] Saving a page after adding any focusable node throws error "TypeError: rect is undefined" - https://phabricator.wikimedia.org/T120699#1918950 (10Jdforrester-WMF) 5Open>3Resolved a:3Esanders [22:04:42] (03CR) 10Jforrester: [C: 032] ve.ce.minImgDataUri was considered invalid in Safari [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/262725 (owner: 10DLynch) [22:09:51] (03Merged) 10jenkins-bot: ve.ce.minImgDataUri was considered invalid in Safari [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/262725 (owner: 10DLynch) [22:45:16] (03Abandoned) 10D3r1ck01: Blank Edit summary prompt Fix [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/244439 (https://phabricator.wikimedia.org/T114857) (owner: 10D3r1ck01) [23:03:33] (03PS6) 10Jforrester: ve.ce.Surface: Remove selection-type awareness from renderSelectedContentBranchNode [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/258761 (owner: 10Esanders) [23:46:58] (03PS7) 10Jforrester: Provide methods to (de)serialize transactions [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/231017 (https://phabricator.wikimedia.org/T74658) (owner: 10Esanders)