[00:13:31] (03CR) 10Alex Monk: [C: 032] Remove references to non-existent messages [extensions/VisualEditor] (wmf/1.27.0-wmf.10) - 10https://gerrit.wikimedia.org/r/263934 (owner: 10Krinkle) [00:17:33] (03Merged) 10jenkins-bot: Remove references to non-existent messages [extensions/VisualEditor] (wmf/1.27.0-wmf.10) - 10https://gerrit.wikimedia.org/r/263934 (owner: 10Krinkle) [01:04:56] 10VisualEditor, 10VisualEditor-ContentEditable: pressing left-arrow key, cursor skips period past footnote reference. - https://phabricator.wikimedia.org/T123608#1933635 (10Ijon) 3NEW [08:38:58] 10VisualEditor, 6Community-Liaison, 10Wikimedia-Site-Requests: Please enable VisualEditor at the Kazakh Wikipedia - https://phabricator.wikimedia.org/T97315#1933957 (10Whatamidoing-WMF) Elitre posted a message in May 2015. It is now January 2016. There have been no further comments in that discussion. [11:33:00] 10VisualEditor: Image alignment causes VisualEditor to not load - https://phabricator.wikimedia.org/T123471#1934139 (10Raftab) Here's the HTML output from the Parsoid instance, this is one example of a center aligned image:
10VisualEditor, 10Wikimedia-Site-Requests: Disable VisualEditor at Multilingual Wikisource (sourceswiki) - https://phabricator.wikimedia.org/T122567#1934274 (10Krenair) 5Open>3Invalid a:3Krenair Nope, I think this was just because it looked like another wikisource.org vs. other wikisources inconsistency. [15:51:42] 10VisualEditor, 6Editing-Analysis, 6Research-and-Data: Add support for hashtags (URL parameter -> edit summary) - https://phabricator.wikimedia.org/T123529#1934471 (10Krenair) >>! In T123529#1934450, @Sadads wrote: > per @DarTar and @Krenair I want to +1 the idea I'm not +1ing the idea, I'm questioning the... [16:00:19] 10VisualEditor, 10VisualEditor-Tables, 7notice, 7user-notice: Be able to re-order the columns or rows of a table in VisualEditor - https://phabricator.wikimedia.org/T88694#1934478 (10Esanders) [16:21:40] (03PS3) 10Esanders: Tables: Move columns and rows [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/263869 (https://phabricator.wikimedia.org/T88694) [16:21:42] (03PS1) 10Esanders: Put construction of table context items in loops [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/264089 [16:21:53] edsanders: Boo, no dragging? ;-) [16:22:05] not yet [16:22:28] I like that attitude. :-) [16:22:51] https://gerrit.wikimedia.org/r/#/c/264089/1/src/ui/contextitems/ve.ui.TableContextItem.js suggests we need to reduce our boiler-plate, not cook up special loop methods. [16:22:52] But eh. [16:25:56] 10VisualEditor, 6Community-Liaison, 10Wikimedia-Site-Requests: Please enable VisualEditor at the Kazakh Wikipedia - https://phabricator.wikimedia.org/T97315#1934515 (10Jdforrester-WMF) >>! In T97315#1933957, @Whatamidoing-WMF wrote: > Elitre posted a message in May 2015. It is now January 2016. There have... [16:26:05] (03CR) 10jenkins-bot: [V: 04-1] Tables: Move columns and rows [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/263869 (https://phabricator.wikimedia.org/T88694) (owner: 10Esanders) [16:29:10] 10VisualEditor: Image alignment causes VisualEditor to not load in REL1_25 - https://phabricator.wikimedia.org/T123471#1934522 (10Jdforrester-WMF) [16:30:06] 10VisualEditor: Image alignment causes VisualEditor to not load in REL1_25 - https://phabricator.wikimedia.org/T123471#1930792 (10Jdforrester-WMF) It's possible you're using a too-new version of #Parsoid and that there was a breaking change, but I don't recall anything in this area changing around that time. [16:47:35] (03CR) 10Jforrester: [C: 04-1] "Cute. Some issues:" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/263869 (https://phabricator.wikimedia.org/T88694) (owner: 10Esanders) [17:10:28] 10VisualEditor: Image alignment causes VisualEditor to not load in REL1_25 - https://phabricator.wikimedia.org/T123471#1934590 (10Raftab) Thanks for the response. Interesting. The parsoid version we're on is: 0.4.1. That still appears to be the version that is pulled down from: https://gerrit.wikimedia.org/r/p... [17:38:59] (03PS1) 10DLynch: Links in focusableNodes: shouldn't look clickable [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/264098 (https://phabricator.wikimedia.org/T100275) [18:45:54] 10VisualEditor, 10Flow, 3Collaboration-Team-Current, 5Patch-For-Review, 5WMF-deploy-2016-01-19_(1.27.0-wmf.11): Flow VE: Link inspector displays 'Edit' and 'delete'(oo-ui-buttonElement-framed) in different sizes - https://phabricator.wikimedia.org/T121987#1934906 (10Etonkovidova) Checked in betalabs - V... [18:50:02] (03PS4) 10Esanders: Tables: Move columns and rows [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/263869 (https://phabricator.wikimedia.org/T88694) [18:53:05] (03PS1) 10Esanders: Update name of language icon [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/264105 [18:53:22] (03CR) 10jenkins-bot: [V: 04-1] Tables: Move columns and rows [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/263869 (https://phabricator.wikimedia.org/T88694) (owner: 10Esanders) [18:53:31] (03CR) 10Jforrester: [C: 032] Update name of language icon [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/264105 (owner: 10Esanders) [18:54:39] (03PS2) 10Esanders: Put construction of table context items in loops [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/264089 [18:54:41] (03PS5) 10Esanders: Tables: Move columns and rows [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/263869 (https://phabricator.wikimedia.org/T88694) [18:58:06] (03Merged) 10jenkins-bot: Update name of language icon [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/264105 (owner: 10Esanders) [18:58:19] (03CR) 10jenkins-bot: [V: 04-1] Tables: Move columns and rows [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/263869 (https://phabricator.wikimedia.org/T88694) (owner: 10Esanders) [18:59:49] (03CR) 10Jforrester: "Better. Still issues with moving merged cell (e.g. click on '4' and then 'move before' and the column goes), but I really like it. :-)" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/263869 (https://phabricator.wikimedia.org/T88694) (owner: 10Esanders) [19:13:10] 10TemplateData, 10MediaWiki-API, 7Easy, 3Google-Code-In-2015, 5Patch-For-Review: ApiTemplateData implements ApiBase::getCustomPrinter for no good reason - https://phabricator.wikimedia.org/T91455#1935017 (10MtDu) a:5Krenair>3MtDu I'm working on this. I have claimed it on the GCI page. Thanks, MtDu [19:14:20] 10TemplateData, 10MediaWiki-API, 7Easy, 3Google-Code-In-2015, 5Patch-For-Review: ApiTemplateData implements ApiBase::getCustomPrinter for no good reason - https://phabricator.wikimedia.org/T91455#1935020 (10Krenair) a:5MtDu>3Krenair I already uploaded a patch, @MtDu. I claimed it here, and cannot see... [20:26:46] (03CR) 10Jforrester: [C: 032] "Holding my nose." [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/264089 (owner: 10Esanders) [20:30:54] (03Merged) 10jenkins-bot: Put construction of table context items in loops [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/264089 (owner: 10Esanders) [20:42:55] (03PS6) 10Jforrester: Tables: Move columns and rows [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/263869 (https://phabricator.wikimedia.org/T88694) (owner: 10Esanders) [20:43:19] (03CR) 10Jforrester: [C: 04-1] "Per my last." [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/263869 (https://phabricator.wikimedia.org/T88694) (owner: 10Esanders) [20:48:52] 10VisualEditor, 6Editing-Analysis, 6Research-and-Data: Add support for hashtags (URL parameter -> edit summary) - https://phabricator.wikimedia.org/T123529#1935238 (10DarTar) [21:14:32] 10VisualEditor: VisualEditor link tool stays active after you're done with the link - https://phabricator.wikimedia.org/T123664#1935322 (10maiden_taiwan) 3NEW [21:15:19] 10VisualEditor: VisualEditor link tool stays active after you're done with the link - https://phabricator.wikimedia.org/T123664#1935329 (10maiden_taiwan) Here is a screenshot of what happens. {F3228669} [21:16:07] 10VisualEditor: VisualEditor link tool stays active after you're done with the link - https://phabricator.wikimedia.org/T123664#1935332 (10maiden_taiwan) This is on the current VisualEditor on English Wikipedia today: 0.1.0 (c37fbf1) 21:55, 11 January 2016 [21:25:03] 10VisualEditor: VisualEditor link tool stays active after you're done with the link - https://phabricator.wikimedia.org/T123664#1935350 (10maiden_taiwan) Another way to say this is: When you click the "Done" button in the link tool, the tool doesn't go away. It stays there, displaying an "Edit" button where the... [21:31:23] (03CR) 10Anomie: [C: 04-1] "Change itself works good. -1 because you should remove the now-unused 'apihelp-templatedata-param-format' i18n message." (032 comments) [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/263881 (https://phabricator.wikimedia.org/T91455) (owner: 10Alex Monk) [21:35:56] 10TemplateData, 10MediaWiki-API, 7Easy, 3Google-Code-In-2015, 5Patch-For-Review: ApiTemplateData implements ApiBase::getCustomPrinter for no good reason - https://phabricator.wikimedia.org/T91455#1935417 (10Jdforrester-WMF) >>! In T91455#1932087, @Krenair wrote: > Actually you end up with XML, like this:... [21:36:39] 10TemplateData, 10MediaWiki-API, 7Easy, 3Google-Code-In-2015, 5Patch-For-Review: ApiTemplateData implements ApiBase::getCustomPrinter for no good reason - https://phabricator.wikimedia.org/T91455#1935418 (10Krenair) I put in pretty useless TemplateData, to be fair. [21:36:51] :-) [21:37:14] don't remember how it compares to the JSON equivalent [21:43:18] James_F, so the UI for https://gerrit.wikimedia.org/r/#/c/263655/ ... [21:43:34] right now we don't provide a multiple input thing you'd need [21:44:16] Krenair: We don't? Can't we use the tokenised input thing in OOUI? [21:44:38] There is 'aliases' but that's comma-separated, which I don't think is good enough for this one [21:44:43] Yeah. [21:44:54] not familiar with the tokenised input thing in OOUI. what's the name of that? [21:45:15] CapsuleMultiSelectWidget [21:45:26] No, wait. [21:45:30] There's an input version. [21:45:52] Hmm, yeah. [21:46:06] I'm wrong, we need a CapsuleMultiInputWidget [21:46:15] And it needs to implement draggable. [21:46:17] Fuuuun. [21:47:07] You know what has one of these? OpenStackManager :P [21:47:34] for the project filter thing [21:47:37] Clearly we should make Ryan Lane make the widget, then. :-) [21:47:40] haha [21:51:16] James_F, I don't think it needs to implement draggable really [21:51:28] Krenair: The order might be important. [21:51:35] Krenair: It's an array, not an object. :-) [21:51:53] E.g. values of "left, right, centre" shouldn't show randomly. [21:52:11] it won't cause any change in software behaviour if they do show randomly [21:52:25] if we implemented it without, then a request to add draggable would be a feature request imo [21:55:11] So what is the purpose of mw.TemplateData.DragDropItemWidget beyond setting up some defaults for use as parameters and adding a class... [21:56:19] Ordering. [21:56:47] Also it was upstreamed from TD so the remaining code may be a little crufty, if that's what you're asking.. [21:57:07] it inherits from OO.ui.DecoratedOptionWidget and mixes in OO.ui.mixin.DraggableElement [21:57:10] hm [22:00:20] 10TemplateData, 10MediaWiki-API, 7Easy, 3Google-Code-In-2015, 5Patch-For-Review: ApiTemplateData implements ApiBase::getCustomPrinter for no good reason - https://phabricator.wikimedia.org/T91455#1935512 (10Anomie) >>! In T91455#1935417, @Jdforrester-WMF wrote: > Oh dear. That's pretty useless, surely?... [22:10:28] James_F, so OO.ui.CapsuleMultiTextInputWidget [22:11:19] Krenair: Something like that. I saw "CapsuleMultiSelectWidget with NumberInputWidget popup‎" so maybe it's relatively easy? [22:11:47] "Maybe". [22:12:00] going to look a bit like a TextInputWidget, but containing a CapsuleMultiSelectWidget (which I suppose will have to contain CapsuleMultiTextInputItemWidgets which will have remove buttons), and a TextInputWidget, and some mechanism for submitting your TextInputWidget value into the multi select [22:12:19] i guess [22:12:22] hm [22:12:59] James_F, where did you see that? [22:14:18] In the dmeo. [22:14:20] Demo, too. [22:14:33] https://doc.wikimedia.org/oojs-ui/master/demos/#widgets-mediawiki-mixed-ltr [22:15:47] ooh [22:15:49] that looks like what we want [22:15:55] Yeah. [22:15:56] maybe this will be easier than I thought [22:39:06] (03PS10) 10Alex Monk: [WIP] Add a parameter key to limit possible valid values to a given set [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/263655 (https://phabricator.wikimedia.org/T53375) [22:39:54] James_F, okay [22:40:39] (03CR) 10jenkins-bot: [V: 04-1] [WIP] Add a parameter key to limit possible valid values to a given set [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/263655 (https://phabricator.wikimedia.org/T53375) (owner: 10Alex Monk) [22:40:49] would like to know what you think of the table column [22:41:21] bah, I broke it just before uploading [22:43:17] "Don't make functions within a loop" [22:43:19] hm [22:43:35] probably good advice considering the issue I just ran into [22:47:25] and actually it doesn't seem to insert yet [22:47:36] maybe my PS10 upload was a bit premature [22:53:32] (03PS11) 10Alex Monk: [WIP] Add a parameter key to limit possible valid values to a given set [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/263655 (https://phabricator.wikimedia.org/T53375) [23:03:40] (03PS12) 10Alex Monk: [WIP] Add a parameter key to limit possible valid values to a given set [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/263655 (https://phabricator.wikimedia.org/T53375) [23:40:49] (03PS2) 10Alex Monk: Don't restrict format parameter in the API [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/263881 (https://phabricator.wikimedia.org/T91455) [23:43:10] (03CR) 10jenkins-bot: [V: 04-1] Don't restrict format parameter in the API [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/263881 (https://phabricator.wikimedia.org/T91455) (owner: 10Alex Monk) [23:45:30] (03PS3) 10Alex Monk: Don't restrict format parameter in the API [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/263881 (https://phabricator.wikimedia.org/T91455)