[00:03:54] Krenair: Differnet value, same key. Can't be defined twice in the same json file [00:03:55] templatedata-doc-param-type-wiki-page-name [00:03:57] and others [00:04:30] Looks like 2/3rd of the blob was duplicated somehow [00:06:53] James_F: Where is it passing on hhvm and failing on zend? The failure is from -qunit [00:07:34] Krinkle: Isn't mediawiki-extensions-hhvm just mediawiki-extensions-qunit but on HHVM instead of Zend [00:07:34] ? [00:07:52] ? [00:07:57] -qunit runs qunit. [00:08:21] -qunit uses Zend PHP 5.5 I think, or whatever trusty ships [00:08:25] So why does mediawiki-extensions-hhvm spam everyone about qunit tests? [00:08:26] Notice: Undefined index: editappendix in /mnt/jenkins-workspace/workspace/mediawiki-extensions-qunit/src/extensions/GuidedTour/GuidedTourHooks.php on line [00:08:33] It doesn't [00:08:36] The error is from -qunit [00:08:40] mw install failed [00:08:43] php notices and errors [00:08:59] Eurgh. [00:09:04] Krinkle, oh I see, I duplicated the whole block there [00:09:04] oops [00:09:10] PHP Notice: Undefined index: editappendix [00:09:10] #0 /mnt/jenkins-workspace/workspace/mediawiki-extensions-qunit/src/extensions/GuidedTour/GuidedTourHooks.php [00:09:14] or most of it [00:09:20] https://integration.wikimedia.org/ci/job/mediawiki-extensions-qunit/25623/ -> artefacts -> mw-error.log [00:09:22] instead of just individual lines [00:09:27] (for errors without html wrappers) [00:09:35] Fscking GuidedTour. [00:10:04] PHP Notice: Undefined index: editappendix #0 /mnt/jenkins-workspace/workspace/mediawiki-extensions-qunit/src/extensions/GuidedTour/GuidedTourHooks.php(line 38): includes/Setup.php(725): GuidedTourHooks::onSetup() [00:10:05] YEah [00:10:14] Why why why. [00:10:44] solly :) [00:12:14] This extension is hopelessly outdated. [00:18:49] (03CR) 10Jforrester: "Thanks to Krinkle, found the issue; I264599a1 in GuidedTour is needed first." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/258357 (owner: 10Jforrester) [00:25:01] (03PS3) 10Alex Monk: Localise names of types in HTML rendering [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/263918 (https://phabricator.wikimedia.org/T61745) [00:33:28] (03PS4) 10Alex Monk: Drop support for adding prefix/appendix labels to edit tabs/links [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/258357 (owner: 10Jforrester) [00:37:58] (03CR) 10Krinkle: [C: 04-1] "I think Moriel originally opted to using 'undefined' in the TDG GUI because it naturally casted from the undefined value in JavaScript. Ho" [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/263918 (https://phabricator.wikimedia.org/T61745) (owner: 10Alex Monk) [02:18:53] 10VisualEditor, 10Parsoid: Parsoid removes newlines between block elements when content is inserted between them - https://phabricator.wikimedia.org/T119789#1938757 (10Arlolra) [03:03:47] (03CR) 10Alex Monk: [C: 04-1] Drop support for adding prefix/appendix labels to edit tabs/links (031 comment) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/258357 (owner: 10Jforrester) [03:58:37] 10VisualEditor, 10VisualEditor-MediaWiki, 10OOjs-UI, 5Patch-For-Review: Keyboard shortcuts dialog has no scroll bar - https://phabricator.wikimedia.org/T123775#1938815 (10Kipod) also: hotkeys help form is completely borked in hebrew, probably in all other RTL languages. peace. [06:16:27] 10VisualEditor, 10VisualEditor-Tables: Be able to copy/paste whole tables, without selecting anything else on the page - https://phabricator.wikimedia.org/T123826#1938874 (10Whatamidoing-WMF) 3NEW [09:26:28] (03PS1) 10Divec: Minor documentation tweaks [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/264450 [14:00:15] (03CR) 10Esanders: [C: 04-1] Links in focusableNodes: shouldn't look clickable (031 comment) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/264098 (https://phabricator.wikimedia.org/T100275) (owner: 10DLynch) [14:34:56] (03PS11) 10Esanders: Tables: Move columns and rows [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/263869 (https://phabricator.wikimedia.org/T88694) [14:35:12] (03CR) 10jenkins-bot: [V: 04-1] Tables: Move columns and rows [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/263869 (https://phabricator.wikimedia.org/T88694) (owner: 10Esanders) [14:37:17] (03PS12) 10Esanders: Tables: Move columns and rows [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/263869 (https://phabricator.wikimedia.org/T88694) [14:51:31] 10VisualEditor: NEWSECTIONLINK and INDEX being added to articles - https://phabricator.wikimedia.org/T118796#1939072 (10Wbm1058) https://en.wikipedia.org/wiki/Wikipedia:VisualEditor/Feedback/Archive_2016_3#Stop_adding_various_magicwords_FORCETOC.2C_NOEDITSECTION.2C_INDEX_and_NEWSECTIONLINK VisualEditor should o... [14:52:53] (03PS13) 10Esanders: Tables: Move columns and rows [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/263869 (https://phabricator.wikimedia.org/T88694) [14:55:41] 10VisualEditor: NEWSECTIONLINK and INDEX being added to articles - https://phabricator.wikimedia.org/T118796#1939081 (10Wbm1058) 5declined>3Open [16:53:12] 10Citoid, 7Easy, 5WMF-deploy-2016-01-12_(1.27.0-wmf.10): Message should be enhanced as citoid supports PMIDs - https://phabricator.wikimedia.org/T122427#1939101 (10matej_suchanek) a:5matej_suchanek>3None [16:58:22] 10VisualEditor, 6Editing-Analysis, 6Research-and-Data: Add support for hashtags (URL parameter -> edit summary) - https://phabricator.wikimedia.org/T123529#1939105 (10DarTar) @Jdforrester-WMF who is the right person to determine if this proposal would be best implemented as a VE feature or an interface-indep... [17:13:18] (03PS14) 10Esanders: Tables: Move columns and rows [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/263869 (https://phabricator.wikimedia.org/T88694) [17:14:17] (03PS1) 10Esanders: Fix styling of separators [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/264470 [17:19:11] 10VisualEditor, 10VisualEditor-Tables, 7Browser-Support-Firefox: [Regression wmf16]: Firefox only: Tables - When a cell is highlighted, a thick border line displayed in the middle - https://phabricator.wikimedia.org/T88474#1939111 (10Esanders) The above commit (https://gerrit.wikimedia.org/r/188926) is not... [17:20:31] 10VisualEditor, 10VisualEditor-Tables, 7Browser-Support-Firefox: [Regression wmf16]: Firefox only: Tables - When a cell is highlighted, a thick border line displayed in the middle - https://phabricator.wikimedia.org/T88474#1939114 (10Esanders) Can't reproduce in latest FF [17:20:42] 10VisualEditor, 10VisualEditor-Tables, 7Browser-Support-Firefox: [Regression wmf16]: Firefox only: Tables - When a cell is highlighted, a thick border line displayed in the middle - https://phabricator.wikimedia.org/T88474#1939115 (10Esanders) 5Open>3stalled [17:22:01] 10VisualEditor, 10VisualEditor-Tables: Can't place cursor in empty table cells at https://cs.wikipedia.org/wiki/Seznam_židovských_památek_ve_Středočeském_kraji?veaction=edit - https://phabricator.wikimedia.org/T86703#1939117 (10Esanders) Can't reproduce [17:24:23] 10VisualEditor, 10VisualEditor-ContentEditable: VisualEditor: Drag-and-drop of a block image into a table slices the table rather than inserting inside the cell - https://phabricator.wikimedia.org/T75318#1939120 (10Esanders) 5Open>3Resolved a:3Esanders I think this has been fixed since we introduced bloc... [17:27:26] 10VisualEditor, 10VisualEditor-ContentEditable, 10VisualEditor-Tables, 10Parsoid: VisualEditor: Tables that are inserted into Media captions will display Table caption below the table - https://phabricator.wikimedia.org/T75435#1939127 (10Esanders) [17:28:34] 10VisualEditor, 10VisualEditor-ContentEditable, 10VisualEditor-Tables, 10Parsoid: VisualEditor: Tables that are inserted into Media captions will display Table caption below the table - https://phabricator.wikimedia.org/T75435#1939130 (10Esanders) This is an upstream issue with how Parsoid styles 10VisualEditor, 10VisualEditor-Tables: Can't place cursor in empty table cells at https://cs.wikipedia.org/wiki/Seznam_židovských_památek_ve_Středočeském_kraji?veaction=edit - https://phabricator.wikimedia.org/T86703#1939154 (10matmarex) Hmm… me neither now. There are comments in all the empty cells, and I'm... [17:44:48] (03PS15) 10Esanders: Tables: Move columns and rows [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/263869 (https://phabricator.wikimedia.org/T88694) [21:01:50] 10Cite, 5Patch-For-Review: Edit preview doesn't let you preview cite.php footnotes. - https://phabricator.wikimedia.org/T7984#1939284 (10Cenarium) >>! In T7984#1343285, @TheDJ wrote: > I've updated this patch a bit. Anyone wanna try it out ? I've given it a shot. [22:11:16] (03CR) 10Anomie: "Noticed a breaking change here that we should look at closer." [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/263881 (https://phabricator.wikimedia.org/T91455) (owner: 10Alex Monk) [22:11:55] (03CR) 10Anomie: "(d'oh)" (031 comment) [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/263881 (https://phabricator.wikimedia.org/T91455) (owner: 10Alex Monk) [23:40:04] 10VisualEditor, 10VisualEditor-Tables, 7Browser-Support-Firefox: [Regression wmf16]: Firefox only: Tables - When a cell is highlighted, a thick border line displayed in the middle - https://phabricator.wikimedia.org/T88474#1939361 (10Aklapper) (Exact numbers are welcome as "latest" in "latest FF" changes e... [23:48:10] 10VisualEditor: NEWSECTIONLINK and INDEX being added to articles - https://phabricator.wikimedia.org/T118796#1939363 (10Aklapper) I am going to merge this into T100691 - see the argumentation given there. [23:48:16] 10VisualEditor: NEWSECTIONLINK and INDEX being added to articles - https://phabricator.wikimedia.org/T118796#1939365 (10Aklapper) [23:48:18] 10VisualEditor: defeature __NOEDITSECTION__ from VE - https://phabricator.wikimedia.org/T100691#1318523 (10Aklapper)