[00:10:35] <grrrit-wm>	 (03PS16) 10Esanders: Tables: Move columns and rows [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/263869 (https://phabricator.wikimedia.org/T88694) 
[00:10:37] <grrrit-wm>	 (03PS1) 10Esanders: Multi-cell table copy and paste [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/265660 
[00:12:32] <wikibugs>	 10VisualEditor, 10VisualEditor-Tables, 5Patch-For-Review, 7notice, 7user-notice: Be able to re-order the columns or rows of a table in VisualEditor - https://phabricator.wikimedia.org/T88694#1954196 (10Esanders)
[00:14:11] <wikibugs>	 10VisualEditor, 10VisualEditor-CopyPaste, 10VisualEditor-Tables: Allow copy/pasting of arbitrary selections of table cells - https://phabricator.wikimedia.org/T85791#1954202 (10Esanders)
[00:14:43] <grrrit-wm>	 (03PS2) 10Esanders: Multi-cell table copy and paste [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/265660 (https://phabricator.wikimedia.org/T85791) 
[00:14:45] <grrrit-wm>	 (03PS17) 10Esanders: Tables: Move columns and rows [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/263869 (https://phabricator.wikimedia.org/T88694) 
[00:17:21] <grrrit-wm>	 (03CR) 10Jforrester: [C: 031] Don't restrict format parameter in the API [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/263881 (https://phabricator.wikimedia.org/T91455) (owner: 10Alex Monk)
[00:50:07] <grrrit-wm>	 (03CR) 10Esanders: "CC'ing Roan to look at the newFromDocumentInsertion issue, because that's all his fault..." [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/265660 (https://phabricator.wikimedia.org/T85791) (owner: 10Esanders)
[00:56:55] <wikibugs>	 10VisualEditor, 10VisualEditor-EditingTools, 10VisualEditor-Tables: VisualEditor:Hiero is getting copied as Empty template while copying from Chrome to FF - https://phabricator.wikimedia.org/T60982#1954354 (10Esanders) 5stalled>3Resolved a:3Esanders WFM. Likely fixed at some point in the last two years.
[00:59:16] <wikibugs>	 10VisualEditor, 10VisualEditor-CopyPaste, 10VisualEditor-Tables: Pasting a table from LibreOffice creates a lot of whitespace and blanklines in the wikitext - https://phabricator.wikimedia.org/T102906#1954360 (10Esanders)
[01:15:35] <grrrit-wm>	 (03PS1) 10Esanders: ElementLinearData#Sanitize: Remove meaningless HTML whitespace by default [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/265672 (https://phabricator.wikimedia.org/T102906) 
[01:17:36] <grrrit-wm>	 (03PS3) 10Esanders: Multi-cell table copy and paste [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/265660 (https://phabricator.wikimedia.org/T85791) 
[01:17:39] <grrrit-wm>	 (03PS18) 10Esanders: Tables: Move columns and rows [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/263869 (https://phabricator.wikimedia.org/T88694) 
[01:23:52] <wikibugs>	 10VisualEditor, 10VisualEditor-CopyPaste, 10VisualEditor-Tables: Clean up mess from copy-pasted tables - https://phabricator.wikimedia.org/T97462#1954411 (10Esanders) VE should be stripping all HTML attributes for external paste, so can we get precise reproduction steps?
[01:25:57] <wikibugs>	 10VisualEditor, 10VisualEditor-Tables, 7Browser-Support-Firefox: Missing cells look like they're present in Firefox - https://phabricator.wikimedia.org/T85463#1954416 (10Esanders) 5Open>3declined a:3Esanders This is the same in read mode - so this is a bug in Firefox, not VE:  https://en.wikipedia.org/...
[01:27:21] <wikibugs>	 10VisualEditor, 10VisualEditor-Tables: Allow keyboard arrows to move between cells in a table - https://phabricator.wikimedia.org/T84851#1954426 (10Esanders) 5Open>3Resolved a:3Esanders Bug as filed is resolved.
[01:30:19] <wikibugs>	 10VisualEditor, 10VisualEditor-Tables, 7Design: Tables: Delete table should be an option from the context tooltip, not in the toolbar - https://phabricator.wikimedia.org/T76676#1954431 (10Esanders) Many tables are larger than the viewport so we'd need to think about context placement. 'Embedding' the context...
[01:31:34] <wikibugs>	 10VisualEditor, 10VisualEditor-Tables, 7Design: Tables: If you select N rows / columns and click "insert above/below" or "… left/right", VE should insert N rows / columns, not 1 - https://phabricator.wikimedia.org/T75227#1954435 (10Esanders) ..or we could show two options when more than one cell is selected...
[01:32:57] <wikibugs>	 10VisualEditor, 10VisualEditor-ContentEditable, 10VisualEditor-Tables: Applying text formatting to empty cell does not format the text entered afterwards - https://phabricator.wikimedia.org/T74825#1954441 (10Esanders) p:5Normal>3Low
[02:31:47] <wikibugs>	 10VisualEditor, 10VisualEditor-MediaWiki, 7Wikimedia-log-errors: Notice: Undefined index: 1 in /srv/mediawiki/php-1.27.0-wmf.11/extensions/VisualEditor/VisualEditor.hooks.php on line 83 - https://phabricator.wikimedia.org/T124264#1954520 (10Krenair) a:3Krenair
[02:31:59] <grrrit-wm>	 (03PS1) 10Alex Monk: Try to do a better job of matching user agent strings [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/265680 (https://phabricator.wikimedia.org/T124264) 
[02:32:40] <grrrit-wm>	 (03PS2) 10Alex Monk: Try to do a better job of matching user agent strings [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/265680 (https://phabricator.wikimedia.org/T124264) 
[03:17:18] <wikibugs>	 10TemplateData: Template Documentation Editor does not understand #tag parser function - https://phabricator.wikimedia.org/T124338#1954560 (10maiden_taiwan) @Krenair: I don't blame you. :-)  I encourage you to formally document on Extension:TemplateData that you do not support `#tag:templatedata`, since it is va...
[11:41:30] <wikibugs>	 10VisualEditor, 10VisualEditor-CopyPaste, 10VisualEditor-MediaWiki, 10VisualEditor-MediaWiki-Media, 7I18n: When copying an image from a non-English wiki, use the correct File: namespace for the target wiki, not the source wiki - https://phabricator.wikimedia.org/T123768#1955107 (10Elitre) T110104 ?
[11:46:04] <wikibugs>	 10VisualEditor, 10VisualEditor-ContentEditable: Drag and drop or position of table using VE - https://phabricator.wikimedia.org/T86044#1955127 (10Elitre) See also T123826 .
[12:18:29] <Elitre>	 hey edsanders 
[12:18:49] <edsanders>	 hi
[12:19:02] <Elitre>	 thought you guys had a standup in the European morning or something?
[12:19:59] <edsanders>	 We haven't done those for a while actually
[12:20:15] <Elitre>	 ha!
[12:45:13] <wikibugs>	 10VisualEditor: Interwiki link is generated as uppercase, not idempotent - https://phabricator.wikimedia.org/T124410#1955194 (10awight) 3NEW
[15:51:21] <wikibugs>	 10WikiEditor, 7Easy, 7JavaScript: Remove button for <big> from toolbar - https://phabricator.wikimedia.org/T40487#1955587 (10Danny_B)
[15:51:54] <wikibugs>	 10WikiEditor, 7Easy, 7JavaScript: Remove button for <big> from toolbar - https://phabricator.wikimedia.org/T40487#1955591 (10Danny_B) p:5Low>3Normal
[15:54:07] <wikibugs>	 10VisualEditor, 10MediaWiki-extensions-Translate: when forgetting a newline after translate marker VE doesn't display the real error message - https://phabricator.wikimedia.org/T122276#1955594 (10Nikerabbit) If you request a change in Translate, please state what that is explicitly.
[15:56:41] <wikibugs>	 10VisualEditor, 6Community-Liaison, 6Editing-Analysis: Find out why the visual editor is so used at the Portuguese Wikipedia - https://phabricator.wikimedia.org/T115724#1955615 (10Elitre) (Sometimes at night, when I can't sleep, I stare at the ceiling and think about this task.) The only "explanation" I coul...
[16:01:54] <wikibugs>	 10VisualEditor, 6Community-Liaison, 6Editing-Analysis: Find out why the visual editor is so used at the Portuguese Wikipedia - https://phabricator.wikimedia.org/T115724#1955639 (10Elitre)
[16:21:57] <grrrit-wm>	 (03CR) 10Jforrester: [C: 032] ElementLinearData#Sanitize: Remove meaningless HTML whitespace by default [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/265672 (https://phabricator.wikimedia.org/T102906) (owner: 10Esanders)
[16:22:24] <wikibugs>	 10VisualEditor, 10VisualEditor-CopyPaste, 10VisualEditor-Tables: Pasting a table from LibreOffice creates a lot of whitespace and blanklines in the wikitext - https://phabricator.wikimedia.org/T102906#1955753 (10Jdforrester-WMF) 5Open>3Resolved a:3Esanders
[16:26:06] <grrrit-wm>	 (03Merged) 10jenkins-bot: ElementLinearData#Sanitize: Remove meaningless HTML whitespace by default [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/265672 (https://phabricator.wikimedia.org/T102906) (owner: 10Esanders)
[16:31:04] <grrrit-wm>	 (03CR) 10DLynch: [C: 04-1] "It totally works -- creating a language annotation gets a 1px wide disabled selection maintaining the cursor appearance." (031 comment) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/265423 (owner: 10Esanders)
[16:31:58] <James_F>	 Kemayo: Want me to cut the end off the comment so you can +2 'cleanly'? :-)
[16:32:11] <Kemayo>	 Sure.
[16:32:25] <Kemayo>	 It's more fun to just say "this works! -1", of course.
[16:32:29] <James_F>	 :-D
[16:33:35] <grrrit-wm>	 (03PS2) 10Jforrester: ce.Surface: Show deactivated selection when cursor is collapsed [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/265423 (owner: 10Esanders)
[16:33:46] <grrrit-wm>	 (03CR) 10Jforrester: ce.Surface: Show deactivated selection when cursor is collapsed (031 comment) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/265423 (owner: 10Esanders)
[16:34:07] <wikibugs>	 10VisualEditor, 6Community-Liaison, 6Editing-Analysis: Find out why the visual editor is so used at the Portuguese Wikipedia - https://phabricator.wikimedia.org/T115724#1955802 (10Qgil) > We may be particularly interested in why IPs prefer it to wikitext editing  Maybe because for newcomers "Editar código-fo...
[16:34:37] <grrrit-wm>	 (03CR) 10DLynch: [C: 032] ce.Surface: Show deactivated selection when cursor is collapsed [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/265423 (owner: 10Esanders)
[16:36:40] <grrrit-wm>	 (03CR) 10DLynch: [C: 032] Fix logic for showing alien context item [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/265497 (owner: 10Esanders)
[16:40:02] <grrrit-wm>	 (03CR) 10Jforrester: [C: 04-1] Multi-cell table copy and paste (031 comment) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/265660 (https://phabricator.wikimedia.org/T85791) (owner: 10Esanders)
[16:40:08] <grrrit-wm>	 (03Merged) 10jenkins-bot: ce.Surface: Show deactivated selection when cursor is collapsed [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/265423 (owner: 10Esanders)
[16:40:11] <grrrit-wm>	 (03Merged) 10jenkins-bot: Fix logic for showing alien context item [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/265497 (owner: 10Esanders)
[16:40:22] <wikibugs>	 10VisualEditor, 10VisualEditor-MediaWiki-Links, 6Collaboration-Team-Backlog, 10Flow: [Regression wmf23] On creating an inter-wiki link, the nice regex strips section parts of the link - https://phabricator.wikimedia.org/T112898#1955807 (10Trizek-WMF) Also concerns #Flow
[16:42:12] <wikibugs>	 10VisualEditor, 10VisualEditor-Tables, 5Patch-For-Review, 7user-notice: Be able to copy/paste whole tables, without selecting anything else on the page - https://phabricator.wikimedia.org/T123826#1955810 (10Trizek-WMF)
[16:43:59] <grrrit-wm>	 (03CR) 10Esanders: Multi-cell table copy and paste (031 comment) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/265660 (https://phabricator.wikimedia.org/T85791) (owner: 10Esanders)
[16:45:03] <grrrit-wm>	 (03PS4) 10Esanders: Multi-cell table copy and paste [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/265660 (https://phabricator.wikimedia.org/T85791) 
[16:45:05] <grrrit-wm>	 (03PS19) 10Esanders: Tables: Move columns and rows [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/263869 (https://phabricator.wikimedia.org/T88694) 
[16:46:04] <grrrit-wm>	 (03CR) 10Esanders: "fixme" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/265423 (owner: 10Esanders)
[16:46:12] <edsanders>	 James_F, ^^
[16:46:35] <James_F>	 ?
[16:46:35] <edsanders>	 agh
[16:46:51] <edsanders>	 can't leave a comment on an old patchset apparently
[16:47:01] <grrrit-wm>	 (03CR) 10Esanders: ce.Surface: Show deactivated selection when cursor is collapsed (031 comment) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/265423 (owner: 10Esanders)
[16:47:09] <James_F>	 Ah
[16:47:09] <edsanders>	 there
[16:47:16] <wikibugs>	 10VisualEditor, 6Community-Liaison, 6Editing-Analysis: Find out why the visual editor is so used at the Portuguese Wikipedia - https://phabricator.wikimedia.org/T115724#1955821 (10Elitre) >>! In T115724#1955802, @Qgil wrote: >> We may be particularly interested in why IPs prefer it to wikitext editing >  > M...
[16:47:55] <edsanders>	 you feeling better?
[16:49:35] <James_F>	 A bit.
[16:49:54] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Multi-cell table copy and paste [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/265660 (https://phabricator.wikimedia.org/T85791) (owner: 10Esanders)
[16:50:02] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Tables: Move columns and rows [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/263869 (https://phabricator.wikimedia.org/T88694) (owner: 10Esanders)
[16:50:12] <James_F>	 edsanders: Given that 265660 worked without a key file, I'm guessing it's not got any unit tests…
[16:55:59] <edsanders>	 not yet
[16:56:12] <edsanders>	 table unit tests are... long
[16:56:28] <James_F>	 Slacker. :-)
[16:56:32] <edsanders>	 especially the edge cases
[16:57:00] * James_F sighs.
[16:57:00] <edsanders>	 you played with it locally
[16:57:00] <James_F>	 Yeah.
[16:57:00] <edsanders>	 ?
[16:57:01] <James_F>	 Way too many of those with tables.
[16:57:02] <edsanders>	 it's great fun
[16:57:22] <edsanders>	 the logic isn't that complicated so I'm not too worried about it breaking actually
[16:57:35] <James_F>	 Yeah, it's nice.
[16:57:47] <edsanders>	 it just expands, the tables, clears the target area (unmerges everything in sight) and overwrites the data
[16:57:52] <James_F>	 I should +1 once I'm satisfied I've not found too horrible a set of bugs.
[16:57:58] <edsanders>	 and because selections are required to be rectangular, there are no problems there
[16:58:14] <James_F>	 Let's hope we don't later do non-rectangular selections.
[16:58:15] <edsanders>	 <td><ref/></td> is the only thing that is broken
[16:59:02] <edsanders>	 you'll need to add tableSlice to extension.json to test that
[16:59:19] <James_F>	 The main issue I've found in SA is pasting contents larger than a table into the table.
[17:00:28] <edsanders>	 ?
[17:00:37] <edsanders>	 it grows the table though
[17:01:51] <James_F>	 Not for me.
[17:01:55] <James_F>	 Instead it just blanks the first cell.
[17:02:38] <James_F>	 E.g. select from "2" to "26" from "Merged cells", click on "A" in "Simple table".
[17:02:41] <James_F>	 It become wide but blank; double click on it and it goes back to normal width.
[17:04:06] <edsanders>	 that sounds like it is crashing after beforePaste (which removes the contents of the first cell)
[17:04:11] <edsanders>	 anything in the console?
[17:04:21] <James_F>	 Ah.
[17:04:21] <edsanders>	 WFM locally - try cache clearing
[17:04:26] <James_F>	 Aha, yes.
[17:04:41] <James_F>	 "Uncaught TypeError: Cannot read property 'translateByTransactions' of undefined"
[17:04:42] <James_F>	 In meeting now. Later.
[17:05:23] <wikibugs>	 10VisualEditor: Change a ref group name with the visual editor removes the reference itself - https://phabricator.wikimedia.org/T124439#1955875 (10Trizek-WMF) 3NEW
[17:06:30] <James_F>	 edsanders: TableAction line 583; 'selection' is undefined.
[17:06:30] <edsanders>	 maybe I have some code in the wrong commit (the row move commit)
[17:06:47] <grrrit-wm>	 (03PS1) 10Tchanders: Add method for setting minimum number of rows in Ace editor widget [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/265765 (https://phabricator.wikimedia.org/T123891) 
[17:07:33] <James_F>	 Could be.
[17:08:01] <edsanders>	 yeah - conflict with the next commit
[17:18:58] <edsanders>	 jsduck dependency of the week: https://github.com/nene/rkelly-remix
[17:28:00] <grrrit-wm>	 (03PS5) 10Esanders: Multi-cell table copy and paste [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/265660 (https://phabricator.wikimedia.org/T85791) 
[17:28:02] <grrrit-wm>	 (03PS20) 10Esanders: Tables: Move columns and rows [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/263869 (https://phabricator.wikimedia.org/T88694) 
[17:47:14] <wikibugs>	 10VisualEditor, 10VisualEditor-CopyPaste: Copy and paste(?) leads to VE adding non-breaking spaces inside span tags - https://phabricator.wikimedia.org/T108155#1956017 (10Jdforrester-WMF)
[17:47:16] <wikibugs>	 10VisualEditor, 10VisualEditor-MediaWiki, 10Parsoid: VE silently alters non-breaking spaces into normal spaces - https://phabricator.wikimedia.org/T96701#1956018 (10Jdforrester-WMF)
[17:47:18] <wikibugs>	 10VisualEditor, 10VisualEditor-ContentEditable, 5Patch-For-Review: Make non-breaking spaces (nbsp) visible in VisualEditor - https://phabricator.wikimedia.org/T96666#1956016 (10Jdforrester-WMF)
[17:58:27] <wikibugs>	 10VisualEditor, 10VisualEditor-ContentEditable, 5Patch-For-Review: Make non-breaking spaces (nbsp) visible in VisualEditor - https://phabricator.wikimedia.org/T96666#1956063 (10Trizek-WMF) I ask James to add the blocking tasks that need to be fixed before make &nbsp; visible on wikis. When all this is fixed,...
[18:02:05] <grrrit-wm>	 (03PS12) 10Alex Monk: [WIP] Use widgets for wiki-page-name and wiki-user-name parameters [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/169936 (https://phabricator.wikimedia.org/T55613) 
[18:02:42] <grrrit-wm>	 (03CR) 10Jforrester: [C: 031] "LGTM." [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/265660 (https://phabricator.wikimedia.org/T85791) (owner: 10Esanders)
[18:02:44] <grrrit-wm>	 (03PS13) 10Alex Monk: [WIP] Use widgets for wiki-page-name and wiki-user-name parameters [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/169936 (https://phabricator.wikimedia.org/T55613) 
[18:05:21] <grrrit-wm>	 (03PS1) 10IoannisKydonis: Update documentation of citoid-citefromiddialog-use-general-error-message [extensions/Citoid] - 10https://gerrit.wikimedia.org/r/265780 
[18:06:20] <grrrit-wm>	 (03CR) 10DLynch: [C: 032] Add method for setting minimum number of rows in Ace editor widget [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/265765 (https://phabricator.wikimedia.org/T123891) (owner: 10Tchanders)
[18:06:42] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] [WIP] Use widgets for wiki-page-name and wiki-user-name parameters [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/169936 (https://phabricator.wikimedia.org/T55613) (owner: 10Alex Monk)
[18:09:53] <grrrit-wm>	 (03Merged) 10jenkins-bot: Add method for setting minimum number of rows in Ace editor widget [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/265765 (https://phabricator.wikimedia.org/T123891) (owner: 10Tchanders)
[18:13:02] <grrrit-wm>	 (03CR) 10Jforrester: [C: 031] Tables: Move columns and rows [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/263869 (https://phabricator.wikimedia.org/T88694) (owner: 10Esanders)
[18:15:14] <grrrit-wm>	 (03CR) 10Divec: [C: 032] Initial cursor position: outside any nails [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/260057 (https://phabricator.wikimedia.org/T114376) (owner: 10DLynch)
[18:19:35] <wikibugs>	 10VisualEditor, 10VisualEditor-ContentEditable: When a link is the first element on a page, don't launch the link context menu automatically; instead put the cursor in the placement outside the link - https://phabricator.wikimedia.org/T114376#1956191 (10Jdforrester-WMF) 5Open>3Resolved
[18:20:39] <grrrit-wm>	 (03Merged) 10jenkins-bot: Initial cursor position: outside any nails [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/260057 (https://phabricator.wikimedia.org/T114376) (owner: 10DLynch)
[18:31:02] <grrrit-wm>	 (03PS14) 10Alex Monk: [WIP] Use widgets for wiki-page-name and wiki-user-name parameters [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/169936 (https://phabricator.wikimedia.org/T55613) 
[18:32:57] <Krenair>	 James_F, hey
[18:36:32] <James_F>	 Hey.
[18:37:19] <grrrit-wm>	 (03PS2) 10Mvolz: [WIP] Allow users to select cite template [extensions/Citoid] - 10https://gerrit.wikimedia.org/r/265200 (https://phabricator.wikimedia.org/T97936) 
[18:38:09] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] [WIP] Allow users to select cite template [extensions/Citoid] - 10https://gerrit.wikimedia.org/r/265200 (https://phabricator.wikimedia.org/T97936) (owner: 10Mvolz)
[18:38:14] <grrrit-wm>	 (03CR) 10Jforrester: [C: 032] "Thank you!" [extensions/Citoid] - 10https://gerrit.wikimedia.org/r/265780 (owner: 10IoannisKydonis)
[18:38:29] <grrrit-wm>	 (03PS3) 10Mvolz: [WIP] Allow users to select cite template [extensions/Citoid] - 10https://gerrit.wikimedia.org/r/265200 (https://phabricator.wikimedia.org/T97936) 
[18:39:04] <grrrit-wm>	 (03Merged) 10jenkins-bot: Update documentation of citoid-citefromiddialog-use-general-error-message [extensions/Citoid] - 10https://gerrit.wikimedia.org/r/265780 (owner: 10IoannisKydonis)
[18:45:01] <wikibugs>	 10Citoid, 10VisualEditor, 10VisualEditor-MediaWiki-Templates, 5Patch-For-Review, 15User-Josve05a: Allow user to switch cite template in limited circumstances - https://phabricator.wikimedia.org/T97936#1956360 (10Mvolz) a:3Mvolz
[18:45:25] <grrrit-wm>	 (03PS1) 10Esanders: MWTableNode: Apply wikitable class to pasted tables [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/265785 (https://phabricator.wikimedia.org/T85577) 
[18:50:10] <Krenair>	 James_F, was thinking about the template parameter type stuff
[18:50:44] <Krenair>	 I did have https://gerrit.wikimedia.org/r/#/c/169936/ sitting around which I rebased
[18:51:43] <Krenair>	 the problem was cases where we actually end up restricting user input through this, i.e. if we did special input types for boolean/number/etc.
[18:51:55] <Krenair>	 the commit currently includes number
[18:52:08] <Krenair>	 but I wonder if we took that out, could we get the basic suggestion inputs for user/page etc. in
[18:56:15] <grrrit-wm>	 (03PS1) 10Esanders: Remove background colour form table headers [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/265786 
[18:57:13] <James_F>	 Krenair: We'd still need for people to put in {{echo|User:Foo}} for a user input though…
[18:57:29] <James_F>	 Krenair: Let me sketch something.
[19:06:10] <James_F>	 Krenair: Maybe something a bit like https://dl.dropboxusercontent.com/u/17195534/Screen%20Shot%202016-01-22%20at%2011.05.20.png ?
[19:07:15] <grrrit-wm>	 (03CR) 10Jforrester: [C: 032] MWTableNode: Apply wikitable class to pasted tables [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/265785 (https://phabricator.wikimedia.org/T85577) (owner: 10Esanders)
[19:07:34] <wikibugs>	 10VisualEditor, 10VisualEditor-CopyPaste, 10VisualEditor-Tables: Automatically give pasted tables class="wikitable" in VE-MW - https://phabricator.wikimedia.org/T85577#1956504 (10Jdforrester-WMF) 5Open>3Resolved a:3Esanders
[19:10:42] <grrrit-wm>	 (03Merged) 10jenkins-bot: MWTableNode: Apply wikitable class to pasted tables [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/265785 (https://phabricator.wikimedia.org/T85577) (owner: 10Esanders)
[19:11:07] <wikibugs>	 10VisualEditor, 10VisualEditor-Media, 6Multimedia: MWMediaDialog: exception  "Local uploads are disabled" - https://phabricator.wikimedia.org/T119314#1956526 (10Jdforrester-WMF) 5Open>3Resolved
[19:13:28] <grrrit-wm>	 (03CR) 10Jforrester: [C: 031] Try to put TemplateData in an existing noinclude at bottom of the page [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/263641 (https://phabricator.wikimedia.org/T96537) (owner: 10Alex Monk)
[19:20:05] <wikibugs>	 10TemplateData, 10VisualEditor, 10VisualEditor-MediaWiki-Templates, 7Design, 5Patch-For-Review: Create dedicated input methods for transclusion parameters (using "Param#type" from TemplateData) - https://phabricator.wikimedia.org/T55613#1956596 (10Jdforrester-WMF)
[19:21:12] <wikibugs>	 10VisualEditor, 10MediaWiki-extensions-RelatedArticles: RelatedArticles disappears during edit process when using VisualEditor - https://phabricator.wikimedia.org/T120443#1956603 (10Jdforrester-WMF)
[19:21:14] <wikibugs>	 10VisualEditor: VisualEditor should fire an event on opening to allow other scripts to clean up - https://phabricator.wikimedia.org/T121050#1956602 (10Jdforrester-WMF) 5Open>3stalled
[19:21:34] <wikibugs>	 10Citoid, 10VisualEditor, 6Services: Citoid fails to cite from link to dx.doi.org - https://phabricator.wikimedia.org/T121265#1956605 (10Jdforrester-WMF)
[19:22:05] <James_F>	 edsanders: Could you respond for VE on https://phabricator.wikimedia.org/T122390 or nominate someone else to do so
[19:22:18] <James_F>	 ?
[19:22:23] <wikibugs>	 10VisualEditor, 10VisualEditor-MediaWiki, 6Editing-Analysis, 6Editing-Department, and 2 others: EventLogging validation error: 'user.id' is a required property (schema:Edit) - https://phabricator.wikimedia.org/T116717#1956607 (10Jdforrester-WMF)
[19:23:28] <wikibugs>	 10VisualEditor, 10VisualEditor-MediaWiki: Provide a GET URL option on action=edit to force loading the wikitext editor, not the visual editor, regardless of preference - https://phabricator.wikimedia.org/T121242#1956609 (10Jdforrester-WMF)
[19:24:49] <wikibugs>	 10VisualEditor, 10VisualEditor-MediaWiki: Provide a GET URL option on action=edit to force loading the wikitext editor, not the visual editor, regardless of preference - https://phabricator.wikimedia.org/T121242#1873458 (10Jdforrester-WMF) >>! In T121242#1874504, @Krenair wrote: > If we make editor=wikitext, d...
[19:25:55] <wikibugs>	 10VisualEditor, 10Wikimedia-Site-Requests, 5Patch-For-Review: Re-enable VisualEditor by default for all users of the English Wikipedia - https://phabricator.wikimedia.org/T90662#1956615 (10Jdforrester-WMF)
[19:26:23] <wikibugs>	 10VisualEditor, 10Math: Add a new "Algebra" section to the math dialog - https://phabricator.wikimedia.org/T123399#1956618 (10Jdforrester-WMF)
[19:26:28] <wikibugs>	 10VisualEditor, 10Math: Give SVGs in the math dialog menu the same baseline - https://phabricator.wikimedia.org/T123397#1956620 (10Jdforrester-WMF)
[19:26:33] <wikibugs>	 10VisualEditor, 10Math, 5Patch-For-Review: Improve calculus in the math dialog - https://phabricator.wikimedia.org/T123394#1956622 (10Jdforrester-WMF)
[19:26:38] <wikibugs>	 10VisualEditor, 10Math: Add more functions to the math dialog - https://phabricator.wikimedia.org/T123391#1956624 (10Jdforrester-WMF)
[19:26:44] <wikibugs>	 10VisualEditor, 10Math: Include more standard numerical functions in the math dialog - https://phabricator.wikimedia.org/T123390#1956626 (10Jdforrester-WMF)
[19:26:49] <wikibugs>	 10VisualEditor, 10Math: Rework the "Bounds" section of the math dialog menu - https://phabricator.wikimedia.org/T123393#1956627 (10Jdforrester-WMF)
[19:26:53] <wikibugs>	 10VisualEditor, 10Math: Improve the "Subscripts, superscripts and integrals" section in the math dialog - https://phabricator.wikimedia.org/T123396#1956629 (10Jdforrester-WMF)
[19:26:59] <wikibugs>	 10VisualEditor, 10Math: Improve the coverage and organisation of the math dialog functions - https://phabricator.wikimedia.org/T123402#1956631 (10Jdforrester-WMF)
[19:27:06] <wikibugs>	 10VisualEditor, 10Math: Improve the coverage and organisation of the math dialog functions - https://phabricator.wikimedia.org/T123402#1928575 (10Jdforrester-WMF)
[19:31:00] <grrrit-wm>	 (03CR) 10Jforrester: [C: 032] Remove background colour form table headers [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/265786 (owner: 10Esanders)
[19:32:27] <grrrit-wm>	 (03CR) 10Nemo bis: "Note to self: used for https://codein.withgoogle.com/dashboard/tasks/6632788748926976/" [extensions/Citoid] - 10https://gerrit.wikimedia.org/r/265780 (owner: 10IoannisKydonis)
[19:34:46] <grrrit-wm>	 (03Merged) 10jenkins-bot: Remove background colour form table headers [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/265786 (owner: 10Esanders)
[19:36:09] <Krenair>	 James_F, right, but doesn't the user input widget allow any input while suggesting only users?
[19:38:33] <James_F>	 Krenair: Or should it restrict you to valid user name, and suggest existing users.
[19:38:53] <James_F>	 Krenair: So you can add a username that doesn't exist yet, but you can't use a username that can't be valid like "Foo#~@Bar".
[19:41:52] <Krenair>	 James_F, I suppose that's a valid question
[19:41:57] <Krenair>	 at the moment it doesn't
[19:45:26] <wikibugs>	 10VisualEditor, 10ContentTranslation-cxserver, 10Parsoid, 10RESTBase, and 2 others: Is RDFa metadata in Parsoid HTML head actually useful to you / no user name & edit comment suppression in Parsoid <head> metadata - https://phabricator.wikimedia.org/T122390#1956753 (10Esanders) @catrope will be best placed...
[19:49:01] <Krenair>	 James_F, I think that if we did decide to add the ability to restrict input to valid usernames, it would be optional
[19:51:52] <wikibugs>	 10VisualEditor, 10ContentTranslation-cxserver, 10Parsoid, 10RESTBase, and 2 others: Is RDFa metadata in Parsoid HTML head actually useful to you / no user name & edit comment suppression in Parsoid <head> metadata - https://phabricator.wikimedia.org/T122390#1956771 (10GWicke) We have recently started to lo...
[19:56:36] <wikibugs>	 10VisualEditor, 10ContentTranslation-cxserver, 10Parsoid, 10RESTBase, and 2 others: Is RDFa metadata in Parsoid HTML head actually useful to you / no user name & edit comment suppression in Parsoid <head> metadata - https://phabricator.wikimedia.org/T122390#1956798 (10Esanders) Looking at the snippet and o...
[19:58:43] <grrrit-wm>	 (03PS1) 10Jforrester: Follow-up I04ca47: Adjust comment to note we still care it's native [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/265801 
[19:59:54] <James_F>	 edsanders: Were you thinking to fix the TODO on https://gerrit.wikimedia.org/r/#/c/265660/ or do it later?
[20:00:37] <edsanders>	 I think having it throw an exception when you try to copy a reference is probably not a good thing
[20:01:41] <James_F>	 True.
[20:01:57] <James_F>	 edsanders: https://gerrit.wikimedia.org/r/#/c/265801/ +2 please.
[20:05:48] <wikibugs>	 10VisualEditor, 10MediaWiki-extensions-RelatedArticles: RelatedArticles disappears during edit process when using VisualEditor - https://phabricator.wikimedia.org/T120443#1956826 (10Esanders)
[20:05:50] <wikibugs>	 10VisualEditor: VisualEditor should fire an event on opening to allow other scripts to clean up - https://phabricator.wikimedia.org/T121050#1956823 (10Esanders) 5stalled>3declined a:3Esanders We actually have a hook that fires on activation: ve.activationComplete, but it should be used sparingly. Edit mode...
[20:07:08] <grrrit-wm>	 (03CR) 10Esanders: [C: 032] Follow-up I04ca47: Adjust comment to note we still care it's native [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/265801 (owner: 10Jforrester)
[20:12:27] <grrrit-wm>	 (03Merged) 10jenkins-bot: Follow-up I04ca47: Adjust comment to note we still care it's native [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/265801 (owner: 10Jforrester)
[20:14:29] <grrrit-wm>	 (03PS1) 10Esanders: Follow-up I9714cf3: Add tests for wikitable paste [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/265812 (https://phabricator.wikimedia.org/T85577) 
[20:14:36] <grrrit-wm>	 (03Abandoned) 10Alex Monk: When switching from WE to VE, parse display title on the server and replace the title shown [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/252218 (https://phabricator.wikimedia.org/T117643) (owner: 10Alex Monk)
[20:15:31] <James_F>	 edsanders: You and your actually-testing-things ethic. It'll get us killed, or worse, expelled.
[20:15:43] <grrrit-wm>	 (03CR) 10Jforrester: [C: 032] Follow-up I9714cf3: Add tests for wikitable paste [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/265812 (https://phabricator.wikimedia.org/T85577) (owner: 10Esanders)
[20:17:20] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Follow-up I9714cf3: Add tests for wikitable paste [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/265812 (https://phabricator.wikimedia.org/T85577) (owner: 10Esanders)
[20:19:51] <grrrit-wm>	 (03PS21) 10Esanders: Tables: Move columns and rows [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/263869 (https://phabricator.wikimedia.org/T88694) 
[20:21:14] <grrrit-wm>	 (03Merged) 10jenkins-bot: Follow-up I9714cf3: Add tests for wikitable paste [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/265812 (https://phabricator.wikimedia.org/T85577) (owner: 10Esanders)
[20:23:27] <grrrit-wm>	 (03PS1) 10Alex Monk: When loading VE, replace the title shown [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/265815 (https://phabricator.wikimedia.org/T117643) 
[20:25:30] <Krenair>	 maybe I should put that inside a check for action=edit/submit..
[20:28:36] <grrrit-wm>	 (03PS2) 10Alex Monk: When loading VE from action=edit/submit, replace the title shown [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/265815 (https://phabricator.wikimedia.org/T117643) 
[20:29:06] <grrrit-wm>	 (03PS1) 10Jforrester: Update VE core submodule to master (0329d1d) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/265816 
[20:35:28] <grrrit-wm>	 (03CR) 10Esanders: [C: 032] Update VE core submodule to master (0329d1d) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/265816 (owner: 10Jforrester)
[20:37:00] <grrrit-wm>	 (03CR) 10Esanders: [C: 032] When loading VE from action=edit/submit, replace the title shown [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/265815 (https://phabricator.wikimedia.org/T117643) (owner: 10Alex Monk)
[20:37:24] <Krenair>	 Krinkle, so we need a way to detect that VE failed to load because of the startup.js UA checks
[20:39:49] <wikibugs>	 10VisualEditor, 10VisualEditor-MediaWiki: The text "Editing" is appearing before the article title  when I switch to VisualEditor - https://phabricator.wikimedia.org/T117643#1956941 (10Jdforrester-WMF) 5Open>3Resolved a:3Krenair
[20:40:12] <grrrit-wm>	 (03Merged) 10jenkins-bot: Update VE core submodule to master (0329d1d) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/265816 (owner: 10Jforrester)
[20:40:14] <wikibugs>	 10VisualEditor, 10VisualEditor-MediaWiki: The text "Editing" is appearing before the article title  when I switch to VisualEditor - https://phabricator.wikimedia.org/T117643#1780474 (10Jdforrester-WMF) We've mostly-ish fixed this; there are some edge cases, but let's close for now.
[20:40:15] <Krenair>	 was wondering if I could add a script to the end of the page that detects the client-nojs class or something
[20:43:04] <grrrit-wm>	 (03Merged) 10jenkins-bot: When loading VE from action=edit/submit, replace the title shown [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/265815 (https://phabricator.wikimedia.org/T117643) (owner: 10Alex Monk)
[21:03:40] <Krinkle>	 Krenair: Can you elaborate on that question?
[21:04:06] <Krinkle>	 Krenair: If you're looking for a <script> that only runs if-supported, use <script>RLQ, or rather, RL::makeInlineScript
[21:04:09] <Krinkle>	 (or whatever it is called)
[21:04:30] <Krinkle>	 What is the action if not supported?
[21:04:48] <Krinkle>	 Should be the same as the no-js version, which is served by default if the script didn't ran?
[21:05:34] <Krinkle>	 Hm.. since this is a redirect to a different server render (we optimise for js version, which is the default server render right?) - then we need a way to redirect that isn't <noscript> and not <script>RLQ but in between.
[21:10:29] <James_F>	 Krinkle: Yeah.
[21:11:16] <Krinkle>	 One possible work around you might want to consider in the short term is a raw <script> (that doesn't use RL::makeInlineScript) in which you call the global isCompatible() function.
[21:11:24] <Krinkle>	 and redirect if false.
[21:11:49] <Krinkle>	 That's conceptually considered a private method, but at least it's pretty stable. Something we can maintain and reason about.
[21:12:44] <James_F>	 Or, at least, we can shout at you if it breaks in the next few months whilst we figure out the long-term way forward/
[21:12:51] <Krenair>	 Krinkle, no, I'm looking to make a script that runs if *not* supported
[21:13:46] <Krenair>	 There's cases where if the server expects the client to load VE but the client doesn't (e.g., because they aren't running our JS), the client will not be able to get any editor.
[21:14:23] <Krenair>	 Because we try to avoid sending the wikitext editor and then immediately replacing it with VE as the JS loads.
[21:19:19] <Krinkle>	 Krenair: Yeah, I understood.
[21:19:25] <Krinkle>	 Krenair: <script>if(!isCompatible()){
[21:19:37] <Krinkle>	 doesn't even have to wait for async startup
[21:19:40] <Krinkle>	 oh wait, it does
[21:30:03] <Krenair>	 this is probably my least favourite part of the SET code
[21:41:47] <Krenair>	 Krinkle, so, something like this?
[21:41:49] <Krenair>	 		$article->getContext()->getOutput()->addScript(
[21:41:49] <Krenair>	 			Html::inlineScript( "$(function(){if(!isCompatible()){location.href=\"$url\";}});" )
[21:41:50] <Krenair>	 		);
[21:42:06] <Krinkle>	 Krenair: No, because $ will be undefined.
[21:42:32] <Krenair>	 ah, right.
[21:42:38] <Krenair>	 we're that early on in the startup process...
[21:42:49] <Krinkle>	 startup.js loads jquery, both are async
[21:42:59] <Krinkle>	 There is no callback for after startup fails.
[21:43:05] <Krinkle>	 only for when it succeeds (RLQ)
[21:49:14] <Krenair>	 Krinkle, so what can we do to ensure this runs after startup.js?
[22:08:06] <wikibugs>	 10VisualEditor, 10MediaWiki-extensions-Translate: when forgetting a newline after translate marker VE doesn't display the real error message - https://phabricator.wikimedia.org/T122276#1957376 (10JanZerebecki) I only described the problem a user experiences. The next step is finding a solution, do you have a s...
[23:10:43] <grrrit-wm>	 (03CR) 10Jforrester: "> You asked me to review this but it doesn't work yet... Do you want me to try to make it actually work?" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/259017 (owner: 10Jforrester)
[23:19:38] <Krinkle>	 Krenair: We'll need to come up with something new.
[23:20:07] <Krinkle>	 Possibly something like RLQ that is run by startup.js after !isCompatibility().
[23:20:20] <Krinkle>	 NORLQ maybe, or some such
[23:21:01] <Krinkle>	 or modify RLQ handling in a way to accept fail callbacks 
[23:24:51] <James_F>	 Krinkle: Norl-qué. I like it.
[23:44:43] <Krenair>	 James_F, just noticed a change in parsoid behaviour from a few months ago, try editing this table: https://meta.wikimedia.org/wiki/System_administrators#List
[23:45:25] <Krenair>	 is it supposed to let you select individual rows like that? they're transcluded
[23:53:45] <edsanders>	 Krenair, those are transclusions inside a real table
[23:54:24] <edsanders>	 the <table> is not a template so it gets treated normally...
[23:56:47] <Krenair>	 it used to get a data-mw
[23:56:50] <Krenair>	 attribute