[00:00:38] Hmm. I must have mis-remembered. [00:04:22] James_F, nope, no validation [00:04:29] it extends TextInputWidget and adds some suggestion stuff [00:05:21] Hmm. Which is the one with validation then? [00:07:01] James_F, TitleInputWidget [00:07:13] which is the other part of this, which I can take out [00:11:43] James_F, I might just change core to make the validation optional though [00:14:15] * James_F nods. [00:14:21] Though ideally we'd do it 'properly' up-front. [00:21:40] (03CR) 10Krinkle: [C: 031] "May wanna make sure that if all detected parameters are already present, that the import button doesn't do nothing (or that the button doe" [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/265410 (https://phabricator.wikimedia.org/T124223) (owner: 10Alex Monk) [00:22:13] Krinkle: Not the priority CR for us. :-P [00:22:23] (03CR) 10Krinkle: [C: 031] Fix mw.TemplateData.SourceHandler.prototype.extractParametersFromTemplateCode return doc [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/265411 (owner: 10Alex Monk) [00:23:25] (Thanks though.) [00:25:48] I was catching up on back scroll. This was the only unmerged one of thr three mentions links I passed by [00:25:56] I see you later asked for https://gerrit.wikimedia.org/r/#/c/259771/4/VisualEditor.hooks.php [00:26:04] I'll test that out locally now [00:26:15] (03PS5) 10Krinkle: SET: Set user's editor to wikitext if the browser doesn't do JS [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/259771 (https://phabricator.wikimedia.org/T121257) (owner: 10Alex Monk) [00:26:24] Krinkle: Thanks. [00:27:38] Krinkle: https://gerrit.wikimedia.org/r/#/c/265878/ https://gerrit.wikimedia.org/r/#/c/265879/ is pretty awesome but scary to me; is it the kind of thing you worry might get abused? [00:28:03] Yes [00:28:09] But It's a genuine use case [00:28:21] * James_F nods. [00:28:28] However I'd recommend you ("Editing dept.") track stats on this to see how valuable and common it is. [00:28:39] Another thing to stalk for badness. [00:28:39] * James_F nods. [00:28:45] Right. [00:28:49] Something generic in WikimediaEvents perhaps [00:28:57] And try to find a way to kill it eventually? [00:28:59] low sampling to track hitrate of NORLQ [00:29:11] Well, I don't expect it to die really [00:29:14] Hmm. Possibly. [00:29:25] If anything, I very much want to us to increase that category. [00:29:43] (by shrinking Grade A to only modern browsers) [00:30:06] However in 99% of cases, it won't involve JS, so NORLQ as a hook should be very rare [00:30:19] But as an execution entry point, it should be quite common. [00:30:25] We could bounce users to Special:ChooseEditor which has JS (grade A) -> VE or WT via JS, and for fallback (grade C/X) -> WT via meta-refresh or something. [00:31:14] Grade A/X to VE you mean, and Grade C to WT [00:31:40] A and X must be treated equally by all infrastructure levels. [00:32:07] Sorry, yes, grade A/X with JS -> VE, grade C and grade A/X without JS -> WT. [00:46:32] (03CR) 10Jforrester: [C: 031] Tables: Multi-cell copy and paste [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/265660 (https://phabricator.wikimedia.org/T85791) (owner: 10Esanders) [00:47:09] 10VisualEditor: Pasting bullets containing templates indents incorrectly - https://phabricator.wikimedia.org/T124730#1964429 (10ksmith) 3NEW [00:50:17] (03PS15) 10Alex Monk: Use widgets for wiki-page-name and wiki-user-name parameters [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/169936 (https://phabricator.wikimedia.org/T55613) [00:52:47] (03CR) 10jenkins-bot: [V: 04-1] Use widgets for wiki-page-name and wiki-user-name parameters [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/169936 (https://phabricator.wikimedia.org/T55613) (owner: 10Alex Monk) [00:56:02] (03PS16) 10Alex Monk: Use widgets for wiki-page-name and wiki-user-name parameters [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/169936 (https://phabricator.wikimedia.org/T55613) [01:14:11] (03CR) 10Alex Monk: "I think that once that TitleInputWidget dependency is through, this can be merged, and then I can move on to dealing with the more complex" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/169936 (https://phabricator.wikimedia.org/T55613) (owner: 10Alex Monk) [01:23:01] 10VisualEditor, 10VisualEditor-MediaWiki, 6Editing-Analysis: Revise the Edit schema and its use - https://phabricator.wikimedia.org/T118063#1964646 (10Neil_P._Quinn_WMF) [01:24:57] 10VisualEditor, 10VisualEditor-MediaWiki-Templates, 10MediaWiki-extensions-TemplateData: Create dedicated input methods for "wiki-page-name" transclusion parameters - https://phabricator.wikimedia.org/T124734#1964655 (10Jdforrester-WMF) 3NEW a:3Krenair [01:25:25] 10VisualEditor, 10VisualEditor-MediaWiki-Templates, 10MediaWiki-extensions-TemplateData: Create dedicated input methods for "wiki-user-name" transclusion parameters - https://phabricator.wikimedia.org/T124736#1964671 (10Jdforrester-WMF) 3NEW a:3Krenair [01:27:17] 10VisualEditor, 10VisualEditor-MediaWiki-Templates, 10MediaWiki-extensions-TemplateData: Create dedicated input methods for "wiki-page-name" transclusion parameters - https://phabricator.wikimedia.org/T124734#1964693 (10Krenair) -> https://gerrit.wikimedia.org/r/#/c/169936/ and https://gerrit.wikimedia.org/r... [01:28:33] 10VisualEditor, 10VisualEditor-MediaWiki-Templates, 10MediaWiki-extensions-TemplateData: Create dedicated input methods for "wiki-user-name" transclusion parameters - https://phabricator.wikimedia.org/T124736#1964694 (10Krenair) -> https://gerrit.wikimedia.org/r/#/c/169936/ [01:36:29] 10VisualEditor, 10VisualEditor-MediaWiki-Templates, 10MediaWiki-extensions-TemplateData, 7Design, 5Patch-For-Review: Create dedicated input methods for transclusion parameters (using "Param#type" from TemplateData) - https://phabricator.wikimedia.org/T55613#1964727 (10Jdforrester-WMF) [01:40:45] (03CR) 10Alex Monk: "I think the button just isn't there in that case." [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/265410 (https://phabricator.wikimedia.org/T124223) (owner: 10Alex Monk) [01:58:46] Krenair: James_F|Away: Local settings to do SET in VE on master? [01:59:11] $wgVisualEditorUseSingleEditTab = true; [01:59:24] Right :) [02:00:17] Krenair: Hm.. 1) It refreshes to action=edit instead of in-JS, 2) It opens the same dialog twice over to of each other [02:00:21] (abotu asking how to remember) [02:00:30] over top* [02:01:32] Krinkle, it refreshes to action=edit? [02:01:39] clickign Edit I mean [02:01:50] opened VE after refreshing to action=edit [02:01:52] instead of ajaxy [02:01:55] I'll double check [02:02:11] Yeah, it's a fresh load [02:02:25] WFM [02:02:27] Is that on purpose? [02:02:29] does VE load on the new page? [02:02:32] no [02:03:02] mw and ve latest master both [02:03:17] wiki/Main_Page with wgVeSET=true [02:03:39] shows 1 Edit tab, which leads to a full page GET navigation to /w/....action=edit [02:03:47] same for the Read tab when going back [02:04:01] (the latter makes sense when already there) [02:04:17] I see the WIkiEditor load first in the background [02:05:16] I commented out these two in local settings [02:05:17] #$wgDefaultUserOptions['visualeditor-enable'] = 1; [02:05:17] #$wgDefaultUserOptions['visualeditor-enable-experimental'] = 1; [02:05:20] Maybe I shoulnd;t have done that [02:08:15] wgVeSET=true? [02:08:34] $wgVisualEditorUseSingleEditTab = true? [02:19:17] 10VisualEditor, 10VisualEditor-MediaWiki: Pages with pending changes show an "Edit" tab label even when they actually mean "Edit source" - https://phabricator.wikimedia.org/T124652#1964779 (10Krenair) [02:24:52] Krenair: Yes [02:25:45] anything in console? [02:25:59] (03CR) 10Krinkle: [C: 032] "Indeed (confirmed). Thanks :)" [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/265410 (https://phabricator.wikimedia.org/T124223) (owner: 10Alex Monk) [02:26:06] Krenair: Nope [02:26:15] Krenair: It's fine now that I enabled by default [02:26:21] I guess the JS wasn't being loaded if that pref isn't on [02:26:27] at least not on page views [02:26:59] urgh.... [02:27:41] (03Merged) 10jenkins-bot: Don't show warning about already-known parameters that weren't imported [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/265410 (https://phabricator.wikimedia.org/T124223) (owner: 10Alex Monk) [02:27:41] Krinkle, no, I think all users get the initialisation module [02:42:59] Krinkle, okay, so I can reproduce the issue [02:43:51] What should actually be happening is VE not loading on the action=edit page [02:44:01] so we're missing a userPrefEnabled check [02:46:08] Krinkle, mind filing a proper bug? [02:46:29] I've made a note. I'll try to repro tomorrow [02:46:33] and file a task then [02:46:34] I have a fix [02:46:42] I'll just make a task and upload the commit [02:47:27] 10VisualEditor, 10VisualEditor-MediaWiki: On single edit tab wikis, if you have VE disabled and press edit, we take you to action=edit but then immediately load VE - https://phabricator.wikimedia.org/T124743#1964808 (10Krenair) 3NEW [02:47:37] 10VisualEditor, 10VisualEditor-MediaWiki: On single edit tab wikis, if you have VE disabled and press edit, we take you to action=edit but then immediately load VE - https://phabricator.wikimedia.org/T124743#1964817 (10Krenair) [02:47:40] 10VisualEditor, 10VisualEditor-MediaWiki, 7Design, 7Epic: Change VE integration to only use one edit tab, to avoid user choice paralysis - https://phabricator.wikimedia.org/T58337#1964816 (10Krenair) [02:47:50] 10VisualEditor, 10VisualEditor-MediaWiki: On single edit tab wikis, if you have VE disabled and press edit, we take you to action=edit but then immediately load VE - https://phabricator.wikimedia.org/T124743#1964818 (10Krenair) a:3Krenair [02:48:51] (03PS1) 10Alex Monk: Check user preferences before loading VE on-load on action=edit/submit etc. [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/266459 (https://phabricator.wikimedia.org/T124743) [03:05:04] (03CR) 10Jforrester: [C: 032] Check user preferences before loading VE on-load on action=edit/submit etc. [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/266459 (https://phabricator.wikimedia.org/T124743) (owner: 10Alex Monk) [03:10:54] (03Merged) 10jenkins-bot: Check user preferences before loading VE on-load on action=edit/submit etc. [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/266459 (https://phabricator.wikimedia.org/T124743) (owner: 10Alex Monk) [03:34:37] (03CR) 10Krinkle: [C: 032] Fix mw.TemplateData.SourceHandler.prototype.extractParametersFromTemplateCode return doc [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/265411 (owner: 10Alex Monk) [03:36:14] thanks guys [03:36:28] (03Merged) 10jenkins-bot: Fix mw.TemplateData.SourceHandler.prototype.extractParametersFromTemplateCode return doc [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/265411 (owner: 10Alex Monk) [03:36:36] Krinkle, is your -1 on the NORLQ commit so we wait, or "At least we should no-op the opposite queue as well to allow garbage collection of any scopes passed to the queues."? [03:37:18] 10VisualEditor, 10VisualEditor-MediaWiki, 5Patch-For-Review: On single edit tab wikis, if you have VE disabled and press edit, we take you to action=edit but then immediately load VE - https://phabricator.wikimedia.org/T124743#1964847 (10Krenair) 5Open>3Resolved [03:37:20] 10VisualEditor, 10VisualEditor-MediaWiki, 7Design, 7Epic: Change VE integration to only use one edit tab, to avoid user choice paralysis - https://phabricator.wikimedia.org/T58337#1964848 (10Krenair) [04:03:39] Krenair: I want it to wait a day or two. Can go out as early as next week afaic. [04:03:55] It's an unexpected RL new feature, so not this week. [09:58:54] parsoid is trying to fetch images using relative urls, even though the wikipage itself is using "[[File:20130705163106.gif|alt=foss i akserselva|frame|akserselva]]". This fails with error code 1, but following the logs, I find "Error: Bad article title: ./File:20130705163106.gif" Mediawiki doesn't like relative urls, why are parsoid trying? can I convince it otherways? [11:01:22] Hello [11:16:43] 10Cite, 10MediaWiki-API, 10MobileFrontend, 5Patch-For-Review, 7Tracking: Should be possible to access references and notes for a given page via API - https://phabricator.wikimedia.org/T123290#1965347 (10phuedx) [11:31:17] Krinkle, okay [11:31:19] Krinkle, I thought they weren't branching this week? [11:41:56] 10Cite, 10MediaWiki-API, 10MobileFrontend, 5Patch-For-Review, 7Tracking: Should be possible to access references and notes for a given page via API - https://phabricator.wikimedia.org/T123290#1965388 (10phuedx) a:3phuedx [12:06:22] 10Citoid, 6Services, 10Traffic, 6operations: Remove citoid from parsoidcache - https://phabricator.wikimedia.org/T110476#1965408 (10BBlack) Are things still using the hostnames `citoid.wikimedia.org` and/or `citoid.eqiad.wikimedia.org`, which map to the cache_parsoid cluster rather than through restbase? [14:12:02] Krinkle, please clarify what you mean by "At least we should no-op the opposite queue as well to allow garbage collection of any scopes passed to the queues." [14:32:24] would NORLQ processing cause RLQ to be emptied and vice versa? [14:57:34] 10VisualEditor, 10VisualEditor-MediaWiki, 10MediaWiki-extensions-FlaggedRevs: Pages with pending changes show an "Edit" tab label even when they actually mean "Edit source" - https://phabricator.wikimedia.org/T124652#1965689 (10Krenair) That'd be FlaggedRevs overwriting it after us, based on FlaggablePageVie... [15:00:15] 10VisualEditor: On single edit tab wikis, if your preference is 'remember last editor' and you last used VisualEditor, VisualEditor will load on a "View source" action=edit - https://phabricator.wikimedia.org/T124650#1965693 (10Krenair) >>! In T124650#1961631, @Elitre wrote: > When preference for registered user... [15:01:57] 10VisualEditor: On single edit tab wikis, if your preference is 'remember last editor' and you last used VisualEditor, VisualEditor will load on a "View source" action=edit - https://phabricator.wikimedia.org/T124650#1965696 (10Elitre) Except for the (discarding changes) bit. [15:06:18] 10VisualEditor: On single edit tab wikis, if your preference is 'remember last editor' and you last used VisualEditor, VisualEditor will load on a "View source" action=edit - https://phabricator.wikimedia.org/T124650#1965704 (10Krenair) >>! In T124650#1965696, @Elitre wrote: > Except for the (discarding changes)... [15:07:17] 10VisualEditor: On single edit tab wikis, if your preference is 'remember last editor' and you last used VisualEditor, VisualEditor will load on a "View source" action=edit - https://phabricator.wikimedia.org/T124650#1965708 (10Elitre) The latter AFAIK. [15:50:44] 10VisualEditor, 10VisualEditor-MediaWiki, 5WMF-deploy-2016-02-02_(1.27.0-wmf.12): On single edit tab wikis, if you have VE disabled and press edit, we take you to action=edit but then immediately load VE - https://phabricator.wikimedia.org/T124743#1965807 (10Jdforrester-WMF) p:5Triage>3High [15:57:25] (03PS1) 10Esanders: Tables: Add getMaxColCount to count total columns in a table matrix [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/266505 [15:57:27] (03PS1) 10Esanders: Tables: Add slugs for missing cells in sparse tables [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/266506 (https://phabricator.wikimedia.org/T85464) [15:57:43] edsanders: Oooh. [15:57:52] (03PS7) 10Esanders: Tables: Multi-cell copy and paste [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/265660 (https://phabricator.wikimedia.org/T85791) [15:58:05] quite [16:00:48] (03CR) 10jenkins-bot: [V: 04-1] Tables: Add getMaxColCount to count total columns in a table matrix [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/266505 (owner: 10Esanders) [16:02:53] (03PS8) 10Esanders: Tables: Multi-cell copy and paste [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/265660 (https://phabricator.wikimedia.org/T85791) [16:02:55] (03PS2) 10Esanders: Tables: Add getMaxColCount to count total columns in a table matrix [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/266505 [16:03:11] (03CR) 10jenkins-bot: [V: 04-1] Tables: Add slugs for missing cells in sparse tables [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/266506 (https://phabricator.wikimedia.org/T85464) (owner: 10Esanders) [16:05:17] (03PS2) 10Esanders: Tables: Add slugs for missing cells in sparse tables [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/266506 (https://phabricator.wikimedia.org/T85464) [16:05:50] edsanders: Missed another one in Add getMaxColCount, and it fails its unit tests. [16:06:51] Chrome 47.0.2526 (Mac OS X 10.11.0) ve.dm.TableSelection Basic methods (clone, expand, collapse*, getRange(s), isCollased, isSingleCell, equals, isNull, isFullRow/Col, getRow/ColCount) FAILED [16:06:51] Died on test #17 at /Users/jdforrester/Documents/git/vagrant/mediawiki/extensions/VisualEditor/lib/ve/tests/dm/selections/ve.dm.TableSelection.test.js:108:7: Cannot read property 'length' of undefined [16:08:19] (03CR) 10jenkins-bot: [V: 04-1] Tables: Multi-cell copy and paste [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/265660 (https://phabricator.wikimedia.org/T85791) (owner: 10Esanders) [16:08:42] (03CR) 10jenkins-bot: [V: 04-1] Tables: Add getMaxColCount to count total columns in a table matrix [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/266505 (owner: 10Esanders) [16:09:04] (03PS3) 10Esanders: Tables: Add slugs for missing cells in sparse tables [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/266506 (https://phabricator.wikimedia.org/T85464) [16:09:06] (03PS3) 10Esanders: Tables: Add getMaxColCount to count total columns in a table matrix [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/266505 [16:09:29] (03PS9) 10Esanders: Tables: Multi-cell copy and paste [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/265660 (https://phabricator.wikimedia.org/T85791) [16:09:55] (03CR) 10jenkins-bot: [V: 04-1] Tables: Add slugs for missing cells in sparse tables [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/266506 (https://phabricator.wikimedia.org/T85464) (owner: 10Esanders) [16:10:08] 10VisualEditor, 10VisualEditor-MediaWiki, 10MediaWiki-extensions-FlaggedRevs: Pages with pending changes show an "Edit" tab label even when they actually mean "Edit source" - https://phabricator.wikimedia.org/T124652#1965894 (10Jdforrester-WMF) [16:10:12] 10VisualEditor, 10VisualEditor-MediaWiki, 7Design, 7Epic: Change VE integration to only use one edit tab, to avoid user choice paralysis - https://phabricator.wikimedia.org/T58337#1965893 (10Jdforrester-WMF) [16:14:06] (03CR) 10jenkins-bot: [V: 04-1] Tables: Add getMaxColCount to count total columns in a table matrix [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/266505 (owner: 10Esanders) [16:14:34] (03CR) 10jenkins-bot: [V: 04-1] Tables: Add slugs for missing cells in sparse tables [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/266506 (https://phabricator.wikimedia.org/T85464) (owner: 10Esanders) [16:15:10] (03CR) 10jenkins-bot: [V: 04-1] Tables: Multi-cell copy and paste [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/265660 (https://phabricator.wikimedia.org/T85791) (owner: 10Esanders) [16:20:01] 10VisualEditor, 10VisualEditor-ContentEditable, 10VisualEditor-ContentLanguage, 7Browser-Support-Firefox: Specific kanji input causes Firefox crash on Windows 10 - https://phabricator.wikimedia.org/T118729#1965930 (10Jdforrester-WMF) [16:38:09] (03PS1) 10Alex Monk: Check user permissions for viewsource before loading VE on-load on action=edit/submit etc. [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/266522 (https://phabricator.wikimedia.org/T124650) [16:40:24] 10VisualEditor, 5Patch-For-Review: On single edit tab wikis, if your preference is 'remember last editor' and you last used VisualEditor, VisualEditor will load on a "View source" action=edit - https://phabricator.wikimedia.org/T124650#1965987 (10Krenair) a:3Krenair [16:44:25] (03CR) 10Jforrester: [C: 031] Check user permissions for viewsource before loading VE on-load on action=edit/submit etc. (031 comment) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/266522 (https://phabricator.wikimedia.org/T124650) (owner: 10Alex Monk) [16:45:34] Krenair: Can https://gerrit.wikimedia.org/r/#/c/265903/ be rebased onto master so we can merge it, or is there a reason it's in the stack? [16:48:31] (03PS2) 10Alex Monk: Check user permissions for viewsource before loading VE on-load on action=edit/submit etc. [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/266522 (https://phabricator.wikimedia.org/T124650) [16:48:31] James_F, it's probably only in the stack by accident [16:48:44] although sometimes I leave stuff stacked to convince people to review the parent commit [16:49:13] yeah, doesn't seem necessary [16:53:33] (03PS2) 10Alex Monk: Don't try to load VE over the top of the wikitext editor we just switched to [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/265903 (https://phabricator.wikimedia.org/T124316) [16:53:33] (03CR) 10Jforrester: [C: 032] Check user permissions for viewsource before loading VE on-load on action=edit/submit etc. [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/266522 (https://phabricator.wikimedia.org/T124650) (owner: 10Alex Monk) [16:53:33] Krenair: Thanks. [16:53:34] 10VisualEditor, 10VisualEditor-MediaWiki: On single edit tab wikis, if your preference is 'remember last editor' and you last used VisualEditor, VisualEditor will load on a "View source" action=edit - https://phabricator.wikimedia.org/T124650#1966047 (10Jdforrester-WMF) 5Open>3Resolved p:5Triage>3High [16:53:36] 10VisualEditor, 10VisualEditor-MediaWiki, 7Design, 7Epic: Change VE integration to only use one edit tab, to avoid user choice paralysis - https://phabricator.wikimedia.org/T58337#1966051 (10Jdforrester-WMF) [16:55:32] (03Merged) 10jenkins-bot: Check user permissions for viewsource before loading VE on-load on action=edit/submit etc. [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/266522 (https://phabricator.wikimedia.org/T124650) (owner: 10Alex Monk) [16:58:14] (03CR) 10Jforrester: [C: 032] Don't try to load VE over the top of the wikitext editor we just switched to [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/265903 (https://phabricator.wikimedia.org/T124316) (owner: 10Alex Monk) [17:01:29] (03Merged) 10jenkins-bot: Don't try to load VE over the top of the wikitext editor we just switched to [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/265903 (https://phabricator.wikimedia.org/T124316) (owner: 10Alex Monk) [17:22:53] (03PS4) 10Esanders: Tables: Add slugs for missing cells in sparse tables [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/266506 (https://phabricator.wikimedia.org/T85464) [17:22:55] (03PS4) 10Esanders: Tables: Add getMaxColCount to count total columns in a table matrix [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/266505 [17:23:19] (03PS10) 10Esanders: Tables: Multi-cell copy and paste [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/265660 (https://phabricator.wikimedia.org/T85791) [17:39:19] (03CR) 10Anomie: [C: 032] "James +1ed, so let's do this already." [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/263881 (https://phabricator.wikimedia.org/T91455) (owner: 10Alex Monk) [17:40:58] (03Merged) 10jenkins-bot: Don't restrict format parameter in the API [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/263881 (https://phabricator.wikimedia.org/T91455) (owner: 10Alex Monk) [17:42:22] 10VisualEditor, 10VisualEditor-MediaWiki, 10MediaWiki-API, 10MediaWiki-extensions-TemplateData, and 2 others: ApiTemplateData implements ApiBase::getCustomPrinter for no good reason - https://phabricator.wikimedia.org/T91455#1966199 (10Anomie) 5Open>3Resolved [17:48:26] (03PS5) 10Esanders: Tables: Add slugs for missing cells in sparse tables [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/266506 (https://phabricator.wikimedia.org/T85464) [17:54:30] (03CR) 10Bartosz Dziewoński: "How badly is this going to break in VE-MW for partially template-generated tables? (see also T85462)" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/266506 (https://phabricator.wikimedia.org/T85464) (owner: 10Esanders) [17:58:25] 10Citoid, 6Services, 10Traffic, 6operations: Remove citoid from parsoidcache - https://phabricator.wikimedia.org/T110476#1966263 (10mobrovac) >>! In T110476#1965408, @BBlack wrote: > Are things still using the hostnames `citoid.wikimedia.org` and/or `citoid.eqiad.wikimedia.org`, which map to the cache_pars... [19:39:33] 10VisualEditor, 10Graph, 7Epic, 7Milestone: [Objective] It's easier to create and edit charts from within VisualEditor - https://phabricator.wikimedia.org/T119233#1966843 (10Jdforrester-WMF) [19:39:36] 10VisualEditor, 10Graph, 5WMF-deploy-2016-02-02_(1.27.0-wmf.12): "TypeError: can't convert undefined to object" apperas when I delete all the co-ordinates from Data section of the Graph editor and cannot open any other inspector after that - https://phabricator.wikimedia.org/T118898#1966841 (10Jdforrester-WM... [19:40:42] 10VisualEditor, 10VisualEditor-MediaWiki, 7Browser-Support-Firefox: Single edit tab: Preferences dialog is not showing in Firefox (? on Macs only) - https://phabricator.wikimedia.org/T122389#1966850 (10Jdforrester-WMF) [19:40:46] 10VisualEditor, 10VisualEditor-MediaWiki, 7Design, 7Epic: Change VE integration to only use one edit tab, to avoid user choice paralysis - https://phabricator.wikimedia.org/T58337#1966849 (10Jdforrester-WMF) [19:42:15] (03CR) 10Jforrester: [C: 032] Tables: Add getMaxColCount to count total columns in a table matrix [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/266505 (owner: 10Esanders) [19:44:24] 10VisualEditor, 10VisualEditor-MediaWiki, 7Browser-Support-Firefox: Single edit tab: Preferences dialog is not showing in Firefox (? on Macs only) - https://phabricator.wikimedia.org/T122389#1966872 (10Krenair) a:3Whatamidoing-WMF [19:47:26] (03Merged) 10jenkins-bot: Tables: Add getMaxColCount to count total columns in a table matrix [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/266505 (owner: 10Esanders) [20:08:16] 10VisualEditor, 10VisualEditor-MediaWiki, 10Parsoid: Parsoid occasionally serialises new images as figure class="default size" inserted in a caption - https://phabricator.wikimedia.org/T124815#1966920 (10Jdforrester-WMF) 3NEW [20:08:40] 10VisualEditor, 10VisualEditor-ContentEditable: figure class="default size" inserted in a caption - https://phabricator.wikimedia.org/T88099#1004028 (10Jdforrester-WMF) >>! In T88099#1945329, @Drongou wrote: > In my example, all files are on Commons less than 5mn before insertion on WP:xx It seems that it's di... [20:08:52] 10VisualEditor, 10VisualEditor-ContentEditable: figure class="default size" inserted in a caption - https://phabricator.wikimedia.org/T88099#1966933 (10Jdforrester-WMF) 5Open>3Resolved [20:09:07] 10VisualEditor, 10VisualEditor-MediaWiki, 10Parsoid: Parsoid occasionally serialises new images as figure class="default size" inserted in a caption - https://phabricator.wikimedia.org/T124815#1966920 (10Jdforrester-WMF) [20:10:01] 10VisualEditor, 10VisualEditor-MediaWiki, 10VisualEditor-MediaWiki-Templates: Always display and prompt the user to fill in all required and suggested parameters for existing templates, regardless of what has been set in the wikitext - https://phabricator.wikimedia.org/T122578#1966940 (10Jdforrester-WMF) [20:11:10] 10VisualEditor, 10VisualEditor-MediaWiki, 10VisualEditor-MediaWiki-Templates: Always display and prompt the user to fill in all required and suggested parameters for existing templates, regardless of what has been set in the wikitext - https://phabricator.wikimedia.org/T122578#1907962 (10Jdforrester-WMF) Oh,... [20:11:19] 10VisualEditor, 10VisualEditor-MediaWiki, 10VisualEditor-MediaWiki-Templates: Always display and prompt the user to fill in all required and suggested parameters for existing templates, regardless of what has been set in the wikitext - https://phabricator.wikimedia.org/T122578#1966944 (10Jdforrester-WMF) p:... [20:12:08] 10VisualEditor, 10VisualEditor-MediaWiki, 10VisualEditor-MediaWiki-Links: Interwiki linking broken - https://phabricator.wikimedia.org/T123012#1966949 (10Jdforrester-WMF) >>! In T123012#1945962, @Krenair wrote: > If I try to make a link to gerrit:123 without selecting any text, I can't insert anything (butto... [20:12:19] 10VisualEditor, 10VisualEditor-MediaWiki, 10VisualEditor-MediaWiki-Links: Interwiki linking broken - https://phabricator.wikimedia.org/T123012#1966950 (10Jdforrester-WMF) 5Open>3stalled [20:13:13] 10VisualEditor: Support Bibtext format on VE when citing a reference - https://phabricator.wikimedia.org/T123128#1966955 (10Jdforrester-WMF) Where would this bibtext go? We edit wikitext, not LaTeX documents… [20:13:25] 10VisualEditor: Support Bibtext format on VE when citing a reference - https://phabricator.wikimedia.org/T123128#1966959 (10Jdforrester-WMF) 5Open>3stalled [20:14:05] 10VisualEditor, 10VisualEditor-MediaWiki: after switching from source to visual editing, #mw-content-text loses lang and dir attributes - https://phabricator.wikimedia.org/T123148#1966965 (10Jdforrester-WMF) p:5Triage>3Low [20:18:59] 10VisualEditor, 10VisualEditor-Links: Offer a tab for UNC links - https://phabricator.wikimedia.org/T123154#1966989 (10Jdforrester-WMF) These links have no place on a public wiki, so really this should be provided by an extension aimed at private wikis rather than inside MW-VE for all users. [20:19:01] 10VisualEditor, 10VisualEditor-Links: Offer a tab for UNC links - https://phabricator.wikimedia.org/T123154#1966990 (10Jdforrester-WMF) p:5Triage>3Lowest [20:19:13] 10VisualEditor, 10VisualEditor-MediaWiki: Be able to enable VisualEditor for a single page (rather than just namespaces) - https://phabricator.wikimedia.org/T123231#1966998 (10Jdforrester-WMF) p:5Triage>3Low [20:19:23] 10VisualEditor: Visual editor misparses comments in templates - https://phabricator.wikimedia.org/T123353#1967006 (10Jdforrester-WMF) [20:19:26] 10VisualEditor, 10VisualEditor-MediaWiki, 10VisualEditor-MediaWiki-Templates: Comment syntax shown in template's name in VisualEditor - https://phabricator.wikimedia.org/T89615#1967007 (10Jdforrester-WMF) [20:20:20] 10VisualEditor: Saving a page after adding an image/formula is throwing error "Cannot read property 'top' of undefined" in VisualEditor - https://phabricator.wikimedia.org/T123340#1967017 (10Jdforrester-WMF) Seems to work fine now. [20:20:27] 10VisualEditor, 10VisualEditor-MediaWiki, 10Parsoid: Parsoid occasionally serialises new images as figure class="default size" inserted in a caption - https://phabricator.wikimedia.org/T124815#1967019 (10cscott) This looks to me like a VE bug -- it looks like somehow VE is generating something very similar t... [20:20:40] 10VisualEditor: [Regression pre-wmf.11] Saving a page after adding an image/formula is throwing error "Cannot read property 'top' of undefined" in VisualEditor - https://phabricator.wikimedia.org/T123340#1967021 (10Jdforrester-WMF) 5Open>3Resolved p:5Triage>3High a:3Krenair [20:20:46] 10VisualEditor: [Regression pre-wmf.11] Saving a page after adding an image/formula is throwing error "Cannot read property 'top' of undefined" in VisualEditor - https://phabricator.wikimedia.org/T123340#1926626 (10Jdforrester-WMF) [20:21:13] James_F, I fixed that? [20:21:38] I think so. [20:21:49] I have no idea what I did, but okay :) [20:22:08] 10VisualEditor, 10VisualEditor-MediaWiki, 5Patch-For-Review, 5WMF-deploy-2016-02-02_(1.27.0-wmf.12): On single edit tab wikis: Switching from VE to the wikitext editor (discarding changes) while having "always give me the visual editor" as your preference c... - https://phabricator.wikimedia.org/T124316#1967042 [20:22:12] 10VisualEditor, 10VisualEditor-MediaWiki, 7Design, 7Epic: Change VE integration to only use one edit tab, to avoid user choice paralysis - https://phabricator.wikimedia.org/T58337#1967045 (10Jdforrester-WMF) [20:28:32] 10VisualEditor, 10VisualEditor-MediaWiki: Bi-directional switching (VE-WT-VE-WT) loses all changes on the third switch in Firefox 43 on Windows 10 (for one user) - https://phabricator.wikimedia.org/T124708#1967104 (10Jdforrester-WMF) 5Open>3stalled p:5Triage>3Normal [20:28:32] 10VisualEditor, 10VisualEditor-MediaWiki, 10MediaWiki-extensions-FlaggedRevs: Pages with pending changes show an "Edit" tab label even when they actually mean "Edit source" - https://phabricator.wikimedia.org/T124652#1967111 (10Jdforrester-WMF) p:5Triage>3Normal [20:54:32] 10VisualEditor, 10VisualEditor-MediaWiki, 7Browser-Support-Firefox: Single edit tab: Preferences dialog is not showing in Firefox (? on Macs only) - https://phabricator.wikimedia.org/T122389#1967247 (10Krenair) I believe that the dialog is only shown to a user if all of the below are true: * they're logged... [21:07:21] (03CR) 10Esanders: "Template generated cells are handled by the table matrix. Check out 'Alien Table' in the standalone demo. I don't think this patch will ma" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/266506 (https://phabricator.wikimedia.org/T85464) (owner: 10Esanders) [21:07:50] (03CR) 10Jforrester: [C: 031] Tables: Add slugs for missing cells in sparse tables [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/266506 (https://phabricator.wikimedia.org/T85464) (owner: 10Esanders) [21:08:10] 10VisualEditor, 10VisualEditor-Tables, 5Patch-For-Review: Make it possible to insert a missing cell into a table - https://phabricator.wikimedia.org/T85464#1967302 (10Jdforrester-WMF) a:3Esanders [21:08:28] 10VisualEditor, 10VisualEditor-Tables, 5Patch-For-Review: Make it possible to insert a missing cell into a table - https://phabricator.wikimedia.org/T85464#947430 (10Jdforrester-WMF) [21:08:31] 10VisualEditor, 10VisualEditor-Tables, 7Epic: Fully support basic table editing in the visual editor - https://phabricator.wikimedia.org/T108245#1967304 (10Jdforrester-WMF) [21:21:10] (03PS1) 10Jforrester: Update OOjs UI to v0.15.1 [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/266591 [21:22:57] 10VisualEditor, 10VisualEditor-MediaWiki, 10MediaWiki-extensions-TemplateData, 5WMF-deploy-2016-01-19_(1.27.0-wmf.11), 7user-notice: Display a warning when user will leave TemplateData form - https://phabricator.wikimedia.org/T106382#1967380 (10Krenair) [21:26:28] (03CR) 10Bartosz Dziewoński: [C: 032] Update OOjs UI to v0.15.1 [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/266591 (owner: 10Jforrester) [21:35:42] (03Merged) 10jenkins-bot: Update OOjs UI to v0.15.1 [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/266591 (owner: 10Jforrester) [21:52:06] (03PS11) 10Esanders: Tables: Multi-cell copy and paste [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/265660 (https://phabricator.wikimedia.org/T85791) [22:00:30] 10Cite, 6TCB-Team, 7German-Community-Wishlist, 5WMF-deploy-2016-02-02_(1.27.0-wmf.12), 7user-notice: Edit preview doesn't let you preview cite.php footnotes. - https://phabricator.wikimedia.org/T7984#1967520 (10TheDJ) @Cenarium, I think such an approach would be a nice general solution, but I don't think... [22:11:31] 10VisualEditor, 10VisualEditor-MediaWiki: Bi-directional switching (VE-WT-VE-WT) loses all changes on the third switch in Firefox 43 on Windows 10 (for one user) - https://phabricator.wikimedia.org/T124708#1967568 (10Jdforrester-WMF) [22:11:34] 10VisualEditor, 10VisualEditor-MediaWiki, 7Design, 7Epic: Change VE integration to only use one edit tab, to avoid user choice paralysis - https://phabricator.wikimedia.org/T58337#1967567 (10Jdforrester-WMF) [22:11:41] Krenair: So, state of play: [22:12:27] that one user is a SET blocker? :P [22:13:02] T121257 blocked on Krinkle +2; T123457 blocked on Krinkle +2 for NORLQ and thus in VE-MW; T124652 needs you to fight FlaggedRevs; T122389 and T124708 need testing/details as we can't reproduce. And that's it. [22:13:03] Sound right? [22:13:57] T122389 and T124708 might well be Declined as WFM. [22:15:22] 10VisualEditor, 10VisualEditor-MediaWiki, 10VisualEditor-Tables: Support sortable columns in tables - https://phabricator.wikimedia.org/T95189#1967589 (10Jdforrester-WMF) [22:15:27] Yes; yes; Yes, not sure what I'm going to do about FR yet; T122389 yes but not sure about T124708 [22:15:43] * James_F nods. [22:16:10] re T124708 - is Sherry not able to reproduce that? [22:16:19] Don't we use invalid for WFM? [22:17:03] I don't know. [22:17:13] Nope, T124708 is a user report. [22:18:35] 10VisualEditor, 10VisualEditor-MediaWiki, 10MediaWiki-extensions-TemplateData: Enable multiline TemplateData descriptions with \n - https://phabricator.wikimedia.org/T115641#1967637 (10Jdforrester-WMF) p:5Triage>3Low [22:18:41] 10VisualEditor, 10VisualEditor-MediaWiki, 10VisualEditor-MediaWiki-Media: Using the "#" keyboard shortcut (sequence), it's possible to input a list into image caption, which is mangled when turned back into wikitext - https://phabricator.wikimedia.org/T124619#1967645 (10Jdforrester-WMF) p:5Triage>3Low [22:18:42] sounds like that's all correct then James_F [22:19:04] Oy. OK. [22:19:13] 10Cite: Section edit preview doesn't let you preview references defined outside the sectioning being previewed - https://phabricator.wikimedia.org/T124840#1967662 (10TheDJ) 3NEW a:3MGChecker [22:20:25] 10VisualEditor, 10VisualEditor-CopyPaste, 10VisualEditor-MediaWiki, 10VisualEditor-MediaWiki-Media, 7I18n: When copying an image from a non-English wiki, use the correct File: namespace for the target wiki, not the source wiki - https://phabricator.wikimedia.org/T123768#1967684 (10Jdforrester-WMF) p:5Tr... [22:20:50] 10VisualEditor, 10VisualEditor-MediaWiki, 10MediaWiki-extensions-TemplateData: Order the suggested parameters in the TemplateData generator more logically - https://phabricator.wikimedia.org/T119363#1967689 (10Jdforrester-WMF) 5stalled>3declined a:3Jdforrester-WMF [22:21:21] 10Cite, 6TCB-Team, 7German-Community-Wishlist, 5WMF-deploy-2016-02-02_(1.27.0-wmf.12), 7user-notice: Edit preview doesn't let you preview cite.php footnotes. - https://phabricator.wikimedia.org/T7984#1967694 (10TheDJ) I've split any remaining functionality requests into: {T124840} The German-Community-W... [22:21:26] 10VisualEditor, 10VisualEditor-MediaWiki, 10WikiEditor, 10Wikimedia-General-or-Unknown, 7Regression: WikiEditor toolbar distorted by button for VisualEditor on Wikivoyage - https://phabricator.wikimedia.org/T124513#1967696 (10Jdforrester-WMF) p:5Triage>3High [22:21:57] 10Cite: Section edit preview doesn't let you preview references defined outside the sectioning being previewed - https://phabricator.wikimedia.org/T124840#1967697 (10TheDJ) a:5MGChecker>3None [22:22:28] 10Cite: Section edit preview doesn't let you preview references defined outside the section being previewed - https://phabricator.wikimedia.org/T124840#1967716 (10TheDJ) [22:23:41] 10Cite: Section edit preview doesn't let you preview references defined outside the section being previewed - https://phabricator.wikimedia.org/T124840#1967662 (10TheDJ) [22:34:15] (03PS12) 10Esanders: Tables: Multi-cell copy and paste [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/265660 (https://phabricator.wikimedia.org/T85791) [22:38:07] 10VisualEditor, 10VisualEditor-MediaWiki, 10VisualEditor-MediaWiki-Media: Using the "#" keyboard shortcut (sequence), it's possible to input a list into image caption, which is mangled when turned back into wikitext - https://phabricator.wikimedia.org/T124619#1967798 (10Esanders) The captionTarget in the med... [22:41:17] 10VisualEditor, 10VisualEditor-MediaWiki, 10WikiEditor, 10Wikimedia-General-or-Unknown, 7Regression: WikiEditor toolbar distorted by button for VisualEditor on Wikivoyage - https://phabricator.wikimedia.org/T124513#1967820 (10Jdforrester-WMF) 5Open>3Resolved a:3Jdforrester-WMF Fixed in https://en.w... [22:41:47] 10VisualEditor, 10VisualEditor-MediaWiki, 10WikiEditor, 10Wikimedia-General-or-Unknown, 7Regression: WikiEditor toolbar distorted by faulty gadget clashing with editor switching button on the English Wikivoyage - https://phabricator.wikimedia.org/T124513#1967823 (10Jdforrester-WMF) [22:46:02] (03CR) 10Jforrester: [C: 031] Tables: Multi-cell copy and paste [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/265660 (https://phabricator.wikimedia.org/T85791) (owner: 10Esanders) [22:46:43] edsanders: How are we going to get that +2'ed? [22:51:27] (03PS1) 10Jforrester: MWEditingTabDialog: Use 'small' size [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/266614 [22:55:38] (03PS1) 10Jforrester: Follow-up Ic506950: Use new filenames for OOUI stylesheets for demo [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/266615 [22:57:14] you tell me [23:00:26] (03CR) 10Bartosz Dziewoński: [C: 032] "James sez it works." [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/266615 (owner: 10Jforrester) [23:00:27] edsanders: It seems to work OK for me. I'm happy to +2, but you wanted Roan to have a look, despite him being (a) in a different team, (b) away at a conference in Australia, and (c) away from the conference on holiday in New Zealand. :-) [23:00:52] I'm ok with the internal list stuff now [23:01:29] OK. Could Kemayo look at it, do you think? [23:04:20] (03Merged) 10jenkins-bot: Follow-up Ic506950: Use new filenames for OOUI stylesheets for demo [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/266615 (owner: 10Jforrester) [23:20:16] 10VisualEditor, 10VisualEditor-MediaWiki, 6Editing-Analysis: Revise the Edit schema and its use - https://phabricator.wikimedia.org/T118063#1968024 (10Neil_P._Quinn_WMF) [23:27:13] (03CR) 10Alex Monk: [C: 032] MWEditingTabDialog: Use 'small' size [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/266614 (owner: 10Jforrester) [23:32:17] (03Merged) 10jenkins-bot: MWEditingTabDialog: Use 'small' size [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/266614 (owner: 10Jforrester) [23:32:22] Krenair: Have you looked at https://gerrit.wikimedia.org/r/#/c/259017/ or https://gerrit.wikimedia.org/r/#/c/252345/ ? Need any help? [23:35:05] 10VisualEditor, 10MobileFrontend, 10Reading-Web: Sample edit events in MobileFrontend at 6.25% - https://phabricator.wikimedia.org/T124845#1968065 (10Neil_P._Quinn_WMF) 3NEW a:3Neil_P._Quinn_WMF [23:35:41] 10VisualEditor, 6Editing-Analysis, 10MobileFrontend, 10Reading-Web: Sample edit events in MobileFrontend at 6.25% - https://phabricator.wikimedia.org/T124845#1968075 (10Neil_P._Quinn_WMF) [23:38:40] James_F, I left a comment on the second, yeah [23:43:02] James_F: The multi-cell pasting? I can take a look. [23:44:33] (03PS1) 10Esanders: Sequences: Check command against surface's allowed commands [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/266620 (https://phabricator.wikimedia.org/T124619) [23:45:23] (03PS1) 10Esanders: MediaDialog: Add missing indent commands to blacklist [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/266621 (https://phabricator.wikimedia.org/T124619) [23:45:40] Kemayo: Awesome. [23:46:10] Krenair: Are you going to fix the second one up? It's a bit of a mess. [23:46:28] (03PS2) 10Esanders: MWTargetWidget: Add missing indent commands to blacklists [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/266621 (https://phabricator.wikimedia.org/T124619) [23:49:16] (03CR) 10Jforrester: [C: 032] "Oops." [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/266620 (https://phabricator.wikimedia.org/T124619) (owner: 10Esanders) [23:49:49] (03CR) 10Jforrester: [C: 032] MWTargetWidget: Add missing indent commands to blacklists [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/266621 (https://phabricator.wikimedia.org/T124619) (owner: 10Esanders) [23:52:57] (03PS13) 10Esanders: Tables: Multi-cell copy and paste [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/265660 (https://phabricator.wikimedia.org/T85791) [23:53:04] ^^fixes table cut support [23:53:50] (03Merged) 10jenkins-bot: Sequences: Check command against surface's allowed commands [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/266620 (https://phabricator.wikimedia.org/T124619) (owner: 10Esanders) [23:53:52] (03Merged) 10jenkins-bot: MWTargetWidget: Add missing indent commands to blacklists [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/266621 (https://phabricator.wikimedia.org/T124619) (owner: 10Esanders) [23:57:02] (03PS1) 10Jforrester: Update VE core submodule to master (155ab43) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/266624 [23:58:35] (03PS14) 10Esanders: Tables: Multi-cell copy and paste [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/265660 (https://phabricator.wikimedia.org/T85791)