[00:32:35] 10Citoid, 10Beta-Cluster-Infrastructure, 10ContentTranslation-cxserver, 10Graphoid, and 4 others: Migrate BetaCluster Node.JS services to Jessie and Node 4.2 - https://phabricator.wikimedia.org/T125003#1971975 (10mobrovac) [00:40:58] 10VisualEditor, 10Parsoid: Possible cases where scrubWikitext wasn't being passed? - https://phabricator.wikimedia.org/T110153#1972412 (10GWicke) [01:03:22] 10Citoid, 10Beta-Cluster-Infrastructure, 10ContentTranslation-cxserver, 10Graphoid, and 4 others: Migrate BetaCluster Node.JS services to Jessie and Node 4.2 - https://phabricator.wikimedia.org/T125003#1972559 (10JanZerebecki) 01:48 < mobrovac> jzerebecki: the question is: can i just delete those machines... [01:12:41] 10Citoid, 10Beta-Cluster-Infrastructure, 10ContentTranslation-cxserver, 10Graphoid, and 4 others: Migrate BetaCluster Node.JS services to Jessie and Node 4.2 - https://phabricator.wikimedia.org/T125003#1972597 (10mobrovac) [01:27:33] 10Citoid, 10Beta-Cluster-Infrastructure, 10ContentTranslation-cxserver, 10Graphoid, and 4 others: Migrate BetaCluster Node.JS services to Jessie and Node 4.2 - https://phabricator.wikimedia.org/T125003#1972625 (10mobrovac) [01:58:31] 10Citoid, 10Beta-Cluster-Infrastructure, 10ContentTranslation-cxserver, 10Graphoid, and 4 others: Migrate BetaCluster Node.JS services to Jessie and Node 4.2 - https://phabricator.wikimedia.org/T125003#1972653 (10mobrovac) [02:05:20] 10VisualEditor: Trying to save without an internet connection loses all your work - https://phabricator.wikimedia.org/T125032#1972654 (10Whatamidoing-WMF) 3NEW [02:08:15] 10VisualEditor, 10VisualEditor-EditingTools: Do not change existing ref names, not even to add a gratuitous "2" to the end of each ref name. - https://phabricator.wikimedia.org/T125034#1972668 (10Whatamidoing-WMF) 3NEW [02:10:34] 10VisualEditor, 10VisualEditor-MediaWiki: Bi-directional switching (VE-WT-VE-WT) loses all changes on the third switch when using the Edit/Edit source tabs at the top of the page - https://phabricator.wikimedia.org/T124708#1972680 (10Krenair) Edit vs. edit source implies to me that this is only with multiple t... [02:13:26] 10VisualEditor, 10VisualEditor-MediaWiki: Fix "1 notice" on the remaining wikis - https://phabricator.wikimedia.org/T103693#1972701 (10Shizhao) [02:32:07] (03PS1) 10Alex Monk: Run VE->WTE modification checks regardless of how the user got into VE [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/266961 (https://phabricator.wikimedia.org/T124708) [03:10:04] 10Citoid, 10Beta-Cluster-Infrastructure, 10ContentTranslation-cxserver, 10Graphoid, and 5 others: Migrate BetaCluster Node.JS services to Jessie and Node 4.2 - https://phabricator.wikimedia.org/T125003#1972843 (10mobrovac) [03:57:20] 10Citoid, 10Beta-Cluster-Infrastructure, 10ContentTranslation-cxserver, 10Graphoid, and 5 others: Migrate BetaCluster Node.JS services to Jessie and Node 4.2 - https://phabricator.wikimedia.org/T125003#1972968 (10mobrovac) [03:57:34] 10Citoid, 10Beta-Cluster-Infrastructure, 10ContentTranslation-cxserver, 10Graphoid, and 4 others: Migrate BetaCluster Node.JS services to Jessie and Node 4.2 - https://phabricator.wikimedia.org/T125003#1971975 (10mobrovac) [03:58:19] 10Citoid, 10Beta-Cluster-Infrastructure, 10ContentTranslation-cxserver, 10Graphoid, and 4 others: Migrate BetaCluster Node.JS services to Jessie and Node 4.2 - https://phabricator.wikimedia.org/T125003#1971975 (10mobrovac) All done except the jenkins slaves (Parsoid and CXServer). @hashar, I'd love your he... [04:03:51] 10VisualEditor, 10VisualEditor-MediaWiki: Fix "1 notice" on the remaining wikis - https://phabricator.wikimedia.org/T103693#1973063 (10Liuxinyu970226) [04:04:41] 10VisualEditor, 10VisualEditor-MediaWiki: Fix "1 notice" on the remaining wikis - https://phabricator.wikimedia.org/T103693#1396730 (10Liuxinyu970226) [05:19:07] 10VisualEditor, 7Milestone: Make VisualEditor good enough to use with all common IMEs for Japanese - https://phabricator.wikimedia.org/T109818#1973122 (10dchan) [05:19:09] 10VisualEditor, 10VisualEditor-ContentEditable, 10VisualEditor-ContentLanguage, 7Browser-Support-Firefox: Specific kanji input causes Firefox crash on Windows 10 - https://phabricator.wikimedia.org/T118729#1973117 (10dchan) 5Open>3Resolved a:3dchan My best guess is that some unusual event sequence wa... [06:43:40] 10Cite: ref inside Wikilinks leave UNIQ - https://phabricator.wikimedia.org/T27417#1973169 (10Amire80) Meh. And a lot of references are actually templates :( [06:52:55] 10VisualEditor, 10VisualEditor-MediaWiki, 6Community-Liaison, 10MediaWiki-extensions-TemplateData, and 3 others: Check documentation for the TemplateData editor for completeness, accuracy, and ease of understanding by adding TemplateData to templates on Wik... - https://phabricator.wikimedia.org/T117499#1973174 [06:53:49] (03CR) 10DLynch: [C: 032] Tables: Multi-cell copy and paste [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/265660 (https://phabricator.wikimedia.org/T85791) (owner: 10Esanders) [06:58:28] (03Merged) 10jenkins-bot: Tables: Multi-cell copy and paste [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/265660 (https://phabricator.wikimedia.org/T85791) (owner: 10Esanders) [07:29:10] (03PS3) 10Siebrand: Create a more neutral warning message [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/266656 (https://phabricator.wikimedia.org/T121754) (owner: 10MtDu) [07:29:30] (03CR) 10Siebrand: [C: 032] "i18n/L10n reviewed." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/266656 (https://phabricator.wikimedia.org/T121754) (owner: 10MtDu) [07:41:40] 10Citoid, 10Graphoid, 6Services, 6operations: Remove Graphoid and Citoid from sca100x - https://phabricator.wikimedia.org/T125029#1973256 (10mobrovac) [07:49:13] 10Citoid, 10Graphoid, 10Mathoid, 6Services, 6operations: Remove Graphoid, Mathoid and Citoid from sca100x - https://phabricator.wikimedia.org/T125029#1973292 (10mobrovac) [07:57:35] (03Merged) 10jenkins-bot: Create a more neutral warning message [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/266656 (https://phabricator.wikimedia.org/T121754) (owner: 10MtDu) [09:55:15] (03PS1) 10Divec: Spoil the fun of guessing what current[0] and current[1] mean. [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/267005 [09:56:58] (03PS1) 10Divec: Rewrite ve.BranchNode#getNodeFromOffset to be non-recursive [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/267006 [10:00:10] (03PS2) 10Divec: Rewrite ve.BranchNode#getNodeFromOffset to be non-recursive [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/267006 [11:07:19] 10VisualEditor, 7Milestone: Make VisualEditor good enough to use with all common IMEs for Japanese - https://phabricator.wikimedia.org/T109818#1973639 (10Trizek-WMF) I've [[ https://ja.wikipedia.org/wiki/Wikipedia:%E3%81%8A%E7%9F%A5%E3%82%89%E3%81%9B#Visual_Editor_:_final_round_to_find_IME_bugs | posted a mess... [11:22:04] (03CR) 10Esanders: [C: 032] Spoil the fun of guessing what current[0] and current[1] mean. [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/267005 (owner: 10Divec) [11:24:59] current[ 0 ][ current[ 1 ] ] whoa. [11:25:53] (03Merged) 10jenkins-bot: Spoil the fun of guessing what current[0] and current[1] mean. [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/267005 (owner: 10Divec) [13:10:31] 10Cite: LDR not emitting error message when two named references are defined differently - https://phabricator.wikimedia.org/T125074#1973780 (10Izno) 3NEW [13:13:11] 10Cite: LDR not emitting error message when two named references are defined differently - https://phabricator.wikimedia.org/T125074#1973789 (10Izno) [13:16:20] 10Cite: LDR only linked from another ref in the block supposedly does not exist - https://phabricator.wikimedia.org/T125075#1973794 (10Izno) 3NEW [13:16:41] 10Cite: Multiple problems with refs inside ... blocks - https://phabricator.wikimedia.org/T24635#1973801 (10Izno) [13:18:22] 10Cite: Ref tag also used outside block does not appear - https://phabricator.wikimedia.org/T125076#1973805 (10Izno) 3NEW [13:19:15] 10Cite: Multiple problems with refs inside ... blocks - https://phabricator.wikimedia.org/T24635#1973812 (10Izno) [13:20:06] 10Cite: Note defined outside block disappears if referenced inside the references block - https://phabricator.wikimedia.org/T125077#1973813 (10Izno) 3NEW [13:21:08] 10Cite: LDR only linked from another ref in the block supposedly does not exist - https://phabricator.wikimedia.org/T125075#1973822 (10Izno) [13:21:52] 10Cite: Multiple problems with refs inside ... blocks - https://phabricator.wikimedia.org/T24635#1973827 (10Izno) Split items 4, 5, 7, and a new bug identified at en.wp:Help talk:CS1 to subtasks. [14:39:09] (03PS4) 10Alex Monk: Localise names of types in HTML rendering [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/263918 (https://phabricator.wikimedia.org/T61745) [14:43:02] (03CR) 10jenkins-bot: [V: 04-1] Localise names of types in HTML rendering [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/263918 (https://phabricator.wikimedia.org/T61745) (owner: 10Alex Monk) [15:25:36] 10Cite, 6TCB-Team, 7German-Community-Wishlist: Section edit preview doesn't let you preview references defined outside the section being previewed - https://phabricator.wikimedia.org/T124840#1974112 (10Tobi_WMDE_SW) [15:25:39] 10Cite, 6TCB-Team, 7German-Community-Wishlist, 5WMF-deploy-2016-02-02_(1.27.0-wmf.12), 7user-notice: Edit preview doesn't let you preview cite.php footnotes. - https://phabricator.wikimedia.org/T7984#1974113 (10Tobi_WMDE_SW) [15:28:57] 10Cite: LDR not emitting error message when two named references are defined differently - https://phabricator.wikimedia.org/T125074#1974121 (10John_of_Reading) Curiously, when I grab the text of that revision and feed it into ExpandTemplates, an error message *is* displayed just after reference 4. [15:59:03] (03PS5) 10Alex Monk: Localise names of types in HTML rendering [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/263918 (https://phabricator.wikimedia.org/T61745) [16:00:48] (03CR) 10jenkins-bot: [V: 04-1] Localise names of types in HTML rendering [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/263918 (https://phabricator.wikimedia.org/T61745) (owner: 10Alex Monk) [16:55:41] 10VisualEditor, 10VisualEditor-ContentEditable, 10VisualEditor-ContentLanguage, 7Browser-Support-Firefox, 5WMF-deploy-2016-02-02_(1.27.0-wmf.12): Specific kanji input causes Firefox crash on Windows 10 - https://phabricator.wikimedia.org/T118729#1974355 (10Jdforrester-WMF) [17:10:42] (03PS6) 10Alex Monk: Localise names of types in HTML rendering [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/263918 (https://phabricator.wikimedia.org/T61745) [17:57:14] (03PS2) 10DLynch: Remove uses of plain .contentEditable [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/266265 (https://phabricator.wikimedia.org/T116214) [18:03:14] (03PS1) 10Bartosz Dziewoński: ve.ui.Icons: Remove styles for unused classes .oo-ui-ltr and .oo-ui-rtl [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/267062 [18:13:32] I have no idea what happened at the end of that call, but... bye? and strange noises [18:16:09] James_F, so what's priority for me to be working on at the moment? or shall I look at something like T122388? [18:16:25] * Krenair gets dinner [18:30:15] 10VisualEditor, 10VisualEditor-MediaWiki, 10VisualEditor-MediaWiki-Media: Padding of caption box (SurfaceWidget) in the Media Settings dialog is wrong - https://phabricator.wikimedia.org/T123126#1978931 (10Jdforrester-WMF) Yeah, I thought we'd fixed this. [18:33:40] 10VisualEditor, 10VisualEditor-MediaWiki, 10VisualEditor-MediaWiki-Media: Padding of caption box (SurfaceWidget) in the Media Settings dialog is wrong - https://phabricator.wikimedia.org/T123126#1978954 (10Jdforrester-WMF) 5Open>3Resolved a:3Esanders [18:38:01] 10VisualEditor, 10VisualEditor-MediaWiki, 7Design, 7Epic: Change VE integration to only use one edit tab, to avoid user choice paralysis - https://phabricator.wikimedia.org/T58337#1978965 (10Jdforrester-WMF) [18:38:04] 10VisualEditor, 10VisualEditor-MediaWiki, 7Browser-Support-Firefox: Single edit tab: Preferences dialog is not showing in Firefox (? on Macs only) - https://phabricator.wikimedia.org/T122389#1978963 (10Jdforrester-WMF) 5Open>3declined This is intentional. We're not going to warn users that haven't seen... [18:56:33] * James_F waves at Thalia. [19:16:18] (03CR) 10Jforrester: [C: 032] Tables: Add slugs for missing cells in sparse tables [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/266506 (https://phabricator.wikimedia.org/T85464) (owner: 10Esanders) [19:16:22] hi James_F [19:17:19] Hey. [19:17:34] Krenair: Sorry, I failed to actually answer you except in my head. :-) [19:17:41] :D [19:18:59] Krenair: Other than no feedback, and needing a stiff rebase, what do you think about https://gerrit.wikimedia.org/r/#/c/140445/ ? [19:19:21] Krenair: I'd dearly love to get transclusions (magic words, parser functions etc.) working nicely in VE. [19:21:15] (03CR) 10Jforrester: [C: 031] Remove uses of plain .contentEditable (031 comment) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/266265 (https://phabricator.wikimedia.org/T116214) (owner: 10DLynch) [19:21:38] (03CR) 10Jforrester: "(Also, tsk rebase-and-change in one revision. ;-))" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/266265 (https://phabricator.wikimedia.org/T116214) (owner: 10DLynch) [19:22:59] James_F, I might want to get some input from someone about how to properly implement this in TemplateData, because it clearly wasn't intended to ever do this :) [19:23:26] one of the blockers is shipping docs for core parser functions and magic words [19:23:43] Krenair: You mean, being programmatically extensible? [19:23:43] Yeah. [19:23:48] I think I had to start either writing those docs, or copying them from mw.o, or something [19:23:59] * James_F wonders if it'd be better to wait for multi-content revisions. [19:24:04] I was seeing them as part of this patch, for core. [19:24:13] how would multi-content revisions help with this? [19:24:19] But yes, they need writing, not just wishing into being. :-) [19:25:08] 10Cite, 10MediaWiki-API, 10MobileFrontend, 3Reading-Web-Sprint-65-g: Spike: Can we store a JSON blob of references data in ParserOutput - https://phabricator.wikimedia.org/T125134#1979176 (10Jdlrobson) 3NEW a:3phuedx [19:25:51] actually I don't think I ever uploaded text [19:25:56] TD would be stored as a separate content stream alongside template revisions. Fake templates like magic words etc. would provide their own TD intercepted via RevisionSlot->getSlotName() or something. [19:26:00] (actual i18n messages) [19:26:04] * James_F nods. [19:26:05] just references to the i18n messages [19:26:48] James_F, so magic words and parser functions, which don't actually work the same way as templates, would create what are essentially special pages, within the template namespace? [19:27:27] I was assuming. [19:27:34] So that downstream clients don't need to know or care when a template is actually a magicword or not. [19:27:44] See for example {{!}} becoming a parser built-in. [19:28:03] Adjusting every client each time this changed would be (a) tedious and (b) backwards-incompatbile. [19:28:05] Also spelling. [19:28:05] so part of what timo wrote in one of the blocker tasks is relevant here [19:28:09] " [19:28:10] parser functions don't have numerical parameters, and the first parameter is separated by colon, not by pipe. So we need a way (both in TemplateData and VisualEditor) to insert unnamed parameters without using numbers. [19:28:10] e.g. {{urlencode:Foo|WIKI}} is correct, but {{urlencode:Foo|1=WIKI}} or {{urlencode:1=Foo|2=WIKI}} or {{urlencode|1=Foo|2=WIKI}} is wrong." [19:28:37] * James_F nods. [19:28:41] Yeah, it's… complicated. [19:28:46] magic words have a different syntax too [19:28:55] Mostly that's Parsoid's problem rather than VE's. [19:28:55] But still. [19:29:13] Yup. [19:29:29] we should be considering non-VE users of TD [19:29:30] * James_F sighs. [19:29:39] I knew you were going to do that [19:29:50] I am. [19:30:07] But 'non-VE users' isn't just 'people writing raw wikitext'. ;-) [19:32:09] (03Merged) 10jenkins-bot: Tables: Add slugs for missing cells in sparse tables [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/266506 (https://phabricator.wikimedia.org/T85464) (owner: 10Esanders) [19:32:35] 10VisualEditor, 10VisualEditor-Tables, 7Epic: Fully support basic table editing in the visual editor - https://phabricator.wikimedia.org/T108245#1979202 (10Jdforrester-WMF) [19:32:37] 10VisualEditor, 10VisualEditor-Tables, 5WMF-deploy-2016-02-02_(1.27.0-wmf.12): Make it possible to insert a missing cell into a table - https://phabricator.wikimedia.org/T85464#1979200 (10Jdforrester-WMF) 5Open>3Resolved [19:32:55] James_F, yes, I know [19:35:25] As of next week or whenever, Parsoid will be the largest user of TD ahead of VE, technically. [19:35:25] We should maybe work on the "find templates lacking TD" bug, I guess. [19:37:46] anyway we've got off-topic [19:38:55] 10VisualEditor, 10VisualEditor-MediaWiki, 10MediaWiki-extensions-FlaggedRevs: Pages with pending changes show an "Edit" tab label even when they actually mean "Edit source" - https://phabricator.wikimedia.org/T124652#1979218 (10aaron) a:5aaron>3None [19:38:55] I'll want to get input from timo early on [19:39:40] Roan might be good to speak to instead if you can't get Timo. [19:39:42] But yeah. [19:40:18] (03PS22) 10Jforrester: Tables: Move columns and rows [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/263869 (https://phabricator.wikimedia.org/T88694) (owner: 10Esanders) [19:40:34] I think Roan is away, I also wanted to speak to him about something else [19:40:46] He is, he's in .au. [19:41:04] Wait, no. He's in .nz, he's in .au from tomorrow. [19:41:12] I was about to say.. :P [19:41:35] (03CR) 10Jforrester: [C: 04-1] "Column context menu has wrong heigh, throws error on open, doesn't work." [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/263869 (https://phabricator.wikimedia.org/T88694) (owner: 10Esanders) [19:42:17] For some reason I thought his flight was yesterday. [19:42:48] Krenair: Do you want to try to do the template field button to switch to wikitext? [19:43:10] oh, yes, the type fallback stuff [19:45:00] I knew there was something that kept escaping my attention [19:45:59] :-) [19:46:05] Do you still have my high-quality sketch? [19:47:13] James_F, was this it? https://dl.dropboxusercontent.com/u/17195534/Screen Shot 2016-01-22 at 11.05.20.png [19:47:13] Yup. [19:47:13] Innit pretty? ;-) [19:47:13] the cog button forces it to be wikitext? [19:47:13] Yeah. [19:47:20] Just an idea. If you have a better one, implement that. :-) [19:52:52] (03PS5) 10Esanders: Move logic for showing icon for invisibles to focusable node [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/266774 [19:53:05] (03CR) 10Esanders: "Moved the icon up a pixel" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/266774 (owner: 10Esanders) [20:04:17] James_F, so I need a way to determine whether a particular value is valid for a given type [20:04:39] I think ideally I'd be able to ask the input widget which I'd like to use for that type whether it's valid or not [20:06:28] However, isValid is not static [20:06:52] so I need to set the input widget up, give it the value, and then decide whether that's invalid and I need to throw it away [20:06:54] 10Cite, 6TCB-Team, 7German-Community-Wishlist: Section edit preview doesn't let you preview references defined outside the section being previewed - https://phabricator.wikimedia.org/T124840#1979315 (10Cenarium) a:3Cenarium Actually, I think that page_props is a good solution. The size limit can be circum... [20:08:20] Krenair: Surely Parsoid is the only trustable thing to tell you? [20:08:58] well for types like number we don't need parsoid [20:09:11] I worry about putting too much logic in the client. [20:09:16] But yes. [20:10:06] for content, yes we'd probably need parsoid to tell us whether that's valid - [20:10:06] wait [20:10:14] what would invalid wikitext be? [20:11:29] Invalid wikitext would be something like "1=hello". [20:11:41] There's no such thing as invalid unbalanced-wikitext, but that's different. [20:12:31] Also, https://phabricator.wikimedia.org/T124652#1979218 :-( [20:18:19] 10VisualEditor, 10VisualEditor-MediaWiki, 10MediaWiki-extensions-FlaggedRevs: Pages with pending changes show an "Edit" tab label even when they actually mean "Edit source" - https://phabricator.wikimedia.org/T124652#1979339 (10Krenair) @aaron: Is that a no, or..? I need your input as the FlaggedRevs guy :/ [20:21:37] edsanders: Ping re. https://gerrit.wikimedia.org/r/#/c/263869/ in case you didn't see my -1. [20:28:46] (03PS23) 10Esanders: Tables: Move columns and rows [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/263869 (https://phabricator.wikimedia.org/T88694) [20:28:56] yep, logical rebase error on getMaxColCount patch [20:30:11] Ah, right. [20:31:48] 10VisualEditor, 10VisualEditor-MediaWiki, 10MediaWiki-extensions-FlaggedRevs: Pages with pending changes show an "Edit" tab label even when they actually mean "Edit source" - https://phabricator.wikimedia.org/T124652#1979372 (10aaron) It's not really my area atm. Also, my task assigners are normally myself a... [20:32:36] 10Citoid, 10Graphoid, 10Mathoid, 6Services, and 2 others: Remove Graphoid, Mathoid and Citoid from sca100x - https://phabricator.wikimedia.org/T125029#1979380 (10Dzahn) @mobrovac looks done meanwhile? ``` Linux sca1001 3.13.0-44-generic #73-Ubuntu SMP Tue Dec 16 00:22:43 UTC 2014 x86_64 Ubuntu 14.04.3 LT... [20:32:59] James_F, so basically if we give it some wikitext, it should say whether that's balanced or not. if it's unbalanced, we fall back to source editing, otherwise we show the parsed result in a surface? [20:34:05] 10Citoid, 10Graphoid, 10Mathoid, 6Services, and 2 others: Remove Graphoid, Mathoid and Citoid from sca100x - https://phabricator.wikimedia.org/T125029#1979412 (10Dzahn) ah, looks like they are still running on sca1002. want me to kill those process and clean up? [20:34:08] Yeah. There's a function for this in the Parsoid API somewhere. [20:34:08] data-mw stuff. [20:34:40] James_F, maybe we should just say that performance is blocking SET [20:36:13] Krenair: I did in Scrum of Scrums. [20:36:31] Also, performance isn't blocked SET, but Performance is. ;-) [20:37:03] well now we have another bug to add to the list [20:41:13] * James_F nods. [20:41:44] (03CR) 10Jforrester: [C: 032] Tables: Move columns and rows [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/263869 (https://phabricator.wikimedia.org/T88694) (owner: 10Esanders) [20:42:34] 10VisualEditor, 10VisualEditor-Tables, 7Epic: Fully support basic table editing in the visual editor - https://phabricator.wikimedia.org/T108245#1979447 (10Jdforrester-WMF) [20:42:36] 10VisualEditor, 10VisualEditor-Tables, 5WMF-deploy-2016-02-02_(1.27.0-wmf.12), 7user-notice: Be able to copy/paste whole tables, without selecting anything else on the page - https://phabricator.wikimedia.org/T123826#1979442 (10Jdforrester-WMF) 5Open>3Resolved a:3Esanders [20:42:59] 10VisualEditor, 10VisualEditor-Tables, 7Epic: Fully support basic table editing in the visual editor - https://phabricator.wikimedia.org/T108245#1516043 (10Jdforrester-WMF) [20:43:01] 10VisualEditor, 10VisualEditor-Tables, 5WMF-deploy-2016-02-02_(1.27.0-wmf.12), 7user-notice: Be able to re-order the columns or rows of a table in VisualEditor - https://phabricator.wikimedia.org/T88694#1979448 (10Jdforrester-WMF) 5Open>3Resolved a:3Esanders [20:43:23] 10VisualEditor, 10VisualEditor-Tables, 7Epic: Fully support basic table editing in the visual editor - https://phabricator.wikimedia.org/T108245#1516043 (10Jdforrester-WMF) [20:43:25] 10VisualEditor, 10VisualEditor-CopyPaste, 10VisualEditor-Tables, 5WMF-deploy-2016-02-02_(1.27.0-wmf.12), 7user-notice: Allow copy/pasting of arbitrary selections of table cells - https://phabricator.wikimedia.org/T85791#1979452 (10Jdforrester-WMF) 5Open>3Resolved a:3Esanders [20:44:15] 10VisualEditor, 10VisualEditor-Tables: Be able to move a cell/cell selection/row/column by dragging - https://phabricator.wikimedia.org/T125145#1979456 (10Jdforrester-WMF) 3NEW [20:45:14] 10VisualEditor, 10VisualEditor-Tables, 5WMF-deploy-2016-02-02_(1.27.0-wmf.12), 7user-notice: Be able to re-order the columns or rows of a table in VisualEditor - https://phabricator.wikimedia.org/T88694#1979465 (10Jdforrester-WMF) Note that this is "just" moving columns and rows one by one through the cont... [20:46:51] 10VisualEditor, 10VisualEditor-MediaWiki, 7I18n, 5WMF-deploy-2016-02-02_(1.27.0-wmf.12): Create a more neutral warning message when leaving VE edit mode - https://phabricator.wikimedia.org/T121754#1979467 (10Jdforrester-WMF) 5Open>3Resolved a:3MtDu [20:47:12] 10VisualEditor, 10VisualEditor-ContentEditable, 10VisualEditor-Tables, 7Epic: Tab/Shift-Tab behaviour in contexts other than list indent/outdent (e.g. tables) - https://phabricator.wikimedia.org/T72665#1979471 (10Jdforrester-WMF) [20:47:14] 10VisualEditor, 10VisualEditor-Tables, 7Epic: Fully support basic table editing in the visual editor - https://phabricator.wikimedia.org/T108245#1979470 (10Jdforrester-WMF) [20:50:02] (03CR) 10DLynch: "Could also make those changes just on `.ve-ce-commentNode` as smaller tweaks, I guess." (032 comments) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/266774 (owner: 10Esanders) [20:50:44] 10Citoid, 10Graphoid, 10Mathoid, 6Services, and 2 others: Remove Graphoid, Mathoid and Citoid from sca100x - https://phabricator.wikimedia.org/T125029#1979477 (10mobrovac) >>! In T125029#1979412, @Dzahn wrote: > ah, looks like they are still running on sca1002. want me to kill those process and clean up?... [20:51:11] Kemayo, what were the restbase vagrant issues you had? [20:53:13] 10Cite, 10MediaWiki-API, 10MobileFrontend, 3Reading-Web-Sprint-65-g: Spike: Can we store a JSON blob of references data in ParserOutput - https://phabricator.wikimedia.org/T125134#1979488 (10Cenarium) Yes. The successive mRefs arrays can be saved as extension data during parse. Then, the array can be json_... [20:55:46] 10Citoid, 10Graphoid, 10Mathoid, 6Services, and 2 others: Remove Graphoid, Mathoid and Citoid from sca100x - https://phabricator.wikimedia.org/T125029#1979497 (10Dzahn) stopped all 3 services on both machines, ran puppet, confirmed they did not get restarted anymore [21:03:33] 10Citoid, 10Graphoid, 10Mathoid, 6Services, and 2 others: Remove Graphoid, Mathoid and Citoid from sca100x - https://phabricator.wikimedia.org/T125029#1979522 (10Dzahn) the issue we saw on icinga is also gone. done? [21:04:28] (03Merged) 10jenkins-bot: Tables: Move columns and rows [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/263869 (https://phabricator.wikimedia.org/T88694) (owner: 10Esanders) [21:06:03] 10Citoid, 10Graphoid, 10Mathoid, 6Services, and 2 others: Remove Graphoid, Mathoid and Citoid from sca100x - https://phabricator.wikimedia.org/T125029#1979531 (10mobrovac) 5Open>3Resolved a:3mobrovac Confirmed it's all good, so resolving. Thnx @Dzahn! [21:06:22] 10Citoid, 10Graphoid, 10Mathoid, 6Services, 6operations: Remove Graphoid, Mathoid and Citoid from sca100x - https://phabricator.wikimedia.org/T125029#1979534 (10mobrovac) [21:07:23] (03CR) 10Jforrester: [C: 031] "Moderately moves the icons in comments, but I think it's fine." [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/266774 (owner: 10Esanders) [21:11:41] 10VisualEditor, 10ContentTranslation-Deployments, 10ContentTranslation-cxserver, 10Parsoid, and 4 others: Decom parsoid-lb.eqiad.wikimedia.org entrypoint - https://phabricator.wikimedia.org/T110474#1979545 (10BBlack) Status for `parsoid-lb.eqiad.wikimedia.org`: only a small handful of requests are still fl... [21:12:31] turns out I needed to update the vagrant folder itself but now getting some error about mysql when trying to provision [21:13:47] (03PS1) 10Jforrester: Update VE core submodule to master (526e1bf) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/267136 [21:13:59] edsanders: Odd. [21:14:38] 10VisualEditor, 10VisualEditor-MediaWiki, 10MediaWiki-extensions-FlaggedRevs, 7Blocked-on-Performance: Pages with pending changes show an "Edit" tab label even when they actually mean "Edit source" - https://phabricator.wikimedia.org/T124652#1979558 (10Jdforrester-WMF) [21:14:42] 10VisualEditor: Backspacing at the start of a bulleted list item should convert item to plain paragraph before combining with the previous element - https://phabricator.wikimedia.org/T125148#1979559 (10Neil_P._Quinn_WMF) 3NEW [21:16:33] 10VisualEditor, 10VisualEditor-MediaWiki, 7Blocked-on-Performance, 5Patch-For-Review: On single edit tab wikis, if your browser is non-JS but your settings say VE you get a blank edit page and no way to fix it - https://phabricator.wikimedia.org/T121257#1979573 (10Jdforrester-WMF) [21:16:48] 10VisualEditor, 10VisualEditor-MediaWiki, 7Blocked-on-Performance, 5Patch-For-Review: On single edit tab wikis, if your browser runs JS but is only grade C supported (no MW JS) you probably get a blank edit page and no way to fix it - https://phabricator.wikimedia.org/T123457#1979577 (10Jdforrester-WMF) [21:24:24] (03CR) 10Krinkle: Move logic for showing icon for invisibles to focusable node (031 comment) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/266774 (owner: 10Esanders) [21:25:31] (03CR) 10Alex Monk: Update VE core submodule to master (526e1bf) (031 comment) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/267136 (owner: 10Jforrester) [21:29:15] Krinkle: Could you please stop reviewing the wrong code? We're blocked on you and it's not that patch. :-P [21:30:21] Error: Could not find dependency Mysql::Db[undef] [21:30:39] who do I ask about vagrant? [21:34:39] edsanders: you rang? :) [21:34:55] bd808, ^^ getting that error when running vagrant provision [21:35:19] this was after updating my vagrant folder to latest master [21:35:24] and running setup.sh [21:35:44] edsanders: can you do "PUPPET_DEBUG=1 vagrant provision" and paste the huge log output somewhere? [21:36:28] the whole thing? [21:36:36] or just the last N? [21:39:44] bd808, http://pastebin.com/bLHQjKkX [21:40:14] that's that last 100 odd, there were 5000 lines [21:41:38] it's got the bit I wanted most I think [21:41:52] ::role::echo is a bit wonky [21:42:13] it's assuming puppet ordering I think [21:42:25] and not really using hiera correctly [21:43:24] edsanders: can your fix wait for a hour or so? [21:43:29] is that a problem with my machine or the codebase? [21:43:45] yeah probably [21:43:50] I'd say it's a problem with the codebase that exhibits on your machine [21:44:51] ok, at least I'm not going crazy then [21:45:39] edsanders: I think you can monkey patch locally with "role::echo::shared_tracking_db: wikishared" in your puppet/hieradata/local.yaml file [21:45:46] you may have to create that file [21:46:24] If you can take a couple of minutes to file a bug in phab that would be awesome too [21:46:43] * bd808 returns to debugging another thingy that is borked [21:47:23] I'm also getting some warnings [21:47:39] Warning: Scope(Class[Role::Echo]): Could not look up qualified variable '::mediawiki::multiwiki::extension_db_cluster'; class ::mediawiki::multiwiki has not been evaluated [21:48:16] patch seems to work, thanks [21:50:20] edsanders: that warning is the root problem [21:50:34] some stuff just needs to be rearranged in the config [22:01:35] Krenair: Hmm. Not sure how DocumentSynchronizer is making it into the build. [22:02:26] Krenair: It's still in eg-iframe.html [22:09:24] (03CR) 10Jforrester: Update VE core submodule to master (526e1bf) (031 comment) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/267136 (owner: 10Jforrester) [22:09:39] Krenair: That should be OK. [22:11:35] 10VisualEditor, 10VisualEditor-MediaWiki, 10MediaWiki-extensions-FlaggedRevs, 7Blocked-on-Performance: Pages with pending changes show an "Edit" tab label even when they actually mean "Edit source" - https://phabricator.wikimedia.org/T124652#1979777 (10Krenair) @Ori helped me track this down. It was commit... [22:11:49] 10VisualEditor, 10VisualEditor-MediaWiki, 10MediaWiki-extensions-FlaggedRevs: Pages with pending changes show an "Edit" tab label even when they actually mean "Edit source" - https://phabricator.wikimedia.org/T124652#1979780 (10Krenair) [22:13:31] I love deleting code to fix bugs. [22:13:52] :-) [22:18:54] 10VisualEditor, 10VisualEditor-MediaWiki, 10MediaWiki-extensions-FlaggedRevs, 5Patch-For-Review: Pages with pending changes show an "Edit" tab label even when they actually mean "Edit source" - https://phabricator.wikimedia.org/T124652#1979806 (10Krenair) a:3Krenair [22:21:13] (03CR) 10Alex Monk: [C: 032] Update VE core submodule to master (526e1bf) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/267136 (owner: 10Jforrester) [22:30:35] (03Merged) 10jenkins-bot: Update VE core submodule to master (526e1bf) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/267136 (owner: 10Jforrester) [22:39:53] edsanders: My restbase issue turned out to be that I hadn't done a git pull in the vagrant repo itself, because I'd been kind of assuming that `vagrant git-update` included that, and as a result the restbase config was out of sync with an updated version of restbase that got installed. [22:40:17] Kemayo, yeah had the same issue - then tripped on a an actual vagrant bug ^^ [22:41:36] I also had a separate issue with parsoid, which was because in the course of trying random things to debug why mathoid wasn't working I'd run `npm install` on my mac instead of inside the vm, which wound up getting me the wrong binary architecture inside one of the node_modules. [22:42:03] ...and then after everything mathoid still wasn't working. So I went to bed, and it started working the next day for no explicable reason. :P [22:58:51] 2 reports of editors seeing "Edit source " and "Edit " for the page tabs. [22:58:57] https://twitter.com/MagnusManske/status/692833819263500288 [22:58:57] and [22:58:57] https://en.wikipedia.org/wiki/Wikipedia:Village_pump_%28technical%29#.22Undefined.22_on_edit_links [22:59:20] perhaps Windows only? (I can't reproduce in Linux firefox) [22:59:42] the second report says "Firefox 47.0a1 on Windows 10 TH2" [23:00:57] James_F, might be appendix stuff? [23:05:21] I can't reproduce in chromium or opera, either. [23:11:25] (03CR) 10Krinkle: Remove uses of plain .contentEditable (031 comment) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/266265 (https://phabricator.wikimedia.org/T116214) (owner: 10DLynch) [23:11:31] quiddity: Might be a broken gadget. [23:12:02] I couldn't see anything in their respective common/vector/global.js. I'lll check gadgets.. [23:12:39] 10VisualEditor, 10VisualEditor-ContentEditable, 5Patch-For-Review, 7Technical-Debt: Switch to using isContentEditable instead of contentEditable - https://phabricator.wikimedia.org/T116214#1980152 (10Krinkle) Yay! Nice work. [23:23:42] nothing obvious in gadgets... :/ [23:26:04] James_F|Away: i have it too [23:26:18] Enabled all gadgets. Still can't reproduce. [23:26:32] could be a user script [23:26:35] * thedj checks [23:26:50] Krenair, not a userscript. Magnus disabled all his, and still sees it. [23:27:10] https://twitter.com/MagnusManske/status/692833819263500288 [23:27:27] James_F|Away, Krenair er wut http://i.imgur.com/iVnt8aM.png !? [23:27:45] edsanders, what OS? [23:27:59] ubuntu [23:28:04] not really relevant quiddity [23:28:09] mw.loader.implement("ext.visualEditor.desktopArticleTarget.init" [23:28:09] what if you set uselang=qqx? [23:28:44] sounds like i'm getting old scripts. [23:29:03] possibly the race condition again after a scap ? [23:30:09] qqx looks fine [23:30:22] (vector-view-view)(visualeditor-ca-editsource)(vector-view-edit)(vector-view-history) [23:30:45] switching back the bug is now gone [23:31:04] yup, for me gone now as well [23:31:32] heisenbug [23:31:46] and the script is now updated to. [23:32:08] i have different ve JS resource delivered now [23:32:21] James_F|Away: Interesting. greenkeeper-iobot ; https://github.com/filamentgroup/loadCSS/pull/117 Uses Travis CI with David (the other other other David, the mechanical one - https://david-dm.org ) to update dependencies and make pulls. [23:32:27] 10VisualEditor, 6Editing-Analysis: Start generating a visual editor adoption metric - https://phabricator.wikimedia.org/T109158#1980206 (10leila) [23:34:00] interesting - if you use an invalid language code you get system defaults - not 'en', so 'Article' becomes 'Page', ', the free encyclopedia' disappears... [23:36:31] also it's encyclopedia even in en-GB, James_F|Away must have given up the fight [23:36:31] lol, and, Interesting/useful! [23:36:31] still seeing the issue quiddity? [23:36:31] oh, you couldn't reproduce it [23:36:59] and thedj has beat me to replying at VPT (<3) [23:40:37] (03CR) 10Esanders: Remove uses of plain .contentEditable (031 comment) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/266265 (https://phabricator.wikimedia.org/T116214) (owner: 10DLynch)