[00:07:46] whoa. https://phabricator.wikimedia.org/F3289480 [00:07:52] what did you guys break this time [00:14:59] see ^ [00:15:16] tldr: not sure, caching? [00:15:41] i apparently only see this on opera 12, btw. :P [00:16:09] oh huh, not just me? okayyy [00:38:23] Krinkle: Neat about greenkeeper. Can I get review on https://gerrit.wikimedia.org/r/#/c/259771/ https://gerrit.wikimedia.org/r/#/c/265878/ https://gerrit.wikimedia.org/r/#/c/265879/ ? :-) [00:44:29] 10VisualEditor, 6Editing-Department, 10MobileFrontend, 7Mobile, 5Patch-For-Review: Enable editing for mobile users without JavaScript and kill Special:MobileEditor code in MobileFrontend - https://phabricator.wikimedia.org/T125174#1980476 (10Jdforrester-WMF) p:5Triage>3Normal [00:44:42] 10VisualEditor, 6Editing-Department, 10MobileFrontend, 7Mobile, 5Patch-For-Review: Enable editing for mobile users without JavaScript and kill Special:MobileEditor code in MobileFrontend - https://phabricator.wikimedia.org/T125174#1980479 (10Jdlrobson) [01:11:36] ^ James_F any thoughts about that? [01:11:55] jdlrobson: The task or the photo? [01:12:09] just the general idea - is there any reason we want to keep it hidden behind JS? [01:12:35] and if turning it on is a good idea is it something that's likely to be volunteer led or editing team led? [01:14:12] jdlrobson: I'd be happy to help shepherd it, but if there's a volunteer who's keen I'd love to support them. [01:14:25] jdlrobson: I'm assuming there's not, but… [01:14:31] i wonder if Florian might be interested :) [01:14:42] Ha. Plausibly. :-) [01:14:44] would be good to get a green light from you though if it is something you want [01:14:47] also codezee [01:14:58] Totally in favour. [01:14:59] I even thumb-up-ed it. :-) [01:15:01] Yeah. [01:15:15] jdlrobson: Thank you for this. [01:16:16] 10VisualEditor, 10VisualEditor-MediaWiki, 7Design, 7Epic: Change VE integration to only use one edit tab, to avoid user choice paralysis - https://phabricator.wikimedia.org/T58337#1980578 (10Jdforrester-WMF) [01:16:20] 10VisualEditor, 10VisualEditor-MediaWiki, 10MediaWiki-extensions-FlaggedRevs: Pages with pending changes show an "Edit" tab label even when they actually mean "Edit source" - https://phabricator.wikimedia.org/T124652#1980575 (10Jdforrester-WMF) 5Open>3Resolved [01:16:24] 10VisualEditor, 6Editing-Department, 10MobileFrontend, 7Mobile, 5Patch-For-Review: Enable editing for mobile users without JavaScript and kill Special:MobileEditor code in MobileFrontend - https://phabricator.wikimedia.org/T125174#1980579 (10Jdlrobson) @sumit / @florian - something you might be intereste... [02:29:53] 10VisualEditor, 6Research-and-Data: Add support for hashtags (URL parameter -> edit summary) - https://phabricator.wikimedia.org/T123529#1980688 (10Neil_P._Quinn_WMF) [02:48:41] 10VisualEditor, 10VisualEditor-Initialisation, 10VisualEditor-Performance, 6Collaboration-Team-Backlog, and 6 others: Store & load data-mw separately - https://phabricator.wikimedia.org/T78676#1980700 (10mobrovac) [02:52:39] (03CR) 10Esanders: Rewrite ve.BranchNode#getNodeFromOffset to be non-recursive (031 comment) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/267006 (owner: 10Divec) [03:21:50] 10Cite, 10MediaWiki-API, 10MobileFrontend, 3Reading-Web-Sprint-65-g: Spike: Can we store a JSON blob of references data in ParserOutput - https://phabricator.wikimedia.org/T125134#1980726 (10Anomie) I suppose that proposing serializing to JSON is to save a few bytes over just putting the data structure int... [04:21:01] 10VisualEditor, 10VisualEditor-MediaWiki, 10VisualEditor-MediaWiki-Media, 7I18n: Actually pass username to visualeditor-dialog-media-info-meta-artist - https://phabricator.wikimedia.org/T109563#1980774 (10MtDu) I don't think this message needs GENDER. What do you all think? Thanks, MtDu [07:01:24] 10VisualEditor, 6Editing-Department, 10MobileFrontend, 7Mobile, 5Patch-For-Review: Enable editing for mobile users without JavaScript and kill Special:MobileEditor code in MobileFrontend - https://phabricator.wikimedia.org/T125174#1980941 (10Sumit) a:3Sumit I'll submit a patch soon. [07:01:31] 10VisualEditor, 6Editing-Department, 10MobileFrontend, 7Mobile: Enable editing for mobile users without JavaScript and kill Special:MobileEditor code in MobileFrontend - https://phabricator.wikimedia.org/T125174#1980943 (10Sumit) [07:24:52] 10VisualEditor, 6Editing-Department, 10MobileFrontend, 7Mobile: Enable editing for mobile users without JavaScript and kill Special:MobileEditor code in MobileFrontend - https://phabricator.wikimedia.org/T125174#1980958 (10Florian) @Sumit: Ok, great, thanks :) I'm interested in this, too, so if you need he... [09:20:39] (03CR) 10Siebrand: [C: 04-1] "i18n/L10n reviewed." (032 comments) [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/263918 (https://phabricator.wikimedia.org/T61745) (owner: 10Alex Monk) [09:44:38] 10VisualEditor, 10VisualEditor-MediaWiki, 7I18n, 5WMF-deploy-2016-02-02_(1.27.0-wmf.12), 7user-notice: Create a more neutral warning message when leaving VE edit mode - https://phabricator.wikimedia.org/T121754#1981034 (10Trizek-WMF) [09:45:06] 10Cite, 6TCB-Team, 7German-Community-Wishlist: Section edit preview doesn't let you preview references defined outside the section being previewed - https://phabricator.wikimedia.org/T124840#1981036 (10Tobi_WMDE_SW) @Cenarium great! Let me know when you need help or review. [10:24:58] (03CR) 10TheDJ: [C: 032] Use boolean values for .prop() on boolean HTML attributes [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/264278 (owner: 10Gerrit Patch Uploader) [10:26:45] (03Merged) 10jenkins-bot: Use boolean values for .prop() on boolean HTML attributes [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/264278 (owner: 10Gerrit Patch Uploader) [11:08:51] 10Cite, 10MediaWiki-API, 10MobileFrontend, 3Reading-Web-Sprint-65-g: Spike: Can we store a JSON blob of references data in ParserOutput - https://phabricator.wikimedia.org/T125134#1981196 (10phuedx) > I suppose that proposing serializing to JSON is to save a few bytes over just putting the data structure i... [11:10:10] 10Cite, 10MediaWiki-API, 10MobileFrontend, 3Reading-Web-Sprint-65-g: Spike: Can we store a JSON blob of references data in ParserOutput - https://phabricator.wikimedia.org/T125134#1981197 (10phuedx) >>! In T125134#1979488, @Cenarium wrote: > Yes. The successive mRefs arrays can be saved as extension data d... [11:26:13] 10VisualEditor, 10ContentTranslation-Deployments, 10ContentTranslation-cxserver, 10Parsoid, and 4 others: Decom parsoid-lb.eqiad.wikimedia.org entrypoint - https://phabricator.wikimedia.org/T110474#1981220 (10BBlack) Here's a better list: cxserver deploy: https://github.com/wikimedia/mediawiki-services-cx... [12:23:42] 10VisualEditor, 10VisualEditor-Tables, 5WMF-deploy-2016-02-02_(1.27.0-wmf.12), 7user-notice: Be able to copy/paste whole tables, without selecting anything else on the page - https://phabricator.wikimedia.org/T123826#1981284 (10Esanders) Admittedly this requires selecting the whole table which may not be t... [13:15:37] 10VisualEditor, 10VisualEditor-MediaWiki, 10VisualEditor-MediaWiki-Media, 7I18n: Actually pass username to visualeditor-dialog-media-info-meta-artist - https://phabricator.wikimedia.org/T109563#1981362 (10Nemo_bis) >>! In T109563#1980774, @MtDu wrote: > I don't think this message needs GENDER. What do you... [13:31:06] 10Cite: False duplicate errors ("defined multiple times with different content") when using {{#tag:ref}} with XML-style tags inside - https://phabricator.wikimedia.org/T118603#1981402 (10THE_IT) @matmarex: Thanks for your help. I applied your suggestions. This fix the big red errors for the moment. But still is... [14:11:18] 10VisualEditor, 10VisualEditor-ContentLanguage, 10Wikimedia-Site-Requests, 5Patch-For-Review: Make VisualEditor work by default in some "easier" phase 6 Wikipedias - https://phabricator.wikimedia.org/T116523#1981521 (10Elitre) [14:15:55] 10Cite, 10MobileFrontend, 3Reading-Web-Sprint-65-g: Spike: Can we store a JSON blob of references data in ParserOutput - https://phabricator.wikimedia.org/T125134#1981526 (10Anomie) [14:22:53] 10Cite, 10MobileFrontend, 3Reading-Web-Sprint-65-g: Spike: Can we store a JSON blob of references data in ParserOutput - https://phabricator.wikimedia.org/T125134#1981537 (10Anomie) >>! In T125134#1981196, @phuedx wrote: >> I suppose that proposing serializing to JSON is to save a few bytes over just putting... [14:48:48] 10VisualEditor, 10VisualEditor-MediaWiki, 6Community-Liaison, 10MediaWiki-extensions-TemplateData, and 3 others: Check documentation for the TemplateData editor for completeness, accuracy, and ease of understanding by adding TemplateData to templates on Wik... - https://phabricator.wikimedia.org/T117499#1981566 [15:58:48] 10VisualEditor, 10VisualEditor-CopyPaste, 10VisualEditor-Tables: Inserting a new row created a nested table - https://phabricator.wikimedia.org/T122413#1981707 (10Esanders) 5Open>3declined a:3Esanders Now that we support cell copy paste this is less likely to happen [16:14:36] 10VisualEditor, 10ContentTranslation-Deployments, 10ContentTranslation-cxserver, 10Parsoid, and 4 others: Decom parsoid-lb.eqiad.wikimedia.org entrypoint - https://phabricator.wikimedia.org/T110474#1981719 (10ssastry) >>! In T110474#1981220, @BBlack wrote: > integration-visualdiff: > https://github.com/wik... [16:21:48] 10VisualEditor, 10VisualEditor-Links: Offer a tab for UNC links - https://phabricator.wikimedia.org/T123154#1981753 (10AmazingTrans) Is there any sample on how to include that into a VE? Issue is i do not know how to write an extension for the VE. Like including the template with templatedata into VE> [16:22:52] 10VisualEditor, 10VisualEditor-Tables: [regression] VE crashes on pages with plain tables - https://phabricator.wikimedia.org/T125219#1981758 (10Esanders) 3NEW a:3Esanders [16:23:18] (03PS1) 10Esanders: ClassAttributeNode: Handle undefined attributes [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/267272 (https://phabricator.wikimedia.org/T125219) [16:23:38] edsanders: Oops. [16:23:45] (03CR) 10Jforrester: [C: 032] ClassAttributeNode: Handle undefined attributes [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/267272 (https://phabricator.wikimedia.org/T125219) (owner: 10Esanders) [16:24:03] 10VisualEditor, 10VisualEditor-MediaWiki, 10VisualEditor-Tables, 5Patch-For-Review: [regression] VE crashes on pages with plain tables - https://phabricator.wikimedia.org/T125219#1981771 (10Esanders) [16:26:23] 10VisualEditor, 10VisualEditor-DataModel, 10VisualEditor-Tables: [regression] Copying a plain table to another VE instance converts it to a wikitable - https://phabricator.wikimedia.org/T125220#1981777 (10Esanders) 3NEW a:3Esanders [16:30:09] yeah [16:30:30] (03Merged) 10jenkins-bot: ClassAttributeNode: Handle undefined attributes [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/267272 (https://phabricator.wikimedia.org/T125219) (owner: 10Esanders) [16:31:04] (03PS1) 10Jforrester: Update VE core submodule to master (9704a43) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/267273 [16:31:06] edsanders: ^^ +2 please. [16:32:14] 10VisualEditor, 10VisualEditor-MediaWiki, 10VisualEditor-Tables, 5WMF-deploy-2016-02-02_(1.27.0-wmf.12): [Regression pre-wmf.12] VE crashes on pages with plain tables - https://phabricator.wikimedia.org/T125219#1981802 (10Jdforrester-WMF) 5Open>3Resolved p:5Triage>3Unbreak! [16:32:43] 10VisualEditor, 10VisualEditor-CopyPaste, 10VisualEditor-DataModel, 10VisualEditor-Tables: [Regression pre-wmf.12] Copying a plain table to another VE instance converts it to a wikitable - https://phabricator.wikimedia.org/T125220#1981807 (10Jdforrester-WMF) [16:32:53] 10VisualEditor, 10VisualEditor-CopyPaste, 10VisualEditor-DataModel, 10VisualEditor-Tables: [Regression pre-wmf.12] Copying a plain table to another VE instance converts it to a wikitable - https://phabricator.wikimedia.org/T125220#1981777 (10Jdforrester-WMF) p:5Triage>3High [16:35:43] (03CR) 10Jforrester: [C: 032] ve.ui.Icons: Remove styles for unused classes .oo-ui-ltr and .oo-ui-rtl [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/267062 (owner: 10Bartosz Dziewoński) [16:36:07] (03CR) 10jenkins-bot: [V: 04-1] Update VE core submodule to master (9704a43) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/267273 (owner: 10Jforrester) [16:36:51] (03CR) 10Jforrester: "recheck" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/267273 (owner: 10Jforrester) [16:59:30] 10VisualEditor, 6Editing-Department, 10MobileFrontend, 7Mobile: Enable editing for mobile users without JavaScript and kill Special:MobileEditor code in MobileFrontend - https://phabricator.wikimedia.org/T125174#1981887 (10Jdlrobson) [17:00:40] (03Merged) 10jenkins-bot: ve.ui.Icons: Remove styles for unused classes .oo-ui-ltr and .oo-ui-rtl [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/267062 (owner: 10Bartosz Dziewoński) [17:16:17] (03CR) 10Esanders: [C: 032] Update VE core submodule to master (9704a43) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/267273 (owner: 10Jforrester) [17:16:45] James_F, what's wrong with beta labs? [17:20:19] edsanders: I don't know. What's wrong with the Beta Cluster? [17:20:19] (I'm in a meeting.) [17:20:31] 503s when you load VE [17:29:10] 10VisualEditor, 6Editing-Department, 10MobileFrontend, 7Mobile, 5Patch-For-Review: Enable editing for mobile users without JavaScript and kill Special:MobileEditor code in MobileFrontend - https://phabricator.wikimedia.org/T125174#1981986 (10Sumit) Regarding **Add editor ResourceLoader module "skins.mine... [17:33:57] 10VisualEditor, 10VisualEditor-MediaWiki-Media: Provide a link to the File: page for an image - https://phabricator.wikimedia.org/T125227#1982014 (10Whatamidoing-WMF) 3NEW [17:34:15] edsanders: Oh, hmm. RB/Parsoid down maybe? [17:34:24] probably [17:36:20] who do we kick? [17:36:36] I'll ask in -releng [17:38:40] (03Merged) 10jenkins-bot: Update VE core submodule to master (9704a43) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/267273 (owner: 10Jforrester) [17:43:35] (03PS1) 10Esanders: Sanitization: Add option to perform per-node sanitization [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/267286 [17:46:16] (03PS1) 10Esanders: MWTable: use new sanitization method [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/267287 (https://phabricator.wikimedia.org/T97462) [17:46:41] edsanders: Only needed on MWTable? [17:47:12] edsanders: Don't we want to stop sanitisation on VE-VE SA stuff? [17:47:28] the extra class names are a ClassAttributeNode feature [17:47:43] Which isn't used, right. [17:47:49] the problem was unsanitization: adding wikitable [17:48:00] doesn't happen in core of course [17:49:11] * James_F nods. [17:49:29] Until we start hacking CSS defaults into core. ;-) [17:49:37] (03CR) 10Jforrester: [C: 032] Sanitization: Add option to perform per-node sanitization [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/267286 (owner: 10Esanders) [17:51:07] 10VisualEditor, 10VisualEditor-CopyPaste, 10VisualEditor-Tables, 5Patch-For-Review: Clean up mess from copy-pasted tables - https://phabricator.wikimedia.org/T97462#1982079 (10Esanders) I could reproduce 'id' preservation, but col/rowspan=1 is still and issue after this fix. Unfortunately we don't yet have... [17:52:13] 10VisualEditor, 3Liaisons-January-2016: Review https://www.mediawiki.org/wiki/VisualEditor/Rollouts - https://phabricator.wikimedia.org/T125210#1982082 (10Elitre) [17:52:47] (03CR) 10jenkins-bot: [V: 04-1] MWTable: use new sanitization method [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/267287 (https://phabricator.wikimedia.org/T97462) (owner: 10Esanders) [17:54:40] 10VisualEditor, 10VisualEditor-ContentLanguage, 10Wikimedia-Site-Requests, 5Patch-For-Review: Make VisualEditor work by default in some "easier" phase 6 Wikipedias - https://phabricator.wikimedia.org/T116523#1982093 (10Elitre) [17:56:35] 10VisualEditor, 10VisualEditor-DataModel, 7Technical-Debt: Move some sanitization rules to the converter - https://phabricator.wikimedia.org/T125229#1982098 (10Esanders) 3NEW [17:57:01] (03Merged) 10jenkins-bot: Sanitization: Add option to perform per-node sanitization [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/267286 (owner: 10Esanders) [17:58:45] (03PS2) 10Esanders: MWTable: use new sanitization method [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/267287 (https://phabricator.wikimedia.org/T97462) [18:06:20] (03CR) 10jenkins-bot: [V: 04-1] MWTable: use new sanitization method [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/267287 (https://phabricator.wikimedia.org/T97462) (owner: 10Esanders) [18:06:24] 10VisualEditor, 10VisualEditor-Tables, 7Design: Make it easier to select all or nearly all of the contents of a single cell in a table, without selecting the table cell - https://phabricator.wikimedia.org/T116341#1982128 (10Esanders) 5Open>3Resolved a:3Esanders CTRL+A or selecting WFM [18:07:32] (03CR) 10Divec: Rewrite ve.BranchNode#getNodeFromOffset to be non-recursive (031 comment) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/267006 (owner: 10Divec) [18:14:21] 10VisualEditor, 10ContentTranslation-Deployments, 10ContentTranslation-cxserver, 10Parsoid, and 4 others: Decom parsoid-lb.eqiad.wikimedia.org entrypoint - https://phabricator.wikimedia.org/T110474#1982145 (10ssastry) [18:14:22] (03PS3) 10Jforrester: MWTable: use new sanitization method [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/267287 (https://phabricator.wikimedia.org/T97462) (owner: 10Esanders) [18:14:24] (03PS1) 10Jforrester: Update VE core submodule to master (a0308f0) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/267290 [18:17:17] 10VisualEditor: Language identification for a code block is case sensitive: some blocks disappear while editing with VE - https://phabricator.wikimedia.org/T125231#1982148 (10Trizek-WMF) 3NEW [18:20:28] (03CR) 10jenkins-bot: [V: 04-1] MWTable: use new sanitization method [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/267287 (https://phabricator.wikimedia.org/T97462) (owner: 10Esanders) [18:26:59] 10VisualEditor, 6Editing-Department, 10MobileFrontend, 7Mobile, 5Patch-For-Review: Enable editing for mobile users without JavaScript and kill Special:MobileEditor code in MobileFrontend - https://phabricator.wikimedia.org/T125174#1982169 (10Jdlrobson) >>! In T125174#1981986, @Sumit wrote: > Regarding **... [18:27:01] 10VisualEditor, 10Wikimedia-Site-Requests, 7user-notice: Enable VisualEditor by default for all users of all "phase 7" Wikipedias - https://phabricator.wikimedia.org/T93388#1982171 (10Elitre) [18:28:51] (03PS4) 10Jforrester: MWTable: use new sanitization method [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/267287 (https://phabricator.wikimedia.org/T97462) (owner: 10Esanders) [18:31:29] 10VisualEditor: Enable VisualEditor by default for all users of this random group of Phase 6 languages - https://phabricator.wikimedia.org/T125234#1982200 (10Elitre) 3NEW [18:32:15] 10VisualEditor: Enable VisualEditor by default for all users of this random group of Phase 6 languages - https://phabricator.wikimedia.org/T125234#1982212 (10Elitre) [18:32:17] 10VisualEditor, 10Wikimedia-Site-Requests, 7user-notice: Enable VisualEditor by default for all users of all "phase 6" Wikipedias - https://phabricator.wikimedia.org/T93387#1982211 (10Elitre) [18:32:53] 10VisualEditor, 10Wikimedia-Site-Requests, 7user-notice: Enable VisualEditor by default for all users of all "phase 6" Wikipedias - https://phabricator.wikimedia.org/T93387#1982223 (10Elitre) [18:32:57] 10Cite: LDR not emitting error message when two named references are defined differently - https://phabricator.wikimedia.org/T125074#1982229 (10Izno) [18:32:59] 10Cite: Multiple problems with refs inside ... blocks - https://phabricator.wikimedia.org/T24635#1982228 (10Izno) [18:33:20] Elitre: ε> [18:33:29] 10VisualEditor: Make VisualEditor work by default in this random group of Phase 6 languages - https://phabricator.wikimedia.org/T125234#1982230 (10Elitre) [18:34:31] (03PS1) 10Divec: WIP: Fix node and offset calculations [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/267292 (https://phabricator.wikimedia.org/T124318) [18:35:05] (03CR) 10Jforrester: [C: 032] MWTable: use new sanitization method [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/267287 (https://phabricator.wikimedia.org/T97462) (owner: 10Esanders) [18:35:24] edsanders: +2 on https://gerrit.wikimedia.org/r/#/c/267290/1 please. [18:36:47] (03CR) 10Esanders: [C: 032] Update VE core submodule to master (a0308f0) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/267290 (owner: 10Jforrester) [18:37:41] 10VisualEditor, 10VisualEditor-CopyPaste, 10VisualEditor-Tables: Clean up mess from copy-pasted tables - https://phabricator.wikimedia.org/T97462#1982257 (10Jdforrester-WMF) 5Open>3Resolved a:3Esanders [18:37:58] 10VisualEditor, 10VisualEditor-CopyPaste, 10VisualEditor-DataModel, 10VisualEditor-Tables: [Regression pre-wmf.12] Copying a plain table to another VE instance converts it to a wikitable - https://phabricator.wikimedia.org/T125220#1982265 (10Jdforrester-WMF) 5Open>3Resolved [18:39:05] (03CR) 10jenkins-bot: [V: 04-1] WIP: Fix node and offset calculations [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/267292 (https://phabricator.wikimedia.org/T124318) (owner: 10Divec) [18:40:21] 10VisualEditor, 10VisualEditor-Tables, 7Browser-Support-Firefox: Can't edit table cell contents in Firefox on Ubuntu - https://phabricator.wikimedia.org/T108712#1982274 (10Esanders) 5Open>3Resolved a:3Esanders Re-open if still reproduceable [18:41:37] 10VisualEditor, 10VisualEditor-MediaWiki, 6Community-Liaison, 10MediaWiki-extensions-TemplateData, and 3 others: Check documentation for the TemplateData editor for completeness, accuracy, and ease of understanding by adding TemplateData to templates on Wik... - https://phabricator.wikimedia.org/T117499#1982281 [18:41:40] (03CR) 10Divec: "In the long run it would be better to consider systematically the different node configurations getNodeAndOffset should handle, and the "b" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/267292 (https://phabricator.wikimedia.org/T124318) (owner: 10Divec) [18:42:08] 10VisualEditor, 10VisualEditor-Tables: Table backgrounds and borders don't always display correctly - https://phabricator.wikimedia.org/T85639#1982284 (10Esanders) 5Open>3Resolved a:3Esanders This is by design. VE is not WYSIWYG and in this case I think collapsing borders makes editing the table easier. [18:44:44] (03Merged) 10jenkins-bot: Update VE core submodule to master (a0308f0) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/267290 (owner: 10Jforrester) [18:46:06] (03Merged) 10jenkins-bot: MWTable: use new sanitization method [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/267287 (https://phabricator.wikimedia.org/T97462) (owner: 10Esanders) [18:46:08] 10VisualEditor, 10VisualEditor-Tables: Do not allow editors to add empty spaces or blank lines in table cells - https://phabricator.wikimedia.org/T107076#1982296 (10Esanders) [18:46:12] 10VisualEditor, 10VisualEditor-CopyPaste, 10VisualEditor-Tables: Pasting a table from LibreOffice creates a lot of whitespace and blanklines in the wikitext - https://phabricator.wikimedia.org/T102906#1982298 (10Esanders) [18:47:00] 10VisualEditor, 10VisualEditor-Tables: Make it possible to edit a table cell's data-sort-value attribute - https://phabricator.wikimedia.org/T99890#1982305 (10Esanders) [18:47:02] 10VisualEditor, 10VisualEditor-MediaWiki, 10VisualEditor-Tables: Support sortable columns in tables - https://phabricator.wikimedia.org/T95189#1982304 (10Esanders) [18:47:39] 10VisualEditor, 10VisualEditor-ContentEditable, 10VisualEditor-Tables: An image inserted to table cell, break the table - https://phabricator.wikimedia.org/T86501#1982313 (10Esanders) 5Open>3Resolved a:3Esanders reopen if reproduceable [18:48:30] 10VisualEditor, 10VisualEditor-ContentEditable, 7Epic: Tab/Shift-Tab behaviour in contexts other than list indent/outdent (e.g. tables) - https://phabricator.wikimedia.org/T72665#1982318 (10Esanders) [18:51:28] 10VisualEditor, 10VisualEditor-Tables: Table: text in Bullet lists in Caption should not be centered - https://phabricator.wikimedia.org/T86725#1982330 (10Esanders) 5Open>3Resolved a:3Esanders Looks the same to me. The HTML was basically the same so it must have been a browser rendering bug with CE, so u... [18:55:27] 10VisualEditor, 10VisualEditor-Tables, 7Browser-Support-Internet-Explorer: Cannot select multiple cells in tables Internet Explorer 11 - https://phabricator.wikimedia.org/T85418#1982343 (10Esanders) 5Open>3Resolved a:3Esanders Tested in IE10/11, probably fixed in the last year. [19:10:37] 10VisualEditor, 10VisualEditor-Tables, 7Browser-Support-Internet-Explorer: Cannot select multiple cells in tables Internet Explorer 11 - https://phabricator.wikimedia.org/T85418#1982422 (10Jdforrester-WMF) [19:13:15] 10VisualEditor, 10VisualEditor-CopyPaste, 10VisualEditor-Tables, 5WMF-deploy-2016-02-02_(1.27.0-wmf.12): Clean up mess from copy-pasted tables - https://phabricator.wikimedia.org/T97462#1982453 (10Jdforrester-WMF) [19:27:04] (03PS1) 10Esanders: Move cell mergeability test to Selection and improve [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/267303 (https://phabricator.wikimedia.org/T75222) [19:28:23] 10VisualEditor, 10VisualEditor-CopyPaste, 10VisualEditor-Tables, 5WMF-deploy-2016-02-02_(1.27.0-wmf.12): Pasting a table from LibreOffice creates a lot of whitespace and blanklines in the wikitext - https://phabricator.wikimedia.org/T102906#1982499 (10Jdforrester-WMF) [19:29:00] 10VisualEditor, 10VisualEditor-Tables: Make it possible to edit a table cell's data-sort-value attribute - https://phabricator.wikimedia.org/T99890#1982503 (10Jdforrester-WMF) I'm not sure this should block initial implementation of {T95189}; it's pretty rare to need to over-ride this value. [19:29:51] 10VisualEditor, 10VisualEditor-ContentEditable, 10VisualEditor-Tables, 7Epic: Tab/Shift-Tab behaviour in contexts other than list indent/outdent (e.g. tables) - https://phabricator.wikimedia.org/T72665#1982507 (10Jdforrester-WMF) Not fixed. {T119546} still exists. [19:30:08] 10VisualEditor, 10VisualEditor-Tables: Table: text in Bullet lists in Caption should not be centered - https://phabricator.wikimedia.org/T86725#1982516 (10Jdforrester-WMF) [19:30:28] (03CR) 10jenkins-bot: [V: 04-1] Move cell mergeability test to Selection and improve [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/267303 (https://phabricator.wikimedia.org/T75222) (owner: 10Esanders) [19:35:06] (03PS2) 10Jforrester: Move table cell mergeability test to Selection and improve [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/267303 (https://phabricator.wikimedia.org/T75222) (owner: 10Esanders) [19:36:13] (03CR) 10Jforrester: [C: 032] "It'd be nice to let users edit table sections at some point, but this suffices." [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/267303 (https://phabricator.wikimedia.org/T75222) (owner: 10Esanders) [19:39:06] 10VisualEditor, 10VisualEditor-EditingTools, 10VisualEditor-Tables, 5WMF-deploy-2016-02-02_(1.27.0-wmf.12): Stop users being able to merge cells across table sections, as that's invalid HTML - https://phabricator.wikimedia.org/T75222#1982565 (10Jdforrester-WMF) 5Open>3Resolved a:3Esanders [19:43:52] (03Merged) 10jenkins-bot: Move table cell mergeability test to Selection and improve [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/267303 (https://phabricator.wikimedia.org/T75222) (owner: 10Esanders) [19:47:38] (03PS1) 10Esanders: ve.Node.findParent: Shortcut for specific traverseUpstream [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/267310 [19:50:40] (03PS2) 10Esanders: ve.Node.findParent: Shortcut for specific traverseUpstream [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/267310 [19:51:43] 10Cite, 10MobileFrontend, 3Reading-Web-Sprint-65-g: Spike: Can we store a JSON blob of references data in ParserOutput - https://phabricator.wikimedia.org/T125134#1982587 (10Cenarium) >>! In T125134#1981197, @phuedx wrote: > That'd be ideal. When are you planning on starting this work? Is this something that... [19:56:45] (03CR) 10jenkins-bot: [V: 04-1] ve.Node.findParent: Shortcut for specific traverseUpstream [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/267310 (owner: 10Esanders) [20:24:46] 10VisualEditor, 10VisualEditor-MediaWiki, 6Community-Liaison, 10MediaWiki-extensions-TemplateData, and 3 others: Check documentation for the TemplateData editor for completeness, accuracy, and ease of understanding by adding TemplateData to templates on Wik... - https://phabricator.wikimedia.org/T117499#1982659 [20:32:33] 10VisualEditor: Source and VE edit tabs have the word appearing next to them - https://phabricator.wikimedia.org/T125249#1982668 (10Wittylama) 3NEW [21:02:48] (03CR) 10Esanders: [C: 032] "Ran the tests 10 times on each branch and couldn't see much performance though." [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/267006 (owner: 10Divec) [21:11:16] (03Merged) 10jenkins-bot: Rewrite ve.BranchNode#getNodeFromOffset to be non-recursive [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/267006 (owner: 10Divec) [21:11:50] 10Cite, 10MediaWiki-API, 10MobileFrontend, 5Patch-For-Review, 7Tracking: Should be possible to access references and notes for a given page via API - https://phabricator.wikimedia.org/T123290#1982789 (10Jdlrobson) [21:12:31] 10Cite, 10MobileFrontend, 3Reading-Web-Sprint-65-g: Spike: Can we store a JSON blob of references data in ParserOutput - https://phabricator.wikimedia.org/T125134#1982791 (10Jdlrobson) Thanks for everyone's answers! @Cenarium I'll assign you to T123290 and we'll help as best we can next week! [21:12:39] 10Cite, 10MediaWiki-API, 10MobileFrontend, 5Patch-For-Review, 7Tracking: Should be possible to access references and notes for a given page via API - https://phabricator.wikimedia.org/T123290#1925425 (10Jdlrobson) [21:12:41] 10Cite, 10MobileFrontend, 3Reading-Web-Sprint-65-g: Spike: Can we store a JSON blob of references data in ParserOutput - https://phabricator.wikimedia.org/T125134#1982793 (10Jdlrobson) 5Open>3Resolved The answer seems to be YES. [21:13:01] 10Cite, 10MediaWiki-API, 10MobileFrontend, 3Reading-Web-Sprint-65-g, 7Tracking: Should be possible to access references and notes for a given page via API - https://phabricator.wikimedia.org/T123290#1982796 (10Jdlrobson) a:5phuedx>3Cenarium [21:16:17] (03PS3) 10Esanders: ve.Node.findParent: Shortcut for specific traverseUpstream [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/267310 [21:30:39] 10VisualEditor: VisualEditor has difficulty replacing a bare URL with different link text - https://phabricator.wikimedia.org/T124305#1982827 (10Strainu) I could only partially confirm this on Wikipedia. As long as you keep the selection within the link, the replacement works just fine. However, if you drag a bi... [21:30:47] 10VisualEditor: VisualEditor has difficulty replacing a bare URL with different link text - https://phabricator.wikimedia.org/T124305#1982828 (10Strainu) I could only partially confirm this on Wikipedia. As long as you keep the selection within the link, the replacement works just fine. However, if you drag a bi... [21:42:25] (03PS1) 10Esanders: Use mouse position to place selection after double clicking a table cell [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/267359 (https://phabricator.wikimedia.org/T107446) [22:12:39] (03CR) 10Jforrester: [C: 032] "Neat." [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/267359 (https://phabricator.wikimedia.org/T107446) (owner: 10Esanders) [22:20:01] (03Merged) 10jenkins-bot: Use mouse position to place selection after double clicking a table cell [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/267359 (https://phabricator.wikimedia.org/T107446) (owner: 10Esanders) [22:36:44] (03CR) 10Jforrester: [C: 032] ve.Node.findParent: Shortcut for specific traverseUpstream [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/267310 (owner: 10Esanders) [22:42:27] (03Merged) 10jenkins-bot: ve.Node.findParent: Shortcut for specific traverseUpstream [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/267310 (owner: 10Esanders) [22:56:56] 10VisualEditor, 10ContentTranslation-cxserver, 10Parsoid, 10RESTBase, and 2 others: Remove user name and edit comment from html - https://phabricator.wikimedia.org/T125266#1983016 (10GWicke) 3NEW [22:57:08] 10VisualEditor, 10ContentTranslation-cxserver, 10Parsoid, 10RESTBase, and 2 others: Remove user name and edit comment from html - https://phabricator.wikimedia.org/T125266#1983016 (10GWicke) p:5Normal>3High [22:57:27] 10VisualEditor, 10ContentTranslation-cxserver, 10Parsoid, 10RESTBase, and 2 others: Remove user name and edit comment from html - https://phabricator.wikimedia.org/T125266#1983016 (10GWicke) [22:58:07] (03PS1) 10Jforrester: Update VE core submodule to master (c5bf879) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/267386 [22:58:44] 10VisualEditor, 10ContentTranslation-cxserver, 10Parsoid, 10RESTBase, and 2 others: Remove user name and edit comment from html - https://phabricator.wikimedia.org/T125266#1983016 (10GWicke) [22:58:59] (03PS7) 10Alex Monk: Localise names of types in HTML rendering [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/263918 (https://phabricator.wikimedia.org/T61745) [22:59:51] 10VisualEditor, 10ContentTranslation-cxserver, 10Parsoid, 10RESTBase, and 2 others: Remove user name and edit comment from html - https://phabricator.wikimedia.org/T125266#1983046 (10GWicke) I raised the priority, as this is the remaining blocker for T120409. [23:10:31] 10VisualEditor: Source and VE edit tabs have the word appearing next to them - https://phabricator.wikimedia.org/T125249#1983065 (10Krenair) does it still show up if you try the page with uselang=qqx and then go back to normal? [23:10:44] 10VisualEditor, 10VisualEditor-MediaWiki: Source and VE edit tabs have the word appearing next to them - https://phabricator.wikimedia.org/T125249#1983066 (10Krenair) [23:44:29] 10VisualEditor, 10VisualEditor-MediaWiki: Source and VE edit tabs have the word appearing next to them - https://phabricator.wikimedia.org/T125249#1983109 (10Wittylama) That indeed fixed it. Don't know how or why... Thanks to @ijon for explaining to me that the instruction meant that needed to ad...