[00:03:15] Hey there, I recently told you over this IRC chat, that my website http://wiki.vocaloid.de/ has a problem with VisualEditor, although I configured everything correctly... The DOM console gives the error "the server responded with a status of 500". Is someone able to tell me what I need to fix? [00:04:29] After James_F told me there to check the skin, I switched my skin, so that this error comes up. [00:14:40] 10VisualEditor, 10VisualEditor-EditingTools: Convert hyphens to en dashes when written in VisualEditor - https://phabricator.wikimedia.org/T76275#1984481 (10Danny_B) 5Open>3declined a:3Danny_B >>! In T76275#802670, @Jdforrester-WMF wrote: >>>! In T76275#802653, @Juandev wrote: >> Yes, I am suggesting tha... [00:49:45] nekura, I think there are other issues going on here as well [00:49:46] http://wiki.vocaloid.de/load.php?modules=oojs-ui.styles.icons&* [00:50:00] should be something in your apache logs about that [01:03:06] Krenair Well I use nginx. I opened the error.log and it seems like there is a bug. I tried fixing the permissions on my server, without success. Here is the error: [01:03:19] PHP message: PHP Fatal error: Call to a member function appendChild() on a non-object in /var/www/html/Wiki/includes/resourceloader/ResourceLoaderImage.php on line 281" while reading response header from upstream, client: 129.12.195.225, server: wiki.vocaloid.de, request: "GET /load.php?debug=false&lang=de&modules=ext.cite.style%7Cext.visualEditor.base%2Ccore%2Cdata%2CdesktopArticleTarget%2Cicons%2Clanguage%2Cmediawik [01:08:31] Sorry I missed some details: [01:10:59] http://wiki.vocaloid.de/error.txt [01:14:23] I guess this problem is caused by the """ but I do not know where this is part of the directory path.. [02:27:32] 10VisualEditor, 10VisualEditor-MediaWiki: Source and VE edit tabs have the word appearing next to them for some users on enwiki (very old cached HTML/JS?) - https://phabricator.wikimedia.org/T125249#1984546 (10Jdforrester-WMF) As the cluster's been re-re-rolled back to wmf.10 this probably has gone... [08:04:20] hi [08:04:29] any one to help me? [08:14:48] 10Cite, 6TCB-Team, 7German-Community-Wishlist, 5Patch-For-Review: Section edit preview doesn't let you preview references defined outside the section being previewed - https://phabricator.wikimedia.org/T124840#1984639 (10Cenarium) [08:14:50] 10Cite, 10MediaWiki-API, 10MobileFrontend, 5Patch-For-Review, and 2 others: Should be possible to access references and notes for a given page via API - https://phabricator.wikimedia.org/T123290#1984640 (10Cenarium) [08:19:26] 10Cite: Save references in page_props and cache - https://phabricator.wikimedia.org/T125329#1984641 (10Cenarium) 3NEW a:3Cenarium [08:22:17] 10Cite: Save references in page_props and cache - https://phabricator.wikimedia.org/T125329#1984653 (10Cenarium) [08:22:19] 10Cite, 6TCB-Team, 7German-Community-Wishlist, 5Patch-For-Review: Section edit preview doesn't let you preview references defined outside the section being previewed - https://phabricator.wikimedia.org/T124840#1984652 (10Cenarium) [08:22:29] 10Cite: Save references in page_props and cache - https://phabricator.wikimedia.org/T125329#1984641 (10Cenarium) [08:22:31] 10Cite, 10MediaWiki-API, 10MobileFrontend, 5Patch-For-Review, and 2 others: Should be possible to access references and notes for a given page via API - https://phabricator.wikimedia.org/T123290#1984654 (10Cenarium) [08:32:59] 10Cite, 10MediaWiki-API, 10MobileFrontend, 5Patch-For-Review, and 2 others: Should be possible to access references and notes for a given page via API - https://phabricator.wikimedia.org/T123290#1984659 (10Cenarium) a:5Cenarium>3phuedx Okay, I've done the internal logic for Cite, for which I've created... [11:18:02] (03PS1) 10Esanders: Rename TableContext to TableLineContext [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/267531 [11:18:04] (03PS1) 10Esanders: Introduce table and table cell context [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/267532 (https://phabricator.wikimedia.org/T75212) [11:25:07] 10VisualEditor, 10VisualEditor-EditingTools, 10VisualEditor-Tables, 5Patch-For-Review: VisualEditor: "Insert table" tool in a separate menu to the other table tools (delete/merge/caption) - https://phabricator.wikimedia.org/T75212#1984756 (10Esanders) [11:27:10] (03CR) 10jenkins-bot: [V: 04-1] Introduce table and table cell context [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/267532 (https://phabricator.wikimedia.org/T75212) (owner: 10Esanders) [13:17:52] 10VisualEditor, 10VisualEditor-MediaWiki, 10MediaWiki-extensions-TemplateData: TemplateData: Parse wikicode and/or HTML in interface text - https://phabricator.wikimedia.org/T52656#1984828 (10Agabi10) >>! In T52656#1937666, @Krenair wrote: > Well we definitely can't allow all HTML, and we probably don't want... [14:29:56] James_F, wmf10 again? [14:30:43] (03PS2) 10Esanders: Introduce table and table cell context [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/267532 (https://phabricator.wikimedia.org/T75212) [14:35:29] (03CR) 10jenkins-bot: [V: 04-1] Introduce table and table cell context [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/267532 (https://phabricator.wikimedia.org/T75212) (owner: 10Esanders) [14:45:23] (03PS3) 10Esanders: Introduce table and table cell context [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/267532 (https://phabricator.wikimedia.org/T75212) [14:47:19] (03PS1) 10Esanders: [PULL THROUGH] Files for table context [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/267537 [14:47:21] (03PS1) 10Esanders: Add controls for wikitable and sortable to table dialog [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/267538 (https://phabricator.wikimedia.org/T95189) [14:47:46] (03CR) 10jenkins-bot: [V: 04-1] [PULL THROUGH] Files for table context [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/267537 (owner: 10Esanders) [14:47:57] (03CR) 10jenkins-bot: [V: 04-1] Add controls for wikitable and sortable to table dialog [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/267538 (https://phabricator.wikimedia.org/T95189) (owner: 10Esanders) [14:51:47] (03CR) 10jenkins-bot: [V: 04-1] Introduce table and table cell context [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/267532 (https://phabricator.wikimedia.org/T75212) (owner: 10Esanders) [15:04:06] 10VisualEditor, 10VisualEditor-Tables: Highlighting table cells differ before and after entering VEedit - https://phabricator.wikimedia.org/T86164#1984908 (10Esanders) 5Open>3Invalid a:3Esanders This is by design and very deliberate. We have no plans to change VE selection of cells, nor override the syst... [15:12:45] 10VisualEditor, 10VisualEditor-ContentEditable, 7Epic: Tab/Shift-Tab behaviour in contexts other than list indent/outdent (e.g. tables) - https://phabricator.wikimedia.org/T72665#755967 (10Esanders) [15:13:25] 10VisualEditor, 10VisualEditor-ContentEditable, 7Epic: Tab/Shift-Tab behaviour in contexts other than list indent/outdent (e.g. tables) - https://phabricator.wikimedia.org/T72665#755967 (10Esanders) Fine, but let's leave the tracker off the tables board. [15:16:36] 10VisualEditor, 10VisualEditor-CopyPaste, 10VisualEditor-Tables: Firefox allows pasting of unwrapped table cells, comes out as joined plain text in VE - https://phabricator.wikimedia.org/T101478#1984925 (10Esanders) [15:17:50] 10VisualEditor, 10VisualEditor-CopyPaste, 10VisualEditor-Tables: Firefox allows pasting of unwrapped table cells, comes out as joined plain text in VE - https://phabricator.wikimedia.org/T101478#1339952 (10Esanders) Actually the expected behaviour is to paste a table consisting of just that row, and Chrome d... [18:15:15] (03PS4) 10Esanders: Introduce table and table cell context [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/267532 (https://phabricator.wikimedia.org/T75212) [18:20:31] (03CR) 10jenkins-bot: [V: 04-1] Introduce table and table cell context [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/267532 (https://phabricator.wikimedia.org/T75212) (owner: 10Esanders) [18:27:18] (03PS1) 10Alex Monk: Re-add null appendix tab messages to extension.json [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/267551 (https://phabricator.wikimedia.org/T125249) [18:27:49] 10VisualEditor, 10VisualEditor-MediaWiki, 5Patch-For-Review: Source and VE edit tabs have the word appearing next to them for some users on enwiki (very old cached HTML/JS?) - https://phabricator.wikimedia.org/T125249#1985127 (10Krenair) a:3Krenair [18:29:03] (03PS1) 10Alex Monk: Re-add null appendix tab messages to extension.json [extensions/VisualEditor] (wmf/1.27.0-wmf.11) - 10https://gerrit.wikimedia.org/r/267552 (https://phabricator.wikimedia.org/T125249) [20:19:16] (03PS5) 10Esanders: Introduce table and table cell context [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/267532 (https://phabricator.wikimedia.org/T75212) [20:19:18] (03PS2) 10Esanders: Rename TableContext to TableLineContext [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/267531 [20:24:19] (03CR) 10jenkins-bot: [V: 04-1] Introduce table and table cell context [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/267532 (https://phabricator.wikimedia.org/T75212) (owner: 10Esanders) [21:05:32] 10VisualEditor, 10VisualEditor-ContentEditable, 5Patch-For-Review: getNodeAndOffset has incorrect returns if given the offset after the close of a non-focusable node - https://phabricator.wikimedia.org/T124318#1985218 (10dchan) Change 267292 shows one way to fix this getNodeAndOffset bug. But would be cleane... [22:07:04] (03PS6) 10Esanders: Introduce table and table cell context [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/267532 (https://phabricator.wikimedia.org/T75212) [22:08:04] 10Cite, 6TCB-Team, 7German-Community-Wishlist, 5WMF-deploy-2016-02-02_(1.27.0-wmf.12), 7user-notice: Edit preview doesn't let you preview cite.php footnotes. - https://phabricator.wikimedia.org/T7984#1985313 (10Cenarium) a:3Cenarium [22:14:25] (03CR) 10jenkins-bot: [V: 04-1] Introduce table and table cell context [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/267532 (https://phabricator.wikimedia.org/T75212) (owner: 10Esanders) [22:20:06] Hello! I'm writing a small gadget for VE, which should insert a template. I need need to pass the selected text as a parameter to that template. Is it possible? [22:21:50] Should I perform this operation at linear mode level, e.g. with surfaceModel.getFragment().annotateContent(...) ? [22:26:23] at the other side, templates is something that should be operated at the wikitext level [22:27:00] so I am a bit confused [22:27:47] TwisteR: yes. you'll probably want to insertContent() [22:29:18] MatmaRex: and how to retrieve the selected text as a string suitable for passing it as template parameter? [22:29:21] i'm trying to find out what the format is [22:31:43] TwisteR: probably something like this: https://github.com/wikimedia/mediawiki-extensions-VisualEditor/blob/master/modules/ve-mw/tests/dm/ve.dm.mwExample.js#L132-L179 [22:32:36] yes, I'm inserting template like this [22:32:51] but in your example, parametera are hardcoded [22:32:57] parameters* [22:33:28] params: { 1: {wt: 'Hello, world!'} [22:34:56] and I need something like params: { 1: {wt: surfaceModel.getSelection().getRange()} [22:35:01] right [22:35:11] yeah, so do that? i'm experimenting right now and that seems to work [22:35:23] yes, it does work [22:36:07] but my gadget is about selected text highlighting (with different colors) [22:36:50] so, I need to pass selected text to my highlight template as a first parameter (of type 'string') [22:38:25] I was not able to find a sample code that perform similar action. Only editing at linear level with annotateContent() (like marking bold/italic) [22:38:26] TwisteR: You'll need to replace the content, not just insert. [22:38:42] TwisteR: Text annotations are fundamentally different from content nodes, yes. [22:38:48] yes, I already know how to replace [22:39:00] TwisteR: See the ListAction code. [22:39:01] thanks to find/replace gadget [22:39:58] James_F: so there is no easy way to get the selected text at wikitext level? [22:40:14] TwisteR: No; VE doesn't know anything about wikitext. [22:40:26] TwisteR: You have to consider what DOM operation you want to achieve. [22:40:28] yes, that's makes sense [22:41:02] (OK, VE-MW's template stuff knows some stuff about how the wikitext of templates works, but we're likely to change that soon.) [22:41:50] (03PS1) 10Jforrester: Follow-up 1b3516c6: Fix build for added language 'cdo' [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/267614 [22:42:53] MatmaRex: As you're here can I beg you to +2 https://gerrit.wikimedia.org/r/#/c/267614/ to un-break master? :-) [22:43:28] anytime [22:43:43] my original idea was to implement a text highlighter template with 3 parameters: 1. text to highlight 2. color 3. optional popup message (for, e.g. proofreading comments) [22:43:49] (03CR) 10Bartosz Dziewoński: [C: 032] Follow-up 1b3516c6: Fix build for added language 'cdo' [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/267614 (owner: 10Jforrester) [22:43:59] (03CR) 10Jforrester: [C: 032] "Not sure how long we should leave it around; will create the revert as F/U." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/267551 (https://phabricator.wikimedia.org/T125249) (owner: 10Alex Monk) [22:45:13] TwisteR: if you wanted the "highlighted" text to stay editable in the editor (and not inside a popup dialog/inspector), that's going to require some more coding work :( templates generally work as nodes, not annotations. [22:45:53] it's probably possible to implement an annotation that becomes a template when you save the page, but it's probably not trivial. [22:46:02] Not "some work". [22:46:20] It's going to be epic. [22:46:21] no, it is fine if the text wouldn't be editable [22:46:37] There's no DOM-level typing of individual templates. [22:46:45] (03PS2) 10Jforrester: DesktopContext: Float the context when it goes beyond the viewport [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/267446 (https://phabricator.wikimedia.org/T51922) (owner: 10Esanders) [22:47:24] James_F: if it was limited to a single template with a single parameter… probably a couple evenings' worth of work? i haven't tried though :D but as a general thing, definitely yes. [22:47:41] TwisteR: hmm, which part are you having problems with? [22:48:13] MatmaRex: Converter doesn't let you match that way. I guess you could extend it quite a lot, but I'm not sure the speed loss would be something we could accept for the use case. [22:48:14] James_F: hmm, i guess turning templates from existing wikitext into annotations would be the hard part. [22:48:19] Yeah. [22:48:22] yeah. i just realized that [22:48:31] I think it is easier to wrap the text with some spans or divs, rather than to mess with templates, right? [22:48:44] The "do something special on save" bit is easier, I agree. [22:48:44] Though again, not something we're set up for right now. [22:48:44] TwisteR: most likely. the "language" annotation works this way [22:49:05] TwisteR: Much, yes. [22:50:10] and will I be able to make it via insertContent()? or ListAction? [22:50:28] unsure what is ListAction about right now [22:51:08] (03CR) 10jenkins-bot: [V: 04-1] DesktopContext: Float the context when it goes beyond the viewport [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/267446 (https://phabricator.wikimedia.org/T51922) (owner: 10Esanders) [22:51:50] TwisteR: When you have a selection of content and press one of the list buttons it wraps it in
  • …
. [22:52:10] TwisteR: So it's an example of code that does more complex transforms on content than just "replace" [22:52:46] right, thanks! [22:53:01] (03Merged) 10jenkins-bot: Follow-up 1b3516c6: Fix build for added language 'cdo' [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/267614 (owner: 10Jforrester) [22:53:03] (03Merged) 10jenkins-bot: Re-add null appendix tab messages to extension.json [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/267551 (https://phabricator.wikimedia.org/T125249) (owner: 10Alex Monk) [22:53:49] (03PS1) 10Jforrester: Revert "Re-add null appendix tab messages to extension.json" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/267616 [22:53:57] (03CR) 10Jforrester: [C: 04-1] "For now…" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/267616 (owner: 10Jforrester) [22:54:24] I will try a simpler way: surfaceModel.getFragment().annotateContent( 'set', 'textStyle/bold' ); [22:54:28] (03PS2) 10Jforrester: Re-add null appendix tab messages to extension.json [extensions/VisualEditor] (wmf/1.27.0-wmf.11) - 10https://gerrit.wikimedia.org/r/267552 (https://phabricator.wikimedia.org/T125249) (owner: 10Alex Monk) [22:54:49] (03CR) 10Jforrester: [C: 031] Re-add null appendix tab messages to extension.json [extensions/VisualEditor] (wmf/1.27.0-wmf.11) - 10https://gerrit.wikimedia.org/r/267552 (https://phabricator.wikimedia.org/T125249) (owner: 10Alex Monk) [22:55:55] and then - ve.api.registerAnnotation() [22:56:23] with my bells and whistles [22:56:25] :) [22:56:48] (03PS3) 10Jforrester: DesktopContext: Float the context when it goes beyond the viewport [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/267446 (https://phabricator.wikimedia.org/T51922) (owner: 10Esanders) [22:58:54] TwisteR: Good luck! [22:59:17] thanks! [22:59:38] James_F, I guess I can put the wmf.11 backport up for swat tomorrow [22:59:42] assuming that's going ahead [23:00:05] Krenair: Yeah. Who knows at this point [23:00:36] if it's not I'll try to get it out some time before wmf.11 goes live again [23:01:18] surprise deployment, etc. [23:01:33] (03CR) 10Jforrester: [C: 04-1] "If there's not enough room for the DesktopContext, previously it would show as much of the context as possible; now it doesn't show unless" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/267446 (https://phabricator.wikimedia.org/T51922) (owner: 10Esanders) [23:01:46] Krenair: Maybe we should do it now? wmf.11 isn't anywhere… [23:03:35] well [23:03:46] since it's not a live branch, I guess now is as good as later [23:04:09] (otherwise I'd avoid it at weekends) [23:04:23] Krenair: Ask a third party maybe first? :-) [23:04:23] (03CR) 10Alex Monk: [C: 032] Re-add null appendix tab messages to extension.json [extensions/VisualEditor] (wmf/1.27.0-wmf.11) - 10https://gerrit.wikimedia.org/r/267552 (https://phabricator.wikimedia.org/T125249) (owner: 10Alex Monk) [23:04:40] (03PS3) 10Jforrester: Rename TableContext to TableLineContext [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/267531 (owner: 10Esanders) [23:04:40] uh [23:04:45] (03CR) 10Jforrester: [C: 032] Rename TableContext to TableLineContext [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/267531 (owner: 10Esanders) [23:04:48] I pressed submit before seeing that suggestion [23:04:49] :D [23:04:58] Krenair: Before merging the core patch, that is. [23:05:04] well, yeah [23:05:07] Krenair: VE doesn't auto-merge into MW. ;_) [23:05:33] (03PS7) 10Jforrester: Introduce table and table cell context [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/267532 (https://phabricator.wikimedia.org/T75212) (owner: 10Esanders) [23:07:06] I might ask Bryan, since he did the rollback... it's not clear yet what the process to get back to wmf.11 will be [23:07:15] and then there's the potential complication of the extra non-sessionmanager wmf.11 branch [23:07:53] * James_F nods. [23:12:36] (03Merged) 10jenkins-bot: Re-add null appendix tab messages to extension.json [extensions/VisualEditor] (wmf/1.27.0-wmf.11) - 10https://gerrit.wikimedia.org/r/267552 (https://phabricator.wikimedia.org/T125249) (owner: 10Alex Monk) [23:16:01] (03CR) 10Jforrester: [C: 04-1] "This looks great. One minor bug, one comment, one suggestion:" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/267532 (https://phabricator.wikimedia.org/T75212) (owner: 10Esanders) [23:33:54] * Krenair grumbles [23:34:06] git corruption issues appear to be back [23:34:39] Oh dear. [23:38:35] 10VisualEditor, 6Research-and-Data: Add support for hashtags (URL parameter -> edit summary) - https://phabricator.wikimedia.org/T123529#1985421 (10mahmoud) Hey all! Glad to see this discussion made some good progress without me, so thanks to everyone for getting the ball rolling. I just wanted to chime in an... [23:52:09] Hello, I have a similiar problem like many other people, where the edit tab of the VE extension creates the error: "parsoidserver-http-error: (curl error: 7)". My setup is identical to this one: https://www.mediawiki.org/wiki/Topic:Su2mdhksx4rz6wi6 [23:52:42] This is my website causing the popup message: http://wiki.vocaloid.de/Hauptseite [23:53:16] CURL error code 7 (CURLE_COULDNT_CONNECT) [23:54:22] suggests you have not configured VE to point to parsoid correctly [23:56:25] Krenair, I did. I put the following code into my LocalSettings.php: [23:56:26] $wgVirtualRestConfig['modules']['parsoid'] = array( 'url' => 'http://127.0.0.1:8142', 'domain' => 'localhost', 'prefix' => 'localhost' ); [23:56:39] run `curl http://127.0.0.1:8142` [23:56:43] As well as this one: $wgVisualEditorParsoidURL = 'http://localhost:8142'; [23:57:29] Seems like the connection is refused.. weird.. [23:57:42] when you run curl from the cli? [23:58:41] Yes, using PuttY I get the message: "curl: (7) Failed to connect to 127.0.0.1 port 8142: Connection refused" [23:59:18] what port is parsoid listening on?