[00:32:40] 10VisualEditor, 10ContentTranslation-Deployments, 10ContentTranslation-cxserver, 10Parsoid, and 4 others: Decom parsoid-lb.eqiad.wikimedia.org entrypoint - https://phabricator.wikimedia.org/T110474#1988453 (10mobrovac) [01:19:35] 10Cite, 10MediaWiki-API, 10MobileFrontend, 5Patch-For-Review, 7Tracking: Should be possible to access references and notes for a given page via API - https://phabricator.wikimedia.org/T123290#1988577 (10Jdlrobson) 5Open>3stalled Waiting on T125329 [02:05:52] 10VisualEditor, 10VisualEditor-MediaWiki-Templates, 10MediaWiki-extensions-TemplateData: Create dedicated input methods for "string" transclusion parameters - https://phabricator.wikimedia.org/T124917#1988667 (10Krenair) Wouldn't this just be TextInputWidget? [02:16:07] 10VisualEditor, 10VisualEditor-EditingTools, 10Parsoid: Do not insert blank s - https://phabricator.wikimedia.org/T125479#1988697 (10Whatamidoing-WMF) 3NEW [02:18:27] (03PS3) 10Krinkle: TemplateDataBlob: avoid reencoding and compressing json twice [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/266661 (owner: 10Cenarium) [02:23:57] (03PS4) 10Krinkle: TemplateDataBlob: Avoid encoding and compressing json twice [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/266661 (owner: 10Cenarium) [02:24:01] (03CR) 10Krinkle: TemplateDataBlob: Avoid encoding and compressing json twice (032 comments) [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/266661 (owner: 10Cenarium) [02:24:06] (03CR) 10Krinkle: [C: 031] TemplateDataBlob: Avoid encoding and compressing json twice [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/266661 (owner: 10Cenarium) [02:26:02] (03CR) 10jenkins-bot: [V: 04-1] TemplateDataBlob: Avoid encoding and compressing json twice [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/266661 (owner: 10Cenarium) [02:26:06] (03CR) 10Krinkle: Localise names of types in HTML rendering (031 comment) [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/263918 (https://phabricator.wikimedia.org/T61745) (owner: 10Alex Monk) [02:26:24] (03CR) 10Krinkle: [C: 04-1] Localise names of types in HTML rendering [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/263918 (https://phabricator.wikimedia.org/T61745) (owner: 10Alex Monk) [02:33:29] 10VisualEditor, 10VisualEditor-MediaWiki: Make the "Discard changes" message for bi-directional switching clearer - https://phabricator.wikimedia.org/T125481#1988753 (10Whatamidoing-WMF) 3NEW [02:35:57] James_F: Do you need/want my input on https://gerrit.wikimedia.org/r/#/c/169936/ ? [02:36:51] Krinkle: No, but https://gerrit.wikimedia.org/r/#/c/259771/ and https://gerrit.wikimedia.org/r/#/c/265879/ are getting pretty desperate. [02:36:55] 10VisualEditor, 10VisualEditor-Tables: "Delete" message is unclear, when multiple cells are selected - https://phabricator.wikimedia.org/T125482#1988764 (10Whatamidoing-WMF) 3NEW [02:40:15] 10VisualEditor, 10VisualEditor-Tables: "Delete" message is unclear, when multiple cells are selected - https://phabricator.wikimedia.org/T125482#1988776 (10Jdforrester-WMF) It says "Table [ Delete ]"… [02:41:47] 10VisualEditor, 10VisualEditor-Tables: Table doesn't display correctly after the last column has been deleted - https://phabricator.wikimedia.org/T125483#1988780 (10Whatamidoing-WMF) 3NEW [02:56:33] James_F: OK. [02:56:42] James_F: What exactly do you want from me there. [02:57:06] Krinkle: You to either +2 or say you're OK for other people so to do. [02:57:33] Krinkle: For the latter, it depends on https://gerrit.wikimedia.org/r/#/c/265878/ [02:58:01] Right [02:58:22] Krinkle: Right now we've been waiting > three weeks for the former and > a week for the latter for your review in cookie-licked form. :-( [02:58:48] I don't recall cookie licking that VE patch (first one) [02:59:06] the latter is obviously blocked on RL, which is difficult to prioritize mid-quarter. [02:59:17] But I'll do my best. [02:59:22] Probably late this week or early next week. [02:59:26] :-( [02:59:42] Thank you. [02:59:44] The first patch I'll get to first thing on Wednesday. [02:59:49] Kk. [02:59:50] I'm taking off tomorrow and going to bed now. [03:00:06] o/ [06:28:52] 10Cite: Zero-width joiner before references on Wikipedia - https://phabricator.wikimedia.org/T125480#1988901 (10TTO) p:5High>3Low [06:29:06] 10Cite: Zero-width joiner before references on Wikipedia - https://phabricator.wikimedia.org/T125480#1988711 (10TTO) This issue has been around for years, it's not suddenly high priority. [07:28:45] 10Cite: Zero-width joiner before references on Wikipedia - https://phabricator.wikimedia.org/T125480#1988973 (10Obsuser) p:5Low>3Normal [07:31:31] 10Cite: Zero-width joiner before references on Wikipedia - https://phabricator.wikimedia.org/T125480#1988978 (10Obsuser) Changed back to normal; my first post at phabricator... Don’t know all the details and politics, but hope this can be resolved. Can you tell me when do bugs/issues usually get fixed i.e. how... [08:13:49] 10Cite: Zero-width joiner before references on Wikipedia - https://phabricator.wikimedia.org/T125480#1989101 (10Obsuser) [08:16:08] 10Cite: Zero-width joiner before references on Wikipedia - https://phabricator.wikimedia.org/T125480#1989103 (10TTO) As far as I know, there are no developers actively working on Cite. That means that unfortunately, this task will join the queue of 103 other tasks in the Cite code waiting to be solved, many of w... [08:37:08] 10VisualEditor, 10VisualEditor-ContentEditable, 5Patch-For-Review: getNodeAndOffset has incorrect returns if given the offset after the close of a non-focusable node - https://phabricator.wikimedia.org/T124318#1989114 (10dchan) I've looked at this in detail, and I'm working on a cleaner rewrite on the follow... [10:17:22] who's around? edsanders , others? [10:18:58] I just wanted to understand whether the "metrics" provided at https://www.mediawiki.org/wiki/Wikimedia_Product#Editing are actually the dept's KPI, or if KPIs are available elsewhere. [10:37:07] 10Cite, 5Patch-For-Review, 3Reading-Web-Sprint-65-Game of Phones: Save references in page_props and cache - https://phabricator.wikimedia.org/T125329#1984641 (10phuedx) @Cenarium: Just FYI, #Reading-Web is tracking the progress of your patch(es) – because we're both interested and excited – so you'll likely... [11:36:51] https://gerrit.wikimedia.org/r/258206 clearly didn't work as expected. [11:41:03] what's up Elitre? [11:41:37] was this https://phabricator.wikimedia.org/T125400 ? [11:41:44] Krenair: The point of adding exceptions was that the local feedback page had to stay as the target for the tool as well. [11:41:44] Instead, the tool now points to "VisualEditor/Feedback" which is not the name of local feedback pages. [11:41:44] Can you tell me how this can be fixed? The only thing that comes into my mind is overwriting MediaWiki:Feedback-dialog-intro locally, [11:41:44] but I don't know if I should replace "$1" with the actual link to the page, and most importantly it usually takes a lot for such changes to actually go live. [11:44:22] feedback-dialog-intro is a generic message for the mediawiki.feedback system, it's not for VE specifically [11:44:44] other projects may be using it [11:45:52] Is this https://phabricator.wikimedia.org/T125400 ? [11:49:04] I have to go, back in around an hour [11:50:07] could be? thanks for the link. [11:51:05] 10VisualEditor, 10VisualEditor-MediaWiki, 10MediaWiki-General-or-Unknown, 5Patch-For-Review: Feedback tool gives wrong target for page link when it's cross-wiki - https://phabricator.wikimedia.org/T125400#1989410 (10Elitre) Is this about https://phabricator.wikimedia.org/T92661#1986528, and does this mean... [12:14:03] 10Cite: Zero-width joiner before references on Wikipedia - https://phabricator.wikimedia.org/T125480#1989462 (10Aklapper) p:5Normal>3Low [12:14:13] 10Cite: Zero-width joiner before references on Wikipedia - https://phabricator.wikimedia.org/T125480#1989467 (10Fomafix) A CSS based solution to insert a ZWJ before the refs is ```lang=css sup.reference::before { content: "\200d"; } ``` [12:27:04] 10Cite: in ordered list or unordered list closes surrounding element - https://phabricator.wikimedia.org/T27939#1989507 (10Fomafix) I guess this depends on {T104927}. [13:44:28] 10VisualEditor, 10Continuous-Integration-Infrastructure, 10Math: Math tests failing - https://phabricator.wikimedia.org/T125513#1989675 (10Physikerwelt) 3NEW [13:55:13] https://www.mediawiki.org/w/index.php?title=Topic:Sxmsghgvngnjqlba&action=history looks like a question which some of you may answer. [14:06:46] 10VisualEditor, 10Continuous-Integration-Infrastructure, 10Math: Math tests failing - https://phabricator.wikimedia.org/T125513#1989723 (10Esanders) p:5Triage>3Unbreak! [14:16:15] 10Cite: Zero-width joiner before references on Wikipedia - https://phabricator.wikimedia.org/T125480#1989757 (10Graham87) The zero-width character reads as a question mark for me in the latest versions of both JAWS and NVDA, which are among the most popular screen readers for Windows. [14:20:48] 10Cite: Zero-width joiner before references on Wikipedia - https://phabricator.wikimedia.org/T125480#1989761 (10Graham87) Which admittedly doesn't sound that bad *before* a reference ... but I could still do without it. [14:20:52] 10VisualEditor, 10Continuous-Integration-Infrastructure, 10Math: Math tests failing - https://phabricator.wikimedia.org/T125513#1989763 (10Physikerwelt) @esanders: do you have access to the jenkins clients? It would be interesting to figure out what has been changed there. For example one could test to compi... [14:42:55] 10Cite: Zero-width joiner before references on Wikipedia - https://phabricator.wikimedia.org/T125480#1989800 (10Fomafix) Can such a CSS rule excluded for screen readers? [14:43:32] 10VisualEditor: VisualEditor's Insert Template feature, when autocompleting template names, should skip "doc" subpages - https://phabricator.wikimedia.org/T125517#1989801 (10maiden_taiwan) 3NEW [15:20:48] 10VisualEditor, 10Continuous-Integration-Infrastructure, 10Math: Math tests failing - https://phabricator.wikimedia.org/T125513#1989919 (10Esanders) I'm not really familiar with it. @Jdforrester-WMF or @hashar will be better placed to fixed this. [16:26:02] 10VisualEditor: When switching between the wikitext and visual editors, the "Discard changes" option should require confirmation before losing all my work - https://phabricator.wikimedia.org/T123960#1990105 (10Whatamidoing-WMF) If you are going WT to VE, and choose to discard your changes, then the browser promp... [16:29:49] Hey, are there any efforts already for allowing real-time collaboration with ve? I'm working on what I hope will become the successor of etherpad, and was wondering if integrating it with ve is feasible. It would certainly be cool, I think. [16:30:11] For anyone interested: http://hivejs.org [16:31:34] 10VisualEditor: When switching between the wikitext and visual editors, the "Discard changes" option should require confirmation before losing all my work - https://phabricator.wikimedia.org/T123960#1990128 (10Krenair) Are you saying we currently have double confirmation one way but not the other? We should fix... [16:31:51] Currently there is support for HTML (syncing DOM trees), but I'm not sure if syncing the ve DOM tree is ideal. Ideally, the model behind it should be synced, which would require a new ottype. [16:33:24] analphabet: Hey again. :-) Yes, cscott did some work tying Mozilla's TogetherJS (formerly TowTruck) into VE-MW and MediaWiki itself. There's a stack of WIP patches in VE to make it work, but it's not merged. edsanders would be the person with whom to talk. :-) [16:43:16] 10VisualEditor, 10QuickSurveys: QuickSurveys breaks (is incompatible) with VisualEditor on mediawiki-1.25.3 - https://phabricator.wikimedia.org/T125534#1990191 (10Jpagliaccio) 3NEW [16:51:18] James_F: hey :) thanks. Does TogetherJS allow real-time editing on HTML contenteditable elements? [16:52:27] analphabet: This is abit beyond my knowledge. :-) I believe that it's more a framework for OT systems, and with a few patches we've made VE OT. I think. [16:52:52] 10VisualEditor, 10Continuous-Integration-Infrastructure, 10Math: Math tests failing - https://phabricator.wikimedia.org/T125513#1990224 (10Physikerwelt) was this fixed: https://gerrit.wikimedia.org/r/#/c/267611/ [16:58:14] ok [17:02:03] 10Cite: Zero-width joiner before references on Wikipedia - https://phabricator.wikimedia.org/T125480#1990256 (10Graham87) Nope. Screen readers don't follow the CSS rules that have been designed for them. [17:21:41] edsanders, thx for the patches! how hard do you think would it be to do https://phabricator.wikimedia.org/T125539 ? [17:21:54] (no pressure of course :)))) [17:25:06] (03CR) 10Jforrester: [C: 031] "Leaving to Kemayo to +2." [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/266774 (owner: 10Esanders) [17:25:59] 10Cite: Zero-width joiner before references on Wikipedia - https://phabricator.wikimedia.org/T125480#1990356 (10TheDJ) @Fomafix no, that's not possible. Also It creates a bit of a visual problem with larger sequences of multiple references and situations where the ref id is something like [note-567] should also... [17:26:04] (03CR) 10Jforrester: [C: 031] "Leaving to Krenair to +2." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/252345 (owner: 10Esanders) [17:31:37] yurik, mostly you'd worry about integrating the UI [17:32:20] edsanders, rigth, so in your opinion, is that more like a day project or a month project? [17:32:44] edsanders: hey! I'm glad to catch you. I was told by James_F you're the one to talk to about real-time collab integration in ve. [17:32:58] yurik, could be longish [17:33:28] analphabet, one of them [17:33:49] edsanders, heh, well, i guess we will launch without the editor, but it would definitely be the killer feature once we add it :) [17:34:59] analphabet, as you've probably heard cscott has done a lot of thinking about it too [17:36:24] edsanders: I heard cscott has implemented integration with togetherJS. How did that work out for you? [17:36:32] edsanders, btw, i think thedj at one point experimented with adding it at one of the hackathons [17:36:47] maybe thedj wants to participate in it? :D [17:36:53] analphabet, I didn't see it - it was an experiment he did on his own [17:37:08] analphabet, our main issue is working out and what level we do conflict resolution [17:37:24] analphabet, i.e. transaction level / data model level/ dom level [17:37:54] yurik, you could probably hack it in quite quickly - the hard part is doing a clean integration [17:38:28] 10VisualEditor, 6Community-Liaison, 3Liaisons-February-2016: Review list of pages which receive the VE newsletter - https://phabricator.wikimedia.org/T125430#1990382 (10Elitre) For now I added Phase 6.1 wikis, and removed targets which can't be used anymore. [17:38:30] edsanders, what specifically do you think might be the problems with integration? [17:39:04] analphabet, transactions are always generated against a specific version of the doc, and if you re-order them there's no guarantee you'll end up with a logically valid document [17:39:54] just fitting all the widgets into our dialog, and making them look right [17:40:30] edsanders: and transactions are wikitext diffs already, or..? [17:40:47] analphabet, VE knows nothing of wikitext - it's an HTML editor [17:40:50] analphabet: sorry, let me catch up on backlog here & figure out what you folks are talking about. [17:41:07] cscott: heh, okies [17:41:25] edsanders, is your patch ready or are you still working on it? i tried it at vem3.wmflabs.org, seems to be ok [17:41:34] yurik, ready [17:41:38] analphabet, It's HTML in, HTML out - Parsoid handles wikitext conversion later. [17:42:06] analphabet: yes, at various points my togetherjs patches have allowed real time editing of the VE canvas. but VE and TogetherJS keep mutually changing (and my approach to the integration also has changed) so the current code isn't completely working. [17:42:17] analphabet, but within VE we convert the HTML to a linear model: [ {type:'paragraph'}, 'F', 'o', 'p', {type:'/paragraph'}] [17:42:26] edsanders: is it actually a HTML editor, or an editor for an intermediary format, i.e. your model? -- yea [17:42:32] analphabet, the transactions occur against that linear mode (so no tree transactions) [17:42:40] yes, in theory VE is wikitext-free, so it should allow arbitrary editing of a content-editable. however, there's a startup issue where togetherjs needs to enumerate the VE canvases on the page. [17:42:52] IIRC VE didn't have a good mechanism to do that at the time, so that used a WMF-specific hack [17:43:02] that might have been fixed in VE core by now, i'd have to look. [17:43:53] i've been looking for an excuse to refresh that patch set for a while, so if you've got a compelling near term use case I could probably be persuaded to dust it off. [17:44:59] cscott: how did your integration with togetherJs turn out? Afaict, togetherJS can't sync the DOM, can it? [17:45:00] as edsanders said, the sketchiest part was getting some support integrated in VE to represent the VE operations (which togetherjs then takes case of the real-time cooperative ordering of). I've written three different versions of those VE patches to date; lucky charm is probably attempt #4. [17:45:37] analphabet: togetherjs has a plugin mechanism, so you just tell it where in the DOM the VE canvas lives, and then give it a plugin method which is VE-aware to use the VE machinery to sync the VE canvas. [17:46:16] the togetherjs plugin is not a lot of code, let me see if i can find it [17:46:27] ah, k [17:46:45] https://github.com/cscott/mediawiki-extensions-togetherjs/blob/master/js/ext.togetherjs.ve.js [17:47:14] note the very end of that file has the mediawiki-specific code to find the VE canvases on the page. VE should grow a MW-independent mechanism for that. [17:47:54] cf https://github.com/cscott/mediawiki-extensions-togetherjs/blob/master/js/ext.togetherjs.ve.js#L374 "According to Trevor, we should really "just make an ve.InstanceList class, which has add and remove methods and emits add and remove events. Then replace ve.instances and ve.init.target with instances of ve.InstanceList, and make all callers use add/remove instead of push/splice. Then just connect to ve.instances or ve.init.targets and lis [17:48:11] analphabet: can you describe your use case a bit? is it cool? [17:49:09] analphabet: (also, my togetherjs integration had an issue with the mediawiki "save" button, we really needed some sort of cooperative save mechanism, but I didn't have good ideas for how to do that at the time. but in january some folks gave me some really good ideas for how to do that properly.) [17:51:05] I'm working on what I hope to be the successor of etherpad, and was intrigued to integrate it with ve. I'm guessing togetherJs has solved most problems related to real-time collaboration [17:51:12] already [17:53:51] so, you have transformation of transactions baked into ve? [17:54:03] (cscott) [17:54:43] (03CR) 10DLynch: [C: 032] "I'm happy with the aesthetics now." [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/266774 (owner: 10Esanders) [17:57:50] analphabet: weeellll. yes. four or so different times. the latest version is at https://gerrit.wikimedia.org/r/151545 [17:58:08] a VE-based etherpad would be very cool. it is my goal in life to replace WMF's usage of etherpad in our meetings. [17:58:23] analphabet: are you working on this in the near term? [17:59:11] 10VisualEditor, 10Continuous-Integration-Config, 6Discovery, 10Kartographer, and 2 others: Add VisualEditor as a CI dependency of the Kartographer extension - https://phabricator.wikimedia.org/T122926#1990451 (10Yurik) [17:59:12] what's your plan for persistent storage of documents? the togetherjs hub just synchronizes real-time sessions, you'd still need to integrate some storage mechanism. [17:59:42] cscott: have a demo: http://hivejs.org [17:59:45] ;) [18:00:49] s/soar spot in Etherpad/sore spot in Etherpad/ on http://hivejs.org/ [18:00:56] (sorry, can't resist writing patches) [18:01:02] (there's also plugins for presence/userlist, chat, caret broadcast, and attribution markers) [18:02:26] (03Merged) 10jenkins-bot: Move logic for showing icon for invisibles to focusable node [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/266774 (owner: 10Esanders) [18:03:46] analphabet: that looks pretty solid. togetherjs has a ckeditor plugin as well AFAIK [18:04:03] (i think that's what you're using for html editing?) [18:06:25] (03PS2) 10Jforrester: Update VE core submodule to master (53476f4) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/267902 (owner: 10Esanders) [18:06:50] (03CR) 10Jforrester: [C: 032] Update VE core submodule to master (53476f4) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/267902 (owner: 10Esanders) [18:07:15] (03PS3) 10Jforrester: Use new iconWhenInvisible feature in Transclusion/Extenion nodes [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/266777 (owner: 10Esanders) [18:07:15] analphabet: re "iframes discard their content if detached" -- there's an importNode/adoptNode API in the DOM specifically for that purpose. [18:07:41] (03CR) 10Jforrester: [C: 032] Use new iconWhenInvisible feature in Transclusion/Extenion nodes [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/266777 (owner: 10Esanders) [18:08:22] analphabet: http://cscott.net/#post-cananian-60624 if you're curious [18:09:47] analphabet: the CKEditor folk might be interesting in knowing of that solution, but I can't be bothered to create a trac account just to tell them about it. [18:13:45] (03CR) 10jenkins-bot: [V: 04-1] Update VE core submodule to master (53476f4) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/267902 (owner: 10Esanders) [18:20:15] (03CR) 10jenkins-bot: [V: 04-1] Use new iconWhenInvisible feature in Transclusion/Extenion nodes [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/266777 (owner: 10Esanders) [18:22:39] 10Cite: Zero-width joiner before references on Wikipedia - https://phabricator.wikimedia.org/T125480#1990627 (10Fomafix) >>! In T125480#1990256, @Graham87 wrote: > Nope. Screen readers don't follow the CSS rules that have been designed for them. That is not the answer of my question. Maybe we have a misunderstan... [18:45:54] James_F, not seeing any local errors on the pull through [18:46:07] (03CR) 10Esanders: "recheck" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/267902 (owner: 10Esanders) [18:46:38] (03CR) 10Esanders: [C: 032] Check xhr.responseText is set before trying to send it to $.byteLength [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/267693 (https://phabricator.wikimedia.org/T125399) (owner: 10Alex Monk) [18:46:44] 18:11:37 Chromium 48.0.2564 (Ubuntu 0.0.0) mediawiki.jqueryMsg Match PHP parser FAILED [18:47:08] 10VisualEditor, 10VisualEditor-MediaWiki: Error in VE ArticleTarget error handler - https://phabricator.wikimedia.org/T125399#1990771 (10Jdforrester-WMF) 5Open>3Resolved p:5Triage>3High [18:47:26] James_F, seems unlikely given what was pulled through [18:47:39] edsanders: It's a failure in MW core, not VE. [18:47:52] how did that get merged? [18:47:53] edsanders: Could be that it's broken/flaky, could be that the CI environment is broken. [18:48:01] edsanders: Don't worry about it. [18:51:42] seems to be passing now [18:52:27] (03CR) 10Jforrester: [C: 032] Update VE core submodule to master (53476f4) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/267902 (owner: 10Esanders) [18:52:38] But 267693,2 is failing. [18:52:54] * James_F sighs. [18:52:59] (03PS3) 10Jforrester: Check xhr.responseText is set before trying to send it to $.byteLength [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/267693 (https://phabricator.wikimedia.org/T125399) (owner: 10Alex Monk) [18:53:06] (03CR) 10Jforrester: [C: 032] Check xhr.responseText is set before trying to send it to $.byteLength [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/267693 (https://phabricator.wikimedia.org/T125399) (owner: 10Alex Monk) [18:53:58] 10VisualEditor: VisualEditor ctrl-A fails to capture the last line if there's no final newline - https://phabricator.wikimedia.org/T125557#1990812 (10maiden_taiwan) [18:54:21] 10VisualEditor: VisualEditor ctrl-A fails to capture the last line if there's no final newline - https://phabricator.wikimedia.org/T125557#1990806 (10maiden_taiwan) This is MediaWiki 1.26.2 with the appropriate VE version for 1.26. [19:00:03] 10VisualEditor: VisualEditor ctrl-A fails to capture the last line if there's no final newline - https://phabricator.wikimedia.org/T125557#1990830 (10Esanders) What browser & OS? Are you using an IME? I can't reproduce in this in Chrome or Firefox. [19:00:07] (03Merged) 10jenkins-bot: Update VE core submodule to master (53476f4) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/267902 (owner: 10Esanders) [19:01:20] edsanders: Do you agree with my edit to https://gerrit.wikimedia.org/r/#/c/114355/5/tests/dm/ve.dm.example.js as that being the expected outcome? [19:02:17] 10Cite: Zero-width joiner before references on Wikipedia - https://phabricator.wikimedia.org/T125480#1990834 (10Fomafix) >>! In T125480#1990356, @TheDJ wrote: > Also It creates a bit of a visual problem with larger sequences of multiple references and situations where the ref id is something like [note-567] shou... [19:06:32] 10VisualEditor, 10VisualEditor-Tables: "Delete" message is unclear, when multiple cells are selected - https://phabricator.wikimedia.org/T125482#1990854 (10Esanders) and it doesn't change in response to the selection [19:07:44] 10VisualEditor, 10VisualEditor-Tables: Table doesn't display correctly after the last column has been deleted - https://phabricator.wikimedia.org/T125483#1988780 (10Esanders) This is likely caused by the sparse cell slugging feature. [19:08:09] (03Merged) 10jenkins-bot: Use new iconWhenInvisible feature in Transclusion/Extenion nodes [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/266777 (owner: 10Esanders) [19:08:11] (03Merged) 10jenkins-bot: Check xhr.responseText is set before trying to send it to $.byteLength [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/267693 (https://phabricator.wikimedia.org/T125399) (owner: 10Alex Monk) [19:25:03] James_F, I'll look later, going to the football [19:25:12] Kk. [19:27:54] 10VisualEditor: VisualEditor 1.26: Ctrl-A fails to capture the last line if there's no final newline - https://phabricator.wikimedia.org/T125557#1990945 (10Jdforrester-WMF) 5Open>3stalled [19:28:24] 10VisualEditor, 10QuickSurveys: VisualEditor 1.25: QuickSurveys breaks (is incompatible) with VisualEditor on mediawiki-1.25.3 - https://phabricator.wikimedia.org/T125534#1990947 (10Jdforrester-WMF) [19:29:00] 10VisualEditor, 10QuickSurveys: VisualEditor 1.25: QuickSurveys breaks (is incompatible) with VisualEditor on mediawiki-1.25.3 - https://phabricator.wikimedia.org/T125534#1990191 (10Jdforrester-WMF) 5Open>3stalled This seems odd. No edit button //probably// means a JavaScript error; is there anything in yo... [19:30:02] 10VisualEditor: VisualEditor's Insert Template feature, when autocompleting template names, should skip "doc" subpages - https://phabricator.wikimedia.org/T125517#1990969 (10Jdforrester-WMF) [19:30:04] 10VisualEditor, 10VisualEditor-EditingTools, 10VisualEditor-MediaWiki-Templates: Transclusion dialog should not suggest documentation sub pages as templates - https://phabricator.wikimedia.org/T54448#1990970 (10Jdforrester-WMF) [19:33:58] 10VisualEditor, 10Continuous-Integration-Infrastructure, 10Math: Math tests failing - https://phabricator.wikimedia.org/T125513#1991003 (10Jdforrester-WMF) I'm merging this with {T125495} because I think they're all the same issue. I think. [19:34:09] 10VisualEditor, 10Continuous-Integration-Infrastructure, 10Math: Math tests failing - https://phabricator.wikimedia.org/T125513#1991005 (10Jdforrester-WMF) [19:35:07] 10VisualEditor, 10VisualEditor-Tables: Table doesn't display correctly after the last column has been deleted - https://phabricator.wikimedia.org/T125483#1991009 (10Jdforrester-WMF) p:5Triage>3High [19:41:53] 10VisualEditor, 10VisualEditor-Tables: "Delete" message is unclear, when multiple cells are selected - https://phabricator.wikimedia.org/T125482#1991041 (10Jdforrester-WMF) 5Open>3stalled [19:42:23] 10VisualEditor, 10VisualEditor-Tables: Table doesn't display correctly after the last column has been deleted - https://phabricator.wikimedia.org/T125483#1991044 (10Jdforrester-WMF) [19:42:25] 10VisualEditor, 10VisualEditor-Tables: [Regression pre-wmf.12] Deleting the last column of a table breaks its UI - https://phabricator.wikimedia.org/T125436#1991045 (10Jdforrester-WMF) [19:42:44] 10VisualEditor, 6Community-Liaison, 3Liaisons-February-2016: Review list of pages which receive the VE newsletter - https://phabricator.wikimedia.org/T125430#1991048 (10Jdforrester-WMF) [19:44:27] 10VisualEditor, 10ContentTranslation-cxserver, 10Parsoid, 10RESTBase, and 2 others: Remove user name and edit comment from html - https://phabricator.wikimedia.org/T125266#1991070 (10Jdforrester-WMF) [19:45:00] 10VisualEditor, 10SyntaxHighlight: Language identification for a code block is case sensitive: some blocks disappear while editing with VE - https://phabricator.wikimedia.org/T125231#1991072 (10Jdforrester-WMF) p:5Triage>3Low [19:46:06] 10VisualEditor: Link editor does not handle fragment - https://phabricator.wikimedia.org/T124631#1991089 (10Jdforrester-WMF) [19:46:10] 10VisualEditor, 10VisualEditor-MediaWiki-Links, 6Collaboration-Team-Backlog, 10Flow: [Regression wmf23] On creating an inter-wiki link, the nice regex strips section parts of the link - https://phabricator.wikimedia.org/T112898#1991090 (10Jdforrester-WMF) [19:47:34] 10VisualEditor, 10VisualEditor-EditingTools, 10VisualEditor-MediaWiki: Back out pending nodes/etc. on switching editor so that e.g. half-made references aren't created - https://phabricator.wikimedia.org/T125479#1991100 (10Jdforrester-WMF) p:5Triage>3Low [19:48:37] 10VisualEditor: When switching between the wikitext and visual editors, the "Discard changes" option should require confirmation before losing all my work - https://phabricator.wikimedia.org/T123960#1991125 (10Jdforrester-WMF) 5Open>3declined a:3Jdforrester-WMF We shouldn't double-ask ever. [19:49:19] 10VisualEditor, 10VisualEditor-MediaWiki: Make the "Discard changes" message for bi-directional switching clearer - https://phabricator.wikimedia.org/T125481#1991134 (10Jdforrester-WMF) It only discards //your// changes, though… not sure if that's worth stating? [19:49:45] 10VisualEditor: VisualEditor 1.25: Image alignment causes VisualEditor to not load in REL1_25 - https://phabricator.wikimedia.org/T123471#1991135 (10Jdforrester-WMF) [20:06:54] 10VisualEditor, 10VisualEditor-ContentEditable: Cannot move cursor left past nail at the end of styled text unless using the mouse to move the cursor first - https://phabricator.wikimedia.org/T123430#1991234 (10Jdforrester-WMF) p:5Triage>3High [20:06:59] 10VisualEditor, 10VisualEditor-ContentEditable: Cannot move cursor left past nail at the end of styled text unless using the mouse to move the cursor first - https://phabricator.wikimedia.org/T123430#1929586 (10Jdforrester-WMF) Most perplexing. [20:08:21] 10VisualEditor, 10VisualEditor-ContentEditable: pressing left-arrow key, cursor skips period past footnote reference. - https://phabricator.wikimedia.org/T123608#1991254 (10Jdforrester-WMF) p:5Triage>3Normal [20:11:11] 10VisualEditor: VisualEditor link tool stays active after you're done with the link - https://phabricator.wikimedia.org/T123664#1991275 (10Jdforrester-WMF) 5Open>3Invalid a:3Jdforrester-WMF There are two things here: * There is a context menu shown against any node (image, template, reference, …) or rich... [20:11:58] 10VisualEditor, 10VisualEditor-MediaWiki: Occassional "docserver-http: HTTP 404" when trying to save an edit made in Visual Editor - https://phabricator.wikimedia.org/T123708#1991279 (10Jdforrester-WMF) p:5Triage>3Normal [20:12:29] 10VisualEditor, 10VisualEditor-MediaWiki: Occassional "docserver-http: HTTP 404" when trying to save an edit made in Visual Editor - https://phabricator.wikimedia.org/T123708#1936248 (10Jdforrester-WMF) Do you have any particular reproduction steps? Do you think it's related to a particular account, set of pag... [20:13:55] 10VisualEditor: VisualEditor Captcha is not solvable, keeps refreshing after saving, cannot save page - https://phabricator.wikimedia.org/T123736#1991296 (10Jdforrester-WMF) 5Open>3stalled It's probable that the particular extension you're using to provide a CAPTCHA needs custom support inside VisualEditor (... [20:14:26] 10VisualEditor: [With some extension's set-up,] CAPTCHA is not solvable in VisualEditor, keeps refreshing after saving, cannot save page - https://phabricator.wikimedia.org/T123736#1991298 (10Jdforrester-WMF) [20:15:10] 10VisualEditor, 10VisualEditor-CopyPaste, 10VisualEditor-MediaWiki, 10VisualEditor-MediaWiki-Media, 7I18n: When copying an image from a non-English wiki, use the correct File: namespace for the target wiki, not the source wiki - https://phabricator.wikimedia.org/T123768#1991301 (10Jdforrester-WMF) [20:17:45] 10VisualEditor, 6Research-and-Data: Add support for hashtags (URL parameter -> edit summary) - https://phabricator.wikimedia.org/T123529#1991325 (10Jdforrester-WMF) 5Open>3stalled Is there a proposed design here to be implemented? I'm unconvinced of the value, but if there's a clean design we could look at... [20:18:04] 10VisualEditor, 10VisualEditor-MediaWiki-Media: Make it possible to set, change and remove the |link= for an image file - https://phabricator.wikimedia.org/T123769#1991330 (10Jdforrester-WMF) [20:18:06] 10VisualEditor, 10VisualEditor-EditingTools: VisualEditor: Be able to set a over-ride link target (link=…) in the media edit dialog - https://phabricator.wikimedia.org/T64672#1991331 (10Jdforrester-WMF) [20:18:08] 10VisualEditor, 10VisualEditor-MediaWiki: Occassional "docserver-http: HTTP 404" when trying to save an edit made in Visual Editor - https://phabricator.wikimedia.org/T123708#1991334 (10Mbch331) I usually use Visual Editor when I want to add an image to an infobox. So far it's pages with infoboxes, but it's ha... [20:20:26] 10VisualEditor, 10VisualEditor-DataModel, 10VisualEditor-MediaWiki-References, 7Epic: If a reference is defined in a template, and re-used outside of it, and you delete the template, then the reference contents get lost; similarly, copying citations defined ... - https://phabricator.wikimedia.org/T67301#1991345 [20:20:36] 10VisualEditor, 10VisualEditor-CopyPaste: Copying citations from a reference template doesn't work as expected - https://phabricator.wikimedia.org/T123774#1991351 (10Jdforrester-WMF) [20:20:38] 10VisualEditor, 10VisualEditor-DataModel, 10VisualEditor-MediaWiki-References, 7Epic: If a reference is defined in a template, and re-used outside of it, and you delete the template, then the reference contents get lost; similarly, copying citations defined ... - https://phabricator.wikimedia.org/T67301#1991352 [20:23:29] 10VisualEditor, 10VisualEditor-MediaWiki-References: Make it possible to convert a bare URL reference that I just added - https://phabricator.wikimedia.org/T123776#1991362 (10Jdforrester-WMF) p:5Triage>3Normal [20:24:09] 10VisualEditor, 10VisualEditor-MediaWiki-References: When Converting a bare URL, just alter the contents, don't replace the reference - https://phabricator.wikimedia.org/T123778#1991368 (10Jdforrester-WMF) p:5Triage>3Low [20:25:19] 10VisualEditor: MediaWiki.org's {{Extension}} infobox template is broken; causes text to slide to the right when editing - https://phabricator.wikimedia.org/T123870#1991385 (10Jdforrester-WMF) p:5Triage>3Low [20:27:30] 10VisualEditor, 10VisualEditor-MediaWiki, 10VisualEditor-MediaWiki-Links: Inserting a link forces the first character to be capitalised, which doesn't work for case-sensitive interwiki links - https://phabricator.wikimedia.org/T124410#1991398 (10Jdforrester-WMF) p:5Triage>3Low [20:34:13] 10VisualEditor: VisualEditor 1.26: Ctrl-A fails to capture the last line if there's no final newline - https://phabricator.wikimedia.org/T125557#1991432 (10maiden_taiwan) In Windows 7 Professional, I can reproduce this 100% of the time in Firefox 44.0, Chrome 48.0.2564.97 m, and Internet Explorer 11. I don't kn... [20:38:30] 10VisualEditor: VisualEditor 1.26: Ctrl-A fails to capture the last line if there's no final newline - https://phabricator.wikimedia.org/T125557#1991468 (10maiden_taiwan) I can't reproduce it on Wikipedia, but I can on our 1.26.2 internal wiki at work. Attached is a screenshot after: # Starting a new article... [20:38:38] 10VisualEditor, 6Research-and-Data: Add support for hashtags (URL parameter -> edit summary) - https://phabricator.wikimedia.org/T123529#1991474 (10mahmoud) Oh, sure, so the design as I understand it is to make it so that editathon coordinators can distribute a special link that would associate the clicking us... [20:40:02] I created a custom mw skin, but want to become able to use visualeditor. Unfortunately I get a console error when using my theme: "Uncaught TypeError: Cannot read property 'getBoundingClientRect' of undefined". I guess this is happening because of the module "ext.visualEditor.desktopArticleTarget.init" where this is included: "contentRect=$content[0].getBoundingClientRect();" [20:40:22] Can someone help me with my problem? :) [20:40:57] 10VisualEditor, 10VisualEditor-EditingTools, 10VisualEditor-MediaWiki-Templates: Transclusion dialog should not suggest documentation sub pages as templates - https://phabricator.wikimedia.org/T54448#1991488 (10maiden_taiwan) Suggestion: allow the wiki administrator to designate a particular subpage string,... [20:42:49] 10Cite, 5Patch-For-Review: No duplicate ref error when duplicate refs are defined inside {{#tag:references}} - https://phabricator.wikimedia.org/T124227#1991495 (10matmarex) 5Open>3Resolved This has been fixed and will be deployed to Wikimedia wikis soon, see Maybe someone is able to tell me where $content gets defined [20:49:30] ReJoin: i think VisualEditor relies on some 'id' attributes on various page elements [20:50:39] modules/ve-mw/init/targets/ve.init.mw.DesktopArticleTarget.init.js [20:50:42] $content = $( '#content' ); [20:50:42] contentRect = $content[ 0 ].getBoundingClientRect(); [20:50:55] so… your skin has to wrap the page content in
, i guess. [20:54:16] Oh ok, then I only have to add id="content" to my template ? .. if so, thank you [20:55:32] huh [20:55:44] apparently if you fail to switch WTE -> VE too many times you end up with this in console [20:55:49] Uncaught TypeError: target.loading.abort is not a function [20:55:57] and a useless page [20:56:00] lovely [20:56:50] 10VisualEditor, 10VisualEditor-CopyPaste: Copying citations from a reference template doesn't work as expected - https://phabricator.wikimedia.org/T123774#1991542 (10Whatamidoing-WMF) I've been trying to reproduce this. I've been successful once today, but then I went back to make sure I had all of the steps... [20:58:54] (03CR) 10Alex Monk: [C: 04-1] "Now it doesn't show when you switch from VE into the wikitext editor while keeping changes." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/252345 (owner: 10Esanders) [20:59:53] hmm... not always [20:59:58] sometimes it breaks it different ways [21:00:19] like an empty progress bar with a useless page [21:02:00] MatmaRex Thank you, it worked! [21:02:18] 10VisualEditor, 10VisualEditor-MediaWiki: Failing to switch from the wikitext editor into VE 3 times in a row leaves you with a useless page - https://phabricator.wikimedia.org/T125580#1991565 (10Krenair) 3NEW [21:20:54] oh, hi tewwy [21:20:55] how are you? [21:21:17] Hey tewwy! [21:21:29] Krenair: Fine. Accidentally launched IRC :-) [21:21:34] ah :) [21:21:39] James_F: Hey James_F! [21:21:50] * James_F grins. [21:21:58] But I might as well leave visualeditor on my auto-log ins just for s—t’s and gigles [21:22:06] tewwy: You should come to the office some time. [21:22:15] :-) [21:22:39] James_F: It’s only a block away, but that’s a bit far. [21:22:55] Besides, everyone will be different except for some of the engineering staff. [21:22:57] * James_F tsks. [21:23:05] tewwy: It's all the Superb Owl traffic, right? [21:23:33] tewwy: Turn-over in the staff hasn't been that high. Mostly senior management. [21:23:35] I’m literally around the corner. Just south of 111 minna [21:23:49] Ha. [21:24:23] tewwy: Any time you want a coffee, just ask. :-) [21:24:29] James_F: Yes, I’d recognize the engineers and that’s about it. But I don’t know if I can handle the gossip. It gave me grey hair. :-) [21:24:59] tewwy: Though 111 Minna does coffee too. [21:26:25] Yes, they were doing that before I left. Though the Yelp building opened up. I visited a friend who works there (in the building, but not for Yelp) [21:26:50] You might see more of me around the city now that I’m no longer working from home. :-) [21:29:43] :-) [21:46:14] (03CR) 10Alex Monk: Localise names of types in HTML rendering (031 comment) [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/263918 (https://phabricator.wikimedia.org/T61745) (owner: 10Alex Monk) [21:52:32] (03CR) 10Alex Monk: Localise names of types in HTML rendering (031 comment) [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/263918 (https://phabricator.wikimedia.org/T61745) (owner: 10Alex Monk) [22:00:57] 10Cite: Zero-width joiner before references on Wikipedia - https://phabricator.wikimedia.org/T125480#1991806 (10Obsuser) What is defined as a "veryLongUnwrapableWordAtTheEnd"? Is it like a recipe which tells you "put some sugar" or "put a bit of sugar" where "a bit" for me could be either 0.0000000001 g or 2,000... [22:09:13] (03PS1) 10Jforrester: Update OOjs UI to v0.15.2 [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/268006 [22:14:02] (03CR) 10jenkins-bot: [V: 04-1] Update OOjs UI to v0.15.2 [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/268006 (owner: 10Jforrester) [22:14:19] Eh. [22:14:41] * James_F fiddles. [22:15:33] 10Cite: Zero-width joiner before references on Wikipedia - https://phabricator.wikimedia.org/T125480#1991869 (10TheDJ) >>! In T125480#1991806, @Obsuser wrote: > What is defined as a "veryLongUnwrapableWordAtTheEnd"? The subjective point at which people will perceive it as 'standing out' compared it's surroundin... [22:15:35] (03CR) 10Bartosz Dziewoński: [C: 032] Update OOjs UI to v0.15.2 [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/268006 (owner: 10Jforrester) [22:15:59] MatmaRex: No, that needs fixing. [22:16:12] heh. [22:16:23] i'm just used to npm jobs failing all the time for no reason. [22:16:32] MatmaRex: Jsduck is seeing the duplicate definitions in oojs-ui.js and oojs-ui-windows.js etc. [22:16:50] ughhhhh [22:17:20] eh, how does that make any sense [22:17:29] we should probably not copy all of dist/, eh. [22:18:15] Yeah. [22:22:12] (03PS2) 10Jforrester: Update OOjs UI to v0.15.2 [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/268006 [22:22:34] MatmaRex: ^^^ +2 that? :-) [22:23:46] (03CR) 10Bartosz Dziewoński: [C: 032] Update OOjs UI to v0.15.2 [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/268006 (owner: 10Jforrester) [22:24:03] um [22:24:05] Technically I shouldn't do the switch-over in the same patch, but eh. [22:24:06] will that work? [22:24:13] ah, wait, okay [22:24:16] i see now [22:24:19] It seemed to. [22:24:23] :-) [22:24:27] Build files are magical. [22:27:42] (03PS1) 10Jforrester: update-oojs-ui: Don't copy across oojs-ui.js, we don't use that [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/268014 [22:28:56] (03Merged) 10jenkins-bot: Update OOjs UI to v0.15.2 [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/268006 (owner: 10Jforrester) [22:39:43] 10VisualEditor, 10VisualEditor-MediaWiki, 6Community-Liaison, 10MediaWiki-extensions-TemplateData, and 3 others: Check documentation for the TemplateData editor for completeness, accuracy, and ease of understanding by adding TemplateData to templates on Wik... - https://phabricator.wikimedia.org/T117499#1991984 [22:52:31] 10VisualEditor, 10VisualEditor-CopyPaste: Copying the (plain) text of citations from a reference template, and pasting that text into a Basic citation form, doesn't work as expected - https://phabricator.wikimedia.org/T123774#1992045 (10Whatamidoing-WMF) 5duplicate>3Open [22:52:59] (03PS1) 10Esanders: Defer creation of cell slugs until end of cycle [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/268015 (https://phabricator.wikimedia.org/T125436) [22:58:10] 10VisualEditor, 10VisualEditor-CopyPaste: Copying the (plain) text of citations from a reference template, and pasting that text into a Basic citation form, doesn't work as expected - https://phabricator.wikimedia.org/T123774#1992073 (10Whatamidoing-WMF) The {{reflist}} template may be a red herring. The same... [22:58:58] (03CR) 10Jforrester: [C: 032] Defer creation of cell slugs until end of cycle [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/268015 (https://phabricator.wikimedia.org/T125436) (owner: 10Esanders) [22:59:30] 10VisualEditor, 10VisualEditor-MediaWiki, 6Editing-Analysis: Sample edit events in desktop visual editor at 6.25% - https://phabricator.wikimedia.org/T125598#1992076 (10Neil_P._Quinn_WMF) 3NEW a:3Neil_P._Quinn_WMF [23:00:10] (03PS1) 10Jforrester: Defer creation of cell slugs until end of cycle [VisualEditor/VisualEditor] (wmf/1.27.0-wmf.12) - 10https://gerrit.wikimedia.org/r/268017 (https://phabricator.wikimedia.org/T125436) [23:00:52] 10VisualEditor, 10VisualEditor-Tables, 5Patch-For-Review: [Regression pre-wmf.12] Deleting the last column of a table breaks its UI - https://phabricator.wikimedia.org/T125436#1992089 (10Jdforrester-WMF) a:3Esanders [23:01:00] (03CR) 10Jforrester: [C: 032] Defer creation of cell slugs until end of cycle [VisualEditor/VisualEditor] (wmf/1.27.0-wmf.12) - 10https://gerrit.wikimedia.org/r/268017 (https://phabricator.wikimedia.org/T125436) (owner: 10Jforrester) [23:05:15] (03Merged) 10jenkins-bot: Defer creation of cell slugs until end of cycle [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/268015 (https://phabricator.wikimedia.org/T125436) (owner: 10Esanders) [23:06:47] (03Merged) 10jenkins-bot: Defer creation of cell slugs until end of cycle [VisualEditor/VisualEditor] (wmf/1.27.0-wmf.12) - 10https://gerrit.wikimedia.org/r/268017 (https://phabricator.wikimedia.org/T125436) (owner: 10Jforrester) [23:11:22] (03PS1) 10Jforrester: Update VE core submodule to master (7c7aa59) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/268018 [23:11:22] 10VisualEditor, 10VisualEditor-EditingTools, 10VisualEditor-MediaWiki: Back out pending nodes/etc. on switching editor so that e.g. half-made references aren't created - https://phabricator.wikimedia.org/T125479#1992169 (10Krenair) you mean Keep changes? [23:11:22] 10VisualEditor, 10VisualEditor-Tables, 7RTL: Tab in VisualEditor moves the wrong way in RTL - https://phabricator.wikimedia.org/T125378#1992173 (10DLynch) @dchan and I actually argued about this in https://gerrit.wikimedia.org/r/#/c/255160/5/src/ce/keydownhandlers/ve.ce.TableArrowKeyDownHandler.js when I was... [23:11:22] 10VisualEditor, 10ContentTranslation-Deployments, 10ContentTranslation-cxserver, 10Parsoid, and 4 others: Decom parsoid-lb.eqiad.wikimedia.org entrypoint - https://phabricator.wikimedia.org/T110474#1992175 (10ssastry) [23:12:49] (03PS1) 10Jforrester: Update VE core submodule to master (f7e440c) [extensions/VisualEditor] (wmf/1.27.0-wmf.12) - 10https://gerrit.wikimedia.org/r/268019 [23:13:14] (03PS2) 10Jforrester: Update VE core submodule to wmf/1.27.0-wmf.12 HEAD (f7e440c) [extensions/VisualEditor] (wmf/1.27.0-wmf.12) - 10https://gerrit.wikimedia.org/r/268019 [23:18:34] (03CR) 10jenkins-bot: [V: 04-1] Update VE core submodule to wmf/1.27.0-wmf.12 HEAD (f7e440c) [extensions/VisualEditor] (wmf/1.27.0-wmf.12) - 10https://gerrit.wikimedia.org/r/268019 (owner: 10Jforrester) [23:24:39] 10VisualEditor, 10VisualEditor-EditingTools, 10VisualEditor-MediaWiki: Back out pending nodes/etc. on switching editor so that e.g. half-made references aren't created - https://phabricator.wikimedia.org/T125479#1992251 (10Krenair) a:3Krenair @esanders: I looked at this, and was tempted to try a this.getSu... [23:33:36] 10VisualEditor, 6Research-and-Data: Add support for hashtags (URL parameter -> edit summary) - https://phabricator.wikimedia.org/T123529#1992263 (10DarTar) p:5Triage>3Normal [23:40:12] (03CR) 10Alex Monk: [C: 032] Update VE core submodule to master (7c7aa59) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/268018 (owner: 10Jforrester) [23:40:41] (03CR) 10Jforrester: "recheck" [extensions/VisualEditor] (wmf/1.27.0-wmf.12) - 10https://gerrit.wikimedia.org/r/268019 (owner: 10Jforrester) [23:47:58] (03Merged) 10jenkins-bot: Update VE core submodule to master (7c7aa59) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/268018 (owner: 10Jforrester)