[00:12:12] 10VisualEditor, 10Phlogiston, 15User-JAufrecht: 51569 shows open points and tasks but shouldn't - https://phabricator.wikimedia.org/T124949#1992422 (10JAufrecht) [00:12:14] 10VisualEditor, 10Phlogiston, 15User-JAufrecht: The forecasts for Better Link Editing and for Formula Editing are wrong - https://phabricator.wikimedia.org/T123550#1992423 (10JAufrecht) [00:12:16] 10VisualEditor, 10Phlogiston, 15User-JAufrecht: Some tasks show as "Open" in Phlogiston but "Closed" in Phabricator - https://phabricator.wikimedia.org/T124958#1992421 (10JAufrecht) 5Open>3Resolved [00:12:26] 10VisualEditor, 10VisualEditor-Tables, 5WMF-deploy-2016-02-02_(1.27.0-wmf.12), 5WMF-deploy-2016-02-09_(1.27.0-wmf.13): [Regression pre-wmf.12] Deleting the last column of a table breaks its UI - https://phabricator.wikimedia.org/T125436#1992424 (10Jdforrester-WMF) 5Open>3Resolved [00:12:29] 10VisualEditor, 10Phlogiston, 15User-JAufrecht: The forecasts for Better Link Editing and for Formula Editing are wrong - https://phabricator.wikimedia.org/T123550#1992426 (10JAufrecht) 5Open>3Resolved [00:15:03] Krenair: Do you think the V-1 (qunit) on https://gerrit.wikimedia.org/r/#/c/268019/ is real? [00:16:07] 23:42:53 Chromium 48.0.2564 (Ubuntu 0.0.0) wikibase.datamodel.Claim Constructor FAILED [00:16:29] along with various other failures from wikibase tests [00:16:48] real, but maybe not from VE [00:16:53] Oh, sure. [00:17:05] But it's -wmf.12 which isn't yet deployed anywhere. [00:17:14] I was wondering if -wmf.12 is totally borked. [00:19:00] 10VisualEditor, 10VisualEditor-MediaWiki, 10MediaWiki-Vagrant, 10MobileFrontend-Feature-requests: MobileFrontend vagrant role forces EventLogging on, breaks VisualEditor - https://phabricator.wikimedia.org/T88698#1992466 (10Jdforrester-WMF) p:5Triage>3Normal [00:26:16] https://gerrit.wikimedia.org/r/#/c/267892/ is the only other wmf.12 patch open [00:26:19] and it's a huge wikibase update [00:26:37] Fuuun. [00:26:40] * James_F sighs. [00:26:46] I'm going home. Too meh right now. [00:26:55] +9293, -4759 [00:26:57] (Great sign.) [00:27:05] * Krenair waves [00:32:31] 10Cite: Zero-width joiner before references on Wikipedia - https://phabricator.wikimedia.org/T125480#1992511 (10Graham87) >>! In T125480#1990627, @Fomafix wrote: > I tested with [[ https://addons.mozilla.org/de/firefox/addon/claws/ | Claws ]]. It does not output any CSS generated content like > ```lang=css > sup... [00:39:16] 10Cite: Zero-width joiner before references on Wikipedia - https://phabricator.wikimedia.org/T125480#1992522 (10Obsuser) But I said //it cannot be more than ten references//, and this is old version of the page just as an example. I know that mobile view is going to be influenced and others but as I mentioned:... [03:25:10] 10VisualEditor, 10ContentTranslation-Deployments, 10ContentTranslation-cxserver, 10Parsoid, and 4 others: Decom parsoid-lb.eqiad.wikimedia.org entrypoint - https://phabricator.wikimedia.org/T110474#1992751 (10BBlack) 5Open>3stalled Re: timing - per https://lists.wikimedia.org/pipermail/wikitech-l/2016-... [05:37:08] 10VisualEditor, 10VisualEditor-MediaWiki, 6Community-Liaison, 10MediaWiki-extensions-TemplateData, and 3 others: Check documentation for the TemplateData editor for completeness, accuracy, and ease of understanding by adding TemplateData to templates on Wik... - https://phabricator.wikimedia.org/T117499#1992861 [06:45:26] 10VisualEditor: [With some extension's set-up,] CAPTCHA is not solvable in VisualEditor, keeps refreshing after saving, cannot save page - https://phabricator.wikimedia.org/T123736#1992996 (10Hmrc87) [06:46:22] 10VisualEditor: [With some extension's set-up,] CAPTCHA is not solvable in VisualEditor, keeps refreshing after saving, cannot save page - https://phabricator.wikimedia.org/T123736#1936671 (10Hmrc87) Hi James, I am using ConfirmEdit 1.4.0 GPL-2.0+, although I did not install it by hand. I downloaded a stable 1.2... [07:16:54] (03CR) 10Cenarium: "Thanks for fixing the unneeded = null." [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/266661 (owner: 10Cenarium) [08:09:59] 10VisualEditor, 6Community-Liaison, 7Documentation, 3Liaisons-February-2016: Write a page on mediawiki.org to explain Single Edit Tab (with screenshots) - https://phabricator.wikimedia.org/T124710#1993129 (10Qgil) [09:08:40] 10VisualEditor: VisualEditor 1.25: Image alignment causes VisualEditor to not load in REL1_25 - https://phabricator.wikimedia.org/T123471#1993202 (10Raftab) It's not just image alignment, it's when you use any image and pass in options via pipes. Weirdly enough VE creates these, I can't imagine a breaking change... [09:12:58] https://phabricator.wikimedia.org/T125400#1991054 is not encouraging, although I guess it's an indirect answer to my question. [09:15:02] 10VisualEditor, 10VisualEditor-MediaWiki, 6Community-Liaison, 10Wikimedia-Site-Requests: Plan to redirect inactive VisualEditor feedback pages for some wikis to mediawiki.org - https://phabricator.wikimedia.org/T92661#1993222 (10Elitre) I believe the description can only be updated after T125400 is fixed. [09:33:30] (03PS1) 10Esanders: ResizableNode: Remove assumption about 'width'/'height' attributes [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/268059 [09:41:33] (03PS1) 10Divec: Utility function for "index of node in its parentNode's childNode list" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/268061 [10:08:21] (03PS1) 10Esanders: wikipage.content hook: Wait until content is visible [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/268068 (https://phabricator.wikimedia.org/T125263) [10:14:27] (03CR) 10Yurik: [C: 032] wikipage.content hook: Wait until content is visible [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/268068 (https://phabricator.wikimedia.org/T125263) (owner: 10Esanders) [10:16:17] edsanders, oops, sorry, i thought it was a kartographer patch, so i +2ed [10:16:27] should i revert? it seems simple enough [10:16:39] no - it's fine [10:16:39] I actually have a follow up for an edge case [10:18:40] feel free to test though [10:18:53] oh - I thought you meant the interactive maps one [10:19:26] um - yeah I'll get someone to post-review it, should be ok [10:20:07] (03CR) 10Esanders: [C: 04-2] wikipage.content hook: Wait until content is visible [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/268068 (https://phabricator.wikimedia.org/T125263) (owner: 10Esanders) [10:20:19] acutally it hadn't validated, just stopped it [10:20:55] yurik, just change yours to +1 [10:20:59] ok [10:21:19] (03CR) 10Yurik: [C: 031] wikipage.content hook: Wait until content is visible [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/268068 (https://phabricator.wikimedia.org/T125263) (owner: 10Esanders) [10:22:08] yurik, do you plan on supporting geojson in static mode? [10:22:28] edsanders, of course - but that geojson will need to be rendered server-side [10:22:39] yeah [10:22:39] edsanders, and it won't be available in v1 [10:23:13] ok - the 'inline' patch hides the geojson field in static mode [10:23:41] our initial target will always use interactive map - for wikivoyage i think we might even make all maps interactive even when marked as "static" [10:23:57] edsanders, i think we should always have that field [10:34:19] yurik static maps fail with 4d.p. [10:54:13] edsanders, i updated http://vem3.wmflabs.org/ [10:54:42] changes to geojson don't dynamically update on screen, right? [10:55:01] 10VisualEditor, 10VisualEditor-Tables: Inserting a row above the first row of a table results in extra cells being added to the row rather than an extra row - https://phabricator.wikimedia.org/T125419#1993478 (10Esanders) The VE HTML is correct. This looks like a Parsoid selser bug: if I change one cell is the... [10:55:05] 10VisualEditor, 10VisualEditor-MediaWiki, 6Community-Liaison, 10Wikimedia-Site-Requests: Plan to redirect inactive VisualEditor feedback pages for some wikis to mediawiki.org - https://phabricator.wikimedia.org/T92661#1993479 (10Elitre) [10:55:17] 10VisualEditor, 10VisualEditor-Tables, 10Parsoid: Inserting a row above the first row of a table results in extra cells being added to the row rather than an extra row - https://phabricator.wikimedia.org/T125419#1993481 (10Esanders) a:5Esanders>3None [10:55:34] yurik, not yet [10:55:47] i will make a task. [10:55:52] LOlOLOL github thinks i'm a robot [10:55:58] should i feel proud? [13:00:33] (03CR) 10Hashar: "recheck" [extensions/VisualEditor] (wmf/1.27.0-wmf.12) - 10https://gerrit.wikimedia.org/r/268019 (owner: 10Jforrester) [13:01:45] (03CR) 10Hashar: [C: 04-1] "I have filled the qunit test failure as T125655" [extensions/VisualEditor] (wmf/1.27.0-wmf.12) - 10https://gerrit.wikimedia.org/r/268019 (owner: 10Jforrester) [13:01:49] (03CR) 10Aude: "the submodule for wikidata on the wmf/1.27.0-wmf.12 core branch is pointing to the wrong thing." [extensions/VisualEditor] (wmf/1.27.0-wmf.12) - 10https://gerrit.wikimedia.org/r/268019 (owner: 10Jforrester) [13:03:16] 10VisualEditor, 10MediaWiki-Unit-tests, 6Release-Engineering-Team: 30% of QUnit tests fail on 1.27.0-wmf.12 branch when proposing a VE submodule dump - https://phabricator.wikimedia.org/T125655#1993674 (10hashar) [13:37:59] (03CR) 10Aude: "recheck" [extensions/VisualEditor] (wmf/1.27.0-wmf.12) - 10https://gerrit.wikimedia.org/r/268019 (owner: 10Jforrester) [13:42:15] (03CR) 10jenkins-bot: [V: 04-1] Update VE core submodule to wmf/1.27.0-wmf.12 HEAD (f7e440c) [extensions/VisualEditor] (wmf/1.27.0-wmf.12) - 10https://gerrit.wikimedia.org/r/268019 (owner: 10Jforrester) [13:45:55] (03CR) 10Hashar: "recheck" [extensions/VisualEditor] (wmf/1.27.0-wmf.12) - 10https://gerrit.wikimedia.org/r/268019 (owner: 10Jforrester) [13:46:19] (03CR) 10Hashar: "The qunit tests seems to have a wild range of different race conditions / unstable tests :-(" [extensions/VisualEditor] (wmf/1.27.0-wmf.12) - 10https://gerrit.wikimedia.org/r/268019 (owner: 10Jforrester) [13:51:01] (03CR) 10Hashar: [C: 032] Update VE core submodule to wmf/1.27.0-wmf.12 HEAD (f7e440c) [extensions/VisualEditor] (wmf/1.27.0-wmf.12) - 10https://gerrit.wikimedia.org/r/268019 (owner: 10Jforrester) [13:57:36] 10VisualEditor, 10MediaWiki-Unit-tests, 6Release-Engineering-Team: 30% of QUnit tests fail on 1.27.0-wmf.12 branch when proposing a VE submodule dump - https://phabricator.wikimedia.org/T125655#1993846 (10hashar) Looks like it was a one time error and then a racy test. The change landed. [13:57:46] 10VisualEditor, 10MediaWiki-Unit-tests, 6Release-Engineering-Team: 30% of QUnit tests fail on 1.27.0-wmf.12 branch when proposing a VE submodule dump - https://phabricator.wikimedia.org/T125655#1993847 (10hashar) 5Open>3Resolved [13:59:08] (03Merged) 10jenkins-bot: Update VE core submodule to wmf/1.27.0-wmf.12 HEAD (f7e440c) [extensions/VisualEditor] (wmf/1.27.0-wmf.12) - 10https://gerrit.wikimedia.org/r/268019 (owner: 10Jforrester) [14:04:08] (03CR) 10Hashar: "Submodule update at https://gerrit.wikimedia.org/r/268111" [extensions/VisualEditor] (wmf/1.27.0-wmf.12) - 10https://gerrit.wikimedia.org/r/268019 (owner: 10Jforrester) [14:08:28] (03PS1) 10Esanders: getViewportDimensions: Fix calculation of 'bottom' [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/268112 [15:04:26] (03PS7) 10Krinkle: SET: Set user's editor to wikitext if the browser doesn't do JS [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/259771 (https://phabricator.wikimedia.org/T121257) (owner: 10Alex Monk) [15:30:51] James_F|Away: Krenair: getting "TypeError: $.cookie is not a function" on every page with VE installed on local master [15:30:56] (Exception in module-execute in module ext.visualEditor.desktopArticleTarget.init) [15:31:00] Looks like a missing dependency [15:31:58] 10VisualEditor, 10MediaWiki-Unit-tests, 6Release-Engineering-Team: 30% of QUnit tests fail on 1.27.0-wmf.12 branch when proposing a VE submodule dump - https://phabricator.wikimedia.org/T125655#1994075 (10Krenair) Are you sure it wasn't just fixed by https://gerrit.wikimedia.org/r/#/c/267892/ ? [15:38:23] (03PS8) 10Krinkle: SET: Set user's editor to wikitext if the browser doesn't do JS [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/259771 (https://phabricator.wikimedia.org/T121257) (owner: 10Alex Monk) [15:40:59] (03CR) 10Krinkle: [C: 04-1] "On wikis where VE is default, this causes the Edit page to be empty by default and to no longer be excluded from search engines. The meta " [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/259771 (https://phabricator.wikimedia.org/T121257) (owner: 10Alex Monk) [15:44:53] what's wrong with Edit section link, guys? [15:44:54] (03PS1) 10DLynch: VE demo: allow saving some markup to localStorage for testing [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/268131 [15:45:41] wrong style, and it doesn't load any editor: random example, https://meta.wikimedia.org/wiki/User:Qgil-WMF [15:46:44] Elitre, refresh [15:47:36] (03CR) 10Krinkle: "The current effect from enabling VE (or by default) and visiting action=edit in a non-blacklisted browser." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/259771 (https://phabricator.wikimedia.org/T121257) (owner: 10Alex Monk) [15:51:13] tnx. [15:51:14] Krinkle, I don't see it [15:51:15] Elitre: https://phabricator.wikimedia.org/T124356 , i guess? [15:51:19] 10VisualEditor, 10MediaWiki-Unit-tests, 6Release-Engineering-Team: 30% of QUnit tests fail on 1.27.0-wmf.12 branch when proposing a VE submodule dump - https://phabricator.wikimedia.org/T125655#1994106 (10hashar) 5Resolved>3Open Yeah the Wikidata bump might have fixed it. There is still a racy test goin... [15:51:52] MatmaRex: it wasn't happening on mobile though. [15:52:04] 10VisualEditor, 10MediaWiki-Unit-tests, 6Release-Engineering-Team: 30% of QUnit tests fail on 1.27.0-wmf.12 branch when proposing a VE submodule dump - https://phabricator.wikimedia.org/T125655#1994110 (10Paladox) Should add the wikibase project since the errors says wikibase is the problem. [15:52:14] Elitre: right, that's not happening on mobile. [15:52:19] (03PS1) 10Krinkle: Fix "Uncaught TypeError: $.cookie is not a function" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/268134 [15:52:26] it's mobile stuff appearing on desktop. [15:52:30] Krenair: I;m getting it on al pages [15:52:49] I see tasks were merged... [15:52:51] maybe I have something else that's loading it already... [15:52:59] Can't enable VE. And if I enable manually and visit action=edit i just get a blank page with a half loaden blue progress bar and then the same exception [15:53:16] Krenair: https://gerrit.wikimedia.org/r/#/c/268134/ [15:54:43] (03CR) 10Alex Monk: [C: 032] Fix "Uncaught TypeError: $.cookie is not a function" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/268134 (owner: 10Krinkle) [15:55:51] Krenair: Hm.. so just to double check. Previously I could use VE on Meta by clicking the "other" Edit tab (not Edit source). This is now gone and its wikitext by default again. [15:56:04] That is intentional? (Until we change defaults or roll out things further) [15:56:07] 10VisualEditor, 10MediaWiki-Unit-tests, 6Release-Engineering-Team: QUnit tests fail on 1.27.0-wmf.12 branch - https://phabricator.wikimedia.org/T125655#1994114 (10hashar) [15:56:20] Krinkle, nothing has changed on meta [15:56:47] Right [15:56:53] User page [15:56:56] and wasn't there [15:56:57] nvm [15:57:12] I still see Edit/Edit source on mw.org as well [15:57:12] ok [15:58:34] I like the new smooth transition. Not sure how recent, but when switching to Edit from read mode, it very smoothly transitions in and leaves the page title in place without any jumps [15:58:55] (toolbar) [16:01:35] (03CR) 10Alex Monk: "> On wikis where VE is default, this causes the Edit page to be empty by default [...]" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/259771 (https://phabricator.wikimedia.org/T121257) (owner: 10Alex Monk) [16:01:50] (03CR) 10Alex Monk: "When we*" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/259771 (https://phabricator.wikimedia.org/T121257) (owner: 10Alex Monk) [16:07:21] 10VisualEditor, 10MediaWiki-Unit-tests, 6Release-Engineering-Team: QUnit tests fail on 1.27.0-wmf.12 branch - https://phabricator.wikimedia.org/T125655#1994126 (10hashar) The qunit reports a failure to get zh mediawiki.language.data and mediawiki.language over the API: ``` [proxy]: failed to proxy /jenk... [16:07:59] (03Merged) 10jenkins-bot: Fix "Uncaught TypeError: $.cookie is not a function" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/268134 (owner: 10Krinkle) [16:08:20] (03PS9) 10Krinkle: SET: Set user's editor to wikitext if the browser doesn't do JS [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/259771 (https://phabricator.wikimedia.org/T121257) (owner: 10Alex Monk) [16:08:48] cscott: Hey, just getting back to you on togetherJs' ckeditor integration. it turns out togetherJS' ckeditor tracker is a simple setHTML, atm. They will probably add a proper tracker when ckeditor 5 with change tracking capabilities is released. [16:12:16] 10VisualEditor, 10MediaWiki-Unit-tests, 6Release-Engineering-Team: QUnit tests fail on 1.27.0-wmf.12 branch - https://phabricator.wikimedia.org/T125655#1994143 (10hashar) [16:12:17] (03CR) 10Krinkle: "When disabling JavaSCript, It seems this is setting cookie 'VEE=wikitext' instead of 'VEE' and something else is also setting a 'V" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/259771 (https://phabricator.wikimedia.org/T121257) (owner: 10Alex Monk) [16:13:00] Krenair: This is general SET review from my perspective, whether new in this change or not. [16:13:14] I can file them as subtasks of something if there is a tracker [16:13:59] 10VisualEditor, 10MediaWiki-Unit-tests, 6Release-Engineering-Team: QUnit tests fail on 1.27.0-wmf.12 branch - https://phabricator.wikimedia.org/T125655#1994160 (10JanZerebecki) 5Open>3Resolved Yea this happened because the fixes for T117886 weren't in that branch yet, because of T125663. I think the erro... [16:14:17] Krinkle, it'll need to be a separate task rather than a CR-1 on a randomly chosen commit in gerrit [16:23:52] 10VisualEditor, 10VisualEditor-MediaWiki: VisualEditor Single-edit-tab breaks certain Edit page semantics - https://phabricator.wikimedia.org/T125670#1994207 (10Krinkle) 3NEW [16:24:42] (03CR) 10Krinkle: "Filed T125670 for unrelated regressions. Main thing remaining here is the VEE cookie mixup. The new PHP code should probably disable the c" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/259771 (https://phabricator.wikimedia.org/T121257) (owner: 10Alex Monk) [16:48:32] (03PS3) 10DLynch: Remove uses of plain .contentEditable [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/266265 (https://phabricator.wikimedia.org/T116214) [16:54:12] (03CR) 10jenkins-bot: [V: 04-1] Remove uses of plain .contentEditable [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/266265 (https://phabricator.wikimedia.org/T116214) (owner: 10DLynch) [16:54:46] Oh, right, keep forgetting to test building the docs before I push these things. [16:57:52] (03CR) 10Esanders: [C: 04-1] "The item is the dropdown is always disabled for me." [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/268131 (owner: 10DLynch) [16:58:23] (03CR) 10Esanders: "...until I reload the page" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/268131 (owner: 10DLynch) [17:00:41] (03CR) 10Esanders: VE demo: allow saving some markup to localStorage for testing (032 comments) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/268131 (owner: 10DLynch) [17:00:59] 10VisualEditor, 10MediaWiki-Unit-tests, 6Release-Engineering-Team: QUnit tests fail on 1.27.0-wmf.12 branch - https://phabricator.wikimedia.org/T125655#1994366 (10hashar) Thank @JanZerebecki for the clarification. [17:02:31] I put some updates about Phase 6.1 wikis on https://office.wikimedia.org/w/index.php?type=revision&diff=172376&oldid=172267 . [17:02:37] (03CR) 10Esanders: VE demo: allow saving some markup to localStorage for testing (031 comment) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/268131 (owner: 10DLynch) [17:05:53] (03PS4) 10DLynch: Remove uses of plain .contentEditable [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/266265 (https://phabricator.wikimedia.org/T116214) [17:12:57] (03CR) 10DLynch: VE demo: allow saving some markup to localStorage for testing (031 comment) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/268131 (owner: 10DLynch) [17:17:21] (03PS1) 10Zfilipin: Update mediawiki_selenium Ruby gem to version 1.6.5 [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/268166 (https://phabricator.wikimedia.org/T125532) [17:18:38] (03PS2) 10DLynch: VE demo: allow saving some markup to localStorage for testing [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/268131 [17:33:33] 10VisualEditor, 10VisualEditor-ContentEditable: Cannot move cursor left past nail at the end of styled text unless using the mouse to move the cursor first - https://phabricator.wikimedia.org/T123430#1994542 (10DLynch) Note also that after triggering this, if you click to move the cursor you get: ``` Error: N... [17:38:59] (03CR) 10Dduvall: [C: 032] Update mediawiki_selenium Ruby gem to version 1.6.5 [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/268166 (https://phabricator.wikimedia.org/T125532) (owner: 10Zfilipin) [17:43:48] 10VisualEditor: Loss of edits due to accidental click to leave page - https://phabricator.wikimedia.org/T125679#1994582 (10Jdlrobson) 3NEW [17:52:47] 10VisualEditor, 6Editing-Department, 10MobileFrontend, 7Mobile, 5Patch-For-Review: Enable editing for mobile users without JavaScript and kill Special:MobileEditor code in MobileFrontend - https://phabricator.wikimedia.org/T125174#1994650 (10Jdlrobson) [17:53:11] 10VisualEditor, 6Editing-Department, 10MobileFrontend, 7Mobile, 5Patch-For-Review: Enable editing for mobile users without JavaScript and kill Special:MobileEditor code in MobileFrontend - https://phabricator.wikimedia.org/T125174#1980463 (10Jdlrobson) [17:56:45] 10VisualEditor, 6Editing-Department, 10MobileFrontend, 7Mobile, 5Patch-For-Review: Enable editing for mobile users without JavaScript and kill Special:MobileEditor code in MobileFrontend - https://phabricator.wikimedia.org/T125174#1994665 (10Jdlrobson) This could do with some input - @nirzar any interest... [17:56:57] 10VisualEditor, 6Editing-Department, 10MobileFrontend, 7Mobile: Enable editing for mobile users without JavaScript and kill Special:MobileEditor code in MobileFrontend - https://phabricator.wikimedia.org/T125174#1994669 (10Jdlrobson) [17:59:43] (03Merged) 10jenkins-bot: Update mediawiki_selenium Ruby gem to version 1.6.5 [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/268166 (https://phabricator.wikimedia.org/T125532) (owner: 10Zfilipin) [18:02:36] 10VisualEditor, 10QuickSurveys: VisualEditor 1.25: QuickSurveys breaks (is incompatible) with VisualEditor on mediawiki-1.25.3 - https://phabricator.wikimedia.org/T125534#1994686 (10Jpagliaccio) JD: I get this in Chrome console message in red: http://wiki.aerco.com/mw/load.php?debug=false&lang=en&modules=sta... [18:05:40] (03CR) 10Esanders: wikipage.content hook: Wait until content is visible [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/268068 (https://phabricator.wikimedia.org/T125263) (owner: 10Esanders) [18:10:42] (03CR) 10Esanders: [C: 04-1] VE demo: allow saving some markup to localStorage for testing (031 comment) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/268131 (owner: 10DLynch) [18:12:38] (03CR) 10DLynch: VE demo: allow saving some markup to localStorage for testing (031 comment) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/268131 (owner: 10DLynch) [18:14:32] (03PS3) 10DLynch: VE demo: allow saving some markup to localStorage for testing [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/268131 [18:20:27] (03CR) 10Esanders: [C: 032] VE demo: allow saving some markup to localStorage for testing [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/268131 (owner: 10DLynch) [18:21:05] (03CR) 10Esanders: [C: 04-2] VE demo: allow saving some markup to localStorage for testing [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/268131 (owner: 10DLynch) [18:21:35] (03CR) 10Esanders: [C: 04-1] "If I hit 'save page' in 'Edit HTML' mode I get an exception" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/268131 (owner: 10DLynch) [18:21:42] Emotional ups and downs, here. [18:27:42] (03PS4) 10DLynch: VE demo: allow saving some markup to localStorage for testing [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/268131 [18:51:09] (03CR) 10Esanders: [C: 032] VE demo: allow saving some markup to localStorage for testing [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/268131 (owner: 10DLynch) [18:53:18] 10VisualEditor, 10Wikimedia-Site-Requests, 7user-notice: Enable VisualEditor by default for all users of all "phase 6" Wikipedias - https://phabricator.wikimedia.org/T93387#1994929 (10Jdforrester-WMF) [18:57:02] (03Merged) 10jenkins-bot: VE demo: allow saving some markup to localStorage for testing [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/268131 (owner: 10DLynch) [19:14:30] Kemayo: :-) [19:22:20] James_F, does the VE-MW test suite run with Cite I assume? [19:22:32] edsanders: Yeah. [19:22:34] (otherwise tests will start failing after the separation) [19:25:25] James_F, did you test those commits at all? or should I expect exceptions? [19:29:05] edsanders: I tested them a long time ago; they may now be broken. I didn't test with my last rebase. [19:29:12] ok [19:32:05] (03PS1) 10Esanders: Update name of VE cite module [extensions/Citoid] - 10https://gerrit.wikimedia.org/r/268194 [19:33:16] (03CR) 10jenkins-bot: [V: 04-1] Update name of VE cite module [extensions/Citoid] - 10https://gerrit.wikimedia.org/r/268194 (owner: 10Esanders) [19:39:46] 10VisualEditor, 10VisualEditor-EditingTools, 7Design: VisualEditor: Consider whether exiting the link dialog in create mode should remove the link - https://phabricator.wikimedia.org/T71407#1995155 (10Elitre) Not sure if I'm adding further confusion :) (and I think this task didn't keep T101176 into account... [19:46:01] 10VisualEditor, 10VisualEditor-Tables, 10Parsoid: Deleting a colspan column breaks the table layout failing to adjust the rowspan (also leaving an extra empty row) - https://phabricator.wikimedia.org/T125703#1995194 (10Whatamidoing-WMF) 3NEW [19:49:35] James_F, "MessageDirs" isn't working for me [19:49:52] In Cite? [19:51:31] ah I think you used the wrong format [19:51:35] it's a keyed object, not a list [19:51:39] fixed [19:52:42] Hmm. [19:52:57] (03PS4) 10Esanders: Remove all Extension:Cite code, now moved there [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/254082 (owner: 10Jforrester) [19:53:05] (03PS2) 10Esanders: Update name of VE cite module [extensions/Citoid] - 10https://gerrit.wikimedia.org/r/268194 [19:53:22] Oh, oops. [19:53:27] (03CR) 10jenkins-bot: [V: 04-1] Remove all Extension:Cite code, now moved there [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/254082 (owner: 10Jforrester) [19:53:38] (03CR) 10jenkins-bot: [V: 04-1] Update name of VE cite module [extensions/Citoid] - 10https://gerrit.wikimedia.org/r/268194 (owner: 10Esanders) [20:01:24] 10VisualEditor: When switching between the wikitext and visual editors, the "Discard changes" option should require confirmation before losing all my work - https://phabricator.wikimedia.org/T123960#1995266 (10Whatamidoing-WMF) James, do you really mean that if I //accidentally// click "discard two hours of work... [20:03:51] I'm looking at the source code for a webpage, and I wonder if "" is the bit which tells Citoid which kind of content that is, and therefore which template should be used for it? [20:04:20] Elitre: It depends on the website (or, rather, on the 'translator' in Zotero that Citoid uses), but possible. [20:11:54] (03CR) 10Jforrester: [C: 031] wikipage.content hook: Wait until content is visible [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/268068 (https://phabricator.wikimedia.org/T125263) (owner: 10Esanders) [21:02:23] (03PS3) 10Esanders: Updates after move of ve-cite module [extensions/Citoid] - 10https://gerrit.wikimedia.org/r/268194 [21:04:00] James_F|Away, got it working again [21:04:33] *-again [21:05:10] (03CR) 10jenkins-bot: [V: 04-1] Updates after move of ve-cite module [extensions/Citoid] - 10https://gerrit.wikimedia.org/r/268194 (owner: 10Esanders) [21:28:36] 10VisualEditor, 10WikiEditor, 10ArchCom-RfC, 6Editing-Department, and 3 others: RFC: MediaWiki should provide a pluggable registry for editor interfaces - https://phabricator.wikimedia.org/T120414#1995530 (10Krinkle) [21:37:22] 10VisualEditor, 10VisualEditor-ContentEditable: Cannot move cursor left past nail at the end of styled text unless using the mouse to move the cursor first - https://phabricator.wikimedia.org/T123430#1995587 (10dchan) a:3dchan This is a regression introduced in 05c0293f0525c180c7d4820ddd8ca5f0176b8d08 . In v... [21:51:00] (03CR) 10Krinkle: [C: 04-1] "This explicitly violates the expectation from the wikipage.content hook. This sounds like a bug in the maps extension instead." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/268068 (https://phabricator.wikimedia.org/T125263) (owner: 10Esanders) [21:52:12] 10VisualEditor, 10ContentTranslation-cxserver, 10Parsoid, 10RESTBase, and 2 others: Remove user name and edit comment from html - https://phabricator.wikimedia.org/T125266#1995671 (10bearND) The Mobile-Content-Service does not use this information nor does it propagate it. [21:52:42] 10VisualEditor, 10ContentTranslation-cxserver, 10Parsoid, 10RESTBase, 10Reading-Web: Remove user name and edit comment from html - https://phabricator.wikimedia.org/T125266#1995672 (10bearND) [21:54:51] 10VisualEditor, 10VisualEditor-MediaWiki-Media: Visual Editor removes some media properties - https://phabricator.wikimedia.org/T125718#1995674 (10Krenair) [21:54:59] 10VisualEditor, 10VisualEditor-MediaWiki, 10VisualEditor-MediaWiki-Media: Visual Editor removes some media properties - https://phabricator.wikimedia.org/T125718#1995677 (10Krenair) [21:58:14] 10VisualEditor, 10VisualEditor-MediaWiki, 10VisualEditor-MediaWiki-Media: Visual Editor removes some media properties - https://phabricator.wikimedia.org/T125718#1995687 (10Rezonansowy) My suggested solution is that VE should not touch things it doesn't understands, like these for example. [22:23:11] (03PS1) 10Divec: After KeyDown, call checkUnicorns before polling the surfaceObserver [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/268305 (https://phabricator.wikimedia.org/T123430) [22:26:43] (03CR) 10Esanders: "Where is it documented? The first page load hook fires on visible content and many users may require the content to be visible. In this ca" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/268068 (https://phabricator.wikimedia.org/T125263) (owner: 10Esanders) [22:33:40] (03CR) 10Krinkle: "The hook is documented at https://doc.wikimedia.org/mediawiki-core/master/js/#!/api/mw.hook-event-wikipage_content / https://github.com/wi" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/268068 (https://phabricator.wikimedia.org/T125263) (owner: 10Esanders) [22:46:50] Krinkle, thx for the comment on the patch. In case you need to experiment with the maps, try http://vem3.wmflabs.org/wiki/Main_Page [22:47:43] yurik: I hope my comment is enough to fix it in the extension. [22:48:49] Krinkle, tell you the truth, i don't know enough front end stuff for it to be useful right away - I would have to learn much more. edsanders|away has done an amazing job helping us build the VE front end for maps [22:49:33] (03CR) 10Krinkle: [C: 04-1] "It's failing because one of the validation steps in parse() is to call getJSONForDatabase() and check the length." [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/266661 (owner: 10Cenarium) [22:50:31] yurik: Sure.. In that case I suppose he could apply a similar patch to Maps instead. [22:50:39] Whoever is responsible for it. [22:50:48] or .. it's frontend. [22:51:04] :)) [22:56:49] 10VisualEditor, 10Phlogiston, 15User-JAufrecht: Figure out what the unlabeled white data factor is in VE Completed work graph. - https://phabricator.wikimedia.org/T124950#1995964 (10JAufrecht) 5Open>3Resolved It was "other" - now that zoom-list is used differently, this appears to be getting labeled corr... [22:59:37] (03PS1) 10Jforrester: IME tests: Add failing Korean IME test [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/268316 (https://phabricator.wikimedia.org/T120156) [23:00:30] (03PS5) 10Krinkle: TemplateDataBlob: Avoid encoding and compressing json twice [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/266661 (owner: 10Cenarium) [23:02:39] 10VisualEditor, 10Phlogiston, 15User-JAufrecht: Figure out how to handle old tranches in reporting - https://phabricator.wikimedia.org/T123422#1995992 (10JAufrecht) 5Open>3Resolved With the change to zoom lists, it's probably enough now to mark it false on the recategorization zoom list. It will be hidd... [23:06:48] (03CR) 10jenkins-bot: [V: 04-1] IME tests: Add failing Korean IME test [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/268316 (https://phabricator.wikimedia.org/T120156) (owner: 10Jforrester) [23:07:40] (03CR) 10Jforrester: "This is, as the title and Jenkins note, just a failing test at this point. AFAICT it's one of the last blockers to enabling on Korean. Fun" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/268316 (https://phabricator.wikimedia.org/T120156) (owner: 10Jforrester) [23:08:36] 10VisualEditor, 10VisualEditor-ContentLanguage: Cannot type in Korean using Mozilla on Windows 7 with dual-script keyboard - https://phabricator.wikimedia.org/T72353#1996013 (10Jdforrester-WMF) >>! In T72353#1864840, @revi wrote: > Nope., It's still happening, in different form now. I think that's the same as... [23:11:02] (03CR) 10Krinkle: [C: 031] TemplateDataBlob: Avoid encoding and compressing json twice [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/266661 (owner: 10Cenarium) [23:15:05] (03PS1) 10Paladox: Fix "Uncaught TypeError: $.cookie is not a function" [extensions/VisualEditor] (wmf/1.27.0-wmf.12) - 10https://gerrit.wikimedia.org/r/268318 [23:16:47] (03CR) 10Jforrester: [C: 031] "Hmm. I thought this would have made the cut, but I was off by a day. :-)" [extensions/VisualEditor] (wmf/1.27.0-wmf.12) - 10https://gerrit.wikimedia.org/r/268318 (owner: 10Paladox) [23:17:23] (03CR) 10Esanders: "The map container has dimensions at the time of the hook firing so the problem is deeper. I don't think it's unreasonable for users to wan" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/268068 (https://phabricator.wikimedia.org/T125263) (owner: 10Esanders) [23:49:59] 10VisualEditor, 10VisualEditor-Tables, 10Parsoid: Deleting a colspan column breaks the table layout failing to adjust the rowspan (also leaving an extra empty row) - https://phabricator.wikimedia.org/T125703#1996323 (10ssastry) This looks like a VE issue to me. Parsoid won't add the rowspan=2 attribute unila...