[00:04:50] (03CR) 10Jforrester: Localisation updates from https://translatewiki.net. (031 comment) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/268294 (owner: 10L10n-bot) [01:22:58] (03PS10) 10Alex Monk: SET: Set user's editor to wikitext if the browser doesn't do JS [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/259771 (https://phabricator.wikimedia.org/T121257) [01:26:22] (03CR) 10Bartosz Dziewoński: [C: 032] update-oojs-ui: Don't copy across oojs-ui.js, we don't use that [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/268014 (owner: 10Jforrester) [01:31:48] (03Merged) 10jenkins-bot: update-oojs-ui: Don't copy across oojs-ui.js, we don't use that [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/268014 (owner: 10Jforrester) [05:49:49] (03CR) 10Ferdbold: "This seems to have created a visual issue on templates, graphs and transclusions (possibly even more)" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/266774 (owner: 10Esanders) [06:26:16] (03CR) 10DLynch: After KeyDown, call checkUnicorns before polling the surfaceObserver (031 comment) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/268305 (https://phabricator.wikimedia.org/T123430) (owner: 10Divec) [07:41:49] 10VisualEditor, 10VisualEditor-MediaWiki, 10VisualEditor-MediaWiki-Media, 6Multimedia, and 3 others: Give guidance in the new upload form, to prevent the most common errors - e.g. bad file titles - https://phabricator.wikimedia.org/T116086#1996664 (10Prtksxna) [07:49:18] 10VisualEditor: FocusableNode invisibles produces weird results with graphs - https://phabricator.wikimedia.org/T125767#1996836 (10ferdbold) 3NEW [07:49:18] 10VisualEditor: FocusableNode invisibles produces weird results with graph, templates and transclusions - https://phabricator.wikimedia.org/T125767#1996842 (10ferdbold) [07:50:15] 10VisualEditor: FocusableNode invisibles produces weird results with graph, templates and transclusions - https://phabricator.wikimedia.org/T125767#1996836 (10ferdbold) [08:21:24] 10VisualEditor, 10Graph: Clicking "edit" for a graph of unsupported type crashes VisualEditor - https://phabricator.wikimedia.org/T125761#1996694 (10Yair_rand) 3NEW [08:59:40] 10VisualEditor: Section 'Edit source' link appears messy - https://phabricator.wikimedia.org/T125764#1996797 (10KartikMistry) 3NEW [09:01:25] 10VisualEditor: Section 'Edit source' link appears messy - https://phabricator.wikimedia.org/T125764#1996805 (10KartikMistry) [09:17:31] 10VisualEditor, 10MediaWiki-General-or-Unknown: mw.widgets.TitleWidget doesn't do language fallback for Wikidata descriptions - https://phabricator.wikimedia.org/T125763#1996748 (10Jdforrester-WMF) 3NEW [09:31:59] 10Cite: Zero-width joiner before references on Wikipedia - https://phabricator.wikimedia.org/T125480#1997116 (10Obsuser) Archived for year 2344 obviously. :) [09:45:43] 10VisualEditor: Section 'Edit source' link appears messy - https://phabricator.wikimedia.org/T125764#1997137 (10Sjoerddebruin) [11:18:14] 10Cite: Zero-width joiner before references on Wikipedia - https://phabricator.wikimedia.org/T125480#1997331 (10Fomafix) >>! In T125480#1992511, @Graham87 wrote: >> Does your screen reader include such CSS generated content? > Nope. Ok, then this CSS rule does not affect screen readers and the solution does not... [12:13:42] 10Citoid, 6Community-Liaison, 6Developer-Relations: Tech Talk with Sebastian K. (Zotero) - https://phabricator.wikimedia.org/T125796#1997513 (10Elitre) [12:18:06] (03CR) 10Esanders: [C: 031] Updates after move of ve-cite module [extensions/Citoid] - 10https://gerrit.wikimedia.org/r/268194 (owner: 10Esanders) [12:18:29] (03CR) 10Esanders: [C: 031] Remove all Extension:Cite code, now moved there [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/254082 (owner: 10Jforrester) [12:18:59] (03CR) 10Esanders: "Let's get this merged before it starts conflicting again." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/254082 (owner: 10Jforrester) [12:50:59] 10VisualEditor, 10VisualEditor-MediaWiki: Occassional "docserver-http: HTTP 404" when trying to save an edit made in Visual Editor - https://phabricator.wikimedia.org/T123708#1997568 (10Elitre) @Mbch331, every details is useful and welcome. Thanks. [12:51:21] 10VisualEditor, 10VisualEditor-MediaWiki: Occasional "docserver-http: HTTP 404" when trying to save an edit made in the visual editor - https://phabricator.wikimedia.org/T123708#1997569 (10Elitre) [13:19:25] (03CR) 10Siebrand: [C: 031] "i18n/L10n reviewed." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/254082 (owner: 10Jforrester) [13:33:29] (03CR) 10Hashar: [C: 031] "Seems we have jquery.cookie loaded on production and this patch is not any urgent isn't it ? If it was it would have been deployed on spo" [extensions/VisualEditor] (wmf/1.27.0-wmf.12) - 10https://gerrit.wikimedia.org/r/268318 (owner: 10Paladox) [13:55:40] 10VisualEditor, 10VisualEditor-MediaWiki: Occasional "docserver-http: HTTP 404" when trying to save an edit made in the visual editor - https://phabricator.wikimedia.org/T123708#1997759 (10Mbch331) Error occured February 2nd, 22:20 CET while trying to edit [[ //nl.wikipedia.org/wiki/Guy_Bleyaert ]]. I edited... [16:31:11] edsanders: I suppose I should put a commit under https://gerrit.wikimedia.org/r/#/c/254082/ which conditionally loads ext.visualEditor.mwreference if ext.cite.visualEditor isn't loaded? [16:31:45] edsanders: Then merge that, then https://gerrit.wikimedia.org/r/#/c/254041/ and then https://gerrit.wikimedia.org/r/#/c/254082/ [16:32:01] edsanders: Yes? [16:33:17] er [16:33:28] if you need hacks to get CI to work then sure [16:33:40] Kk. [16:33:41] then only thing you need after is the alias I made [16:34:00] Alias? [16:34:17] Oh, in Citoid? [16:34:17] in cite [16:34:34] line 144 https://gerrit.wikimedia.org/r/#/c/254041/10/extension.json [16:34:35] no Cite [16:34:53] Hmm. [16:35:05] OK, that's odd. [16:35:10] Theoretically that should make it Just Work™. [16:35:20] that was the plan [16:35:39] Oh, but it'll still get double-loaded. [16:36:28] there's also a jshint about the target: label [16:36:33] shall I fix? [16:36:49] I'll do it. [16:37:01] rename the label to targetLoop or something [16:37:22] there's an identical label in Citoid too [16:37:38] CiteFromIdInspectorTool [16:37:44] OK. [16:38:10] we should separate that into an init file after [16:38:45] and come up with a toolbar API that lets us do that properly [16:38:59] * James_F nods. [16:39:01] There's a task in OOUI to do that. [16:39:16] Also have the toolbar dynamically re-size based on available width. [16:39:19] Feel up to the challenge? [16:40:09] I don't know how we'll let people define position [16:40:26] Yeah. [16:40:26] Don't want to hard-code it too much. [16:40:47] Maybe VE could provide an EditorToolbar with pre-defined groups and you have to pick a group or add a new one, which goes at the end. [16:41:40] well at the moment we have history - format - textStyle - link - indent - insert [16:41:55] and cite is between link and indent [16:42:09] Yeah, and Cite wants to insert next to link. [16:42:14] arguably textStyle and link are grouped together [16:42:27] s/indent/structure [16:42:46] Except they're explicitly not grouped. [16:43:22] not yet [16:43:39] No, I mean, we intentionally ungrouped them. [16:43:39] so we should think where in that list we'd allow people to insert stuff [16:43:57] we did - but I don't think you'd want them to be not next to each other [16:44:01] By default everything just goes into the 'other' bucket, which we currently label 'insert'. [16:44:16] Yeah, but it also looks odd for it to be conjoined to the style group. [16:44:48] the other option is to make an empty bucket after link and give it a suitable name [16:45:18] (I'm not talking OOUI bordered 'group' but the conceptual grouping we are aiming for) [16:45:35] * James_F nods. [16:45:38] then everything to the left of link is untouchable [16:45:59] Hard-coding that feels icky [16:45:59] Look at Flow's toolbar, for instance. [16:45:59] at the root level [16:46:14] well you can still remove items [16:46:21] Ideally that'd be a sub-class of ours with different styling and visual behaviour, not a re-implementation as it is now. [16:46:33] And empty groups get collapsed? Hmm. [16:46:33] or sub class the whole thing and do your own order [16:46:50] I'm talking about where extensions can insert themselves [16:46:56] Yeah. [16:47:10] yeah, empty groups are collapsed (or at least they should be) [16:47:24] But if Flow sub-classes and changes how registration happens then they'd have to adjust for every extension. [16:47:39] Whereas we want the burden to be light, but fall on extension authors' heads. [16:47:54] if we had a group call 'promotedExtensions' after link [16:48:15] then Flow would just have to include that group [16:52:18] Hmm. Feels hacky [16:56:22] the alternatives are: [16:56:45] specifying which group to go before/after (status quo) but this breaks if the upstream groups change [16:56:55] * James_F nods. [16:57:01] specifying a numerical ident - same problem as above [16:57:07] Can we have meta-groups? [16:57:26] "primary" and "additional"? [16:57:26] ? [16:57:36] And VE has format, style, link and cite in "primary". [16:58:16] right [16:58:23] but you can only push to the end of the queue? [16:58:44] So [ history: […], primary: { format: […], style: […], link: […], cite: […], }, additional: { structure: […], other: […] } ] [16:58:46] Or something. [16:58:52] Yeah, maybe. [16:58:52] that's the same as 'promotedExtensions' but named differently [16:58:55] so yes [16:58:57] :-) [16:59:40] but basically two allowed insertion points: after link and specialChar [17:01:47] edsanders: However… [17:01:48] Extension load order is not guaranteed. [17:01:50] (Right now it's an accident of the order of LocalSettings.php, but in future even that will go with everything switching to extension.json loading.) [17:01:56] It'd suck if multiple extensions register primary buttons, and their order rotates at random. [17:02:28] Also, is specialChar not meant to be guaranteed-last (opposite of history)? So it'd be before specialChar or after link? [17:03:28] nor particularly [17:03:42] TBH we don't really have much room for people to be adding to the root [17:08:58] Well, if the toolbar magically expands and contracts to fill the space we can be more relaxed about that. [17:09:07] (Though not entirely.) [17:11:42] (03CR) 10Jforrester: [C: 032] "Per Ed." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/254082 (owner: 10Jforrester) [17:11:49] 10VisualEditor, 10VisualEditor-EditingTools: Make VE "your signature" button more visible on non-Flow talkpages - https://phabricator.wikimedia.org/T125839#1998482 (10Wittylama) 3NEW [17:12:11] (03CR) 10jenkins-bot: [V: 04-1] Remove all Extension:Cite code, now moved there [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/254082 (owner: 10Jforrester) [17:13:56] 10VisualEditor, 10VisualEditor-EditingTools: Make VE "your signature" button more visible on non-Flow talkpages - https://phabricator.wikimedia.org/T125839#1998505 (10Esanders) You can also just type four tildes to trigger the tool [17:19:45] James_F: My wmbug.com domain () is expiring in a few months. [17:20:00] I don't plan on extending it unless someone feels it's useful [17:20:38] (03PS5) 10Jforrester: Remove all Extension:Cite code, now moved there [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/254082 [17:22:05] Krinkle: Fine by me. [17:22:16] (03CR) 10Jforrester: [C: 032] "PS5 is a rebase; +2 per Ed." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/254082 (owner: 10Jforrester) [17:24:57] (03CR) 10jenkins-bot: [V: 04-1] Remove all Extension:Cite code, now moved there [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/254082 (owner: 10Jforrester) [17:25:42] Eurgh. [17:28:23] edsanders: Help? ^^^ [17:29:17] 'Unknown node type: mwReference' [17:29:48] you need to merge Cite first (without VisualEditorPluginModules) [17:30:02] then merge VE [17:30:08] er wait [17:30:44] you definitely need the files in Cite [17:31:16] but somehow only auto-loading after VE gets updated [17:31:43] 10VisualEditor, 10VisualEditor-MediaWiki, 10MediaWiki-General-or-Unknown, 5Patch-For-Review: Feedback tool gives wrong target for page link when it's cross-wiki - https://phabricator.wikimedia.org/T125400#1998584 (10Elitre) There are 2 issues I'm seeing, 1) the link inside the internal feedback tool everyw... [17:46:29] edsanders: The one in Cite /is/ merged. [17:46:36] oh [17:49:12] edsanders: Yeah. Is CI not doing the merge order correctly? [17:49:59] edsanders: fyi, node 4 support has landed in mw-vagrant, so you should be able to use all nodejs services there with no pb [17:50:16] mobrovac: Yeah, I saw – thank you. :-) [18:04:20] (03CR) 10Krinkle: "Hashar: It doesn't work like that. Not a single module (other than jquery core) is "loaded" in production or anywhere else. Things are enq" [extensions/VisualEditor] (wmf/1.27.0-wmf.12) - 10https://gerrit.wikimedia.org/r/268318 (owner: 10Paladox) [18:04:22] 10VisualEditor: Feedback at enwiki should not go to mediawiki.org - https://phabricator.wikimedia.org/T125850#1998786 (10Whatamidoing-WMF) 3NEW [18:20:37] edsanders: Hmm. [18:21:13] (03CR) 10Krinkle: "Focus doesn't apply to page content since the page is owned by the skin, which has its own autofocus areas." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/268068 (https://phabricator.wikimedia.org/T125263) (owner: 10Esanders) [18:22:13] So, on Cite master/VE-MW master, VE loads fine, using its old Cite code; the new Cite code is loaded but not working it appears. [18:23:34] 10VisualEditor, 5Patch-For-Review: FocusableNode invisibles produces weird results with graph, templates and transclusions - https://phabricator.wikimedia.org/T125767#1998990 (10DLynch) Glancing at this happening to Math, briefly, it seems like the issue is that when `this.hasRendering()` is checked, the math... [18:23:52] One Cite master/VE-MW 254082 everything looks like it works fine. [18:25:29] edsanders: Stupid uni network won't let me pull changes from gerrit, I can, [18:25:36] I can't test out your change* [18:25:38] Aha. The Citoid patch needs to land. [18:26:09] edsanders: I think it'd be better if we could fix the hasRendering check, rather than having to update every extension. [18:27:07] (03PS4) 10Jforrester: Updates after move of ve-cite module [extensions/Citoid] - 10https://gerrit.wikimedia.org/r/268194 (owner: 10Esanders) [18:27:19] (03CR) 10Esanders: "The problem with adding a setTimeout to the maps extension is that it depends on the particular case of VE appending the DOM in the same c" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/268068 (https://phabricator.wikimedia.org/T125263) (owner: 10Esanders) [18:28:15] Kemayo: If we whitelist some node types (as you said on Phab), wouldn't it come down to having to update all those extensions anyway? [18:28:24] (03PS5) 10Jforrester: Updates after move of ve-cite module [extensions/Citoid] - 10https://gerrit.wikimedia.org/r/268194 (owner: 10Esanders) [18:28:31] (03CR) 10Jforrester: [C: 032] Updates after move of ve-cite module [extensions/Citoid] - 10https://gerrit.wikimedia.org/r/268194 (owner: 10Esanders) [18:29:52] (03CR) 10jenkins-bot: [V: 04-1] Updates after move of ve-cite module [extensions/Citoid] - 10https://gerrit.wikimedia.org/r/268194 (owner: 10Esanders) [18:30:25] ferdbold: Not really, what I meant was that we could update the FocusableNode hasRendering check to think that, say, is always visible. [18:31:58] Kemayo: Ah. I wonder though if other tags could cause issues. Do we have weird extensions that put things like iframes or canvases in nodes? [18:33:05] (Besides graphs I mean. Graph needs to be able to render canvases in VE right now, though it's in the roadmap to have it render instead) [18:35:15] (03PS6) 10Jforrester: Updates after move of ve-cite module [extensions/Citoid] - 10https://gerrit.wikimedia.org/r/268194 (owner: 10Esanders) [18:35:47] (03PS6) 10Jforrester: Remove all Extension:Cite code, now moved there [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/254082 [18:37:20] (03CR) 10jenkins-bot: [V: 04-1] Updates after move of ve-cite module [extensions/Citoid] - 10https://gerrit.wikimedia.org/r/268194 (owner: 10Esanders) [18:38:14] (03CR) 10Jforrester: "recheck" [extensions/Citoid] - 10https://gerrit.wikimedia.org/r/268194 (owner: 10Esanders) [18:41:41] (03CR) 10jenkins-bot: [V: 04-1] Remove all Extension:Cite code, now moved there [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/254082 (owner: 10Jforrester) [18:42:04] (03PS1) 10DLynch: Don't just rely on jQuery width / height for hasRendering [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/268437 (https://phabricator.wikimedia.org/T125767) [18:42:08] (03CR) 10Jforrester: [C: 032] Updates after move of ve-cite module [extensions/Citoid] - 10https://gerrit.wikimedia.org/r/268194 (owner: 10Esanders) [18:42:52] ferdbold: That patch there fixes up the math extension case, at least. I need to get graph installed on my VM. [18:43:07] Going with the "don't just trust jquery" approach. :D [18:44:23] (03Merged) 10jenkins-bot: Updates after move of ve-cite module [extensions/Citoid] - 10https://gerrit.wikimedia.org/r/268194 (owner: 10Esanders) [18:44:36] (03CR) 10Krinkle: "That's the same as this patch does. If/when such a hook exists, it can be called I suppose." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/268068 (https://phabricator.wikimedia.org/T125263) (owner: 10Esanders) [18:44:38] (03CR) 10Jforrester: "recheck" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/254082 (owner: 10Jforrester) [18:45:28] 10Cite, 10VisualEditor, 10VisualEditor-MediaWiki, 10VisualEditor-MediaWiki-Plugins, and 4 others: Refactor VisualEditor editing plugin for Cite back into the Cite extension - https://phabricator.wikimedia.org/T41621#1999119 (10Jdforrester-WMF) 5Open>3Resolved a:3Jdforrester-WMF [18:45:43] 10Cite, 10VisualEditor, 10VisualEditor-MediaWiki, 10VisualEditor-MediaWiki-Plugins, and 4 others: Refactor VisualEditor editing plugin for Cite back into the Cite extension - https://phabricator.wikimedia.org/T41621#469079 (10Jdforrester-WMF) [18:45:46] 10Cite, 10VisualEditor, 10VisualEditor-MediaWiki, 10VisualEditor-MediaWiki-References, and 5 others: Move ext.visualEditor.mwreference registration back to extension.json once ext.cite.style is definitely available - https://phabricator.wikimedia.org/T104928#1999123 (10Jdforrester-WMF) 5Open>3Resolved... [18:47:07] Kemayo, in this case the rendering is a totally empty div until the graph is finished rendering [18:47:33] which is async [18:47:38] hasRendering won't be able to ever know that [18:47:43] 10VisualEditor, 10MediaWiki-Unit-tests, 6Release-Engineering-Team, 5WMF-deploy-2016-02-02_(1.27.0-wmf.12): VE QUnit tests fail on 1.27.0-wmf.12 branch due to Wikidata branch cut issue - https://phabricator.wikimedia.org/T125655#1999138 (10Jdforrester-WMF) [18:48:06] we could have the graph trigger an 'update size' after it has finished rendeirng [18:48:14] 10VisualEditor, 10VisualEditor-MediaWiki, 10MediaWiki-Vagrant, 10MobileFrontend-Feature-requests: MobileFrontend vagrant role forces EventLogging on, breaks VisualEditor - https://phabricator.wikimedia.org/T88698#1018337 (10Jdforrester-WMF) [18:48:52] 10VisualEditor: Review https://www.mediawiki.org/wiki/VisualEditor/Rollouts - https://phabricator.wikimedia.org/T125210#1981494 (10Jdforrester-WMF) [18:49:04] 10VisualEditor: [Regression pre-wmf.11] Saving a page after adding an image/formula is throwing error "Cannot read property 'top' of undefined" in VisualEditor - https://phabricator.wikimedia.org/T123340#1999154 (10Jdforrester-WMF) [18:49:36] 10VisualEditor, 6Editing-Department, 10MediaWiki-extensions-ContentTranslation, 7Design, and 2 others: [Epic] replace plain contenteditable with VisualEditor in ContentTranslation - https://phabricator.wikimedia.org/T105447#1999158 (10Jdforrester-WMF) [18:49:40] 10VisualEditor, 6Community-Tech, 10MediaWiki-extensions-ContentTranslation: Merge the content translation and the visual editor to one tool - https://phabricator.wikimedia.org/T120476#1999157 (10Jdforrester-WMF) [18:49:51] edsanders: the update size route would make sense, yeah. We'd need to adjust focusablenode to know it's possible to gain a rendering, also. I think it won't toggle away from the invisibles class as-is. [18:51:16] 10VisualEditor, 10VisualEditor-ContentEditable, 5WMF-deploy-2016-02-02_(1.27.0-wmf.12): When a link is the first element on a page, don't launch the link context menu automatically; instead put the cursor in the placement outside the link - https://phabricator.wikimedia.org/T114376#1999163 (10Jdforrester-WMF) [18:52:02] 10VisualEditor, 10VisualEditor-ContentLanguage, 7Tracking: VisualEditor multilingual input / i18n issues (tracking) - https://phabricator.wikimedia.org/T35077#1999167 (10Jdforrester-WMF) 5Resolved>3Invalid [18:52:06] 10VisualEditor, 10VisualEditor-Tables: Table backgrounds and borders don't always display correctly - https://phabricator.wikimedia.org/T85639#1999169 (10Jdforrester-WMF) 5Resolved>3declined [18:53:00] 10Citoid, 10VisualEditor, 5WMF-deploy-2016-02-02_(1.27.0-wmf.12): Use en dash instead of hyphen-minus between page numbers - https://phabricator.wikimedia.org/T113570#1999178 (10Jdforrester-WMF) [18:53:11] (03CR) 10jenkins-bot: [V: 04-1] Remove all Extension:Cite code, now moved there [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/254082 (owner: 10Jforrester) [18:53:22] OFFS. [18:57:07] 10VisualEditor, 10OOjs-UI: Ctrl+Enter to confirm OOui dialogs - https://phabricator.wikimedia.org/T125860#1999203 (10eranroz) [19:00:00] 10VisualEditor, 10OOjs-UI, 10UI-Standardization: Duplicate icons: 'Translation' and 'TextLanguage' - https://phabricator.wikimedia.org/T111040#1999209 (10Jdforrester-WMF) 5Open>3Resolved [19:00:33] (03PS7) 10Jforrester: Remove all Extension:Cite code, now moved there [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/254082 [19:04:46] Kemayo, most extensions render synchronously - Graph even has custom handling for the rendering being blank [19:05:00] (03CR) 10jenkins-bot: [V: 04-1] Remove all Extension:Cite code, now moved there [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/254082 (owner: 10Jforrester) [19:07:07] 10VisualEditor, 10VisualEditor-MediaWiki: VisualEditor Single-edit-tab breaks certain Edit page semantics - https://phabricator.wikimedia.org/T125670#1999254 (10Jdforrester-WMF) [19:07:10] 10VisualEditor, 5Patch-For-Review: [Regression wmf.12] FocusableNode invisibles produces weird results with graph, templates and transclusions - https://phabricator.wikimedia.org/T125767#1999257 (10Ryasmeen) [19:07:23] 10VisualEditor, 10VisualEditor-MediaWiki, 6Editing-Analysis: Sample edit events in desktop visual editor at 6.25% - https://phabricator.wikimedia.org/T125598#1992076 (10Jdforrester-WMF) [19:07:45] 10VisualEditor, 10VisualEditor-MediaWiki, 10Wikimedia-Site-Requests: Feedback at enwiki should not go to mediawiki.org - https://phabricator.wikimedia.org/T125850#1999266 (10Jdforrester-WMF) p:5Triage>3High a:3Jdforrester-WMF [19:08:14] 10VisualEditor, 10VisualEditor-Tables, 7RTL: Tab in tables in VisualEditor moves the wrong way in RTL - https://phabricator.wikimedia.org/T125378#1999271 (10Jdforrester-WMF) [19:08:46] Good news, VisualEditors! We just merged some refactoring in core that lets you use the completion suggester over the API. :-) [19:09:00] With all the bells and whistles, like generators. [19:09:24] Be aware that it's still a beta-level feature, though. Don't go replacing things in production yet! But, if you were interesting in running tests, you can do that now. :-) [19:09:34] I'm writing an email listing more details. [19:10:44] 10VisualEditor, 10VisualEditor-EditingTools: Make VE "your signature" button more visible on non-Flow talkpages - https://phabricator.wikimedia.org/T125839#1999281 (10Jdforrester-WMF) 5Open>3declined a:3Jdforrester-WMF It's entirely //possible// to adjust the VE toolbar dynamically, but we absolutely wil... [19:11:15] 10VisualEditor, 10VisualEditor-ContentEditable, 5Patch-For-Review: [Regression wmf.12] FocusableNode invisibles produces weird results with graph, templates and transclusions - https://phabricator.wikimedia.org/T125767#1999287 (10Jdforrester-WMF) p:5Triage>3High a:3DLynch [19:11:22] Deskana: Woo. [19:11:55] edsanders: Can you review/merge https://gerrit.wikimedia.org/r/#/c/268437/ quickly so we can do a deploy? [19:11:59] 10VisualEditor, 10VisualEditor-ContentEditable, 5Patch-For-Review, 5WMF-deploy-2016-02-02_(1.27.0-wmf.12): [Regression wmf.12] FocusableNode invisibles produces weird results with graph, templates and transclusions - https://phabricator.wikimedia.org/T125767#1996836 (10Jdforrester-WMF) [19:17:18] 10VisualEditor, 10OOjs, 10OOjs-UI: Submit OOjs UI and OOjs to cdnjs - https://phabricator.wikimedia.org/T106721#1999321 (10Jdforrester-WMF) p:5Normal>3Low [19:17:44] 10VisualEditor, 10VisualEditor-MediaWiki, 10MediaWiki-General-or-Unknown, 5Patch-For-Review: Feedback tool displays/links the wrong target for page link when it's cross-wiki - https://phabricator.wikimedia.org/T125400#1999322 (10Jdforrester-WMF) a:3Jdforrester-WMF [19:20:30] 10VisualEditor, 10Phlogiston, 15User-JAufrecht: 51569 shows open points and tasks but shouldn't - https://phabricator.wikimedia.org/T124949#1999331 (10JAufrecht) 5Open>3Resolved fixed by fixing blocking task [19:21:25] (03CR) 10Krinkle: [C: 031] "We'll need to update the getUserEditor getCookie call as well. But that predates this commit." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/259771 (https://phabricator.wikimedia.org/T121257) (owner: 10Alex Monk) [19:23:55] 10VisualEditor, 10Phlogiston, 15User-JAufrecht: Forecast graphs should round up (so that 0.4 weeks doesn't show as 0 weeks, but as 1) - https://phabricator.wikimedia.org/T120721#1999340 (10JAufrecht) 5Open>3Resolved seems to have been fixed as an unintended side-effect of some other change [19:24:21] Krinkle: Is that a +1-someone-from-VE-should-+2 or a +1-and-I'll-come-back-to-it or something else? [19:24:29] The former [19:24:42] :) [19:25:10] Note I filed a separate task for some issues with SET in general that should be considered (ideally fixed) before prod [19:25:43] and the other getCookie() call, whcih is currently broken (e.g. the cookie set by JS isn't recognised by the server currently) [19:26:06] Kemayo, which nodes have width & height properties? Surely just images... [19:26:48] Krinkle: Right-o. Yeah, I saw. Thanks. [19:27:00] (03CR) 10Esanders: [C: 04-1] Don't just rely on jQuery width / height for hasRendering (031 comment) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/268437 (https://phabricator.wikimedia.org/T125767) (owner: 10DLynch) [19:27:33] 10VisualEditor, 10Phlogiston, 15User-JAufrecht, 7WorkType-NewFunctionality: Generate master burnup in Phlogiston that accurately communicates backlog, burnup, and maintenance fraction trends and status. - https://phabricator.wikimedia.org/T110085#1999354 (10JAufrecht) 5Open>3Resolved The requirements o... [19:27:35] 10VisualEditor, 10Phlogiston, 15User-JAufrecht, 7WorkType-NewFunctionality: Create third version of VE burnup report - https://phabricator.wikimedia.org/T107482#1999356 (10JAufrecht) [19:30:26] James_F, https://gerrit.wikimedia.org/r/#/c/268429/ fixes the issue [19:31:10] edsanders: For graph; the bug report says it happens for formulae/templates/etc. too. [19:31:29] hm [19:31:41] 10VisualEditor, 7Epic: Make improvements to the VisualEditor team's processes - https://phabricator.wikimedia.org/T101207#1999368 (10JAufrecht) [19:31:43] 10VisualEditor, 15User-JAufrecht: Measure and document results of changes to VE team processes - https://phabricator.wikimedia.org/T103197#1999366 (10JAufrecht) 5Open>3Invalid 1) did not have baseline to compare, 2) were not able to identify practically collectible metrics during intervention, so 3) did no... [19:31:51] 10VisualEditor, 7Epic: Make improvements to the VisualEditor team's processes - https://phabricator.wikimedia.org/T101207#1332658 (10JAufrecht) [19:31:53] 10VisualEditor, 15User-JAufrecht: Measure and document results of changes to VE team processes - https://phabricator.wikimedia.org/T103197#1999369 (10JAufrecht) 5Invalid>3declined [19:34:48] James_F, templated graphs don't render, but that's always going to be the case [19:35:22] edsanders: See http://en.wikipedia.beta.wmflabs.org/wiki/User:Jdforrester_(WMF)/Sandbox?veaction=edit (formula after the second heading). [19:35:30] 10VisualEditor: A small dialog with drop down appears on the top-left corner while trying to add an existing group reference - https://phabricator.wikimedia.org/T125862#1999376 (10Ryasmeen) 3NEW [19:37:06] ok, I'll change the default to null for known extensions [19:37:15] (null = no icon logic) [19:38:17] * James_F nods. [19:38:47] (03PS1) 10Esanders: Default extensions to not use the 'invisible icon' [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/268449 (https://phabricator.wikimedia.org/T125767) [19:40:30] 10VisualEditor, 10VisualEditor-MediaWiki, 10Wikimedia-Site-Requests, 5WMF-deploy-2016-02-02_(1.27.0-wmf.12): Feedback at enwiki should not go to mediawiki.org - https://phabricator.wikimedia.org/T125850#1999419 (10Jdforrester-WMF) 5Open>3Resolved [19:40:33] 10VisualEditor, 10VisualEditor-MediaWiki, 10Wikimedia-Site-Requests, 5WMF-deploy-2016-02-02_(1.27.0-wmf.12): Feedback at enwiki should not go to mediawiki.org - https://phabricator.wikimedia.org/T125850#1998786 (10Jdforrester-WMF) Oops. [19:41:16] (03CR) 10Jforrester: [C: 032] SET: Set user's editor to wikitext if the browser doesn't do JS [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/259771 (https://phabricator.wikimedia.org/T121257) (owner: 10Alex Monk) [19:41:48] 10VisualEditor, 10VisualEditor-MediaWiki, 7Design, 7Epic: Change VE integration to only use one edit tab, to avoid user choice paralysis - https://phabricator.wikimedia.org/T58337#1999427 (10Jdforrester-WMF) [19:41:51] 10VisualEditor, 10VisualEditor-MediaWiki: On single edit tab wikis, if your browser is non-JS but your settings say VE you get a blank edit page and no way to fix it - https://phabricator.wikimedia.org/T121257#1999425 (10Jdforrester-WMF) 5Open>3Resolved [19:43:36] 10VisualEditor, 10VisualEditor-MediaWiki: Fix the broken JS getCookie() call, which sets a cookie not recognised by the server - https://phabricator.wikimedia.org/T125864#1999430 (10Jdforrester-WMF) 3NEW a:3Krenair [19:43:40] 10VisualEditor, 10VisualEditor-MediaWiki: Fix the broken JS getCookie() call, which sets a cookie not recognised by the server - https://phabricator.wikimedia.org/T125864#1999430 (10Jdforrester-WMF) [19:44:04] where is this James_F / Krinkle? [19:44:26] The cookie? [19:44:33] "When disabling JavaSCript, It seems this is setting cookie 'VEE=wikitext' instead of 'VEE' and something else is also setting a 'VEE=visualeditor' cookie (which remains unchanged). Looks like these should be coordinated together. " [19:44:39] Krenair: getUserEditor calls getCookie [19:44:41] same file lower down [19:44:49] Also needs '' prefix [19:44:59] otherwise it's not looking at the same place where VE javascript sets the VEE cookie [19:45:00] "Main thing remaining here is the VEE cookie mixup. The new PHP code should probably disable the cookie prefix so that it matches the JS code (which also uses raw jquery.cookie without mw.cookie prefix). " [19:45:47] I thought I dealt with something like that already [19:46:49] (03CR) 10Jforrester: [C: 032] Default extensions to not use the 'invisible icon' [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/268449 (https://phabricator.wikimedia.org/T125767) (owner: 10Esanders) [19:47:26] (03CR) 10Krinkle: [C: 031] Remove uses of plain .contentEditable [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/266265 (https://phabricator.wikimedia.org/T116214) (owner: 10DLynch) [19:48:10] 10VisualEditor, 10Graph: Clicking "edit" for a graph of unsupported type crashes VisualEditor - https://phabricator.wikimedia.org/T125761#1999470 (10Jdforrester-WMF) p:5Triage>3High a:3ferdbold [19:49:10] (03PS1) 10Jforrester: Default extensions to not use the 'invisible icon' [extensions/VisualEditor] (wmf/1.27.0-wmf.12) - 10https://gerrit.wikimedia.org/r/268453 (https://phabricator.wikimedia.org/T125767) [19:51:25] 10VisualEditor, 10VisualEditor-MediaWiki, 6Community-Liaison, 10MediaWiki-extensions-TemplateData, and 3 others: Check documentation for the TemplateData editor for completeness, accuracy, and ease of understanding by adding TemplateData to templates on Wik... - https://phabricator.wikimedia.org/T117499#1999488 [19:54:18] (03CR) 10DLynch: Don't just rely on jQuery width / height for hasRendering (031 comment) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/268437 (https://phabricator.wikimedia.org/T125767) (owner: 10DLynch) [19:55:01] (03CR) 10Jforrester: [C: 031] Don't just rely on jQuery width / height for hasRendering [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/268437 (https://phabricator.wikimedia.org/T125767) (owner: 10DLynch) [19:57:11] (03Merged) 10jenkins-bot: SET: Set user's editor to wikitext if the browser doesn't do JS [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/259771 (https://phabricator.wikimedia.org/T121257) (owner: 10Alex Monk) [19:59:25] (03Merged) 10jenkins-bot: Default extensions to not use the 'invisible icon' [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/268449 (https://phabricator.wikimedia.org/T125767) (owner: 10Esanders) [20:06:20] 10VisualEditor, 10VisualEditor-MediaWiki, 10VisualEditor-MediaWiki-Media, 6Multimedia, and 3 others: Give guidance in the new upload form, to prevent the most common errors - e.g. bad file titles - https://phabricator.wikimedia.org/T116086#1999540 (10Jdforrester-WMF) >>! In T116086#1936206, @Prtksxna wrote... [20:07:15] (03CR) 10Jforrester: [C: 031] ResizableNode: Remove assumption about 'width'/'height' attributes [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/268059 (owner: 10Esanders) [20:08:06] edsanders: Are you fixing https://gerrit.wikimedia.org/r/#/c/252345/ ? [20:15:07] (03CR) 10Esanders: "Yes - we should" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/252345 (owner: 10Esanders) [20:26:50] 10VisualEditor, 10VisualEditor-MediaWiki, 10MediaWiki-General-or-Unknown, 5Patch-For-Review: Feedback tool displays/links the wrong target for page link when it's cross-wiki - https://phabricator.wikimedia.org/T125400#1999645 (10Elitre) I'm learning that part 2 is fixed in T125850 . [20:37:18] 10VisualEditor, 7I18n: [[MediaWiki:Apihelp-visualeditor-param-pst/eo]] i18n issue - https://phabricator.wikimedia.org/T125798#1999678 (10Florian) [20:42:58] (03CR) 10Esanders: "veswitched is currently posted and then written as a hidden form input so you can check $('#editform').find('input[name=veswitched]').val(" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/252345 (owner: 10Esanders) [20:43:05] 10VisualEditor, 7I18n: [[MediaWiki:Apihelp-visualeditor-param-pst/eo]] i18n issue - https://phabricator.wikimedia.org/T125798#1999734 (10Jdforrester-WMF) "Pre-save transform" is a key technical term in MediaWiki. It should appear in dozens of other API i18n strings and documentation. See https://www.mediawiki.... [20:50:12] Krenair: https://gerrit.wikimedia.org/r/267696 review'd be smashing. [20:51:20] James_F, does that actually work? [20:51:33] Krenair: It seems to. [20:51:39] Krenair: Why wouldn't it? [20:51:59] you're trying to set an element attribute to a Promise object... [20:52:07] instead of a string [20:53:01] No? I'm setting it to the return of a promise resolution… [20:55:32] https://api.jquery.com/deferred.then/ [21:01:50] Krenair: I thought .then was a synonym for .done? [21:13:49] James_F, .then will chain deferreds [21:14:28] Yeah, unless you break it by returning, surely? [21:15:09] 10VisualEditor, 6Collaboration-Team-Backlog, 10Flow, 10Parsoid: Figure out how to get page bundle from Flow VE - https://phabricator.wikimedia.org/T125890#1999951 (10Mattflaschen) 3NEW [21:17:34] Krenair: So WTF is one meant to do? [21:28:17] James_F, well you should start the .get as soon as you have the api object [21:29:07] then in case 'submitted':, this.feedbackPageUrlPromise.done( function () { ... } ); [21:29:30] can resolve immediately if there's no api [21:29:38] Krenair: But in the majority use-case it's not going to be remote. [21:29:48] can resolve immediately if there's no api [21:29:52] Meh. [21:32:38] (03CR) 10Esanders: Don't just rely on jQuery width / height for hasRendering (031 comment) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/268437 (https://phabricator.wikimedia.org/T125767) (owner: 10DLynch) [21:33:02] 10Cite, 10MediaWiki-API, 10MobileFrontend, 5Patch-For-Review, 3Reading-Web-Sprint-66-h: Should be possible to access references and notes for a given page via API - https://phabricator.wikimedia.org/T123290#2000029 (10Jdlrobson) [21:38:44] (03PS2) 10DLynch: Don't just rely on jQuery width / height for hasRendering [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/268437 (https://phabricator.wikimedia.org/T125767) [21:41:24] Kemayo, have you looked at ve.ce.MWExtensionNode.prototype.afterRender [21:41:55] (03CR) 10Esanders: [C: 04-1] "On reflection I think you should use the approach in ve.ce.MWExtensionNode.prototype.afterRender, specifically waiting for all images to l" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/268437 (https://phabricator.wikimedia.org/T125767) (owner: 10DLynch) [21:44:03] 10Cite, 10Reading-Web-Planning, 3Reading-Web-Sprint-66-h: Create Special:References fallback for non-JavaScript users - https://phabricator.wikimedia.org/T125897#2000071 (10Jdlrobson) 3NEW [21:50:27] (03CR) 10jenkins-bot: [V: 04-1] Remove all Extension:Cite code, now moved there [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/254082 (owner: 10Jforrester) [22:18:45] (03PS1) 10Esanders: Use negative margins to even out panel margins [extensions/Citoid] - 10https://gerrit.wikimedia.org/r/268570 [22:39:13] (03PS8) 10Jforrester: Remove all Extension:Cite code, now moved there [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/254082 [22:41:17] 10VisualEditor, 10VisualEditor-MediaWiki, 6Community-Liaison, 10MediaWiki-extensions-TemplateData, and 3 others: Check documentation for the TemplateData editor for completeness, accuracy, and ease of understanding by adding TemplateData to templates on Wik... - https://phabricator.wikimedia.org/T117499#2000354 [22:42:38] (03CR) 10jenkins-bot: [V: 04-1] Remove all Extension:Cite code, now moved there [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/254082 (owner: 10Jforrester) [22:47:15] 10VisualEditor, 10MediaWiki-General-or-Unknown: mw.widgets.TitleWidget doesn't do language fallback for Wikidata descriptions - https://phabricator.wikimedia.org/T125763#2000364 (10matmarex) Sounds like it should be Wikibase's responsibility. TitleWidget doesn't ask for a specific language, as far as I can see. [22:48:56] (03PS1) 10Esanders: Fix toolbar hack [extensions/Citoid] - 10https://gerrit.wikimedia.org/r/268581 [23:05:59] (03PS2) 10Esanders: VE: Fix toolbar hack [extensions/Citoid] - 10https://gerrit.wikimedia.org/r/268581 [23:14:12] James_F, ve-mw hasn't merged yet? [23:14:58] edsanders: No. :-( Looking at it with legoktm; we can't work out why not. [23:23:50] I noticed that was the first dependency we added for VE tests [23:26:25] Yeah. [23:26:41] Moving all the tests of internalList from VE-MW to Cite though would suck. [23:28:43] edsanders: I'm half-minded to force-merge it. [23:28:45] But… [23:29:02] :o [23:31:34] Yeah. :-( [23:35:20] the tests aren't going to start just because you merge it [23:36:22] They work perfectly locally. [23:48:53] (03CR) 10Jforrester: [C: 032] "Ha." [extensions/Citoid] - 10https://gerrit.wikimedia.org/r/268581 (owner: 10Esanders) [23:50:22] (03Merged) 10jenkins-bot: VE: Fix toolbar hack [extensions/Citoid] - 10https://gerrit.wikimedia.org/r/268581 (owner: 10Esanders)