[01:31:21] (03CR) 10Alex Monk: "Let's schedule this for the next swat deploy then" [extensions/VisualEditor] (wmf/1.27.0-wmf.12) - 10https://gerrit.wikimedia.org/r/268318 (owner: 10Paladox) [01:35:42] (03CR) 10Alex Monk: "scheduled for monday evening" [extensions/VisualEditor] (wmf/1.27.0-wmf.12) - 10https://gerrit.wikimedia.org/r/268318 (owner: 10Paladox) [02:27:08] (03PS1) 10Alex Monk: Set page title when we take over action=edit [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/268610 (https://phabricator.wikimedia.org/T125670) [07:54:01] (03PS3) 10DLynch: FocusableNode: watch for image loaded/layout changes for invisible icons [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/268437 (https://phabricator.wikimedia.org/T125767) [07:58:04] (03CR) 10DLynch: "Slightly closer investigation revealed that the images are generally *loaded* by then, at least in the Math case. However, although the ra" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/268437 (https://phabricator.wikimedia.org/T125767) (owner: 10DLynch) [08:11:30] (03CR) 10DLynch: [C: 032] Use negative margins to even out panel margins [extensions/Citoid] - 10https://gerrit.wikimedia.org/r/268570 (owner: 10Esanders) [08:12:25] (03Merged) 10jenkins-bot: Use negative margins to even out panel margins [extensions/Citoid] - 10https://gerrit.wikimedia.org/r/268570 (owner: 10Esanders) [11:44:10] (03CR) 10Esanders: [C: 04-1] "why not just use the onLoad event and test the naturalWidth/Height only. It's unlikely an image of significant natural dimensions will be " (032 comments) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/268437 (https://phabricator.wikimedia.org/T125767) (owner: 10DLynch) [14:21:29] (03PS1) 10Esanders: SurfaceFragment: Handle multi-range annotations correctly [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/268669 (https://phabricator.wikimedia.org/T125978) [14:50:21] (03CR) 10Esanders: [C: 04-1] "needs tests" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/268669 (https://phabricator.wikimedia.org/T125978) (owner: 10Esanders) [15:52:04] (03PS2) 10Esanders: SurfaceFragment: Handle multi-range annotations correctly [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/268669 (https://phabricator.wikimedia.org/T125978) [16:16:24] Hello everyone... I need some assistance with VisualEditor ... I have it installed and Parsoid installed. verified by running curl -L to sitename:8142 .... I load an existing page and or create a page and I still see the old editor [16:16:44] public wiki? [16:16:58] Also verified settings in settings.js and LocalSettings [16:17:08] No internal network with internet access [16:17:27] well, does VE show up on Special:Version? [16:18:06] Sorry can you direct me on how to access Special:Version? [16:18:50] it's a page on your wiki [16:19:50] Yes I see a line item for VE 0.1.0 [16:24:27] VE was installed from download package not Git. I did see a thread on a possible submodule but that was from pulling from the Git repo [16:29:12] Also after installation and configuration I lost my edit (button/tab) and only have edit source [16:32:26] is there anything else I can take a look at? try/test/check? [16:32:34] anything in your JS console? [16:32:44] what do you mean 'from download package'? [16:33:08] Sorry tarbal [16:33:13] tarball* [16:35:02] Not that I can see ... I do see index.php and load.php [16:35:52] what? [16:35:57] you see index.php and load.php in your js console? [16:36:51] Sorry was on Network when I typed that. I see no errors in my console [16:42:01] what sort of page were you trying to edit? [16:42:10] did you go to your preferences and ensure ve is enabled? [16:52:05] 10Cite, 5Patch-For-Review, 3Reading-Web-Sprint-65-Game of Phones: Save references in page_props and cache - https://phabricator.wikimedia.org/T125329#2002553 (10phuedx) @Cenarium is making good progress with the patch but there's an improvement that can be made around how the references are accumulated. For... [16:58:42] Any page ... this is a new install and I only have the main page at the moment. In Special:Preferences under editing I see a check box that says: Temporarily disable the visual editor while it is in beta outside of that how else can I confirm VE is enabled [17:04:11] 10VisualEditor, 10ContentTranslation-Deployments, 10ContentTranslation-cxserver, 10Parsoid, and 4 others: Decom parsoid-lb.eqiad.wikimedia.org entrypoint - https://phabricator.wikimedia.org/T110474#2002590 (10BBlack) Took another log of all traffic today, for ~1 hour. Excluding our own healthcheck/monitor... [17:11:36] Is there another location to confirm that VE is enabled? [17:14:53] James_F, any ideas the on the test dependencies [17:15:00] 10VisualEditor, 10VisualEditor-EditingTools, 7Design: VisualEditor: Consider whether exiting the link dialog in create mode should remove the link - https://phabricator.wikimedia.org/T71407#2002622 (10Jdforrester-WMF) Yeah, that's {T52868}. [17:15:14] I have local commits that move the Cite tests to Cite, but we should work out what's going wrong [17:22:17] 10VisualEditor, 10ContentTranslation-Deployments, 10ContentTranslation-cxserver, 10Parsoid, and 4 others: Decom parsoid-lb.eqiad.wikimedia.org entrypoint - https://phabricator.wikimedia.org/T110474#2002627 (10GWicke) While breaking parsoid-prod.wmflab.org's favicon is a heavy price to pay, all those sacrif... [17:23:03] Since I am unable to get VE working and really don't know where to look to figure out where it is failing or I am failing is there another alternative. [17:25:43] 10VisualEditor, 10ContentTranslation-Deployments, 10ContentTranslation-cxserver, 10Parsoid, and 4 others: Decom parsoid-lb.eqiad.wikimedia.org entrypoint - https://phabricator.wikimedia.org/T110474#2002633 (10BBlack) Sometime between now and the 22nd, I'll try to get a full capture for a period of multiple... [17:29:12] 10Citoid: Citoid should convert typographer's quote marks to straight quote marks - https://phabricator.wikimedia.org/T126003#2002644 (10Jonesey95) 3NEW [17:41:13] anyone [17:42:04] 10VisualEditor, 6Collaboration-Team-Backlog, 10Parsoid, 7Epic: HTML diffs of edits for everything - https://phabricator.wikimedia.org/T105173#2002737 (10Jdforrester-WMF) [17:48:34] 10VisualEditor, 7Parsoid-Nowiki, 7Verified-in-Phase0, 7Verified-in-Phase2: ISBN are surrounded by nowiki - https://phabricator.wikimedia.org/T110347#2002770 (10Jdforrester-WMF) 5Open>3Resolved >>! In T110347#1925124, @Amire80 wrote: > This still happens, at least as described in the title. Please do n... [17:49:45] 10VisualEditor, 6Editing-Department, 10MobileFrontend, 7Mobile, 5WMF-deploy-2016-02-09_(1.27.0-wmf.13): Enable editing for mobile users without JavaScript and kill Special:MobileEditor code in MobileFrontend - https://phabricator.wikimedia.org/T125174#2002777 (10Sumit) >>! In T125174#1994665, @Jdlrobson... [17:55:26] is there another location I can look to see if VE is throwing an error or something? [18:13:58] (03CR) 10Jforrester: [C: 032] "Merging this now to prepare the core patch." [extensions/VisualEditor] (wmf/1.27.0-wmf.12) - 10https://gerrit.wikimedia.org/r/268453 (https://phabricator.wikimedia.org/T125767) (owner: 10Jforrester) [18:14:06] (03CR) 10Jforrester: [C: 032] "Merging this now to prepare the core patch." [extensions/VisualEditor] (wmf/1.27.0-wmf.12) - 10https://gerrit.wikimedia.org/r/268318 (owner: 10Paladox) [18:14:19] 10VisualEditor, 6Community-Liaison, 3Liaisons-February-2016: Review list of pages which receive the VE newsletter - https://phabricator.wikimedia.org/T125430#2002902 (10Elitre) That list should now have all the 49 wikis it needs. [18:18:22] edsanders: Do you want to update https://gerrit.wikimedia.org/r/#/c/254082/ killing all the tests first, or do a new patch with them all in? [18:18:22] (in Cite)? [18:22:43] As a test I enabled WikiEditor and it appears. Is there another configuration file I should change? Is there a hook I might have missed to get the editor to appear on the edit page or create page [18:23:12] (03Merged) 10jenkins-bot: Default extensions to not use the 'invisible icon' [extensions/VisualEditor] (wmf/1.27.0-wmf.12) - 10https://gerrit.wikimedia.org/r/268453 (https://phabricator.wikimedia.org/T125767) (owner: 10Jforrester) [18:24:19] 10VisualEditor, 7Technical-Debt: InternalListNode has an empty $element, so we assume that the slug goes at the end instead. This is a hack and the internal list needs to die in a fire. - https://phabricator.wikimedia.org/T126019#2002960 (10Jdforrester-WMF) 3NEW [18:25:57] (03Merged) 10jenkins-bot: Fix "Uncaught TypeError: $.cookie is not a function" [extensions/VisualEditor] (wmf/1.27.0-wmf.12) - 10https://gerrit.wikimedia.org/r/268318 (owner: 10Paladox) [18:26:32] 10VisualEditor, 7Technical-Debt: ve.dm.Document#newFromHtml: Adding a new ve.dm.MetaLinearData to the document is paste-specific - https://phabricator.wikimedia.org/T126020#2002972 (10Jdforrester-WMF) 3NEW [18:28:08] 10VisualEditor, 7Technical-Debt: ve.dm.SurfaceFragment#insertContent: Don't reach into properties of document - https://phabricator.wikimedia.org/T126021#2002992 (10Jdforrester-WMF) 3NEW [18:28:28] 10VisualEditor, 7Technical-Debt: ve.dm.SurfaceFragment#insertContent: Annotate inserted content correctly - https://phabricator.wikimedia.org/T126022#2002998 (10Jdforrester-WMF) 3NEW [18:29:40] 10VisualEditor, 7Technical-Debt: ve.dm.Document#getDataFromNode: If the node is wrapped in an element than we should increment the offset by one so we only return the content inside the element. - https://phabricator.wikimedia.org/T126023#2003005 (10Jdforrester-WMF) 3NEW [18:30:56] 10VisualEditor, 7Technical-Debt: .ve-ce-surface-paste: Remove use of position fixed to stop the viewport scrolling when the paste target is typed into - https://phabricator.wikimedia.org/T126024#2003011 (10Jdforrester-WMF) 3NEW [18:32:14] 10VisualEditor, 7Technical-Debt: ve.ce.ContentBranchNode#onSplice: Don't rely on isRenderingLocked to adjust slug indexes - https://phabricator.wikimedia.org/T126025#2003019 (10Jdforrester-WMF) 3NEW [18:35:02] 10VisualEditor, 7Technical-Debt: ve.init.Platform#isInternetExplorer shouldn't exit - https://phabricator.wikimedia.org/T126026#2003038 (10Jdforrester-WMF) 3NEW [18:35:29] Is there any information I can provide to get this editor to appear...I really need it to complete a project utilizing mediawiki [18:36:30] 10VisualEditor, 7Browser-Support-Google-Chrome, 7Technical-Debt: ve.ui.FragmentInspector#getBodyHeight: Remove need for Chrome-specific hack on non-opaque elements - https://phabricator.wikimedia.org/T126027#2003048 (10Jdforrester-WMF) 3NEW [18:37:13] 10VisualEditor, 10VisualEditor-MediaWiki-Mobile, 7Technical-Debt: ve.ui.MobileWindowManager#onMobileOpening: Don't un-frame buttons - https://phabricator.wikimedia.org/T126029#2003064 (10Jdforrester-WMF) 3NEW [18:38:12] 10VisualEditor, 7Technical-Debt: .oo-ui-tool-headingN: Don't use px just so that padding is not changed by font size - https://phabricator.wikimedia.org/T126030#2003075 (10Jdforrester-WMF) 3NEW [18:39:58] 10VisualEditor, 7Technical-Debt: ve.dm.AnnotationSet#containsComparableForSerialization: … - https://phabricator.wikimedia.org/T126031#2003083 (10Jdforrester-WMF) 3NEW [18:41:05] 10VisualEditor, 7Technical-Debt: ve#transformStyleAttributes: Don't inject empty text nodes into empty non-void tags - https://phabricator.wikimedia.org/T126032#2003091 (10Jdforrester-WMF) 3NEW [18:41:57] 10VisualEditor, 7Technical-Debt: ve#serializeXhtml: Don't use a hack to remove the xmlns attribute - https://phabricator.wikimedia.org/T126035#2003113 (10Jdforrester-WMF) 3NEW [18:43:29] 10VisualEditor, 7Technical-Debt: Get rid of ve#getSystemPlatform by not needing the system platform before the ve.init.platform is constructed - https://phabricator.wikimedia.org/T126036#2003123 (10Jdforrester-WMF) 3NEW [18:45:01] 10VisualEditor, 7Technical-Debt: ve.dm.Annotation#getComparableHtmlAttributes: Remove if we're convinced Parsoid merges similar annotations well enough - https://phabricator.wikimedia.org/T126037#2003131 (10Jdforrester-WMF) 3NEW [18:46:22] 10VisualEditor, 7Technical-Debt: Clean up ve.dm.Annotation#getComparableObjectForSerialization - https://phabricator.wikimedia.org/T126038#2003142 (10Jdforrester-WMF) 3NEW [18:47:12] 10VisualEditor, 7Technical-Debt: Stop needing ve.dm.Annotation#compareToForSerialization - https://phabricator.wikimedia.org/T126039#2003149 (10Jdforrester-WMF) 3NEW [18:48:27] 10VisualEditor, 7Browser-Support-Apple-Safari, 7Browser-Support-Firefox, 7Technical-Debt: ve.ce.Surface#destroy: Stop needing to blur the surface on destruction for Firefox and to kill the keyboard in iOS - https://phabricator.wikimedia.org/T126041#2003167 (10Jdforrester-WMF) 3NEW [18:49:35] 10VisualEditor, 7Browser-Support-Internet-Explorer, 7Technical-Debt: ve.ce.Surface#onDocumentMouseDown: Get rid of IE-specific triple-click workaround - https://phabricator.wikimedia.org/T126043#2003189 (10Jdforrester-WMF) 3NEW [18:49:56] 10VisualEditor, 7Browser-Support-Internet-Explorer, 7Technical-Debt: ve.ce.Surface#onDocumentMouseDown: Get rid of IE-specific triple-click workaround - https://phabricator.wikimedia.org/T126043#2003189 (10Jdforrester-WMF) [18:49:58] 10VisualEditor, 7Technical-Debt: ve.init.Platform#isInternetExplorer shouldn't exit - https://phabricator.wikimedia.org/T126026#2003198 (10Jdforrester-WMF) [18:50:43] 10VisualEditor, 7Technical-Debt: ve.ce.Surface#afterPaste shouldn't have code to remove Parsoid IDs - https://phabricator.wikimedia.org/T126044#2003201 (10Jdforrester-WMF) 3NEW [18:51:42] 10VisualEditor, 7Technical-Debt: Find a neater way for the testrunner to force the user of clipboardData in ve.ce.Surface#afterPaste - https://phabricator.wikimedia.org/T126045#2003209 (10Jdforrester-WMF) 3NEW [18:53:35] 10VisualEditor, 7Browser-Support-Google-Chrome, 7Technical-Debt: More cleanly strip trailing linebreaks introduced by a Chrome bug in ve.ce.Surface#afterPaste - https://phabricator.wikimedia.org/T126046#2003215 (10Jdforrester-WMF) 3NEW [18:55:13] (03PS1) 10Jforrester: Convert a bunch of HACK:/XXX:/FIXME: tags to a task reference [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/268716 [18:56:30] achild: Hey. If you don't have a VE tab but it's installed and on for all users it's likely that either (a) your browser isn't supported, (b) some JavaScript is breaking VE's loading of the tab, or (c) something I haven't thought of. [18:57:51] edsanders: BTW, there are three references in VE-core to MediaWiki-stuff. Got two of them with that pass. [19:00:03] (03CR) 10Jforrester: [C: 031] SurfaceFragment: Handle multi-range annotations correctly [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/268669 (https://phabricator.wikimedia.org/T125978) (owner: 10Esanders) [19:00:15] 10VisualEditor, 10VisualEditor-DataModel, 5Patch-For-Review: Can't unbold multiple table cells - https://phabricator.wikimedia.org/T125978#2003257 (10Jdforrester-WMF) p:5Triage>3Normal [19:00:54] 10VisualEditor, 10VisualEditor-MediaWiki: In single edit tab mode, when you load VE directly by browsing to action=edit, and it fails to load, bad things happen - https://phabricator.wikimedia.org/T125998#2003268 (10Jdforrester-WMF) p:5Triage>3Normal [19:07:34] (03CR) 10Jforrester: [C: 032] Remove uses of plain .contentEditable [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/266265 (https://phabricator.wikimedia.org/T116214) (owner: 10DLynch) [19:07:43] 10VisualEditor: Black cloud upon pasting a ref into the Basic citation dialog - https://phabricator.wikimedia.org/T126047#2003286 (10Whatamidoing-WMF) 3NEW [19:09:26] 10VisualEditor, 10VisualEditor-ContentEditable, 7Technical-Debt, 5WMF-deploy-2016-02-09_(1.27.0-wmf.13): Switch to using isContentEditable instead of contentEditable - https://phabricator.wikimedia.org/T116214#2003294 (10Jdforrester-WMF) 5Open>3Resolved a:3DLynch [19:10:45] (03CR) 10Jforrester: Convert a bunch of HACK:/XXX:/FIXME: tags to a task reference (031 comment) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/268716 (owner: 10Jforrester) [19:12:16] (03CR) 10Jforrester: [C: 032] Utility function for "index of node in its parentNode's childNode list" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/268061 (owner: 10Divec) [19:12:36] (03CR) 10Jforrester: [C: 031] getViewportDimensions: Fix calculation of 'bottom' [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/268112 (owner: 10Esanders) [19:15:24] (03Merged) 10jenkins-bot: Remove uses of plain .contentEditable [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/266265 (https://phabricator.wikimedia.org/T116214) (owner: 10DLynch) [19:22:07] (03Merged) 10jenkins-bot: Utility function for "index of node in its parentNode's childNode list" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/268061 (owner: 10Divec) [19:30:06] James_F: I am up to data on Chrome, I'm not seeing any error in my console with loading a page. is there a visual representation somewhere to verify VE is enabled? [19:30:37] achild: Go to Special:Version – it should list VisualEditor there. [19:30:57] 10WikiEditor: Editing screen shouldn't re-shape or move after it is displayed - https://phabricator.wikimedia.org/T125843#2003360 (10Krenair) [19:31:08] James_F: I do see it there. Just can't get it to appear in a page. [19:31:30] 10VisualEditor, 7Browser-Support-Internet-Explorer, 7Technical-Debt: ve.ce.Surface#onDocumentMouseDown: Get rid of IE-specific triple-click workaround - https://phabricator.wikimedia.org/T126043#2003367 (10Esanders) When? We still support versions of IE that are broken... [19:31:39] achild: What skin are you using [19:31:56] 10VisualEditor, 7Browser-Support-Internet-Explorer, 7Technical-Debt: ve.ce.Surface#onDocumentMouseDown: Get rid of IE-specific triple-click workaround - https://phabricator.wikimedia.org/T126043#2003370 (10Jdforrester-WMF) >>! In T126043#2003367, @Esanders wrote: > When? We still support versions of IE that... [19:32:07] (Is the default, Vector?) [19:32:59] James_F: Modern is the skin I have applied at the moment [19:33:20] achild: Ah, that'd be it. VE requires a lot of specifics about skins, and Modern doesn't have them so it's not whitelisted. [19:33:35] 10VisualEditor, 7Technical-Debt: ve.init.Platform#isInternetExplorer shouldn't exit - https://phabricator.wikimedia.org/T126026#2003375 (10Esanders) There is an existing bug about evaluating ie hacks for IE11. IIRC some are still required so we should merge this bug with that one. [19:33:43] James_F: I will give that a quick try. BRB [19:33:56] achild: If you install Vector it should Just Work™. [19:35:19] (03CR) 10Esanders: "Some of these are labelled as hacks because the solutions are inelegant, that don't mean there will be better solutions though..." [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/268716 (owner: 10Jforrester) [19:36:00] James_F: Finally some good news/bad news :) When clicking edit (which reappeared) I get a HTTP 500 error [19:36:12] Aha. Success. :-) [19:36:25] 10VisualEditor, 10VisualEditor-ContentEditable, 5Patch-For-Review, 5WMF-deploy-2016-02-02_(1.27.0-wmf.12): [Regression wmf.12] FocusableNode invisibles produces weird results with graph, templates and transclusions - https://phabricator.wikimedia.org/T125767#2003383 (10Esanders) 5Open>3Resolved [19:37:04] 10VisualEditor, 10VisualEditor-ContentEditable, 5Patch-For-Review, 5WMF-deploy-2016-02-02_(1.27.0-wmf.12): [Regression wmf.12] FocusableNode invisibles produces weird results with graph, templates and transclusions - https://phabricator.wikimedia.org/T125767#2003386 (10Jdforrester-WMF) This isn't resolved,... [19:37:39] achild: Is there a log in Parsoid of what went wrong? [19:39:03] "If this hasn't died in a fire by the end of September 2015, Roan has failed." [19:39:16] (ve.init.Platform.static.isInternetExplorer) [19:39:34] The error occurs while the loading and the following in the log: [fatal/request][dev-wiki.com/main_page] Did not find page revisions for Main_page [19:39:37] Krenair: Indeed. [19:40:12] achild: That means that the configuration for Parsoid is probably looking in the wrong place. Are you connecting via RESTbase or directly? [19:40:15] it's all reorg's fault. [19:40:40] I believe direct ... but I am open to recommendations and verification [19:41:20] (03CR) 10Alex Monk: [C: 032] Convert a bunch of HACK:/XXX:/FIXME: tags to a task reference [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/268716 (owner: 10Jforrester) [19:48:14] (03Merged) 10jenkins-bot: Convert a bunch of HACK:/XXX:/FIXME: tags to a task reference [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/268716 (owner: 10Jforrester) [19:57:04] 10VisualEditor, 10VisualEditor-MediaWiki: Occasional "docserver-http: HTTP 404" when trying to save an edit made in the visual editor - https://phabricator.wikimedia.org/T123708#2003490 (10Mbch331) February 4th, 16:15 CET https://nl.wikipedia.org/wiki/BOb_Van_Reeth Trying to add an infobox February 4th, 21:20... [20:01:38] James_F, so who's fixing https://gerrit.wikimedia.org/r/#/c/254082/ ? [20:06:11] edsanders: That's what I asked you. [20:07:14] 10VisualEditor, 10VisualEditor-MediaWiki, 6Editing-Analysis: Sample edit events in desktop visual editor at 6.25% - https://phabricator.wikimedia.org/T125598#2003510 (10Neil_P._Quinn_WMF) [20:07:16] 10VisualEditor, 6Editing-Analysis, 10MobileFrontend, 10Reading-Web, 5Patch-For-Review: Sample edit events in MobileFrontend at 6.25% - https://phabricator.wikimedia.org/T124845#2003511 (10Neil_P._Quinn_WMF) [20:08:21] edsanders: "Do you want to update https://gerrit.wikimedia.org/r/#/c/254082/ killing all the tests first, or do a new patch with them all in?" [20:12:32] I'll do it in another patch [20:13:20] In Cite? [20:21:49] James_F: my Apache logs shows the following error: PHP Fatal error: Call to undefined function curl_multi_init() in /opt/mediawiki-1.26.2/includes/libs/MultiHttpClient.php on line 412, referer: http://dev-wiki.risksense.com/mediawiki/index.php/Main_Page?veaction=edit [20:22:23] achild: Aha, you need to install php_curl. [20:22:46] 10VisualEditor, 10VisualEditor-MediaWiki, 6Editing-Analysis: Revise the Edit schema and its use - https://phabricator.wikimedia.org/T118063#2003552 (10Neil_P._Quinn_WMF) [20:23:36] achild: Some PHP environments don't have that by default, sorry. [20:25:10] Krenair: How terrible will it be to kill ParsoidURL/ParsoidHTTPProxy/etc.? It's been deprecated since ? 1.25.x I think. Prod doesn't use it, Beta Cluster doesn't use it, Vagrant doesn't use it… [20:26:52] James_F, so I think that's all configurable by VirtualRestConfig now [20:27:03] Yeah. [20:27:10] should be fine [20:27:21] they're only used as fallback in case you didn't set that up [20:27:37] new users upgrading will have to change their config [20:27:46] s/new // [20:27:59] 10Cite, 6TCB-Team, 7German-Community-Wishlist, 5Patch-For-Review: Section edit preview doesn't let you preview references defined outside the section being previewed - https://phabricator.wikimedia.org/T124840#2003560 (10Cenarium) I've added specific classes for each cite warning/error. In this case, the c... [20:29:13] Krenair: Yeah. [20:30:28] 10VisualEditor, 10VisualEditor-MediaWiki, 6Editing-Analysis: Revise the Edit schema and its use - https://phabricator.wikimedia.org/T118063#2003589 (10Neil_P._Quinn_WMF) [20:31:25] 10VisualEditor, 10VisualEditor-MediaWiki, 6Editing-Analysis: Revise the Edit schema and its use - https://phabricator.wikimedia.org/T118063#1790572 (10Neil_P._Quinn_WMF) [20:32:59] 10Cite, 5Patch-For-Review, 3Reading-Web-Sprint-65-Game of Phones: Save references in page_props and cache - https://phabricator.wikimedia.org/T125329#2003610 (10Cenarium) >>! In T125329#1989289, @phuedx wrote: > @Cenarium: Just FYI, #Reading-Web is tracking the progress of your patch(es) – because we're both... [20:33:53] 10VisualEditor, 10VisualEditor-MediaWiki, 6Editing-Analysis, 6Editing-Department, and 2 others: EventLogging validation error: 'user.id' is a required property (schema:Edit) - https://phabricator.wikimedia.org/T116717#2003615 (10Neil_P._Quinn_WMF) [20:33:57] 10VisualEditor, 10VisualEditor-MediaWiki, 6Editing-Analysis: Revise the Edit schema and its use - https://phabricator.wikimedia.org/T118063#2003612 (10Neil_P._Quinn_WMF) [20:35:18] James_F, Cite and ve-MW [20:39:55] (03PS1) 10Jforrester: [BREAKING CHANGE] Drop support for contacting Parsoid outwith VRS [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/268736 [20:39:58] edsanders: Kk. [20:40:12] edsanders: Anything I can do to help? [20:47:23] I don't know how to get CI to run properly with the extension [20:48:43] edsanders: What do you mean? Local testing? [20:50:50] edsanders: Special:JavaScriptTest/qunit/plain?hidepassed will run all registered extensions and their tests. [20:51:15] (03CR) 10jenkins-bot: [V: 04-1] [BREAKING CHANGE] Drop support for contacting Parsoid outwith VRS [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/268736 (owner: 10Jforrester) [20:51:46] edsanders: The issue with CI is making sure it gets all the different extensions we want to test at once; I /think/ that's now fixed after yesterday, and that patches in VE will get tested with a checkout of Cite master and v.v. [20:52:38] so why is it V-1? [20:53:01] edsanders: I don't know. [20:53:19] that's my question - who can we get to fix it? [20:53:24] (03PS1) 10Esanders: Remove mwReference tests, moved to Cite extension [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/268775 [20:54:40] edsanders: l.egoktm said he'd help over the weekend once he flew back from Down Under. [20:55:12] James_F: making progress now getting error loading data from server curl error: 6 can't resolve host name. What file would I need to edit? [20:56:20] achild: Have you followed https://www.mediawiki.org/wiki/Extension:VisualEditor#Linking_with_Parsoid – the host name etc. should be set in LocalSettings.php. [20:56:36] 10VisualEditor, 6Editing-Analysis, 10MobileFrontend, 10Reading-Web: Sample edit events in MobileFrontend at 6.25% - https://phabricator.wikimedia.org/T124845#2003700 (10Jdlrobson) [20:56:45] 10VisualEditor, 10VisualEditor-MediaWiki, 6Editing-Analysis: Revise the Edit schema and its use - https://phabricator.wikimedia.org/T118063#2003704 (10Jdlrobson) [20:56:47] 10VisualEditor, 6Editing-Analysis, 10MobileFrontend, 10Reading-Web: Sample edit events in MobileFrontend at 6.25% - https://phabricator.wikimedia.org/T124845#2003701 (10Jdlrobson) 5Open>3Resolved [20:58:43] 10VisualEditor, 6Editing-Department, 10MobileFrontend, 7Mobile, and 2 others: Enable editing for mobile users without JavaScript and kill Special:MobileEditor code in MobileFrontend - https://phabricator.wikimedia.org/T125174#2003711 (10Jdforrester-WMF) [21:00:32] (03PS1) 10Jforrester: composer.json: Pass `composer validate` [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/268795 [21:14:00] hmm. `$.isEmptyObject( null )` is true. [21:14:11] >> $.isEmptyObject( null ); [21:14:11] MatmaRex: ReferenceError: $ is not defined [21:14:23] ecmabot-wm should have jQuery loaded :( [21:14:59] MatmaRex: Fussy. :-) [21:15:32] grumblegrumble [21:16:12] i'm trying to work out https://phabricator.wikimedia.org/T124515 and i'm running into some high-wtf-quotient code in Scalable stuff [21:17:44] MatmaRex: Eww. Fun. [21:18:18] MatmaRex: BTW, did you see I made https://www.mediawiki.org/wiki/VisualEditor/Stats_fun using the cross-wiki upload tool; worked like a dream. [21:18:23] >> for (var i in null) {}; [21:18:24] MatmaRex: undefined [21:18:39] fascinating how that's not a big-ass exception. [21:18:50] James_F: :o [21:19:24] James_F: i uploaded the graphs for the cross-wiki upload A/B test results using it ;) [21:19:41] * James_F nods. [21:24:24] James_F: I am troubleshooting why I am getting that error when I can run curl -L http://dev-wiki.com:8142/dev-wiki.risksense.com/v3/page/html/main_page/ without an error [21:26:13] achild: What does your LocalSettings.php say for vrs? [21:27:38] James_F: Apologies what is vrs? [21:28:25] achild: Did you add a line of "$wgVirtualRestConfig['modules']['parsoid']" into your LocalSettings.php? [21:28:46] [VRS = VirtualRest(Service).] [21:29:50] Yes, with url, domain, and prefix. [21:31:10] Hmm. [21:34:36] I must have the wrong information in the prefix and domain fields [21:35:00] What is the best way to verify each of the fields [21:37:02] I'm not sure, sorry. [21:37:27] (03PS9) 10Esanders: Remove all Extension:Cite code, now moved there [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/254082 (owner: 10Jforrester) [21:37:29] (03PS2) 10Esanders: Remove mwReference tests, moved to Cite extension [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/268775 [21:40:52] edsanders: Ha! dirname( __DIR__ ) !== __DIR__ [21:41:11] ? [21:41:37] what? [21:41:50] I think it was dirname( __FILE__) == __DIR__, right? [21:41:51] edsanders: https://gerrit.wikimedia.org/r/#/c/268788/2..3/CiteHooks.php [21:41:54] or something [21:42:06] I copied that from somewhere else [21:42:36] We use 'localBasePath' => __DIR__, in VE. [21:42:55] It's in Graph and Math as well [21:42:55] Somewhere else might be defining hooks in a sub-directory of the extension, perhaps. [21:42:58] I know some evil extensions have /include etc. [21:43:26] 10Cite, 5Patch-For-Review, 3Reading-Web-Sprint-65-Game of Phones: Save references in page_props and cache - https://phabricator.wikimedia.org/T125329#2003930 (10kaldari) This is a lot of data to store in page_props. Are there any concerns about bloating that table? Might be worth pinging @jcrespo and @aaron. [21:43:42] well the code I submitted was working locally... [21:44:35] edsanders: Not locally for me, but with that change it does, I think. [21:44:53] edsanders: "Failed asserting that file "/mnt/jenkins-workspace/workspace/mediawiki-extensions-hhvm/src/extensions/modules/ve-cite/tests/ve.dm.citeExample.js" exists." [21:45:49] (03PS1) 10Jforrester: package.json: Make clear this is VE-MW not VE-core [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/268801 [21:46:07] (03CR) 10Esanders: [C: 031] Remove all Extension:Cite code, now moved there [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/254082 (owner: 10Jforrester) [21:48:34] we should create a failing test in VE that asserts that 'mwReference' is registered [21:48:43] for fixing CI [21:48:51] Sounds good. [21:49:07] Though I'm moderately confused as to why that wouldn't pass right now. [21:49:24] Ultimately nothing in VE-MW should know about mwReference, ideally. [21:50:19] no, but the Cite tests should run as part of ve-mw CI for sanity [21:50:52] Yes, but we should do that by configuring CI to run Cite when we change VE-MW so we know we're not breaking that. [21:50:56] Rather than hard-coding that into VE-MW. [21:51:15] * James_F waits impatiently for merge. [21:55:34] (03PS1) 10Esanders: NEVERMERGE VE tests should be loading the Cite module. [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/268803 [22:00:16] (03CR) 10jenkins-bot: [V: 04-1] NEVERMERGE VE tests should be loading the Cite module. [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/268803 (owner: 10Esanders) [22:03:52] (03CR) 10Jforrester: [C: 032] Remove mwReference tests, moved to Cite extension [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/268775 (owner: 10Esanders) [22:04:07] edsanders: OK, could you +2 https://gerrit.wikimedia.org/r/268810 and then I think we're good to land. [22:04:18] (03CR) 10Jforrester: [C: 032] Remove all Extension:Cite code, now moved there [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/254082 (owner: 10Jforrester) [22:06:13] edsanders: Oh, do we use extsrc from data-mw for references? https://gerrit.wikimedia.org/r/268718 says Parsoid are about to kill it as 'unused'. [22:06:27] Reading our code I can't quite tell if we're generating it ourselves or if we're using Parsoid's. [22:06:42] extsrc is wikitext isn't it [22:07:48] (so I hope not) [22:08:11] we use extsrc for general extensions [22:08:29] Ah, OK. [22:16:26] (03Merged) 10jenkins-bot: Remove mwReference tests, moved to Cite extension [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/268775 (owner: 10Esanders) [22:16:45] Woo. [22:17:11] (03Merged) 10jenkins-bot: Remove all Extension:Cite code, now moved there [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/254082 (owner: 10Jforrester) [22:22:21] James_F: Is there a way to test php_curl from the command line? [22:22:35] (03CR) 10Esanders: "Also if I put the delay here it's next to the code causing the delay. If I wrap the map initialisation code in a setTimeout it's way more " [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/268068 (https://phabricator.wikimedia.org/T125263) (owner: 10Esanders) [22:22:49] achild: php -e would do it, but I'm not an expert… [22:27:21] 10VisualEditor, 10VisualEditor-EditingTools, 6Multimedia, 5Patch-For-Review, 5WMF-deploy-2016-02-02_(1.27.0-wmf.12): Visual editor upload tool hangs when trying to insert newly uploaded image - https://phabricator.wikimedia.org/T124515#2004070 (10matmarex) 5Open>3Resolved >>! In T124515#1958997, @mat... [22:29:45] MatmaRex: Yay? [22:30:43] James_F: not yay. i don't know why that works, and it will no doubt break some day again. [22:31:03] :-( [22:31:53] James_F: the data is essentially passed there via global variables (ve.init.platform.imageInfoCache) [22:31:56] 10VisualEditor, 10Wikidata: html continues to say "Editing..." after I saved an edit using VisualEditor (and interwiki links are gone) - https://phabricator.wikimedia.org/T126077#2004089 (10aude) 3NEW [22:32:19] <MatmaRex> and this definitely depends on the order of some operations [22:32:45] <MatmaRex> so, i dunno, you might want to file some tech debt bugs, but i don't even know what needs fixing. [22:32:59] <MatmaRex> there are too many places pulling Scalable objects out of thin air [22:33:43] * James_F nods. [22:36:34] <wikibugs> 10VisualEditor, 10VisualEditor-Media, 10VisualEditor-MediaWiki, 7Technical-Debt: ve.dm.MWImageModel.prototype.resetDefaultDimensions: Calling `this.scalable.setDefaultDimensions( {} );` is a no-op - https://phabricator.wikimedia.org/T126078#2004102 (10matmarex) 3NEW [22:38:47] <wikibugs> 10VisualEditor, 10Wikidata: html <title> continues to say "Editing..." after I saved an edit using VisualEditor (and interwiki links are gone) - https://phabricator.wikimedia.org/T126077#2004118 (10aude) regarding no interwiki links, might be related to T47839 in the source of the page after save, I have: <!... [22:40:17] <wikibugs> 10VisualEditor, 10VisualEditor-Media, 10VisualEditor-MediaWiki: When user's preference for thumb size differs from default 220px, making any change in media dialog causes images to be resized from 220px to user's preference - https://phabricator.wikimedia.org/T126079#2004121 (10matmarex) 3NEW [22:40:19] <MatmaRex> grumble. [22:40:54] <wikibugs> 10VisualEditor, 10Wikidata: html <title> continues to say "Editing..." after I saved an edit using VisualEditor (and interwiki links are gone) - https://phabricator.wikimedia.org/T126077#2004132 (10aude) [22:41:12] * James_F hugs MatmaRex-who-is-awesome. [22:47:40] <wikibugs> 10VisualEditor, 10VisualEditor-MediaWiki: It is unclear what is supposed to be stored in ve.init.platform.imageInfoCache - https://phabricator.wikimedia.org/T126081#2004170 (10matmarex) 3NEW [22:47:45] <MatmaRex> there, that's the last one. [23:02:30] <Krenair> James_F, should boolean parameters be a checkbox or a radio input of some sort? [23:05:50] <James_F> Krenair: Checkbox I think. [23:06:25] <wikibugs> 10VisualEditor, 10VisualEditor-MediaWiki-Templates, 10MediaWiki-extensions-TemplateData, 7Design: Create dedicated input methods for transclusion parameters (using "Param#type" from TemplateData) - https://phabricator.wikimedia.org/T55613#2004236 (10Krenair) [23:19:45] <wikibugs> 10WikiEditor: Editing screen shouldn't re-shape or move after it is displayed - https://phabricator.wikimedia.org/T125843#2004328 (10GOIII) >>! In T125843#2003298, @Yurivict wrote: > Observing the problem in the classic editor, with options "Show the edit toolbar", "Enable enhanced editing toolbar" enabled. > .... [23:37:49] <wikibugs> 10Cite, 5Patch-For-Review, 3Reading-Web-Sprint-65-Game of Phones: Save references in page_props and cache - https://phabricator.wikimedia.org/T125329#2004413 (10jcrespo) I am blocking any non-regular addition of data to s2 (even if minimal) wikis until we promote the new master (hopefully on Tuesday), and ve... [23:48:14] <yurik> edsanders, hi, what do you think about https://phabricator.wikimedia.org/T125686 ? [23:48:38] <yurik> we outlined some ideas on better <maps> tag structure [23:55:47] <wikibugs> 10VisualEditor-MediaWiki-Plugins, 10MediaWiki-extensions-ProofreadPage, 6Wikisource, 7Community-Wishlist-Survey: Create a VisualEditor plugin to integrate with ProofreadPage - https://phabricator.wikimedia.org/T48580#2004482 (10DannyH) [23:57:01] <wikibugs> 10Cite, 5Patch-For-Review, 3Reading-Web-Sprint-65-Game of Phones: Save references in page_props and cache - https://phabricator.wikimedia.org/T125329#2004488 (10kaldari) Estimating the data size might be difficult for this. You could get a rough idea of the number of rows by querying for the number of unique...