[00:53:54] (03CR) 10Jforrester: JavaScript: Use single quotes instead of double quotes for strings (031 comment) [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/268955 (owner: 10Gerrit Patch Uploader) [00:54:49] 10VisualEditor, 10Parsoid: Inserting the English Wikipedia {{won}} template into a table cell using VisualEditor shows unnecessary code - https://phabricator.wikimedia.org/T124934#2007001 (10Jdforrester-WMF) [00:54:59] 10VisualEditor, 10Parsoid, 7Epic: Inserting the English Wikipedia {{won}} template into a table cell using VisualEditor shows unnecessary code - https://phabricator.wikimedia.org/T124934#2007003 (10Jdforrester-WMF) p:5Triage>3Low [01:08:31] James_F, did you see https://phabricator.wikimedia.org/T125864 ? [01:08:58] I don't know, I just copied Krinkle's comment. [01:09:26] 10VisualEditor, 10VisualEditor-MediaWiki: Fix the broken JS getCookie() call, which sets a cookie not recognised by the server - https://phabricator.wikimedia.org/T125864#2007021 (10Krenair) a:5Krenair>3Krinkle Apparently Krinkle knows what this is about. [01:11:05] Krenair: "Apparently"? It's copy-and-pasted from his code review on your code. :-) [01:11:30] Krenair: I imagine he might have meant "setCookie", but it's your code. :-) [01:18:29] (03CR) 10Jforrester: [C: 032] cloneElements: Use the correct node type when cloning [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/268963 (https://phabricator.wikimedia.org/T126169) (owner: 10Esanders) [01:18:59] 10VisualEditor, 10VisualEditor-CopyPaste, 5Patch-For-Review, 5WMF-deploy-2016-02-09_(1.27.0-wmf.13): [regression] Adjacent copied inline template is destroyed by Parsoid - https://phabricator.wikimedia.org/T126169#2007041 (10Jdforrester-WMF) p:5Triage>3High [01:20:16] (03CR) 10Jforrester: "I'd dearly love for there to be unit tests for this so it doesn't re-break again. :-(" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/268966 (https://phabricator.wikimedia.org/T126169) (owner: 10Esanders) [01:21:34] (03CR) 10Jforrester: [C: 032] KeyDownHandlers: Make Tab behave the same in table cells as in table selections [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/268898 (https://phabricator.wikimedia.org/T125378) (owner: 10Esanders) [01:21:53] 10VisualEditor, 10VisualEditor-Tables, 7RTL, 5WMF-deploy-2016-02-09_(1.27.0-wmf.13): Tab in tables in VisualEditor moves the wrong way in RTL - https://phabricator.wikimedia.org/T125378#2007049 (10Jdforrester-WMF) 5Open>3Resolved a:3Esanders [01:24:35] (03Merged) 10jenkins-bot: cloneElements: Use the correct node type when cloning [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/268963 (https://phabricator.wikimedia.org/T126169) (owner: 10Esanders) [01:24:49] (03CR) 10Jforrester: [C: 032] getViewportDimensions: Fix calculation of 'bottom' [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/268112 (owner: 10Esanders) [01:27:24] (03Merged) 10jenkins-bot: KeyDownHandlers: Make Tab behave the same in table cells as in table selections [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/268898 (https://phabricator.wikimedia.org/T125378) (owner: 10Esanders) [01:28:38] (03Merged) 10jenkins-bot: getViewportDimensions: Fix calculation of 'bottom' [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/268112 (owner: 10Esanders) [01:32:53] (03PS1) 10Jforrester: Update VE core submodule to master (c283af7) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/269077 [01:34:12] (03PS3) 10Jforrester: Fix transclusion node cloneElement method [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/268966 (https://phabricator.wikimedia.org/T126169) (owner: 10Esanders) [01:40:17] (03PS3) 10Jforrester: Follow-up I7e1edcf05c: Remove MonoBook z-index hack [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/268918 (owner: 10Esanders) [01:40:19] (03PS3) 10Jforrester: DesktopTarget: Move generic VE desktop styles into a separate module [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/268922 (owner: 10Esanders) [01:40:54] (03CR) 10Jforrester: [C: 032] "PS3: Rebase from underneath the queried commit." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/268922 (owner: 10Esanders) [01:41:15] (03CR) 10Jforrester: "PS3: Rebased to the other side of the stack given query." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/268918 (owner: 10Esanders) [01:47:18] 10Cite, 6TCB-Team, 7German-Community-Wishlist, 5Patch-For-Review, 7user-notice: Users should be (more) aware that references in section preview aren't a part of final rendered section - https://phabricator.wikimedia.org/T125981#2007068 (10Jdforrester-WMF) [01:55:05] 10VisualEditor, 10VisualEditor-DataModel, 6Discovery, 10Kartographer, and 3 others: Changing map size in VE does not save - https://phabricator.wikimedia.org/T126092#2007076 (10Jdforrester-WMF) a:3Esanders [01:55:12] 10VisualEditor, 10VisualEditor-DataModel, 6Discovery, 10Kartographer, and 2 others: Changing map size in VE does not save - https://phabricator.wikimedia.org/T126092#2007078 (10Jdforrester-WMF) 5Open>3Resolved [01:57:00] 10Cite, 6TCB-Team, 7German-Community-Wishlist, 5Patch-For-Review, 7user-notice: Users should be (more) aware that references in section preview aren't a part of final rendered section - https://phabricator.wikimedia.org/T125981#2007083 (10Jdforrester-WMF) 5Open>3Resolved (Not sure about whether this... [01:59:58] (03Merged) 10jenkins-bot: DesktopTarget: Move generic VE desktop styles into a separate module [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/268922 (owner: 10Esanders) [02:00:34] 10VisualEditor, 10VisualEditor-MediaWiki, 10VisualEditor-MediaWiki-Media, 6Multimedia, and 3 others: Give guidance in the new upload form, to prevent the most common errors - e.g. bad file titles - https://phabricator.wikimedia.org/T116086#2007089 (10Prtksxna) >>! In T116086#1999540, @Jdforrester-WMF wrote... [02:03:19] (03CR) 10Jforrester: "Does composer not have a 'private' flag, like npm? If not, could I implement one for them, or are they against it in principle?" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/268795 (owner: 10Jforrester) [02:08:11] (03CR) 10Jforrester: [C: 032] Fix transclusion node cloneElement method [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/268966 (https://phabricator.wikimedia.org/T126169) (owner: 10Esanders) [02:08:39] (03CR) 10Jforrester: Fix transclusion node cloneElement method (031 comment) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/268966 (https://phabricator.wikimedia.org/T126169) (owner: 10Esanders) [02:15:30] (03CR) 10Jforrester: JavaScript: Use single quotes instead of double quotes for strings (031 comment) [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/268955 (owner: 10Gerrit Patch Uploader) [02:45:20] Ho-hum [02:45:28] Maybe it might be a good idea to assert ES3-ness in our initinit code. :-) [03:16:08] (03PS1) 10Jforrester: build: Bump various devDeps to latest and make pass [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/269080 [03:40:17] (03PS1) 10Jforrester: build: Bump various devDeps to latest and make pass [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/269081 [03:42:50] 10VisualEditor, 10VisualEditor-EditingTools, 10VisualEditor-MediaWiki, 5WMF-deploy-2016-02-09_(1.27.0-wmf.13): Back out pending nodes/etc. on switching editor so that e.g. half-made references aren't created - https://phabricator.wikimedia.org/T125479#2007130 (10Jdforrester-WMF) [05:40:28] (03PS4) 10Gerrit Patch Uploader: Remove deferred loading of the toolbar [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/268968 (https://phabricator.wikimedia.org/T126138) [05:40:31] (03CR) 10Gerrit Patch Uploader: "This commit was uploaded using the Gerrit Patch Uploader [1]." [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/268968 (https://phabricator.wikimedia.org/T126138) (owner: 10Gerrit Patch Uploader) [05:45:41] (03CR) 10Fomafix: "This patch is superseded by I49909ef35b87ce9091cf9897f278adcc420c14aa which removes the entire deferred loading." [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/258746 (owner: 10Gerrit Patch Uploader) [06:53:00] 10VisualEditor, 10Parsoid, 7Epic: Inserting the English Wikipedia {{won}} template into a table cell using VisualEditor shows unnecessary code - https://phabricator.wikimedia.org/T124934#2007214 (10Amire80) [08:14:23] 10VisualEditor, 7I18n: [[MediaWiki:Apihelp-visualeditor-param-pst/eo]] i18n issue - https://phabricator.wikimedia.org/T125798#2007301 (10Psychoslave) Thank you very much. I would translate your explicited sentance as ''Se tiu estas asignata, prekonservtransformigi vikitekston antaŭ sendi la rezultantan prekon... [10:26:56] 10Cite, 6TCB-Team, 7German-Community-Wishlist, 5Patch-For-Review: Section edit preview doesn't let you preview references defined outside the section being previewed - https://phabricator.wikimedia.org/T124840#2007428 (10MGChecker) Why the references list is displayed as unordered list here: https://de.wik... [11:06:58] edsanders, hi, around? [11:09:16] edsanders, ping me when you get back - I wanted to pick your brain on how we should structure kartographer tags - we should resolve that issue soonish [11:38:30] 10Cite, 6TCB-Team, 7German-Community-Wishlist, 5Patch-For-Review: Section edit preview doesn't let you preview references defined outside the section being previewed - https://phabricator.wikimedia.org/T124840#2007548 (10Cenarium) This will be fixed along T125981. [11:49:18] (03PS1) 10Gerrit Patch Uploader: Use formatversion=2 for API request [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/269107 [11:49:21] (03CR) 10Gerrit Patch Uploader: "This commit was uploaded using the Gerrit Patch Uploader [1]." [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/269107 (owner: 10Gerrit Patch Uploader) [11:56:25] (03CR) 10Alex Monk: [C: 032] Update VE core submodule to master (c283af7) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/269077 (owner: 10Jforrester) [12:04:39] 10Cite, 6TCB-Team, 7German-Community-Wishlist, 5Patch-For-Review, 7user-notice: Users should be (more) aware that references in section preview aren't a part of final rendered section - https://phabricator.wikimedia.org/T125981#2007590 (10Johan) > (Not sure about whether this needs to be flagged for Tech... [12:12:56] (03Merged) 10jenkins-bot: Update VE core submodule to master (c283af7) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/269077 (owner: 10Jforrester) [12:26:59] (03CR) 10jenkins-bot: [V: 04-1] Fix transclusion node cloneElement method [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/268966 (https://phabricator.wikimedia.org/T126169) (owner: 10Esanders) [12:37:27] (03PS3) 10Bartosz Dziewoński: MWImageModel: Use clearDefaultDimensions [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/268900 (https://phabricator.wikimedia.org/T126078) (owner: 10Esanders) [12:37:42] (03CR) 10Bartosz Dziewoński: [C: 032] "OK, I trust you know what this does." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/268900 (https://phabricator.wikimedia.org/T126078) (owner: 10Esanders) [12:39:23] (03CR) 10Esanders: "recheck" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/268966 (https://phabricator.wikimedia.org/T126169) (owner: 10Esanders) [12:52:12] (03Merged) 10jenkins-bot: MWImageModel: Use clearDefaultDimensions [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/268900 (https://phabricator.wikimedia.org/T126078) (owner: 10Esanders) [15:16:16] 10VisualEditor, 7Browser-Tests, 5Patch-For-Review: Delete or fix failed VisualEditor browsertests Jenkins jobs - https://phabricator.wikimedia.org/T94162#2007907 (10zeljkofilipin) a:3zeljkofilipin [15:29:31] (03PS4) 10Esanders: Fix transclusion node cloneElement method [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/268966 (https://phabricator.wikimedia.org/T126169) [15:34:57] 10VisualEditor, 10VisualEditor-MediaWiki, 10VisualEditor-Tables, 5WMF-deploy-2016-02-02_(1.27.0-wmf.12): Support sortable columns in tables - https://phabricator.wikimedia.org/T95189#2007962 (10matmarex) 5Resolved>3Open The sortable styling patch was reverted in cbe1910f8719fd01ca902810ae9ab73b1256549a... [15:35:20] (03CR) 10Esanders: [C: 032] "per James" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/268966 (https://phabricator.wikimedia.org/T126169) (owner: 10Esanders) [15:56:30] 10VisualEditor, 10MediaWiki-Page-editing, 7Design: Preview showed me removing content that I'd never added - https://phabricator.wikimedia.org/T121185#2008036 (10awight) [15:58:39] 10VisualEditor, 10MediaWiki-Page-editing, 7Design: Preview showed me removing content that I'd never added - https://phabricator.wikimedia.org/T121185#2008046 (10awight) I can confirm that I saw this bug in the wikitext editor, so I would suggest removing the #VisualEditor tag. I would also say that, for th... [16:12:09] (03PS1) 10Esanders: Provide approximate preview of table sort styling [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/269153 (https://phabricator.wikimedia.org/T95189) [16:20:27] 10VisualEditor: Annotation tools not display correct state - https://phabricator.wikimedia.org/T126232#2008154 (10Esanders) 3NEW [16:26:17] (03CR) 10Bartosz Dziewoński: "Eh, this is kind of lame. You already have the table matrix, so it shouldn't be that much code to reproduce the tablesorter logic." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/269153 (https://phabricator.wikimedia.org/T95189) (owner: 10Esanders) [16:32:13] edsanders, ping [16:44:06] 10VisualEditor, 10VisualEditor-CopyPaste, 5WMF-deploy-2016-02-09_(1.27.0-wmf.13): [regression] Adjacent copied inline template is destroyed by Parsoid - https://phabricator.wikimedia.org/T126169#2008236 (10Jdforrester-WMF) 5Open>3Resolved [16:44:18] 10VisualEditor, 6Discovery, 10Kartographer, 10Maps, 5WMF-deploy-2016-02-09_(1.27.0-wmf.13): Copied adjacent extension objects collapsed on save - https://phabricator.wikimedia.org/T126114#2008238 (10Jdforrester-WMF) 5Open>3Resolved [17:13:55] (03CR) 10Divec: [C: 04-1] SurfaceFragment: Handle multi-range annotations correctly (031 comment) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/268669 (https://phabricator.wikimedia.org/T125978) (owner: 10Esanders) [17:15:58] (03PS4) 10DLynch: FocusableNode: watch for image loaded/layout changes for invisible icons [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/268437 (https://phabricator.wikimedia.org/T125767) [17:23:57] 10VisualEditor, 10VisualEditor-MediaWiki-Mobile, 7Browser-Support-Apple-Safari: Unable to scroll the "Review your changes" screen on mobile (iOS Safari 9.x) - https://phabricator.wikimedia.org/T126240#2008350 (10Jdforrester-WMF) 3NEW [17:24:45] 10VisualEditor, 10VisualEditor-Media, 10VisualEditor-MediaWiki, 7Technical-Debt, 5WMF-deploy-2016-02-09_(1.27.0-wmf.13): ve.dm.MWImageModel.prototype.resetDefaultDimensions: Calling `this.scalable.setDefaultDimensions( {} );` is a no-op - https://phabricator.wikimedia.org/T126078#2008361 (10Jdforrester-WM... [17:30:21] 10Cite: #cite_note and #cite_ref links generated from empty references are broken - https://phabricator.wikimedia.org/T126241#2008373 (10petr.matas) 3NEW [17:53:41] (03PS2) 10Alex Monk: build: Bump various devDeps to latest and make pass [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/269080 (owner: 10Jforrester) [17:57:56] (03PS3) 10Esanders: SurfaceFragment: Handle multi-range annotations correctly [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/268669 (https://phabricator.wikimedia.org/T125978) [17:58:28] (03CR) 10Alex Monk: [C: 032] build: Bump various devDeps to latest and make pass [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/269080 (owner: 10Jforrester) [17:58:54] 10Cite: #cite_note and #cite_ref links generated from empty references are broken - https://phabricator.wikimedia.org/T126241#2008536 (10petr.matas) [18:01:20] Hello again all. Sorry to bother...how do I make VE the editor for all pages. As an example I go to create a new page and VE is not available. [18:02:59] (03CR) 10Alex Monk: [C: 032] build: Bump various devDeps to latest and make pass [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/269081 (owner: 10Jforrester) [18:07:02] (03Merged) 10jenkins-bot: build: Bump various devDeps to latest and make pass [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/269080 (owner: 10Jforrester) [18:07:04] (03CR) 10jenkins-bot: [V: 04-1] SurfaceFragment: Handle multi-range annotations correctly [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/268669 (https://phabricator.wikimedia.org/T125978) (owner: 10Esanders) [18:18:06] (03Merged) 10jenkins-bot: build: Bump various devDeps to latest and make pass [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/269081 (owner: 10Jforrester) [18:18:13] 10Citoid: Support external link templates - https://phabricator.wikimedia.org/T126249#2008622 (10eranroz) 3NEW [18:24:12] (03PS1) 10Bartosz Dziewoński: Use MenuOptionWidget rather than OptionWidget for MenuSelectWidget items [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/269176 [18:24:35] 10Citoid: Support external link templates - https://phabricator.wikimedia.org/T126249#2008671 (10Johsthao) [18:24:37] (03PS4) 10Esanders: SurfaceFragment: Handle multi-range annotations correctly [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/268669 (https://phabricator.wikimedia.org/T125978) [18:24:48] 10Cite: #cite_note and #cite_ref links generated from empty references are broken - https://phabricator.wikimedia.org/T126241#2008679 (10Johsthao) [18:32:14] 10Citoid: Support external link templates - https://phabricator.wikimedia.org/T126249#2008779 (10matmarex) 5duplicate>3Open [18:32:34] 10Cite: #cite_note and #cite_ref links generated from empty references are broken - https://phabricator.wikimedia.org/T126241#2008787 (10matmarex) 5duplicate>3Open [18:36:04] 10VisualEditor, 10VisualEditor-CopyPaste, 10VisualEditor-MediaWiki-Links: Pasting text for a link label removes the link - https://phabricator.wikimedia.org/T121895#2008854 (10Cirdan) This was raised as a blocking issue on de-WP [[:de:Wikipedia_Diskussion:Meinungsbilder/VisualEditor_für_nicht_eingeloggte_und... [18:40:56] 10VisualEditor, 10VisualEditor-CopyPaste, 10VisualEditor-MediaWiki-Links: Pasting text for a link label removes the link - https://phabricator.wikimedia.org/T121895#2008892 (10Luke081515) ([[https://de.wikipedia.org/wiki/Wikipedia_Diskussion:Meinungsbilder/VisualEditor_f%C3%BCr_nicht_eingeloggte_und_neu_ange... [18:43:07] (03CR) 10Esanders: [C: 04-1] "See above comment." [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/268437 (https://phabricator.wikimedia.org/T125767) (owner: 10DLynch) [18:45:32] edsanders: What are we waiting on with https://gerrit.wikimedia.org/r/#/c/243979/ ("MediaSizeWidget: Allow an user to really use a custom size")? [18:57:48] 10Cite, 5Patch-For-Review, 3Reading-Web-Sprint-65-Game of Phones: Save references in page_props and cache - https://phabricator.wikimedia.org/T125329#2009019 (10Jdlrobson) > I am not the performance guy here, but what is the impact on saving? References HTML in a page on our larger pages currently accounts f... [19:00:50] legoktm: Hmm. If I add `"repositories": [ { "packagist": false } ]` to composer.json will that stop packagist publishing the repo? [19:07:00] 10Cite, 5Patch-For-Review, 3Reading-Web-Sprint-65-Game of Phones: Save references in page_props and cache - https://phabricator.wikimedia.org/T125329#2009043 (10jcrespo) > @jcrespo Is there anything blocking us from feature flagging this in the Cite extension and enabling it in on the beta cluster to get you... [19:09:59] (03PS2) 10Jforrester: composer.json: Pass `composer validate`, disable packagist pushes [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/268795 [19:18:57] (03CR) 10jenkins-bot: [V: 04-1] composer.json: Pass `composer validate`, disable packagist pushes [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/268795 (owner: 10Jforrester) [19:56:56] yurik, ping [19:57:29] James_F, it's still missing stuff I think [19:57:45] Kk. [19:57:54] per my comments on PS4 [19:59:17] also the use case it was designed for is wrong [19:59:38] … but other than that it's great? [20:00:20] it adds the unlock button to every widget [20:00:30] some dimension inputs can't be unlocked [20:02:29] (03CR) 10Esanders: [C: 04-1] "This adds the ability to unlock the ratio on every MediaSizeWidget, but some use cases don't allow this. ve.dm.Scalable needs to specify i" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/243979 (owner: 10Florianschmidtwelzow) [20:03:06] 10Cite, 5Patch-For-Review, 3Reading-Web-Sprint-65-Game of Phones: Save references in page_props and cache - https://phabricator.wikimedia.org/T125329#2009362 (10kaldari) My only worry is potentially affecting the performance of queries that join the page_props table. If we do decide to use that table, rather... [20:26:52] (03CR) 10DLynch: "You'd prefer the raw check on width / naturalWidth being put back into hasRendering in addition to the jQuery.width check, then?" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/268437 (https://phabricator.wikimedia.org/T125767) (owner: 10DLynch) [20:38:56] edsanders, i'm back, was in a meeting [20:44:43] edsanders, how do you think we should deal with multiple modes/tags? [20:46:29] Hello all. How do you add a table to an article and change the width of an article or page? [20:47:51] achild: To add a table, click Insert > Table. MediaWiki doesn't allow changing the width of a page, so I'm not sure what you're asking for on the latter? [20:54:18] James_F: I am attempting to move a set of documentation to mediawiki. The page layout is to wide I would like to control the page width to control the structure a bit better. [20:54:51] You want a fixed-width view of the page? [20:54:55] edsanders, Kemayo: How did you guys end up dealing with the newFromDocumentInsertion problem in https://gerrit.wikimedia.org/r/#/c/265660/ ? (And what was the problem, for that matter?) I meant to look at it after my vacation but I see it's merged now [20:55:04] yes [20:55:12] There are some skins that do that (or you can theoretically just hack it into Common.css). [20:56:19] if I happen to use a different skin they I lose VE right? So really my only option is to modify common.css [20:57:08] Well, it depends on the skin. If the skin is based off Vector it'll work with a single line change. [20:57:14] RoanKattouw, the issue was the way I was constructing transactions [20:57:44] I was queuing up all the removals (in reverse order to maintain offsets), then queuing up the insertions [20:57:53] Is there a repo somewhere that lists themes (skins) based on vector? [20:58:38] you can queue up insertions in reverse when they are normal [20:58:55] but if they are NFDI then each insertion changes the internalList offset [20:59:14] so you need to do them one at a time [20:59:14] Aah of course [21:01:54] * yurik pokes edsanders with thoughts [21:02:41] achild: I don't think so, no, sorry. Hacking it in Common.css should be fine. [21:02:58] yurik, I'm in favour of using one tag name [21:02:58] (even if I object morally on that course of action ;-)) [21:03:19] James_F: LOL thanks. Off the top does BootStrapSkin work with VE? [21:03:40] achild: No. [21:03:57] edsanders, i understand, but it will allow us much more flexibility and interface (typing) cleanliness if we use different ones. They all have somwhat different set of attributes, even though their body is the same geojson [21:04:15] James_F:Great since it costs money apparently. :) [21:07:08] yurik, there are quite a few extensions like that, extensions rarely have more than one name AFAIK other than as an alias [21:07:23] yurik, plus we'd have to write more VE code to support it :) [21:07:47] edsanders, we would have to write more code to support multiple sets of attributes (modes) regardless :( [21:08:06] (for modes) [21:08:10] I mean handling multiple tag names and outputting the correct one [21:08:29] you should ask some MW core people - they may have an opinion [21:08:43] Krinkle, RoanKattouw? ^^ [21:08:44] ok, i will raise it to some mailing list [21:08:51] or that :) [21:09:44] RoanKattouw, Krinkle - https://phabricator.wikimedia.org/T125686 [21:10:37] (td;dr: should maps use ,, or , , for different rendering modes) [21:13:15] edsanders, i was looking at your setgeojson patch - how would it handle geojson that was set by the mode=data? [21:13:40] in non-edit, all groups are sent as one big object [21:13:49] and each map has a list of groups to show [21:13:51] mode=data isn't really supported [21:14:07] but we only render an interactive map in the node if mode === 'interactive' and geoJSON is non-empty [21:14:22] mode=data renders as an icon I think [21:14:34] we should always render it inside the VE dialog, but only as an icon in text [21:14:56] Normally I would support in favor of , but mode=data seems very different [21:15:53] Why is there a data-only mode? Is that so that maps can be referred to from elsewhere? Why not make all maps work that way and version them separately? [21:16:34] RoanKattouw, yes, they all are fairly different -- mode=embed is a regular map, mode=link is a clickable link that pops up the map. Both can have some geojson elements drawn on top of them. But often you might want to have additional data definined elsewhere on the page, and that's where we use mode=data [21:16:43] edsanders: yurik: Creating three new tags seems like a mistake imho [21:17:41] Krinkle and RoanKattouw, i am on the fence about it also - could you review what options we have discussed in https://phabricator.wikimedia.org/T125686 -- there is a reason behind madness :) [21:17:47] Though if you do, at least prefix it (are dashes allowed?). map-{embed,data,link} [21:18:50] So it looks like it's not really three modes at all, and mode= doesn't really feel right [21:19:05] You're either defining map data, or linking to a map, or embedding a map [21:19:13] linkprefix/linksuffix attributes are bad idea too [21:19:58] yurik: What kind of purpose are these tags? Do they relate to providing custom geo data, or relate to picking a place on a globe and zoom level etc. [21:20:31] If the latter, I assume all three will use the same "pick a map position" editor [21:20:45] or input widget, rather [21:20:46] RoanKattouw, all three could define data, its just that wikivoyage (as a good example) wants to define each data point separately. Scroll down a bit from https://en.wikivoyage.org/wiki/Salzburg#Get_around [21:20:49] Krinkle, ^ [21:21:02] can't look further now [21:21:12] e-mail me or schedule a meeting. I'm packed this week. [21:21:33] Krinkle, i will add you to that phab ticket -- all the discussion is there. [21:21:34] (03PS1) 10Jforrester: ve.init.mw.trackSubscriber: Sample at 6.25% [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/269289 (https://phabricator.wikimedia.org/T125598) [21:23:06] (03PS1) 10Jforrester: ve.init.mw.trackSubscriber: Sample at 6.25% [extensions/VisualEditor] (wmf/1.27.0-wmf.12) - 10https://gerrit.wikimedia.org/r/269291 (https://phabricator.wikimedia.org/T125598) [21:24:27] edsanders, back to the groups question - in VE, is it possible to run through all map tags and assemble all the dataZ [21:25:27] so when drawing each map, we could do the same as done by the backend to assemble groups into one structure, but also to update all maps when one of the groups changes. [21:26:43] James_F: no, that'll just break trying to fetch dependencies I think [21:27:02] legoktm: Meh. Composer sucks. [21:31:08] yurik: That's basically how works. It's possible but it is laborious and a bit complicated [21:31:41] RoanKattouw, what part are you refering to? [21:31:50] "run through all map tags and assemble the data" [21:32:06] That sounds like the same thing that does, right? [21:32:48] yurik: Speaking of, what does the Parsoid output for this map stuff look like? [21:33:34] roan, interesting, thx. Re parsoid - no idea really - it is set up on vem3.wmflabs.org, including the parsoid's api [21:35:13] Well, I ask because we don't want to add more -like code to VE [21:35:21] i.e. code that requires multiple passes [21:35:28] Or Parsoid. [21:35:35] Ideally, the -related logic would be moved into Parsoid [21:35:41] (Ideally ideally, it wouldn't be that complicated) [21:37:17] (03CR) 10Alex Monk: [C: 032] ve.init.mw.trackSubscriber: Sample at 6.25% [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/269289 (https://phabricator.wikimedia.org/T125598) (owner: 10Jforrester) [21:37:23] RoanKattouw, so the need for "state" storage is because the map features (pushpins, highlighted areas, ...) could be defied separately from the map itself [21:37:31] see wikivoyage [21:37:43] Krenair: Thanks! [21:38:01] For some reason I thought we were already doing that [21:38:02] Krenair: (Scheduled for SWAT this afternoon so that it happens on all wikis at once, not over time.) [21:38:19] Krenair: Everywhere *except* VE we were. [21:38:55] and something in mobilefrontend? [21:39:18] RoanKattouw, they have a link for each attraction on the page, and clicking each shows the map with that specific feature in the center. But they all also show up in the map on the side of the article. [21:39:25] Yeah, sorry, "everywhere" == WikiEditor. [21:39:28] I've been talking to normal editors too much. :-) [21:39:33] haha [21:40:51] yurik, RoanKattouw yeah tags with look ahead / grouping are a bit evil - they stop us doing things like section editing properly. [21:42:19] edsanders, agree, but we don't have any alternatives at the moment. Ideas like multiple streams per article (per Daniel) have been floating, but nothing useful yet. It would be cool to store all this data in wikidata-like storage outside of the article [21:42:34] I imagine Performance would veto anything with that getting deployed. [21:42:54] i'm sure we could figure out performance aspect [21:42:56] (03CR) 10jenkins-bot: [V: 04-1] ve.init.mw.trackSubscriber: Sample at 6.25% [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/269289 (https://phabricator.wikimedia.org/T125598) (owner: 10Jforrester) [21:43:09] Oh, CI. [21:43:36] its not easy, i agree, but wikidata has managed to solve performance despite storing tiny data pieces in a separate storage [21:43:43] "at the moment" well yes, but once you go with the easy solution you can pretty much never go back [21:45:02] edsanders, we already are in that solution - all of wikivoyage uses their magic template to generate some magical tags that get picked up by an external database and drawn. What we are doing is a big step forward [21:45:05] James_F, that VE change is in the very long gate-and-submit queue :/ [21:45:22] Krenair: Yeah, no worries, it just needs to land in the next three hours. ;-) [21:45:28] Krenair: RelEng are working on it. [21:45:33] heh [21:45:45] yeah, we don't need jenkins to land stuff anyway [21:45:56] Well. No, but we ideally should. :-) [21:46:05] Also, php55 jobs are rolling out tomorrow. [21:46:21] And I'd really (really) like to have repos in a known-good state before we start breaking them with that. [21:46:38] Otherwise we won't know whether we're done. [21:46:56] Looks like the gate-and-submit queue is unclogging a bit [21:46:57] https://gerrit.wikimedia.org/r/#/c/269194/ just merged almost 2 hours after I +2ed it [21:47:26] yeah but changing every invocation on wikivoyage is nothing compared to en.wiki [21:47:50] One the -php53 job finishes on CirrusSearch, the queue should flush all the way down to the first VE change [21:48:52] outwith? [21:49:45] (03PS4) 10Alex Monk: [BREAKING CHANGE] Drop support for contacting Parsoid without VirtualRestConfig [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/268736 (owner: 10Jforrester) [21:49:53] edsanders, even though I really really don't want to do this, we could make it conditional for WV only [21:50:22] Krenair: It's the correct term. :-P [21:50:50] Google says it's Scottish. [21:51:22] edsanders, actually, i think all wikis will want this - because this way you can define a map somewhere in the middle of the article, but you can also place a link at the very top (where we currently have GPS coordinates) to popup that same map. [21:52:02] Wiktionary adds the North. [21:52:28] Krenair: Aka "English". [21:52:28] It's more precise. [21:52:46] * James_F shrugs. [21:53:22] James_F, did you try out https://gerrit.wikimedia.org/r/#/c/268854/ ? [21:53:44] Not yet, sorry. [21:54:01] * James_F will try to get some time. [21:54:38] James_F, I didn't expect you to have yet, I would've been surprised if you'd said yes.. :p Could you please do it at some point? :) [21:54:54] Krenair: Yessir. :-) [21:55:00] thanks [21:55:51] (03CR) 10jenkins-bot: [V: 04-1] [BREAKING CHANGE] Drop support for contacting Parsoid without VirtualRestConfig [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/268736 (owner: 10Jforrester) [21:56:14] (Regardless of the name, it's still broken.) [21:57:02] okay so [21:57:06] 21:55:47 The data provider specified for ApiDocumentationTest::testDocumentationExists is invalid. [21:57:06] 21:55:47 The VirtualRESTService for the document server is not defined [21:57:28] I guess it's set up to work with the variables we're removing back-compat for [21:57:41] do you know where those are configured? I imagine it's in an integration/* repo? [21:58:35] ohh, wait [21:58:41] maybe it's not set up to test with parsoid at all [21:59:04] Krenair: https://github.com/wikimedia/mediawiki/blob/HEAD/tests/phpunit/structure/ApiDocumentationTest.php [21:59:10] just relies on being able to create a VRS object, no matter how useless, because that's what we do in the constructor [21:59:41] Krenair: The VRS object is hard-coded in https://github.com/wikimedia/mediawiki/blob/HEAD/includes/libs/virtualrest/ParsoidVirtualRESTService.php [21:59:59] can we move the serviceClient->mount call to execute() ? [22:00:30] it has some defaults in there, yes [22:10:23] yurik, I don't think it would be worth all the effort just to avoid duplicating a pair of coords once - especially as in some cases the embedded map won't want the target in the perfect centre - so the coordinates may not be identical [22:11:50] edsanders, its not just the coordinates - take a look at the link and scroll down to the "See" section. https://en.wikivoyage.org/wiki/Salzburg#Get_around [22:13:24] the link is what describes each piece of data. I know it would be great to have another storage, but "nice" and "not available" are two different things - this feature is being implemented in the worst possible way - with an external labs-based service. This is bad, and should be fixed. Once we have more storage options, we can upgrade them all [22:22:09] (03CR) 10Alex Monk: "Could we move the serviceClient->mount call into the execute function?" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/268736 (owner: 10Jforrester) [22:22:54] 10Cite, 6TCB-Team, 7German-Community-Wishlist, 5WMF-deploy-2016-02-02_(1.27.0-wmf.12), 7user-notice: Edit preview doesn't let you preview cite.php footnotes. - https://phabricator.wikimedia.org/T7984#2009981 (10TheDJ) To all who had (and are still having) part in fixing these problems, there have already... [22:27:44] yurik, the markers should be in the map [22:27:55] everything else is just a link to that map [22:32:27] edsanders, baby steps - we should first match what already exists - users expectations. Afterwards, we may revisit this and shift the location of the data. Otherwise we once again try to dictate how things "should be" vs "how everyone expects them to be, and how they are now" [22:33:31] we cannot just introduce a new system and expect everyone to break all the processes. We should introduce something matching, and than work on converting [22:33:38] I disagree - if you build the product to match how it was hacked together in the past that makes it much harder to change it in the future [22:34:00] nor do I think wikivoyage is a massive use case one needs to tip-toe around [22:34:23] if you come up with a sensible system for en.wiki and get widespread adoption, WV will follow suite [22:34:47] especially if that's the only way to get the supported editing tools [22:37:50] WIll VE support a BootStrap3 skin? [22:38:00] this is also a valid point. My opinion is that it is better to have this feature, as it will be useful in a number of cases. I might agree that we don't have to support groups in VE from the start. [22:40:09] (03CR) 10Esanders: "I'd prefer an event based solution to the polling solution..." [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/268437 (https://phabricator.wikimedia.org/T125767) (owner: 10DLynch) [22:51:37] yurik, that's not my point - we shouldn't design a system that requires document-wide context to render [22:53:07] nor make bad architectural decisions based on a tiny sister project's use case [22:55:21] (03CR) 10Esanders: "possibly" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/268918 (owner: 10Esanders) [22:57:55] (03CR) 10Esanders: "buildHeaders looks pretty complex and I don't like the idea of duplicating that logic - I'd rather make upstream fixes to tableSorter to h" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/269153 (https://phabricator.wikimedia.org/T95189) (owner: 10Esanders) [22:59:19] (03CR) 10Esanders: "Also I think it's an incremental improvement in that currently the table looks like it isn't sortable when it is, and changing the sortabl" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/269153 (https://phabricator.wikimedia.org/T95189) (owner: 10Esanders) [23:01:20] I have a VE question on how to insert a tab? Currently they are grayed out in my UI. [23:12:18] achild: You mean a tab character? That's not possible, sorry. The indent/outdent buttons are (currently) for editing lists only. If you want just a regular paragraph but indented, choose "blockquote" from the formatting menu (or press Ctrl+8). [23:20:28] James_F: Perfect Thank you [23:23:24] (03CR) 10DLynch: "I can do that, I just have to go back on the change made in response to your earlier complaint. :P" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/268437 (https://phabricator.wikimedia.org/T125767) (owner: 10DLynch) [23:39:54] edsanders|away, we already do that - in references. We should be consistent - if its required for some features, we should make it available to all features because that is what we are being asked to do by the editors. If we introduce a better system, we should migrate everything to it [23:41:21] yurik: We did it once in 2003 when we didn't know better, and wouldn't ever allow it again. [23:41:37] yurik: And yes, replacing the Cite extension is on the list. [23:42:20] James_F, replacing with what? do you have any other mechanism at the moment to do something that has page-wide autocounting? [23:42:39] i ran it by tim, and he was totally fine with our approach [23:42:40] yurik: CSS. [23:42:40] yurik: See ext.cite. [23:43:12] CSS does not work for complex case like maps - i need to have those pre-generated [23:43:29] geojson needs to be somehow constructed on both client and server side [23:57:43] (03CR) 10Bartosz Dziewoński: "Well, I imagine it'd go something like this: https://phabricator.wikimedia.org/F3325021 – that code has some TODOs, because I don't really" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/269153 (https://phabricator.wikimedia.org/T95189) (owner: 10Esanders)