[00:29:38] (03CR) 10jenkins-bot: [V: 04-1] ve.init.mw.trackSubscriber: Sample at 6.25% [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/269289 (https://phabricator.wikimedia.org/T125598) (owner: 10Jforrester) [00:31:15] (03CR) 10Hashar: [C: 032] ve.init.mw.trackSubscriber: Sample at 6.25% [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/269289 (https://phabricator.wikimedia.org/T125598) (owner: 10Jforrester) [00:44:55] (03CR) 10Hashar: ve.init.mw.trackSubscriber: Sample at 6.25% [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/269289 (https://phabricator.wikimedia.org/T125598) (owner: 10Jforrester) [00:45:02] (03CR) 10Hashar: [C: 032] "+2 again. Zuul went crazy." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/269289 (https://phabricator.wikimedia.org/T125598) (owner: 10Jforrester) [00:51:03] 10VisualEditor, 10VisualEditor-MediaWiki, 7Design, 7Epic: Change VE integration to only use one edit tab, to avoid user choice paralysis - https://phabricator.wikimedia.org/T58337#2010424 (10Jdforrester-WMF) [00:51:06] 10VisualEditor, 10VisualEditor-MediaWiki, 6Editing-Department, 10MediaWiki-Page-editing, 5WMF-deploy-2016-02-09_(1.27.0-wmf.13): When CustomEditor is used, the EditPage robot policy isn't loaded - https://phabricator.wikimedia.org/T126145#2010422 (10Jdforrester-WMF) 5Open>3Resolved [00:54:59] (03CR) 10Jforrester: [C: 032] ve.init.mw.trackSubscriber: Sample at 6.25% [extensions/VisualEditor] (wmf/1.27.0-wmf.12) - 10https://gerrit.wikimedia.org/r/269291 (https://phabricator.wikimedia.org/T125598) (owner: 10Jforrester) [01:01:13] (03CR) 10Jforrester: [V: 032] ve.init.mw.trackSubscriber: Sample at 6.25% [extensions/VisualEditor] (wmf/1.27.0-wmf.12) - 10https://gerrit.wikimedia.org/r/269291 (https://phabricator.wikimedia.org/T125598) (owner: 10Jforrester) [01:06:25] (03Merged) 10jenkins-bot: ve.init.mw.trackSubscriber: Sample at 6.25% [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/269289 (https://phabricator.wikimedia.org/T125598) (owner: 10Jforrester) [01:36:42] (03CR) 10Divec: [C: 04-1] "Looking good ..." (033 comments) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/268669 (https://phabricator.wikimedia.org/T125978) (owner: 10Esanders) [01:41:03] 10Cite, 5Patch-For-Review: #cite_note and #cite_ref links generated from empty references are broken - https://phabricator.wikimedia.org/T126241#2010510 (10matmarex) You should be seeing a big fat red error on that page, though, which is apparently suppressed on en.wp somehow… [01:41:18] 10VisualEditor, 10VisualEditor-MediaWiki, 6Editing-Analysis: Revise the Edit schema and its use - https://phabricator.wikimedia.org/T118063#2010514 (10Jdforrester-WMF) [01:41:20] 10VisualEditor, 10VisualEditor-MediaWiki, 6Editing-Analysis, 5WMF-deploy-2016-02-02_(1.27.0-wmf.12), 5WMF-deploy-2016-02-09_(1.27.0-wmf.13): Sample edit events in desktop visual editor at 6.25% - https://phabricator.wikimedia.org/T125598#2010511 (10Jdforrester-WMF) 5Open>3Resolved [01:47:47] 10Cite, 5Patch-For-Review: #cite_note and #cite_ref links generated from empty references are broken - https://phabricator.wikimedia.org/T126241#2010525 (10petr.matas) @matmarex Yes, if I switch to Czech language, I do see it, but in English I don't. [01:48:49] 10Cite, 5Patch-For-Review: #cite_note and #cite_ref links generated from empty references are broken - https://phabricator.wikimedia.org/T126241#2010527 (10petr.matas) The patch also fixes the following problem: Reproduction steps: Use the empty named reference twice Expected behavior: Two backlinks are gener... [01:52:55] (03PS1) 10Jforrester: mw.trackSubscriber: Force event.id to 0 if the user is anon [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/269353 (https://phabricator.wikimedia.org/T116717) [02:06:35] (03PS5) 10Jforrester: mw.trackSubscriber: Handle timeStamp being undef/NaN/infinite [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/249143 (https://phabricator.wikimedia.org/T116718) [02:06:41] (03PS5) 10Jforrester: mw.trackSubscriber: If the number is NaN/falsy, return -1; [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/249149 (https://phabricator.wikimedia.org/T116718) [02:10:09] 10VisualEditor, 6Community-Liaison, 7Documentation: Write help page for using citoid in VisualEditor - https://phabricator.wikimedia.org/T108980#2010551 (10Whatamidoing-WMF) [02:11:27] (03PS5) 10Jforrester: SurfaceFragment: Handle multi-range annotations correctly [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/268669 (https://phabricator.wikimedia.org/T125978) (owner: 10Esanders) [02:11:32] (03CR) 10Jforrester: SurfaceFragment: Handle multi-range annotations correctly (033 comments) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/268669 (https://phabricator.wikimedia.org/T125978) (owner: 10Esanders) [02:13:43] RoanKattouw: https://phabricator.wikimedia.org/T126081 [02:26:11] 10VisualEditor, 10VisualEditor-MediaWiki, 6Editing-Analysis, 5WMF-deploy-2016-02-02_(1.27.0-wmf.12), 5WMF-deploy-2016-02-09_(1.27.0-wmf.13): Sample edit events in desktop visual editor at 6.25% - https://phabricator.wikimedia.org/T125598#2010562 (10Jdforrester-WMF) Data: {F3325443} [03:14:18] (03CR) 10Divec: [C: 032] SurfaceFragment: Handle multi-range annotations correctly [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/268669 (https://phabricator.wikimedia.org/T125978) (owner: 10Esanders) [03:23:52] (03Merged) 10jenkins-bot: SurfaceFragment: Handle multi-range annotations correctly [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/268669 (https://phabricator.wikimedia.org/T125978) (owner: 10Esanders) [04:03:56] (03PS1) 10Divec: Handle Enter keyPress without matching keyDown [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/269362 [04:10:06] (03CR) 10jenkins-bot: [V: 04-1] Handle Enter keyPress without matching keyDown [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/269362 (owner: 10Divec) [04:40:06] (03PS2) 10Divec: Handle Enter keyPress without matching keyDown [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/269362 [04:45:05] (03CR) 10Jforrester: "Can you rebase I19a38a624 onto this?" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/269362 (owner: 10Divec) [04:48:11] (03PS2) 10Divec: IME tests: Add failing Korean IME test [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/268316 (https://phabricator.wikimedia.org/T120156) (owner: 10Jforrester) [04:49:14] (03CR) 10Divec: "Rebase onto I51e3275c8371c3b5ca28dd95838499a87fb04328" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/268316 (https://phabricator.wikimedia.org/T120156) (owner: 10Jforrester) [04:52:07] (03CR) 10Divec: "Rebased I19a38a624 onto this as requested. Can you confirm whether this fixes T120156 in Firefox?" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/269362 (owner: 10Divec) [04:53:22] (03CR) 10jenkins-bot: [V: 04-1] IME tests: Add failing Korean IME test [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/268316 (https://phabricator.wikimedia.org/T120156) (owner: 10Jforrester) [04:55:09] (03CR) 10Divec: "@Esanders: care to review whether this evil workround is at the correct level of generality?" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/269362 (owner: 10Divec) [04:57:38] (03PS3) 10Divec: Handle Enter keyPress without matching keyDown [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/269362 [04:57:59] (03PS3) 10Divec: IME tests: Add failing Korean IME test [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/268316 (https://phabricator.wikimedia.org/T120156) (owner: 10Jforrester) [05:07:47] (03CR) 10jenkins-bot: [V: 04-1] IME tests: Add failing Korean IME test [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/268316 (https://phabricator.wikimedia.org/T120156) (owner: 10Jforrester) [10:57:10] 10VisualEditor: Unable to enter a small image size for panorama size images - https://phabricator.wikimedia.org/T126315#2011043 (10Raymond) 3NEW [12:11:28] edsanders|away, i think the best course of action would be to enable VE maps editor just for the , and the two other tags ( and ) only enable for wikivoyage, without VE support. This way we can move forward with the new functionality, while still supporting their existing environment [12:53:31] yurik, I don't see the obsession with wikivoyage - it represents 0.01% of our potential users and the most complex edge cases [12:54:01] we should focus on the needs of the Wikipedia sites [12:55:05] edsanders, unless we heed at least to some of the requests from non en-wikipedia, we will never develop them. They are a good testbed for new functionality, they are much more flexible adapting new features, and much easier to work with [12:55:14] also as soon as you deploy that feature people will never let you turn it off if it requires them to migrate their content - they'll want the old way that "just works" even if it will never have VE spport [12:55:55] yurik, they're not the only place we can develop new features - we have tons of smaller wikis [12:56:29] edsanders, i am ok with not enabling the link & data on the wikipedias just yet - until we have some semblance of an agreement [12:56:45] i know, but they stand to benefit the most from the maps [12:57:01] (in terms of impact per visitor) [12:57:11] maps and wikivoyage are highly related [12:57:24] wikipedias are not map-centric [12:57:26] but there are no visitors [12:57:42] so should we close them? [12:57:54] there are orders of magnitude more people who look at and edit maps on Wikipedia the WV [12:57:54] *than [12:58:17] no, but we shouldn't focus our engineering efforts around them - nor cripple our software for their benefit [12:59:15] ed, they are already doing it this way. Until we can provide an alternative, let them continue doing it - it is the core of their workflow. I am totally ok to discuss better approaches [12:59:22] data is our biggest problem IMO [12:59:39] yes - they can continue to use whatever hacks they are using [12:59:41] and we should address it, and once that's available, it should be trivial to write a script to copy stuff [12:59:53] but don't build those hacks into the extension [13:00:11] we are not ok with them using external site (even if its wmflabs) for all visitors [13:00:17] its a security issue [13:00:41] we do not want to allow a DEFAULT (not-user-initiated) view of a page to hit external resources [13:01:21] hence we need to provide a simple workaround. Without VE, this is a trivial code that will make their live much better [13:01:31] i'm ok to not develop VE support for that extra feature [13:01:58] but we need to migrate them regardless [13:04:50] Ed, i know it sucks in the "grand scheme of things". We do need a better unified data storage, sharable between wikis, embedable into any map. We do want auto-counting of sorts, so that each embeded feature could have its own index (reference), etc. But we don't have any of that yet. [13:05:45] so we have to fix what is majorly broken now with something that is "less broken". Lets try to fix things iteratively, not one giant leap at a time that takes years [14:01:10] yurik, what data is being pulled from wmflabs at the moment [14:02:58] Hello, anyone here? [14:03:50] hi [14:04:50] edsanders, https://en.wikivoyage.org/wiki/Salzburg -- pulls all the javascript to create the map, plus pulls the data to draw the marks [14:05:08] the data comes from parsing wikimarkup of the page itself [14:05:19] a roundtrip [14:07:19] you can migrate that code to the local wiki if wmflabs is all you're concerned about [14:08:22] I am trying to get visualeditor up and running with vagrant. I've been able to enable visualeditor role successfully, but it seems that parsoid doesnt work, it doesnt parse between mediatext and html when editing a page. How can I tackle this problem? [14:08:46] Chinny_, do you ave the parsoid and restbase roles enabled? [14:09:11] Do I have to enable those roles separately? [14:09:33] and no i haven't. [14:10:25] you can list all roles to see if they are enabled [14:10:44] I am enabling them now] [14:15:09] nope, i still see wikitext when editing a page [14:16:02] (03CR) 10Bartosz Dziewoński: [C: 032] "This dates back to 6f446e0d1ad2422c9bb7f92464dd71016a0ea441 (Nov 2014). The issue was fixed in MonoBook in dd4e7ccb8ab92255e93901865cc9dd9" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/268918 (owner: 10Esanders) [14:17:48] parsoid, restbase and visualeditor are enabled now. Am I missing something? [14:28:18] (03Merged) 10jenkins-bot: Follow-up I7e1edcf05c: Remove MonoBook z-index hack [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/268918 (owner: 10Esanders) [14:36:57] Any ideas? [14:37:01] Chinny_, in the wikitext edit is there a pencil icon in the top right corner? [14:37:34] It says "Error loading data from server: HTTP 0" [14:37:36] it has probably remembered your last editor as the wikitext editor [14:37:47] did you do vagrant provision? [14:39:30] Yes, I did [14:40:13] It still gives the same error [14:44:39] Should I try to reinstall vagrant? [15:02:20] Well.. it still doesnt work, still gives "Error loading data from server: HTTP 0" as a error. Im out of ideas [15:17:09] edsanders, that would be harder - the code is not written to our standards, and would have to be significantly rewritten to pass the security and quality. Plus we would have to run some magical additional services and databases to do all that. Not likely. [16:09:53] ferdbold, hi, any luck updating to vega2? [16:10:43] yurik: yes, it works great ;) now all that's left is to properly handle legacy graphs while in VE [16:11:03] ferdbold, crash is the best way to handle them :) [16:11:20] i would probably have finished it already if I wasn't stuck in vagrant limbo right now [16:11:45] well I did crash ve mobile once, I'm sure I can do it again haha [16:12:06] Good Morning all. I have another VE question how do I change font and text color? If not in VE is there another location where I can do this? [16:13:02] (03PS5) 10DLynch: FocusableNode: watch for image loaded/layout changes for invisible icons [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/268437 (https://phabricator.wikimedia.org/T125767) [16:13:15] (03CR) 10Alex Monk: [C: 04-1] "user.id is already set above" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/269353 (https://phabricator.wikimedia.org/T116717) (owner: 10Jforrester) [16:15:30] (03CR) 10jenkins-bot: [V: 04-1] FocusableNode: watch for image loaded/layout changes for invisible icons [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/268437 (https://phabricator.wikimedia.org/T125767) (owner: 10DLynch) [16:16:42] (03CR) 10Jforrester: "> user.id is already set above" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/269353 (https://phabricator.wikimedia.org/T116717) (owner: 10Jforrester) [16:18:15] (03PS6) 10DLynch: FocusableNode: watch for image loaded/layout changes for invisible icons [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/268437 (https://phabricator.wikimedia.org/T125767) [16:20:31] I am looking to try a skin named Timeless, I am unable to determine if it is based on Vector does anyone know if VE works with that skin. [16:23:15] achild: It won't; you have to add it to VisualEditorSupportedSkins. [16:23:36] achild: But just adding it there won't make it work if it doesn't have the right structure. [16:23:51] achild: (Re-writing all of MediaWiki's skins system so that every skins supports VE is on the roadmap… just very far down the road.) [16:26:18] James_F: I know how that goes. I will keep looking for a skin that is supported. Did you happen to catch my question on fonts and font color? [16:30:20] achild: I didn't. [16:30:20] * James_F reads scrollback. [16:31:15] Do you want to let regular users set the font and font colours as they edit? Or just "for all pages"? [16:34:09] I want to set a standard font across the platform. I would like to be able to set color on specific text as call outs. i.e. RED (text red) - High Risk, etc [16:34:33] 10VisualEditor: VE feedback tool fails to post feedback when you click "File" - https://phabricator.wikimedia.org/T126347#2011741 (10Sj) 3NEW [16:40:00] 10VisualEditor: Extremely slow & laggy editing for long page w/many citations - https://phabricator.wikimedia.org/T126348#2011760 (10Sj) 3NEW [16:40:43] 10VisualEditor: Extremely slow & laggy editing for long page w/many citations - https://phabricator.wikimedia.org/T126348#2011769 (10Sj) [16:42:01] Oh, so some tools to make text red or grey or whatever? There's nothing built into VisualEditor for that, no. It'd be possible to write one relatively easily though. [16:46:09] James_F: Excellent, is that something that I can do? Or would it be something I should table for a while? [16:49:31] achild: You could, but it'd involve getting to know how VE works. :-) [16:50:26] achild: You'd need to build something like a ve.ui.RedTextTool which provides a button in the annotations menu. [16:50:57] achild: See ve.ui.AnnotationTool.js in VE-core for a number of these for bold/italic/code/strikethrough/etc. [16:51:30] achild: I'd imagine you could just use the existing ve.dm.FontAnnotation stuff for the model side. [16:57:00] James_F: Thanks I'll have a look. Do you have a list of confirmed skins that work with VE? I tired Metrolook which is based on Vector but no longer have an edit button. [17:02:50] achild: Vector, apex, monobook, minerva and blueprint. [17:02:51] (03PS1) 10Alex Monk: Use NumberInputWidget for number template parameter fields [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/269433 (https://phabricator.wikimedia.org/T124850) [17:05:27] 10VisualEditor, 10VisualEditor-MediaWiki, 5WMF-deploy-2016-02-02_(1.27.0-wmf.12): [Regression wmf.11] Source and VE edit tabs have the word appearing next to them for some users on enwiki (very old cached HTML/JS?) - https://phabricator.wikimedia.org/T125249#2011822 (10Krenair) Krinkle, what do y... [17:08:51] ferdbold, check out what edsanders has been making for the maps! http://vem3.wmflabs.org/wiki/Main_Page [17:09:04] would you be interested in poking at it? :) [17:16:04] James_F: I'm looking at the stable skins wiki page and I am unable to find: Apex, Minerva or Blueprint does anyone have links? [17:21:09] (03PS2) 10Alex Monk: Use NumberInputWidget for number template parameter fields [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/269433 (https://phabricator.wikimedia.org/T124850) [17:22:03] achild: Minerva is the name of the skin inside MobileFrontend; don't worry about that one. Blueprint is https://www.mediawiki.org/wiki/Skin:Blueprint and Apex is https://www.mediawiki.org/wiki/Skin:Apex [17:28:43] 10VisualEditor, 10VisualEditor-MediaWiki: In single edit tab mode, when you load VE directly by browsing to action=edit, and it fails to load, bad things happen - https://phabricator.wikimedia.org/T125998#2011887 (10Krenair) @Jdforrester-WMF: So what should be the proper behaviour in this case? [17:34:49] James_F: Thank you. [17:35:06] (03CR) 10Alex Monk: "I doubt trying to set it twice is going to achieve much. Also, commit message - it's user.id, not event.id." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/269353 (https://phabricator.wikimedia.org/T116717) (owner: 10Jforrester) [17:35:50] (03PS2) 10Jforrester: mw.trackSubscriber: Force event.user.id to 0 if the user is anon [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/269353 (https://phabricator.wikimedia.org/T116717) [18:00:14] (03PS1) 10DLynch: [WIP] Subdocuments: Current uses of Document are contained in a DocumentSet [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/269449 [18:03:01] (03CR) 10jenkins-bot: [V: 04-1] [WIP] Subdocuments: Current uses of Document are contained in a DocumentSet [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/269449 (owner: 10DLynch) [18:10:50] Krenair: https://phabricator.wikimedia.org/T125249#2011822 [18:11:02] Krenair: Have you been able to observe it yourself? [18:11:11] Krenair: Does it come from JS or HTML output? [18:11:44] I haven't been able to observe it myself [18:11:55] the caching issue anyway [18:12:16] the is added by *old* JS depending on how you set up the TabMessages data [18:12:30] our *new* data caused it to appear [18:12:47] TabMessages and the code that does this are part of the same RL module [18:12:55] You're saying current master JS is not capable of generating those texts? [18:13:36] The screenshot on the task shows a tab called "Page" which is non-standard, the title is also blue. [18:14:32] yes [18:15:11] undefined !== null [18:15:12] nice [18:20:59] Krenair: The assertion of the config and the js being in the same module, that is incorrect [18:21:07] the custom veinitmodule only provides the message keys [18:21:29] The config object itself comes from a hook [18:21:29] wgVisualEditorConfig [18:21:41] which deploys near instantantly [18:22:02] However module updates go through the same path [18:22:20] the new startup module repsonse will contain the new config and the new version hash of the js module [18:22:23] Krinkle: Status update on https://gerrit.wikimedia.org/r/#/c/265878/ ? [18:22:23] (03PS2) 10DLynch: [WIP] Subdocuments: Current uses of Document are contained in a DocumentSet [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/269449 [18:22:37] However this is likely another instance of scap race conditions. Which makes all odds off [18:22:39] Krinkle: It's blocking our quarterly goal still. [18:22:47] Touching the js file and syncing again will do it, Krenair [18:23:09] That's the "oh, *fine*, I'll make code-style pass as well" update. [18:23:14] James_F: Has the first patch on the ve side been merged? [18:23:34] Krinkle: Yes, last week. [18:23:41] k [18:24:23] VE second patch needs rebase thoguh [18:24:26] I'm testing it now and will rebase it [18:24:29] Thanks. [18:24:34] Krinkle, ah, right, I misunderstood VisualEditorDesktopArticleTargetInitModule [18:24:36] and didn't read it properly [18:25:16] Krinkle, all right, thanks [18:26:24] (03CR) 10jenkins-bot: [V: 04-1] [WIP] Subdocuments: Current uses of Document are contained in a DocumentSet [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/269449 (owner: 10DLynch) [18:26:50] (The documentation complaints can wait.) [18:28:12] Kemayo: Neat. [18:30:34] Kemayo: Looks fancy. [18:31:24] (03PS3) 10DLynch: [WIP] Subdocuments: Current uses of Document are contained in a DocumentSet [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/269449 [18:31:34] (03PS4) 10Krinkle: Send users whose browsers support JS but are unsupported by MW to the WTE using venoscript=1 [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/265879 (https://phabricator.wikimedia.org/T123457) (owner: 10Alex Monk) [18:32:22] Kemayo: Should probably list all the TODOs/HACKs/etc. as SUBDOCUMENT TODOs I guess? [18:32:58] 10VisualEditor, 10VisualEditor-MediaWiki, 5WMF-deploy-2016-02-02_(1.27.0-wmf.12): [Regression wmf.11] Source and VE edit tabs have the word appearing next to them for some users on enwiki (very old cached HTML/JS?) - https://phabricator.wikimedia.org/T125249#2012068 (10Krenair) Based on chatting... [18:33:02] There are currently 20 "SUBDOCUMENT TODO"s in there. :D [18:33:17] Exception in module-execute in module ext.visualEditor.desktopArticleTarget.init: TypeError: mw.user.isAnon is not a function [18:33:19] Krenair: ^ [18:33:49] Kemayo: Clearly there should be 25. :-) [18:34:01] Granted. [18:34:55] Krinkle: That's… odd. [18:35:18] Krinkle: ext.visualEditor.desktopArticleTarget.init depends on a bunch of things but not mw.User; should it? [18:35:30] If it's using that then yes [18:35:43] It depends on user.options which I'd have thought includes mw.User. [18:35:45] Krinkle, are we missing a mediawiki.user dependency? [18:36:18] Looks that way [18:36:36] That would explain the issue about user.id not being set as well [18:36:41] Yeah. [18:36:48] ext.visualEditor.mediawiki has it as dependency, but not init [18:36:50] mediawiki sets up a skeleton mw.user object without all of the methods you'd expect [18:36:52] Which is much earlier [18:37:15] (03PS1) 10Jforrester: ext.visualEditor.desktopArticleTarget.init: Depend on mediawiki.user too [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/269454 [18:37:29] ^^^ [18:37:37] (03CR) 10Krinkle: [C: 032] ext.visualEditor.desktopArticleTarget.init: Depend on mediawiki.user too [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/269454 (owner: 10Jforrester) [18:37:56] VE wont' load for me without that change [18:38:09] You're probably more lucky in prod [18:38:20] Ha. [18:38:20] Yeah. [18:38:28] I've got installed: 'EventLogging', 'WikimediaEvents', 'BetaFeatures', 'Cite', 'cldr', 'GlobalCssJs', 'Interwiki', 'ParserFunctions', 'SyntaxHighlight_GeSHi', 'TemplateData', 'VisualEditor', 'WikiEditor', [18:38:46] but no, wait, this doesn't explain the user.id thing [18:39:02] "modules/ve-mw/init/ve.init.mw.trackSubscriber.js" is included as part of ext.visualEditor.mediawiki [18:39:06] which depends on mediawiki.user [18:39:31] (03PS1) 10Jforrester: ext.visualEditor.desktopArticleTarget.init: Depend on mediawiki.user too [extensions/VisualEditor] (wmf/1.27.0-wmf.12) - 10https://gerrit.wikimedia.org/r/269455 [18:39:47] (03PS1) 10Jforrester: ext.visualEditor.desktopArticleTarget.init: Depend on mediawiki.user too [extensions/VisualEditor] (wmf/1.27.0-wmf.13) - 10https://gerrit.wikimedia.org/r/269456 [18:40:18] I'm getting a lot of these events locally: [18:40:18] {"event":{"property":"visualeditor-editor","value":"\"visualeditor\"","isDefault":false,"version":"1","userId":1,"saveTimestamp":"20160203161751"},"schema":"PrefUpdate [18:40:30] Is that supposed to trigger repeatedly for the same user? [18:40:50] Because it is [18:40:56] basically all my page views as logged-in localhost [18:41:32] We might be saving that preference without checking the existing value [18:41:58] which is probably unnecessary [18:42:49] - } else { [18:42:50] + } else if ( mw.user.options.get( 'visualeditor-editor' ) !== editor ) { [18:42:50] return new mw.Api().saveOption( 'visualeditor-editor', editor ).then( function () { [18:43:14] (03PS1) 10Alex Monk: Revert "Re-add null appendix tab messages to extension.json" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/269457 (https://phabricator.wikimedia.org/T125249) [18:45:20] (03CR) 10Krinkle: [C: 031] Revert "Re-add null appendix tab messages to extension.json" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/269457 (https://phabricator.wikimedia.org/T125249) (owner: 10Alex Monk) [18:48:43] (03Merged) 10jenkins-bot: ext.visualEditor.desktopArticleTarget.init: Depend on mediawiki.user too [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/269454 (owner: 10Jforrester) [18:53:25] (03PS1) 10Alex Monk: Don't try to tell the server to set preferences to their current values [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/269462 [18:54:34] Krenair: Prefix size matches :) http://i.imgur.com/KWah0WE.png [18:55:12] Krinkle: Shouldn't the code be equally minimised? [18:55:26] Yeah, core will be minified further at some point. [18:56:47] :) [18:59:55] (03CR) 10Jforrester: "Dupe of Ib051c7cf9 :-P" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/269457 (https://phabricator.wikimedia.org/T125249) (owner: 10Alex Monk) [19:00:01] (03CR) 10Jforrester: [C: 031] Revert "Re-add null appendix tab messages to extension.json" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/269457 (https://phabricator.wikimedia.org/T125249) (owner: 10Alex Monk) [19:04:16] (03PS5) 10Krinkle: Send users whose browsers support JS but are unsupported by MW to the WTE using venoscript=1 [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/265879 (https://phabricator.wikimedia.org/T123457) (owner: 10Alex Monk) [19:05:39] James_F: Is it supposed to say "Edit source" instead of "Edit" as the tab label after being noscript'ed? [19:05:50] I saw that happen locally and seemed somewhat unexpected [19:06:13] Krinkle: Yes. [19:06:41] Krinkle: Logged-in users get a tab label reflecting what will happen when they click on it, unless they have an 'always WT' option, in which case it's just "Edit". [19:07:05] Krinkle: Logged-out users' tabs can't vary without FOUC, so we just leave them as "Edit" always. [19:08:13] Krinkle: I expect "eventually" we'll replace the text of the tab with a pencil (or whatever) icon, if Reading carry out the skin simplification ideas that have been floating around for years. [19:08:15] (03CR) 10Krinkle: [C: 031] Don't try to tell the server to set preferences to their current values [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/269462 (owner: 10Alex Monk) [19:09:07] Removing the last-standing edge case of where it becomes "Edit source" and keeping it as "Edit" would also be a step forward meho [19:09:09] imho [19:09:22] anyway [19:09:35] Maybe. [19:09:47] So; NORLQ good to merge? [19:11:47] (03CR) 10Krinkle: [C: 031] "Verified to work (with User-Agent MSIE 7) and code looks good." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/265879 (https://phabricator.wikimedia.org/T123457) (owner: 10Alex Monk) [19:12:11] Krinkle: Yay. Thank you. [19:12:51] Yep [19:13:10] Krinkle: Do you need anything from us? [19:15:38] 10VisualEditor: Wrong style of Table of Contents displays when saving a page at Wikivoyage - https://phabricator.wikimedia.org/T126361#2012186 (10Whatamidoing-WMF) 3NEW [19:16:14] 10VisualEditor, 10VisualEditor-MediaWiki, 7Design, 7Epic: Change VE integration to only use one edit tab, to avoid user choice paralysis - https://phabricator.wikimedia.org/T58337#2012196 (10Krinkle) [19:16:17] 10VisualEditor, 10VisualEditor-MediaWiki: Fix the broken JS getCookie() call, which sets a cookie not recognised by the server - https://phabricator.wikimedia.org/T125864#2012194 (10Krinkle) 5Open>3Invalid ```lang=php private static function getUserEditor( User $user, WebRequest $req ) { if ( $user->isA... [19:19:03] James_F: Not at the moment, thanks [19:38:27] 10VisualEditor, 10VisualEditor-MediaWiki, 5Patch-For-Review: On single edit tab wikis, if your browser runs JS but is only grade C supported (no MW JS) you probably get a blank edit page and no way to fix it - https://phabricator.wikimedia.org/T123457#2012303 (10Jdforrester-WMF) [19:38:37] (03CR) 10Jforrester: [C: 032] Send users whose browsers support JS but are unsupported by MW to the WTE using venoscript=1 [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/265879 (https://phabricator.wikimedia.org/T123457) (owner: 10Alex Monk) [19:57:45] 10VisualEditor, 10ContentTranslation-cxserver, 10Parsoid, 10RESTBase, and 2 others: Is RDFa metadata in Parsoid HTML head actually useful to you / no user name & edit comment suppression in Parsoid metadata - https://phabricator.wikimedia.org/T122390#2012355 (10Catrope) >>! In T122390#1956753, @Esan... [19:59:06] 10VisualEditor: Consider a way to make "changing the title" (moving the page) more obvious to new users in the visual editor - https://phabricator.wikimedia.org/T126368#2012365 (10Whatamidoing-WMF) 3NEW [20:03:27] (03Merged) 10jenkins-bot: Send users whose browsers support JS but are unsupported by MW to the WTE using venoscript=1 [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/265879 (https://phabricator.wikimedia.org/T123457) (owner: 10Alex Monk) [20:04:36] 10VisualEditor, 10VisualEditor-MediaWiki, 10Wikidata, 10Wikidata-Page-Banner: Wrong style of Table of Contents displays when saving a page at Wikivoyage - https://phabricator.wikimedia.org/T126361#2012394 (10Jdforrester-WMF) [20:05:47] 10Cite, 10VisualEditor, 10VisualEditor-MediaWiki-References, 7Performance: Extremely slow & laggy editing for long page w/many citations - https://phabricator.wikimedia.org/T126348#2012398 (10Jdforrester-WMF) p:5Triage>3High [20:09:08] 10VisualEditor, 10VisualEditor-Media, 10VisualEditor-MediaWiki-Media: Unable to enter a '1' as the x image size for panorama size images as the aspect ratio forces it to be larger - https://phabricator.wikimedia.org/T126315#2012422 (10Jdforrester-WMF) p:5Triage>3Low [20:09:44] 10VisualEditor, 10VisualEditor-ContentEditable, 10VisualEditor-EditingTools: Annotation tools do not display correct state in some sitations - https://phabricator.wikimedia.org/T126232#2012430 (10Jdforrester-WMF) p:5Triage>3Normal [20:10:15] 10VisualEditor, 10VisualEditor-MediaWiki, 10MediaWiki-extensions-ContentTranslation, 7Community-Wishlist-Survey, 7Epic: Merge the Content Translation tool and VisualEditor - https://phabricator.wikimedia.org/T121475#2012436 (10Jdforrester-WMF) p:5Triage>3Lowest [20:10:47] 10VisualEditor, 10VisualEditor-MediaWiki: It is unclear what is supposed to be stored in ve.init.platform.imageInfoCache - https://phabricator.wikimedia.org/T126081#2012440 (10Jdforrester-WMF) This is used for efficiently sizing/editing of media in the edit page, isn't it? [20:10:54] 10VisualEditor, 10VisualEditor-MediaWiki, 7Technical-Debt: It is unclear what is supposed to be stored in ve.init.platform.imageInfoCache - https://phabricator.wikimedia.org/T126081#2012441 (10Jdforrester-WMF) [20:11:52] 10VisualEditor, 10VisualEditor-Media, 10VisualEditor-MediaWiki: When user's preference for thumb size differs from default 220px, making any change in media dialog causes images to be resized from 220px to user's preference - https://phabricator.wikimedia.org/T126079#2012447 (10Jdforrester-WMF) [20:11:54] 10VisualEditor, 10VisualEditor-EditingTools: VisualEditor: Image should not change size when going from read to edit - https://phabricator.wikimedia.org/T69047#2012448 (10Jdforrester-WMF) [20:12:15] 10VisualEditor, 10VisualEditor-MediaWiki, 10Wikidata: html continues to say "Editing..." after I saved an edit using VisualEditor (and interwiki links are gone) - https://phabricator.wikimedia.org/T126077#2012453 (10Jdforrester-WMF) p:5Triage>3Normal [20:12:37] <wikibugs> 10VisualEditor, 10VisualEditor-CopyPaste, 10VisualEditor-MediaWiki-References: Black cloud upon pasting a ref into the Basic citation dialog - https://phabricator.wikimedia.org/T126047#2012456 (10Jdforrester-WMF) p:5Triage>3High [20:13:46] <wikibugs> 10VisualEditor, 10VisualEditor-MediaWiki-References: A small dialog with drop down appears on the top-left corner while trying to add an existing group reference - https://phabricator.wikimedia.org/T125862#2012464 (10Jdforrester-WMF) p:5Triage>3Normal [20:14:12] <wikibugs> 10VisualEditor, 10OOjs-UI: Provide Ctrl+Enter as a keyboard shortcut to confirm OOui dialogs - https://phabricator.wikimedia.org/T125860#2012468 (10Jdforrester-WMF) [20:14:33] <wikibugs> 10VisualEditor, 10OOjs-UI: Provide Ctrl+Enter as a keyboard shortcut to confirm OOui dialogs - https://phabricator.wikimedia.org/T125860#1999196 (10Jdforrester-WMF) p:5Triage>3Normal [20:17:14] <wikibugs> 10VisualEditor, 10VisualEditor-Tables, 10Parsoid: Deleting a colspan column breaks the table layout failing to adjust the rowspan (also leaving an extra empty row) - https://phabricator.wikimedia.org/T125703#2012487 (10Jdforrester-WMF) I can't reproduce. The display I get in the visual editor is: | ColA | |... [20:17:24] <wikibugs> 10VisualEditor, 10VisualEditor-Tables, 10Parsoid: Deleting a colspan column breaks the table layout failing to adjust the rowspan (also leaving an extra empty row) - https://phabricator.wikimedia.org/T125703#2012488 (10Jdforrester-WMF) 5Open>3stalled [20:19:11] <wikibugs> 10VisualEditor: Loss of edits due to accidental click to leave page - https://phabricator.wikimedia.org/T125679#2012502 (10Jdforrester-WMF) This might have been a gadget? It works fine for me. [20:19:21] <wikibugs> 10VisualEditor: Loss of edits due to accidental click to leave page - https://phabricator.wikimedia.org/T125679#2012504 (10Jdforrester-WMF) 5Open>3stalled [20:19:38] <wikibugs> 10VisualEditor, 10VisualEditor-MediaWiki: Failing to switch from the wikitext editor into VE 3 times in a row leaves you with a useless page - https://phabricator.wikimedia.org/T125580#2012505 (10Jdforrester-WMF) p:5Triage>3Normal [20:20:10] <wikibugs> 10VisualEditor, 10VisualEditor-MediaWiki: Make the "Discard changes" message for bi-directional switching clearer - https://phabricator.wikimedia.org/T125481#2012510 (10Jdforrester-WMF) 5Open>3stalled [20:22:08] <wikibugs> 10VisualEditor: Punctuation after end line link should not be isolated in the next line - https://phabricator.wikimedia.org/T125454#2012521 (10Jdforrester-WMF) I believe that this is browser behaviour, and there's not much that we can do. (Please file the second issue as a separate task, yes.) [20:22:25] <wikibugs> 10VisualEditor: Punctuation after end line link should not be isolated in the next line - https://phabricator.wikimedia.org/T125454#2012524 (10Jdforrester-WMF) 5Open>3stalled [20:22:56] <wikibugs> 10VisualEditor: [Regression] Continuously getting an error about editing a old revision of the page with VE - https://phabricator.wikimedia.org/T125437#2012526 (10Jdforrester-WMF) Any update on reproduction steps here? [20:23:38] <wikibugs> 10VisualEditor: Find and replace feature froze my browser - https://phabricator.wikimedia.org/T125277#2012528 (10Jdforrester-WMF) Hmm. The function is already limited for performance reasons. Does it happen on long pages more than short ones? [20:23:59] <wikibugs> 10VisualEditor, 10VisualEditor-EditingTools: Backspacing at the start of a bulleted list item should convert item to plain paragraph before combining with the previous element - https://phabricator.wikimedia.org/T125148#2012531 (10Jdforrester-WMF) p:5Triage>3Low [20:24:20] <wikibugs> 10VisualEditor, 10VisualEditor-Tables, 10Parsoid: Deleting a colspan column breaks the table layout failing to adjust the rowspan (also leaving an extra empty row) - https://phabricator.wikimedia.org/T125703#2012535 (10JAufrecht) [20:24:37] <wikibugs> 10VisualEditor, 10VisualEditor-MediaWiki: Trying to save without an Internet connection loses all your work; should prompt you after a timeout (?) - https://phabricator.wikimedia.org/T125032#2012536 (10Jdforrester-WMF) p:5Triage>3Normal [20:25:10] <wikibugs> 10VisualEditor, 10VisualEditor-ContentEditable, 10VisualEditor-CopyPaste: Alien tables: copy / paste causes errors - https://phabricator.wikimedia.org/T124933#2012542 (10Jdforrester-WMF) p:5Triage>3High [20:27:32] <wikibugs> 10VisualEditor: Pasting bullets containing templates indents incorrectly - https://phabricator.wikimedia.org/T124730#2012577 (10Jdforrester-WMF) 5Open>3stalled This is expected behaviour. The content you cut and pasted was not just "a bullet", it was the start of a list. Pasting a list into a list inserts it... [20:28:16] <wikibugs> 10VisualEditor, 10VisualEditor-MediaWiki-Media: Follow {{Commonscat}} to find appropriate images for an article, if that template and/or a link to a category on Commons is present on the page - https://phabricator.wikimedia.org/T124709#2012582 (10Jdforrester-WMF) 5Open>3stalled This could plausibly be done... [20:29:34] <wikibugs> 10Citoid, 10VisualEditor: Automaticly convert bare-formated references - https://phabricator.wikimedia.org/T124610#2012589 (10Jdforrester-WMF) 5Open>3stalled For bare URL references we provide a tool to convert them (`<ref>foo.com</ref>` -> `<ref>{{cite news…}}</ref>`), but I can't see how hand-written pro... [20:31:15] <wikibugs> 10VisualEditor, 10VisualEditor-MediaWiki, 7Design, 7Epic: Change VE integration to only use one edit tab, to avoid user choice paralysis - https://phabricator.wikimedia.org/T58337#2012594 (10Jdforrester-WMF) [20:31:18] <wikibugs> 10VisualEditor, 10VisualEditor-MediaWiki, 5WMF-deploy-2016-02-09_(1.27.0-wmf.13): On single edit tab wikis, if your browser runs JS but is only grade C supported (no MW JS) you probably get a blank edit page and no way to fix it - https://phabricator.wikimedia.org/T123457#2012592 (10Jdforrester-WMF) 5Open>... [20:32:05] <wikibugs> 10VisualEditor, 10VisualEditor-MediaWiki: In single edit tab mode, when you load VE directly by browsing to action=edit, and it fails to load, bad things happen - https://phabricator.wikimedia.org/T125998#2012597 (10Jdforrester-WMF) Fallback to an editor, any editor. [20:32:36] <grrrit-wm> (03Abandoned) 10Jforrester: mw.trackSubscriber: Force event.user.id to 0 if the user is anon [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/269353 (https://phabricator.wikimedia.org/T116717) (owner: 10Jforrester) [20:32:58] <wikibugs> 10VisualEditor, 10VisualEditor-MediaWiki, 6Editing-Analysis, 6Editing-Department, and 3 others: EventLogging validation error: 'user.id' is a required property (schema:Edit) - https://phabricator.wikimedia.org/T116717#2012604 (10Jdforrester-WMF) Probably fixed by https://gerrit.wikimedia.org/r/#/q/I8df684a... [20:33:13] <wikibugs> 10VisualEditor, 10VisualEditor-MediaWiki, 6Editing-Analysis: Revise the Edit schema and its use - https://phabricator.wikimedia.org/T118063#2012610 (10Jdforrester-WMF) [20:33:15] <wikibugs> 10VisualEditor, 10VisualEditor-MediaWiki, 6Editing-Analysis, 6Editing-Department, and 4 others: EventLogging validation error: 'user.id' is a required property (schema:Edit) - https://phabricator.wikimedia.org/T116717#2012607 (10Jdforrester-WMF) 5Open>3Resolved a:3Jdforrester-WMF [20:33:27] <wikibugs> 10VisualEditor: Pasting bullets containing templates indents incorrectly - https://phabricator.wikimedia.org/T124730#2012612 (10ksmith) But what about the "Three" appearing on a separate line, rather than on a bullet line? The argument that selecting the first bullet is "selecting a list" rather than "selecting... [20:39:12] <wikibugs> 10Citoid, 10VisualEditor: Automaticly convert bare-formated references - https://phabricator.wikimedia.org/T124610#2012621 (10Josve05a) >>! In T124610#2012589, @Jdforrester-WMF wrote: > For bare URL references we provide a tool to convert them (`<ref>foo.com</ref>` -> `<ref>{{cite news…}}</ref>`), but I can't... [20:39:42] <wikibugs> 10VisualEditor: [Regression wmf.13] Math node is failing to parse, not getting rendered, showing error in the console " "TypeError: this.model is null" - https://phabricator.wikimedia.org/T126371#2012622 (10Ryasmeen) 3NEW [20:40:35] <wikibugs> 10VisualEditor: [Regression wmf.13] Math node is failing to get parsed, not getting rendered, showing error in the console " "TypeError: this.model is null" - https://phabricator.wikimedia.org/T126371#2012637 (10Ryasmeen) [20:42:06] <wikibugs> 10VisualEditor: Button labels are not appearing for Reference list dialog - https://phabricator.wikimedia.org/T126373#2012645 (10Ryasmeen) 3NEW [20:46:52] <wikibugs> 10VisualEditor, 7Browser-Support-Firefox: With Firefox, punctuation isolated in a new line after a link blocks left arrow key - https://phabricator.wikimedia.org/T126374#2012664 (10Pols12) 3NEW [20:47:10] <wikibugs> 10VisualEditor: Sort is not working correctly for tables - https://phabricator.wikimedia.org/T126375#2012675 (10Ryasmeen) 3NEW [20:48:13] <wikibugs> 10VisualEditor: Punctuation after end line link should not be isolated in the next line - https://phabricator.wikimedia.org/T125454#1987869 (10Pols12) [20:54:01] <wikibugs> 10VisualEditor: Sort is not working correctly for tables - https://phabricator.wikimedia.org/T126375#2012707 (10Ryasmeen) [21:00:44] <wikibugs> 10VisualEditor: Sort is not working correctly for tables - https://phabricator.wikimedia.org/T126375#2012718 (10Ryasmeen) I think its trying to sort all the columns at once and making things go wrong in that attempt while it should only sort data in one column. Its easily reproducible when you have another colum... [21:11:01] <wikibugs> 10VisualEditor: Punctuation after end line link should not be isolated in the next line - https://phabricator.wikimedia.org/T125454#2012761 (10Pols12) HTML structure is : <a class="ve-ce-linkAnnotation ve-ce-mwInternalLinkAnnotation new ve-ce-linkAnnotation-active"> <img class="ve-ce-nail ve-ce-nail-post... [21:22:24] <wikibugs> 10VisualEditor, 10VisualEditor-EditingTools: Backspacing at the start of a bulleted list item should convert item to plain paragraph before combining with the previous element - https://phabricator.wikimedia.org/T125148#2012801 (10Neil_P._Quinn_WMF) [21:34:37] <grrrit-wm> (03PS1) 10Jforrester: Update OOjs UI to v0.15.3 [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/269534 [21:36:04] <wikibugs> 10VisualEditor, 10VisualEditor-MediaWiki, 10MediaWiki-extensions-TemplateData: Add a mecanism to mark templates without TemplateData - https://phabricator.wikimedia.org/T126382#2012835 (10MGChecker) 3NEW [21:36:22] <grrrit-wm> (03CR) 10Bartosz Dziewoński: [C: 032] Update OOjs UI to v0.15.3 [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/269534 (owner: 10Jforrester) [21:39:32] <James_F> Krenair: Thoughts on Ed's comments on https://gerrit.wikimedia.org/r/#/c/252345/ ? This is now the last thing before going to Design. [21:49:24] <grrrit-wm> (03Merged) 10jenkins-bot: Update OOjs UI to v0.15.3 [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/269534 (owner: 10Jforrester) [21:52:47] <wikibugs> 10TemplateData, 10VisualEditor, 10VisualEditor-MediaWiki: Add a mecanism to mark templates without TemplateData - https://phabricator.wikimedia.org/T126382#2012891 (10Krenair) This is a duplicate of either {T52368} or {T72242}, or both. [21:54:53] <grrrit-wm> (03CR) 10Alex Monk: "Yes, let's add veswitched=1 to the query string when posting. I don't think it's going to be the most fragile thing we're implementing. :)" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/252345 (owner: 10Esanders) [22:03:44] <grrrit-wm> (03CR) 10Jforrester: "> Rebased I19a38a624 onto this as requested. Can you confirm whether this fixes T120156 in Firefox?" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/269362 (owner: 10Divec) [22:04:43] <James_F> Krenair: https://phabricator.wikimedia.org/T125998#2012597 isn't very helpful of me, I know. :-) [22:04:53] <Krenair> Indeed. [22:05:10] <Krenair> I could probably send the user to the wikitext editor, but I forget whether that sets their last used preference or not [22:10:05] <wikibugs> 10VisualEditor, 10ContentTranslation-cxserver, 10Parsoid, 10RESTBase, and 2 others: Is RDFa metadata in Parsoid HTML head actually useful to you / no user name & edit comment suppression in Parsoid <head> metadata - https://phabricator.wikimedia.org/T122390#2012969 (10mobrovac) >>! In T122390#2012355, @Cat... [22:45:16] <wikibugs> 10VisualEditor: Sort is not working correctly for tables - https://phabricator.wikimedia.org/T126375#2013140 (10matmarex) This is read mode, though, not during VE-editing? If so, #mediawiki-jquery-tablesorter :) If it's that, then this looks like the expected behavior to me. It's meant to sort the rows of the t... [22:50:50] <grrrit-wm> (03PS1) 10Esanders: Use plain DOM in ve.ce.LinkAnnotation [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/269546 (https://phabricator.wikimedia.org/T126348) [22:55:08] <grrrit-wm> (03CR) 10Catrope: [C: 04-1] Use plain DOM in ve.ce.LinkAnnotation (031 comment) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/269546 (https://phabricator.wikimedia.org/T126348) (owner: 10Esanders) [22:55:14] <grrrit-wm> (03CR) 10jenkins-bot: [V: 04-1] Use plain DOM in ve.ce.LinkAnnotation [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/269546 (https://phabricator.wikimedia.org/T126348) (owner: 10Esanders) [22:55:31] <grrrit-wm> (03CR) 10Jforrester: Use plain DOM in ve.ce.LinkAnnotation (031 comment) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/269546 (https://phabricator.wikimedia.org/T126348) (owner: 10Esanders) [22:59:44] <thedj> James_F: quite some good feedback on the en.wp page wrt a session with first time users of VE and Wikipedia. [23:00:38] <James_F> thedj: Thanks. Will look. [23:29:21] <grrrit-wm> (03PS2) 10Esanders: Use plain DOM in ve.ce.LinkAnnotation [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/269546 (https://phabricator.wikimedia.org/T126348) [23:34:15] <wikibugs> 10Citoid, 10scap, 3Scap3: Deploy Citoid with scap3 - https://phabricator.wikimedia.org/T116337#2013378 (10greg) [23:38:23] <wikibugs> 10VisualEditor, 10VisualEditor-MediaWiki: Trying to save without an Internet connection loses all your work; should prompt you after a timeout (?) - https://phabricator.wikimedia.org/T125032#2013443 (10Krenair) I just get an immediate "Unknown error". [23:39:01] <wikibugs> 10VisualEditor, 10VisualEditor-ContentEditable: Cursoring jumps over references - https://phabricator.wikimedia.org/T126401#2013445 (10Esanders) 3NEW [23:43:57] <wikibugs> 10VisualEditor, 10ContentTranslation-cxserver, 10Parsoid, 10RESTBase, and 2 others: Is RDFa metadata in Parsoid HTML head actually useful to you / no user name & edit comment suppression in Parsoid <head> metadata - https://phabricator.wikimedia.org/T122390#2013477 (10Catrope) >>! In T122390#2012969, @mobr... [23:55:37] <wikibugs> 10VisualEditor, 10VisualEditor-MediaWiki, 10VisualEditor-MediaWiki-References, 10VisualEditor-MediaWiki-Templates, 10Parsoid: Ref generating templates show reflists when edited - https://phabricator.wikimedia.org/T101553#1342287 (10Esanders) [23:55:41] <wikibugs> 10VisualEditor, 6Collaboration-Team-Backlog, 10Flow, 6Language-Engineering, and 3 others: Provide an API flag to suppress auto-generated <references /> - https://phabricator.wikimedia.org/T113331#2013566 (10Esanders) 5declined>3Open I was looking at doing the stripping in VE (T101553) but it turns that...