[00:19:27] ahh about to lose a huge edit [00:19:44] window is still open - any way to access the wikitext? [00:21:09] (03CR) 10Alex Monk: [C: 032] Update VE core submodule to master (6f0c9c2) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/270316 (owner: 10Jforrester) [00:22:57] jdlrobson, umm [00:23:01] what's gone wrong exactly? [00:23:31] Krenair: phew i saved it. It froze with a JS error but luckily it showed me an error message and worked the second time round [00:23:38] unfortunately didnt get the js error [00:24:25] Krenair: in case it's of any use... http://imgur.com/tctlck4 [00:24:32] my wifi is spotty\ [00:24:37] so could have been a dropped connection [00:25:11] that shouldn't cause js errors [00:25:20] I can't do anything with that [00:25:26] need to see the api response itself [00:26:20] jdlrobson, ve.init.target.surface.getHtml() ? [00:26:33] cool i'll rememebr that for next time [00:26:40] you could then run that through Parsoid to get wikitext [00:27:09] it's getting more and more slick but there are a few things that have been bugging me (for instance I get text occasionally shifted around when i backspace. Haven't been able to work out why though :/ [00:27:25] Krenair, James_F|Away wat: https://en.wikipedia.org/wiki/McDonnell_Douglas_F-4_Phantom_II_in_Australian_service?veaction=edit [00:27:59] (03CR) 10jenkins-bot: [V: 04-1] Update VE core submodule to master (6f0c9c2) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/270316 (owner: 10Jforrester) [00:28:02] jdlrobson, yeah we've been letting some more native stuff happen around cursoring/backspacing to help improve language support [00:28:13] Parsoid thinks it's all one transclusion edsanders [00:28:57] ugh - the wikitext has {|{{Infobox ... }}|} [00:29:17] and three sections [00:29:20] I hate wikitext [00:30:25] Krenair: Yeah, the element will be transclusion-affected in their walk of the DOM (correctly). [00:31:11] (03PS2) 10Jforrester: Update VE core submodule to master (6f0c9c2) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/270316 [00:31:16] (03CR) 10Jforrester: [C: 032] "…" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/270316 (owner: 10Jforrester) [00:32:22] (03CR) 10GOIII: [C: 031] Remove deferred loading of the toolbar [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/268968 (https://phabricator.wikimedia.org/T126138) (owner: 10Gerrit Patch Uploader) [00:32:23] huh [00:32:27] something is wrong with my local install [00:37:44] James_F, correctly? [00:37:55] https://phabricator.wikimedia.org/T126834 [00:38:17] edsanders: I agree that the bug there isn't correct. [00:38:28] (03CR) 10jenkins-bot: [V: 04-1] Update VE core submodule to master (6f0c9c2) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/270316 (owner: 10Jforrester) [00:38:37] edsanders: But the
… bit is. [00:38:56] Eh. [00:39:06] Dear CI, you suck. [00:56:53] okay [00:56:57] so I fixed my issue [00:57:09] but how the hell does VE work without my change [00:57:18] seriously, what. [00:57:54] ugh, okay, this is caused by my commit [00:59:40] (03PS1) 10Alex Monk: Unbreak VE [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/270454 [00:59:46] While trying to fix behaviour in cases where it errored, I broke it succeeding at all. [01:00:11] James_F, ^ [01:02:20] hah yeah that'll break things [01:02:24] (03CR) 10Catrope: [C: 032] Unbreak VE [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/270454 (owner: 10Alex Monk) [01:02:53] thanks roan [01:10:50] (03Merged) 10jenkins-bot: Unbreak VE [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/270454 (owner: 10Alex Monk) [01:30:50] 10Cite, 10MediaWiki-API, 10MobileFrontend, 3Reading-Web-Sprint-67-i: Spike: What is impact of storing references - https://phabricator.wikimedia.org/T126802#2024821 (10jcrespo) That is not proper performance testing. Allow me to do it for you, at least [[ https://wikitech.wikimedia.org/wiki/MariaDB/query_p... [02:04:21] (03PS3) 10Jforrester: Update VE core submodule to master (6f0c9c2) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/270316 [02:04:29] (03CR) 10Jforrester: [C: 032] "…" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/270316 (owner: 10Jforrester) [02:15:21] (03Merged) 10jenkins-bot: Update VE core submodule to master (6f0c9c2) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/270316 (owner: 10Jforrester) [02:17:55] (03PS2) 10Jforrester: Revert "DesktopArticleTarget: Don't abort in SET mode if veswitched is set" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/270439 (owner: 10Alex Monk) [02:18:12] (03CR) 10Jforrester: "Needs rebase/squash into parent, I guess?" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/270440 (https://phabricator.wikimedia.org/T125998) (owner: 10Alex Monk) [02:44:06] (03CR) 10Alex Monk: "ugh... I thought I had a (sort of hacky) solution for the issues with CheckboxInputWidget (boolean), but then I remembered - the presence " [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/268854 (https://phabricator.wikimedia.org/T55613) (owner: 10Alex Monk) [02:56:16] (03PS2) 10Alex Monk: Try to switch into the wikitext editor automatically if there is an error loading VE on action=edit [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/270440 (https://phabricator.wikimedia.org/T125998) [02:58:00] (03CR) 10Alex Monk: "ok :)" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/169936 (https://phabricator.wikimedia.org/T124734) (owner: 10Alex Monk) [04:05:11] 10Cite, 10MediaWiki-API, 10MobileFrontend, 3Reading-Web-Sprint-67-i: Spike: What is impact of storing references - https://phabricator.wikimedia.org/T126802#2024894 (10kaldari) @jcrespo: Yay! You rock! [04:39:46] 10VisualEditor, 10VisualEditor-Tables: Moving a row through a rowspan loses content - https://phabricator.wikimedia.org/T126840#2024901 (10gpaumier) 3NEW [08:37:24] 10VisualEditor, 10VisualEditor-MediaWiki-Links, 6Discovery: Search results for internal links in VisualEditor frequently ignore the exact match if it's a redirect - https://phabricator.wikimedia.org/T126852#2025091 (10Whatamidoing-WMF) 3NEW [10:08:26] (03CR) 10Krinkle: [C: 032] TemplateDataBlob: Avoid encoding and compressing json twice [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/266661 (owner: 10Cenarium) [10:17:21] (03Merged) 10jenkins-bot: TemplateDataBlob: Avoid encoding and compressing json twice [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/266661 (owner: 10Cenarium) [15:25:53] 10Cite: Changing text of Mediawiki:Cite error ref no key - https://phabricator.wikimedia.org/T115810#2025532 (10darthbhyrava) Thanks @TheDJ. Glad I could contribute. [15:33:41] (03CR) 10Esanders: "not a massive fan of duplicating logic - I'd rather we just made getHeaders from table sorter a public API, but we can revert this patch w" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/269153 (https://phabricator.wikimedia.org/T95189) (owner: 10Esanders) [23:49:34] 10WikiEditor, 5Patch-For-Review: Every click after the initial selection of a character set in WikiEditor contiguously loads the entire group at the end of the previous group - https://phabricator.wikimedia.org/T126138#2026028 (10GOIII)