[00:10:10] (03CR) 10Jforrester: Replace some $.hasClass with Element.classList.contains (031 comment) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/270790 (owner: 10Esanders) [00:18:21] (03Abandoned) 10Alex Monk: Use widgets for wiki-template-name, boolean and URL template fields [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/268854 (https://phabricator.wikimedia.org/T55613) (owner: 10Alex Monk) [00:21:53] (03PS3) 10Alex Monk: Use NumberInputWidget for number template parameter fields [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/269433 (https://phabricator.wikimedia.org/T124850) [00:21:55] (03PS21) 10Alex Monk: [WIP] Use widgets for wiki-page-name, wiki-user-name, wiki-template-name, boolean, URL and line template fields [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/169936 (https://phabricator.wikimedia.org/T55613) [00:24:07] James_F, ^ I've moved a bunch of things around and probably broken everything [00:24:14] and hopefully fixed some of your feedback comments :) [00:25:10] I wonder if we can rely on Number.parseInt [00:26:52] have to use global parseInt on IE11, maybe it's polyfilled or something though [00:26:58] (03CR) 10jenkins-bot: [V: 04-1] Use NumberInputWidget for number template parameter fields [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/269433 (https://phabricator.wikimedia.org/T124850) (owner: 10Alex Monk) [00:27:57] Only one test broken today jenkins? [00:28:14] 3 missing semicolons, of course [00:29:18] (03PS22) 10Alex Monk: [WIP] Use widgets for wiki-page-name, wiki-user-name, wiki-template-name, boolean, URL and line template fields [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/169936 (https://phabricator.wikimedia.org/T55613) [00:30:46] Krinkle, happen to know about the Number.parseInt thing off the top of your head? [00:30:55] I could reboot a machine into windows, but... :/ [00:31:20] Number.parseInt is ES5-only alias to global parseInt. [00:31:37] (or the other way around depending how you look at it) [00:31:55] link? [00:32:55] Krenair: ES6, not ES5. [00:33:02] yes, it's ES6 [00:33:31] Wait why parse + isNaN [00:33:48] do you want to tolerate a string that contains numbers + non-numerical characters after it? [00:33:50] e.g. '12foo' [00:34:38] (03CR) 10jenkins-bot: [V: 04-1] [WIP] Use widgets for wiki-page-name, wiki-user-name, wiki-template-name, boolean, URL and line template fields [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/169936 (https://phabricator.wikimedia.org/T55613) (owner: 10Alex Monk) [00:36:48] (03PS23) 10Alex Monk: [WIP] Use widgets for wiki-page-name, wiki-user-name, wiki-template-name, boolean, URL and line template fields [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/169936 (https://phabricator.wikimedia.org/T55613) [00:47:17] Krinkle, no, that's me using it incorrectly, thanks [00:47:49] Krenair: If you just want "looks like number" !isNaN might do what you want. or !!Number() [00:47:51] same thing [00:48:03] both cast input to number [00:48:19] yes [00:48:25] I was thinking parseInt( value ).toString() === value [00:50:14] Number() looks like it'll do the trick [00:53:49] (03PS4) 10Alex Monk: Use NumberInputWidget for number template parameter fields [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/269433 (https://phabricator.wikimedia.org/T124850) [02:29:56] 10Cite: LDR not emitting error message when two named references are defined differently - https://phabricator.wikimedia.org/T125074#2030183 (10matmarex) 5Open>3Resolved a:3matmarex I now see an error message being correctly displayed at 10Cite: Note defined outside block disappears if referenced inside the references block - https://phabricator.wikimedia.org/T125077#2030191 (10matmarex) This can apparently be worked around by using the #tag form for : ``` {{#tag:references| ... |group="n"}} ``` ``` Lorem ipsum 10Cite: LDR only linked from another ref in the block supposedly does not exist - https://phabricator.wikimedia.org/T125075#2030192 (10matmarex) This can apparently be //partially// worked around by using the #tag form for : ``` {{#tag:references| ... |group="n"}} ``` (You only get one e... [02:46:17] 10VisualEditor, 10VisualEditor-MediaWiki, 10VisualEditor-MediaWiki-Media, 6Multimedia, and 3 others: Give guidance in the new upload form, to prevent the most common errors - e.g. bad file titles - https://phabricator.wikimedia.org/T116086#2030193 (10Prtksxna) 5Open>3Resolved [08:07:39] 10VisualEditor, 6Community-Liaisons, 7Documentation, 3Liaisons-February-2016: Fix Cite labels at https://www.mediawiki.org/wiki/Help:VisualEditor/User_guide - https://phabricator.wikimedia.org/T127004#2030392 (10Qgil) Could https://www.mediawiki.org/wiki/Language_Screenshots be used here? [08:09:28] 10VisualEditor, 6Community-Liaisons, 7Documentation, 3Liaisons-February-2016: Fix Cite labels at https://www.mediawiki.org/wiki/Help:VisualEditor/User_guide - https://phabricator.wikimedia.org/T127004#2030395 (10Elitre) Generally speaking, we do use the bot for screenshots (note it is currently broken AFAI... [10:31:25] 10VisualEditor, 6Community-Liaisons, 7Documentation, 3Liaisons-February-2016: Fix Cite labels at https://www.mediawiki.org/wiki/Help:VisualEditor/User_guide - https://phabricator.wikimedia.org/T127004#2030670 (10Qgil) Sorry, my multitasking bad. [13:49:13] 10VisualEditor: Not possible to disable or turn off VisualEditor - https://phabricator.wikimedia.org/T127064#2031093 (10Bugreporter) 3NEW [14:06:48] edsanders, awesome patches, but i think you are missing geojson clearing [14:07:03] e.g. setGeoJson(undefined) [14:08:40] yurik, that's an existing bug though [14:10:16] 10VisualEditor: Not possible to disable or turn off VisualEditor on test2 - https://phabricator.wikimedia.org/T127064#2031168 (10Aklapper) [14:10:39] edsanders, i thought this was a new functionality? https://gerrit.wikimedia.org/r/#/c/270942/ [14:11:16] ah [14:11:21] the old patch was removing data [14:11:27] old code [14:11:35] the new one adds data, but does not clear existing data [14:12:44] 10VisualEditor: Not possible to disable or turn off VisualEditor on test2 - https://phabricator.wikimedia.org/T127064#2031182 (10Aklapper) Cannot confirm the problem: When setting "Editing tabs" to "Always give me the wikitext editor" on https://test2.wikipedia.org/wiki/Special:Preferences#mw-prefsection-editin... [14:26:31] edsanders, awesome! http://vem3.wmflabs.org/wiki/Main_Page?veaction=edit [14:26:34] i'm merging [14:26:48] next step is to add the formatting pannel? [14:27:13] so that users can pick/enter color, and change icon mark? [15:00:02] edsanders, i found a few bugs with it - https://gerrit.wikimedia.org/r/#/c/268969/ [15:13:40] probably the circulate update loop from setting the text input JSON (that triggers an update from text value) [15:13:47] *circular [15:13:59] yep [15:17:25] fixed [15:20:31] edsanders, updated and reviewd - http://vem3.wmflabs.org/wiki/Main_Page?veaction=edit [15:20:58] better, but has a weird "pink" bug :) [15:21:25] i have to leave for a bit, will be back later today. Thanks for everything, this is getting to be amazing! [15:26:52] edsanders, what's your user account on wikitech.wikimedia.org ? [15:27:08] i will add you to the mapsteam so you can access vem3 directly if you need [15:27:27] er - not sure - I don't do much server stuff [15:27:46] edsanders, ah, never mind then :) [15:28:38] 10VisualEditor: Not possible to disable or turn off VisualEditor on test2 - https://phabricator.wikimedia.org/T127064#2031517 (10Bugreporter) "Editing tabs"="Always give me the wikitext editor", and "Temporarily disable the visual editor while it is in beta"=true. More strange is the setting change will somehow... [15:30:38] edsanders, btw, i started a discussion on the github's leaflet.editor - it seems noone has been merging any patches to it, even though theer are lots of good pull requests there, like the one that allows to move tho whole object with a drag, etc [15:30:55] ok, i really have to go , will be back in an hour or so [15:31:07] yeah saw [15:45:37] 10Cite, 10MobileFrontend, 3Reading-Web-Sprint-67-i: Create Special:References fallback for non-JavaScript users - https://phabricator.wikimedia.org/T125897#2031563 (10Sumit) Does cite store references in page_props or somewhere else, so that they could be retrieved on a SpecialPage given a page title? [16:16:16] 10VisualEditor, 6Community-Liaisons, 3Liaisons-February-2016: Review list of pages which receive the VE newsletter - https://phabricator.wikimedia.org/T125430#2031709 (10Elitre) Asked wikis about their preference (or I'll target tech VP or main VP). [16:37:56] looking for review on https://gerrit.wikimedia.org/r/#/ edsanders? James_F? [16:38:45] ferdbold: You mean https://gerrit.wikimedia.org/r/#/c/261995/ ? [16:39:33] Krenair: Do you want to squash https://gerrit.wikimedia.org/r/#/c/270440/ and https://gerrit.wikimedia.org/r/#/c/270439/ BTW? [16:39:34] ugh yes [16:39:57] ferdbold: OK. :-) [16:40:21] silly adium didn't replace that with the proper link [16:40:51] James_F, I don't think they need to be squashed really [16:41:17] Krenair: https://gerrit.wikimedia.org/r/#/c/270439/ lacks any justification for why it should be done, though. :-) [16:42:32] Krenair: I trust your thinking and testing, but mostly https://gerrit.wikimedia.org/r/#/c/259078/ was that patches revert anyway and it was done, undone, redone and this one is now re-un-doing it. [16:43:40] right, that was the problem with that patch set [16:44:22] it went back and forth multiple times and the current situation in HEAD is inconsistent and I'm not 100% sure whether the new revert commit breaks things [16:44:40] * James_F nods. [16:44:40] My testing makes it /look/ OK, but… [16:44:41] * James_F sighs. [16:45:22] yeah [16:45:25] so did mine, iirc [16:45:57] (03CR) 10Jforrester: [C: 032] Revert "DesktopArticleTarget: Don't abort in SET mode if veswitched is set" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/270439 (owner: 10Alex Monk) [16:46:07] (03CR) 10Jforrester: [C: 032] Try to switch into the wikitext editor automatically if there is an error loading VE on action=edit [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/270440 (https://phabricator.wikimedia.org/T125998) (owner: 10Alex Monk) [16:46:54] 10VisualEditor, 10VisualEditor-MediaWiki, 7Design, 7Epic: Change VE integration to only use one edit tab, to avoid user choice paralysis - https://phabricator.wikimedia.org/T58337#2031856 (10Jdforrester-WMF) [16:46:58] 10VisualEditor, 10VisualEditor-MediaWiki, 5WMF-deploy-2016-02-23_(1.27.0-wmf.15): In single edit tab mode, when you load VE directly by browsing to action=edit, and it fails to load, bad things happen - https://phabricator.wikimedia.org/T125998#2031853 (10Jdforrester-WMF) 5Open>3Resolved [16:47:15] 10VisualEditor, 10VisualEditor-MediaWiki: Release VisualEditor-MediaWiki as "1.0" - https://phabricator.wikimedia.org/T84936#2031865 (10Jdforrester-WMF) [16:47:17] 10VisualEditor, 10VisualEditor-MediaWiki, 7Design, 7Epic, 7user-notice: Migrate wikis to use a single edit tab which has both visual and wikitext modes and allows on-the-fly switching between them - https://phabricator.wikimedia.org/T102398#2031864 (10Jdforrester-WMF) [16:47:20] 10VisualEditor, 10VisualEditor-MediaWiki, 7Design, 7Epic: VisualEditor: Where VisualEditor is the primary editor, redlinks in read mode should open VE (not wikitext editor) - https://phabricator.wikimedia.org/T55441#2031866 (10Jdforrester-WMF) [16:47:24] 10VisualEditor, 10VisualEditor-MediaWiki: VisualEditor: VE should use the existing "action" URL parameter instead of the new "veaction" - https://phabricator.wikimedia.org/T54281#2031867 (10Jdforrester-WMF) [16:47:26] 10VisualEditor, 10VisualEditor-MediaWiki, 7Design, 7Epic, 5WMF-deploy-2016-02-23_(1.27.0-wmf.15): Change VE integration to only use one edit tab, to avoid user choice paralysis - https://phabricator.wikimedia.org/T58337#2031857 (10Jdforrester-WMF) 5Open>3Resolved [16:47:41] Once the dust settles, we should probably refactor this code. [16:47:54] if it causes issues, we may end up reverting again and using a different parameter (not 'veswitched') [16:48:11] instead of trying to use the same parameter in subtly different ways for different purposes [16:53:50] (03Merged) 10jenkins-bot: Revert "DesktopArticleTarget: Don't abort in SET mode if veswitched is set" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/270439 (owner: 10Alex Monk) [16:54:54] 10VisualEditor, 10VisualEditor-MediaWiki: VE should intercept all calls to action=edit (undo, diffs, etc.) to apply consistently for user expectation - https://phabricator.wikimedia.org/T114531#2031904 (10Jdforrester-WMF) [16:55:02] 10VisualEditor, 10VisualEditor-MediaWiki: Release VisualEditor-MediaWiki as "1.0" - https://phabricator.wikimedia.org/T84936#2031910 (10Jdforrester-WMF) [16:55:04] 10VisualEditor, 10VisualEditor-MediaWiki, 5WMF-deploy-2016-02-23_(1.27.0-wmf.15): VisualEditor: [[MediaWiki:Anoneditwarning]] has an editor-specific link rather than taking you to the appropriate one - https://phabricator.wikimedia.org/T55746#2031905 (10Jdforrester-WMF) 5Open>3Resolved a:3Krenair [16:55:06] 10VisualEditor, 10VisualEditor-MediaWiki, 5WMF-deploy-2016-02-23_(1.27.0-wmf.15): VisualEditor: [[MediaWiki:Anoneditwarning]] has an editor-specific link rather than taking you to the appropriate one - https://phabricator.wikimedia.org/T55746#548557 (10Jdforrester-WMF) [16:55:08] 10VisualEditor, 10VisualEditor-MediaWiki: VisualEditor: Provide a way for interface messages, edit notices, etc to display different content to Visual and Source editors - https://phabricator.wikimedia.org/T54471#2031913 (10Jdforrester-WMF) [16:55:10] 10VisualEditor, 10VisualEditor-MediaWiki, 7Design, 7Epic, 5WMF-deploy-2016-02-23_(1.27.0-wmf.15): Change VE integration to only use one edit tab, to avoid user choice paralysis - https://phabricator.wikimedia.org/T58337#2031912 (10Jdforrester-WMF) [16:55:14] 10VisualEditor, 10VisualEditor-MediaWiki, 5WMF-deploy-2016-02-23_(1.27.0-wmf.15): VisualEditor: [[MediaWiki:Anoneditwarning]] has an editor-specific link rather than taking you to the appropriate one - https://phabricator.wikimedia.org/T55746#548557 (10Jdforrester-WMF) This now works. [16:55:48] 10VisualEditor, 10VisualEditor-MediaWiki: Release VisualEditor-MediaWiki as "1.0" - https://phabricator.wikimedia.org/T84936#934150 (10Jdforrester-WMF) [16:55:50] 10VisualEditor, 10VisualEditor-MediaWiki, 7Design, 7Epic, 5WMF-deploy-2016-02-23_(1.27.0-wmf.15): VisualEditor: Where VisualEditor is the primary editor, redlinks in read mode should open VE (not wikitext editor) - https://phabricator.wikimedia.org/T55441#2031917 (10Jdforrester-WMF) 5Open>3Resolved a... [16:56:18] (03Merged) 10jenkins-bot: Try to switch into the wikitext editor automatically if there is an error loading VE on action=edit [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/270440 (https://phabricator.wikimedia.org/T125998) (owner: 10Alex Monk) [16:58:00] 10VisualEditor, 10VisualEditor-MediaWiki: VE should intercept all calls to action=edit (undo, diffs, etc.) to apply consistently for user expectation - https://phabricator.wikimedia.org/T114531#2031930 (10Jdforrester-WMF) [16:58:02] 10VisualEditor, 10VisualEditor-MediaWiki: VisualEditor is not the editor linked from the diff page - https://phabricator.wikimedia.org/T89060#2031929 (10Jdforrester-WMF) [16:58:04] 10VisualEditor, 10VisualEditor-MediaWiki: The undo link in the page history leads to the source editor and not VisualEditor - https://phabricator.wikimedia.org/T78550#2031931 (10Jdforrester-WMF) [16:58:06] 10VisualEditor, 10VisualEditor-MediaWiki: VE should intercept all calls to action=edit (undo, diffs, etc.) to apply consistently for user expectation - https://phabricator.wikimedia.org/T114531#1698539 (10Jdforrester-WMF) [16:58:19] 10VisualEditor, 10VisualEditor-MediaWiki: The undo link in the page history leads to the source editor and not VisualEditor - https://phabricator.wikimedia.org/T78550#848117 (10Jdforrester-WMF) [16:58:21] 10VisualEditor, 10VisualEditor-MediaWiki: VisualEditor is not the editor linked from the diff page - https://phabricator.wikimedia.org/T89060#1026575 (10Jdforrester-WMF) [16:58:23] 10VisualEditor, 10VisualEditor-MediaWiki: VE should intercept all calls to action=edit (undo, diffs, etc.) to apply consistently for user expectation - https://phabricator.wikimedia.org/T114531#1698539 (10Jdforrester-WMF) [16:58:59] 10VisualEditor, 10VisualEditor-MediaWiki: VE should intercept all calls to action=edit (undo, diffs, etc.) to apply consistently for user expectation - https://phabricator.wikimedia.org/T114531#1698539 (10Jdforrester-WMF) [16:59:47] 10VisualEditor, 10VisualEditor-MediaWiki: The undo link in the page history leads to the source editor and not VisualEditor - https://phabricator.wikimedia.org/T78550#848117 (10Jdforrester-WMF) [16:59:57] 10VisualEditor, 10VisualEditor-MediaWiki: VE should intercept all calls to action=edit (undo, diffs, etc.) to apply consistently for user expectation - https://phabricator.wikimedia.org/T114531#1698539 (10Jdforrester-WMF) [17:05:07] 10Cite, 5Patch-For-Review, 3Reading-Web-Sprint-65-Game of Phones: Save references in page_props and cache - https://phabricator.wikimedia.org/T125329#2031971 (10Cenarium) I'd consider this closed only if this goes into production (with this table or another one). [17:19:51] Yeah. [17:43:00] 10Cite, 10MediaWiki-API, 10MobileFrontend, 5Patch-For-Review, 3Reading-Web-Sprint-66-h: Should be possible to access references and notes for a given page via API - https://phabricator.wikimedia.org/T123290#2032178 (10Jdlrobson) 5stalled>3Open [17:47:22] 10Cite, 10MediaWiki-API, 10MobileFrontend, 5Patch-For-Review, 3Reading-Web-Sprint-66-h: Should be possible to access references and notes for a given page via API - https://phabricator.wikimedia.org/T123290#2032187 (10Jdlrobson) [18:40:31] edsanders: Hmm. [18:40:36] edsanders: Where in SA init should I write some code to abort instead? [18:40:52] ve.init.sa.Target doesn't have a "stop" concept. :-) [18:42:34] 10VisualEditor, 10VisualEditor-MediaWiki, 6Editing-Analysis: Revise the Edit schema and its use - https://phabricator.wikimedia.org/T118063#2032459 (10Neil_P._Quinn_WMF) [18:42:56] 10VisualEditor, 10VisualEditor-MediaWiki, 7Design, 7Epic, and 2 others: VisualEditor: Where VisualEditor is the primary editor, redlinks in read mode should open VE (not wikitext editor) - https://phabricator.wikimedia.org/T55441#2032462 (10Trizek-WMF) [18:45:54] hm [18:46:49] so looking at the boilerplate we have for SA [18:47:03] ve.init.platform.initialize().done( function () { [18:47:03] var target = new ve.init.sa.DesktopTarget(); [18:47:03] target.addSurface( [18:47:03] ve.dm.converter.getModelFromDom( [18:47:04] ve.createDocumentFromHtml( '

Hello, World!

' ) [18:47:05] ) [18:47:06] ); [18:47:09] $( 'body' ).append( target.$element ); [18:47:22] } ); [18:47:24] we have a few options [18:47:34] we can reject the platform promise [18:48:14] that's probably the most sensible approach, because then you don't have to short circuit the target constructor [18:48:45] edsanders: Yeah, I'll do that. [18:49:56] we could standardize on Platform.initialize [18:50:03] in MW as well [18:50:46] so that MW can rely on core's feature tests [18:52:00] Yeah. [18:52:16] Well. [18:52:32] Except modules/ve-mw/init/targets/ve.init.mw.DesktopArticleTarget.init.js is loaded on every page. [18:52:58] ve.init.mw.Platform.js isn't. [18:53:09] FIXME. [18:54:23] (Both would be fine, I guess.) [19:03:23] 10VisualEditor, 6Editing-Department, 10MobileFrontend, 7Mobile, and 4 others: Enable editing for mobile users without JavaScript and kill Special:MobileEditor code in MobileFrontend - https://phabricator.wikimedia.org/T125174#2032535 (10Jdlrobson) Thanks @matmarex I think this makes sense. With regards to... [19:07:14] 10VisualEditor: Broken link in empty citation - https://phabricator.wikimedia.org/T127102#2032544 (10eranroz) 3NEW [19:14:55] (03PS1) 10Jforrester: Move initialisation browser support checking from downstream [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/271030 [19:15:21] (03PS2) 10Jforrester: Move initialisation browser support checking from downstream [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/271030 [19:19:06] (03PS1) 10Jforrester: Use initialisation browser support checking from upstream [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/271031 [19:20:32] (03PS2) 10Jforrester: ce.TableNode#onSurfaceModelSelect: Table overlay optimisation [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/270347 (owner: 10Esanders) [19:20:39] (03CR) 10Jforrester: [C: 032] ce.TableNode#onSurfaceModelSelect: Table overlay optimisation [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/270347 (owner: 10Esanders) [19:20:49] (03CR) 10jenkins-bot: [V: 04-1] Move initialisation browser support checking from downstream [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/271030 (owner: 10Jforrester) [19:21:08] (03CR) 10jenkins-bot: [V: 04-1] Use initialisation browser support checking from upstream [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/271031 (owner: 10Jforrester) [19:21:12] (03CR) 10Jforrester: [C: 032] Fix cache invalidation of SurfaceFragment.leafNodes [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/270760 (https://phabricator.wikimedia.org/T126348) (owner: 10Esanders) [19:22:08] (03CR) 10Jforrester: [C: 032] Share getSelectedNode logic between Surface and SurfaceFragment [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/270762 (https://phabricator.wikimedia.org/T126348) (owner: 10Esanders) [19:24:30] (03CR) 10Jforrester: Replace some $.hasClass with Element.classList.contains (031 comment) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/270790 (owner: 10Esanders) [19:24:33] (03Merged) 10jenkins-bot: ce.TableNode#onSurfaceModelSelect: Table overlay optimisation [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/270347 (owner: 10Esanders) [19:27:50] (03Merged) 10jenkins-bot: Fix cache invalidation of SurfaceFragment.leafNodes [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/270760 (https://phabricator.wikimedia.org/T126348) (owner: 10Esanders) [19:27:59] (03Merged) 10jenkins-bot: Share getSelectedNode logic between Surface and SurfaceFragment [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/270762 (https://phabricator.wikimedia.org/T126348) (owner: 10Esanders) [19:44:18] 10VisualEditor, 10VisualEditor-MediaWiki, 7Design, 7Epic, and 2 others: VisualEditor: Where VisualEditor is the primary editor, redlinks in read mode should open VE (not wikitext editor) - https://phabricator.wikimedia.org/T55441#2032681 (10Jdforrester-WMF) (Only fixed for Single Edit Tab wikis.) [19:48:39] 10Cite, 5Patch-For-Review, 3Reading-Web-Sprint-65-Game of Phones, 5WMF-deploy-2016-02-23_(1.27.0-wmf.15): Save references in page_props and cache - https://phabricator.wikimedia.org/T125329#2032694 (10Jdlrobson) I was thinking about this over the weekend, and I'm now re-thinking the whole page props approa... [19:51:45] (03CR) 10Jforrester: [C: 032] ve.ce.Surface: Cache current selection [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/270784 (owner: 10Esanders) [19:52:00] (03CR) 10Jforrester: [C: 032] Move model fallback for getDirectionFromSelection into method [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/270767 (owner: 10Esanders) [19:52:38] (03CR) 10Jforrester: [C: 032] Move selection directionality to ve.ce.Selection [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/270776 (https://phabricator.wikimedia.org/T121347) (owner: 10Esanders) [19:55:55] (03CR) 10Jforrester: [C: 032] FocusableNode: Bind position events later [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/270750 (https://phabricator.wikimedia.org/T126348) (owner: 10Esanders) [19:56:03] (03CR) 10Jforrester: [C: 032] FocusableNode: Change mouseout events to mouseleave [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/270751 (owner: 10Esanders) [19:56:48] (03Merged) 10jenkins-bot: ve.ce.Surface: Cache current selection [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/270784 (owner: 10Esanders) [19:56:50] (03Merged) 10jenkins-bot: Move model fallback for getDirectionFromSelection into method [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/270767 (owner: 10Esanders) [19:57:41] (03Merged) 10jenkins-bot: Move selection directionality to ve.ce.Selection [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/270776 (https://phabricator.wikimedia.org/T121347) (owner: 10Esanders) [19:59:59] (03Merged) 10jenkins-bot: FocusableNode: Bind position events later [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/270750 (https://phabricator.wikimedia.org/T126348) (owner: 10Esanders) [20:01:17] (03Merged) 10jenkins-bot: FocusableNode: Change mouseout events to mouseleave [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/270751 (owner: 10Esanders) [20:04:29] 10VisualEditor: Broken link in empty citation - https://phabricator.wikimedia.org/T127102#2032755 (10Jdforrester-WMF) What link to what help page? Is this a message that's not being evaluated in the right context? [20:04:59] 10Cite, 10VisualEditor, 10VisualEditor-MediaWiki-References: Warning about an empty citation has a broken link - https://phabricator.wikimedia.org/T127102#2032758 (10Jdforrester-WMF) p:5Triage>3High [20:05:41] 10VisualEditor: Not possible to disable or turn off VisualEditor on test2 - https://phabricator.wikimedia.org/T127064#2032767 (10Jdforrester-WMF) 5Open>3stalled [20:05:52] 10VisualEditor, 10VisualEditor-MediaWiki: Not possible to disable or turn off VisualEditor on test2 - https://phabricator.wikimedia.org/T127064#2031093 (10Jdforrester-WMF) p:5Triage>3High [20:06:51] 10VisualEditor, 6Community-Liaisons, 7Documentation, 3Liaisons-February-2016: Fix Cite labels at https://www.mediawiki.org/wiki/Help:VisualEditor/User_guide - https://phabricator.wikimedia.org/T127004#2032777 (10Jdforrester-WMF) 5Open>3Resolved p:5Triage>3Normal a:3Elitre [20:07:46] 10VisualEditor, 10VisualEditor-MediaWiki-Links: Can't paste #mw-prefsection-editing onto the end of a link, or in the middle - https://phabricator.wikimedia.org/T127005#2032786 (10Jdforrester-WMF) [20:07:48] 10VisualEditor, 10VisualEditor-MediaWiki-Links, 6Collaboration-Team-Backlog, 10Flow: [Regression wmf23] On creating an inter-wiki link, the nice regex strips section parts of the link - https://phabricator.wikimedia.org/T112898#2032787 (10Jdforrester-WMF) [20:08:25] 10Cite, 5Patch-For-Review, 3Reading-Web-Sprint-65-Game of Phones, 5WMF-deploy-2016-02-23_(1.27.0-wmf.15): Save references in page_props and cache - https://phabricator.wikimedia.org/T125329#2032789 (10Cenarium) Page_props allows to store the data //somewhere//. But this still needs a proper API (T123290),... [20:09:59] 10Cite, 10Citoid, 10VisualEditor, 10VisualEditor-MediaWiki-References: Citoid should down-convert odd whitespace (e.g. line feed characters) on inserting - https://phabricator.wikimedia.org/T126968#2032796 (10Jdforrester-WMF) [20:10:19] 10Cite, 10Citoid, 10VisualEditor, 10VisualEditor-MediaWiki-References: Citoid should down-convert odd whitespace (e.g. line feed characters) on inserting - https://phabricator.wikimedia.org/T126968#2028393 (10Jdforrester-WMF) p:5Triage>3Normal [20:11:52] 10VisualEditor, 10VisualEditor-ContentEditable, 10VisualEditor-MediaWiki-References: Snowman added and references deleted - https://phabricator.wikimedia.org/T126910#2032814 (10Jdforrester-WMF) 5Open>3stalled Any information from the user on what browser they were using, if they have any odd gadgets or b... [20:12:03] 10VisualEditor, 10VisualEditor-ContentEditable, 10VisualEditor-MediaWiki-References: Snowman added and references deleted by edits of one user (broken browser?) - https://phabricator.wikimedia.org/T126910#2032816 (10Jdforrester-WMF) p:5Triage>3Unbreak! [20:12:23] 10Cite, 10VisualEditor, 10VisualEditor-MediaWiki-References, 5WMF-deploy-2016-02-09_(1.27.0-wmf.13), 5WMF-deploy-2016-02-16_(1.27.0-wmf.14): [Regression wmf.13] Button labels are not appearing for Reference list dialog - https://phabricator.wikimedia.org/T126373#2032821 (10Jdforrester-WMF) 5Open>3Reso... [20:14:44] 10VisualEditor, 10VisualEditor-MediaWiki-Links, 6Discovery: Search results for internal links in VisualEditor frequently ignore the exact match if it's a redirect - https://phabricator.wikimedia.org/T126852#2032829 (10Jdforrester-WMF) 5Open>3stalled I can't reproduce. Can you supply a screenshot? [20:15:30] 10Cite, 5Patch-For-Review, 3Reading-Web-Sprint-65-Game of Phones, 5WMF-deploy-2016-02-23_(1.27.0-wmf.15): Save references in page_props and cache - https://phabricator.wikimedia.org/T125329#2032834 (10Cenarium) [[https://git.wikimedia.org/blob/mediawiki%2Fextensions%2FGraph/master/includes%2FApiGraph.php|G... [20:15:33] 10VisualEditor, 10VisualEditor-Tables: Moving a row through a rowspan loses content - https://phabricator.wikimedia.org/T126840#2032836 (10Jdforrester-WMF) 5Open>3declined a:3Jdforrester-WMF I think this is the (least un-)expected behaviour. The alternative is wimping out like Excel does and not letting... [20:18:36] 10VisualEditor, 10VisualEditor-MediaWiki: Visualeditor should follow my wpforceeditsummary settings in the "Review your changes" window for section edits which have no content beyond the auto-placed section name - https://phabricator.wikimedia.org/T126562#2032847 (10Jdforrester-WMF) p:5Triage>3Low [20:18:55] 10VisualEditor, 10VisualEditor-MediaWiki, 7Performance: Typing into text field in media search dialog hangs and then crashes browser tab when using Opera (Chromium-like) on Windows 7 - https://phabricator.wikimedia.org/T126546#2032859 (10Jdforrester-WMF) p:5Triage>3High [20:19:59] 10Citoid, 10VisualEditor, 10VisualEditor-MediaWiki-References: Citoid should magically see that a source has already been used in a reference on this page and re-use it (or warn me to do so) rather than creating a new reference to the same source - https://phabricator.wikimedia.org/T126488#2032867 (10Jdforres... [20:20:37] 10TemplateData, 10VisualEditor, 10VisualEditor-MediaWiki: Add a mecanism to mark templates without TemplateData - https://phabricator.wikimedia.org/T126382#2032871 (10Jdforrester-WMF) [20:20:39] 10TemplateData, 10VisualEditor, 10VisualEditor-MediaWiki: TempateData: Provide a way to list all documented (and undocumented) templates on a wiki (beyond Special:PagesWithProp/templatedata) - https://phabricator.wikimedia.org/T52368#2032872 (10Jdforrester-WMF) [20:20:51] still waiting on review for https://gerrit.wikimedia.org/r/#/c/261995/ James_F edsanders :P [20:22:01] 10VisualEditor, 10VisualEditor-ContentEditable, 10VisualEditor-Links: Cursor gets "stuck" when down-arrowing from the start of a link which spans a page beginning/end - https://phabricator.wikimedia.org/T126487#2032878 (10Jdforrester-WMF) p:5Triage>3High [20:23:33] 10VisualEditor, 10VisualEditor-ContentEditable: Cursoring jumps over references - https://phabricator.wikimedia.org/T126401#2032884 (10Jdforrester-WMF) [20:23:36] 10VisualEditor, 10VisualEditor-ContentEditable: pressing left-arrow key, cursor skips period past footnote reference. - https://phabricator.wikimedia.org/T123608#2032885 (10Jdforrester-WMF) [20:24:01] 10VisualEditor, 10VisualEditor-ContentEditable: Cursoring jumps over references; pressing left-arrow key, cursor skips period past footnote reference - https://phabricator.wikimedia.org/T123608#2032888 (10Jdforrester-WMF) p:5Normal>3High [20:24:56] 10VisualEditor, 10VisualEditor-Links, 7Browser-Support-Firefox: With Firefox, punctuation isolated in a new line after a link blocks left arrow key - https://phabricator.wikimedia.org/T126374#2032892 (10Jdforrester-WMF) p:5Triage>3Low [20:28:35] 10Citoid, 10VisualEditor: Adding a citation manually causes it to be displayed at the top of the page - https://phabricator.wikimedia.org/T126437#2032902 (10Jdforrester-WMF) This is a very serious issue, but I cannot reliably replicate in Chrome 48 or Safari 9. It seems to happen some of the time (maybe just t... [20:29:07] 10Cite, 10Citoid, 10VisualEditor, 10VisualEditor-MediaWiki-References: Adding a citation manually causes it to be inserted at the top of the page, not where the cursor is, sometimes(?) - https://phabricator.wikimedia.org/T126437#2032903 (10Jdforrester-WMF) p:5Triage>3High [20:30:05] 10VisualEditor, 10VisualEditor-ContentEditable, 10VisualEditor-ContentLanguage: Mac OSX Korean: Implicit completion of CV syllables causes text removal - https://phabricator.wikimedia.org/T127108#2032909 (10dchan) 3NEW a:3dchan [20:33:18] 10VisualEditor, 10VisualEditor-ContentEditable, 7Browser-Support-Firefox, 5Patch-For-Review: Uncommitted Korean IME candidate text ignored when user presses enter, causing CE/DM desync in Firefox - https://phabricator.wikimedia.org/T120156#2032923 (10dchan) From testing with @Tchanders and @Esanders , it l... [20:34:30] 10Cite, 10VisualEditor, 10VisualEditor-MediaWiki-References: Warning about an empty citation has a broken link - https://phabricator.wikimedia.org/T127102#2032942 (10eranroz) The message that appears in the citation box after adding such citation. For example when adding citation for: http://www.ynet.co.il/a... [20:51:31] (03PS1) 10Divec: Clarify documentation of directionality methods [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/271064 [21:06:45] 10VisualEditor, 10VisualEditor-ContentEditable, 10VisualEditor-ContentLanguage: Mac OSX Korean: Implicit completion of CV syllables causes text removal - https://phabricator.wikimedia.org/T127108#2033050 (10dchan) @Jdforrester-WMF initially reported similar behaviour in T120156 , including video F3328523 whi... [22:18:37] 10VisualEditor, 6Community-Liaisons, 7Documentation, 3Liaisons-February-2016: Fix Cite labels at https://www.mediawiki.org/wiki/Help:VisualEditor/User_guide - https://phabricator.wikimedia.org/T127004#2033298 (10Elitre) @Jdforrester-WMF, how is this fixed? [22:20:43] 10Cite, 10Citoid, 10VisualEditor, 10VisualEditor-MediaWiki-References: Adding a citation manually causes it to be inserted at the top of the page, not where the cursor is, sometimes(?) - https://phabricator.wikimedia.org/T126437#2033314 (10Elitre) I also can't reproduce [[ https://it.wikipedia.org/w/index.... [23:13:26] 10VisualEditor, 10VisualEditor-MediaWiki: VisualEditor: VE should use the existing "action" URL parameter instead of the new "veaction" - https://phabricator.wikimedia.org/T54281#2033496 (10Jdforrester-WMF) 5Open>3Resolved a:3Jdforrester-WMF This is now mostly done, for single edit tab wikis. [23:13:32] 10VisualEditor, 10VisualEditor-MediaWiki: VisualEditor: VE should use the existing "action" URL parameter instead of the new "veaction" - https://phabricator.wikimedia.org/T54281#2033501 (10Jdforrester-WMF) [23:13:43] 10VisualEditor, 10VisualEditor-MediaWiki, 5WMF-deploy-2016-02-23_(1.27.0-wmf.15): VisualEditor: VE should use the existing "action" URL parameter instead of the new "veaction" - https://phabricator.wikimedia.org/T54281#2033503 (10Jdforrester-WMF) a:5Jdforrester-WMF>3Krenair