[00:09:45] edsanders, do you know what HTML we should use for "inline" and "frame right/left" for maps? [00:13:59] 10VisualEditor, 6Editing-Department, 10MobileFrontend, 7Mobile, and 4 others: Enable editing for mobile users without JavaScript and kill Special:MobileEditor code in MobileFrontend - https://phabricator.wikimedia.org/T125174#2033758 (10Jdlrobson) @matmarex while speaking to @Volker_E we realised given the... [00:14:54] 10VisualEditor, 6Editing-Department, 10MobileFrontend, 7Mobile, and 4 others: Enable editing for mobile users without JavaScript and kill Special:MobileEditor code in MobileFrontend - https://phabricator.wikimedia.org/T125174#2033764 (10Jdlrobson) [00:15:14] 10VisualEditor, 6Editing-Department, 10MobileFrontend, 7Mobile, and 4 others: Enable editing for mobile users without JavaScript and kill Special:MobileEditor code in MobileFrontend - https://phabricator.wikimedia.org/T125174#1980463 (10Jdlrobson) [00:40:35] 10VisualEditor, 6Editing-Department, 10MobileFrontend, 7Mobile, and 4 others: Enable editing for mobile users without JavaScript and kill Special:MobileEditor code in MobileFrontend - https://phabricator.wikimedia.org/T125174#2033826 (10Jdlrobson) @Florian we've done similar things where we change the lice... [00:42:41] (03CR) 10Jforrester: [C: 032] Revert "Re-add null appendix tab messages to extension.json" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/269457 (https://phabricator.wikimedia.org/T125249) (owner: 10Alex Monk) [00:50:37] (03Merged) 10jenkins-bot: Revert "Re-add null appendix tab messages to extension.json" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/269457 (https://phabricator.wikimedia.org/T125249) (owner: 10Alex Monk) [00:59:57] 10VisualEditor: Race condition in Chrome when clicking on links near bottom of screen - https://phabricator.wikimedia.org/T127141#2033874 (10AxelBoldt) 3NEW [01:06:18] (03PS1) 10Alex Monk: Revert "Re-add null appendix tab messages to extension.json" [extensions/VisualEditor] (wmf/1.27.0-wmf.14) - 10https://gerrit.wikimedia.org/r/271172 (https://phabricator.wikimedia.org/T125249) [01:06:29] (03PS1) 10Alex Monk: Revert "Re-add null appendix tab messages to extension.json" [extensions/VisualEditor] (wmf/1.27.0-wmf.13) - 10https://gerrit.wikimedia.org/r/271173 (https://phabricator.wikimedia.org/T125249) [01:07:06] (03CR) 10Jforrester: [C: 032] Revert "Re-add null appendix tab messages to extension.json" [extensions/VisualEditor] (wmf/1.27.0-wmf.14) - 10https://gerrit.wikimedia.org/r/271172 (https://phabricator.wikimedia.org/T125249) (owner: 10Alex Monk) [01:07:11] (03CR) 10Jforrester: [C: 032] Revert "Re-add null appendix tab messages to extension.json" [extensions/VisualEditor] (wmf/1.27.0-wmf.13) - 10https://gerrit.wikimedia.org/r/271173 (https://phabricator.wikimedia.org/T125249) (owner: 10Alex Monk) [01:14:06] (03Merged) 10jenkins-bot: Revert "Re-add null appendix tab messages to extension.json" [extensions/VisualEditor] (wmf/1.27.0-wmf.14) - 10https://gerrit.wikimedia.org/r/271172 (https://phabricator.wikimedia.org/T125249) (owner: 10Alex Monk) [01:16:00] (03Merged) 10jenkins-bot: Revert "Re-add null appendix tab messages to extension.json" [extensions/VisualEditor] (wmf/1.27.0-wmf.13) - 10https://gerrit.wikimedia.org/r/271173 (https://phabricator.wikimedia.org/T125249) (owner: 10Alex Monk) [01:36:15] 10VisualEditor, 10VisualEditor-MediaWiki, 5Patch-For-Review: [Regression wmf.11] Source and VE edit tabs have the word appearing next to them for some users on enwiki (very old cached HTML/JS?) - https://phabricator.wikimedia.org/T125249#2033941 (10Stashbot) {nav icon=file, name=Mentioned in SAL,... [01:56:49] 10VisualEditor, 10VisualEditor-MediaWiki, 5Patch-For-Review: [Regression wmf.11] Source and VE edit tabs have the word appearing next to them for some users on enwiki (very old cached HTML/JS?) - https://phabricator.wikimedia.org/T125249#2034012 (10Krenair) 5stalled>3Resolved I believe everyt... [02:01:00] 10VisualEditor, 6Community-Liaisons, 7Documentation, 3Liaisons-February-2016: Write a page on mediawiki.org to explain Single Edit Tab (with screenshots) - https://phabricator.wikimedia.org/T124710#2034015 (10Whatamidoing-WMF) 5Open>3Resolved This is marked for translation, which means that it's done. [02:12:24] 10VisualEditor, 10VisualEditor-MediaWiki: Not possible to disable or turn off VisualEditor on test2 - https://phabricator.wikimedia.org/T127064#2034027 (10Krenair) Are you saying that the preference to disable VE does not save properly? Do the other preferences save properly? It worked properly for me when I... [02:12:40] James_F, ^ did you manage to reproduce that? [02:13:10] Krenair: No, hence stalled. [02:13:19] (03PS1) 10Jforrester: Update OOjs UI to v0.15.4 [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/271177 [02:13:22] ok, wasn't clear. thanks [02:13:47] Yeah, was rushing through. [02:14:04] (03CR) 10Catrope: [C: 032] Update OOjs UI to v0.15.4 [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/271177 (owner: 10Jforrester) [02:18:46] (03CR) 10jenkins-bot: [V: 04-1] Update OOjs UI to v0.15.4 [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/271177 (owner: 10Jforrester) [02:21:38] (03CR) 10Jforrester: [C: 032] "…" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/271177 (owner: 10Jforrester) [02:26:28] (03Merged) 10jenkins-bot: Update OOjs UI to v0.15.4 [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/271177 (owner: 10Jforrester) [02:29:03] (03PS1) 10Jforrester: Update VE core submodule to master (33d090b) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/271180 [02:43:33] (03CR) 10Alex Monk: [C: 032] Update VE core submodule to master (33d090b) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/271180 (owner: 10Jforrester) [02:45:42] 10WikiEditor, 5Patch-For-Review: Every click after the initial selection of a character set in WikiEditor contiguously loads the entire group at the end of the previous group - https://phabricator.wikimedia.org/T126138#2034057 (10Krenair) a:5Krenair>3Fomafix [02:50:27] (03Merged) 10jenkins-bot: Update VE core submodule to master (33d090b) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/271180 (owner: 10Jforrester) [05:54:03] 10VisualEditor, 10VisualEditor-MediaWiki: Not possible to disable or turn off VisualEditor on test2 - https://phabricator.wikimedia.org/T127064#2034140 (10Bugreporter) 5stalled>3declined a:3Bugreporter [08:26:11] 10VisualEditor, 10VisualEditor-ContentEditable, 10VisualEditor-MediaWiki-References: Snowman added and references deleted by edits of one user (broken browser?) - https://phabricator.wikimedia.org/T126910#2034540 (10Elitre) ATM the details we have are "Mozilla Firefox, Vector, WinXP", I asked for more. [08:33:41] 10VisualEditor, 10VisualEditor-MediaWiki: Not possible to disable or turn off VisualEditor on test2 - https://phabricator.wikimedia.org/T127064#2034562 (10Aklapper) @Bugreporter: Why was this task closed as "declined"? Could you explain and/or answer the last question? [12:00:21] 10Cite, 10Citoid, 10VisualEditor, 10VisualEditor-MediaWiki-References: Adding a citation manually causes it to be inserted at the top of the page, not where the cursor is, sometimes(?) - https://phabricator.wikimedia.org/T126437#2034881 (10Elitre) @Jdforrester-WMF, yesterday's test was in Chrome/Win, but t... [12:02:38] (03PS2) 10Divec: WIP: Refactor getNodeAndOffset [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/270315 [12:02:57] (03CR) 10jenkins-bot: [V: 04-1] WIP: Refactor getNodeAndOffset [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/270315 (owner: 10Divec) [12:35:47] 10VisualEditor, 10VisualEditor-MediaWiki: Not possible to disable or turn off VisualEditor on test2 - https://phabricator.wikimedia.org/T127064#2034901 (10Bugreporter) Can not reproduce. When it happens again, I will reopen it. [13:03:24] 10VisualEditor, 10VisualEditor-MediaWiki, 10MediaWiki-extensions-UniversalLanguageSelector: Integrate jQuery IME control with the VE toolbar - https://phabricator.wikimedia.org/T126125#2034952 (10Pginer-WMF) We need to figure out to which level should we indicate the input method in use when the menu is clos... [13:36:04] (03CR) 10Paladox: Allow the signature wikitext to be overridden locally (031 comment) [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/258783 (https://phabricator.wikimedia.org/T26191) (owner: 10Paladox) [13:36:18] (03PS15) 10Paladox: Allow the signature wikitext to be overridden locally [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/258783 (https://phabricator.wikimedia.org/T26191) [13:39:07] (03CR) 10jenkins-bot: [V: 04-1] Allow the signature wikitext to be overridden locally [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/258783 (https://phabricator.wikimedia.org/T26191) (owner: 10Paladox) [13:45:18] (03CR) 10Paladox: "recheck" [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/258783 (https://phabricator.wikimedia.org/T26191) (owner: 10Paladox) [13:47:43] (03PS16) 10Paladox: Allow the signature wikitext to be overridden locally [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/258783 (https://phabricator.wikimedia.org/T26191) [14:25:12] (03CR) 10Esanders: [C: 032] Clarify documentation of directionality methods [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/271064 (owner: 10Divec) [14:34:43] (03Merged) 10jenkins-bot: Clarify documentation of directionality methods [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/271064 (owner: 10Divec) [14:40:23] (03PS2) 10Bartosz Dziewoński: Use MenuOptionWidget rather than OptionWidget for MenuSelectWidget items [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/269176 [14:42:47] Krenair, ve-activated is being removed from the target which is incorrect, and resulting in styling issues [14:43:11] (03CR) 10jenkins-bot: [V: 04-1] Use MenuOptionWidget rather than OptionWidget for MenuSelectWidget items [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/269176 (owner: 10Bartosz Dziewoński) [14:44:52] 10VisualEditor: [regression] ve-activated class removed from target, resulting in styling issues - https://phabricator.wikimedia.org/T127184#2035190 (10Esanders) 3NEW a:3Krenair [14:59:25] 10WikiEditor, 5Patch-For-Review: Every click after the initial selection of a character set in WikiEditor contiguously loads the entire group at the end of the previous group - https://phabricator.wikimedia.org/T126138#2035208 (10TheDJ) I hope to review this before the end of the week. [15:10:58] 10VisualEditor, 10VisualEditor-ContentEditable: Cursoring jumps over references and some extra characters - https://phabricator.wikimedia.org/T123608#2035230 (10Esanders) [15:18:47] edsanders, was that something we changed in one of the failure cases? [15:22:00] 10VisualEditor, 6Editing-Department, 10MobileFrontend, 7Mobile, and 4 others: Enable editing for mobile users without JavaScript and kill Special:MobileEditor code in MobileFrontend - https://phabricator.wikimedia.org/T125174#2035251 (10Florian) @Jdlrobson I understand the problem, but especially for that... [15:36:30] (03PS1) 10Alex Monk: Don't remove .ve-activated after successfully activating [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/271278 (https://phabricator.wikimedia.org/T127184) [15:36:38] 10Cite: Request for mediawiki:Cite section preview references format change - https://phabricator.wikimedia.org/T127188#2035293 (10IKhitron) 3NEW [15:42:32] (03CR) 10Divec: "@Esanders and I decided this does fix the Enter bug (see T120156 - the text removal can still happen but it is a separate issue now filed " [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/269362 (owner: 10Divec) [15:43:34] 10Cite: Request for mediawiki:Cite section preview references format change - https://phabricator.wikimedia.org/T127188#2035328 (10TheDJ) 5Open>3Invalid a:3TheDJ Already possible, you can use MediaWiki:Common.css to apply styling to the class of this particular header. [15:51:21] 10Cite: Request for mediawiki:Cite section preview references format change - https://phabricator.wikimedia.org/T127188#2035339 (10IKhitron) Thank's for the tip, @TheDJ, but .mw-ext-cite-cite_section_preview_references css style is not exclusive for this mediawiki message. For example, it's inherited to the firs... [15:51:36] 10Cite: Request for mediawiki:Cite section preview references format change - https://phabricator.wikimedia.org/T127188#2035340 (10IKhitron) 5Invalid>3Open [16:18:14] (03PS1) 10Jforrester: build: Update mediawiki-codesniffer to 0.6.0, add "composer fix" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/271281 [16:24:50] (03CR) 10Jforrester: [C: 032] "Oh, yeah, that's not good." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/271278 (https://phabricator.wikimedia.org/T127184) (owner: 10Alex Monk) [16:25:20] 10VisualEditor, 10VisualEditor-MediaWiki, 5Patch-For-Review, 5WMF-deploy-2016-02-16_(1.27.0-wmf.14), 5WMF-deploy-2016-02-23_(1.27.0-wmf.15): [Regression wmf.14] ve-activated class removed from target, resulting in styling issues - https://phabricator.wikimedia.org/T127184#2035486 (10Jdforrester-WMF) [16:32:50] (03Merged) 10jenkins-bot: Don't remove .ve-activated after successfully activating [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/271278 (https://phabricator.wikimedia.org/T127184) (owner: 10Alex Monk) [16:35:53] (03CR) 10Jforrester: "Needs manual cherry-pick to wmf.14." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/271278 (https://phabricator.wikimedia.org/T127184) (owner: 10Alex Monk) [16:38:24] (03PS1) 10Alex Monk: Don't remove .ve-activated after successfully activating [extensions/VisualEditor] (wmf/1.27.0-wmf.14) - 10https://gerrit.wikimedia.org/r/271286 (https://phabricator.wikimedia.org/T127184) [16:38:35] James_F, ^ slightly different commit for wmf.14 [16:39:54] Oh, hmm. [16:40:21] (03CR) 10Jforrester: [C: 032] Don't remove .ve-activated after successfully activating [extensions/VisualEditor] (wmf/1.27.0-wmf.14) - 10https://gerrit.wikimedia.org/r/271286 (https://phabricator.wikimedia.org/T127184) (owner: 10Alex Monk) [16:42:22] (03CR) 10jenkins-bot: [V: 04-1] Don't remove .ve-activated after successfully activating [extensions/VisualEditor] (wmf/1.27.0-wmf.14) - 10https://gerrit.wikimedia.org/r/271286 (https://phabricator.wikimedia.org/T127184) (owner: 10Alex Monk) [16:42:50] Meh. [16:43:40] 16:41:16 npm ERR! enoent ENOENT, lstat '/mnt/jenkins-workspace/workspace/mediawiki-extensions-qunit/src/node_modules/karma/node_modules/core-js/modules/_typed-array.js' [16:48:23] (03Merged) 10jenkins-bot: Don't remove .ve-activated after successfully activating [extensions/VisualEditor] (wmf/1.27.0-wmf.14) - 10https://gerrit.wikimedia.org/r/271286 (https://phabricator.wikimedia.org/T127184) (owner: 10Alex Monk) [16:48:50] Yeah, hence 'meh' not 'oh no it's broken'. :-) [16:52:42] (03CR) 10Esanders: [C: 031] build: Update mediawiki-codesniffer to 0.6.0, add "composer fix" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/271281 (owner: 10Jforrester) [16:57:34] 10TemplateData, 10OOjs-UI: Draggable list not working as expected in TemplateData - https://phabricator.wikimedia.org/T127203#2035617 (10Esanders) 3NEW [17:17:43] (03CR) 10Fomafix: Remove deferred loading of the toolbar (031 comment) [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/268968 (https://phabricator.wikimedia.org/T126138) (owner: 10Gerrit Patch Uploader) [17:23:27] 10VisualEditor, 10VisualEditor-ContentEditable, 10VisualEditor-MediaWiki-References: Snowman added and references deleted by edits of one user (broken browser?) - https://phabricator.wikimedia.org/T126910#2035719 (10Elitre) Windows XP Ver. 5.1 (Build 2600.xpsp_sp3_qfe.130704-0421:SP 3), Mozilla Firefox (43.0... [17:38:57] 10VisualEditor, 10VisualEditor-ContentEditable: Cursoring jumps over references and some extra characters - https://phabricator.wikimedia.org/T123608#2035803 (10DLynch) Possibly related: T119838 for the cursor requiring two presses to get past a mwEntity. [17:59:44] 10VisualEditor, 10VisualEditor-ContentEditable, 10VisualEditor-MediaWiki-References: Snowman added and references deleted by edits of one user (broken browser?) - https://phabricator.wikimedia.org/T126910#2035885 (10Elitre) Looks like [[ https://it.wikipedia.org/w/index.php?title=Utente%3AElitre_%28WMF%29%2F... [18:05:37] (03CR) 10Catrope: [C: 04-1] Provide methods to (de)serialize transactions (034 comments) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/231017 (https://phabricator.wikimedia.org/T74658) (owner: 10Esanders) [18:06:22] (03CR) 10Catrope: Provide methods to (de)serialize transactions (032 comments) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/231017 (https://phabricator.wikimedia.org/T74658) (owner: 10Esanders) [18:07:33] (03CR) 10Catrope: Provide methods to (de)serialize transactions (031 comment) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/231017 (https://phabricator.wikimedia.org/T74658) (owner: 10Esanders) [18:27:38] Ooh look, a URL to the stand-alone version of VE for that wiki's code version: https://www.mediawiki.org/w/extensions/VisualEditor/lib/ve/demos/ve/desktop.html#!pages/simple.html [18:27:42] * James_F applauds. [18:57:03] 10VisualEditor, 10Parsoid, 10Wikimedia-Site-Requests: Visual Editor doesn't work in ady.wikipedia.org - https://phabricator.wikimedia.org/T127218#2036081 (10Amire80) 3NEW [19:13:38] 10VisualEditor, 10Parsoid, 10Wikimedia-Site-Requests, 5Patch-For-Review: Visual Editor doesn't work in ady.wikipedia.org - https://phabricator.wikimedia.org/T127218#2036207 (10ssastry) @Amire80, The fixes are already documented in https://wikitech.wikimedia.org/wiki/Add_a_wiki under the Parsoid and RESTBas... [19:16:21] 10VisualEditor, 10Parsoid, 10Wikimedia-Site-Requests, 5Patch-For-Review: Visual Editor doesn't work in ady.wikipedia.org - https://phabricator.wikimedia.org/T127218#2036238 (10Amire80) >>! In T127218#2036207, @ssastry wrote: > @Amire80, The fixes are already documented in https://wikitech.wikimedia.org/wik... [19:17:47] 10VisualEditor, 10Parsoid, 10Wikimedia-Site-Requests, 5Patch-For-Review: Visual Editor doesn't work in ady.wikipedia.org - https://phabricator.wikimedia.org/T127218#2036248 (10ssastry) >>! In T127218#2036238, @Amire80 wrote: >>>! In T127218#2036207, @ssastry wrote: >> @Amire80, The fixes are already docume... [19:21:19] edsanders: CR on https://gerrit.wikimedia.org/r/#/c/271030/ appreciated. :-) [19:22:15] 10VisualEditor, 10Parsoid, 10Wikimedia-Site-Requests, 5Patch-For-Review: Visual Editor doesn't work in ady.wikipedia.org - https://phabricator.wikimedia.org/T127218#2036269 (10mobrovac) Note that `ady.wp.org` is already alive for RESTBase: https://ady.wikipedia.org/api/rest_v1/?doc . Once Parsoid's site ma... [19:25:38] (03CR) 10Esanders: Provide methods to (de)serialize transactions (034 comments) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/231017 (https://phabricator.wikimedia.org/T74658) (owner: 10Esanders) [19:25:54] (03PS8) 10Esanders: Provide methods to (de)serialize transactions [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/231017 (https://phabricator.wikimedia.org/T74658) [19:29:48] James_F, I guess in some browsers just attempting to load VE code will fatal [19:30:06] but standalone doesn't load it async so... [19:30:50] edsanders: Why? [19:30:59] (03CR) 10jenkins-bot: [V: 04-1] Provide methods to (de)serialize transactions [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/231017 (https://phabricator.wikimedia.org/T74658) (owner: 10Esanders) [19:31:20] James_F, well a bunch of files have immediately executing code [19:31:39] e.g. registration [19:31:50] Oh, yeah, ES3 clients won't be happy for ES5 stuff. [19:31:52] * James_F nods. [19:35:41] (03CR) 10Esanders: [C: 04-1] Move initialisation browser support checking from downstream (033 comments) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/271030 (owner: 10Jforrester) [20:05:09] 10Cite, 10Graph, 10MediaWiki-API: gzipped page props - https://phabricator.wikimedia.org/T127225#2036363 (10Jdlrobson) 3NEW [20:05:23] 10Cite, 5Patch-For-Review, 3Reading-Web-Sprint-65-Game of Phones, 5WMF-deploy-2016-02-23_(1.27.0-wmf.15): Save references in page_props and cache - https://phabricator.wikimedia.org/T125329#2036372 (10Jdlrobson) >>! In T125329#2032789, @Cenarium wrote: > Page_props allows to store the data //somewhere//. B... [20:09:17] 10Cite, 10Graph, 10MediaWiki-API: gzipped page props - https://phabricator.wikimedia.org/T127225#2036391 (10matmarex) This would be cool. The issue affects TemplateData too. [20:10:32] 10Cite, 10TemplateData, 10Graph, 10MediaWiki-API: gzipped page props - https://phabricator.wikimedia.org/T127225#2036397 (10Jdforrester-WMF) [20:12:00] 10Cite, 10TemplateData, 10Graph, 10MediaWiki-API: gzipped page props - https://phabricator.wikimedia.org/T127225#2036400 (10matmarex) It would be nice if it worked with Special:PagesWithProp too, right now it just doesn't display binary or large values (see SpecialPagesWithProp::formatResult). [20:19:09] (03CR) 10Jforrester: Move initialisation browser support checking from downstream (033 comments) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/271030 (owner: 10Jforrester) [20:22:46] (03PS3) 10Jforrester: Move initialisation browser support checking from downstream [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/271030 [20:28:03] (03CR) 10jenkins-bot: [V: 04-1] Move initialisation browser support checking from downstream [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/271030 (owner: 10Jforrester) [20:38:19] (03PS4) 10Jforrester: Move initialisation browser support checking from downstream [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/271030 [20:39:22] RoanKattouw: Is there a cleaner way to do https://gerrit.wikimedia.org/r/#/c/271030/ architecturally? [20:41:03] James_F: Will look later, busy now [20:41:12] Sure. [21:02:27] 10VisualEditor, 10Parsoid, 10Wikimedia-Site-Requests, 5Patch-For-Review: Visual Editor doesn't work in ady.wikipedia.org - https://phabricator.wikimedia.org/T127218#2036556 (10Krenair) This is probably my fault. I created the wiki and RESTBase was already set up correctly for it. I also documented the Pars... [21:07:09] 10Cite, 10TemplateData, 10Graph, 10MediaWiki-API: gzipped page props - https://phabricator.wikimedia.org/T127225#2036590 (10Anomie) Fortunately we now have a "PageProps" class that manages access to the database table, thanks to @cicalese. The logic for handling gzipped `pp_value` fields (and maybe also va... [21:16:45] 10Cite, 10TemplateData, 10Graph, 10MediaWiki-API: gzipped page props - https://phabricator.wikimedia.org/T127225#2036631 (10matmarex) [21:23:17] 10Cite, 10TemplateData, 10Graph, 10MediaWiki-API: gzipped page props - https://phabricator.wikimedia.org/T127225#2036656 (10Yurik) Graph ext uses its own api call to get pp_value unzipped. Also note that for `format=json`, it returns the value directly in the body of the response, not as a string. And I a... [21:24:16] 10VisualEditor, 10VisualEditor-MediaWiki, 7Technical-Debt, 5WMF-deploy-2016-02-16_(1.27.0-wmf.14): Move generateCitationFeatures out of MWTarget - https://phabricator.wikimedia.org/T89746#2036661 (10Jdforrester-WMF) 5Open>3Resolved a:3Jdforrester-WMF [21:24:20] 10VisualEditor, 10VisualEditor-MediaWiki, 7Technical-Debt, 5WMF-deploy-2016-02-16_(1.27.0-wmf.14): Move generateCitationFeatures out of MWTarget - https://phabricator.wikimedia.org/T89746#1044332 (10Jdforrester-WMF) Done in https://gerrit.wikimedia.org/r/#/c/254082/9/modules/ve-mw/init/ve.init.mw.Target.js [21:30:00] 10Cite, 10TemplateData, 10Graph, 10MediaWiki-API: gzipped page props - https://phabricator.wikimedia.org/T127225#2036677 (10matmarex) Hmm, interesting, but I think we can do this one step at a time. I imagine sending JSON-as-string (with all the escaped `"`) is still going to be better for performance than... [21:37:46] 10Cite, 10TemplateData, 10Graph, 10MediaWiki-API: gzipped page props - https://phabricator.wikimedia.org/T127225#2036716 (10Yurik) @matmarex in graph case, it is actually slower, because after being read from DB and unzipped, data has to be parsed into JSON, the specific graph's data retrieved (there could... [21:37:59] (03CR) 10Esanders: [C: 04-1] Move initialisation browser support checking from downstream (031 comment) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/271030 (owner: 10Jforrester) [21:40:43] (03CR) 10Catrope: [C: 04-1] "Looks good to me, one comment inline. Integration with VE-MW would have to be tested carefully, and we probably want a follow-up patch in " (031 comment) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/271030 (owner: 10Jforrester) [21:45:20] (03CR) 10Jforrester: Move initialisation browser support checking from downstream (032 comments) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/271030 (owner: 10Jforrester) [21:46:23] (03PS5) 10Jforrester: Move initialisation browser support checking from downstream [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/271030 [21:46:35] RoanKattouw: https://gerrit.wikimedia.org/r/#/c/271031/ [21:52:07] (03CR) 10Catrope: [C: 031] Use initialisation browser support checking from upstream [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/271031 (owner: 10Jforrester) [22:28:25] (03PS1) 10Jforrester: Follow-up c89be66: Fix build for added language 'nan' [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/271426 [22:40:31] 10Cite, 10TemplateData, 10Graph, 10MediaWiki-API: gzipped page props - https://phabricator.wikimedia.org/T127225#2036865 (10Anomie) Let's leave aside the completely unrelated (and -2ed) T120380 here. It's not at all on-topic for this task, which is about the fact that trying to return binary data just does... [22:56:54] 10Cite, 10TemplateData, 10Graph, 10MediaWiki-API: gzipped page props - https://phabricator.wikimedia.org/T127225#2036896 (10cicalese) [23:21:12] 10Cite, 10TemplateData, 10Graph, 10MediaWiki-API: gzipped page props - https://phabricator.wikimedia.org/T127225#2036996 (10Yurik) @anomie, I disagree that it is unrelated. My understanding is that most usecases for binary pageprops is actually to store large json, and having a standard mechanism to get th... [23:21:46] (03CR) 10Legoktm: [C: 032] build: Update mediawiki-codesniffer to 0.6.0, add "composer fix" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/271281 (owner: 10Jforrester) [23:22:02] legoktm: Whee. [23:32:18] (03CR) 10jenkins-bot: [V: 04-1] build: Update mediawiki-codesniffer to 0.6.0, add "composer fix" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/271281 (owner: 10Jforrester) [23:34:37] Whut. [23:35:08] WTF is junit? [23:38:05] Java's unit test framework, which is actually a generic XML-driven test framework. Many other unit test things run on top of it [23:38:19] I think it's also a spec for XML-based communication of unit test results [23:38:25] that a lot of other frameworks use [23:39:22] 23:25:22 + hhvm phpunit.php --log-junit /mnt/jenkins-workspace/workspace/mediawiki-extensions-hhvm/log/junit-phpunit-allexts.xml --testsuite extensions [23:39:23] 23:25:23 A copy of your installation's LocalSettings.php [23:39:23] 23:25:23 must exist and be readable in the source directory. [23:39:23] 23:25:23 Use --conf to specify it. [23:39:33] (03CR) 10Legoktm: [C: 032] build: Update mediawiki-codesniffer to 0.6.0, add "composer fix" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/271281 (owner: 10Jforrester) [23:40:11] Dirty workspace? [23:40:39] or LocalSettings vanished midway through? [23:41:12] That would be bad. [23:46:14] (03Merged) 10jenkins-bot: build: Update mediawiki-codesniffer to 0.6.0, add "composer fix" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/271281 (owner: 10Jforrester) [23:58:54] RoanKattouw: Merge https://gerrit.wikimedia.org/r/#/c/271030/ maybe? :-)