[00:00:35] <grrrit-wm>	 (03CR) 10Catrope: [C: 032] Move initialisation browser support checking from downstream [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/271030 (owner: 10Jforrester)
[00:04:49] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Move initialisation browser support checking from downstream [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/271030 (owner: 10Jforrester)
[00:12:03] <wikibugs>	 10TemplateData, 10OOjs-UI: Draggable list not working as expected in TemplateData - https://phabricator.wikimedia.org/T127203#2037312 (10Krenair) Appears to be related to the if ( this.sideInsertion === 'after' ) case in OO.ui.mixin.DraggableGroupElement.prototype.onItemDrop
[00:18:56] <Krenair>	 Hi RoanKattouw 
[00:19:33] <RoanKattouw>	 Hey
[00:19:56] <Krenair>	 RoanKattouw, do you remember the plan to stop stripping meta items from the model data?
[00:20:02] <Krenair>	 was there a ticket?
[00:20:09] <Krenair>	 I found https://phabricator.wikimedia.org/T63861#648996 again today
[00:21:20] <RoanKattouw>	 We talked about it at the time, but then for comments we just ended up making them a node instead of a meta item
[00:21:20] <RoanKattouw>	 So I don't think that notion ever got anywhere, because just using a node turned out to work pretty well
[00:21:26] <RoanKattouw>	 For redirects we may want something slightly different, but perhaps along the same lines
[00:22:48] <Krenair>	 well redirects can't occur anywhere in the document, has to be the first thing on the page
[00:23:26] <Krenair>	 but other than that... can't think of any other issues. would parsoid changes be needed?
[00:24:23] <RoanKattouw>	 I don't think so
[00:24:32] <RoanKattouw>	 You could probably experiment with making redirects a node rather than a meta item
[00:34:24] <yurik>	 hi, for RTL languages, do we do anything magical with CSS?
[00:34:37] <James_F>	 Yes.
[00:34:47] <James_F>	 CSSJanus.
[00:34:47] <RoanKattouw>	 Do you know about CSSJanus?
[00:35:05] <yurik>	 i heard of it, what do i need to do to make sure a CSS passes through it?
[00:35:14] <RoanKattouw>	 Nothing
[00:35:22] <yurik>	 RoanKattouw, http://en.wikipedia.beta.wmflabs.org/wiki/Map?uselang=he
[00:35:22] <RoanKattouw>	 ResourceLoader does that automatically
[00:35:39] <RoanKattouw>	 Looking
[00:35:49] <yurik>	 for some reason all the tiles are still loaded as if its an LTR
[00:35:56] <yurik>	 (with the right LTR positions)
[00:36:19] <yurik>	 switching the container's dir to RTL solves it
[00:36:33] <RoanKattouw>	 It's possible some CSS is bypassing janus, and for somethings you need /* @noflip */ to bypass it explicitly
[00:36:37] <RoanKattouw>	 Hmm
[00:36:41] <RoanKattouw>	 Which container?
[00:37:24] <yurik>	 RoanKattouw, <div class="mw-kartographer mw-kartographer-interactive 
[00:37:54] <RoanKattouw>	 OK
[00:38:08] <RoanKattouw>	 yurik: Try writing a CSS rule like .mw-kartographer { direction: ltr; }
[00:38:23] <yurik>	 RoanKattouw, what's even weirder by the way, is that http://en.wikipedia.beta.wmflabs.org/wiki/Map?uselang=he&debug=true is showing it ok
[00:38:26] <RoanKattouw>	 That looks silly, and will be a no-op in LTR languages, but in RTL languages it'll be Janused to direction: rtl;
[00:38:44] <RoanKattouw>	 hah! Then maybe you do need noflips
[00:38:44] <RoanKattouw>	 Because Janus doesn't work in debug mode
[00:38:52] <RoanKattouw>	 But try the direction trick first
[00:38:58] <yurik>	 thanks
[00:39:31] <RoanKattouw>	 Oh, nope, I found it
[00:39:40] <RoanKattouw>	 .leaflet-map-pane, .leaflet-tile, .leaflet-marker-icon, .leaflet-marker-shadow, .leaflet-tile-pane, .leaflet-tile-container, .leaflet-overlay-pane, .leaflet-shadow-pane, .leaflet-marker-pane, .leaflet-popup-pane, .leaflet-overlay-pane svg, .leaflet-zoom-box, .leaflet-image-layer, .leaflet-layer{ top:0; left: 0; }
[00:39:51] <RoanKattouw>	 That left: 0; gets Janused to right: 0; in RTL, which screws up the layout
[00:40:07] <RoanKattouw>	 Find that CSS rule in your source and add /* @noflip */ above it
[00:40:07] <RoanKattouw>	 (Above the left: 0; line)
[00:40:10] <RoanKattouw>	 ( yurik ---^^ )
[00:40:30] <yurik>	 RoanKattouw, thx!
[00:40:41] <yurik>	 i was kinda hoping that i wouldn't have to change upstream file
[00:40:55] <yurik>	 is it possible to work around that?
[00:41:26] <yurik>	 RoanKattouw, ^
[00:48:25] <yurik>	 RoanKattouw, i'm not exactly sure where to insert that :)  https://github.com/wikimedia/mediawiki-extensions-Kartographer/blob/master/lib/mapbox/style.css
[00:48:43] <yurik>	 there are like 10 different left:0 :)
[00:51:24] <wikibugs>	 10Cite: References stored in page props are not parsed - https://phabricator.wikimedia.org/T127263#2037529 (10Jdlrobson) 3NEW
[00:52:33] <wikibugs>	 10Cite: References stored in page props are not parsed - https://phabricator.wikimedia.org/T127263#2037529 (10Jdlrobson)
[00:52:50] <wikibugs>	 10Cite, 10MediaWiki-API, 10MobileFrontend, 5Patch-For-Review, 3Reading-Web-Sprint-66-Harry is Tired: Should be possible to access references and notes for a given page via API - https://phabricator.wikimedia.org/T123290#2037543 (10Jdlrobson)
[00:59:50] <grrrit-wm>	 (03CR) 10Jforrester: [C: 032] "Don't mind me." [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/271426 (owner: 10Jforrester)
[01:00:04] <grrrit-wm>	 (03CR) 10Jforrester: [C: 032] "Per Roan." [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/271030 (owner: 10Jforrester)
[01:04:29] <RoanKattouw>	 yurik: Hmm you might need both of them
[01:04:43] <yurik>	 RoanKattouw, might need both what?
[01:04:48] <RoanKattouw>	 yurik: We should possibly have a RL feature where you can exclude an upstream file from Janus
[01:04:55] <RoanKattouw>	 s/both/all/
[01:05:00] <RoanKattouw>	 of the left:0 rules
[01:05:13] <RoanKattouw>	 The one I identified is on line 80
[01:05:23] <RoanKattouw>	 But the others might be causing smaller issues in other parts of the interface
[01:05:25] <yurik>	 btw i tried to set the dir=rtl on the div, and its not working.  Ithink its because i was doing it in debug
[01:05:29] <RoanKattouw>	 e.g. popups
[01:05:38] <yurik>	 major bleh
[01:06:01] <yurik>	 i reaaaaly don't want to mess with that file
[01:07:00] <RoanKattouw>	 yurik: Alternatively, you can write another CSS file that loads after that does  /* @noflip*/ body.rtl [insert original selector here] { left: 0; right: auto; }
[01:07:03] <grrrit-wm>	 (03Merged) 10jenkins-bot: Follow-up c89be66: Fix build for added language 'nan' [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/271426 (owner: 10Jforrester)
[01:07:05] <grrrit-wm>	 (03Merged) 10jenkins-bot: Move initialisation browser support checking from downstream [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/271030 (owner: 10Jforrester)
[01:07:51] <yurik>	 RoanKattouw, hmm, that might work.  I'm not that good with css, what select would i need?
[01:08:41] <yurik>	 selector
[01:08:48] <RoanKattouw>	 In this case that would be /* @noflip */ body.rtl  .leaflet-map-pane, body.rtl .leaflet-tile, body.rtl .leaflet-marker-icon, body.rtl .leaflet-marker-shadow, body.rtl .leaflet-tile-pane, body.rtl .leaflet-tile-container, body.rtl .leaflet-overlay-pane, body.rtl .leaflet-shadow-pane, body.rtl .leaflet-marker-pane, body.rtl  .leaflet-popup-pane, body.rtl .leaflet-overlay-pane svg, body.rtl...
[01:08:58] <RoanKattouw>	 ....leaflet-zoom-box, body.rtl .leaflet-image-layer, body.rtl .leaflet-layer { left: 0; right: auto; }
[01:08:59] <RoanKattouw>	 (I think)
[01:09:19] <RoanKattouw>	 Basically it's that giant selector on lines 65-78 with "body.rtl " added before every comma-separated item
[01:10:51] * yurik is testing
[01:10:58] <yurik>	 thx btw for helping!
[01:12:19] <grrrit-wm>	 (03PS1) 10Jforrester: Update VE core submodule to master (d87c384) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/271455 
[01:13:56] <yurik>	 RoanKattouw, awesome, works!  Still a huge pain, because now we are relying on their class names not to change, but still better than changing it!
[01:13:57] <yurik>	 http://vem3.wmflabs.org/wiki/San_Francisco?uselang=he
[01:14:15] <grrrit-wm>	 (03PS2) 10Jforrester: Use initialisation browser support checking from upstream [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/271031 
[01:15:28] <RoanKattouw>	 yurik: Yeah and you're relying on them not introducing new CSS rules that set left: 0; as well :/ but it's better than patching it
[01:15:36] <RoanKattouw>	 yurik: I take it you control when this library is updated?
[01:15:41] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Update VE core submodule to master (d87c384) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/271455 (owner: 10Jforrester)
[01:16:25] <yurik>	 RoanKattouw, yep
[01:16:39] <yurik>	 so yes, will have to be very carefull
[01:16:39] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Use initialisation browser support checking from upstream [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/271031 (owner: 10Jforrester)
[01:17:28] <RoanKattouw>	 Yeah, but at least you know when to check (i.e. when you update it)
[01:17:45] <RoanKattouw>	 Nice, seems to be working well, popup alignment looks fine and the zoom controls etc also move to the other side
[01:18:08] <yurik>	 RoanKattouw, http://vem3.wmflabs.org/wiki/San_Francisco?uselang=he&veaction=edit -- is that a James_F|Away bug?
[01:18:33] <yurik>	 when clicking on the map, the edit box is on the right
[01:18:45] <RoanKattouw>	 Looking
[01:19:20] <RoanKattouw>	 Probably a VE bug yes
[01:19:25] <yurik>	 ok, will file it
[01:19:26] <RoanKattouw>	 Lemme try that with an image
[01:20:28] <yurik>	 that editor is not finished yet, so it could be the bug in the edsanders|away code too
[01:21:13] <RoanKattouw>	 Hmm works with an image though
[01:22:21] <yurik>	 yeah, i guess its a kartographer's VE than, thx
[01:22:35] <yurik>	 RoanKattouw, thanks for all your help!
[01:24:28] <RoanKattouw>	 Hmm it shouldn't be, because that's the context item, so that looks like a VE bug
[01:24:34] <RoanKattouw>	 But offhand I can't reproduce it with an image
[01:33:34] <Krenair>	 so parsoid gives us a <link>, how do I get CE to show the redirect icon and target title...
[01:40:05] <grrrit-wm>	 (03Abandoned) 10Jforrester: Update VE core submodule to master (d87c384) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/271455 (owner: 10Jforrester)
[01:45:09] <RoanKattouw>	 Krenair: There's probably a RedirectMetaItem class or something? You'd write a RedirectNode whose .static.match* properties match that <link>
[01:45:17] <RoanKattouw>	 Based on its RDFa type etc
[01:45:34] <Krenair>	 yes, I did that
[01:45:47] <grrrit-wm>	 (03PS3) 10Jforrester: Update VE core submodule to master (d87c384) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/271031 
[01:46:00] <RoanKattouw>	 OK
[01:46:16] <RoanKattouw>	 So in the associated ce.Node subclass (with the same .static.name) is where the rendering happens
[01:46:22] <Krenair>	 yes
[01:46:27] <RoanKattouw>	 You might be able to base this on how CommentNode was done?
[01:46:30] <grrrit-wm>	 (03CR) 10Jforrester: [C: 04-1] "Need to check this in the platform" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/271031 (owner: 10Jforrester)
[01:46:41] <Krenair>	 no, I don't think so
[01:47:28] <Krenair>	 CommentNode just shows invisible and uses iconWhenInvisible
[01:47:54] <RoanKattouw>	 lol really? That must be new
[01:48:02] <RoanKattouw>	 Although that is a clever use of that new feature
[01:48:02] <Krenair>	 I need to insert a .redirectMsg block
[01:48:08] <RoanKattouw>	 Oh yes
[01:48:26] <RoanKattouw>	 So I'm guessing you got it to show the title, but then the icon went away because it's no longer invisible?
[01:49:10] <Krenair>	 no, didn't get it to show the title
[01:49:25] <RoanKattouw>	 OK
[01:49:44] <RoanKattouw>	 So, what is your current state of progress? And what does your ve.ce.RedirectNode.js (or whatever you called it) look like?
[01:49:49] <Krenair>	 haven't figured out what the proper way to return a block of HTML to show the element as is
[01:49:54] <RoanKattouw>	 Oh, I see
[01:50:08] <Krenair>	 ve.ce.MWRedirectNode = function VeCeMwRedirectNode( model, config ) {
[01:50:09] <Krenair>	 OO.inheritClass( ve.ce.MWRedirectNode, ve.ce.LeafNode );
[01:50:09] <Krenair>	 OO.mixinClass( ve.ce.MWRedirectNode, ve.ce.FocusableNode );
[01:50:18] <Krenair>	 ve.ce.MWRedirectNode.static.name = 'mwRedirect';
[01:50:18] <Krenair>	 ve.ce.MWRedirectNode.static.primaryCommandName = 'mwRedirect';
[01:50:23] <Krenair>	 ve.ce.MWRedirectNode.static.getDescription = function ( model ) {
[01:50:26] <Krenair>	 ve.ce.nodeFactory.register( ve.ce.MWRedirectNode );
[01:50:27] <Krenair>	 etc.
[01:50:28] <RoanKattouw>	 A CE node behaves like an OOUI element, so this.$element will be the root element (its tagname determined by .static.tagName) and you .append
[01:50:30] <RoanKattouw>	 () stuff to it
[01:50:54] <Krenair>	 oh, okay .what's the proper function to do that inside of?
[01:50:56] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Update VE core submodule to master (d87c384) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/271031 (owner: 10Jforrester)
[01:51:00] <RoanKattouw>	 I was just thinking about that
[01:51:15] <RoanKattouw>	 In this case I *think* it's the constructor, but lemme look at examples
[01:51:46] <RoanKattouw>	 Yup, constructor
[01:52:00] <Krenair>	 aha
[01:52:01] <Krenair>	 yep
[01:52:06] <RoanKattouw>	 You should only need to put stuff in other methods if you're doing things that rely on the node already being visible (e.g. measuring dimensions)
[01:52:42] <RoanKattouw>	 Hmm MWMagicLinkNode is a decent example
[01:53:04] <RoanKattouw>	 You'd want to put the population of the text (from the DM attribute) in an onUpdate method, because it also needs to run when you change the redirect target in the DM
[01:53:32] <Krenair>	 thanks Roan
[01:54:49] <RoanKattouw>	 Sure
[01:54:53] <RoanKattouw>	 Sorry I didn't understand where you were at at first; it's been a while since I messed with VE code
[01:55:23] <grrrit-wm>	 (03PS4) 10Jforrester: Update VE core submodule to master (d87c384) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/271031 
[01:55:32] <grrrit-wm>	 (03CR) 10Jforrester: "> Need to check this in the platform" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/271031 (owner: 10Jforrester)
[01:58:32] <James_F>	 RoanKattouw: Merge https://gerrit.wikimedia.org/r/#/c/269889/ maybe?
[01:59:14] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Update VE core submodule to master (d87c384) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/271031 (owner: 10Jforrester)
[01:59:18] <James_F>	 Whut.
[02:02:32] <grrrit-wm>	 (03PS5) 10Jforrester: Update VE core submodule to master (d87c384) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/271031 
[02:03:30] <grrrit-wm>	 (03CR) 10Catrope: [C: 04-1] ve.dm.ElementLinearData.static.compareElements: Add a couple of missed test cases (031 comment) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/269889 (owner: 10Jforrester)
[02:06:47] <grrrit-wm>	 (03CR) 10Jforrester: ve.dm.ElementLinearData.static.compareElements: Add a couple of missed test cases (031 comment) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/269889 (owner: 10Jforrester)
[02:13:04] <wikibugs>	 10VisualEditor, 7Technical-Debt: ve.init.Platform#isInternetExplorer shouldn't exist - https://phabricator.wikimedia.org/T126026#2037669 (10Catrope)
[02:17:01] <wikibugs>	 10VisualEditor, 10Parsoid, 10Wikimedia-Site-Requests, 5Patch-For-Review: Visual Editor doesn't work in ady.wikipedia.org - https://phabricator.wikimedia.org/T127218#2037686 (10Jdforrester-WMF) p:5Triage>3Unbreak!
[02:17:09] <Krenair>	 James_F, hey
[02:17:28] <Krenair>	 So with https://phabricator.wikimedia.org/T63861 would we still want to be opening the meta dialog on load?
[02:19:55] <James_F>	 Krenair: Probably.
[02:21:38] <grrrit-wm>	 (03PS2) 10Jforrester: dm.ElementLinearData.compareElements: Add a couple of missed test cases [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/269889 
[02:22:01] <Krenair>	 RoanKattouw, so we'll still need to be able to find this node and alter it from the meta dialog
[02:22:16] <RoanKattouw>	 Yeah
[02:22:36] <RoanKattouw>	 MetaList indexed MetaItems but we have no similar index for nodes
[02:22:58] <RoanKattouw>	 Iterating over the entire linmod to find a redirect node is probably expensive
[02:23:04] <Krenair>	 not really
[02:23:15] <Krenair>	 a redirect node should pretty much always occur at index 1
[02:23:17] <RoanKattouw>	 Right
[02:23:29] <RoanKattouw>	 If you're able to bail at a low index, that could work
[02:23:31] <Krenair>	 (index 0 would be the paragraph open)
[02:24:11] <Krenair>	 from the browser console I know how to go through ve.init.target.surface.model.documentModel.data.data
[02:24:21] <Krenair>	 but I need to get the actual node objects
[02:24:42] <RoanKattouw>	 Yeah also please don't literally use that way of accessing it in production code
[02:24:51] <RoanKattouw>	 Hmm does RedirectNode have hasContent  = true ?
[02:24:59] <RoanKattouw>	 I presume it does, since you implied it was inside a paragraph
[02:25:15] <Krenair>	 Yes, I was not planning to use that in the actual code :)
[02:25:32] <Krenair>	 yes it does
[02:26:03] <Krenair>	 I don't really understand where we draw the line and what the implications of that are
[02:26:18] <RoanKattouw>	 No that's  good in this case
[02:26:41] <RoanKattouw>	 There's a function somewhere that gives you the first content offset
[02:26:45] <RoanKattouw>	 Which is where the redirect node will be
[02:27:30] <Krenair>	 ve.dm.Surface.prototype.selectFirstContentOffset ?
[02:27:55] <RoanKattouw>	 Yeah that's what I was thinking of, but you probably don't want to select it
[02:27:59] <Krenair>	 which does var firstOffset = this.getDocument().data.getNearestContentOffset( 0, 1 );
[02:28:06] <RoanKattouw>	 But instead you want to use ... exactly
[02:28:13] <RoanKattouw>	 Presumably you're in ve.init.mw.DesktopArticleTarget.prototype.maybeShowMetaDialog
[02:28:31] <RoanKattouw>	 So this.getSurface().getModel().getDocument().data.etc
[02:28:41] <Krenair>	 Yes, but we'll also need the same code when modifying the contents from inside the meta dialog
[02:28:48] <Krenair>	 yep
[02:29:14] <wikibugs>	 10VisualEditor, 6Editing-Analysis: Update Product page with January numbers for Editing - https://phabricator.wikimedia.org/T127248#2037719 (10Jdforrester-WMF)
[02:29:37] <Krenair>	 So how do I get the node object at this offset?
[02:30:25] <RoanKattouw>	 That'll give you the offset, and then this.getSurface().getModel().getDocument().getDocumentNode().getNodeFromOffset( offset +1 ) will give you that node
[02:30:37] <RoanKattouw>	 I'm not totally sure if you need the +1 but I think you do
[02:30:52] <RoanKattouw>	 (Also, meh, you shouldn't have to do getDocumentNode there :( )
[02:32:00] <RoanKattouw>	 Then you should be able to check its .getType() to see what it is
[02:33:58] <Krenair>	 yep
[02:34:17] <RoanKattouw>	 You'll also need to check for getNearestContentOffset returning -1, and for getNodeFromOffset returning null
[02:34:29] <Krenair>	 okay so, I'll need the ability to change the target
[02:34:49] <RoanKattouw>	 Yes
[02:34:49] <RoanKattouw>	 Presumably the target is an attribute of the DM node?
[02:35:07] <RoanKattouw>	 Like, { type: 'mwRedirect', { attributes: { target: 'Blah' } } or something?
[02:35:13] <Krenair>	 attributes: Object
[02:35:13] <Krenair>	 hrefPrefix: "./"
[02:35:13] <Krenair>	 lookupTitle: "Main Page"
[02:35:13] <Krenair>	 normalizedTitle: "Main Page"
[02:35:13] <Krenair>	 origTitle: "Main_Page"
[02:35:14] <Krenair>	 title: "Main Page"
[02:35:22] <Krenair>	 :|
[02:35:25] <Krenair>	 yep
[02:35:40] <RoanKattouw>	 That's .. whoa why so many
[02:35:57] <Krenair>	 oh, also we'll need to prevent the user from moving the redirect node elsewhere in the document by dragging it
[02:36:03] <RoanKattouw>	 Oh because it reuses the LinkAnnotation code
[02:36:12] <RoanKattouw>	 Yeah :( that part sucks
[02:36:17] <Krenair>	 but they should still be able to delete it
[02:36:35] <RoanKattouw>	 Re changing it, the meta dialog already does that, that should mostly be the same I think
[02:37:23] <RoanKattouw>	 Oh meh it'll be quite different actually, because it's a node not a meta item
[02:37:52] <Krenair>	 this.getMetaItem( 'mwRedirect' )
[02:37:57] <Krenair>	 then .replaceWith
[02:38:06] <Krenair>	 or .remove
[02:38:17] <Krenair>	 or this.metaList.insertMeta( newRedirectItemData, 0, 0 );
[02:38:38] <RoanKattouw>	 Assuming you know the node's offset, you can do tx = ve.dm.Transaction.newFromAttributeChanges( dmDoc, offset, { key: 'newValue' } );
[02:38:59] <RoanKattouw>	 And then this.getSurface().getModel().change( tx );
[02:40:04] <Krenair>	 for changing existing redirect nodes, yeah
[02:40:07] <RoanKattouw>	 Yeah
[02:40:16] <Krenair>	 also have to handle the other two cases :'
[02:40:17] <Krenair>	 :/
[02:40:37] <RoanKattouw>	 Unfortunately you'll have to change/regenerate all those different attributes :/ but I'm guessing the existing code must already do that /somewhere/
[02:40:38] <RoanKattouw>	 Yeah you mean the insertion case and the deletion case?
[02:41:07] <RoanKattouw>	 Would those be relevant? Would we still allow the user to change the redirect target from the meta dialog?
[02:41:33] <James_F>	 I think so.
[02:41:44] <Krenair>	 that's the idea, yeah
[02:42:02] <RoanKattouw>	 Hmm OK
[02:42:04] <Krenair>	 although maybe we could have an inspector for editing/deleting existing redirects
[02:42:11] <James_F>	 RoanKattouw: https://gerrit.wikimedia.org/r/269889 BTW.
[02:42:17] <RoanKattouw>	 Yes we'd also want an inspector
[02:42:20] <Krenair>	 and just a button in the meta dialog to make a new one where there is not an existing one
[02:42:40] <Krenair>	 not sure we want to advertise that in the toolbar :p
[02:42:59] <RoanKattouw>	 Removing an existing node is not too difficult. tx = ve.dm.Transaction.newFromRemoval( doc, redirectNode.getOuterRange() );
[02:44:30] <RoanKattouw>	 or ( doc, new ve.Range( offset, offset + 2 ) ) if you already know the offset
[02:49:54] <James_F>	 RoanKattouw: Not just a trigger on edit to open the meta dialog?
[02:49:58] <James_F>	 Simpler.
[02:50:14] <RoanKattouw>	 Oh instead of an inspector? Sure, maybe
[02:50:24] <James_F>	 Less work for Krenair.
[02:50:26] <James_F>	 :-)
[02:50:39] <James_F>	 Especially as we're probably going to want inline editing rather than an inspector.
[02:50:58] <RoanKattouw>	 I feel like this is the kind of thing you have to code up first, find out what it feels like, and then decide what it should be like
[02:51:14] * James_F nods.
[03:05:02] <wikibugs>	 10VisualEditor, 10VisualEditor-MediaWiki: VisualEditor: Show something other than a blank page when editing a redirect page - https://phabricator.wikimedia.org/T63861#2037804 (10Krenair) a:3Krenair
[03:06:04] <Krenair>	 I have a 9AM and should get some sleep, will continue this later
[03:06:35] <Krenair>	 thanks for your help RoanKattouw, the logic to open the dialog (with node offsets etc.) appears to work
[03:09:06] <RoanKattouw>	 Awesome
[03:09:08] <RoanKattouw>	 Good night Krenair 
[03:27:38] <James_F>	 RoanKattouw: https://gerrit.wikimedia.org/r/#/c/269889/ still. ;-)
[03:32:12] <grrrit-wm>	 (03CR) 10Catrope: [C: 04-1] dm.ElementLinearData.compareElements: Add a couple of missed test cases (032 comments) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/269889 (owner: 10Jforrester)
[03:53:37] <grrrit-wm>	 (03PS3) 10Jforrester: dm.ElementLinearData.compareElements: Add a few missed test cases [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/269889 
[03:56:14] <grrrit-wm>	 (03PS4) 10Jforrester: dm.ElementLinearData.compareElements: Add a few missed test cases [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/269889 
[03:56:46] <grrrit-wm>	 (03CR) 10Catrope: [C: 032] dm.ElementLinearData.compareElements: Add a few missed test cases [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/269889 (owner: 10Jforrester)
[03:59:13] <James_F>	 RoanKattouw: Also https://gerrit.wikimedia.org/r/#/c/271031/
[04:00:19] <grrrit-wm>	 (03Merged) 10jenkins-bot: dm.ElementLinearData.compareElements: Add a few missed test cases [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/269889 (owner: 10Jforrester)
[04:06:30] <grrrit-wm>	 (03PS6) 10Jforrester: Update VE core submodule to master (cdfd84e) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/271031 
[04:07:17] <grrrit-wm>	 (03CR) 10Catrope: [C: 032] Update VE core submodule to master (cdfd84e) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/271031 (owner: 10Jforrester)
[04:14:11] <grrrit-wm>	 (03Merged) 10jenkins-bot: Update VE core submodule to master (cdfd84e) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/271031 (owner: 10Jforrester)
[08:45:45] <wikibugs>	 10VisualEditor, 6Community-Liaisons, 10MediaWiki-extensions-Score, 7Documentation: Make a new section for musical scores in the user guide for VisualEditor - https://phabricator.wikimedia.org/T117437#2038207 (10Qgil) Are you planning to work on this task during this quarter? I'm asking only to find the rig...
[08:47:44] <wikibugs>	 10VisualEditor, 6Community-Liaisons, 7Documentation: Add image uploading to User guide - https://phabricator.wikimedia.org/T117241#2038211 (10Qgil) Are you planning to work on this task during this quarter? I'm asking only to find the right place for this task in the #Community-Liaisons workboard.
[08:58:56] <wikibugs>	 10Citoid, 6Community-Liaisons, 6Developer-Relations: Tech Talk with Sebastian K. (Zotero) - https://phabricator.wikimedia.org/T125796#1997498 (10Qgil) Any indication about when approximately is this Tech Talk expected to happen? This quarter?
[09:22:04] <wikibugs>	 10Citoid, 6Community-Liaisons, 6Developer-Relations, 3DevRel-February-2016: Tech Talk with Sebastian K. (Zotero) - https://phabricator.wikimedia.org/T125796#2038254 (10Elitre)
[09:25:54] <grrrit-wm>	 (03CR) 10Hashar: [C: 04-1] "You want the loop to timeout after x occurrences / time." (031 comment) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/270724 (https://phabricator.wikimedia.org/T126966) (owner: 10Zfilipin)
[09:28:35] <wikibugs>	 10VisualEditor, 6Community-Liaisons, 7Documentation: Add image uploading to User guide - https://phabricator.wikimedia.org/T117241#1769385 (10Elitre) https://www.mediawiki.org/wiki/Help:VisualEditor/User_guide#Uploading_images is what that part of the guide looks like today, so maybe the task is resolved alr...
[09:34:00] <wikibugs>	 10Cite: Request for mediawiki:Cite section preview references format change - https://phabricator.wikimedia.org/T127188#2038320 (10TheDJ) ehm. that would seem more likely to be because Tidy is screwing with the generated output. Ah, this is because span was used instead of div... I warned about this....  Pinging...
[09:38:02] <Elitre>	 I... don't think I see VE on mediawiki.org?
[09:39:34] <Elitre>	 which happens, when you disable it from the Prefs. Which I don't remember doing though :/
[10:03:33] <wikibugs>	 10Cite, 5Patch-For-Review: Request for mediawiki:Cite section preview references format change - https://phabricator.wikimedia.org/T127188#2038423 (10Cenarium) a:5TheDJ>3None Indeed I had noticed this, see comments in https://gerrit.wikimedia.org/r/#/c/268870/.  The patch https://gerrit.wikimedia.org/r/270...
[10:03:54] <wikibugs>	 10Cite, 5Patch-For-Review: Request for mediawiki:Cite section preview references format change - https://phabricator.wikimedia.org/T127188#2038425 (10Cenarium) a:3Cenarium
[10:17:13] <Krenair>	 Elitre, I see it?
[10:25:10] <grrrit-wm>	 (03PS1) 10Esanders: Check node is an element before doing classList.contains [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/271480 
[10:25:59] <Elitre>	 Krenair: yup, you probably haven't disabled it and forgot about it -_-
[10:26:43] <Krenair>	 :)
[11:07:00] <wikibugs>	 10Cite: References stored in page props are not parsed - https://phabricator.wikimedia.org/T127263#2038560 (10Cenarium) Parsed, refs would take much more storage space and I think it should be avoided.  I presume that MobileFrontend will hook into the Cite extension to abort the return of <references> tags and i...
[11:36:58] <grrrit-wm>	 (03PS1) 10Esanders: MWCategoryWidget: Use namespace constants from config [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/271493 
[11:42:44] <wikibugs>	 10VisualEditor, 6Phabricator: Fix edit permissions of VisualEditor Phabricator projects - https://phabricator.wikimedia.org/T119622#2038710 (10Aklapper) @Jdforrester-WMF: Given T119622#1847450 I'll correct this in the next days if there are no objections.
[12:22:20] <wikibugs>	 10Citoid, 6Community-Liaisons, 6Developer-Relations, 3DevRel-February-2016: Tech Talk with Sebastian K. (Zotero) - https://phabricator.wikimedia.org/T125796#2038906 (10Elitre)
[12:25:43] <wikibugs>	 10VisualEditor, 10VisualEditor-MediaWiki, 7Design, 7Epic, and 2 others: VisualEditor: Where VisualEditor is the primary editor, redlinks in read mode should open VE (not wikitext editor) - https://phabricator.wikimedia.org/T55441#836194 (10Johan) So does this affect any other wikis than the test wiki at th...
[13:03:50] <wikibugs>	 10VisualEditor, 10ContentTranslation-Deployments, 10ContentTranslation-cxserver, 10MediaWiki-extensions-ContentTranslation, and 6 others: Decom parsoid-lb.eqiad.wikimedia.org entrypoint - https://phabricator.wikimedia.org/T110474#2039160 (10Amire80) Is there anything left to do in ContentTranslation or cxs...
[13:13:33] <wikibugs>	 10VisualEditor, 10ContentTranslation-cxserver, 10MediaWiki-extensions-ContentTranslation, 10Parsoid, and 3 others: Is RDFa metadata in Parsoid HTML head actually useful to you / no user name & edit comment suppression in Parsoid <head> metadata - https://phabricator.wikimedia.org/T122390#2039202 (10Amire80)
[13:19:48] <wikibugs>	 10Citoid, 10Beta-Cluster-Infrastructure, 10ContentTranslation-cxserver, 10Graphoid, and 5 others: Migrate BetaCluster Node.JS services to Jessie and Node 4.2 - https://phabricator.wikimedia.org/T125003#2039236 (10Amire80)
[13:19:59] <wikibugs>	 10VisualEditor, 10ContentTranslation-cxserver, 10MediaWiki-extensions-ContentTranslation, 10Parsoid, and 2 others: Remove user name and edit comment from html <head> - https://phabricator.wikimedia.org/T125266#2039240 (10Amire80)
[13:41:04] <wikibugs>	 10VisualEditor, 10ContentTranslation-Deployments, 10ContentTranslation-cxserver, 10MediaWiki-extensions-ContentTranslation, and 6 others: Decom parsoid-lb.eqiad.wikimedia.org entrypoint - https://phabricator.wikimedia.org/T110474#2039294 (10BBlack) >>! In T110474#2039160, @Amire80 wrote: > Is there anythin...
[13:50:14] <wikibugs>	 10Citoid, 6Community-Liaisons, 6Developer-Relations, 3DevRel-February-2016: Tech Talk with Sebastian K. (Zotero) - https://phabricator.wikimedia.org/T125796#2039319 (10Trizek-WMF) >>! In T125796#2038229, @Qgil wrote: > Any indication about when approximately is this Tech Talk expected to happen? This quart...
[13:50:18] <wikibugs>	 10VisualEditor, 6Operations, 10Parsoid, 10Traffic, and 2 others: Decom parsoid-lb.eqiad.wikimedia.org entrypoint - https://phabricator.wikimedia.org/T110474#1578478 (10Amire80)
[13:50:59] <wikibugs>	 10VisualEditor, 6Operations, 10Parsoid, 10Traffic, and 2 others: Decom parsoid-lb.eqiad.wikimedia.org entrypoint - https://phabricator.wikimedia.org/T110474#2039324 (10Amire80) >>! In T110474#2039294, @BBlack wrote: >>>! In T110474#2039160, @Amire80 wrote: >> Is there anything left to do in ContentTranslat...
[14:06:49] <wikibugs>	 10Cite, 5Patch-For-Review, 5WMF-deploy-2016-02-23_(1.27.0-wmf.15): Request for mediawiki:Cite section preview references format change - https://phabricator.wikimedia.org/T127188#2039367 (10matmarex) 5Open>3Resolved Should be really fixed now.
[14:23:06] <wikibugs>	 10Cite, 5Patch-For-Review, 5WMF-deploy-2016-02-23_(1.27.0-wmf.15): Request for mediawiki:Cite section preview references format change - https://phabricator.wikimedia.org/T127188#2039409 (10IKhitron) If you mean now as NOW, @matmarex, it is not yet.
[14:24:24] <wikibugs>	 10Cite, 5Patch-For-Review, 5WMF-deploy-2016-02-23_(1.27.0-wmf.15): Request for mediawiki:Cite section preview references format change - https://phabricator.wikimedia.org/T127188#2039411 (10matmarex) Right, no, I mean whenever it's deployed. Which will probably be next week (see https://www.mediawiki.org/wik...
[14:29:25] <wikibugs>	 10Cite, 5Patch-For-Review, 5WMF-deploy-2016-02-23_(1.27.0-wmf.15): Request for mediawiki:Cite section preview references format change - https://phabricator.wikimedia.org/T127188#2039421 (10IKhitron) Very well, thank you.
[14:36:53] <grrrit-wm>	 (03PS8) 10Zfilipin: [BrowserTest] Fix `ve.init is undefined` error messages in Selenium tests [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/270724 (https://phabricator.wikimedia.org/T126966) 
[14:39:03] <grrrit-wm>	 (03CR) 10Zfilipin: [BrowserTest] Fix `ve.init is undefined` error messages in Selenium tests (031 comment) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/270724 (https://phabricator.wikimedia.org/T126966) (owner: 10Zfilipin)
[14:39:57] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] [BrowserTest] Fix `ve.init is undefined` error messages in Selenium tests [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/270724 (https://phabricator.wikimedia.org/T126966) (owner: 10Zfilipin)
[14:42:14] <grrrit-wm>	 (03PS9) 10Zfilipin: [BrowserTest] Fix `ve.init is undefined` error messages in Selenium tests [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/270724 (https://phabricator.wikimedia.org/T126966) 
[14:56:16] <grrrit-wm>	 (03CR) 10Jforrester: [C: 032] Check node is an element before doing classList.contains [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/271480 (owner: 10Esanders)
[14:59:05] <grrrit-wm>	 (03CR) 10Jforrester: [C: 032] MWCategoryWidget: Use namespace constants from config [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/271493 (owner: 10Esanders)
[15:01:02] <grrrit-wm>	 (03Merged) 10jenkins-bot: Check node is an element before doing classList.contains [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/271480 (owner: 10Esanders)
[15:10:48] <grrrit-wm>	 (03Merged) 10jenkins-bot: MWCategoryWidget: Use namespace constants from config [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/271493 (owner: 10Esanders)
[15:15:57] <wikibugs>	 10VisualEditor: Bad autoscroll with visual editor when edit a table cell which is taller than screen - https://phabricator.wikimedia.org/T127315#2039600 (10Pols12)
[15:20:20] <wikibugs>	 10Cite, 10MobileFrontend, 3Reading-Web-Sprint-67-i: Create Special:References fallback for non-JavaScript users - https://phabricator.wikimedia.org/T125897#2000071 (10dr0ptp4kt) Should the task title be updated to reflect this is for RL incompatible UAs? Or are we going to go the extra step and actually supp...
[15:28:05] <wikibugs>	 10VisualEditor, 10VisualEditor-MediaWiki: MWCategoryWidget fires an API request every time a category is moved - https://phabricator.wikimedia.org/T127317#2039664 (10Esanders)
[15:31:49] <wikibugs>	 10VisualEditor: Template (puzzle) icon displaces images/templates - https://phabricator.wikimedia.org/T127319#2039692 (10Lokal_Profil)
[15:38:40] <wikibugs>	 10VisualEditor, 10VisualEditor-MediaWiki, 7Design, 7Epic, and 2 others: VisualEditor: Where VisualEditor is the primary editor, redlinks in read mode should open VE (not wikitext editor) - https://phabricator.wikimedia.org/T55441#2039758 (10Johan) Something like this:  "In the future, clicking a red link w...
[15:41:54] <wikibugs>	 10VisualEditor: Template (puzzle) icon displaces images/templates - https://phabricator.wikimedia.org/T127319#2039775 (10Lokal_Profil) Possibly the problem is related to VE thinking that an image is a hidden template. If I modify the template by having it also add some random text the issue (i.e. puzzle icon) di...
[15:53:12] <wikibugs>	 10VisualEditor: Template (puzzle) icon displaces images/templates - https://phabricator.wikimedia.org/T127319#2039849 (10Lokal_Profil)
[15:53:25] <wikibugs>	 10VisualEditor: Template (puzzle) icon displaces images/templates - https://phabricator.wikimedia.org/T127319#2039692 (10Lokal_Profil)
[16:10:45] <wikibugs>	 10Cite: References stored in page props are not parsed - https://phabricator.wikimedia.org/T127263#2039903 (10Jdlrobson) The primary goal is not a special page but a JavaScript based rendering of references (in existing mobile web site we show references inside a panel at bottom of page).. So we need to work out...
[16:46:41] <grrrit-wm>	 (03PS5) 10Gerrit Patch Uploader: Remove deferred loading of the toolbar [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/268968 (https://phabricator.wikimedia.org/T126138) 
[16:46:44] <grrrit-wm>	 (03CR) 10Gerrit Patch Uploader: "This commit was uploaded using the Gerrit Patch Uploader [1]." [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/268968 (https://phabricator.wikimedia.org/T126138) (owner: 10Gerrit Patch Uploader)
[16:47:50] <grrrit-wm>	 (03CR) 10Paladox: "recheck" [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/268968 (https://phabricator.wikimedia.org/T126138) (owner: 10Gerrit Patch Uploader)
[16:48:16] <grrrit-wm>	 (03CR) 10Fomafix: Remove deferred loading of the toolbar (031 comment) [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/268968 (https://phabricator.wikimedia.org/T126138) (owner: 10Gerrit Patch Uploader)
[16:49:19] <grrrit-wm>	 (03CR) 10Fomafix: Remove deferred loading of the toolbar (032 comments) [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/268968 (https://phabricator.wikimedia.org/T126138) (owner: 10Gerrit Patch Uploader)
[16:50:18] <grrrit-wm>	 (03PS1) 10Esanders: MWCategoryWidget: Improve caching [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/271552 (https://phabricator.wikimedia.org/T127317) 
[17:12:37] <grrrit-wm>	 (03PS2) 10Esanders: MWCategoryWidget: Improve caching [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/271552 (https://phabricator.wikimedia.org/T127317) 
[17:12:39] <grrrit-wm>	 (03PS1) 10Esanders: MWMetaDialog: Fix setup of pages [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/271558 
[17:12:52] <wikibugs>	 10VisualEditor, 10VisualEditor-MediaWiki, 7Design, 7Epic, and 2 others: VisualEditor: Where VisualEditor is the primary editor, redlinks in read mode should open VE (not wikitext editor) - https://phabricator.wikimedia.org/T55441#2040255 (10Jdforrester-WMF) >>! In T55441#2039758, @Johan wrote: > Something...
[17:14:59] <grrrit-wm>	 (03PS3) 10Esanders: MWCategoryWidget: Improve caching [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/271552 (https://phabricator.wikimedia.org/T127317) 
[17:15:01] <grrrit-wm>	 (03PS2) 10Esanders: MWMetaDialog: Fix setup of pages [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/271558 
[17:51:55] <wikibugs>	 10VisualEditor: [Regression pre-wmf.14] Error "slug.firstChild.classList is undefined" appears while placing cursor at the end of a line - https://phabricator.wikimedia.org/T127341#2040424 (10Ryasmeen)
[18:05:05] <wikibugs>	 10VisualEditor, 10Graph: Cannot add a graph in VE , it says "Vega has encountered an error rendering this graph" - https://phabricator.wikimedia.org/T127343#2040496 (10Ryasmeen)
[18:05:18] <wikibugs>	 10VisualEditor, 10Graph: [Regression pre-wmf.14] Cannot add a graph in VE , it says "Vega has encountered an error rendering this graph" - https://phabricator.wikimedia.org/T127343#2040510 (10Ryasmeen)
[18:17:03] <wikibugs>	 10VisualEditor, 6Discovery, 10Maps: " Invalid parameters for the <maps> tag: Syntax error" appears in the read mode after adding map in VE - https://phabricator.wikimedia.org/T127345#2040584 (10Ryasmeen)
[18:17:17] <wikibugs>	 10VisualEditor, 10VisualEditor-MediaWiki, 7Design, 7Epic, and 2 others: VisualEditor: Where VisualEditor is the primary editor, redlinks in read mode should open VE (not wikitext editor) - https://phabricator.wikimedia.org/T55441#2040597 (10Johan) Makes sense. I'll do that.
[18:20:30] <wikibugs>	 10Cite: References stored in page props are not parsed - https://phabricator.wikimedia.org/T127263#2040660 (10Jdlrobson) Demonstration: Before: {F3371472} After: {F3371470}
[18:21:08] <wikibugs>	 10Cite, 10MobileFrontend, 3Reading-Web-Sprint-67-i: Create Special:References fallback for non-JavaScript/Resourceloader unsupported users - https://phabricator.wikimedia.org/T125897#2040662 (10Jdlrobson)
[18:21:25] <wikibugs>	 10Cite: References stored in page props are not parsed - https://phabricator.wikimedia.org/T127263#2040677 (10Jdlrobson)
[18:21:28] <wikibugs>	 10Cite, 10MobileFrontend, 3Reading-Web-Sprint-67-i: Create Special:References fallback for non-JavaScript/Resourceloader unsupported users - https://phabricator.wikimedia.org/T125897#2000071 (10Jdlrobson)
[18:22:51] <wikibugs>	 10Cite, 10MobileFrontend, 3Reading-Web-Sprint-67-i: Create Special:References fallback for non-JavaScript/Resourceloader unsupported users - https://phabricator.wikimedia.org/T125897#2000071 (10Jdlrobson) @Sumit Cite stores them in page props and they can be accessed via  Cite::getStoredReferences Unfortunat...
[18:26:16] <Krenair>	 RoanKattouw, hey
[18:26:44] <Krenair>	 So I have some (untested) code for changing/removing redirects from the meta dialog
[18:27:12] <Krenair>	 What about inserting a new redirect?
[18:28:04] <Krenair>	 presumably ve.dm.Transaction.newFromInsertion
[18:28:33] <Krenair>	 but the offset is...  0 always?
[18:32:34] <James_F>	 Krenair: Yes.
[18:40:24] <wikibugs>	 10Cite: References stored in page props are not parsed - https://phabricator.wikimedia.org/T127263#2040903 (10jhobs)
[18:43:13] <RoanKattouw>	 Hmm I wonder if that works, it might
[18:43:33] <RoanKattouw>	 You can't insert a redirect without a wrapping paragraph, but I think fixupInsertion should take care of that
[18:45:40] <wikibugs>	 10Citoid, 10VisualEditor, 10VisualEditor-MediaWiki-References, 6Community-Liaisons: Consider enabling citoid at smaller Wikipedias - https://phabricator.wikimedia.org/T127354#2040942 (10Whatamidoing-WMF)
[18:46:40] <wikibugs>	 10VisualEditor, 10VisualEditor-MediaWiki-Mobile, 7Browser-Support-Apple-Safari: Unable to scroll the "Review your changes" screen on mobile (iOS Safari 9.x) - https://phabricator.wikimedia.org/T126240#2008350 (10Jdforrester-WMF)
[18:54:38] <wikibugs>	 10Citoid, 10VisualEditor, 10VisualEditor-MediaWiki-References, 6Community-Liaisons: Consider helping some smaller Wikipedias' communities (which?) by writing the TemplateData to enable citoid for them - https://phabricator.wikimedia.org/T127354#2041001 (10Jdforrester-WMF)
[18:54:54] <wikibugs>	 10Citoid, 10VisualEditor, 10VisualEditor-MediaWiki-References, 6Community-Liaisons: Consider enabling citoid at smaller Wikipedias - https://phabricator.wikimedia.org/T127354#2041004 (10Whatamidoing-WMF)
[18:58:02] <wikibugs>	 10VisualEditor, 10Improving access, 6Research-and-Data, 5Patch-For-Review: Make a gadget for hyperlink recommendation - https://phabricator.wikimedia.org/T119477#2041017 (10Jdforrester-WMF)
[18:59:02] <wikibugs>	 10Citoid, 10VisualEditor, 10VisualEditor-MediaWiki-References, 6Community-Liaisons: Consider helping some smaller Wikipedias' communities (which?) by writing the TemplateData to enable citoid for them - https://phabricator.wikimedia.org/T127354#2041023 (10Jdforrester-WMF)
[19:00:03] <grrrit-wm>	 (03CR) 10Jforrester: [C: 032] MWCategoryWidget: Improve caching [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/271552 (https://phabricator.wikimedia.org/T127317) (owner: 10Esanders)
[19:00:27] <wikibugs>	 10VisualEditor, 10VisualEditor-MediaWiki, 7Performance: MWCategoryWidget fires an API request every time a category is moved - https://phabricator.wikimedia.org/T127317#2041049 (10Jdforrester-WMF) 5Open>3Resolved p:5Triage>3High a:3Esanders
[19:01:21] <wikibugs>	 10VisualEditor, 10VisualEditor-ContentEditable, 7Documentation, 5WMF-deploy-2016-02-16_(1.27.0-wmf.14): ve.ce.Annotation methods missing documentation - https://phabricator.wikimedia.org/T121351#2041059 (10Jdforrester-WMF) 5Open>3Resolved
[19:02:01] <wikibugs>	 10VisualEditor, 10VisualEditor-MediaWiki, 10Wikimedia-Site-Requests, 5Patch-For-Review: Enable single edit tab on huwiki and review - https://phabricator.wikimedia.org/T126801#2023737 (10Jdforrester-WMF)
[19:02:19] <wikibugs>	 10TemplateData, 10VisualEditor, 10VisualEditor-MediaWiki-Templates, 5Patch-For-Review: Create dedicated input methods for "wiki-page-name" transclusion parameters - https://phabricator.wikimedia.org/T124734#1964655 (10Jdforrester-WMF)
[19:05:39] <wikibugs>	 10VisualEditor, 10Parsoid, 10Wikimedia-Site-Requests, 5Patch-For-Review: Visual Editor doesn't work in ady.wikipedia.org - https://phabricator.wikimedia.org/T127218#2041072 (10ssastry) 5Open>3Resolved a:3Arlolra
[19:05:53] <wikibugs>	 10VisualEditor, 10Parsoid, 10Wikimedia-Site-Requests: Visual Editor doesn't work in ady.wikipedia.org - https://phabricator.wikimedia.org/T127218#2036081 (10ssastry)
[19:07:42] <grrrit-wm>	 (03Merged) 10jenkins-bot: MWCategoryWidget: Improve caching [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/271552 (https://phabricator.wikimedia.org/T127317) (owner: 10Esanders)
[19:12:23] <Krenair>	 doesn't quite seem to work :/
[19:12:38] <Krenair>	 (the insertion of new redirects, that is. changing/removing existing ones works fine)
[19:14:13] <wikibugs>	 10VisualEditor, 6Editing-Department, 10MobileFrontend, 7Mobile, and 4 others: Enable editing for mobile users without JavaScript and kill Special:MobileEditor code in MobileFrontend - https://phabricator.wikimedia.org/T125174#2041096 (10Jdlrobson) @florian I think that's a good idea but I'm not keen right...
[19:17:51] <wikibugs>	 10VisualEditor, 6Editing-Department, 10MobileFrontend, 7Mobile, and 4 others: Enable editing for mobile users without JavaScript and kill Special:MobileEditor code in MobileFrontend - https://phabricator.wikimedia.org/T125174#2041098 (10Florian) @jdlrobson If you leave a FIXME comment that this should be a...
[19:23:59] <grrrit-wm>	 (03PS1) 10Jforrester: MWPopupTool: Update Phabricator URL broken by upgrade [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/271585 
[19:25:34] <grrrit-wm>	 (03CR) 10Legoktm: [C: 032] MWPopupTool: Update Phabricator URL broken by upgrade [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/271585 (owner: 10Jforrester)
[19:39:09] <grrrit-wm>	 (03Merged) 10jenkins-bot: MWPopupTool: Update Phabricator URL broken by upgrade [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/271585 (owner: 10Jforrester)