[00:12:31] (03PS8) 10Alex Monk: [WIP] Allow TemplateData to output information about magic words [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/140445 (https://phabricator.wikimedia.org/T51996) [00:12:37] (03PS17) 10Paladox: Allow the signature wikitext to be overridden locally [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/258783 (https://phabricator.wikimedia.org/T26191) [00:29:32] 10Cite: CiteDataModule depends on request data - https://phabricator.wikimedia.org/T127916#2058320 (10bd808) [00:52:48] (03PS1) 10BryanDavis: Use inContentLanguage() in CitoidDataModule [extensions/Citoid] - 10https://gerrit.wikimedia.org/r/272920 (https://phabricator.wikimedia.org/T127864) [00:57:13] (03PS2) 10BryanDavis: Use inLanguage() in CitoidDataModule [extensions/Citoid] - 10https://gerrit.wikimedia.org/r/272920 (https://phabricator.wikimedia.org/T127864) [01:02:13] (03CR) 10Gergő Tisza: [C: 031] Use inLanguage() in CitoidDataModule [extensions/Citoid] - 10https://gerrit.wikimedia.org/r/272920 (https://phabricator.wikimedia.org/T127864) (owner: 10BryanDavis) [01:02:19] (03CR) 10Jforrester: [C: 032] Use inLanguage() in CitoidDataModule [extensions/Citoid] - 10https://gerrit.wikimedia.org/r/272920 (https://phabricator.wikimedia.org/T127864) (owner: 10BryanDavis) [01:03:46] (03Merged) 10jenkins-bot: Use inLanguage() in CitoidDataModule [extensions/Citoid] - 10https://gerrit.wikimedia.org/r/272920 (https://phabricator.wikimedia.org/T127864) (owner: 10BryanDavis) [01:08:51] James_F, should wiki-user-name consider IPs to be valid? [01:09:17] Krenair: Yes. Including IPv6. But not ranges. [01:09:52] Krenair: Did SWAT not happen? [01:10:37] James_F, it was delayed and I was expecting RoanKattouw to do it, but it doesn't look like it [01:10:50] I'll sync our patches after Aaron [01:11:09] He's mid-conversation and has been for a long time, AFAICT. [01:11:33] MW's User::isValidUserName hardcodes a username character blacklist regex :( [01:12:07] 10VisualEditor: Three windows overlapping dialong boxes appear when I click Edit (SET + CX is too much) - https://phabricator.wikimedia.org/T127917#2058392 (10Whatamidoing-WMF) [01:14:28] 10VisualEditor: Second item in Single Edit Tab dialog box is not properly centered - https://phabricator.wikimedia.org/T127918#2058411 (10Whatamidoing-WMF) [01:19:21] 10VisualEditor, 10Wikimedia-Site-Requests, 13Patch-For-Review: Enable VisualEditor for logged-out and newly registered users on German Wikipedia - https://phabricator.wikimedia.org/T127881#2058430 (10Jdforrester-WMF) p:5Triage>3High a:5Elitre>3Jdforrester-WMF [01:19:53] 10VisualEditor, 10Wikimedia-Site-Requests, 13Patch-For-Review: Enable VisualEditor for logged-out and newly registered users on German Wikipedia - https://phabricator.wikimedia.org/T127881#2058434 (10Jdforrester-WMF) 5Open>3stalled This is now waiting for the end of the community vote. [01:23:14] 10VisualEditor, 10VisualEditor-MediaWiki, 7Performance: Investigate why VE is consistently **2-4X** slower to switch to Edit after switching back to Read the first time, compared to the first switch after load - https://phabricator.wikimedia.org/T127921#2058465 (10Jdforrester-WMF) [01:23:28] 10Citoid, 10MediaWiki-Authentication-and-authorization, 13Patch-For-Review: CitoidDataModule depends on request data - https://phabricator.wikimedia.org/T127864#2058480 (10Krinkle) [01:23:41] (03CR) 10Jforrester: [C: 032] "Thanks, Krinkle; filed T127921 for the performance issue." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/272763 (https://phabricator.wikimedia.org/T127319) (owner: 10Esanders) [01:24:34] 10VisualEditor, 10Wikimedia-Site-Requests, 13Patch-For-Review: Enable VisualEditor for logged-out and newly registered users on German Wikipedia - https://phabricator.wikimedia.org/T127881#2057383 (10Whatamidoing-WMF) Gradual rollouts are not very difficult (in this case), but I doubt that it would be necess... [01:33:49] (03Merged) 10jenkins-bot: Make surface measurable while activating [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/272763 (https://phabricator.wikimedia.org/T127319) (owner: 10Esanders) [01:38:55] 10Citoid, 10MediaWiki-Authentication-and-authorization, 13Patch-For-Review: CitoidDataModule depends on request data - https://phabricator.wikimedia.org/T127864#2056863 (10Krinkle) [01:39:12] 10VisualEditor, 10Wikimedia-Site-Requests, 13Patch-For-Review: The Visual Editor is asked for two additional namespaces on the French Wiktionary - https://phabricator.wikimedia.org/T127819#2058555 (10Krenair) 5Open>3Resolved [01:40:13] 10Cite, 13Patch-For-Review: CiteDataModule depends on request data - https://phabricator.wikimedia.org/T127916#2058562 (10Krinkle) 5Open>3Resolved [01:51:16] 10VisualEditor, 6Operations, 10Parsoid, 10Traffic, and 2 others: Decom parsoid-lb.eqiad.wikimedia.org entrypoint - https://phabricator.wikimedia.org/T110474#1578558 (10Jackmcbarn) FYI, I didn't realize that this was taking parsoid-prod.wmflabs.org down until it happened, so a lot of the requests from it we... [01:54:26] 10VisualEditor, 6Operations, 10Parsoid, 10Traffic, and 2 others: Decom parsoid-lb.eqiad.wikimedia.org entrypoint - https://phabricator.wikimedia.org/T110474#2058577 (10ssastry) >>! In T110474#2058575, @Jackmcbarn wrote: > FYI, I didn't realize that this was taking parsoid-prod.wmflabs.org down until it hap... [01:55:12] 10VisualEditor, 6Operations, 10Parsoid, 10Traffic, and 2 others: Decom parsoid-lb.eqiad.wikimedia.org entrypoint - https://phabricator.wikimedia.org/T110474#2058578 (10Jackmcbarn) No problem, I already have it taken care of. [02:28:38] 10Cite, 10VisualEditor, 7Performance, 15User-bd808, 5WMF-deploy-2016-03-01_(1.27.0-wmf.15): CiteDataModule depends on request data - https://phabricator.wikimedia.org/T127916#2058595 (10Jdforrester-WMF) a:3bd808 [02:28:53] 10Citoid, 10VisualEditor, 10MediaWiki-Authentication-and-authorization, 7Performance, and 2 others: CitoidDataModule depends on request data - https://phabricator.wikimedia.org/T127864#2058599 (10Jdforrester-WMF) a:3bd808 [02:29:51] 10VisualEditor, 10Math: [Regression pre-wmf.15] "this.model is null" appears after typing a formula inside Math dialog - https://phabricator.wikimedia.org/T127854#2058607 (10Jdforrester-WMF) [02:29:53] 10VisualEditor, 10Math, 6Services, 13Patch-For-Review, 5WMF-deploy-2016-03-01_(1.27.0-wmf.15): [Regression pre-wmf.15] Math node is appearing as UNIQ marker in Read mode - https://phabricator.wikimedia.org/T127738#2058603 (10Jdforrester-WMF) 5Open>3Resolved a:3Physikerwelt OK, I think this is now f... [02:30:21] 10VisualEditor, 10Math, 5WMF-deploy-2016-03-01_(1.27.0-wmf.15): [Regression pre-wmf.15] "this.model is null" appears after typing a formula inside Math dialog - https://phabricator.wikimedia.org/T127854#2056252 (10Jdforrester-WMF) 5Open>3Resolved a:3Physikerwelt [02:45:29] (03CR) 10Krinkle: [C: 04-1] "Composer does have that concept, but they do it differently. But it's quite similar." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/268795 (owner: 10Jforrester) [02:46:17] (03CR) 10Krinkle: [C: 04-1] "This is extension.json, not package.json." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/268801 (owner: 10Jforrester) [02:59:10] (03CR) 10Alex Monk: "> The (i) etc. only shows when the field is focussed (to avoid the tab order being sucky), but that doesn't work for checkboxes." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/169936 (https://phabricator.wikimedia.org/T55613) (owner: 10Alex Monk) [02:59:45] (03PS24) 10Alex Monk: [WIP] Use widgets for wiki-page-name, wiki-user-name, wiki-template-name, boolean, URL and line template fields [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/169936 (https://phabricator.wikimedia.org/T55613) [03:07:14] 10VisualEditor, 10Kartographer, 7Beta-Cluster-reproducible: VE Map does not load dependency - https://phabricator.wikimedia.org/T127865#2058649 (10Krinkle) Module `leaflet.draw` contains `leaflet.draw-src.js` and `leaflet.draw.i18n.js` both of which presume the presence of a global `L` variable. Module `lea... [03:53:43] 10VisualEditor, 6Discovery, 10Kartographer, 10Maps: " Invalid parameters for the tag: Syntax error" appears in the read mode after adding map in VE - https://phabricator.wikimedia.org/T127345#2058677 (10Yurik) 5Open>3Resolved [03:56:48] 10VisualEditor, 10Kartographer: [Regression pre-wmf.15] VE crashes while trying to add map, Error "mw.kartographer.setGeoJsonString is not a function" appears in the console - https://phabricator.wikimedia.org/T127849#2058684 (10Yurik) 5Open>3Resolved Kartographer has not been enabled to any of the wikis y... [03:57:23] 10VisualEditor, 10Kartographer, 7Beta-Cluster-reproducible, 13Patch-For-Review: VE Map does not load dependency - https://phabricator.wikimedia.org/T127865#2058686 (10Yurik) 5Open>3Resolved @krinkle, thanks, silly me, thanks for solving this. [05:57:04] 10VisualEditor, 10Improving-access, 6Research-and-Data, 13Patch-For-Review: Make a gadget for hyperlink recommendation - https://phabricator.wikimedia.org/T119477#2058758 (10leila) @Esanders I think we can proceed as follows: * If you could, please check the [[ https://docs.google.com/presentation/d/14u5r... [09:19:52] 10Cite, 10MediaWiki-API, 10MobileFrontend, 13Patch-For-Review, 3Reading-Web-Sprint-67-i: What is impact of storing references - https://phabricator.wikimedia.org/T126802#2058939 (10jcrespo) We had 36GB free one week ago on s2-master. We are more confortable now, but not totally until new hardware arrives... [10:32:55] 10VisualEditor, 10Improving-access, 6Research-and-Data, 13Patch-For-Review: Make a gadget for hyperlink recommendation - https://phabricator.wikimedia.org/T119477#2059088 (10Esanders) That would be a lot of work, we don't have the infrastructure in place that would be required to implement it i.e. adding i... [10:38:05] 10TemplateData, 10VisualEditor: TemplateData editor fails catastrophically when data contains $1 - https://phabricator.wikimedia.org/T127898#2059092 (10Esanders) This is the quickest fix. Ideally we'd just use offset splices. [10:48:00] 10VisualEditor, 10VisualEditor-MediaWiki, 7Design: Too many pop-ups before a user can start editing? - https://phabricator.wikimedia.org/T124294#2059125 (10Elitre) [10:48:02] 10VisualEditor: Three windows overlapping dialong boxes appear when I click Edit (SET + CX is too much) - https://phabricator.wikimedia.org/T127917#2059124 (10Elitre) [11:29:54] (03PS1) 10Esanders: Remove matching groups from regex [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/272958 (https://bugzilla.wikimedia.org/127898) [11:55:40] (03CR) 10Siebrand: [C: 04-1] "i18n/L10n reviewed." (031 comment) [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/258783 (https://phabricator.wikimedia.org/T26191) (owner: 10Paladox) [12:01:24] 10VisualEditor, 10VisualEditor-MediaWiki: Get rev id from teh etag - https://phabricator.wikimedia.org/T127941#2059227 (10Esanders) [12:01:37] 10VisualEditor, 10VisualEditor-MediaWiki: Get rev id from the etag - https://phabricator.wikimedia.org/T127941#2059245 (10Esanders) [12:02:06] 10VisualEditor, 10ContentTranslation-cxserver, 10MediaWiki-extensions-ContentTranslation, 10Parsoid, and 3 others: Is RDFa metadata in Parsoid HTML head actually useful to you / no user name & edit comment suppression in Parsoid metadata - https://phabricator.wikimedia.org/T122390#1903033 (10Esanders... [12:04:22] 10VisualEditor: Consider alternative wording for "You have switched to source editing" pop-up - https://phabricator.wikimedia.org/T127942#2059249 (10Elitre) [12:07:32] 10VisualEditor, 10VisualEditor-MediaWiki: Get rev id from the etag - https://phabricator.wikimedia.org/T127941#2059263 (10Esanders) Problem: The ETag isn't available if you aren't using RESTBase. [12:08:52] 10VisualEditor, 10ContentTranslation-cxserver, 10MediaWiki-extensions-ContentTranslation, 10Parsoid, and 3 others: Is RDFa metadata in Parsoid HTML head actually useful to you / no user name & edit comment suppression in Parsoid metadata - https://phabricator.wikimedia.org/T122390#2059265 (10Esanders... [12:09:02] I wish we had created a SET project on phab! [13:12:39] (03CR) 10Paladox: Allow the signature wikitext to be overridden locally (031 comment) [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/258783 (https://phabricator.wikimedia.org/T26191) (owner: 10Paladox) [13:16:45] (03CR) 10Siebrand: Allow the signature wikitext to be overridden locally (031 comment) [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/258783 (https://phabricator.wikimedia.org/T26191) (owner: 10Paladox) [13:46:59] (03PS18) 10Paladox: Allow the signature wikitext to be overridden locally [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/258783 (https://phabricator.wikimedia.org/T26191) [13:48:27] (03CR) 10Paladox: "Ok done." [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/258783 (https://phabricator.wikimedia.org/T26191) (owner: 10Paladox) [14:00:58] 10TemplateData: TemplateData shouldn't store paramOrder as a separate list - https://phabricator.wikimedia.org/T127958#2059634 (10Esanders) [14:34:59] (03CR) 10Siebrand: [C: 031] "i18n/L10n reviewed." [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/258783 (https://phabricator.wikimedia.org/T26191) (owner: 10Paladox) [14:58:50] 10TemplateData: Changing parameter doesn't adjust the paramOrder list, leaving it out of sync - https://phabricator.wikimedia.org/T127969#2059878 (10Esanders) [14:58:55] 10TemplateData: TemplateData shouldn't store paramOrder as a separate list - https://phabricator.wikimedia.org/T127958#2059890 (10Esanders) [15:02:16] 10VisualEditor, 10ContentTranslation-cxserver, 10MediaWiki-extensions-ContentTranslation, 10Parsoid, and 3 others: Is RDFa metadata in Parsoid HTML head actually useful to you / no user name & edit comment suppression in Parsoid metadata - https://phabricator.wikimedia.org/T122390#2059900 (10ssastry... [15:02:59] 10TemplateData: TemplateData shouldn't store paramOrder as a separate list - https://phabricator.wikimedia.org/T127958#2059903 (10Esanders) [15:03:09] Krinkle, https://phabricator.wikimedia.org/T127958 thoughts? [15:04:11] 10TemplateData: Changing parameter doesn't adjust the paramOrder list, leaving it out of sync - https://phabricator.wikimedia.org/T127969#2059925 (10Esanders) [15:04:31] (03PS2) 10Gerrit Patch Uploader: Use module jquery.spinner for spinner on preview [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/259217 [15:04:34] (03CR) 10Gerrit Patch Uploader: "This commit was uploaded using the Gerrit Patch Uploader [1]." [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/259217 (owner: 10Gerrit Patch Uploader) [15:05:34] edsanders: As long as we make it strictly enforced using the on-save validation, I'm all for it (e.g. enforce that keys have to be unique, which an array of objects does not naturally provide) [15:06:05] I'd do it without version number though. Just make the spec allow both and mark paramOrder as obsolete. [15:06:20] However it does affect API [15:06:24] which can auto-transform [15:06:29] just like it does already for various things we added [15:06:34] it's part of normalisation [15:07:01] If we want to maintain both versions in the API as well, we'd need a second normalisation option. But I think we can get away with breaking the API at this point. [15:07:26] Or we could keep the normalised consuming format as-is [15:07:30] and allow arrays as authoring format [15:07:45] That way consuming applications have less to loop over and worry about, which seems useful and more native. [15:11:31] 10VisualEditor, 10ContentTranslation-cxserver, 10MediaWiki-extensions-ContentTranslation, 10Parsoid, and 3 others: Is RDFa metadata in Parsoid HTML head actually useful to you / no user name & edit comment suppression in Parsoid metadata - https://phabricator.wikimedia.org/T122390#2059961 (10GWicke)... [15:12:09] (03PS1) 10Esanders: Included aliases in getAllParamNames [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/272986 [15:13:35] (03PS2) 10Esanders: Included aliases in getAllParamNames [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/272986 (https://phabricator.wikimedia.org/T111320) [15:13:38] (03PS2) 10Esanders: Included aliases in getAllParamNames [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/272986 (https://phabricator.wikimedia.org/T111320) [15:27:12] make the spec allow params to be an array or an object? [15:28:57] also I don't think client side validation should be a blocker to any fixes we make - as the user can always save invalid data editing the wikitext directly [15:31:07] In fact I noticed recently that on {{Infobox company}} someone had created new template data keys using copy and paste, but hadn't changed the object indexes - so they'd written invalid-ish JSON. The keys were deleted as soon as you edited it with the UI. [15:32:26] https://en.wikipedia.org/w/index.php?title=Template%3AInfobox_company%2Fdoc&type=revision&diff=706632583&oldid=705782658 (Search for "Line 830:") [15:57:02] (03CR) 10Jforrester: [C: 032] Included aliases in getAllParamNames [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/272986 (https://phabricator.wikimedia.org/T111320) (owner: 10Esanders) [15:57:21] 10TemplateData, 10VisualEditor, 10VisualEditor-MediaWiki: Don't propose parameters which are just used as aliases instead - https://phabricator.wikimedia.org/T111320#2060102 (10Jdforrester-WMF) 5Open>3Resolved a:3Esanders [15:58:26] (03Merged) 10jenkins-bot: Included aliases in getAllParamNames [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/272986 (https://phabricator.wikimedia.org/T111320) (owner: 10Esanders) [16:00:00] (03PS2) 10Jforrester: Remove matching groups from regex [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/272958 (https://phabricator.wikimedia.org/T127898) (owner: 10Esanders) [16:00:08] (03CR) 10Jforrester: [C: 032] Remove matching groups from regex [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/272958 (https://phabricator.wikimedia.org/T127898) (owner: 10Esanders) [16:00:53] 10VisualEditor, 7Browser-Tests, 13Patch-For-Review, 5WMF-deploy-2016-03-01_(1.27.0-wmf.15): Disable VisualEditor scenarios that fail at en.wikipedia.beta.wmflabs.org from running daily - https://phabricator.wikimedia.org/T94162#2060121 (10zeljkofilipin) [16:01:36] (03Merged) 10jenkins-bot: Remove matching groups from regex [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/272958 (https://phabricator.wikimedia.org/T127898) (owner: 10Esanders) [16:02:39] 10TemplateData, 10VisualEditor, 13Patch-For-Review: TemplateData editor fails catastrophically when data contains $1 - https://phabricator.wikimedia.org/T127898#2060125 (10Jdforrester-WMF) 5Open>3Resolved a:3Esanders [16:32:02] 10WikiEditor: Fallback messages get shown on RTL wikis with LTR user interface language - https://phabricator.wikimedia.org/T73661#2060252 (10Ladsgroup) I have no idea why users of Arabic Wikipedia did this. I can only guess, based on the source code, that they might wanted to keep LTR material (common.js pages... [16:45:37] (03PS1) 10DLynch: GeneratedContentNode: Check model existence before using [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/272999 (https://phabricator.wikimedia.org/T121162) [16:57:24] 10VisualEditor, 10MediaWiki-Vagrant: `TypeError: window.VisualEditorSupportCheck is not a function` when tring to edit a page using VisualEditor on MediaWiki-Vagrant - https://phabricator.wikimedia.org/T127986#2060412 (10zeljkofilipin) [17:03:25] Point of curiosity: is there any way to tell resourceloader to ignore missing files for a bit? [17:40:47] (03CR) 10Ryasmeen: [C: 032] "Reviewed it with Zeljko, looks good to me ." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/270724 (https://phabricator.wikimedia.org/T126966) (owner: 10Zfilipin) [17:56:59] (03Merged) 10jenkins-bot: [BrowserTest] Fix `ve.init is undefined` error messages in Selenium tests [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/270724 (https://phabricator.wikimedia.org/T126966) (owner: 10Zfilipin) [17:58:53] Kemayo: No, I don't think so. You can symlink them to /dev/null though, maybe. [18:01:02] James_F, meeting? [18:08:31] 10VisualEditor, 7Browser-Tests, 13Patch-For-Review, 5WMF-deploy-2016-03-01_(1.27.0-wmf.15): Disable VisualEditor scenarios that fail at en.wikipedia.beta.wmflabs.org from running daily - https://phabricator.wikimedia.org/T94162#2060741 (10zeljkofilipin) [18:08:33] 10VisualEditor, 7Browser-Tests, 13Patch-For-Review, 5WMF-deploy-2016-03-01_(1.27.0-wmf.15): Fix `ve.init is undefined` and `ve.init.target is undefined` error messages in VisualEditor browser tests - https://phabricator.wikimedia.org/T126966#2060740 (10zeljkofilipin) 5Open>3Resolved [18:21:12] Okay, I now have a couple of notes of stuff I should file [18:40:02] edsanders, all fixed now :) [18:40:05] thanks for your help yesterday [18:40:13] how do you flush cache? [18:40:24] ?action=purge [18:42:58] ah, thx, i thought there was something in the varnish [18:52:07] (03PS2) 10Jforrester: extension.json: Make clear this is VE-MW not VE-core [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/268801 [18:52:21] (03PS3) 10Jforrester: extension.json: Make clear this is VE-MW not VE-core [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/268801 [18:52:52] (03CR) 10Jforrester: extension.json: Make clear this is VE-MW not VE-core (031 comment) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/268801 (owner: 10Jforrester) [19:00:43] (03CR) 10Jforrester: "> The "name" property, for example, https://getcomposer.org/doc/04-schema.md#name, should not be specified unless the package is meant to " [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/268795 (owner: 10Jforrester) [19:18:55] 10WikiEditor: Fallback messages get shown on RTL wikis with LTR user interface language - https://phabricator.wikimedia.org/T73661#2061017 (10TheDJ) Yeah, no luck there. I'm wondering if we should just ask a global interface rights person to intervene to remove those, and then leave their community a message ref... [19:30:23] 10WikiEditor: Fallback messages get shown on RTL wikis with LTR user interface language - https://phabricator.wikimedia.org/T73661#750151 (10Jdforrester-WMF) >>! In T73661#2061017, @TheDJ wrote: > Yeah, no luck there. I'm wondering if we should just ask a global interface rights person to intervene to remove tho... [19:34:42] 10Cite, 10MobileFrontend, 3Reading-Web-Sprint-67-i: Create Special:Citations fallback for non-JavaScript/Resourceloader unsupported users - https://phabricator.wikimedia.org/T125897#2061120 (10Jdlrobson) [19:39:33] 10VisualEditor, 6Collaboration-Team-Backlog, 10Parsoid, 7Epic: HTML diffs of edits for everything - https://phabricator.wikimedia.org/T105173#1437960 (10Whatamidoing-WMF) Here's an example of what one editor is doing manually, to get a visual diff: https://en.wikipedia.org/w/index.php?title=User:Anthonyhc... [19:56:13] 10WikiEditor: Fallback messages get shown on RTL wikis with LTR user interface language - https://phabricator.wikimedia.org/T73661#2061238 (10TheDJ) I'll first drop a line to the last person to have made several edits to their Common.css file. https://ar.wikipedia.org/w/index.php?title=نقاش_المستخدم:زكريا&diff=1... [20:01:29] 10TemplateData: TemplateData shouldn't store paramOrder as a separate list - https://phabricator.wikimedia.org/T127958#2061257 (10Mooeypoo) The reason that paramOrder was added was because parameters are kept as an object and not an array, and therefore we can't trust their order. IIRC we talked about switching... [20:01:30] (03PS1) 10Esanders: Avoid calling repopulateParamSelectWidget multiple times on setup [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/273047 [20:02:39] 10TemplateData: TemplateData shouldn't store paramOrder as a separate list - https://phabricator.wikimedia.org/T127958#2059634 (10Jdforrester-WMF) It's absolutely not practical to make a breaking change to the syntax of TD JSON; we've committed to never invalidating it. [20:09:33] 10VisualEditor, 10VisualEditor-MediaWiki, 7Technical-Debt: Get rev id from the etag - https://phabricator.wikimedia.org/T127941#2061274 (10Jdforrester-WMF) p:5Triage>3Normal [20:13:56] 10VisualEditor, 10MediaWiki-Vagrant: `TypeError: window.VisualEditorSupportCheck is not a function` when tring to edit a page using VisualEditor on MediaWiki-Vagrant - https://phabricator.wikimedia.org/T127986#2060412 (10Jdforrester-WMF) Are you up to date? That sounds like the VE-core repo is out of date. [20:13:59] 10Cite, 10VisualEditor, 6Editing-Department: Cite should not depend on VisualEditor - https://phabricator.wikimedia.org/T127763#2061283 (10Jdlrobson) FYI this is really messing with my developer workflow since the reading team is doing lots of Cite development right now. I personally have problems getting Vi... [20:17:20] 10Cite, 10VisualEditor, 6Editing-Department: Cite should not depend on VisualEditor - https://phabricator.wikimedia.org/T127763#2053288 (10Jdforrester-WMF) >>! In T127763#2061283, @Jdlrobson wrote: > FYI this is really messing with my developer workflow since the reading team is doing lots of Cite developmen... [20:19:40] 10Cite, 10VisualEditor, 6Editing-Department: Cite should not depend on VisualEditor - https://phabricator.wikimedia.org/T127763#2061297 (10Jdlrobson) MobileFrontend has lots of soft dependencies and doesn't break when VisualEditor is not installed for example. It's trivial to add these modules conditionally... [20:21:04] 10Cite, 10VisualEditor, 6Editing-Department: Cite should not depend on VisualEditor - https://phabricator.wikimedia.org/T127763#2061301 (10Jdforrester-WMF) >>! In T127763#2061297, @Jdlrobson wrote: > Is there a good reason this method cannot be used in Cite? Well, yes – we're getting rid of those hooks inte... [20:23:04] 10Cite, 10VisualEditor, 6Editing-Department: Cite should not depend on VisualEditor - https://phabricator.wikimedia.org/T127763#2061303 (10Jdlrobson) Although performance is a noble cause, you are breaking expectations of how dependencies work and breaking these extensions for 3rd parties. This change makes... [20:23:29] 10VisualEditor, 6Editing-Department, 10SyntaxHighlight: The module 'ext.visualEditor.mwcore' required by 'ext.geshi.visualEditor' must exist - https://phabricator.wikimedia.org/T125494#2061305 (10Jdlrobson) [20:30:25] 10VisualEditor, 6Editing-Department, 10SyntaxHighlight: The module 'ext.visualEditor.mwcore' required by 'ext.geshi.visualEditor' must exist - https://phabricator.wikimedia.org/T125494#2061335 (10Jdlrobson) [20:30:42] 10VisualEditor, 6Editing-Department, 10SyntaxHighlight: The module 'ext.visualEditor.mwcore' required by 'ext.geshi.visualEditor' must exist - https://phabricator.wikimedia.org/T125494#1989189 (10Jdlrobson) [20:30:51] 10VisualEditor, 6Editing-Department, 10SyntaxHighlight: The module 'ext.visualEditor.mwcore' required by 'ext.geshi.visualEditor' must exist - https://phabricator.wikimedia.org/T125494#1989189 (10Jdlrobson) [21:21:04] 10VisualEditor, 10OOjs-UI: [Regression wmf.14] In Chrome, previously opened menu from OOUI toolbar doesn't close after opening another menu - https://phabricator.wikimedia.org/T127739#2052467 (10matmarex) It's a Chrome rendering bug, I suppose. For me, the same thing often happens with the "Notices" popup. [21:21:46] 10VisualEditor, 10OOjs-UI, 10Vector: [Regression wmf.14] Personal tools z-index are showing above OOUI dialogs - https://phabricator.wikimedia.org/T127742#2061588 (10matmarex) I'm pretty sure I fixed this bug at least three times in the past, and @esanders fixed it once or twice too. [22:14:30] James_F, refreshed PHlogiston chart it up [22:15:02] jaufrecht_: Yup, looks sane. Hurrah. [22:15:33] jaufrecht_: http://phlogiston.wmflabs.org/ve_net_growth_points.png still wonky. [22:16:03] force refresh [22:16:12] oh, yeah, that one [22:16:17] I'm thinking of killing it [22:16:39] nobody's ever pointed to it and said anything suggesting they learned something from it [22:17:06] forecasts and Dones look okay? [22:25:03] jaufrecht_: Yes. [22:36:13] 10VisualEditor, 10VisualEditor-MediaWiki: Give a useful message in the theoretically-temporary blank edit screen - https://phabricator.wikimedia.org/T128028#2061778 (10Krenair) [22:36:47] ugh [22:36:54] and of course as soon as I hit save I remember about my account split [22:37:11] although I did forget to record the time, so... [22:38:39] 10TemplateData, 10VisualEditor, 10VisualEditor-MediaWiki, 10VisualEditor-MediaWiki-Templates, and 3 others: Parsoid on serialisation should use the `format` field from TemplateData if available to set the whitespace formatting of new/edited transclusions - https://phabricator.wikimedia.org/T111674#2061790 (... [22:38:51] 10VisualEditor, 10VisualEditor-MediaWiki-References, 10Parsoid, 13Patch-For-Review, 7user-notice: Parsoid on serialisation should use the `paramOrder` field from TemplateData if available to set the order of parameters in new/edited transclusions - https://phabricator.wikimedia.org/T104599#2061791 (10ssa... [22:39:36] 10TemplateData, 10VisualEditor: TemplateData shouldn't store paramOrder as a separate list - https://phabricator.wikimedia.org/T127958#2061792 (10Esanders) >>! In T127958#2061260, @Jdforrester-WMF wrote: > It's absolutely not practical to make a breaking change to the syntax of TD JSON; we've committed to neve... [22:43:17] 10TemplateData, 10VisualEditor: TemplateData's PHP JSON validation isn't strict enough - https://phabricator.wikimedia.org/T128029#2061803 (10Jdforrester-WMF) [22:44:57] Krinkle: https://phabricator.wikimedia.org/T128029 sucks and it's all your fault. ;-) [23:19:40] James_F, i absolutelly love how it is not as strict as original json, because that allows for these! https://www.mediawiki.org/wiki/Extension:Graph/Demo/CategoryPie [23:21:31] yurik: What? [23:21:48] yurik: That page doesn't use TemplateData. [23:22:03] i'm talking about php being good with all sorts of json parsing :) [23:22:13] and allow comments and trailing commas [23:24:28] "Good". [23:25:00] As in, training users that things will work, just to make them sad in a few months time when we put it on JSON content model pages. :-( [23:40:44] James_F, any RFC about that? [23:40:47] would love to read up [23:41:13] yurik: https://phabricator.wikimedia.org/T107595 is the best one. [23:41:23] And https://phabricator.wikimedia.org/T56140 for the TemplateData use of that. [23:41:49] https://phabricator.wikimedia.org/T96384 might be interesting to you too. [23:41:52] James_F, i saw the first one before - is it bein implemented? [23:42:06] yurik: Slooooowly. [23:42:11] thought so :) [23:42:25] yurik: If you feel like helping out… ;-) [23:42:42] no bandwidth [23:42:48] (sounds familiar, eh?) [23:43:30] yeah, so this is a fairly fundamental overhaul, might be a very long time [23:49:59] 10Cite: Allow to preview list-defined references in the section where they are defined - https://phabricator.wikimedia.org/T128036#2061976 (10Cenarium) [23:50:15] 10Cite: Allow to preview list-defined references in the section where they are defined - https://phabricator.wikimedia.org/T128036#2061988 (10Cenarium) a:3Cenarium [23:51:11] 10Cite: Allow to preview list-defined references in the section where they are defined - https://phabricator.wikimedia.org/T128036#2061976 (10Cenarium) This was suggested by D'Ranged 1 on [[https://en.wikipedia.org/wiki/User_talk:Cenarium#Footnote_preview.E2.80.94possible_enhancement.3F|my talk page]]. [23:52:07] 10Cite: Allow to preview list-defined references in the section where they are defined - https://phabricator.wikimedia.org/T128036#2061990 (10Cenarium) p:5Triage>3Low