[00:00:15] 23:59:29 1) ResourcesTest::testUnsatisfiableDependencies [00:00:15] 23:59:29 The module 'ext.visualEditor.mwmeta' must not have target 'mobile' because its dependency 'mediawiki.action.view.redirectPage' does not have it [00:00:20] okay, at least I already knew about this one [00:00:25] wish I had remembered I needed to upload that commit [00:01:22] Want me to do it so you can merge? ;-) [00:02:08] Bad moment for mediawiki core repo to be corrupt... [00:02:36] already done James_F [00:02:40] Ha. [00:03:31] (03PS4) 10Alex Monk: Show redirect target inside target [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/273391 (https://phabricator.wikimedia.org/T63861) [00:07:48] James_F, doesn't this depend on one of ed's commits? [00:08:18] Other way around. [00:08:25] (03PS4) 10Jforrester: CategoryWidget: Update to work with new DraggableGroupElement [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/273263 (owner: 10Esanders) [00:08:30] … which I've now rebased onto it. [00:08:39] (03CR) 10Jforrester: [C: 032] CategoryWidget: Update to work with new DraggableGroupElement [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/273263 (owner: 10Esanders) [00:09:59] did you actually review that in that amount of time? :p [00:10:05] (03CR) 10Alex Monk: [C: 032] Update VE core submodule to master (8450592) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/273395 (owner: 10Jforrester) [00:10:50] Krenair: In the 23 minutes since I pushed 273395 and started looking for things to be based on it? :-) [00:24:53] (03Merged) 10jenkins-bot: Update VE core submodule to master (8450592) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/273395 (owner: 10Jforrester) [00:24:55] (03Merged) 10jenkins-bot: CategoryWidget: Update to work with new DraggableGroupElement [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/273263 (owner: 10Esanders) [00:26:02] (03PS3) 10Jforrester: CategoryWidget: Remove reorder event fix after upstream fix [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/273383 (owner: 10Esanders) [00:26:35] (03CR) 10Ryasmeen: "Instead of just selecting the whole link text, can we also open another inspector to add label upon clicking the button? Just like how we " [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/272510 (https://phabricator.wikimedia.org/T124305) (owner: 10DLynch) [01:23:52] (03PS1) 10Jforrester: Update VE core submodule to wmf/1.27.0-wmf.14 HEAD (301bcd4) [extensions/VisualEditor] (wmf/1.27.0-wmf.14) - 10https://gerrit.wikimedia.org/r/273408 [01:24:20] (03CR) 10Jforrester: [C: 032] Update VE core submodule to wmf/1.27.0-wmf.14 HEAD (301bcd4) [extensions/VisualEditor] (wmf/1.27.0-wmf.14) - 10https://gerrit.wikimedia.org/r/273408 (owner: 10Jforrester) [01:31:54] (03Merged) 10jenkins-bot: Update VE core submodule to wmf/1.27.0-wmf.14 HEAD (301bcd4) [extensions/VisualEditor] (wmf/1.27.0-wmf.14) - 10https://gerrit.wikimedia.org/r/273408 (owner: 10Jforrester) [01:40:27] (03CR) 10Jforrester: "On adding a redirect," [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/273391 (https://phabricator.wikimedia.org/T63861) (owner: 10Alex Monk) [01:40:34] (03CR) 10Jforrester: [C: 04-1] Show redirect target inside target [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/273391 (https://phabricator.wikimedia.org/T63861) (owner: 10Alex Monk) [06:24:17] (03CR) 10Florianschmidtwelzow: [C: 031] "Code looks good, haven't tested yet." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/271994 (https://phabricator.wikimedia.org/T112599) (owner: 10Alex Monk) [10:51:51] 10VisualEditor, 7Browser-Tests, 13Patch-For-Review, 5WMF-deploy-2016-03-01_(1.27.0-wmf.15): Fix VisualEditor scenarios that fail at en.wikipedia.beta.wmflabs.org or do not run them daily - https://phabricator.wikimedia.org/T94162#2066047 (10zeljkofilipin) 5Open>3Resolved Resolving this task. I have cre... [11:11:48] 10Cite, 10VisualEditor, 10VisualEditor-MediaWiki-References: Warning about an empty citation has a broken link - https://phabricator.wikimedia.org/T127102#2066148 (10eranroz) I just noted that the "map" part to citoid in one the citation templates in hewiki was missing in the templatedata. I couldn't guess i... [11:13:25] (03PS1) 10Esanders: FindAndReplace: Avoid getNativeRange() optimisation [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/273433 [11:19:30] 10VisualEditor, 10VisualEditor-ContentEditable: Offset adjustment in getSelectionState should preserve collapsedness - https://phabricator.wikimedia.org/T128176#2066195 (10dchan) [11:20:08] (03PS1) 10Divec: Make getSelectionState preserve collapsedness [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/273435 (https://phabricator.wikimedia.org/T128176) [11:37:12] (03PS1) 10Esanders: WindowAction: Don't emit position event [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/273439 [11:41:10] (03PS1) 10Esanders: FindAndReplace: Keep results cache to reduce re-renderings [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/273440 [11:41:52] 10VisualEditor: Find and replace feature froze my browser - https://phabricator.wikimedia.org/T125277#2066257 (10Esanders) 5Open>3stalled https://gerrit.wikimedia.org/r/#/c/273440/ will make scrolling faster - but can't do anything with this bug without specifics. [11:46:11] someone definitely wants to expand the dependency field for VE at https://www.mediawiki.org/wiki/Wikimedia_Engineering/2015-16_Q3_Goals#Editing . CLs are definitely not the only one, or even the main one for that matter. [13:10:10] 10VisualEditor, 10VisualEditor-MediaWiki, 7Performance: Investigate why VE is consistently **2-4X** slower to switch to Edit after switching back to Read the first time, compared to the first switch after load - https://phabricator.wikimedia.org/T127921#2058465 (10Esanders) How do I generate these numbers? T... [13:46:30] 10VisualEditor, 10VisualEditor-MediaWiki, 7Performance: Investigate why VE is consistently **2-4X** slower to switch to Edit after switching back to Read the first time, compared to the first switch after load - https://phabricator.wikimedia.org/T127921#2066467 (10Krinkle) Per 10VisualEditor: Delete page content when a redirection is created with the visual editor - https://phabricator.wikimedia.org/T128187#2066527 (10Trizek-WMF) [15:01:30] 10VisualEditor, 10VisualEditor-MediaWiki: User education blue dots fail ungracefully in Safari 8 - https://phabricator.wikimedia.org/T128133#2066619 (10Esanders) You'll need to use crossbrowsertesting.com - see office wiki for credentials. [15:05:35] 10VisualEditor, 10VisualEditor-MediaWiki: User education blue dots fail ungracefully in Safari 8 - https://phabricator.wikimedia.org/T128133#2066625 (10Esanders) I suspect we just need to add -webkit browser prefixes to our animation rules: http://caniuse.com/#search=animation . The -moz prefix hasn't been use... [15:23:22] Krenair, I'll fix the Safari 8 bug [15:34:34] (03PS1) 10Esanders: EducationPopupTool: Use vendor prefixes for animation [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/273463 (https://phabricator.wikimedia.org/T128133) [15:35:03] 10VisualEditor, 10VisualEditor-MediaWiki, 13Patch-For-Review: User education blue dots fail ungracefully in Safari 8 - https://phabricator.wikimedia.org/T128133#2066677 (10Esanders) After: {F3432627} [15:42:37] edsanders, thanks, will try safari through crossbrowsertesting [15:58:56] (03CR) 10Krinkle: [C: 04-1] ""This is extension.json, not package.json." wasn't just about the typo. The name of the extension is VisualEditor, not VisualEditor-MediaW" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/268801 (owner: 10Jforrester) [15:59:40] 10VisualEditor, 10VisualEditor-MediaWiki: Give a useful message in the theoretically-temporary blank edit screen - https://phabricator.wikimedia.org/T128028#2066715 (10Jdforrester-WMF) p:5Triage>3Normal [16:08:47] (03CR) 10Alex Monk: [C: 032] EducationPopupTool: Use vendor prefixes for animation [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/273463 (https://phabricator.wikimedia.org/T128133) (owner: 10Esanders) [16:10:51] 10VisualEditor, 10VisualEditor-MediaWiki, 13Patch-For-Review: User education blue dots fail ungracefully in Safari 8 - https://phabricator.wikimedia.org/T128133#2066732 (10AlexMonk-WMF) a:5AlexMonk-WMF>3Esanders Thanks Ed. [16:11:34] 10VisualEditor, 10VisualEditor-MediaWiki, 7Browser-Support-Apple-Safari: User education blue dots fail ungracefully in Safari 8 - https://phabricator.wikimedia.org/T128133#2066735 (10Jdforrester-WMF) 5Open>3Resolved p:5Triage>3Normal [16:17:44] 10Cite: Cite: Add namespace detection for automatically generated reference list - https://phabricator.wikimedia.org/T70324#2066745 (10Cenarium) Unfortunately, this can't be done with the ParserSectionCreate hook since refs are processed before it kicks in. AFAICT, this would require a new hook inside Preprocess... [16:19:20] (03Merged) 10jenkins-bot: EducationPopupTool: Use vendor prefixes for animation [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/273463 (https://phabricator.wikimedia.org/T128133) (owner: 10Esanders) [16:36:52] 10Cite: Cite: Provide a way for users to find articles which have the reference list inserted automatically - https://phabricator.wikimedia.org/T69700#717727 (10Cenarium) If we can't add a tracking category; what of a page_prop ? [16:56:48] (03PS1) 10Krinkle: Refine VisualEditorSupportCheck call and document pattern [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/273484 [16:57:54] (03PS2) 10Krinkle: Refine VisualEditorSupportCheck call and document pattern [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/273484 [16:58:29] (03CR) 10Jforrester: "This is a breaking change and should be flagged as such." [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/273484 (owner: 10Krinkle) [16:58:57] (03CR) 10Krinkle: "It is not remotely a breaking change. Why do you think that?" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/273484 (owner: 10Krinkle) [16:59:22] Krinkle: window.VisualEditorSupportCheck is used in VE-MW. [16:59:29] James_F: that's fine. [16:59:32] window is the global object [16:59:48] just like window.jQuery or window.mw is equally functional, albeit odd. [17:00:00] Yes. [17:00:06] It works just fine. I'm just changing this call pattern to not use it [17:00:09] But it now won't be attached directly to the window? [17:00:12] it's still exposed as global via window as before [17:00:17] no code has changed in its definition [17:00:38] James_F: It is impossible for something to be global but not attached to window. [17:00:41] Oh, hmm. [17:00:47] However is in inappropiate to call them via window. [17:00:57] You've clearly done something better than me, because I tried this way and it didn't work. [17:00:58] like in PHP via $GLOBALS [17:01:09] (kind of) [17:01:18] Hmm. [17:01:32] Does jsdoc still work with this? [17:01:36] (In VE-MW) [17:01:47] Should be fine, but we'll see. [17:01:47] (03CR) 10jenkins-bot: [V: 04-1] Refine VisualEditorSupportCheck call and document pattern [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/273484 (owner: 10Krinkle) [17:01:57] Anyway, meeting. [17:02:21] 10Cite, 7Regression: without any on page does not trigger/display an error - https://phabricator.wikimedia.org/T123236#2066859 (10Cenarium) p:5Triage>3Lowest [17:02:56] (03PS3) 10Krinkle: Refine VisualEditorSupportCheck call and document pattern [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/273484 [17:03:33] James_F: It'll work fine in VE-MW the same way the existing callers before my change also worked in VE core. I've only updated callers, not definition. And we'll do the same update in VE-MW at some point. It's not an issue. [17:24:22] 10Cite, 10VisualEditor: Pressing enter or double clicking a template ref opens the basic reference editor, not the template editor - https://phabricator.wikimedia.org/T128198#2066894 (10Esanders) [17:25:28] 10VisualEditor, 6Community-Liaisons, 3Liaisons-February-2016: Review list of pages which receive the VE newsletter - https://phabricator.wikimedia.org/T125430#2066906 (10Elitre) 5Open>3Resolved [17:35:27] (03CR) 10Esanders: [C: 04-1] FindAndReplace: Avoid getNativeRange() optimisation [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/273433 (owner: 10Esanders) [17:52:42] (03PS2) 10Esanders: WindowAction: Don't emit position event [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/273439 [17:52:44] (03PS2) 10Esanders: FindAndReplace: Avoid getNativeRange() optimisation [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/273433 [17:52:46] (03PS2) 10Esanders: FindAndReplace: Keep results cache to reduce re-renderings [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/273440 [17:59:23] 10Cite, 10MediaWiki-API, 10MobileFrontend, 13Patch-For-Review, 3Reading-Web-Sprint-67-i: What is impact of storing references - https://phabricator.wikimedia.org/T126802#2066938 (10Jdlrobson) Let's go with Japanese wiki then! [18:13:26] (03CR) 10Alex Monk: "Cannot reproduce "on save, it loads the target article"" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/273391 (https://phabricator.wikimedia.org/T63861) (owner: 10Alex Monk) [19:07:26] (03PS3) 10Esanders: WindowAction: Don't emit position event [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/273439 [19:07:28] (03PS3) 10Esanders: FindAndReplace: Remove getNativeRange() optimisation [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/273433 [19:07:30] (03PS3) 10Esanders: FindAndReplace: Keep results cache to reduce re-renderings [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/273440 [19:13:28] (03CR) 10Esanders: [C: 04-1] "If you load ve, then go back to read mode there are two redirect blocks visible." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/273391 (https://phabricator.wikimedia.org/T63861) (owner: 10Alex Monk) [19:15:27] (03CR) 10Esanders: Show redirect target inside target (031 comment) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/273391 (https://phabricator.wikimedia.org/T63861) (owner: 10Alex Monk) [19:34:03] 10VisualEditor, 10VisualEditor-MediaWiki, 7Technical-Debt: It is unclear what is supposed to be stored in ve.init.platform.imageInfoCache - https://phabricator.wikimedia.org/T126081#2004170 (10Catrope) From grepping around, it looks like it's just `width`, `height`, and `mediaType`. [19:44:16] 10VisualEditor-MediaWiki-Plugins, 10MediaWiki-extensions-ProofreadPage, 6Wikisource, 7Community-Wishlist-Survey: Create a VisualEditor plugin to integrate with ProofreadPage - https://phabricator.wikimedia.org/T48580#2067248 (10coren) a:3coren I will be in Jerusalem, and will concentrate on coordinating... [19:53:41] 10VisualEditor-MediaWiki-Plugins, 10MediaWiki-extensions-ProofreadPage, 6Wikisource, 7Community-Wishlist-Survey: Create a VisualEditor plugin to integrate with ProofreadPage - https://phabricator.wikimedia.org/T48580#493794 (10Jdforrester-WMF) [20:16:15] (03PS1) 10Jforrester: [PULL THROUGH] Use new VisualEditorSupportCheck pattern [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/273510 [20:16:50] (03PS4) 10Jforrester: [BREAKING CHANGE] Refine VisualEditorSupportCheck call and document pattern [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/273484 (owner: 10Krinkle) [20:17:05] (03CR) 10Jforrester: [C: 032] "VE-MW pull-through patch is I7dc0c360b." [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/273484 (owner: 10Krinkle) [20:18:35] 10VisualEditor-MediaWiki-Plugins, 10MediaWiki-extensions-ProofreadPage, 6Wikisource, 7Community-Wishlist-Survey: Create a VisualEditor plugin to integrate with ProofreadPage - https://phabricator.wikimedia.org/T48580#2067349 (10Tpt) > I will be in Jerusalem, and will concentrate on coordinating work on thi... [20:22:20] (03CR) 10jenkins-bot: [V: 04-1] [PULL THROUGH] Use new VisualEditorSupportCheck pattern [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/273510 (owner: 10Jforrester) [20:25:08] (03Merged) 10jenkins-bot: [BREAKING CHANGE] Refine VisualEditorSupportCheck call and document pattern [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/273484 (owner: 10Krinkle) [20:28:42] 10Cite: Cite: Add namespace detection for automatically generated reference list - https://phabricator.wikimedia.org/T70324#730250 (10Cenarium) [20:28:51] 10Cite: Cite: Add namespace detection for automatically generated reference list - https://phabricator.wikimedia.org/T70324#730250 (10Cenarium) [20:29:06] 10Cite: Cite: Add namespace detection for automatically generated reference list - https://phabricator.wikimedia.org/T70324#730250 (10Cenarium) [20:32:47] (03PS2) 10Jforrester: Update VE core submodule to master (0371bbe) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/273510 [20:33:07] 10Cite: Cite: Provide a way for users to find articles which have the reference list inserted automatically - https://phabricator.wikimedia.org/T69700#2067408 (10Nemo_bis) >>! In T69700#2066784, @Cenarium wrote: > If we can't add a tracking category; what of a page_prop ? That's ok. [20:45:55] edsanders: what do you think of https://gerrit.wikimedia.org/r/#/c/261995/7/modules/ve-graph/ve.dm.MWGraphNode.js? [20:52:03] 10Citoid, 10VisualEditor: Insert a "bare" citatations in li-elements - https://phabricator.wikimedia.org/T128210#2067449 (10jeblad) [20:52:23] 10Citoid, 10VisualEditor: Insert a "bare" citatation in li-elements - https://phabricator.wikimedia.org/T128210#2067461 (10jeblad) [21:32:18] 10VisualEditor, 10VisualEditor-EditingTools, 10VisualEditor-MediaWiki-Links, 7Design: VisualEditor: Link input widget should have separate inputs for target and display text - https://phabricator.wikimedia.org/T55973#2067598 (10Cirdan) 5declined>3Open p:5Lowest>3Triage [21:33:57] 10VisualEditor, 10VisualEditor-EditingTools, 10VisualEditor-MediaWiki-Links, 7Design: VisualEditor: Link input widget should have separate inputs for target and display text - https://phabricator.wikimedia.org/T55973#578098 (10Cirdan) Sorry Jdforrester, I re-opened this task. I don't doubt that a lot of th... [23:15:22] 10VisualEditor, 6Collaboration-Team-Backlog, 10ContentTranslation-cxserver, 10Flow, and 3 others: Add Accept: header to your HTML requests to RESTBase/Parsoid as per T124365 - https://phabricator.wikimedia.org/T128231#2068016 (10ssastry) [23:29:13] 10VisualEditor: Add Accept: header to your HTML requests to RESTBase/Parsoid as per T124365 - https://phabricator.wikimedia.org/T128233#2068100 (10ssastry) [23:38:43] 10VisualEditor: VisualEditor: Add Accept: header to your HTML requests to RESTBase/Parsoid as per T124365 - https://phabricator.wikimedia.org/T128233#2068266 (10ssastry) [23:45:58] 10VisualEditor, 10VisualEditor-MediaWiki: VisualEditor: Add Accept: header to your HTML requests to RESTBase/Parsoid as per T124365 - https://phabricator.wikimedia.org/T128233#2068303 (10Jdforrester-WMF) [23:47:16] (03PS5) 10Alex Monk: Show redirect target inside target [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/273391 (https://phabricator.wikimedia.org/T63861) [23:52:24] (03CR) 10jenkins-bot: [V: 04-1] Show redirect target inside target [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/273391 (https://phabricator.wikimedia.org/T63861) (owner: 10Alex Monk)