[00:28:36] (03CR) 10Siebrand: [C: 031] "i18n/L10n reviewed." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/273391 (https://phabricator.wikimedia.org/T63861) (owner: 10Alex Monk) [00:36:31] 10Cite, 13Patch-For-Review, 5WMF-deploy-2016-03-01_(1.27.0-wmf.15): Request for mediawiki:Cite section preview references format change - https://phabricator.wikimedia.org/T127188#2087056 (10matmarex) So… @IKhitron, how is it now? [00:47:18] edsanders|away, if around, should i poke at https://gerrit.wikimedia.org/r/#/c/274850/ ? [02:06:59] (03PS1) 10Alex Monk: Try to fix handling of empty document on WTE->VE switch [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/274875 (https://phabricator.wikimedia.org/T128635) [02:07:11] 10VisualEditor, 10VisualEditor-MediaWiki, 13Patch-For-Review: Single Edit Tab: Switching to VE from WTE is not working when the page is empty, reloads WTE instead - https://phabricator.wikimedia.org/T128635#2087278 (10AlexMonk-WMF) a:3AlexMonk-WMF [02:21:36] 10VisualEditor, 10VisualEditor-Tables: VisualEditor: can't edit table content on huwiki main page - https://phabricator.wikimedia.org/T128825#2087291 (10Tgr) [02:39:10] (03PS1) 10Krinkle: ve.test.utils: Don't require QUnit expect() anymore [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/274880 [02:41:10] (03CR) 10Krinkle: [C: 031] Try to fix handling of empty document on WTE->VE switch [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/274875 (https://phabricator.wikimedia.org/T128635) (owner: 10Alex Monk) [02:42:45] (03PS1) 10Krinkle: ve.test.utils: Don't require QUnit expect() anymore [VisualEditor/VisualEditor] (REL1_26) - 10https://gerrit.wikimedia.org/r/274887 [02:46:24] (03CR) 10jenkins-bot: [V: 04-1] ve.test.utils: Don't require QUnit expect() anymore [VisualEditor/VisualEditor] (REL1_26) - 10https://gerrit.wikimedia.org/r/274887 (owner: 10Krinkle) [02:49:17] (03CR) 10Krinkle: "recheck" [VisualEditor/VisualEditor] (REL1_26) - 10https://gerrit.wikimedia.org/r/274887 (owner: 10Krinkle) [02:49:50] (03CR) 10Krinkle: [C: 032] "For CI" [VisualEditor/VisualEditor] (REL1_26) - 10https://gerrit.wikimedia.org/r/274887 (owner: 10Krinkle) [02:53:27] (03Merged) 10jenkins-bot: ve.test.utils: Don't require QUnit expect() anymore [VisualEditor/VisualEditor] (REL1_26) - 10https://gerrit.wikimedia.org/r/274887 (owner: 10Krinkle) [02:54:52] (03PS1) 10Krinkle: Update VE core submodule to REL1_26 (69b1878) [extensions/VisualEditor] (REL1_26) - 10https://gerrit.wikimedia.org/r/274890 [02:55:08] (03CR) 10Krinkle: [C: 032] "For CI. - T125335" [extensions/VisualEditor] (REL1_26) - 10https://gerrit.wikimedia.org/r/274890 (owner: 10Krinkle) [02:57:33] (03CR) 10Krinkle: [V: 032] "Forcing because of circular dependency with I6e5834c3098." [extensions/VisualEditor] (REL1_26) - 10https://gerrit.wikimedia.org/r/274890 (owner: 10Krinkle) [05:01:35] 10VisualEditor: VisualEditor should default to separate tabs until changed - https://phabricator.wikimedia.org/T128780#2087471 (10Tgr) I tried it on testwiki where I happened to have some recent wikitext edits, and got the same result. While it is possible that I opened and left VE on all three wikis since my la... [05:05:58] 10VisualEditor, 10VisualEditor-MediaWiki: VisualEditor: Toolbar "Save page" button is confusing as it merely opens the dialog to save the page - https://phabricator.wikimedia.org/T44138#2087474 (10Tgr) The whole save/preview/edit summary interface feels clunky and getting the way. I don't have a constructive s... [08:39:06] 10VisualEditor, 7I18n: [[MediaWiki:Visualeditor-preference-tabs/de]] i18n issue - https://phabricator.wikimedia.org/T128839#2087805 (10Kghbln) [08:42:15] 10VisualEditor, 7I18n: [[MediaWiki:Visualeditor-preference-tabs]] i18n issue - https://phabricator.wikimedia.org/T128839#2087808 (10Kghbln) [09:55:17] 10VisualEditor: Fire wikipage.diff hook when showing a diff in VE - https://phabricator.wikimedia.org/T128843#2087923 (10Schnark) [10:32:39] 10Cite, 13Patch-For-Review, 5WMF-deploy-2016-03-01_(1.27.0-wmf.15): Request for mediawiki:Cite section preview references format change - https://phabricator.wikimedia.org/T127188#2088007 (10IKhitron) No difference, @matmarex. Why are you asking? There wasn't any new release from Wednesday. [11:10:00] edsanders, check out your patch with a few improvements - works on links and doubleclick: http://vem4.wmflabs.org/wiki/Main_Page [11:10:43] edsanders, the only problem - for some reason the mouse cursor is not showing links as clickable, need a style change [11:18:49] 10VisualEditor: VisualEditor should default to separate tabs until changed - https://phabricator.wikimedia.org/T128780#2088092 (10Elitre) If you were logged-in on test2.wiki, sure you didn't reset your preferences lately? [11:38:02] 10VisualEditor: U+200E avoid people to remove a category with VE - https://phabricator.wikimedia.org/T128852#2088144 (10Trizek-WMF) [11:46:15] 10VisualEditor, 7Browser-Support-Internet-Explorer: Impossible to add a reference on IE11 - https://phabricator.wikimedia.org/T128854#2088191 (10Trizek-WMF) [11:52:21] edsanders, ok, styling fixed. You are welcome to +2 [11:52:34] :) [12:06:27] 10VisualEditor, 7Browser-Tests, 13Patch-For-Review: Fix language screenshots browser test on VisualEditor - https://phabricator.wikimedia.org/T119482#2088224 (10zeljkofilipin) a:5Vikassy>3zeljkofilipin [12:51:25] edsanders, thx, didn't see the PS9 [12:51:29] doing it now [12:58:28] edsanders, the css doesn't seem to work - http://vem3.wmflabs.org/wiki/Main_Page [13:38:07] edsanders, i think it was not the new code, but something messed up with the VE upgrade on vem3. I switched to a different instance with the recent VE, works good [13:55:24] 10VisualEditor: Use keyboards arriows with an inline template produces an unexpected behavior on VE. - https://phabricator.wikimedia.org/T128861#2088390 (10Trizek-WMF) [14:02:37] hi Everyone [14:03:02] i want to get familiar with the mediawiki visual editor code base [14:03:47] and want to implement a feature that is autocompletition for math latex [14:04:14] can anyone tell me how do i get started [14:06:44] sutirtha, i don't know much about VE, but shouldn't this feature be more generic? [14:07:28] sutirtha, for example, when designing graphs, you can use https://en.wikipedia.org/wiki/Special:GraphSandbox [14:07:38] and there, it shows graph changes as you type [14:07:45] but its not part of VE [14:08:47] so in other words - i would suggest implementing it as hooks to the codeeditor, and then it can be integrated into VE [14:11:42] (03Abandoned) 10Zfilipin: WIP [BrowserTest] Fix broken browser test [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/252409 (https://phabricator.wikimedia.org/T119482) (owner: 10Zfilipin) [14:22:30] (03Abandoned) 10Zfilipin: WIP Fix language screenshots browser test on VisualEditor [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/274749 (https://phabricator.wikimedia.org/T119482) (owner: 10Zfilipin) [14:23:59] 10VisualEditor: Use keyboards arrows with an inline template produces an unexpected behavior on VE. - https://phabricator.wikimedia.org/T128861#2088449 (10Aklapper) [14:25:31] (03CR) 10Zfilipin: "Looks like Gerrit does not like links to Jenkins jobs." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/274694 (https://phabricator.wikimedia.org/T128731) (owner: 10Zfilipin) [14:32:46] edsanders, i rebased on the styles and updated vem3 with the full screen, let me know if there is anything else to fix - git fetch https://gerrit.wikimedia.org/r/mediawiki/extensions/Kartographer refs/changes/50/274850/12 && git checkout FETCH_HEAD [14:32:51] i meant http://vem3.wmflabs.org/wiki/Main_Page [14:37:53] yurik: ok yurik i will into it and ask if i have any doubts [14:45:34] i just want autocompletion of math latex expressions in the dialog that opens in visual editor to enter the math formula [14:51:58] (03PS1) 10Zfilipin: [BrowserTest] Disable failing language screenshots [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/274955 (https://phabricator.wikimedia.org/T119482) [14:54:36] (03PS2) 10Zfilipin: [BrowserTest] Disable failing language screenshots [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/274955 (https://phabricator.wikimedia.org/T119482) [15:06:47] (03CR) 10Zfilipin: "Not sure what am I doing wrong, the test jobs is failing (0 scenarios). :|" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/274955 (https://phabricator.wikimedia.org/T119482) (owner: 10Zfilipin) [15:14:15] 10VisualEditor: On single edit tabs wikis, put SET options in the same order - https://phabricator.wikimedia.org/T128863#2088524 (10Elitre) [15:14:27] 10VisualEditor: On single edit tabs wikis, put SET options in the same order - https://phabricator.wikimedia.org/T128863#2088536 (10Elitre) p:5Triage>3Lowest [15:57:46] edsanders, did you speak with max re alignment? [16:34:57] just left comments [17:10:33] (03CR) 10Paladox: "recheck" [extensions/Citoid] - 10https://gerrit.wikimedia.org/r/274517 (owner: 10L10n-bot) [17:29:45] 10VisualEditor, 10VisualEditor-MediaWiki-References: "Re-use" does not allow changes specific to the new use (like correct page numbers, quotes) - https://phabricator.wikimedia.org/T96536#2088864 (10Elitre) It was pointed out at the German Wikipedia that anyone wanting to use VE as their main editor and workin... [17:54:18] 10VisualEditor, 10VisualEditor-MediaWiki, 6Community-Liaisons, 3Liaisons-March-2016: Publish messages about SET on pl.wiki, monitor for reactions and feedback - https://phabricator.wikimedia.org/T128499#2088994 (10Elitre) [17:54:40] 10VisualEditor, 10VisualEditor-MediaWiki, 6Community-Liaisons: Publish messages about SET on hu.wiki, monitor for reactions and feedback - https://phabricator.wikimedia.org/T126985#2089025 (10Elitre) [18:10:46] 10VisualEditor, 10VisualEditor-Tables: VisualEditor: can't edit table content on huwiki main page - https://phabricator.wikimedia.org/T128825#2089115 (10Elitre) Table editing is broken in Firefox, per T128282. Generally speaking, the home page is a bit different from common articles. The table certainly isn't... [18:13:57] 10VisualEditor, 10MediaWiki-extensions-ContentTranslation: ContentTranslation popup obscures VisualEditor popup - https://phabricator.wikimedia.org/T128793#2089123 (10Elitre) [18:14:02] 10VisualEditor, 10VisualEditor-MediaWiki, 7Design: Too many pop-ups before a user can start editing? - https://phabricator.wikimedia.org/T124294#2089124 (10Elitre) [18:21:42] https://phabricator.wikimedia.org/T124356#2089122 [18:22:22] "Thanks, VisualEditor" has become our equivalent of "thanks, Obama". [18:29:53] 10VisualEditor, 6Community-Liaisons, 3Liaisons-March-2016: Follow and facilitate community work around enabling the visual editor for newbies and IPs at de.wiki - https://phabricator.wikimedia.org/T128630#2089206 (10Elitre) [18:31:38] 10VisualEditor, 6Community-Liaisons, 3Liaisons-March-2016: Follow and facilitate community work around enabling the visual editor for newbies and IPs at de.wiki - https://phabricator.wikimedia.org/T128630#2081026 (10Elitre) [18:33:52] 10WikiEditor, 6Labs, 10MediaWiki-ResourceLoader, 10wikitech.wikimedia.org, 13Patch-For-Review: Wikitechwiki has 4xx responses to requests for some static assets inc. poweredby_mediawiki_88x31.png and WikiEditor's button-sprite.svg - https://phabricator.wikimedia.org/T128747#2089228 (10Jdforrester-WMF) p:... [18:34:02] 10VisualEditor, 10VisualEditor-MediaWiki, 6Community-Liaisons, 3Liaisons-March-2016: Publish messages about SET on hu.wiki, monitor for reactions and feedback - https://phabricator.wikimedia.org/T126985#2089233 (10Elitre) [18:36:11] 10VisualEditor, 6Community-Liaisons: Add a few things to the FAQ page for the visual editor - https://phabricator.wikimedia.org/T127822#2089244 (10Elitre) p:5Normal>3Low [18:36:37] Elitre: I don't quite understand? I don't think that task has anything to do with VE? [18:53:17] James_F: I think you had a tracking/blocking bug somewhere about being able to use OOUI on every page view? [18:53:30] legoktm: Yes. [18:53:46] # plz? :) I can't find it [18:54:04] https://phabricator.wikimedia.org/T113677 [18:54:16] Patience. :-) [18:54:36] oh, I thought there was a separate bug :P [18:54:51] thanks :) [18:55:37] 10VisualEditor: Buttons in save dialog leave too little space for caption - https://phabricator.wikimedia.org/T128890#2089406 (10MaxSem) [18:55:44] legoktm: At this point https://phabricator.wikimedia.org/T125725 looks like it may land Soon™, so… [18:57:10] ooh :D [19:01:35] 10Citoid, 10VisualEditor, 10scap, 10Scap3 (scap3-adoption): Deploy Citoid with scap3 - https://phabricator.wikimedia.org/T116337#2089452 (10mmodell) [19:55:07] 10VisualEditor, 10OOjs-UI, 13Patch-For-Review: Provide Ctrl+Enter as a keyboard shortcut to confirm OOui dialogs - https://phabricator.wikimedia.org/T125860#2089656 (10Jdforrester-WMF) a:3DLynch [20:24:11] Hello, I'm integrating visualeditor into a new CMS platform, and I was wondering if the wikipedia toolbar config is publicly available? I'm looking to customize the toolbar config to add some custom buttons [20:25:02] markgraves: Hey! It's a bit of a mess I'm afraid. We've got a task to write a proper API for it, but for now it's set statically in the relevant Target. [20:25:42] markgraves: See https://github.com/wikimedia/VisualEditor/blob/HEAD/src/init/ve.init.Target.js#L70 [20:26:43] Good deal. That is where I was looking and was planning to put it [20:26:53] Thank you @James_F [20:27:08] No worries. [20:27:21] markgraves: I'd be interested to hear about how well it works for you, and what else you'd need. [20:27:46] Where would I put the customization? [20:27:46] My email is mark@myire.com, happy to chat, give you a demo and show you more of what I'm doing [20:29:41] markgraves: To customise you can either over-ride it entirely (that's what we do within MediaWiki, see https://github.com/wikimedia/mediawiki-extensions-VisualEditor/blob/HEAD/modules/ve-mw/init/ve.init.mw.Target.js#L37 or do a hack to replace a group with something else (which I'd discourage, but…) like in the Cite extension currently: https://github.com/wikimedia/mediawiki-extensions-Cite/blob/HEAD/modules/ve-cite/ve.ui.MWRefere [20:29:41] nce.init.js [20:30:19] markgraves: If all you want to do is register a tool that goes into one of the groups (e.g. a new format option, a new text style, or a new node to insert) you can just register your code and it'll end up in the right group. [20:31:03] For instance https://github.com/wikimedia/mediawiki-extensions-Graph/blob/master/modules/ve-graph/ve.ui.MWGraphDialogTool.js is how the MediaWiki Graph extension adds itself. [20:32:24] Thanks @James_F, these are all great resources and I will look into them [20:32:58] The tough thing for me has been tracing the calls to determine what is the appropriate way for instantiating things, since there are a bunch of async calls. Don't know when to extend the prototype, override, etc [20:33:18] Oh, yeah. [20:33:51] We really need to write some documentation about how to integrate VE into an environment. The stand-alone demo is cute but uses a bunch of hacks and is entirely undocumented. [20:34:31] =) That would be amazing, I'd be happy to write a tutorial with some help if you can point me to people who wouldnt mind answering my questions [20:35:20] I'm always happy to answer, but I'm just the product manager. :-) Several of the people in this channel (especially the +V'ed people) know a bunch more than me, and can chip in. [20:39:54] @James_F in the demo, is there a simple way to move the save html button into the toolbar as opposed to the bar above? [20:42:04] markgraves: You'd want to register it as a action button [20:43:55] markgraves: It's a bit of a mess in VE-MW, because we have effectively two integrations (one each for the desktop and mobile views of the site). [20:44:42] Ok I'm looking into that [20:44:42] thank you [20:44:44] markgraves: https://github.com/wikimedia/mediawiki-extensions-VisualEditor/blob/HEAD/modules/ve-mw/init/ve.init.mw.ArticleTarget.js#L1482 is the shared code, and then e.g. https://github.com/wikimedia/mediawiki-extensions-VisualEditor/blob/HEAD/modules/ve-mw/init/targets/ve.init.mw.DesktopArticleTarget.js#L907 is a bit different for desktop. [20:44:55] thank you [20:44:55] Ok I'm looking into that [20:48:05] alrighty, thanks @James_F, I'm off to the grind [20:48:35] Have fun. :-) [21:04:16] 10VisualEditor: VisuaEditor popup for single tab is too small - https://phabricator.wikimedia.org/T128909#2089900 (10He7d3r) [21:52:32] 10VisualEditor: VisualEditor should default to separate tabs until changed - https://phabricator.wikimedia.org/T128780#2090047 (10Tgr) I never do that. Also I encountered this today on officewiki, where I also only used wikitext mode recently (even in Flow). Pretty sure this doesn't work the way you describe it. [21:52:47] Krinkle, would we ever deploy an html5 shiv? [21:54:13] 10VisualEditor, 10VisualEditor-Tables, 7Browser-Support-Firefox: [Regression FF43] In Firefox, double click on a cell makes the page jump down and doesn't allow to change cell contents - https://phabricator.wikimedia.org/T128282#2069433 (10Tgr) In some contexts, single click scrolls to bottom as well (and se... [21:54:34] edsanders: Probably not. Our JS-enabled browsers all support HTML5 (or will very soon). And even as a non-RL JS, we don't want basic reading experience to depend on html5 shiv. So for core layout elements, html5 shouldn't be used (and adds no value anyway), and for anything inline or some such, we can use it as is. It'll fallback gracefully. [21:55:05] assuming the reason for the shiv is css selectors, right? [21:55:08] I mean for styling [21:55:29] Yeah, so as long as it falls back nicely without styles it'll be fine. E.g. inline elements will just be plain text. [21:55:31] Which is okay for Grade C [21:55:35] 10VisualEditor, 10VisualEditor-Tables: VisualEditor: can't edit table content on huwiki main page - https://phabricator.wikimedia.org/T128825#2087291 (10Tgr) >>! In T128825#2089115, @Elitre wrote: > The fact that it's difficult to edit a transclusion which includes templates is covered at T71799 though. That... [21:55:44] edsanders: What element where you thinking of? [21:55:45] well for example Parsoid uses
, which means in IE8 all images are unstyled [21:56:08] https://app.crossbrowsertesting.com/public/i5ee2e3a9f223d95/screenshots/z74107d68b90a34f8e3d/z2280e52f001d5f1969a [21:56:40] Yeah, Parsoid should not currently be served as-is to browsers. [21:56:50] There's various mandatory transformations. [21:57:08] One of which, at least in early stages I imagine, will be to transform that into html compatible with current parser output [21:57:11] I'm talking about it in #mediawiki-parsoid [22:29:08] 10Cite, 10MobileFrontend, 3Reading-Web-Sprint-67-If, Then, Else...?: Create Special:Citations fallback for non-JavaScript/Resourceloader unsupported users - https://phabricator.wikimedia.org/T125897#2090155 (10Jdlrobson) I talked with @nirzar about this today. He is fine with just rendering the title and the... [22:35:46] (03PS27) 10Alex Monk: [WIP] Use widgets for wiki-page-name, wiki-user-name, wiki-template-name, boolean, URL and line template fields [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/169936 (https://phabricator.wikimedia.org/T55613) [22:35:58] (03CR) 10Alex Monk: "Florian: Thanks, should be fixed in PS27" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/169936 (https://phabricator.wikimedia.org/T55613) (owner: 10Alex Monk) [22:43:15] (03PS28) 10Alex Monk: [WIP] Use widgets for wiki-page-name, wiki-user-name, wiki-template-name, boolean, URL and line template fields [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/169936 (https://phabricator.wikimedia.org/T55613) [22:55:32] 10Cite, 10Citoid, 10VisualEditor, 10VisualEditor-MediaWiki-References, and 2 others: Save references in page_props and cache - https://phabricator.wikimedia.org/T125329#1984641 (10Krinkle) I've raised concerns about this in the past in Reading Web meetings and elsewhere. Just want to make sure this goes th... [22:55:47] (03PS29) 10Alex Monk: [WIP] Use widgets for wiki-page-name, wiki-user-name, wiki-template-name, boolean, URL and line template fields [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/169936 (https://phabricator.wikimedia.org/T55613) [22:58:47] ve.ui.LinkAnnotationWidget.prototype.createInputWidget documents a config option and then doesn't actually have one [22:58:49] subclass is the same [22:59:07] Wonderful [22:59:09] Which one? [22:59:39] Oh, the parameter is missing altogether [22:59:41] WTF [23:00:13] You'd think the config param would have to be passed through to the constructor call inside that function [23:00:39] You know, while I agree that the config.$ stuff was annoying and I'm glad we got rid of it, it did at least force us to maintain config object discipline [23:00:50] (03CR) 10jenkins-bot: [V: 04-1] [WIP] Use widgets for wiki-page-name, wiki-user-name, wiki-template-name, boolean, URL and line template fields [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/169936 (https://phabricator.wikimedia.org/T55613) (owner: 10Alex Monk) [23:01:10] In that world this would never have happened, because you'd take one look at new OO.ui.TextInputWidget( { validate: 'non-empty' } ); and go "that looks wrong, how is config.$ propagated" [23:01:57] (03PS30) 10Alex Monk: [WIP] Use widgets for wiki-page-name, wiki-user-name, wiki-template-name, boolean, URL and line template fields [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/169936 (https://phabricator.wikimedia.org/T55613) [23:02:04] RoanKattouw, this commit deals with the subclass [23:02:14] I'm not sure whether we should implement it or remove the documentation though [23:02:35] implementing it should just be a matter of a adding a .extend, which this commit will need to do anyway [23:02:58] (sort of, it's complicated because I'm moving that bit out into a static function) [23:03:00] Yes, I think you should implement it using extend [23:03:08] Also yeah I see you're static-ifying it [23:06:15] should it be implemented in VE core? [23:06:22] I think so [23:12:55] (03PS1) 10Alex Monk: LinkAnnotationWidget: Implement createInputWidget's documented config parameter [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/275127 [23:19:03] 10Cite, 10MobileFrontend, 3Reading-Web-Sprint-67-If, Then, Else...?: Create Special:Citations fallback for non-JavaScript/Resourceloader unsupported users - https://phabricator.wikimedia.org/T125897#2000071 (10Krinkle) >>! In T125897#2090155, @Jdlrobson wrote: > I talked with @nirzar about this today. > He i... [23:19:32] James_F: https://docs.google.com/spreadsheets/d/1uH1toow0ULoYRnC4VllgYpi0iWuHd2B-EGyAtG7yhiA/edit#gid=1665499061 - https://phabricator.wikimedia.org/T125897#2000071 - might find interesting [23:21:10] Krinkle: Won't Grade X get JS but it'll probably break? [23:21:32] Krinkle: E.g. IE Mobile 10 will execute JS. [23:21:53] Right, just fixed [23:21:57] non-RL is not C + X [23:22:03] Yup. [23:22:07] thx [23:22:22] Just me, keeping you honest. :-) [23:22:40] We should probably fix Grade X for browsers we 'like'. [23:23:20] FF/M 42/43 and IE/M 10/11 probably should match Grade A. [23:23:32] Want me to file a task? [23:23:50] Or is it not worth it given the work on feature-sniffed Grade A? [23:25:17] If those browsers behave properly, they will be equal to Grade A [23:25:34] Grade X is also in theory Iceweasel and Linux Chromium [23:25:41] and Pale Mone [23:25:44] Moon* [23:25:51] * James_F nods. [23:26:06] But they'll become Grade A eventually. [23:26:11] If we're gonna commit to actively testing there and treating issues with highest priority we can list them [23:26:24] 8.8% Grade X isn't great. [23:26:43] I see your point [23:26:49] on the other hand, Grade X working is also great. [23:27:02] (Not that it's your fault, of course.) [23:27:05] :-D [23:27:08] True. [23:27:20] How far away is feature-sniffed Grade A? [23:27:50] made some progress last week https://gerrit.wikimedia.org/r/#/c/218955/ [23:28:03] Did a bunch of cross browser testing to see the before/after difference [23:29:23] localStorage alone would be good enough [23:29:28] the other two tests are kind of obsolete [23:29:32] but good to keep for Grade X [23:29:55] and general feature reliance (I mean, we don't just do it to save regexes it's meant to be an actual feature test) [23:29:56] * James_F ndos. [23:30:09] However I'm worried about localStorage and privacy modes throwing or pretending it doesn't eixst [23:30:25] Firefox used to be weird about that, and it keeps changing on all browsers [23:30:30] Ori verbally pointed out that it might make sense to add the contentEditable test in there. [23:30:39] some are worried about exposing the fact that the user is in that mode, so they expose it but just don't persist the data [23:30:48] On the basis that if you're not getting VE, you're not getting the "full-feature experience" that we claim all Grade A users get. [23:30:48] others allow reading from before-private mode, but not writing [23:30:53] its' all horribly inconsistent [23:31:05] * James_F nods. [23:31:21] Browsers. Horribly Inconsistent since 1992.™ [23:32:09] Right. In 1990 the first browser was created and the second one in 1992-1993. [23:32:29] Yup. :-) [23:33:44] https://blog.whatwg.org/this-week-in-html-5-episode-30 [23:35:43] * James_F nods. [23:42:07] James_F: https://gerrit.wikimedia.org/r/#/c/274880/ ? [23:42:52] (03CR) 10Jforrester: [C: 032] ve.test.utils: Don't require QUnit expect() anymore [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/274880 (owner: 10Krinkle) [23:42:53] Krinkle: Oh, interesting. Merging. [23:43:13] Krinkle: Just left comments on https://gerrit.wikimedia.org/r/218955 [23:45:26] thx [23:45:45] Krinkle: Thank me by merging the VE-core -> VE-MW pull-through. [23:46:00] You're making one? [23:46:16] First that needs to merge, but then yes. [23:46:42] k [23:48:00] (03Merged) 10jenkins-bot: ve.test.utils: Don't require QUnit expect() anymore [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/274880 (owner: 10Krinkle) [23:59:33] (03PS1) 10Jforrester: Update VE core submodule to master (f77ac2b) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/275134 [23:59:43] Krinkle: ^^^ Please. [23:59:57] (03CR) 10Krinkle: [C: 032] Update VE core submodule to master (f77ac2b) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/275134 (owner: 10Jforrester)