[00:00:31] (03PS32) 10Alex Monk: Use widgets for wiki-page-name, wiki-user-name, wiki-template-name, boolean, URL and line template fields [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/169936 (https://phabricator.wikimedia.org/T55613) [00:01:17] 10VisualEditor: Fire wikipage.diff hook when showing a diff in VE - https://phabricator.wikimedia.org/T128843#2087923 (10Krenair) ```krenair@terbium:~$ mwgrep wikipage.diff ## Public wiki results mediawikiwiki MediaWiki:Gadget-rtrc.js (total: 1, shown: 1)``` [00:04:08] 10VisualEditor: How to switch the visual editor off in the mediawiki.org wiki? - https://phabricator.wikimedia.org/T128984#2091866 (10AlexMonk-WMF) ^ It should also give you the option of setting that preference when it first starts in SET mode [00:07:41] (03PS1) 10Alex Monk: Simplify showtabdialog logic a little bit [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/275269 [00:09:46] James_F, you didn't set wgVisualEditorSingleEditTabSwitchTime? [00:14:02] 10VisualEditor, 10VisualEditor-MediaWiki: Make the transition between read mode and edit mode seamless (no vertical shift) - https://phabricator.wikimedia.org/T128985#2091898 (10The_RedBurn) [01:43:54] 10VisualEditor, 6Research-and-Data: Add support for hashtags (URL parameter -> edit summary) - https://phabricator.wikimedia.org/T123529#2092042 (10mahmoud) So, did we make it onto the backlog? The #artandfeminism editathon is back again this year and their efforts reminded me. Hope we can have something for t... [02:08:29] 10TemplateData, 10VisualEditor, 7HHVM: TemplateData's PHP JSON validation isn't strict enough because WMF cluster's HHVM allows trailing commas - https://phabricator.wikimedia.org/T128029#2092083 (10ori) [02:40:27] 10TemplateData, 10VisualEditor, 7HHVM: TemplateData's PHP JSON validation isn't strict enough because WMF cluster's HHVM allows trailing commas - https://phabricator.wikimedia.org/T128029#2092144 (10ori) The reason for having two JSON stacks has its roots in a now-infamous clause in [[ http://www.json.org/li... [02:46:18] 10TemplateData, 10VisualEditor, 7HHVM: TemplateData's PHP JSON validation isn't strict enough because WMF cluster's HHVM allows trailing commas - https://phabricator.wikimedia.org/T128029#2092148 (10ori) By the way, it's not just HHVM that suffers from this licensing nightmare; see [[ https://bugs.php.net/bu... [03:52:46] 10TemplateData, 10VisualEditor, 7HHVM: TemplateData's PHP JSON validation isn't strict enough because WMF cluster's HHVM allows trailing commas - https://phabricator.wikimedia.org/T128029#2092214 (10EBernhardson) I took a look back over the code I submitted but I can't remember right now why that bit of code... [08:48:10] 10VisualEditor: VE causes infobox lines collide - https://phabricator.wikimedia.org/T129007#2092357 (10Magioladitis) [09:05:30] 10TemplateData, 10VisualEditor, 7HHVM: TemplateData's PHP JSON validation isn't strict enough because WMF cluster's HHVM allows trailing commas - https://phabricator.wikimedia.org/T128029#2092387 (10ori) My guess is that you were considering the possibility of replacing JSON with JSON-C entirely, by checking... [09:16:36] 10TemplateData, 10VisualEditor, 7HHVM: TemplateData's PHP JSON validation isn't strict enough because WMF cluster's HHVM allows trailing commas - https://phabricator.wikimedia.org/T128029#2092403 (10ori) This is a dupe of T107132, but since this task is currently active I'm merging T107132 into this task rat... [09:16:46] 10TemplateData, 10VisualEditor, 7HHVM: TemplateData's PHP JSON validation isn't strict enough because WMF cluster's HHVM allows trailing commas - https://phabricator.wikimedia.org/T128029#2092406 (10ori) [09:28:55] 10VisualEditor: Spell check and correction not working while editing table rows - https://phabricator.wikimedia.org/T129011#2092434 (1001tonythomas) [11:09:21] 10WikiEditor: Fallback messages get shown on RTL wikis with LTR user interface language - https://phabricator.wikimedia.org/T73661#750151 (10Zack) arwiki tweaks have been removed. Thanks [12:28:37] 10VisualEditor, 10VisualEditor-MediaWiki: Occasional "docserver-http: HTTP 404" when trying to save an edit made in the visual editor - https://phabricator.wikimedia.org/T123708#2092631 (10Mbch331) https://nl.wikipedia.org/wiki/Captain_America:_Civil_War 06-03-2016 13:28 CET Added infobox and categories [13:16:35] 10VisualEditor: Fire wikipage.diff hook when showing a diff in VE - https://phabricator.wikimedia.org/T128843#2092791 (10Esanders) What does it do @Krinkle ? [13:24:53] 10VisualEditor: Use keyboards arrows with an inline template produces an unexpected behavior on VE. - https://phabricator.wikimedia.org/T128861#2088390 (10Esanders) Probably a duplicate of T123608 [13:29:33] 10VisualEditor, 10MonoBook: VisualEditor progressive buttons are not visually distinct on Monobook - https://phabricator.wikimedia.org/T128577#2092802 (10Esanders) p:5Triage>3Low Apex is a slightly lower contrast theme - but it still stands out. [13:29:46] 10VisualEditor, 10MonoBook, 10OOjs-UI: VisualEditor progressive buttons are not visually distinct on Monobook - https://phabricator.wikimedia.org/T128577#2092804 (10Esanders) [13:30:51] 10VisualEditor, 10OOjs-UI, 10UI-Standardization: VisualEditor dialog button placement should be consistent with rest of MediaWiki - https://phabricator.wikimedia.org/T128576#2092805 (10Esanders) [13:51:50] (03PS1) 10Esanders: Search documentNode for unicorn, not document [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/275278 (https://phabricator.wikimedia.org/T128854) [14:14:21] (03PS1) 10Esanders: Add mode index cards before events are bound [extensions/Citoid] - 10https://gerrit.wikimedia.org/r/275280 (https://phabricator.wikimedia.org/T128854) [14:30:40] 10VisualEditor, 7Browser-Support-Internet-Explorer, 13Patch-For-Review: Impossible to add a reference on IE11 - https://phabricator.wikimedia.org/T128854#2092856 (10Esanders) p:5Triage>3Unbreak! [14:48:51] 10VisualEditor: IE11 throws exception on every transaction - https://phabricator.wikimedia.org/T129031#2092858 (10Esanders) [14:49:12] (03PS2) 10Esanders: Search documentNode for unicorn, not document [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/275278 (https://phabricator.wikimedia.org/T129031) [14:49:19] 10VisualEditor, 13Patch-For-Review: IE11 throws exception on every transaction - https://phabricator.wikimedia.org/T129031#2092874 (10Esanders) [14:49:21] 10VisualEditor, 7Browser-Support-Internet-Explorer, 13Patch-For-Review: Impossible to add a reference on IE11 - https://phabricator.wikimedia.org/T128854#2092873 (10Esanders) [14:49:29] 10VisualEditor, 13Patch-For-Review: IE11 throws exception on every transaction - https://phabricator.wikimedia.org/T129031#2092858 (10Esanders) p:5Triage>3Unbreak! [15:57:21] (03CR) 10Physikerwelt: [C: 031] "makes sense to me" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/275278 (https://phabricator.wikimedia.org/T129031) (owner: 10Esanders) [16:24:26] (03PS1) 10Esanders: Use normal whitespace for focusable nodes [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/275290 [16:28:28] (03CR) 10jenkins-bot: [V: 04-1] Use normal whitespace for focusable nodes [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/275290 (owner: 10Esanders) [16:39:30] 10VisualEditor, 10VisualEditor-Tables: Pasting into a table selection should repeat to fill the selection - https://phabricator.wikimedia.org/T129034#2092978 (10Esanders) [16:44:31] (03PS1) 10Esanders: Use iconWhenInvisible for alien extension nodes [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/275292 [17:31:48] 10VisualEditor: VisualEditor uses an oldid of the page when reediting it - https://phabricator.wikimedia.org/T129038#2093062 (10Kvardek_du) [17:32:04] 10VisualEditor: VisualEditor uses an oldid of the page when reediting it - https://phabricator.wikimedia.org/T129038#2093075 (10Kvardek_du) p:5Triage>3High [17:56:57] 10VisualEditor: VisualEditor uses an oldid of the page when reediting it - https://phabricator.wikimedia.org/T129038#2093062 (10Lemondoge) {meme, src=farmer} [18:30:20] 10VisualEditor: Fire wikipage.diff hook when showing a diff in VE - https://phabricator.wikimedia.org/T128843#2093095 (10Krinkle) RTRC is a producer, not a consumer. See [Krinkle/mw-gadget-rtrc@e3044c6](https://github.com/Krinkle/mw-gadget-rtrc/commit/e3044c68506b21b8b873c80428d25f7375f87002) and [Krinkle/mw-gad... [18:34:05] edsanders, that button takes too much space. Can you put it next to the size? [18:34:24] with smaller screens, the geojson will have too little space [18:34:51] edsanders, and eventually, it would be great if there would be just two buttons - undo adn redo [18:35:09] and every change (scroll around, change to geojson, etc) can be undo/redon [18:41:25] 10VisualEditor, 10VisualEditor-MediaWiki, 10MediaWiki-General-or-Unknown, 13Patch-For-Review: Feedback tool displays/links the wrong target for page link when it's cross-wiki - https://phabricator.wikimedia.org/T125400#1986578 (10Sjoerddebruin) See https://www.wikidata.org/w/index.php?title=Wikidata:Contac... [18:44:01] 10WikiEditor: Fallback messages get shown on RTL wikis with LTR user interface language - https://phabricator.wikimedia.org/T73661#2093110 (10Fomafix) 5Open>3Resolved a:3Fomafix [19:21:47] (03PS9) 10Alex Monk: [WIP] Allow TemplateData to output information about magic words [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/140445 (https://phabricator.wikimedia.org/T51996) [19:23:02] (03CR) 10jenkins-bot: [V: 04-1] [WIP] Allow TemplateData to output information about magic words [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/140445 (https://phabricator.wikimedia.org/T51996) (owner: 10Alex Monk) [19:23:24] (03PS10) 10Alex Monk: [WIP] Allow TemplateData to output information about magic words [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/140445 (https://phabricator.wikimedia.org/T51996) [19:25:02] (03PS11) 10Alex Monk: [WIP] Allow TemplateData to output information about magic words [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/140445 (https://phabricator.wikimedia.org/T51996) [19:25:18] (03CR) 10jenkins-bot: [V: 04-1] [WIP] Allow TemplateData to output information about magic words [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/140445 (https://phabricator.wikimedia.org/T51996) (owner: 10Alex Monk) [21:55:44] Does anyone have a guide on how to add the insert image dialog as acomponent? [21:56:01] or can anyone point me to where I can see how this is done in mediawiki? [23:12:49] markgraves: hey [23:13:12] markgraves: the implementation in WikiEditor (the wikitext one) is probably a lot simpler than in VisualEditor [23:14:07] markgraves: https://phabricator.wikimedia.org/rEWED5ea5952cd11bd384a54c22bdc3b138372f8c4cf0 [23:14:47] Thank you [23:14:53] I'm trying to get up to speed to be able to help [23:15:07] but I'm still struggling my way around the internals =) [23:15:15] markgraves: VisualEditor does some fancy/weird stuff to display the two tabs inside the dialog [23:16:38] any suggestions for where to find docs / how to navigate? [23:17:28] for the upload dialog? i'm afraid there isn't much [23:17:47] https://www.mediawiki.org/wiki/Upload_dialog has some end-user documentation, and links to docs generated from code comments (at the bottom) [23:17:58] i think that's all there is [23:19:03] or the visualeditor in general? [23:19:29] I worked through the demos pretty quick, but understanding the internals is still a bit lost on me [23:20:10] I'm trying to figure out the order of events firing... [23:20:16] James_F|Away, Krenair Looking at VE/Feedback page and the discussion about subst:, looks like it is https://phabricator.wikimedia.org/T51904 ... [23:21:19] ah, i don't know that much about VisualEditor, sorry :( [23:22:18] markgraves: this could be of some use. https://www.mediawiki.org/wiki/VisualEditor/Gadgets [23:22:22] James_F|Away, Krenair ah .. looks like Salixalba already pointed that out. I missed that. ok, back to enjoying my sunday evening. :-) [23:22:43] =) no worries thank you matmarex